http://git-wip-us.apache.org/repos/asf/hbase-site/blob/d917c66a/testdevapidocs/src-html/org/apache/hadoop/hbase/util/TestHBaseFsckOneRS.html ---------------------------------------------------------------------- diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/util/TestHBaseFsckOneRS.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/util/TestHBaseFsckOneRS.html index b90f5dc..5fb70d8 100644 --- a/testdevapidocs/src-html/org/apache/hadoop/hbase/util/TestHBaseFsckOneRS.html +++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/util/TestHBaseFsckOneRS.html @@ -54,1492 +54,1772 @@ <span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.coprocessor.CoprocessorHost;<a name="line.46"></a> <span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.io.hfile.TestHFile;<a name="line.47"></a> <span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.master.AssignmentManager;<a name="line.48"></a> -<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.master.RegionStates;<a name="line.49"></a> -<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.master.TableLockManager;<a name="line.50"></a> -<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.regionserver.HRegion;<a name="line.51"></a> -<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.regionserver.HRegionServer;<a name="line.52"></a> -<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction;<a name="line.53"></a> -<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.replication.ReplicationFactory;<a name="line.54"></a> -<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.replication.ReplicationQueues;<a name="line.55"></a> -<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.testclassification.LargeTests;<a name="line.56"></a> -<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.testclassification.MiscTests;<a name="line.57"></a> -<span class="sourceLineNo">058</span>import org.apache.hadoop.hbase.util.hbck.HFileCorruptionChecker;<a name="line.58"></a> -<span class="sourceLineNo">059</span>import org.apache.hadoop.hbase.util.hbck.HbckTestingUtil;<a name="line.59"></a> -<span class="sourceLineNo">060</span>import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher;<a name="line.60"></a> -<span class="sourceLineNo">061</span>import org.junit.AfterClass;<a name="line.61"></a> -<span class="sourceLineNo">062</span>import org.junit.Assert;<a name="line.62"></a> -<span class="sourceLineNo">063</span>import org.junit.Before;<a name="line.63"></a> -<span class="sourceLineNo">064</span>import org.junit.BeforeClass;<a name="line.64"></a> -<span class="sourceLineNo">065</span>import org.junit.Test;<a name="line.65"></a> -<span class="sourceLineNo">066</span>import org.junit.experimental.categories.Category;<a name="line.66"></a> -<span class="sourceLineNo">067</span><a name="line.67"></a> -<span class="sourceLineNo">068</span>import java.io.IOException;<a name="line.68"></a> -<span class="sourceLineNo">069</span>import java.util.ArrayList;<a name="line.69"></a> -<span class="sourceLineNo">070</span>import java.util.LinkedList;<a name="line.70"></a> -<span class="sourceLineNo">071</span>import java.util.List;<a name="line.71"></a> -<span class="sourceLineNo">072</span>import java.util.concurrent.Callable;<a name="line.72"></a> -<span class="sourceLineNo">073</span>import java.util.concurrent.CountDownLatch;<a name="line.73"></a> -<span class="sourceLineNo">074</span>import java.util.concurrent.ExecutorService;<a name="line.74"></a> -<span class="sourceLineNo">075</span>import java.util.concurrent.Executors;<a name="line.75"></a> -<span class="sourceLineNo">076</span>import java.util.concurrent.Future;<a name="line.76"></a> -<span class="sourceLineNo">077</span>import java.util.concurrent.ScheduledThreadPoolExecutor;<a name="line.77"></a> -<span class="sourceLineNo">078</span>import java.util.concurrent.SynchronousQueue;<a name="line.78"></a> -<span class="sourceLineNo">079</span>import java.util.concurrent.ThreadPoolExecutor;<a name="line.79"></a> -<span class="sourceLineNo">080</span>import java.util.concurrent.TimeUnit;<a name="line.80"></a> -<span class="sourceLineNo">081</span>import java.util.concurrent.atomic.AtomicBoolean;<a name="line.81"></a> -<span class="sourceLineNo">082</span><a name="line.82"></a> -<span class="sourceLineNo">083</span>import static org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.*;<a name="line.83"></a> -<span class="sourceLineNo">084</span>import static org.junit.Assert.*;<a name="line.84"></a> -<span class="sourceLineNo">085</span><a name="line.85"></a> -<span class="sourceLineNo">086</span>@Category({MiscTests.class, LargeTests.class})<a name="line.86"></a> -<span class="sourceLineNo">087</span>public class TestHBaseFsckOneRS extends BaseTestHBaseFsck {<a name="line.87"></a> +<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.master.RegionState;<a name="line.49"></a> +<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.master.RegionStates;<a name="line.50"></a> +<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.master.TableLockManager;<a name="line.51"></a> +<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.regionserver.HRegion;<a name="line.52"></a> +<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.regionserver.HRegionServer;<a name="line.53"></a> +<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.regionserver.SplitTransactionImpl;<a name="line.54"></a> +<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.regionserver.SplitTransactionFactory;<a name="line.55"></a> +<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction;<a name="line.56"></a> +<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.replication.ReplicationFactory;<a name="line.57"></a> +<span class="sourceLineNo">058</span>import org.apache.hadoop.hbase.replication.ReplicationQueues;<a name="line.58"></a> +<span class="sourceLineNo">059</span>import org.apache.hadoop.hbase.testclassification.LargeTests;<a name="line.59"></a> +<span class="sourceLineNo">060</span>import org.apache.hadoop.hbase.testclassification.MiscTests;<a name="line.60"></a> +<span class="sourceLineNo">061</span>import org.apache.hadoop.hbase.util.hbck.HFileCorruptionChecker;<a name="line.61"></a> +<span class="sourceLineNo">062</span>import org.apache.hadoop.hbase.util.hbck.HbckTestingUtil;<a name="line.62"></a> +<span class="sourceLineNo">063</span>import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher;<a name="line.63"></a> +<span class="sourceLineNo">064</span>import org.junit.AfterClass;<a name="line.64"></a> +<span class="sourceLineNo">065</span>import org.junit.Assert;<a name="line.65"></a> +<span class="sourceLineNo">066</span>import org.junit.Before;<a name="line.66"></a> +<span class="sourceLineNo">067</span>import org.junit.BeforeClass;<a name="line.67"></a> +<span class="sourceLineNo">068</span>import org.junit.Ignore;<a name="line.68"></a> +<span class="sourceLineNo">069</span>import org.junit.Test;<a name="line.69"></a> +<span class="sourceLineNo">070</span>import org.junit.experimental.categories.Category;<a name="line.70"></a> +<span class="sourceLineNo">071</span><a name="line.71"></a> +<span class="sourceLineNo">072</span>import java.io.IOException;<a name="line.72"></a> +<span class="sourceLineNo">073</span>import java.util.ArrayList;<a name="line.73"></a> +<span class="sourceLineNo">074</span>import java.util.LinkedList;<a name="line.74"></a> +<span class="sourceLineNo">075</span>import java.util.List;<a name="line.75"></a> +<span class="sourceLineNo">076</span>import java.util.HashMap;<a name="line.76"></a> +<span class="sourceLineNo">077</span>import java.util.Map;<a name="line.77"></a> +<span class="sourceLineNo">078</span>import java.util.concurrent.Callable;<a name="line.78"></a> +<span class="sourceLineNo">079</span>import java.util.concurrent.CountDownLatch;<a name="line.79"></a> +<span class="sourceLineNo">080</span>import java.util.concurrent.ExecutorService;<a name="line.80"></a> +<span class="sourceLineNo">081</span>import java.util.concurrent.Executors;<a name="line.81"></a> +<span class="sourceLineNo">082</span>import java.util.concurrent.Future;<a name="line.82"></a> +<span class="sourceLineNo">083</span>import java.util.concurrent.ScheduledThreadPoolExecutor;<a name="line.83"></a> +<span class="sourceLineNo">084</span>import java.util.concurrent.SynchronousQueue;<a name="line.84"></a> +<span class="sourceLineNo">085</span>import java.util.concurrent.ThreadPoolExecutor;<a name="line.85"></a> +<span class="sourceLineNo">086</span>import java.util.concurrent.TimeUnit;<a name="line.86"></a> +<span class="sourceLineNo">087</span>import java.util.concurrent.atomic.AtomicBoolean;<a name="line.87"></a> <span class="sourceLineNo">088</span><a name="line.88"></a> -<span class="sourceLineNo">089</span> @BeforeClass<a name="line.89"></a> -<span class="sourceLineNo">090</span> public static void setUpBeforeClass() throws Exception {<a name="line.90"></a> -<span class="sourceLineNo">091</span> TEST_UTIL.getConfiguration().set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY,<a name="line.91"></a> -<span class="sourceLineNo">092</span> MasterSyncObserver.class.getName());<a name="line.92"></a> -<span class="sourceLineNo">093</span><a name="line.93"></a> -<span class="sourceLineNo">094</span> conf.setInt("hbase.regionserver.handler.count", 2);<a name="line.94"></a> -<span class="sourceLineNo">095</span> conf.setInt("hbase.regionserver.metahandler.count", 30);<a name="line.95"></a> -<span class="sourceLineNo">096</span><a name="line.96"></a> -<span class="sourceLineNo">097</span> conf.setInt("hbase.htable.threads.max", POOL_SIZE);<a name="line.97"></a> -<span class="sourceLineNo">098</span> conf.setInt("hbase.hconnection.threads.max", 2 * POOL_SIZE);<a name="line.98"></a> -<span class="sourceLineNo">099</span> conf.setInt("hbase.hconnection.threads.core", POOL_SIZE);<a name="line.99"></a> -<span class="sourceLineNo">100</span> conf.setInt("hbase.hbck.close.timeout", 2 * REGION_ONLINE_TIMEOUT);<a name="line.100"></a> -<span class="sourceLineNo">101</span> conf.setInt(HConstants.HBASE_RPC_TIMEOUT_KEY, 8 * REGION_ONLINE_TIMEOUT);<a name="line.101"></a> -<span class="sourceLineNo">102</span> TEST_UTIL.startMiniCluster(1);<a name="line.102"></a> -<span class="sourceLineNo">103</span><a name="line.103"></a> -<span class="sourceLineNo">104</span> tableExecutorService = new ThreadPoolExecutor(1, POOL_SIZE, 60, TimeUnit.SECONDS,<a name="line.104"></a> -<span class="sourceLineNo">105</span> new SynchronousQueue<Runnable>(), Threads.newDaemonThreadFactory("testhbck"));<a name="line.105"></a> -<span class="sourceLineNo">106</span><a name="line.106"></a> -<span class="sourceLineNo">107</span> hbfsckExecutorService = new ScheduledThreadPoolExecutor(POOL_SIZE);<a name="line.107"></a> -<span class="sourceLineNo">108</span><a name="line.108"></a> -<span class="sourceLineNo">109</span> AssignmentManager assignmentManager =<a name="line.109"></a> -<span class="sourceLineNo">110</span> TEST_UTIL.getHBaseCluster().getMaster().getAssignmentManager();<a name="line.110"></a> -<span class="sourceLineNo">111</span> regionStates = assignmentManager.getRegionStates();<a name="line.111"></a> +<span class="sourceLineNo">089</span>import static org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.*;<a name="line.89"></a> +<span class="sourceLineNo">090</span>import static org.junit.Assert.*;<a name="line.90"></a> +<span class="sourceLineNo">091</span><a name="line.91"></a> +<span class="sourceLineNo">092</span>@Category({MiscTests.class, LargeTests.class})<a name="line.92"></a> +<span class="sourceLineNo">093</span>public class TestHBaseFsckOneRS extends BaseTestHBaseFsck {<a name="line.93"></a> +<span class="sourceLineNo">094</span><a name="line.94"></a> +<span class="sourceLineNo">095</span> @BeforeClass<a name="line.95"></a> +<span class="sourceLineNo">096</span> public static void setUpBeforeClass() throws Exception {<a name="line.96"></a> +<span class="sourceLineNo">097</span> TEST_UTIL.getConfiguration().set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY,<a name="line.97"></a> +<span class="sourceLineNo">098</span> MasterSyncObserver.class.getName());<a name="line.98"></a> +<span class="sourceLineNo">099</span><a name="line.99"></a> +<span class="sourceLineNo">100</span> conf.setInt("hbase.regionserver.handler.count", 2);<a name="line.100"></a> +<span class="sourceLineNo">101</span> conf.setInt("hbase.regionserver.metahandler.count", 30);<a name="line.101"></a> +<span class="sourceLineNo">102</span><a name="line.102"></a> +<span class="sourceLineNo">103</span> conf.setInt("hbase.htable.threads.max", POOL_SIZE);<a name="line.103"></a> +<span class="sourceLineNo">104</span> conf.setInt("hbase.hconnection.threads.max", 2 * POOL_SIZE);<a name="line.104"></a> +<span class="sourceLineNo">105</span> conf.setInt("hbase.hconnection.threads.core", POOL_SIZE);<a name="line.105"></a> +<span class="sourceLineNo">106</span> conf.setInt("hbase.hbck.close.timeout", 2 * REGION_ONLINE_TIMEOUT);<a name="line.106"></a> +<span class="sourceLineNo">107</span> conf.setInt(HConstants.HBASE_RPC_TIMEOUT_KEY, 8 * REGION_ONLINE_TIMEOUT);<a name="line.107"></a> +<span class="sourceLineNo">108</span> TEST_UTIL.startMiniCluster(1);<a name="line.108"></a> +<span class="sourceLineNo">109</span><a name="line.109"></a> +<span class="sourceLineNo">110</span> tableExecutorService = new ThreadPoolExecutor(1, POOL_SIZE, 60, TimeUnit.SECONDS,<a name="line.110"></a> +<span class="sourceLineNo">111</span> new SynchronousQueue<Runnable>(), Threads.newDaemonThreadFactory("testhbck"));<a name="line.111"></a> <span class="sourceLineNo">112</span><a name="line.112"></a> -<span class="sourceLineNo">113</span> connection = (ClusterConnection) TEST_UTIL.getConnection();<a name="line.113"></a> +<span class="sourceLineNo">113</span> hbfsckExecutorService = new ScheduledThreadPoolExecutor(POOL_SIZE);<a name="line.113"></a> <span class="sourceLineNo">114</span><a name="line.114"></a> -<span class="sourceLineNo">115</span> admin = connection.getAdmin();<a name="line.115"></a> -<span class="sourceLineNo">116</span> admin.setBalancerRunning(false, true);<a name="line.116"></a> -<span class="sourceLineNo">117</span><a name="line.117"></a> -<span class="sourceLineNo">118</span> TEST_UTIL.waitUntilAllRegionsAssigned(TableName.META_TABLE_NAME);<a name="line.118"></a> -<span class="sourceLineNo">119</span> TEST_UTIL.waitUntilAllRegionsAssigned(TableName.NAMESPACE_TABLE_NAME);<a name="line.119"></a> -<span class="sourceLineNo">120</span> }<a name="line.120"></a> -<span class="sourceLineNo">121</span><a name="line.121"></a> -<span class="sourceLineNo">122</span> @AfterClass<a name="line.122"></a> -<span class="sourceLineNo">123</span> public static void tearDownAfterClass() throws Exception {<a name="line.123"></a> -<span class="sourceLineNo">124</span> tableExecutorService.shutdown();<a name="line.124"></a> -<span class="sourceLineNo">125</span> hbfsckExecutorService.shutdown();<a name="line.125"></a> -<span class="sourceLineNo">126</span> admin.close();<a name="line.126"></a> -<span class="sourceLineNo">127</span> TEST_UTIL.shutdownMiniCluster();<a name="line.127"></a> -<span class="sourceLineNo">128</span> }<a name="line.128"></a> -<span class="sourceLineNo">129</span><a name="line.129"></a> -<span class="sourceLineNo">130</span> @Before<a name="line.130"></a> -<span class="sourceLineNo">131</span> public void setUp() {<a name="line.131"></a> -<span class="sourceLineNo">132</span> EnvironmentEdgeManager.reset();<a name="line.132"></a> -<span class="sourceLineNo">133</span> }<a name="line.133"></a> -<span class="sourceLineNo">134</span><a name="line.134"></a> +<span class="sourceLineNo">115</span> AssignmentManager assignmentManager =<a name="line.115"></a> +<span class="sourceLineNo">116</span> TEST_UTIL.getHBaseCluster().getMaster().getAssignmentManager();<a name="line.116"></a> +<span class="sourceLineNo">117</span> regionStates = assignmentManager.getRegionStates();<a name="line.117"></a> +<span class="sourceLineNo">118</span><a name="line.118"></a> +<span class="sourceLineNo">119</span> connection = (ClusterConnection) TEST_UTIL.getConnection();<a name="line.119"></a> +<span class="sourceLineNo">120</span><a name="line.120"></a> +<span class="sourceLineNo">121</span> admin = connection.getAdmin();<a name="line.121"></a> +<span class="sourceLineNo">122</span> admin.setBalancerRunning(false, true);<a name="line.122"></a> +<span class="sourceLineNo">123</span><a name="line.123"></a> +<span class="sourceLineNo">124</span> TEST_UTIL.waitUntilAllRegionsAssigned(TableName.META_TABLE_NAME);<a name="line.124"></a> +<span class="sourceLineNo">125</span> TEST_UTIL.waitUntilAllRegionsAssigned(TableName.NAMESPACE_TABLE_NAME);<a name="line.125"></a> +<span class="sourceLineNo">126</span> }<a name="line.126"></a> +<span class="sourceLineNo">127</span><a name="line.127"></a> +<span class="sourceLineNo">128</span> @AfterClass<a name="line.128"></a> +<span class="sourceLineNo">129</span> public static void tearDownAfterClass() throws Exception {<a name="line.129"></a> +<span class="sourceLineNo">130</span> tableExecutorService.shutdown();<a name="line.130"></a> +<span class="sourceLineNo">131</span> hbfsckExecutorService.shutdown();<a name="line.131"></a> +<span class="sourceLineNo">132</span> admin.close();<a name="line.132"></a> +<span class="sourceLineNo">133</span> TEST_UTIL.shutdownMiniCluster();<a name="line.133"></a> +<span class="sourceLineNo">134</span> }<a name="line.134"></a> <span class="sourceLineNo">135</span><a name="line.135"></a> -<span class="sourceLineNo">136</span> /**<a name="line.136"></a> -<span class="sourceLineNo">137</span> * This creates a clean table and confirms that the table is clean.<a name="line.137"></a> -<span class="sourceLineNo">138</span> */<a name="line.138"></a> -<span class="sourceLineNo">139</span> @Test(timeout=180000)<a name="line.139"></a> -<span class="sourceLineNo">140</span> public void testHBaseFsckClean() throws Exception {<a name="line.140"></a> -<span class="sourceLineNo">141</span> assertNoErrors(doFsck(conf, false));<a name="line.141"></a> -<span class="sourceLineNo">142</span> TableName table = TableName.valueOf("tableClean");<a name="line.142"></a> -<span class="sourceLineNo">143</span> try {<a name="line.143"></a> -<span class="sourceLineNo">144</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.144"></a> -<span class="sourceLineNo">145</span> assertNoErrors(hbck);<a name="line.145"></a> -<span class="sourceLineNo">146</span><a name="line.146"></a> -<span class="sourceLineNo">147</span> setupTable(table);<a name="line.147"></a> -<span class="sourceLineNo">148</span> assertEquals(ROWKEYS.length, countRows());<a name="line.148"></a> -<span class="sourceLineNo">149</span><a name="line.149"></a> -<span class="sourceLineNo">150</span> // We created 1 table, should be fine<a name="line.150"></a> -<span class="sourceLineNo">151</span> hbck = doFsck(conf, false);<a name="line.151"></a> -<span class="sourceLineNo">152</span> assertNoErrors(hbck);<a name="line.152"></a> -<span class="sourceLineNo">153</span> assertEquals(0, hbck.getOverlapGroups(table).size());<a name="line.153"></a> +<span class="sourceLineNo">136</span> @Before<a name="line.136"></a> +<span class="sourceLineNo">137</span> public void setUp() {<a name="line.137"></a> +<span class="sourceLineNo">138</span> EnvironmentEdgeManager.reset();<a name="line.138"></a> +<span class="sourceLineNo">139</span> }<a name="line.139"></a> +<span class="sourceLineNo">140</span><a name="line.140"></a> +<span class="sourceLineNo">141</span><a name="line.141"></a> +<span class="sourceLineNo">142</span> /**<a name="line.142"></a> +<span class="sourceLineNo">143</span> * This creates a clean table and confirms that the table is clean.<a name="line.143"></a> +<span class="sourceLineNo">144</span> */<a name="line.144"></a> +<span class="sourceLineNo">145</span> @Test(timeout=180000)<a name="line.145"></a> +<span class="sourceLineNo">146</span> public void testHBaseFsckClean() throws Exception {<a name="line.146"></a> +<span class="sourceLineNo">147</span> assertNoErrors(doFsck(conf, false));<a name="line.147"></a> +<span class="sourceLineNo">148</span> TableName table = TableName.valueOf("tableClean");<a name="line.148"></a> +<span class="sourceLineNo">149</span> try {<a name="line.149"></a> +<span class="sourceLineNo">150</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.150"></a> +<span class="sourceLineNo">151</span> assertNoErrors(hbck);<a name="line.151"></a> +<span class="sourceLineNo">152</span><a name="line.152"></a> +<span class="sourceLineNo">153</span> setupTable(table);<a name="line.153"></a> <span class="sourceLineNo">154</span> assertEquals(ROWKEYS.length, countRows());<a name="line.154"></a> -<span class="sourceLineNo">155</span> } finally {<a name="line.155"></a> -<span class="sourceLineNo">156</span> cleanupTable(table);<a name="line.156"></a> -<span class="sourceLineNo">157</span> }<a name="line.157"></a> -<span class="sourceLineNo">158</span> }<a name="line.158"></a> -<span class="sourceLineNo">159</span><a name="line.159"></a> -<span class="sourceLineNo">160</span> /**<a name="line.160"></a> -<span class="sourceLineNo">161</span> * Test thread pooling in the case where there are more regions than threads<a name="line.161"></a> -<span class="sourceLineNo">162</span> */<a name="line.162"></a> -<span class="sourceLineNo">163</span> @Test (timeout=180000)<a name="line.163"></a> -<span class="sourceLineNo">164</span> public void testHbckThreadpooling() throws Exception {<a name="line.164"></a> -<span class="sourceLineNo">165</span> TableName table =<a name="line.165"></a> -<span class="sourceLineNo">166</span> TableName.valueOf("tableDupeStartKey");<a name="line.166"></a> -<span class="sourceLineNo">167</span> try {<a name="line.167"></a> -<span class="sourceLineNo">168</span> // Create table with 4 regions<a name="line.168"></a> -<span class="sourceLineNo">169</span> setupTable(table);<a name="line.169"></a> -<span class="sourceLineNo">170</span><a name="line.170"></a> -<span class="sourceLineNo">171</span> // limit number of threads to 1.<a name="line.171"></a> -<span class="sourceLineNo">172</span> Configuration newconf = new Configuration(conf);<a name="line.172"></a> -<span class="sourceLineNo">173</span> newconf.setInt("hbasefsck.numthreads", 1);<a name="line.173"></a> -<span class="sourceLineNo">174</span> assertNoErrors(doFsck(newconf, false));<a name="line.174"></a> -<span class="sourceLineNo">175</span><a name="line.175"></a> -<span class="sourceLineNo">176</span> // We should pass without triggering a RejectedExecutionException<a name="line.176"></a> -<span class="sourceLineNo">177</span> } finally {<a name="line.177"></a> -<span class="sourceLineNo">178</span> cleanupTable(table);<a name="line.178"></a> -<span class="sourceLineNo">179</span> }<a name="line.179"></a> -<span class="sourceLineNo">180</span> }<a name="line.180"></a> +<span class="sourceLineNo">155</span><a name="line.155"></a> +<span class="sourceLineNo">156</span> // We created 1 table, should be fine<a name="line.156"></a> +<span class="sourceLineNo">157</span> hbck = doFsck(conf, false);<a name="line.157"></a> +<span class="sourceLineNo">158</span> assertNoErrors(hbck);<a name="line.158"></a> +<span class="sourceLineNo">159</span> assertEquals(0, hbck.getOverlapGroups(table).size());<a name="line.159"></a> +<span class="sourceLineNo">160</span> assertEquals(ROWKEYS.length, countRows());<a name="line.160"></a> +<span class="sourceLineNo">161</span> } finally {<a name="line.161"></a> +<span class="sourceLineNo">162</span> cleanupTable(table);<a name="line.162"></a> +<span class="sourceLineNo">163</span> }<a name="line.163"></a> +<span class="sourceLineNo">164</span> }<a name="line.164"></a> +<span class="sourceLineNo">165</span><a name="line.165"></a> +<span class="sourceLineNo">166</span> /**<a name="line.166"></a> +<span class="sourceLineNo">167</span> * Test thread pooling in the case where there are more regions than threads<a name="line.167"></a> +<span class="sourceLineNo">168</span> */<a name="line.168"></a> +<span class="sourceLineNo">169</span> @Test (timeout=180000)<a name="line.169"></a> +<span class="sourceLineNo">170</span> public void testHbckThreadpooling() throws Exception {<a name="line.170"></a> +<span class="sourceLineNo">171</span> TableName table =<a name="line.171"></a> +<span class="sourceLineNo">172</span> TableName.valueOf("tableDupeStartKey");<a name="line.172"></a> +<span class="sourceLineNo">173</span> try {<a name="line.173"></a> +<span class="sourceLineNo">174</span> // Create table with 4 regions<a name="line.174"></a> +<span class="sourceLineNo">175</span> setupTable(table);<a name="line.175"></a> +<span class="sourceLineNo">176</span><a name="line.176"></a> +<span class="sourceLineNo">177</span> // limit number of threads to 1.<a name="line.177"></a> +<span class="sourceLineNo">178</span> Configuration newconf = new Configuration(conf);<a name="line.178"></a> +<span class="sourceLineNo">179</span> newconf.setInt("hbasefsck.numthreads", 1);<a name="line.179"></a> +<span class="sourceLineNo">180</span> assertNoErrors(doFsck(newconf, false));<a name="line.180"></a> <span class="sourceLineNo">181</span><a name="line.181"></a> -<span class="sourceLineNo">182</span> @Test (timeout=180000)<a name="line.182"></a> -<span class="sourceLineNo">183</span> public void testTableWithNoRegions() throws Exception {<a name="line.183"></a> -<span class="sourceLineNo">184</span> // We might end up with empty regions in a table<a name="line.184"></a> -<span class="sourceLineNo">185</span> // see also testNoHdfsTable()<a name="line.185"></a> -<span class="sourceLineNo">186</span> TableName table =<a name="line.186"></a> -<span class="sourceLineNo">187</span> TableName.valueOf(name.getMethodName());<a name="line.187"></a> -<span class="sourceLineNo">188</span> try {<a name="line.188"></a> -<span class="sourceLineNo">189</span> // create table with one region<a name="line.189"></a> -<span class="sourceLineNo">190</span> HTableDescriptor desc = new HTableDescriptor(table);<a name="line.190"></a> -<span class="sourceLineNo">191</span> HColumnDescriptor hcd = new HColumnDescriptor(Bytes.toString(FAM));<a name="line.191"></a> -<span class="sourceLineNo">192</span> desc.addFamily(hcd); // If a table has no CF's it doesn't get checked<a name="line.192"></a> -<span class="sourceLineNo">193</span> createTable(TEST_UTIL, desc, null);<a name="line.193"></a> -<span class="sourceLineNo">194</span> tbl = connection.getTable(table, tableExecutorService);<a name="line.194"></a> -<span class="sourceLineNo">195</span><a name="line.195"></a> -<span class="sourceLineNo">196</span> // Mess it up by leaving a hole in the assignment, meta, and hdfs data<a name="line.196"></a> -<span class="sourceLineNo">197</span> deleteRegion(conf, tbl.getTableDescriptor(), HConstants.EMPTY_START_ROW,<a name="line.197"></a> -<span class="sourceLineNo">198</span> HConstants.EMPTY_END_ROW, false, false, true);<a name="line.198"></a> -<span class="sourceLineNo">199</span><a name="line.199"></a> -<span class="sourceLineNo">200</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.200"></a> -<span class="sourceLineNo">201</span> assertErrors(hbck, new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.NOT_IN_HDFS });<a name="line.201"></a> -<span class="sourceLineNo">202</span><a name="line.202"></a> -<span class="sourceLineNo">203</span> doFsck(conf, true);<a name="line.203"></a> -<span class="sourceLineNo">204</span><a name="line.204"></a> -<span class="sourceLineNo">205</span> // fix hole<a name="line.205"></a> -<span class="sourceLineNo">206</span> doFsck(conf, true);<a name="line.206"></a> -<span class="sourceLineNo">207</span><a name="line.207"></a> -<span class="sourceLineNo">208</span> // check that hole fixed<a name="line.208"></a> -<span class="sourceLineNo">209</span> assertNoErrors(doFsck(conf, false));<a name="line.209"></a> -<span class="sourceLineNo">210</span> } finally {<a name="line.210"></a> -<span class="sourceLineNo">211</span> cleanupTable(table);<a name="line.211"></a> -<span class="sourceLineNo">212</span> }<a name="line.212"></a> -<span class="sourceLineNo">213</span> }<a name="line.213"></a> -<span class="sourceLineNo">214</span><a name="line.214"></a> -<span class="sourceLineNo">215</span> @Test (timeout=180000)<a name="line.215"></a> -<span class="sourceLineNo">216</span> public void testHbckFixOrphanTable() throws Exception {<a name="line.216"></a> -<span class="sourceLineNo">217</span> TableName table = TableName.valueOf("tableInfo");<a name="line.217"></a> -<span class="sourceLineNo">218</span> FileSystem fs = null;<a name="line.218"></a> -<span class="sourceLineNo">219</span> Path tableinfo = null;<a name="line.219"></a> -<span class="sourceLineNo">220</span> try {<a name="line.220"></a> -<span class="sourceLineNo">221</span> setupTable(table);<a name="line.221"></a> -<span class="sourceLineNo">222</span><a name="line.222"></a> -<span class="sourceLineNo">223</span> Path hbaseTableDir = FSUtils.getTableDir(<a name="line.223"></a> -<span class="sourceLineNo">224</span> FSUtils.getRootDir(conf), table);<a name="line.224"></a> -<span class="sourceLineNo">225</span> fs = hbaseTableDir.getFileSystem(conf);<a name="line.225"></a> -<span class="sourceLineNo">226</span> FileStatus status = FSTableDescriptors.getTableInfoPath(fs, hbaseTableDir);<a name="line.226"></a> -<span class="sourceLineNo">227</span> tableinfo = status.getPath();<a name="line.227"></a> -<span class="sourceLineNo">228</span> fs.rename(tableinfo, new Path("/.tableinfo"));<a name="line.228"></a> -<span class="sourceLineNo">229</span><a name="line.229"></a> -<span class="sourceLineNo">230</span> //to report error if .tableinfo is missing.<a name="line.230"></a> -<span class="sourceLineNo">231</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.231"></a> -<span class="sourceLineNo">232</span> assertErrors(hbck, new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.NO_TABLEINFO_FILE });<a name="line.232"></a> -<span class="sourceLineNo">233</span><a name="line.233"></a> -<span class="sourceLineNo">234</span> // fix OrphanTable with default .tableinfo (htd not yet cached on master)<a name="line.234"></a> -<span class="sourceLineNo">235</span> hbck = doFsck(conf, true);<a name="line.235"></a> -<span class="sourceLineNo">236</span> assertNoErrors(hbck);<a name="line.236"></a> -<span class="sourceLineNo">237</span> status = null;<a name="line.237"></a> -<span class="sourceLineNo">238</span> status = FSTableDescriptors.getTableInfoPath(fs, hbaseTableDir);<a name="line.238"></a> -<span class="sourceLineNo">239</span> assertNotNull(status);<a name="line.239"></a> -<span class="sourceLineNo">240</span><a name="line.240"></a> -<span class="sourceLineNo">241</span> HTableDescriptor htd = admin.getTableDescriptor(table);<a name="line.241"></a> -<span class="sourceLineNo">242</span> htd.setValue("NOT_DEFAULT", "true");<a name="line.242"></a> -<span class="sourceLineNo">243</span> admin.disableTable(table);<a name="line.243"></a> -<span class="sourceLineNo">244</span> admin.modifyTable(table, htd);<a name="line.244"></a> -<span class="sourceLineNo">245</span> admin.enableTable(table);<a name="line.245"></a> -<span class="sourceLineNo">246</span> fs.delete(status.getPath(), true);<a name="line.246"></a> -<span class="sourceLineNo">247</span><a name="line.247"></a> -<span class="sourceLineNo">248</span> // fix OrphanTable with cache<a name="line.248"></a> -<span class="sourceLineNo">249</span> htd = admin.getTableDescriptor(table); // warms up cached htd on master<a name="line.249"></a> -<span class="sourceLineNo">250</span> hbck = doFsck(conf, true);<a name="line.250"></a> -<span class="sourceLineNo">251</span> assertNoErrors(hbck);<a name="line.251"></a> -<span class="sourceLineNo">252</span> status = FSTableDescriptors.getTableInfoPath(fs, hbaseTableDir);<a name="line.252"></a> -<span class="sourceLineNo">253</span> assertNotNull(status);<a name="line.253"></a> -<span class="sourceLineNo">254</span> htd = admin.getTableDescriptor(table);<a name="line.254"></a> -<span class="sourceLineNo">255</span> assertEquals(htd.getValue("NOT_DEFAULT"), "true");<a name="line.255"></a> -<span class="sourceLineNo">256</span> } finally {<a name="line.256"></a> -<span class="sourceLineNo">257</span> if (fs != null) {<a name="line.257"></a> -<span class="sourceLineNo">258</span> fs.rename(new Path("/.tableinfo"), tableinfo);<a name="line.258"></a> -<span class="sourceLineNo">259</span> }<a name="line.259"></a> -<span class="sourceLineNo">260</span> cleanupTable(table);<a name="line.260"></a> -<span class="sourceLineNo">261</span> }<a name="line.261"></a> -<span class="sourceLineNo">262</span> }<a name="line.262"></a> -<span class="sourceLineNo">263</span><a name="line.263"></a> -<span class="sourceLineNo">264</span> @Test (timeout=180000)<a name="line.264"></a> -<span class="sourceLineNo">265</span> public void testReadOnlyProperty() throws Exception {<a name="line.265"></a> -<span class="sourceLineNo">266</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.266"></a> -<span class="sourceLineNo">267</span> Assert.assertEquals("shouldIgnorePreCheckPermission", true,<a name="line.267"></a> -<span class="sourceLineNo">268</span> hbck.shouldIgnorePreCheckPermission());<a name="line.268"></a> +<span class="sourceLineNo">182</span> // We should pass without triggering a RejectedExecutionException<a name="line.182"></a> +<span class="sourceLineNo">183</span> } finally {<a name="line.183"></a> +<span class="sourceLineNo">184</span> cleanupTable(table);<a name="line.184"></a> +<span class="sourceLineNo">185</span> }<a name="line.185"></a> +<span class="sourceLineNo">186</span> }<a name="line.186"></a> +<span class="sourceLineNo">187</span><a name="line.187"></a> +<span class="sourceLineNo">188</span> @Test (timeout=180000)<a name="line.188"></a> +<span class="sourceLineNo">189</span> public void testTableWithNoRegions() throws Exception {<a name="line.189"></a> +<span class="sourceLineNo">190</span> // We might end up with empty regions in a table<a name="line.190"></a> +<span class="sourceLineNo">191</span> // see also testNoHdfsTable()<a name="line.191"></a> +<span class="sourceLineNo">192</span> TableName table =<a name="line.192"></a> +<span class="sourceLineNo">193</span> TableName.valueOf(name.getMethodName());<a name="line.193"></a> +<span class="sourceLineNo">194</span> try {<a name="line.194"></a> +<span class="sourceLineNo">195</span> // create table with one region<a name="line.195"></a> +<span class="sourceLineNo">196</span> HTableDescriptor desc = new HTableDescriptor(table);<a name="line.196"></a> +<span class="sourceLineNo">197</span> HColumnDescriptor hcd = new HColumnDescriptor(Bytes.toString(FAM));<a name="line.197"></a> +<span class="sourceLineNo">198</span> desc.addFamily(hcd); // If a table has no CF's it doesn't get checked<a name="line.198"></a> +<span class="sourceLineNo">199</span> createTable(TEST_UTIL, desc, null);<a name="line.199"></a> +<span class="sourceLineNo">200</span> tbl = connection.getTable(table, tableExecutorService);<a name="line.200"></a> +<span class="sourceLineNo">201</span><a name="line.201"></a> +<span class="sourceLineNo">202</span> // Mess it up by leaving a hole in the assignment, meta, and hdfs data<a name="line.202"></a> +<span class="sourceLineNo">203</span> deleteRegion(conf, tbl.getTableDescriptor(), HConstants.EMPTY_START_ROW,<a name="line.203"></a> +<span class="sourceLineNo">204</span> HConstants.EMPTY_END_ROW, false, false, true);<a name="line.204"></a> +<span class="sourceLineNo">205</span><a name="line.205"></a> +<span class="sourceLineNo">206</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.206"></a> +<span class="sourceLineNo">207</span> assertErrors(hbck, new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.NOT_IN_HDFS });<a name="line.207"></a> +<span class="sourceLineNo">208</span><a name="line.208"></a> +<span class="sourceLineNo">209</span> doFsck(conf, true);<a name="line.209"></a> +<span class="sourceLineNo">210</span><a name="line.210"></a> +<span class="sourceLineNo">211</span> // fix hole<a name="line.211"></a> +<span class="sourceLineNo">212</span> doFsck(conf, true);<a name="line.212"></a> +<span class="sourceLineNo">213</span><a name="line.213"></a> +<span class="sourceLineNo">214</span> // check that hole fixed<a name="line.214"></a> +<span class="sourceLineNo">215</span> assertNoErrors(doFsck(conf, false));<a name="line.215"></a> +<span class="sourceLineNo">216</span> } finally {<a name="line.216"></a> +<span class="sourceLineNo">217</span> cleanupTable(table);<a name="line.217"></a> +<span class="sourceLineNo">218</span> }<a name="line.218"></a> +<span class="sourceLineNo">219</span> }<a name="line.219"></a> +<span class="sourceLineNo">220</span><a name="line.220"></a> +<span class="sourceLineNo">221</span> @Test (timeout=180000)<a name="line.221"></a> +<span class="sourceLineNo">222</span> public void testHbckFixOrphanTable() throws Exception {<a name="line.222"></a> +<span class="sourceLineNo">223</span> TableName table = TableName.valueOf("tableInfo");<a name="line.223"></a> +<span class="sourceLineNo">224</span> FileSystem fs = null;<a name="line.224"></a> +<span class="sourceLineNo">225</span> Path tableinfo = null;<a name="line.225"></a> +<span class="sourceLineNo">226</span> try {<a name="line.226"></a> +<span class="sourceLineNo">227</span> setupTable(table);<a name="line.227"></a> +<span class="sourceLineNo">228</span><a name="line.228"></a> +<span class="sourceLineNo">229</span> Path hbaseTableDir = FSUtils.getTableDir(<a name="line.229"></a> +<span class="sourceLineNo">230</span> FSUtils.getRootDir(conf), table);<a name="line.230"></a> +<span class="sourceLineNo">231</span> fs = hbaseTableDir.getFileSystem(conf);<a name="line.231"></a> +<span class="sourceLineNo">232</span> FileStatus status = FSTableDescriptors.getTableInfoPath(fs, hbaseTableDir);<a name="line.232"></a> +<span class="sourceLineNo">233</span> tableinfo = status.getPath();<a name="line.233"></a> +<span class="sourceLineNo">234</span> fs.rename(tableinfo, new Path("/.tableinfo"));<a name="line.234"></a> +<span class="sourceLineNo">235</span><a name="line.235"></a> +<span class="sourceLineNo">236</span> //to report error if .tableinfo is missing.<a name="line.236"></a> +<span class="sourceLineNo">237</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.237"></a> +<span class="sourceLineNo">238</span> assertErrors(hbck, new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.NO_TABLEINFO_FILE });<a name="line.238"></a> +<span class="sourceLineNo">239</span><a name="line.239"></a> +<span class="sourceLineNo">240</span> // fix OrphanTable with default .tableinfo (htd not yet cached on master)<a name="line.240"></a> +<span class="sourceLineNo">241</span> hbck = doFsck(conf, true);<a name="line.241"></a> +<span class="sourceLineNo">242</span> assertNoErrors(hbck);<a name="line.242"></a> +<span class="sourceLineNo">243</span> status = null;<a name="line.243"></a> +<span class="sourceLineNo">244</span> status = FSTableDescriptors.getTableInfoPath(fs, hbaseTableDir);<a name="line.244"></a> +<span class="sourceLineNo">245</span> assertNotNull(status);<a name="line.245"></a> +<span class="sourceLineNo">246</span><a name="line.246"></a> +<span class="sourceLineNo">247</span> HTableDescriptor htd = admin.getTableDescriptor(table);<a name="line.247"></a> +<span class="sourceLineNo">248</span> htd.setValue("NOT_DEFAULT", "true");<a name="line.248"></a> +<span class="sourceLineNo">249</span> admin.disableTable(table);<a name="line.249"></a> +<span class="sourceLineNo">250</span> admin.modifyTable(table, htd);<a name="line.250"></a> +<span class="sourceLineNo">251</span> admin.enableTable(table);<a name="line.251"></a> +<span class="sourceLineNo">252</span> fs.delete(status.getPath(), true);<a name="line.252"></a> +<span class="sourceLineNo">253</span><a name="line.253"></a> +<span class="sourceLineNo">254</span> // fix OrphanTable with cache<a name="line.254"></a> +<span class="sourceLineNo">255</span> htd = admin.getTableDescriptor(table); // warms up cached htd on master<a name="line.255"></a> +<span class="sourceLineNo">256</span> hbck = doFsck(conf, true);<a name="line.256"></a> +<span class="sourceLineNo">257</span> assertNoErrors(hbck);<a name="line.257"></a> +<span class="sourceLineNo">258</span> status = FSTableDescriptors.getTableInfoPath(fs, hbaseTableDir);<a name="line.258"></a> +<span class="sourceLineNo">259</span> assertNotNull(status);<a name="line.259"></a> +<span class="sourceLineNo">260</span> htd = admin.getTableDescriptor(table);<a name="line.260"></a> +<span class="sourceLineNo">261</span> assertEquals(htd.getValue("NOT_DEFAULT"), "true");<a name="line.261"></a> +<span class="sourceLineNo">262</span> } finally {<a name="line.262"></a> +<span class="sourceLineNo">263</span> if (fs != null) {<a name="line.263"></a> +<span class="sourceLineNo">264</span> fs.rename(new Path("/.tableinfo"), tableinfo);<a name="line.264"></a> +<span class="sourceLineNo">265</span> }<a name="line.265"></a> +<span class="sourceLineNo">266</span> cleanupTable(table);<a name="line.266"></a> +<span class="sourceLineNo">267</span> }<a name="line.267"></a> +<span class="sourceLineNo">268</span> }<a name="line.268"></a> <span class="sourceLineNo">269</span><a name="line.269"></a> -<span class="sourceLineNo">270</span> hbck = doFsck(conf, true);<a name="line.270"></a> -<span class="sourceLineNo">271</span> Assert.assertEquals("shouldIgnorePreCheckPermission", false,<a name="line.271"></a> -<span class="sourceLineNo">272</span> hbck.shouldIgnorePreCheckPermission());<a name="line.272"></a> -<span class="sourceLineNo">273</span><a name="line.273"></a> -<span class="sourceLineNo">274</span> hbck = doFsck(conf, true);<a name="line.274"></a> -<span class="sourceLineNo">275</span> hbck.setIgnorePreCheckPermission(true);<a name="line.275"></a> -<span class="sourceLineNo">276</span> Assert.assertEquals("shouldIgnorePreCheckPermission", true,<a name="line.276"></a> -<span class="sourceLineNo">277</span> hbck.shouldIgnorePreCheckPermission());<a name="line.277"></a> -<span class="sourceLineNo">278</span> }<a name="line.278"></a> +<span class="sourceLineNo">270</span> @Test (timeout=180000)<a name="line.270"></a> +<span class="sourceLineNo">271</span> public void testReadOnlyProperty() throws Exception {<a name="line.271"></a> +<span class="sourceLineNo">272</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.272"></a> +<span class="sourceLineNo">273</span> Assert.assertEquals("shouldIgnorePreCheckPermission", true,<a name="line.273"></a> +<span class="sourceLineNo">274</span> hbck.shouldIgnorePreCheckPermission());<a name="line.274"></a> +<span class="sourceLineNo">275</span><a name="line.275"></a> +<span class="sourceLineNo">276</span> hbck = doFsck(conf, true);<a name="line.276"></a> +<span class="sourceLineNo">277</span> Assert.assertEquals("shouldIgnorePreCheckPermission", false,<a name="line.277"></a> +<span class="sourceLineNo">278</span> hbck.shouldIgnorePreCheckPermission());<a name="line.278"></a> <span class="sourceLineNo">279</span><a name="line.279"></a> -<span class="sourceLineNo">280</span> /**<a name="line.280"></a> -<span class="sourceLineNo">281</span> * This creates and fixes a bad table where a region is completely contained<a name="line.281"></a> -<span class="sourceLineNo">282</span> * by another region, and there is a hole (sort of like a bad split)<a name="line.282"></a> -<span class="sourceLineNo">283</span> */<a name="line.283"></a> -<span class="sourceLineNo">284</span> @Test (timeout=180000)<a name="line.284"></a> -<span class="sourceLineNo">285</span> public void testOverlapAndOrphan() throws Exception {<a name="line.285"></a> -<span class="sourceLineNo">286</span> TableName table =<a name="line.286"></a> -<span class="sourceLineNo">287</span> TableName.valueOf("tableOverlapAndOrphan");<a name="line.287"></a> -<span class="sourceLineNo">288</span> try {<a name="line.288"></a> -<span class="sourceLineNo">289</span> setupTable(table);<a name="line.289"></a> -<span class="sourceLineNo">290</span> assertEquals(ROWKEYS.length, countRows());<a name="line.290"></a> -<span class="sourceLineNo">291</span><a name="line.291"></a> -<span class="sourceLineNo">292</span> // Mess it up by creating an overlap in the metadata<a name="line.292"></a> -<span class="sourceLineNo">293</span> admin.disableTable(table);<a name="line.293"></a> -<span class="sourceLineNo">294</span> deleteRegion(conf, tbl.getTableDescriptor(), Bytes.toBytes("A"), Bytes.toBytes("B"), true,<a name="line.294"></a> -<span class="sourceLineNo">295</span> true, false, true, HRegionInfo.DEFAULT_REPLICA_ID);<a name="line.295"></a> -<span class="sourceLineNo">296</span> admin.enableTable(table);<a name="line.296"></a> +<span class="sourceLineNo">280</span> hbck = doFsck(conf, true);<a name="line.280"></a> +<span class="sourceLineNo">281</span> hbck.setIgnorePreCheckPermission(true);<a name="line.281"></a> +<span class="sourceLineNo">282</span> Assert.assertEquals("shouldIgnorePreCheckPermission", true,<a name="line.282"></a> +<span class="sourceLineNo">283</span> hbck.shouldIgnorePreCheckPermission());<a name="line.283"></a> +<span class="sourceLineNo">284</span> }<a name="line.284"></a> +<span class="sourceLineNo">285</span><a name="line.285"></a> +<span class="sourceLineNo">286</span> /**<a name="line.286"></a> +<span class="sourceLineNo">287</span> * This creates and fixes a bad table where a region is completely contained<a name="line.287"></a> +<span class="sourceLineNo">288</span> * by another region, and there is a hole (sort of like a bad split)<a name="line.288"></a> +<span class="sourceLineNo">289</span> */<a name="line.289"></a> +<span class="sourceLineNo">290</span> @Test (timeout=180000)<a name="line.290"></a> +<span class="sourceLineNo">291</span> public void testOverlapAndOrphan() throws Exception {<a name="line.291"></a> +<span class="sourceLineNo">292</span> TableName table =<a name="line.292"></a> +<span class="sourceLineNo">293</span> TableName.valueOf("tableOverlapAndOrphan");<a name="line.293"></a> +<span class="sourceLineNo">294</span> try {<a name="line.294"></a> +<span class="sourceLineNo">295</span> setupTable(table);<a name="line.295"></a> +<span class="sourceLineNo">296</span> assertEquals(ROWKEYS.length, countRows());<a name="line.296"></a> <span class="sourceLineNo">297</span><a name="line.297"></a> -<span class="sourceLineNo">298</span> HRegionInfo hriOverlap =<a name="line.298"></a> -<span class="sourceLineNo">299</span> createRegion(tbl.getTableDescriptor(), Bytes.toBytes("A2"), Bytes.toBytes("B"));<a name="line.299"></a> -<span class="sourceLineNo">300</span> TEST_UTIL.getHBaseCluster().getMaster().assignRegion(hriOverlap);<a name="line.300"></a> -<span class="sourceLineNo">301</span> TEST_UTIL.getHBaseCluster().getMaster().getAssignmentManager()<a name="line.301"></a> -<span class="sourceLineNo">302</span> .waitForAssignment(hriOverlap);<a name="line.302"></a> -<span class="sourceLineNo">303</span> ServerName server = regionStates.getRegionServerOfRegion(hriOverlap);<a name="line.303"></a> -<span class="sourceLineNo">304</span> TEST_UTIL.assertRegionOnServer(hriOverlap, server, REGION_ONLINE_TIMEOUT);<a name="line.304"></a> -<span class="sourceLineNo">305</span><a name="line.305"></a> -<span class="sourceLineNo">306</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.306"></a> -<span class="sourceLineNo">307</span> assertErrors(hbck,<a name="line.307"></a> -<span class="sourceLineNo">308</span> new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.ORPHAN_HDFS_REGION, HBaseFsck.ErrorReporter.ERROR_CODE.NOT_IN_META_OR_DEPLOYED,<a name="line.308"></a> -<span class="sourceLineNo">309</span> HBaseFsck.ErrorReporter.ERROR_CODE.HOLE_IN_REGION_CHAIN });<a name="line.309"></a> -<span class="sourceLineNo">310</span><a name="line.310"></a> -<span class="sourceLineNo">311</span> // fix the problem.<a name="line.311"></a> -<span class="sourceLineNo">312</span> doFsck(conf, true);<a name="line.312"></a> -<span class="sourceLineNo">313</span><a name="line.313"></a> -<span class="sourceLineNo">314</span> // verify that overlaps are fixed<a name="line.314"></a> -<span class="sourceLineNo">315</span> HBaseFsck hbck2 = doFsck(conf,false);<a name="line.315"></a> -<span class="sourceLineNo">316</span> assertNoErrors(hbck2);<a name="line.316"></a> -<span class="sourceLineNo">317</span> assertEquals(0, hbck2.getOverlapGroups(table).size());<a name="line.317"></a> -<span class="sourceLineNo">318</span> assertEquals(ROWKEYS.length, countRows());<a name="line.318"></a> -<span class="sourceLineNo">319</span> } finally {<a name="line.319"></a> -<span class="sourceLineNo">320</span> cleanupTable(table);<a name="line.320"></a> -<span class="sourceLineNo">321</span> }<a name="line.321"></a> -<span class="sourceLineNo">322</span> }<a name="line.322"></a> -<span class="sourceLineNo">323</span><a name="line.323"></a> -<span class="sourceLineNo">324</span> /**<a name="line.324"></a> -<span class="sourceLineNo">325</span> * This creates and fixes a bad table where a region overlaps two regions --<a name="line.325"></a> -<span class="sourceLineNo">326</span> * a start key contained in another region and its end key is contained in<a name="line.326"></a> -<span class="sourceLineNo">327</span> * yet another region.<a name="line.327"></a> -<span class="sourceLineNo">328</span> */<a name="line.328"></a> -<span class="sourceLineNo">329</span> @Test (timeout=180000)<a name="line.329"></a> -<span class="sourceLineNo">330</span> public void testCoveredStartKey() throws Exception {<a name="line.330"></a> -<span class="sourceLineNo">331</span> TableName table =<a name="line.331"></a> -<span class="sourceLineNo">332</span> TableName.valueOf("tableCoveredStartKey");<a name="line.332"></a> -<span class="sourceLineNo">333</span> try {<a name="line.333"></a> -<span class="sourceLineNo">334</span> setupTable(table);<a name="line.334"></a> -<span class="sourceLineNo">335</span> assertEquals(ROWKEYS.length, countRows());<a name="line.335"></a> -<span class="sourceLineNo">336</span><a name="line.336"></a> -<span class="sourceLineNo">337</span> // Mess it up by creating an overlap in the metadata<a name="line.337"></a> -<span class="sourceLineNo">338</span> HRegionInfo hriOverlap =<a name="line.338"></a> -<span class="sourceLineNo">339</span> createRegion(tbl.getTableDescriptor(), Bytes.toBytes("A2"), Bytes.toBytes("B2"));<a name="line.339"></a> -<span class="sourceLineNo">340</span> TEST_UTIL.getHBaseCluster().getMaster().assignRegion(hriOverlap);<a name="line.340"></a> -<span class="sourceLineNo">341</span> TEST_UTIL.getHBaseCluster().getMaster().getAssignmentManager()<a name="line.341"></a> -<span class="sourceLineNo">342</span> .waitForAssignment(hriOverlap);<a name="line.342"></a> -<span class="sourceLineNo">343</span> ServerName server = regionStates.getRegionServerOfRegion(hriOverlap);<a name="line.343"></a> -<span class="sourceLineNo">344</span> TEST_UTIL.assertRegionOnServer(hriOverlap, server, REGION_ONLINE_TIMEOUT);<a name="line.344"></a> -<span class="sourceLineNo">345</span><a name="line.345"></a> -<span class="sourceLineNo">346</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.346"></a> -<span class="sourceLineNo">347</span> assertErrors(hbck, new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.OVERLAP_IN_REGION_CHAIN,<a name="line.347"></a> -<span class="sourceLineNo">348</span> HBaseFsck.ErrorReporter.ERROR_CODE.OVERLAP_IN_REGION_CHAIN });<a name="line.348"></a> -<span class="sourceLineNo">349</span> assertEquals(3, hbck.getOverlapGroups(table).size());<a name="line.349"></a> -<span class="sourceLineNo">350</span> assertEquals(ROWKEYS.length, countRows());<a name="line.350"></a> +<span class="sourceLineNo">298</span> // Mess it up by creating an overlap in the metadata<a name="line.298"></a> +<span class="sourceLineNo">299</span> admin.disableTable(table);<a name="line.299"></a> +<span class="sourceLineNo">300</span> deleteRegion(conf, tbl.getTableDescriptor(), Bytes.toBytes("A"), Bytes.toBytes("B"), true,<a name="line.300"></a> +<span class="sourceLineNo">301</span> true, false, true, HRegionInfo.DEFAULT_REPLICA_ID);<a name="line.301"></a> +<span class="sourceLineNo">302</span> admin.enableTable(table);<a name="line.302"></a> +<span class="sourceLineNo">303</span><a name="line.303"></a> +<span class="sourceLineNo">304</span> HRegionInfo hriOverlap =<a name="line.304"></a> +<span class="sourceLineNo">305</span> createRegion(tbl.getTableDescriptor(), Bytes.toBytes("A2"), Bytes.toBytes("B"));<a name="line.305"></a> +<span class="sourceLineNo">306</span> TEST_UTIL.getHBaseCluster().getMaster().assignRegion(hriOverlap);<a name="line.306"></a> +<span class="sourceLineNo">307</span> TEST_UTIL.getHBaseCluster().getMaster().getAssignmentManager()<a name="line.307"></a> +<span class="sourceLineNo">308</span> .waitForAssignment(hriOverlap);<a name="line.308"></a> +<span class="sourceLineNo">309</span> ServerName server = regionStates.getRegionServerOfRegion(hriOverlap);<a name="line.309"></a> +<span class="sourceLineNo">310</span> TEST_UTIL.assertRegionOnServer(hriOverlap, server, REGION_ONLINE_TIMEOUT);<a name="line.310"></a> +<span class="sourceLineNo">311</span><a name="line.311"></a> +<span class="sourceLineNo">312</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.312"></a> +<span class="sourceLineNo">313</span> assertErrors(hbck,<a name="line.313"></a> +<span class="sourceLineNo">314</span> new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.ORPHAN_HDFS_REGION, HBaseFsck.ErrorReporter.ERROR_CODE.NOT_IN_META_OR_DEPLOYED,<a name="line.314"></a> +<span class="sourceLineNo">315</span> HBaseFsck.ErrorReporter.ERROR_CODE.HOLE_IN_REGION_CHAIN });<a name="line.315"></a> +<span class="sourceLineNo">316</span><a name="line.316"></a> +<span class="sourceLineNo">317</span> // fix the problem.<a name="line.317"></a> +<span class="sourceLineNo">318</span> doFsck(conf, true);<a name="line.318"></a> +<span class="sourceLineNo">319</span><a name="line.319"></a> +<span class="sourceLineNo">320</span> // verify that overlaps are fixed<a name="line.320"></a> +<span class="sourceLineNo">321</span> HBaseFsck hbck2 = doFsck(conf,false);<a name="line.321"></a> +<span class="sourceLineNo">322</span> assertNoErrors(hbck2);<a name="line.322"></a> +<span class="sourceLineNo">323</span> assertEquals(0, hbck2.getOverlapGroups(table).size());<a name="line.323"></a> +<span class="sourceLineNo">324</span> assertEquals(ROWKEYS.length, countRows());<a name="line.324"></a> +<span class="sourceLineNo">325</span> } finally {<a name="line.325"></a> +<span class="sourceLineNo">326</span> cleanupTable(table);<a name="line.326"></a> +<span class="sourceLineNo">327</span> }<a name="line.327"></a> +<span class="sourceLineNo">328</span> }<a name="line.328"></a> +<span class="sourceLineNo">329</span><a name="line.329"></a> +<span class="sourceLineNo">330</span> /**<a name="line.330"></a> +<span class="sourceLineNo">331</span> * This creates and fixes a bad table where a region overlaps two regions --<a name="line.331"></a> +<span class="sourceLineNo">332</span> * a start key contained in another region and its end key is contained in<a name="line.332"></a> +<span class="sourceLineNo">333</span> * yet another region.<a name="line.333"></a> +<span class="sourceLineNo">334</span> */<a name="line.334"></a> +<span class="sourceLineNo">335</span> @Test (timeout=180000)<a name="line.335"></a> +<span class="sourceLineNo">336</span> public void testCoveredStartKey() throws Exception {<a name="line.336"></a> +<span class="sourceLineNo">337</span> TableName table =<a name="line.337"></a> +<span class="sourceLineNo">338</span> TableName.valueOf("tableCoveredStartKey");<a name="line.338"></a> +<span class="sourceLineNo">339</span> try {<a name="line.339"></a> +<span class="sourceLineNo">340</span> setupTable(table);<a name="line.340"></a> +<span class="sourceLineNo">341</span> assertEquals(ROWKEYS.length, countRows());<a name="line.341"></a> +<span class="sourceLineNo">342</span><a name="line.342"></a> +<span class="sourceLineNo">343</span> // Mess it up by creating an overlap in the metadata<a name="line.343"></a> +<span class="sourceLineNo">344</span> HRegionInfo hriOverlap =<a name="line.344"></a> +<span class="sourceLineNo">345</span> createRegion(tbl.getTableDescriptor(), Bytes.toBytes("A2"), Bytes.toBytes("B2"));<a name="line.345"></a> +<span class="sourceLineNo">346</span> TEST_UTIL.getHBaseCluster().getMaster().assignRegion(hriOverlap);<a name="line.346"></a> +<span class="sourceLineNo">347</span> TEST_UTIL.getHBaseCluster().getMaster().getAssignmentManager()<a name="line.347"></a> +<span class="sourceLineNo">348</span> .waitForAssignment(hriOverlap);<a name="line.348"></a> +<span class="sourceLineNo">349</span> ServerName server = regionStates.getRegionServerOfRegion(hriOverlap);<a name="line.349"></a> +<span class="sourceLineNo">350</span> TEST_UTIL.assertRegionOnServer(hriOverlap, server, REGION_ONLINE_TIMEOUT);<a name="line.350"></a> <span class="sourceLineNo">351</span><a name="line.351"></a> -<span class="sourceLineNo">352</span> // fix the problem.<a name="line.352"></a> -<span class="sourceLineNo">353</span> doFsck(conf, true);<a name="line.353"></a> -<span class="sourceLineNo">354</span><a name="line.354"></a> -<span class="sourceLineNo">355</span> // verify that overlaps are fixed<a name="line.355"></a> -<span class="sourceLineNo">356</span> HBaseFsck hbck2 = doFsck(conf, false);<a name="line.356"></a> -<span class="sourceLineNo">357</span> assertErrors(hbck2, new HBaseFsck.ErrorReporter.ERROR_CODE[0]);<a name="line.357"></a> -<span class="sourceLineNo">358</span> assertEquals(0, hbck2.getOverlapGroups(table).size());<a name="line.358"></a> -<span class="sourceLineNo">359</span> assertEquals(ROWKEYS.length, countRows());<a name="line.359"></a> -<span class="sourceLineNo">360</span> } finally {<a name="line.360"></a> -<span class="sourceLineNo">361</span> cleanupTable(table);<a name="line.361"></a> -<span class="sourceLineNo">362</span> }<a name="line.362"></a> -<span class="sourceLineNo">363</span> }<a name="line.363"></a> -<span class="sourceLineNo">364</span><a name="line.364"></a> -<span class="sourceLineNo">365</span> /**<a name="line.365"></a> -<span class="sourceLineNo">366</span> * This creates and fixes a bad table with a missing region -- hole in meta<a name="line.366"></a> -<span class="sourceLineNo">367</span> * and data missing in the fs.<a name="line.367"></a> -<span class="sourceLineNo">368</span> */<a name="line.368"></a> -<span class="sourceLineNo">369</span> @Test (timeout=180000)<a name="line.369"></a> -<span class="sourceLineNo">370</span> public void testRegionHole() throws Exception {<a name="line.370"></a> -<span class="sourceLineNo">371</span> TableName table =<a name="line.371"></a> -<span class="sourceLineNo">372</span> TableName.valueOf("tableRegionHole");<a name="line.372"></a> -<span class="sourceLineNo">373</span> try {<a name="line.373"></a> -<span class="sourceLineNo">374</span> setupTable(table);<a name="line.374"></a> -<span class="sourceLineNo">375</span> assertEquals(ROWKEYS.length, countRows());<a name="line.375"></a> -<span class="sourceLineNo">376</span><a name="line.376"></a> -<span class="sourceLineNo">377</span> // Mess it up by leaving a hole in the assignment, meta, and hdfs data<a name="line.377"></a> -<span class="sourceLineNo">378</span> admin.disableTable(table);<a name="line.378"></a> -<span class="sourceLineNo">379</span> deleteRegion(conf, tbl.getTableDescriptor(), Bytes.toBytes("B"), Bytes.toBytes("C"), true,<a name="line.379"></a> -<span class="sourceLineNo">380</span> true, true);<a name="line.380"></a> -<span class="sourceLineNo">381</span> admin.enableTable(table);<a name="line.381"></a> +<span class="sourceLineNo">352</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.352"></a> +<span class="sourceLineNo">353</span> assertErrors(hbck, new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.OVERLAP_IN_REGION_CHAIN,<a name="line.353"></a> +<span class="sourceLineNo">354</span> HBaseFsck.ErrorReporter.ERROR_CODE.OVERLAP_IN_REGION_CHAIN });<a name="line.354"></a> +<span class="sourceLineNo">355</span> assertEquals(3, hbck.getOverlapGroups(table).size());<a name="line.355"></a> +<span class="sourceLineNo">356</span> assertEquals(ROWKEYS.length, countRows());<a name="line.356"></a> +<span class="sourceLineNo">357</span><a name="line.357"></a> +<span class="sourceLineNo">358</span> // fix the problem.<a name="line.358"></a> +<span class="sourceLineNo">359</span> doFsck(conf, true);<a name="line.359"></a> +<span class="sourceLineNo">360</span><a name="line.360"></a> +<span class="sourceLineNo">361</span> // verify that overlaps are fixed<a name="line.361"></a> +<span class="sourceLineNo">362</span> HBaseFsck hbck2 = doFsck(conf, false);<a name="line.362"></a> +<span class="sourceLineNo">363</span> assertErrors(hbck2, new HBaseFsck.ErrorReporter.ERROR_CODE[0]);<a name="line.363"></a> +<span class="sourceLineNo">364</span> assertEquals(0, hbck2.getOverlapGroups(table).size());<a name="line.364"></a> +<span class="sourceLineNo">365</span> assertEquals(ROWKEYS.length, countRows());<a name="line.365"></a> +<span class="sourceLineNo">366</span> } finally {<a name="line.366"></a> +<span class="sourceLineNo">367</span> cleanupTable(table);<a name="line.367"></a> +<span class="sourceLineNo">368</span> }<a name="line.368"></a> +<span class="sourceLineNo">369</span> }<a name="line.369"></a> +<span class="sourceLineNo">370</span><a name="line.370"></a> +<span class="sourceLineNo">371</span> /**<a name="line.371"></a> +<span class="sourceLineNo">372</span> * This creates and fixes a bad table with a missing region -- hole in meta<a name="line.372"></a> +<span class="sourceLineNo">373</span> * and data missing in the fs.<a name="line.373"></a> +<span class="sourceLineNo">374</span> */<a name="line.374"></a> +<span class="sourceLineNo">375</span> @Test (timeout=180000)<a name="line.375"></a> +<span class="sourceLineNo">376</span> public void testRegionHole() throws Exception {<a name="line.376"></a> +<span class="sourceLineNo">377</span> TableName table =<a name="line.377"></a> +<span class="sourceLineNo">378</span> TableName.valueOf("tableRegionHole");<a name="line.378"></a> +<span class="sourceLineNo">379</span> try {<a name="line.379"></a> +<span class="sourceLineNo">380</span> setupTable(table);<a name="line.380"></a> +<span class="sourceLineNo">381</span> assertEquals(ROWKEYS.length, countRows());<a name="line.381"></a> <span class="sourceLineNo">382</span><a name="line.382"></a> -<span class="sourceLineNo">383</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.383"></a> -<span class="sourceLineNo">384</span> assertErrors(hbck, new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.HOLE_IN_REGION_CHAIN });<a name="line.384"></a> -<span class="sourceLineNo">385</span> // holes are separate from overlap groups<a name="line.385"></a> -<span class="sourceLineNo">386</span> assertEquals(0, hbck.getOverlapGroups(table).size());<a name="line.386"></a> -<span class="sourceLineNo">387</span><a name="line.387"></a> -<span class="sourceLineNo">388</span> // fix hole<a name="line.388"></a> -<span class="sourceLineNo">389</span> doFsck(conf, true);<a name="line.389"></a> -<span class="sourceLineNo">390</span><a name="line.390"></a> -<span class="sourceLineNo">391</span> // check that hole fixed<a name="line.391"></a> -<span class="sourceLineNo">392</span> assertNoErrors(doFsck(conf,false));<a name="line.392"></a> -<span class="sourceLineNo">393</span> assertEquals(ROWKEYS.length - 2, countRows()); // lost a region so lost a row<a name="line.393"></a> -<span class="sourceLineNo">394</span> } finally {<a name="line.394"></a> -<span class="sourceLineNo">395</span> cleanupTable(table);<a name="line.395"></a> -<span class="sourceLineNo">396</span> }<a name="line.396"></a> -<span class="sourceLineNo">397</span> }<a name="line.397"></a> -<span class="sourceLineNo">398</span><a name="line.398"></a> -<span class="sourceLineNo">399</span> /**<a name="line.399"></a> -<span class="sourceLineNo">400</span> * The region is not deployed when the table is disabled.<a name="line.400"></a> -<span class="sourceLineNo">401</span> */<a name="line.401"></a> -<span class="sourceLineNo">402</span> @Test (timeout=180000)<a name="line.402"></a> -<span class="sourceLineNo">403</span> public void testRegionShouldNotBeDeployed() throws Exception {<a name="line.403"></a> -<span class="sourceLineNo">404</span> TableName table =<a name="line.404"></a> -<span class="sourceLineNo">405</span> TableName.valueOf("tableRegionShouldNotBeDeployed");<a name="line.405"></a> -<span class="sourceLineNo">406</span> try {<a name="line.406"></a> -<span class="sourceLineNo">407</span> LOG.info("Starting testRegionShouldNotBeDeployed.");<a name="line.407"></a> -<span class="sourceLineNo">408</span> MiniHBaseCluster cluster = TEST_UTIL.getHBaseCluster();<a name="line.408"></a> -<span class="sourceLineNo">409</span> assertTrue(cluster.waitForActiveAndReadyMaster());<a name="line.409"></a> -<span class="sourceLineNo">410</span><a name="line.410"></a> -<span class="sourceLineNo">411</span><a name="line.411"></a> -<span class="sourceLineNo">412</span> byte[][] SPLIT_KEYS = new byte[][] { new byte[0], Bytes.toBytes("aaa"),<a name="line.412"></a> -<span class="sourceLineNo">413</span> Bytes.toBytes("bbb"), Bytes.toBytes("ccc"), Bytes.toBytes("ddd") };<a name="line.413"></a> -<span class="sourceLineNo">414</span> HTableDescriptor htdDisabled = new HTableDescriptor(table);<a name="line.414"></a> -<span class="sourceLineNo">415</span> htdDisabled.addFamily(new HColumnDescriptor(FAM));<a name="line.415"></a> +<span class="sourceLineNo">383</span> // Mess it up by leaving a hole in the assignment, meta, and hdfs data<a name="line.383"></a> +<span class="sourceLineNo">384</span> admin.disableTable(table);<a name="line.384"></a> +<span class="sourceLineNo">385</span> deleteRegion(conf, tbl.getTableDescriptor(), Bytes.toBytes("B"), Bytes.toBytes("C"), true,<a name="line.385"></a> +<span class="sourceLineNo">386</span> true, true);<a name="line.386"></a> +<span class="sourceLineNo">387</span> admin.enableTable(table);<a name="line.387"></a> +<span class="sourceLineNo">388</span><a name="line.388"></a> +<span class="sourceLineNo">389</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.389"></a> +<span class="sourceLineNo">390</span> assertErrors(hbck, new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.HOLE_IN_REGION_CHAIN });<a name="line.390"></a> +<span class="sourceLineNo">391</span> // holes are separate from overlap groups<a name="line.391"></a> +<span class="sourceLineNo">392</span> assertEquals(0, hbck.getOverlapGroups(table).size());<a name="line.392"></a> +<span class="sourceLineNo">393</span><a name="line.393"></a> +<span class="sourceLineNo">394</span> // fix hole<a name="line.394"></a> +<span class="sourceLineNo">395</span> doFsck(conf, true);<a name="line.395"></a> +<span class="sourceLineNo">396</span><a name="line.396"></a> +<span class="sourceLineNo">397</span> // check that hole fixed<a name="line.397"></a> +<span class="sourceLineNo">398</span> assertNoErrors(doFsck(conf,false));<a name="line.398"></a> +<span class="sourceLineNo">399</span> assertEquals(ROWKEYS.length - 2, countRows()); // lost a region so lost a row<a name="line.399"></a> +<span class="sourceLineNo">400</span> } finally {<a name="line.400"></a> +<span class="sourceLineNo">401</span> cleanupTable(table);<a name="line.401"></a> +<span class="sourceLineNo">402</span> }<a name="line.402"></a> +<span class="sourceLineNo">403</span> }<a name="line.403"></a> +<span class="sourceLineNo">404</span><a name="line.404"></a> +<span class="sourceLineNo">405</span> /**<a name="line.405"></a> +<span class="sourceLineNo">406</span> * The region is not deployed when the table is disabled.<a name="line.406"></a> +<span class="sourceLineNo">407</span> */<a name="line.407"></a> +<span class="sourceLineNo">408</span> @Test (timeout=180000)<a name="line.408"></a> +<span class="sourceLineNo">409</span> public void testRegionShouldNotBeDeployed() throws Exception {<a name="line.409"></a> +<span class="sourceLineNo">410</span> TableName table =<a name="line.410"></a> +<span class="sourceLineNo">411</span> TableName.valueOf("tableRegionShouldNotBeDeployed");<a name="line.411"></a> +<span class="sourceLineNo">412</span> try {<a name="line.412"></a> +<span class="sourceLineNo">413</span> LOG.info("Starting testRegionShouldNotBeDeployed.");<a name="line.413"></a> +<span class="sourceLineNo">414</span> MiniHBaseCluster cluster = TEST_UTIL.getHBaseCluster();<a name="line.414"></a> +<span class="sourceLineNo">415</span> assertTrue(cluster.waitForActiveAndReadyMaster());<a name="line.415"></a> <span class="sourceLineNo">416</span><a name="line.416"></a> -<span class="sourceLineNo">417</span> // Write the .tableinfo<a name="line.417"></a> -<span class="sourceLineNo">418</span> FSTableDescriptors fstd = new FSTableDescriptors(conf);<a name="line.418"></a> -<span class="sourceLineNo">419</span> fstd.createTableDescriptor(htdDisabled);<a name="line.419"></a> -<span class="sourceLineNo">420</span> List<HRegionInfo> disabledRegions =<a name="line.420"></a> -<span class="sourceLineNo">421</span> TEST_UTIL.createMultiRegionsInMeta(conf, htdDisabled, SPLIT_KEYS);<a name="line.421"></a> +<span class="sourceLineNo">417</span><a name="line.417"></a> +<span class="sourceLineNo">418</span> byte[][] SPLIT_KEYS = new byte[][] { new byte[0], Bytes.toBytes("aaa"),<a name="line.418"></a> +<span class="sourceLineNo">419</span> Bytes.toBytes("bbb"), Bytes.toBytes("ccc"), Bytes.toBytes("ddd") };<a name="line.419"></a> +<span class="sourceLineNo">420</span> HTableDescriptor htdDisabled = new HTableDescriptor(table);<a name="line.420"></a> +<span class="sourceLineNo">421</span> htdDisabled.addFamily(new HColumnDescriptor(FAM));<a name="line.421"></a> <span class="sourceLineNo">422</span><a name="line.422"></a> -<span class="sourceLineNo">423</span> // Let's just assign everything to first RS<a name="line.423"></a> -<span class="sourceLineNo">424</span> HRegionServer hrs = cluster.getRegionServer(0);<a name="line.424"></a> -<span class="sourceLineNo">425</span><a name="line.425"></a> -<span class="sourceLineNo">426</span> // Create region files.<a name="line.426"></a> -<span class="sourceLineNo">427</span> admin.disableTable(table);<a name="line.427"></a> -<span class="sourceLineNo">428</span> admin.enableTable(table);<a name="line.428"></a> -<span class="sourceLineNo">429</span><a name="line.429"></a> -<span class="sourceLineNo">430</span> // Disable the table and close its regions<a name="line.430"></a> -<span class="sourceLineNo">431</span> admin.disableTable(table);<a name="line.431"></a> -<span class="sourceLineNo">432</span> HRegionInfo region = disabledRegions.remove(0);<a name="line.432"></a> -<span class="sourceLineNo">433</span> byte[] regionName = region.getRegionName();<a name="line.433"></a> -<span class="sourceLineNo">434</span><a name="line.434"></a> -<span class="sourceLineNo">435</span> // The region should not be assigned currently<a name="line.435"></a> -<span class="sourceLineNo">436</span> assertTrue(cluster.getServerWith(regionName) == -1);<a name="line.436"></a> -<span class="sourceLineNo">437</span><a name="line.437"></a> -<span class="sourceLineNo">438</span> // Directly open a region on a region server.<a name="line.438"></a> -<span class="sourceLineNo">439</span> // If going through AM/ZK, the region won't be open.<a name="line.439"></a> -<span class="sourceLineNo">440</span> // Even it is opened, AM will close it which causes<a name="line.440"></a> -<span class="sourceLineNo">441</span> // flakiness of this test.<a name="line.441"></a> -<span class="sourceLineNo">442</span> HRegion r = HRegion.openHRegion(<a name="line.442"></a> -<span class="sourceLineNo">443</span> region, htdDisabled, hrs.getWAL(region), conf);<a name="line.443"></a> -<span class="sourceLineNo">444</span> hrs.addToOnlineRegions(r);<a name="line.444"></a> -<span class="sourceLineNo">445</span><a name="line.445"></a> -<span class="sourceLineNo">446</span> HBaseFsck hbck = doFsck(conf, false);<a name="line.446"></a> -<span class="sourceLineNo">447</span> assertErrors(hbck, new HBaseFsck.ErrorReporter.ERROR_CODE[] { HBaseFsck.ErrorReporter.ERROR_CODE.SHOULD_NOT_BE_DEPLOYED });<a name="line.447"></a> -<span class="sourceLineNo">448</span><a name="line.448"></a> -<span class="sourceLineNo">449</span> // fix this fault<a name="line.449"></a> -<span class="sourceLineNo">450</span> doFsck(conf, true);<a name="line.450"></a> +<span class="sourceLineNo">423</span> // Write the .tableinfo<a name="line.423"></a> +<span class="sourceLineNo">424</span> FSTableDescriptors fstd = new FSTableDescriptors(conf);<a name="line.424"></a> +<span class="sourceLineNo">425</span> fstd.createTableDescriptor(htdDisabled);<a name="line.425"></a> +<span class="sourceLineNo">426</span> List<HRegionInfo> disabledRegions =<a name="line.426"></a> +<span class="sourceLineNo">427</span> TEST_UTIL.createMultiRegionsInMeta(conf, htdDisabled, SPLIT_KEYS);<a name="line.427"></a> +<span class="sourceLineNo">428</span><a name="line.428"></a> +<span class="sourceLineNo">429</span> // Let's just assign everything to first RS<a name="line.429"></a> +<span class="sourceLineNo">430</span> HRegionServer hrs = cluster.getRegionServer(0);<a name="line.430"></a> +<span class="sourceLineNo">431</span><a name="line.431"></a> +<span class="sourceLineNo">432</span> // Create region files.<a name="line.432"></a> +<span class="sourceLineNo">433</span> admin.disableTable(table);<a name="line.433"></a> +<span class="sourceLineNo">434</span> admin.enableTable(table);<a name="line.434"></a> +<span class="sourceLineNo">435</span><a name="line.435"></a> +<span class="sourceLineNo">436</span> // Disable the table and close its regions<a name="line.436"></a> +<span class="sourceLineNo">437</span> admin.disableTable(table);<a name="line.437"></a> +<span class="sourceLineNo">438</span> HRegionInfo region = disabledRegions.remove(0);<a name="line.438"></a> +<span class="sourceLineNo">439</span> byte[] regionName = region.getRegionName();<a name="line.439"></a> +<span class="sourceLineNo">440</span><a name="line.440"></a> +<span class="sourceLineNo">441</span> // The region should not be assigned currently<a name="line.441"></a> +<span class="sourceLineNo">442</span> assertTrue(cluster.getServerWith(regionName) == -1);<a name="line.442"></a> +<span class="sourceLineNo">443</span><a name="line.443"></a> +<span class="sourceLineNo">444</span> // Directly open a region on a region server.<a name="line.444"></a> +<span class="sourceLineNo">445</span> // If going through AM/ZK, the region won't be open.<a name="line.445"></a> +<span class="sourceLineNo">446</span> // Even it is opened, AM will close it which causes<a name="line.446"></a> +<span class="sourceLineNo">447</span> // flakiness of this test.<a name="line.447"></a> +<span class="sourceLineNo">448</span> HRegion r = HRegion.openHRegion(<a name="line.448"></a> +<span class="sourceLineNo">449</span> region, htdDisabled, hrs.getWAL(region), conf);<a name="line.449"></a> +<span class="sourceLineNo">450</span> hrs.addToOnlineRegions(r);<a name="line.450"></a> <span class="sourceLineNo">451</span><a name="line.451"></a> -<span class="sourceLineNo">452</span> // check result<a name="line.452"></a> -<span class="sourceLineNo">453</span> assertNoErrors(doFsck(conf, false));<a name="line.453"></a> -<span class="sourceLineNo">454</span> } finally {<a name="line.454"></a> -<span class="sourceLineNo">455</span> admin.enableTable(table);<a name="line.455"></a> -<span class="sourceLineNo">456</span> cleanupTable(table);<a name="line.456"></a> -<span class="sourceLineNo">457</span> }<a name="line.457"></a> -<span class="sourceLineNo">458</span> }<a name="line.458"></a> -<span class="sourceLineNo">459</span><a name="line.459"></a> -<span class="sourceLineNo">460</span> /**<a name="line.460"></a> -<span class="sourceLineNo">461</span> * This test makes sure that parallel instances of Hbck is disabled.<a name="line.461"></a> -<span class="sourceLineNo">462</span> *<a name="line.462"></a> -<span class="sourceLineNo">463</span> * @throws Exception<a name="line.463"></a> -<span class="sourceLineNo">464</span> */<a name="line.464"></a> -<span class="sourceLineNo">465</span> @Test(timeout=180000)<a name="line.465"></a> -<span class="sourceLineNo">466</span> public void testParallelHbck() throws Exception {<a name="line.466"></a> -<span class="sourceLineNo">467</span> final ExecutorService service;<a name="line.467"></a> -<span class="sourceLineNo">468</span> final Future<HBaseFsck> hbck1,hbck2;<a name="line.468"></a> -<span class="sourceLineNo">469</span><a name="line.469"></a> -<span class="sourceLineNo">470</span> class RunHbck implements Callable<HBaseFsck> {<a name="line.470"></a> -<span class="sourceLineNo">471</span> boolean fail = true;<a name="line.471"></a> -<span class="sourceLineNo">472</span> @Override<a name="line.472"></a> -<span class="sourceLineNo">473</span> public HBaseFsck call(){<a name="line.473"></a> -<span class="sourceLineNo">474</span> Configuration c = new Configuration(conf);<a name="line.474"></a> -<span class="sourceLineNo">475</span> c.setInt("hbase.hbck.lockfile.attempts", 1);<a name="line.475"></a> -<span class="sourceLineNo">476</span> // HBASE-13574 found that in HADOOP-2.6 and later, the create file would internally retry.<a name="line.476"></a> -<span class="sourceLineNo">477</span> // To avoid flakiness of the test, set low max wait time.<a name="line.477"></a> -<span class="sourceLineNo">478</span> c.setInt("hbase.hbck.lockfile.maxwaittime", 3);<a name="line.478"></a> -<span class="sourceLineNo">479</span> try{<a name="line.479"></a> -<span class="sourceLineNo">480</span> return doFsck(c, true); // Exclusive hbck only when fixing<a name="line.480"></a> -<span class="sourceLineNo">481</span> } catch(Exception e){<a name="line.481"></a> -<span class="sourceLineNo">482</span> if (e.getMessage().contains("Duplicate hbck")) {<a name="line.482"></a> -<span class="sourceLineNo">483</span> fail = false;<a name="line.483"></a> -<span class="sourceLineNo">484</span> }<a name="line.484"></a> -<span class="sourceLineNo">485</span> }<a name="line.485"></a> -<span class="sourceLineNo">486</span> // If we reach here, then an exception was caught<a name="line.486"></a> -<span class="sourceLineNo">487</span> if (fail) fail();<a name="line.487"></a> -<span class="sourceLineNo">488</span> return null;<a name="line.488"></a> -<span class="sourceLineNo">489</span> }<a name="line.489"></a> -<span class="sourceLineNo">490</span> }<a name="line.490"></a> -<span class="sourceLineNo">491</span> service = Executors.newFixedThreadPool(2);<a name="line.491"></a> -<span class="sourceLineNo">492</span> hbck1 = service.submit(new RunHbck());<a name="line.492"></a> -<span class="sourceLineNo">493</span> hbck2 = service.submit(new RunHbck());<a name="line.493"></a> -<span class="sourceLineNo">494</span> service.shutdown();<a name="line.494"></a> -<span class="sourceLineNo">495</span> //wait for 15 seconds, for both hbck calls finish<a name="line.495"></a> -<span class="sourceLineNo">496</span> service.awaitTermination(15, TimeUnit.SECONDS);<a name="line.496"></a> -<span class="sourceLineNo">497</span> HBaseFsck h1 = hbck1.get();<a name="line.497"></a> -<span class="sourceLineNo">498</span> HBaseFsck h2 = hbck2.get();<a name="line.498"></a> -<span class="sourceLineNo">499</span> // Make sure only one of the calls was successful<a name="line.499"></a> -<span class="sourceLineNo">500</span> assert(h1 == null || h2 == null);<a name="line.500"></a> -<span class="sourceLineNo">501</span> if (h1 != null) {<a name="line.501"></a> -<span class="sourceLineNo">502</span> assert(h1.getRetCode() >= 0);<a name="line.502"></a> -<span class="sourceLineNo">503</span> }<a name="line.503"></a> -<span class="sourceLineNo">504</span> if (h2 != null) {<a name="line.504"></a> -<span class="sourceLineNo">505</span> assert(h2.getRetCode() >= 0);<a name="line.505"></a> -<span class="sourceLineNo">506</span> }<a name="line.506"></a> -<span class="sourceLineNo">507</span> }<a name="line.507"></a> -<span class="sourceLineNo">508</span><a name="line.508"></a> -<span class="sourceLineNo">509</span> /**<a name="line.509"></a> -<span class="sourceLineNo">510</span> * This test makes sure that with enough retries both parallel instances<a name="line.510"></a> -<span class="sourceLineNo">511</span> * of hbck will be completed successfully.<a name="line.511"></a> -<span class="sourceLineNo">512</span> *<a name="line.512"></a> -<span class="sourceLineNo">513</span> * @throws Exception<a name="line.513"></a> -<span class="sourceLineNo">514</span> */<a name="line.514"></a> -<span class="sourceLineNo">515</span> @Test (timeout=180000)<a name="line.515"></a> -<span class="sourceLineNo">516</span> public void testParallelWithRetriesHbck() throws Exception {<a name="line.516"></a> -<span class="sourceLineNo">517</span> final ExecutorService service;<a name="line.517"></a> -<span class="sourceLineNo">518</span> final Future<HBaseFsck> hbck1,hbck2;<a name="line.518"></a> -<span class="sourceLineNo">519</span><a name="line.519"></a> -<span class="sourceLineNo">520</span> // With the ExponentialBackoffPolicyWithLimit (starting with 200 milliseconds sleep time, and<a name="line.520"></a> -<span class="sourceLineNo">521</span> // max sleep time of 5 seconds), we can retry around 15 times within 80 seconds before bail out.<a name="line.521"></a> -<span class="sourceLineNo">522</span> //<a name="line.522"></a> -<span class="sourceLineNo">523</span> // Note: the reason to use 80 seconds is that in HADOOP-2.6 and later, the create file would<a name="line.523"></a> -<span class="sourceLineNo">524</span> // retry up to HdfsConstants.LEASE_SOFTLIMIT_PERIOD (60 seconds). See HBASE-13574 for more<a name="line.524"></a> -<span class="sourceLineNo">525</span> // details.<a name="line.525"></a> -<span class="sourceLineNo">526</span> final int timeoutInSeconds = 80;<a name="line.526"></a> -<span class="sourceLineNo">527</span> final int sleepIntervalInMilliseconds = 200;<a name="line.527"></a> -<span class="sourceLineNo">528</span> final int maxSleepTimeInMilliseconds = 6000;<a name="line.528"></a> -<span class="sourceLineNo">529</span> final int maxRetryAttempts = 15;<a name="line.529"></a> -<span class="sourceLineNo">530</span><a name="line.530"></a> -<span class="sourceLineNo">531</span> class RunHbck implements Callable<HBaseFsck>{<a name="line.531"></a> -<span class="sourceLineNo">532</span><a name="line.532"></a> -<span class="sourceLineNo">533</span> @Override<a name="line.533"></a> -<span class="sourceLineNo">534</span> public HBaseFsck call() throws Exception {<a name="line.534"></a> -<span class="sourceLineNo">535</span> // Increase retry attempts to make sure the non-active hbck doesn't get starved<a name="line.535"></a> -<span class="sourceLineNo">536</span> Configuration c = new Configuration(conf);<a name="line.536"></a> -<span class="sourceLineNo">537</span> c.setInt("hbase.hbck.lockfile.maxwaittime", timeoutInSeconds);<a name="line.537"></a> -<span class="sourceLineNo">538</span> c.setInt("hbase.hbck.lockfile.attempt.sleep.interval", sleepIntervalInMilliseconds);<a name="line.538"></a> -<span class="sourceLineNo">539</span> c.setInt("hbase.hbck.lockfile.attempt.maxsleeptime", maxSleepTimeInMilliseconds);<a name="line.539"></a> -<span class="sourceLineNo">540</span> c.setInt("hbase.hbck.lockfile.attempts", maxRetryAttempts);<a name="line.540"></a> -<span class="sourceLineNo">541</span> return doFsck(c, false);<a name="line.541"></a> -<span class="sourceLineNo">542</span> }<a name="line.542"></a> -<span class="sourceLineNo">543</span> }<a name="line.543"></a> -<span class="sourceLineNo">544</span><a name="line.544"></a> -<span class="sourceLineNo">545</span> service = Executors.newFixedThreadPool(2);<a name="line.545"></a> -<span class="sourceLineNo">546</span> hbck1 = service.submit(new RunHbck());<a name="line.546"></a> -<span class="sourceLineNo">547</span> hbck2 = service.submit(new RunHbck());<a name="line.547"></a> -<span class="sourceLineNo">548</span> service.shutdown();<a name="line.548"></a> -<span class="sourceLineNo">549</span> //wait for some time, for both hbck calls finish<a name="line.549"></a> -<span class="sourceLineNo">550</span> service.awaitTermination(timeoutInSeconds * 2, TimeUnit.SECONDS);<a name="line.550"></a> -<span class="sourceLineNo">551</span> HBaseFsck h1 = hbck1.get();<a name="line.551"></a> -<span class="sourceLineNo">552</span> HBaseFsck h2 = hbck2.get();<a name="line.552"></a> -<span class="sourceLineNo">553</span> // Both should be successful<a name="line.553"></a> -<span class="sourceLineNo">554</span> assertNotNull(h1);<a name="line.554"></a> -<span class="sourceLineNo">555</span> assertNotNull(h2);<a name="line.555"></a> -<span class="sourceLineNo">556</span> assert(h1.getRetCode() >= 0);<a name="line.556"></a> -<span class="sourceLineNo">557</span> assert(h2.getRetCode() >= 0);<a name="line.557"></a> -<span class="sourceLineNo">558</span><a name="line.558"></a> -<span class="sourceLineNo">559</span> }<a name="line.559"></a> -<span class="sourceLineNo">560</span><a name="line.560"></a> -<span class="sourceLineNo">561</span> @Test (timeout = 180000)<a name="line.561"></a> -<span class="sourceLineNo">562</s
<TRUNCATED>
