http://git-wip-us.apache.org/repos/asf/hbase-site/blob/50917b1d/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/DeleteColumnFamilyProcedure.html
----------------------------------------------------------------------
diff --git
a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/DeleteColumnFamilyProcedure.html
b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/DeleteColumnFamilyProcedure.html
index 37a7b57..eb76b67 100644
---
a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/DeleteColumnFamilyProcedure.html
+++
b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/DeleteColumnFamilyProcedure.html
@@ -41,420 +41,417 @@
<span class="sourceLineNo">033</span>import
org.apache.hadoop.hbase.TableName;<a name="line.33"></a>
<span class="sourceLineNo">034</span>import
org.apache.hadoop.hbase.classification.InterfaceAudience;<a name="line.34"></a>
<span class="sourceLineNo">035</span>import
org.apache.hadoop.hbase.client.TableState;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import
org.apache.hadoop.hbase.executor.EventType;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import
org.apache.hadoop.hbase.master.MasterCoprocessorHost;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import
org.apache.hadoop.hbase.procedure2.StateMachineProcedure;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import
org.apache.hadoop.hbase.protobuf.ProtobufUtil;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import
org.apache.hadoop.hbase.protobuf.generated.MasterProcedureProtos;<a
name="line.40"></a>
-<span class="sourceLineNo">041</span>import
org.apache.hadoop.hbase.protobuf.generated.MasterProcedureProtos.DeleteColumnFamilyState;<a
name="line.41"></a>
-<span class="sourceLineNo">042</span>import
org.apache.hadoop.hbase.util.ByteStringer;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import
org.apache.hadoop.hbase.util.Bytes;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import
org.apache.hadoop.security.UserGroupInformation;<a name="line.44"></a>
-<span class="sourceLineNo">045</span><a name="line.45"></a>
-<span class="sourceLineNo">046</span>/**<a name="line.46"></a>
-<span class="sourceLineNo">047</span> * The procedure to delete a column
family from an existing table.<a name="line.47"></a>
-<span class="sourceLineNo">048</span> */<a name="line.48"></a>
-<span class="sourceLineNo">049</span>@InterfaceAudience.Private<a
name="line.49"></a>
-<span class="sourceLineNo">050</span>public class
DeleteColumnFamilyProcedure<a name="line.50"></a>
-<span class="sourceLineNo">051</span> extends
StateMachineProcedure<MasterProcedureEnv, DeleteColumnFamilyState><a
name="line.51"></a>
-<span class="sourceLineNo">052</span> implements TableProcedureInterface
{<a name="line.52"></a>
-<span class="sourceLineNo">053</span> private static final Log LOG =
LogFactory.getLog(DeleteColumnFamilyProcedure.class);<a name="line.53"></a>
-<span class="sourceLineNo">054</span><a name="line.54"></a>
-<span class="sourceLineNo">055</span> private final AtomicBoolean aborted =
new AtomicBoolean(false);<a name="line.55"></a>
-<span class="sourceLineNo">056</span><a name="line.56"></a>
-<span class="sourceLineNo">057</span> private HTableDescriptor
unmodifiedHTableDescriptor;<a name="line.57"></a>
-<span class="sourceLineNo">058</span> private TableName tableName;<a
name="line.58"></a>
-<span class="sourceLineNo">059</span> private byte [] familyName;<a
name="line.59"></a>
-<span class="sourceLineNo">060</span> private boolean hasMob;<a
name="line.60"></a>
-<span class="sourceLineNo">061</span> private UserGroupInformation user;<a
name="line.61"></a>
-<span class="sourceLineNo">062</span><a name="line.62"></a>
-<span class="sourceLineNo">063</span> private List<HRegionInfo>
regionInfoList;<a name="line.63"></a>
-<span class="sourceLineNo">064</span> private Boolean traceEnabled;<a
name="line.64"></a>
-<span class="sourceLineNo">065</span><a name="line.65"></a>
-<span class="sourceLineNo">066</span> public DeleteColumnFamilyProcedure()
{<a name="line.66"></a>
-<span class="sourceLineNo">067</span> this.unmodifiedHTableDescriptor =
null;<a name="line.67"></a>
-<span class="sourceLineNo">068</span> this.regionInfoList = null;<a
name="line.68"></a>
-<span class="sourceLineNo">069</span> this.traceEnabled = null;<a
name="line.69"></a>
-<span class="sourceLineNo">070</span> }<a name="line.70"></a>
-<span class="sourceLineNo">071</span><a name="line.71"></a>
-<span class="sourceLineNo">072</span> public DeleteColumnFamilyProcedure(<a
name="line.72"></a>
-<span class="sourceLineNo">073</span> final MasterProcedureEnv env,<a
name="line.73"></a>
-<span class="sourceLineNo">074</span> final TableName tableName,<a
name="line.74"></a>
-<span class="sourceLineNo">075</span> final byte[] familyName) throws
IOException {<a name="line.75"></a>
-<span class="sourceLineNo">076</span> this.tableName = tableName;<a
name="line.76"></a>
-<span class="sourceLineNo">077</span> this.familyName = familyName;<a
name="line.77"></a>
-<span class="sourceLineNo">078</span> this.user =
env.getRequestUser().getUGI();<a name="line.78"></a>
-<span class="sourceLineNo">079</span>
this.setOwner(this.user.getShortUserName());<a name="line.79"></a>
-<span class="sourceLineNo">080</span> this.unmodifiedHTableDescriptor =
null;<a name="line.80"></a>
-<span class="sourceLineNo">081</span> this.regionInfoList = null;<a
name="line.81"></a>
-<span class="sourceLineNo">082</span> this.traceEnabled = null;<a
name="line.82"></a>
-<span class="sourceLineNo">083</span> }<a name="line.83"></a>
-<span class="sourceLineNo">084</span><a name="line.84"></a>
-<span class="sourceLineNo">085</span> @Override<a name="line.85"></a>
-<span class="sourceLineNo">086</span> protected Flow executeFromState(final
MasterProcedureEnv env, DeleteColumnFamilyState state)<a name="line.86"></a>
-<span class="sourceLineNo">087</span> throws InterruptedException {<a
name="line.87"></a>
-<span class="sourceLineNo">088</span> if (isTraceEnabled()) {<a
name="line.88"></a>
-<span class="sourceLineNo">089</span> LOG.trace(this + " execute state="
+ state);<a name="line.89"></a>
-<span class="sourceLineNo">090</span> }<a name="line.90"></a>
-<span class="sourceLineNo">091</span><a name="line.91"></a>
-<span class="sourceLineNo">092</span> try {<a name="line.92"></a>
-<span class="sourceLineNo">093</span> switch (state) {<a
name="line.93"></a>
-<span class="sourceLineNo">094</span> case
DELETE_COLUMN_FAMILY_PREPARE:<a name="line.94"></a>
-<span class="sourceLineNo">095</span> prepareDelete(env);<a
name="line.95"></a>
-<span class="sourceLineNo">096</span>
setNextState(DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_PRE_OPERATION);<a
name="line.96"></a>
-<span class="sourceLineNo">097</span> break;<a name="line.97"></a>
-<span class="sourceLineNo">098</span> case
DELETE_COLUMN_FAMILY_PRE_OPERATION:<a name="line.98"></a>
-<span class="sourceLineNo">099</span> preDelete(env, state);<a
name="line.99"></a>
-<span class="sourceLineNo">100</span>
setNextState(DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_UPDATE_TABLE_DESCRIPTOR);<a
name="line.100"></a>
-<span class="sourceLineNo">101</span> break;<a name="line.101"></a>
-<span class="sourceLineNo">102</span> case
DELETE_COLUMN_FAMILY_UPDATE_TABLE_DESCRIPTOR:<a name="line.102"></a>
-<span class="sourceLineNo">103</span> updateTableDescriptor(env);<a
name="line.103"></a>
-<span class="sourceLineNo">104</span>
setNextState(DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_DELETE_FS_LAYOUT);<a
name="line.104"></a>
-<span class="sourceLineNo">105</span> break;<a name="line.105"></a>
-<span class="sourceLineNo">106</span> case
DELETE_COLUMN_FAMILY_DELETE_FS_LAYOUT:<a name="line.106"></a>
-<span class="sourceLineNo">107</span> deleteFromFs(env);<a
name="line.107"></a>
-<span class="sourceLineNo">108</span>
setNextState(DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_POST_OPERATION);<a
name="line.108"></a>
-<span class="sourceLineNo">109</span> break;<a name="line.109"></a>
-<span class="sourceLineNo">110</span> case
DELETE_COLUMN_FAMILY_POST_OPERATION:<a name="line.110"></a>
-<span class="sourceLineNo">111</span> postDelete(env, state);<a
name="line.111"></a>
-<span class="sourceLineNo">112</span>
setNextState(DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_REOPEN_ALL_REGIONS);<a
name="line.112"></a>
-<span class="sourceLineNo">113</span> break;<a name="line.113"></a>
-<span class="sourceLineNo">114</span> case
DELETE_COLUMN_FAMILY_REOPEN_ALL_REGIONS:<a name="line.114"></a>
-<span class="sourceLineNo">115</span>
reOpenAllRegionsIfTableIsOnline(env);<a name="line.115"></a>
-<span class="sourceLineNo">116</span> return Flow.NO_MORE_STATE;<a
name="line.116"></a>
-<span class="sourceLineNo">117</span> default:<a name="line.117"></a>
-<span class="sourceLineNo">118</span> throw new
UnsupportedOperationException(this + " unhandled state=" + state);<a
name="line.118"></a>
-<span class="sourceLineNo">119</span> }<a name="line.119"></a>
-<span class="sourceLineNo">120</span> } catch (IOException e) {<a
name="line.120"></a>
-<span class="sourceLineNo">121</span> if (!isRollbackSupported(state))
{<a name="line.121"></a>
-<span class="sourceLineNo">122</span> // We reach a state that cannot
be rolled back. We just need to keep retry.<a name="line.122"></a>
-<span class="sourceLineNo">123</span> LOG.warn("Error trying to delete
the column family " + getColumnFamilyName()<a name="line.123"></a>
-<span class="sourceLineNo">124</span> + " from table " + tableName +
"(in state=" + state + ")", e);<a name="line.124"></a>
-<span class="sourceLineNo">125</span> } else {<a name="line.125"></a>
-<span class="sourceLineNo">126</span> LOG.error("Error trying to delete
the column family " + getColumnFamilyName()<a name="line.126"></a>
-<span class="sourceLineNo">127</span> + " from table " + tableName +
"(in state=" + state + ")", e);<a name="line.127"></a>
-<span class="sourceLineNo">128</span>
setFailure("master-delete-column-family", e);<a name="line.128"></a>
-<span class="sourceLineNo">129</span> }<a name="line.129"></a>
-<span class="sourceLineNo">130</span> }<a name="line.130"></a>
-<span class="sourceLineNo">131</span> return Flow.HAS_MORE_STATE;<a
name="line.131"></a>
-<span class="sourceLineNo">132</span> }<a name="line.132"></a>
-<span class="sourceLineNo">133</span><a name="line.133"></a>
-<span class="sourceLineNo">134</span> @Override<a name="line.134"></a>
-<span class="sourceLineNo">135</span> protected void rollbackState(final
MasterProcedureEnv env, final DeleteColumnFamilyState state)<a
name="line.135"></a>
-<span class="sourceLineNo">136</span> throws IOException {<a
name="line.136"></a>
-<span class="sourceLineNo">137</span> if (isTraceEnabled()) {<a
name="line.137"></a>
-<span class="sourceLineNo">138</span> LOG.trace(this + " rollback state="
+ state);<a name="line.138"></a>
-<span class="sourceLineNo">139</span> }<a name="line.139"></a>
-<span class="sourceLineNo">140</span> try {<a name="line.140"></a>
-<span class="sourceLineNo">141</span> switch (state) {<a
name="line.141"></a>
-<span class="sourceLineNo">142</span> case
DELETE_COLUMN_FAMILY_REOPEN_ALL_REGIONS:<a name="line.142"></a>
-<span class="sourceLineNo">143</span> break; // Nothing to undo.<a
name="line.143"></a>
-<span class="sourceLineNo">144</span> case
DELETE_COLUMN_FAMILY_POST_OPERATION:<a name="line.144"></a>
-<span class="sourceLineNo">145</span> // TODO-MAYBE: call the
coprocessor event to undo?<a name="line.145"></a>
-<span class="sourceLineNo">146</span> break;<a name="line.146"></a>
-<span class="sourceLineNo">147</span> case
DELETE_COLUMN_FAMILY_DELETE_FS_LAYOUT:<a name="line.147"></a>
-<span class="sourceLineNo">148</span> // Once we reach to this state -
we could NOT rollback - as it is tricky to undelete<a name="line.148"></a>
-<span class="sourceLineNo">149</span> // the deleted files. We are not
suppose to reach here, throw exception so that we know<a name="line.149"></a>
-<span class="sourceLineNo">150</span> // there is a code bug to
investigate.<a name="line.150"></a>
-<span class="sourceLineNo">151</span> throw new
UnsupportedOperationException(this + " rollback of state=" + state<a
name="line.151"></a>
-<span class="sourceLineNo">152</span> + " is unsupported.");<a
name="line.152"></a>
-<span class="sourceLineNo">153</span> case
DELETE_COLUMN_FAMILY_UPDATE_TABLE_DESCRIPTOR:<a name="line.153"></a>
-<span class="sourceLineNo">154</span> restoreTableDescriptor(env);<a
name="line.154"></a>
-<span class="sourceLineNo">155</span> break;<a name="line.155"></a>
-<span class="sourceLineNo">156</span> case
DELETE_COLUMN_FAMILY_PRE_OPERATION:<a name="line.156"></a>
-<span class="sourceLineNo">157</span> // TODO-MAYBE: call the
coprocessor event to undo?<a name="line.157"></a>
-<span class="sourceLineNo">158</span> break;<a name="line.158"></a>
-<span class="sourceLineNo">159</span> case
DELETE_COLUMN_FAMILY_PREPARE:<a name="line.159"></a>
-<span class="sourceLineNo">160</span> break; // nothing to do<a
name="line.160"></a>
-<span class="sourceLineNo">161</span> default:<a name="line.161"></a>
-<span class="sourceLineNo">162</span> throw new
UnsupportedOperationException(this + " unhandled state=" + state);<a
name="line.162"></a>
-<span class="sourceLineNo">163</span> }<a name="line.163"></a>
-<span class="sourceLineNo">164</span> } catch (IOException e) {<a
name="line.164"></a>
-<span class="sourceLineNo">165</span> // This will be retried. Unless
there is a bug in the code,<a name="line.165"></a>
-<span class="sourceLineNo">166</span> // this should be just a "temporary
error" (e.g. network down)<a name="line.166"></a>
-<span class="sourceLineNo">167</span> LOG.warn("Failed rollback attempt
step " + state + " for deleting the column family"<a name="line.167"></a>
-<span class="sourceLineNo">168</span> + getColumnFamilyName() + " to
the table " + tableName, e);<a name="line.168"></a>
-<span class="sourceLineNo">169</span> throw e;<a name="line.169"></a>
-<span class="sourceLineNo">170</span> }<a name="line.170"></a>
-<span class="sourceLineNo">171</span> }<a name="line.171"></a>
-<span class="sourceLineNo">172</span><a name="line.172"></a>
-<span class="sourceLineNo">173</span> @Override<a name="line.173"></a>
-<span class="sourceLineNo">174</span> protected DeleteColumnFamilyState
getState(final int stateId) {<a name="line.174"></a>
-<span class="sourceLineNo">175</span> return
DeleteColumnFamilyState.valueOf(stateId);<a name="line.175"></a>
-<span class="sourceLineNo">176</span> }<a name="line.176"></a>
-<span class="sourceLineNo">177</span><a name="line.177"></a>
-<span class="sourceLineNo">178</span> @Override<a name="line.178"></a>
-<span class="sourceLineNo">179</span> protected int getStateId(final
DeleteColumnFamilyState state) {<a name="line.179"></a>
-<span class="sourceLineNo">180</span> return state.getNumber();<a
name="line.180"></a>
-<span class="sourceLineNo">181</span> }<a name="line.181"></a>
-<span class="sourceLineNo">182</span><a name="line.182"></a>
-<span class="sourceLineNo">183</span> @Override<a name="line.183"></a>
-<span class="sourceLineNo">184</span> protected DeleteColumnFamilyState
getInitialState() {<a name="line.184"></a>
-<span class="sourceLineNo">185</span> return
DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_PREPARE;<a name="line.185"></a>
-<span class="sourceLineNo">186</span> }<a name="line.186"></a>
-<span class="sourceLineNo">187</span><a name="line.187"></a>
-<span class="sourceLineNo">188</span> @Override<a name="line.188"></a>
-<span class="sourceLineNo">189</span> protected void
setNextState(DeleteColumnFamilyState state) {<a name="line.189"></a>
-<span class="sourceLineNo">190</span> if (aborted.get() &&
isRollbackSupported(state)) {<a name="line.190"></a>
-<span class="sourceLineNo">191</span>
setAbortFailure("delete-columnfamily", "abort requested");<a
name="line.191"></a>
-<span class="sourceLineNo">192</span> } else {<a name="line.192"></a>
-<span class="sourceLineNo">193</span> super.setNextState(state);<a
name="line.193"></a>
-<span class="sourceLineNo">194</span> }<a name="line.194"></a>
-<span class="sourceLineNo">195</span> }<a name="line.195"></a>
-<span class="sourceLineNo">196</span><a name="line.196"></a>
-<span class="sourceLineNo">197</span> @Override<a name="line.197"></a>
-<span class="sourceLineNo">198</span> public boolean abort(final
MasterProcedureEnv env) {<a name="line.198"></a>
-<span class="sourceLineNo">199</span> aborted.set(true);<a
name="line.199"></a>
-<span class="sourceLineNo">200</span> return true;<a name="line.200"></a>
-<span class="sourceLineNo">201</span> }<a name="line.201"></a>
-<span class="sourceLineNo">202</span><a name="line.202"></a>
-<span class="sourceLineNo">203</span> @Override<a name="line.203"></a>
-<span class="sourceLineNo">204</span> protected boolean acquireLock(final
MasterProcedureEnv env) {<a name="line.204"></a>
-<span class="sourceLineNo">205</span> if (!env.isInitialized()) return
false;<a name="line.205"></a>
-<span class="sourceLineNo">206</span> return
env.getProcedureQueue().tryAcquireTableExclusiveLock(<a name="line.206"></a>
-<span class="sourceLineNo">207</span> tableName,<a name="line.207"></a>
-<span class="sourceLineNo">208</span>
EventType.C_M_DELETE_FAMILY.toString());<a name="line.208"></a>
-<span class="sourceLineNo">209</span> }<a name="line.209"></a>
-<span class="sourceLineNo">210</span><a name="line.210"></a>
-<span class="sourceLineNo">211</span> @Override<a name="line.211"></a>
-<span class="sourceLineNo">212</span> protected void releaseLock(final
MasterProcedureEnv env) {<a name="line.212"></a>
-<span class="sourceLineNo">213</span>
env.getProcedureQueue().releaseTableExclusiveLock(tableName);<a
name="line.213"></a>
-<span class="sourceLineNo">214</span> }<a name="line.214"></a>
-<span class="sourceLineNo">215</span><a name="line.215"></a>
-<span class="sourceLineNo">216</span> @Override<a name="line.216"></a>
-<span class="sourceLineNo">217</span> public void serializeStateData(final
OutputStream stream) throws IOException {<a name="line.217"></a>
-<span class="sourceLineNo">218</span> super.serializeStateData(stream);<a
name="line.218"></a>
-<span class="sourceLineNo">219</span><a name="line.219"></a>
-<span class="sourceLineNo">220</span>
MasterProcedureProtos.DeleteColumnFamilyStateData.Builder deleteCFMsg =<a
name="line.220"></a>
-<span class="sourceLineNo">221</span>
MasterProcedureProtos.DeleteColumnFamilyStateData.newBuilder()<a
name="line.221"></a>
-<span class="sourceLineNo">222</span>
.setUserInfo(MasterProcedureUtil.toProtoUserInfo(user))<a name="line.222"></a>
-<span class="sourceLineNo">223</span>
.setTableName(ProtobufUtil.toProtoTableName(tableName))<a name="line.223"></a>
-<span class="sourceLineNo">224</span>
.setColumnfamilyName(ByteStringer.wrap(familyName));<a name="line.224"></a>
-<span class="sourceLineNo">225</span> if (unmodifiedHTableDescriptor !=
null) {<a name="line.225"></a>
-<span class="sourceLineNo">226</span>
deleteCFMsg.setUnmodifiedTableSchema(unmodifiedHTableDescriptor.convert());<a
name="line.226"></a>
-<span class="sourceLineNo">227</span> }<a name="line.227"></a>
+<span class="sourceLineNo">036</span>import
org.apache.hadoop.hbase.master.MasterCoprocessorHost;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import
org.apache.hadoop.hbase.procedure2.StateMachineProcedure;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import
org.apache.hadoop.hbase.protobuf.ProtobufUtil;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import
org.apache.hadoop.hbase.protobuf.generated.MasterProcedureProtos;<a
name="line.39"></a>
+<span class="sourceLineNo">040</span>import
org.apache.hadoop.hbase.protobuf.generated.MasterProcedureProtos.DeleteColumnFamilyState;<a
name="line.40"></a>
+<span class="sourceLineNo">041</span>import
org.apache.hadoop.hbase.util.ByteStringer;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import
org.apache.hadoop.hbase.util.Bytes;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import
org.apache.hadoop.security.UserGroupInformation;<a name="line.43"></a>
+<span class="sourceLineNo">044</span><a name="line.44"></a>
+<span class="sourceLineNo">045</span>/**<a name="line.45"></a>
+<span class="sourceLineNo">046</span> * The procedure to delete a column
family from an existing table.<a name="line.46"></a>
+<span class="sourceLineNo">047</span> */<a name="line.47"></a>
+<span class="sourceLineNo">048</span>@InterfaceAudience.Private<a
name="line.48"></a>
+<span class="sourceLineNo">049</span>public class
DeleteColumnFamilyProcedure<a name="line.49"></a>
+<span class="sourceLineNo">050</span> extends
StateMachineProcedure<MasterProcedureEnv, DeleteColumnFamilyState><a
name="line.50"></a>
+<span class="sourceLineNo">051</span> implements TableProcedureInterface
{<a name="line.51"></a>
+<span class="sourceLineNo">052</span> private static final Log LOG =
LogFactory.getLog(DeleteColumnFamilyProcedure.class);<a name="line.52"></a>
+<span class="sourceLineNo">053</span><a name="line.53"></a>
+<span class="sourceLineNo">054</span> private final AtomicBoolean aborted =
new AtomicBoolean(false);<a name="line.54"></a>
+<span class="sourceLineNo">055</span><a name="line.55"></a>
+<span class="sourceLineNo">056</span> private HTableDescriptor
unmodifiedHTableDescriptor;<a name="line.56"></a>
+<span class="sourceLineNo">057</span> private TableName tableName;<a
name="line.57"></a>
+<span class="sourceLineNo">058</span> private byte [] familyName;<a
name="line.58"></a>
+<span class="sourceLineNo">059</span> private boolean hasMob;<a
name="line.59"></a>
+<span class="sourceLineNo">060</span> private UserGroupInformation user;<a
name="line.60"></a>
+<span class="sourceLineNo">061</span><a name="line.61"></a>
+<span class="sourceLineNo">062</span> private List<HRegionInfo>
regionInfoList;<a name="line.62"></a>
+<span class="sourceLineNo">063</span> private Boolean traceEnabled;<a
name="line.63"></a>
+<span class="sourceLineNo">064</span><a name="line.64"></a>
+<span class="sourceLineNo">065</span> public DeleteColumnFamilyProcedure()
{<a name="line.65"></a>
+<span class="sourceLineNo">066</span> this.unmodifiedHTableDescriptor =
null;<a name="line.66"></a>
+<span class="sourceLineNo">067</span> this.regionInfoList = null;<a
name="line.67"></a>
+<span class="sourceLineNo">068</span> this.traceEnabled = null;<a
name="line.68"></a>
+<span class="sourceLineNo">069</span> }<a name="line.69"></a>
+<span class="sourceLineNo">070</span><a name="line.70"></a>
+<span class="sourceLineNo">071</span> public DeleteColumnFamilyProcedure(<a
name="line.71"></a>
+<span class="sourceLineNo">072</span> final MasterProcedureEnv env,<a
name="line.72"></a>
+<span class="sourceLineNo">073</span> final TableName tableName,<a
name="line.73"></a>
+<span class="sourceLineNo">074</span> final byte[] familyName) throws
IOException {<a name="line.74"></a>
+<span class="sourceLineNo">075</span> this.tableName = tableName;<a
name="line.75"></a>
+<span class="sourceLineNo">076</span> this.familyName = familyName;<a
name="line.76"></a>
+<span class="sourceLineNo">077</span> this.user =
env.getRequestUser().getUGI();<a name="line.77"></a>
+<span class="sourceLineNo">078</span>
this.setOwner(this.user.getShortUserName());<a name="line.78"></a>
+<span class="sourceLineNo">079</span> this.unmodifiedHTableDescriptor =
null;<a name="line.79"></a>
+<span class="sourceLineNo">080</span> this.regionInfoList = null;<a
name="line.80"></a>
+<span class="sourceLineNo">081</span> this.traceEnabled = null;<a
name="line.81"></a>
+<span class="sourceLineNo">082</span> }<a name="line.82"></a>
+<span class="sourceLineNo">083</span><a name="line.83"></a>
+<span class="sourceLineNo">084</span> @Override<a name="line.84"></a>
+<span class="sourceLineNo">085</span> protected Flow executeFromState(final
MasterProcedureEnv env, DeleteColumnFamilyState state)<a name="line.85"></a>
+<span class="sourceLineNo">086</span> throws InterruptedException {<a
name="line.86"></a>
+<span class="sourceLineNo">087</span> if (isTraceEnabled()) {<a
name="line.87"></a>
+<span class="sourceLineNo">088</span> LOG.trace(this + " execute state="
+ state);<a name="line.88"></a>
+<span class="sourceLineNo">089</span> }<a name="line.89"></a>
+<span class="sourceLineNo">090</span><a name="line.90"></a>
+<span class="sourceLineNo">091</span> try {<a name="line.91"></a>
+<span class="sourceLineNo">092</span> switch (state) {<a
name="line.92"></a>
+<span class="sourceLineNo">093</span> case
DELETE_COLUMN_FAMILY_PREPARE:<a name="line.93"></a>
+<span class="sourceLineNo">094</span> prepareDelete(env);<a
name="line.94"></a>
+<span class="sourceLineNo">095</span>
setNextState(DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_PRE_OPERATION);<a
name="line.95"></a>
+<span class="sourceLineNo">096</span> break;<a name="line.96"></a>
+<span class="sourceLineNo">097</span> case
DELETE_COLUMN_FAMILY_PRE_OPERATION:<a name="line.97"></a>
+<span class="sourceLineNo">098</span> preDelete(env, state);<a
name="line.98"></a>
+<span class="sourceLineNo">099</span>
setNextState(DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_UPDATE_TABLE_DESCRIPTOR);<a
name="line.99"></a>
+<span class="sourceLineNo">100</span> break;<a name="line.100"></a>
+<span class="sourceLineNo">101</span> case
DELETE_COLUMN_FAMILY_UPDATE_TABLE_DESCRIPTOR:<a name="line.101"></a>
+<span class="sourceLineNo">102</span> updateTableDescriptor(env);<a
name="line.102"></a>
+<span class="sourceLineNo">103</span>
setNextState(DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_DELETE_FS_LAYOUT);<a
name="line.103"></a>
+<span class="sourceLineNo">104</span> break;<a name="line.104"></a>
+<span class="sourceLineNo">105</span> case
DELETE_COLUMN_FAMILY_DELETE_FS_LAYOUT:<a name="line.105"></a>
+<span class="sourceLineNo">106</span> deleteFromFs(env);<a
name="line.106"></a>
+<span class="sourceLineNo">107</span>
setNextState(DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_POST_OPERATION);<a
name="line.107"></a>
+<span class="sourceLineNo">108</span> break;<a name="line.108"></a>
+<span class="sourceLineNo">109</span> case
DELETE_COLUMN_FAMILY_POST_OPERATION:<a name="line.109"></a>
+<span class="sourceLineNo">110</span> postDelete(env, state);<a
name="line.110"></a>
+<span class="sourceLineNo">111</span>
setNextState(DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_REOPEN_ALL_REGIONS);<a
name="line.111"></a>
+<span class="sourceLineNo">112</span> break;<a name="line.112"></a>
+<span class="sourceLineNo">113</span> case
DELETE_COLUMN_FAMILY_REOPEN_ALL_REGIONS:<a name="line.113"></a>
+<span class="sourceLineNo">114</span>
reOpenAllRegionsIfTableIsOnline(env);<a name="line.114"></a>
+<span class="sourceLineNo">115</span> return Flow.NO_MORE_STATE;<a
name="line.115"></a>
+<span class="sourceLineNo">116</span> default:<a name="line.116"></a>
+<span class="sourceLineNo">117</span> throw new
UnsupportedOperationException(this + " unhandled state=" + state);<a
name="line.117"></a>
+<span class="sourceLineNo">118</span> }<a name="line.118"></a>
+<span class="sourceLineNo">119</span> } catch (IOException e) {<a
name="line.119"></a>
+<span class="sourceLineNo">120</span> if (!isRollbackSupported(state))
{<a name="line.120"></a>
+<span class="sourceLineNo">121</span> // We reach a state that cannot
be rolled back. We just need to keep retry.<a name="line.121"></a>
+<span class="sourceLineNo">122</span> LOG.warn("Error trying to delete
the column family " + getColumnFamilyName()<a name="line.122"></a>
+<span class="sourceLineNo">123</span> + " from table " + tableName +
"(in state=" + state + ")", e);<a name="line.123"></a>
+<span class="sourceLineNo">124</span> } else {<a name="line.124"></a>
+<span class="sourceLineNo">125</span> LOG.error("Error trying to delete
the column family " + getColumnFamilyName()<a name="line.125"></a>
+<span class="sourceLineNo">126</span> + " from table " + tableName +
"(in state=" + state + ")", e);<a name="line.126"></a>
+<span class="sourceLineNo">127</span>
setFailure("master-delete-column-family", e);<a name="line.127"></a>
+<span class="sourceLineNo">128</span> }<a name="line.128"></a>
+<span class="sourceLineNo">129</span> }<a name="line.129"></a>
+<span class="sourceLineNo">130</span> return Flow.HAS_MORE_STATE;<a
name="line.130"></a>
+<span class="sourceLineNo">131</span> }<a name="line.131"></a>
+<span class="sourceLineNo">132</span><a name="line.132"></a>
+<span class="sourceLineNo">133</span> @Override<a name="line.133"></a>
+<span class="sourceLineNo">134</span> protected void rollbackState(final
MasterProcedureEnv env, final DeleteColumnFamilyState state)<a
name="line.134"></a>
+<span class="sourceLineNo">135</span> throws IOException {<a
name="line.135"></a>
+<span class="sourceLineNo">136</span> if (isTraceEnabled()) {<a
name="line.136"></a>
+<span class="sourceLineNo">137</span> LOG.trace(this + " rollback state="
+ state);<a name="line.137"></a>
+<span class="sourceLineNo">138</span> }<a name="line.138"></a>
+<span class="sourceLineNo">139</span> try {<a name="line.139"></a>
+<span class="sourceLineNo">140</span> switch (state) {<a
name="line.140"></a>
+<span class="sourceLineNo">141</span> case
DELETE_COLUMN_FAMILY_REOPEN_ALL_REGIONS:<a name="line.141"></a>
+<span class="sourceLineNo">142</span> break; // Nothing to undo.<a
name="line.142"></a>
+<span class="sourceLineNo">143</span> case
DELETE_COLUMN_FAMILY_POST_OPERATION:<a name="line.143"></a>
+<span class="sourceLineNo">144</span> // TODO-MAYBE: call the
coprocessor event to undo?<a name="line.144"></a>
+<span class="sourceLineNo">145</span> break;<a name="line.145"></a>
+<span class="sourceLineNo">146</span> case
DELETE_COLUMN_FAMILY_DELETE_FS_LAYOUT:<a name="line.146"></a>
+<span class="sourceLineNo">147</span> // Once we reach to this state -
we could NOT rollback - as it is tricky to undelete<a name="line.147"></a>
+<span class="sourceLineNo">148</span> // the deleted files. We are not
suppose to reach here, throw exception so that we know<a name="line.148"></a>
+<span class="sourceLineNo">149</span> // there is a code bug to
investigate.<a name="line.149"></a>
+<span class="sourceLineNo">150</span> throw new
UnsupportedOperationException(this + " rollback of state=" + state<a
name="line.150"></a>
+<span class="sourceLineNo">151</span> + " is unsupported.");<a
name="line.151"></a>
+<span class="sourceLineNo">152</span> case
DELETE_COLUMN_FAMILY_UPDATE_TABLE_DESCRIPTOR:<a name="line.152"></a>
+<span class="sourceLineNo">153</span> restoreTableDescriptor(env);<a
name="line.153"></a>
+<span class="sourceLineNo">154</span> break;<a name="line.154"></a>
+<span class="sourceLineNo">155</span> case
DELETE_COLUMN_FAMILY_PRE_OPERATION:<a name="line.155"></a>
+<span class="sourceLineNo">156</span> // TODO-MAYBE: call the
coprocessor event to undo?<a name="line.156"></a>
+<span class="sourceLineNo">157</span> break;<a name="line.157"></a>
+<span class="sourceLineNo">158</span> case
DELETE_COLUMN_FAMILY_PREPARE:<a name="line.158"></a>
+<span class="sourceLineNo">159</span> break; // nothing to do<a
name="line.159"></a>
+<span class="sourceLineNo">160</span> default:<a name="line.160"></a>
+<span class="sourceLineNo">161</span> throw new
UnsupportedOperationException(this + " unhandled state=" + state);<a
name="line.161"></a>
+<span class="sourceLineNo">162</span> }<a name="line.162"></a>
+<span class="sourceLineNo">163</span> } catch (IOException e) {<a
name="line.163"></a>
+<span class="sourceLineNo">164</span> // This will be retried. Unless
there is a bug in the code,<a name="line.164"></a>
+<span class="sourceLineNo">165</span> // this should be just a "temporary
error" (e.g. network down)<a name="line.165"></a>
+<span class="sourceLineNo">166</span> LOG.warn("Failed rollback attempt
step " + state + " for deleting the column family"<a name="line.166"></a>
+<span class="sourceLineNo">167</span> + getColumnFamilyName() + " to
the table " + tableName, e);<a name="line.167"></a>
+<span class="sourceLineNo">168</span> throw e;<a name="line.168"></a>
+<span class="sourceLineNo">169</span> }<a name="line.169"></a>
+<span class="sourceLineNo">170</span> }<a name="line.170"></a>
+<span class="sourceLineNo">171</span><a name="line.171"></a>
+<span class="sourceLineNo">172</span> @Override<a name="line.172"></a>
+<span class="sourceLineNo">173</span> protected DeleteColumnFamilyState
getState(final int stateId) {<a name="line.173"></a>
+<span class="sourceLineNo">174</span> return
DeleteColumnFamilyState.valueOf(stateId);<a name="line.174"></a>
+<span class="sourceLineNo">175</span> }<a name="line.175"></a>
+<span class="sourceLineNo">176</span><a name="line.176"></a>
+<span class="sourceLineNo">177</span> @Override<a name="line.177"></a>
+<span class="sourceLineNo">178</span> protected int getStateId(final
DeleteColumnFamilyState state) {<a name="line.178"></a>
+<span class="sourceLineNo">179</span> return state.getNumber();<a
name="line.179"></a>
+<span class="sourceLineNo">180</span> }<a name="line.180"></a>
+<span class="sourceLineNo">181</span><a name="line.181"></a>
+<span class="sourceLineNo">182</span> @Override<a name="line.182"></a>
+<span class="sourceLineNo">183</span> protected DeleteColumnFamilyState
getInitialState() {<a name="line.183"></a>
+<span class="sourceLineNo">184</span> return
DeleteColumnFamilyState.DELETE_COLUMN_FAMILY_PREPARE;<a name="line.184"></a>
+<span class="sourceLineNo">185</span> }<a name="line.185"></a>
+<span class="sourceLineNo">186</span><a name="line.186"></a>
+<span class="sourceLineNo">187</span> @Override<a name="line.187"></a>
+<span class="sourceLineNo">188</span> protected void
setNextState(DeleteColumnFamilyState state) {<a name="line.188"></a>
+<span class="sourceLineNo">189</span> if (aborted.get() &&
isRollbackSupported(state)) {<a name="line.189"></a>
+<span class="sourceLineNo">190</span>
setAbortFailure("delete-columnfamily", "abort requested");<a
name="line.190"></a>
+<span class="sourceLineNo">191</span> } else {<a name="line.191"></a>
+<span class="sourceLineNo">192</span> super.setNextState(state);<a
name="line.192"></a>
+<span class="sourceLineNo">193</span> }<a name="line.193"></a>
+<span class="sourceLineNo">194</span> }<a name="line.194"></a>
+<span class="sourceLineNo">195</span><a name="line.195"></a>
+<span class="sourceLineNo">196</span> @Override<a name="line.196"></a>
+<span class="sourceLineNo">197</span> public boolean abort(final
MasterProcedureEnv env) {<a name="line.197"></a>
+<span class="sourceLineNo">198</span> aborted.set(true);<a
name="line.198"></a>
+<span class="sourceLineNo">199</span> return true;<a name="line.199"></a>
+<span class="sourceLineNo">200</span> }<a name="line.200"></a>
+<span class="sourceLineNo">201</span><a name="line.201"></a>
+<span class="sourceLineNo">202</span> @Override<a name="line.202"></a>
+<span class="sourceLineNo">203</span> protected boolean acquireLock(final
MasterProcedureEnv env) {<a name="line.203"></a>
+<span class="sourceLineNo">204</span> if (env.waitInitialized(this)) return
false;<a name="line.204"></a>
+<span class="sourceLineNo">205</span> return
env.getProcedureQueue().tryAcquireTableExclusiveLock(tableName, "delete
family");<a name="line.205"></a>
+<span class="sourceLineNo">206</span> }<a name="line.206"></a>
+<span class="sourceLineNo">207</span><a name="line.207"></a>
+<span class="sourceLineNo">208</span> @Override<a name="line.208"></a>
+<span class="sourceLineNo">209</span> protected void releaseLock(final
MasterProcedureEnv env) {<a name="line.209"></a>
+<span class="sourceLineNo">210</span>
env.getProcedureQueue().releaseTableExclusiveLock(tableName);<a
name="line.210"></a>
+<span class="sourceLineNo">211</span> }<a name="line.211"></a>
+<span class="sourceLineNo">212</span><a name="line.212"></a>
+<span class="sourceLineNo">213</span> @Override<a name="line.213"></a>
+<span class="sourceLineNo">214</span> public void serializeStateData(final
OutputStream stream) throws IOException {<a name="line.214"></a>
+<span class="sourceLineNo">215</span> super.serializeStateData(stream);<a
name="line.215"></a>
+<span class="sourceLineNo">216</span><a name="line.216"></a>
+<span class="sourceLineNo">217</span>
MasterProcedureProtos.DeleteColumnFamilyStateData.Builder deleteCFMsg =<a
name="line.217"></a>
+<span class="sourceLineNo">218</span>
MasterProcedureProtos.DeleteColumnFamilyStateData.newBuilder()<a
name="line.218"></a>
+<span class="sourceLineNo">219</span>
.setUserInfo(MasterProcedureUtil.toProtoUserInfo(user))<a name="line.219"></a>
+<span class="sourceLineNo">220</span>
.setTableName(ProtobufUtil.toProtoTableName(tableName))<a name="line.220"></a>
+<span class="sourceLineNo">221</span>
.setColumnfamilyName(ByteStringer.wrap(familyName));<a name="line.221"></a>
+<span class="sourceLineNo">222</span> if (unmodifiedHTableDescriptor !=
null) {<a name="line.222"></a>
+<span class="sourceLineNo">223</span>
deleteCFMsg.setUnmodifiedTableSchema(unmodifiedHTableDescriptor.convert());<a
name="line.223"></a>
+<span class="sourceLineNo">224</span> }<a name="line.224"></a>
+<span class="sourceLineNo">225</span><a name="line.225"></a>
+<span class="sourceLineNo">226</span>
deleteCFMsg.build().writeDelimitedTo(stream);<a name="line.226"></a>
+<span class="sourceLineNo">227</span> }<a name="line.227"></a>
<span class="sourceLineNo">228</span><a name="line.228"></a>
-<span class="sourceLineNo">229</span>
deleteCFMsg.build().writeDelimitedTo(stream);<a name="line.229"></a>
-<span class="sourceLineNo">230</span> }<a name="line.230"></a>
-<span class="sourceLineNo">231</span><a name="line.231"></a>
-<span class="sourceLineNo">232</span> @Override<a name="line.232"></a>
-<span class="sourceLineNo">233</span> public void deserializeStateData(final
InputStream stream) throws IOException {<a name="line.233"></a>
-<span class="sourceLineNo">234</span> super.deserializeStateData(stream);<a
name="line.234"></a>
-<span class="sourceLineNo">235</span>
MasterProcedureProtos.DeleteColumnFamilyStateData deleteCFMsg =<a
name="line.235"></a>
-<span class="sourceLineNo">236</span>
MasterProcedureProtos.DeleteColumnFamilyStateData.parseDelimitedFrom(stream);<a
name="line.236"></a>
-<span class="sourceLineNo">237</span> user =
MasterProcedureUtil.toUserInfo(deleteCFMsg.getUserInfo());<a
name="line.237"></a>
-<span class="sourceLineNo">238</span> tableName =
ProtobufUtil.toTableName(deleteCFMsg.getTableName());<a name="line.238"></a>
-<span class="sourceLineNo">239</span> familyName =
deleteCFMsg.getColumnfamilyName().toByteArray();<a name="line.239"></a>
-<span class="sourceLineNo">240</span><a name="line.240"></a>
-<span class="sourceLineNo">241</span> if
(deleteCFMsg.hasUnmodifiedTableSchema()) {<a name="line.241"></a>
-<span class="sourceLineNo">242</span> unmodifiedHTableDescriptor =
HTableDescriptor.convert(deleteCFMsg.getUnmodifiedTableSchema());<a
name="line.242"></a>
-<span class="sourceLineNo">243</span> }<a name="line.243"></a>
-<span class="sourceLineNo">244</span> }<a name="line.244"></a>
-<span class="sourceLineNo">245</span><a name="line.245"></a>
-<span class="sourceLineNo">246</span> @Override<a name="line.246"></a>
-<span class="sourceLineNo">247</span> public void
toStringClassDetails(StringBuilder sb) {<a name="line.247"></a>
-<span class="sourceLineNo">248</span>
sb.append(getClass().getSimpleName());<a name="line.248"></a>
-<span class="sourceLineNo">249</span> sb.append(" (table=");<a
name="line.249"></a>
-<span class="sourceLineNo">250</span> sb.append(tableName);<a
name="line.250"></a>
-<span class="sourceLineNo">251</span> sb.append(", columnfamily=");<a
name="line.251"></a>
-<span class="sourceLineNo">252</span> if (familyName != null) {<a
name="line.252"></a>
-<span class="sourceLineNo">253</span> sb.append(getColumnFamilyName());<a
name="line.253"></a>
-<span class="sourceLineNo">254</span> } else {<a name="line.254"></a>
-<span class="sourceLineNo">255</span> sb.append("Unknown");<a
name="line.255"></a>
-<span class="sourceLineNo">256</span> }<a name="line.256"></a>
-<span class="sourceLineNo">257</span> sb.append(")");<a name="line.257"></a>
-<span class="sourceLineNo">258</span> }<a name="line.258"></a>
-<span class="sourceLineNo">259</span><a name="line.259"></a>
-<span class="sourceLineNo">260</span> @Override<a name="line.260"></a>
-<span class="sourceLineNo">261</span> public TableName getTableName() {<a
name="line.261"></a>
-<span class="sourceLineNo">262</span> return tableName;<a
name="line.262"></a>
-<span class="sourceLineNo">263</span> }<a name="line.263"></a>
-<span class="sourceLineNo">264</span><a name="line.264"></a>
-<span class="sourceLineNo">265</span> @Override<a name="line.265"></a>
-<span class="sourceLineNo">266</span> public TableOperationType
getTableOperationType() {<a name="line.266"></a>
-<span class="sourceLineNo">267</span> return TableOperationType.EDIT;<a
name="line.267"></a>
-<span class="sourceLineNo">268</span> }<a name="line.268"></a>
-<span class="sourceLineNo">269</span><a name="line.269"></a>
-<span class="sourceLineNo">270</span> /**<a name="line.270"></a>
-<span class="sourceLineNo">271</span> * Action before any real action of
deleting column family.<a name="line.271"></a>
-<span class="sourceLineNo">272</span> * @param env MasterProcedureEnv<a
name="line.272"></a>
-<span class="sourceLineNo">273</span> * @throws IOException<a
name="line.273"></a>
-<span class="sourceLineNo">274</span> */<a name="line.274"></a>
-<span class="sourceLineNo">275</span> private void prepareDelete(final
MasterProcedureEnv env) throws IOException {<a name="line.275"></a>
-<span class="sourceLineNo">276</span> // Checks whether the table is
allowed to be modified.<a name="line.276"></a>
-<span class="sourceLineNo">277</span>
MasterDDLOperationHelper.checkTableModifiable(env, tableName);<a
name="line.277"></a>
-<span class="sourceLineNo">278</span><a name="line.278"></a>
-<span class="sourceLineNo">279</span> // In order to update the descriptor,
we need to retrieve the old descriptor for comparison.<a name="line.279"></a>
-<span class="sourceLineNo">280</span> unmodifiedHTableDescriptor =
env.getMasterServices().getTableDescriptors().get(tableName);<a
name="line.280"></a>
-<span class="sourceLineNo">281</span> if (unmodifiedHTableDescriptor ==
null) {<a name="line.281"></a>
-<span class="sourceLineNo">282</span> throw new
IOException("HTableDescriptor missing for " + tableName);<a name="line.282"></a>
-<span class="sourceLineNo">283</span> }<a name="line.283"></a>
-<span class="sourceLineNo">284</span> if
(!unmodifiedHTableDescriptor.hasFamily(familyName)) {<a name="line.284"></a>
-<span class="sourceLineNo">285</span> throw new
InvalidFamilyOperationException("Family '" + getColumnFamilyName()<a
name="line.285"></a>
-<span class="sourceLineNo">286</span> + "' does not exist, so it
cannot be deleted");<a name="line.286"></a>
-<span class="sourceLineNo">287</span> }<a name="line.287"></a>
-<span class="sourceLineNo">288</span><a name="line.288"></a>
-<span class="sourceLineNo">289</span> if
(unmodifiedHTableDescriptor.getColumnFamilies().length == 1) {<a
name="line.289"></a>
-<span class="sourceLineNo">290</span> throw new
InvalidFamilyOperationException("Family '" + getColumnFamilyName()<a
name="line.290"></a>
-<span class="sourceLineNo">291</span> + "' is the only column family in
the table, so it cannot be deleted");<a name="line.291"></a>
-<span class="sourceLineNo">292</span> }<a name="line.292"></a>
-<span class="sourceLineNo">293</span><a name="line.293"></a>
-<span class="sourceLineNo">294</span> // whether mob family<a
name="line.294"></a>
-<span class="sourceLineNo">295</span> hasMob =
unmodifiedHTableDescriptor.getFamily(familyName).isMobEnabled();<a
name="line.295"></a>
-<span class="sourceLineNo">296</span> }<a name="line.296"></a>
-<span class="sourceLineNo">297</span><a name="line.297"></a>
-<span class="sourceLineNo">298</span> /**<a name="line.298"></a>
-<span class="sourceLineNo">299</span> * Action before deleting column
family.<a name="line.299"></a>
-<span class="sourceLineNo">300</span> * @param env MasterProcedureEnv<a
name="line.300"></a>
-<span class="sourceLineNo">301</span> * @param state the procedure state<a
name="line.301"></a>
-<span class="sourceLineNo">302</span> * @throws IOException<a
name="line.302"></a>
-<span class="sourceLineNo">303</span> * @throws InterruptedException<a
name="line.303"></a>
-<span class="sourceLineNo">304</span> */<a name="line.304"></a>
-<span class="sourceLineNo">305</span> private void preDelete(final
MasterProcedureEnv env, final DeleteColumnFamilyState state)<a
name="line.305"></a>
-<span class="sourceLineNo">306</span> throws IOException,
InterruptedException {<a name="line.306"></a>
-<span class="sourceLineNo">307</span> runCoprocessorAction(env, state);<a
name="line.307"></a>
-<span class="sourceLineNo">308</span> }<a name="line.308"></a>
-<span class="sourceLineNo">309</span><a name="line.309"></a>
-<span class="sourceLineNo">310</span> /**<a name="line.310"></a>
-<span class="sourceLineNo">311</span> * Remove the column family from the
file system and update the table descriptor<a name="line.311"></a>
-<span class="sourceLineNo">312</span> */<a name="line.312"></a>
-<span class="sourceLineNo">313</span> private void
updateTableDescriptor(final MasterProcedureEnv env) throws IOException {<a
name="line.313"></a>
-<span class="sourceLineNo">314</span> // Update table descriptor<a
name="line.314"></a>
-<span class="sourceLineNo">315</span> LOG.info("DeleteColumn. Table = " +
tableName + " family = " + getColumnFamilyName());<a name="line.315"></a>
-<span class="sourceLineNo">316</span><a name="line.316"></a>
-<span class="sourceLineNo">317</span> HTableDescriptor htd =
env.getMasterServices().getTableDescriptors().get(tableName);<a
name="line.317"></a>
-<span class="sourceLineNo">318</span><a name="line.318"></a>
-<span class="sourceLineNo">319</span> if (!htd.hasFamily(familyName)) {<a
name="line.319"></a>
-<span class="sourceLineNo">320</span> // It is possible to reach this
situation, as we could already delete the column family<a name="line.320"></a>
-<span class="sourceLineNo">321</span> // from table descriptor, but the
master failover happens before we complete this state.<a name="line.321"></a>
-<span class="sourceLineNo">322</span> // We should be able to handle
running this function multiple times without causing problem.<a
name="line.322"></a>
-<span class="sourceLineNo">323</span> return;<a name="line.323"></a>
-<span class="sourceLineNo">324</span> }<a name="line.324"></a>
-<span class="sourceLineNo">325</span><a name="line.325"></a>
-<span class="sourceLineNo">326</span> htd.removeFamily(familyName);<a
name="line.326"></a>
-<span class="sourceLineNo">327</span>
env.getMasterServices().getTableDescriptors().add(htd);<a name="line.327"></a>
-<span class="sourceLineNo">328</span> }<a name="line.328"></a>
-<span class="sourceLineNo">329</span><a name="line.329"></a>
-<span class="sourceLineNo">330</span> /**<a name="line.330"></a>
-<span class="sourceLineNo">331</span> * Restore back to the old descriptor<a
name="line.331"></a>
-<span class="sourceLineNo">332</span> * @param env MasterProcedureEnv<a
name="line.332"></a>
-<span class="sourceLineNo">333</span> * @throws IOException<a
name="line.333"></a>
-<span class="sourceLineNo">334</span> **/<a name="line.334"></a>
-<span class="sourceLineNo">335</span> private void
restoreTableDescriptor(final MasterProcedureEnv env) throws IOException {<a
name="line.335"></a>
-<span class="sourceLineNo">336</span>
env.getMasterServices().getTableDescriptors().add(unmodifiedHTableDescriptor);<a
name="line.336"></a>
-<span class="sourceLineNo">337</span><a name="line.337"></a>
-<span class="sourceLineNo">338</span> // Make sure regions are opened after
table descriptor is updated.<a name="line.338"></a>
-<span class="sourceLineNo">339</span>
reOpenAllRegionsIfTableIsOnline(env);<a name="line.339"></a>
-<span class="sourceLineNo">340</span> }<a name="line.340"></a>
-<span class="sourceLineNo">341</span><a name="line.341"></a>
-<span class="sourceLineNo">342</span> /**<a name="line.342"></a>
-<span class="sourceLineNo">343</span> * Remove the column family from the
file system<a name="line.343"></a>
-<span class="sourceLineNo">344</span> **/<a name="line.344"></a>
-<span class="sourceLineNo">345</span> private void deleteFromFs(final
MasterProcedureEnv env) throws IOException {<a name="line.345"></a>
-<span class="sourceLineNo">346</span>
MasterDDLOperationHelper.deleteColumnFamilyFromFileSystem(env, tableName,<a
name="line.346"></a>
-<span class="sourceLineNo">347</span> getRegionInfoList(env), familyName,
hasMob);<a name="line.347"></a>
-<span class="sourceLineNo">348</span> }<a name="line.348"></a>
-<span class="sourceLineNo">349</span><a name="line.349"></a>
-<span class="sourceLineNo">350</span> /**<a name="line.350"></a>
-<span class="sourceLineNo">351</span> * Action after deleting column
family.<a name="line.351"></a>
-<span class="sourceLineNo">352</span> * @param env MasterProcedureEnv<a
name="line.352"></a>
-<span class="sourceLineNo">353</span> * @param state the procedure state<a
name="line.353"></a>
-<span class="sourceLineNo">354</span> * @throws IOException<a
name="line.354"></a>
-<span class="sourceLineNo">355</span> * @throws InterruptedException<a
name="line.355"></a>
-<span class="sourceLineNo">356</span> */<a name="line.356"></a>
-<span class="sourceLineNo">357</span> private void postDelete(final
MasterProcedureEnv env, final DeleteColumnFamilyState state)<a
name="line.357"></a>
-<span class="sourceLineNo">358</span> throws IOException,
InterruptedException {<a name="line.358"></a>
-<span class="sourceLineNo">359</span> runCoprocessorAction(env, state);<a
name="line.359"></a>
-<span class="sourceLineNo">360</span> }<a name="line.360"></a>
-<span class="sourceLineNo">361</span><a name="line.361"></a>
-<span class="sourceLineNo">362</span> /**<a name="line.362"></a>
-<span class="sourceLineNo">363</span> * Last action from the procedure -
executed when online schema change is supported.<a name="line.363"></a>
-<span class="sourceLineNo">364</span> * @param env MasterProcedureEnv<a
name="line.364"></a>
-<span class="sourceLineNo">365</span> * @throws IOException<a
name="line.365"></a>
-<span class="sourceLineNo">366</span> */<a name="line.366"></a>
-<span class="sourceLineNo">367</span> private void
reOpenAllRegionsIfTableIsOnline(final MasterProcedureEnv env) throws
IOException {<a name="line.367"></a>
-<span class="sourceLineNo">368</span> // This operation only run when the
table is enabled.<a name="line.368"></a>
-<span class="sourceLineNo">369</span> if
(!env.getMasterServices().getAssignmentManager().getTableStateManager()<a
name="line.369"></a>
-<span class="sourceLineNo">370</span> .isTableState(getTableName(),
TableState.State.ENABLED)) {<a name="line.370"></a>
-<span class="sourceLineNo">371</span> return;<a name="line.371"></a>
-<span class="sourceLineNo">372</span> }<a name="line.372"></a>
-<span class="sourceLineNo">373</span><a name="line.373"></a>
-<span class="sourceLineNo">374</span> if
(MasterDDLOperationHelper.reOpenAllRegions(env, getTableName(),
getRegionInfoList(env))) {<a name="line.374"></a>
-<span class="sourceLineNo">375</span> LOG.info("Completed delete column
family operation on table " + getTableName());<a name="line.375"></a>
-<span class="sourceLineNo">376</span> } else {<a name="line.376"></a>
-<span class="sourceLineNo">377</span> LOG.warn("Error on reopening the
regions on table " + getTableName());<a name="line.377"></a>
-<span class="sourceLineNo">378</span> }<a name="line.378"></a>
-<span class="sourceLineNo">379</span> }<a name="line.379"></a>
-<span class="sourceLineNo">380</span><a name="line.380"></a>
-<span class="sourceLineNo">381</span> /**<a name="line.381"></a>
-<span class="sourceLineNo">382</span> * The procedure could be restarted
from a different machine. If the variable is null, we need to<a
name="line.382"></a>
-<span class="sourceLineNo">383</span> * retrieve it.<a name="line.383"></a>
-<span class="sourceLineNo">384</span> * @return traceEnabled<a
name="line.384"></a>
-<span class="sourceLineNo">385</span> */<a name="line.385"></a>
-<span class="sourceLineNo">386</span> private Boolean isTraceEnabled() {<a
name="line.386"></a>
-<span class="sourceLineNo">387</span> if (traceEnabled == null) {<a
name="line.387"></a>
-<span class="sourceLineNo">388</span> traceEnabled =
LOG.isTraceEnabled();<a name="line.388"></a>
-<span class="sourceLineNo">389</span> }<a name="line.389"></a>
-<span class="sourceLineNo">390</span> return traceEnabled;<a
name="line.390"></a>
-<span class="sourceLineNo">391</span> }<a name="line.391"></a>
-<span class="sourceLineNo">392</span><a name="line.392"></a>
-<span class="sourceLineNo">393</span> private String getColumnFamilyName()
{<a name="line.393"></a>
-<span class="sourceLineNo">394</span> return Bytes.toString(familyName);<a
name="line.394"></a>
-<span class="sourceLineNo">395</span> }<a name="line.395"></a>
-<span class="sourceLineNo">396</span><a name="line.396"></a>
-<span class="sourceLineNo">397</span> /**<a name="line.397"></a>
-<span class="sourceLineNo">398</span> * Coprocessor Action.<a
name="line.398"></a>
-<span class="sourceLineNo">399</span> * @param env MasterProcedureEnv<a
name="line.399"></a>
-<span class="sourceLineNo">400</span> * @param state the procedure state<a
name="line.400"></a>
-<span class="sourceLineNo">401</span> * @throws IOException<a
name="line.401"></a>
-<span class="sourceLineNo">402</span> * @throws InterruptedException<a
name="line.402"></a>
-<span class="sourceLineNo">403</span> */<a name="line.403"></a>
-<span class="sourceLineNo">404</span> private void runCoprocessorAction(final
MasterProcedureEnv env,<a name="line.404"></a>
-<span class="sourceLineNo">405</span> final DeleteColumnFamilyState
state) throws IOException, InterruptedException {<a name="line.405"></a>
-<span class="sourceLineNo">406</span> final MasterCoprocessorHost cpHost =
env.getMasterCoprocessorHost();<a name="line.406"></a>
-<span class="sourceLineNo">407</span> if (cpHost != null) {<a
name="line.407"></a>
-<span class="sourceLineNo">408</span> user.doAs(new
PrivilegedExceptionAction<Void>() {<a name="line.408"></a>
-<span class="sourceLineNo">409</span> @Override<a name="line.409"></a>
-<span class="sourceLineNo">410</span> public Void run() throws
Exception {<a name="line.410"></a>
-<span class="sourceLineNo">411</span> switch (state) {<a
name="line.411"></a>
-<span class="sourceLineNo">412</span> case
DELETE_COLUMN_FAMILY_PRE_OPERATION:<a name="line.412"></a>
-<span class="sourceLineNo">413</span>
cpHost.preDeleteColumnHandler(tableName, familyName);<a name="line.413"></a>
+<span class="sourceLineNo">229</span> @Override<a name="line.229"></a>
+<span class="sourceLineNo">230</span> public void deserializeStateData(final
InputStream stream) throws IOException {<a name="line.230"></a>
+<span class="sourceLineNo">231</span> super.deserializeStateData(stream);<a
name="line.231"></a>
+<span class="sourceLineNo">232</span>
MasterProcedureProtos.DeleteColumnFamilyStateData deleteCFMsg =<a
name="line.232"></a>
+<span class="sourceLineNo">233</span>
MasterProcedureProtos.DeleteColumnFamilyStateData.parseDelimitedFrom(stream);<a
name="line.233"></a>
+<span class="sourceLineNo">234</span> user =
MasterProcedureUtil.toUserInfo(deleteCFMsg.getUserInfo());<a
name="line.234"></a>
+<span class="sourceLineNo">235</span> tableName =
ProtobufUtil.toTableName(deleteCFMsg.getTableName());<a name="line.235"></a>
+<span class="sourceLineNo">236</span> familyName =
deleteCFMsg.getColumnfamilyName().toByteArray();<a name="line.236"></a>
+<span class="sourceLineNo">237</span><a name="line.237"></a>
+<span class="sourceLineNo">238</span> if
(deleteCFMsg.hasUnmodifiedTableSchema()) {<a name="line.238"></a>
+<span class="sourceLineNo">239</span> unmodifiedHTableDescriptor =
HTableDescriptor.convert(deleteCFMsg.getUnmodifiedTableSchema());<a
name="line.239"></a>
+<span class="sourceLineNo">240</span> }<a name="line.240"></a>
+<span class="sourceLineNo">241</span> }<a name="line.241"></a>
+<span class="sourceLineNo">242</span><a name="line.242"></a>
+<span class="sourceLineNo">243</span> @Override<a name="line.243"></a>
+<span class="sourceLineNo">244</span> public void
toStringClassDetails(StringBuilder sb) {<a name="line.244"></a>
+<span class="sourceLineNo">245</span>
sb.append(getClass().getSimpleName());<a name="line.245"></a>
+<span class="sourceLineNo">246</span> sb.append(" (table=");<a
name="line.246"></a>
+<span class="sourceLineNo">247</span> sb.append(tableName);<a
name="line.247"></a>
+<span class="sourceLineNo">248</span> sb.append(", columnfamily=");<a
name="line.248"></a>
+<span class="sourceLineNo">249</span> if (familyName != null) {<a
name="line.249"></a>
+<span class="sourceLineNo">250</span> sb.append(getColumnFamilyName());<a
name="line.250"></a>
+<span class="sourceLineNo">251</span> } else {<a name="line.251"></a>
+<span class="sourceLineNo">252</span> sb.append("Unknown");<a
name="line.252"></a>
+<span class="sourceLineNo">253</span> }<a name="line.253"></a>
+<span class="sourceLineNo">254</span> sb.append(")");<a name="line.254"></a>
+<span class="sourceLineNo">255</span> }<a name="line.255"></a>
+<span class="sourceLineNo">256</span><a name="line.256"></a>
+<span class="sourceLineNo">257</span> @Override<a name="line.257"></a>
+<span class="sourceLineNo">258</span> public TableName getTableName() {<a
name="line.258"></a>
+<span class="sourceLineNo">259</span> return tableName;<a
name="line.259"></a>
+<span class="sourceLineNo">260</span> }<a name="line.260"></a>
+<span class="sourceLineNo">261</span><a name="line.261"></a>
+<span class="sourceLineNo">262</span> @Override<a name="line.262"></a>
+<span class="sourceLineNo">263</span> public TableOperationType
getTableOperationType() {<a name="line.263"></a>
+<span class="sourceLineNo">264</span> return TableOperationType.EDIT;<a
name="line.264"></a>
+<span class="sourceLineNo">265</span> }<a name="line.265"></a>
+<span class="sourceLineNo">266</span><a name="line.266"></a>
+<span class="sourceLineNo">267</span> /**<a name="line.267"></a>
+<span class="sourceLineNo">268</span> * Action before any real action of
deleting column family.<a name="line.268"></a>
+<span class="sourceLineNo">269</span> * @param env MasterProcedureEnv<a
name="line.269"></a>
+<span class="sourceLineNo">270</span> * @throws IOException<a
name="line.270"></a>
+<span class="sourceLineNo">271</span> */<a name="line.271"></a>
+<span class="sourceLineNo">272</span> private void prepareDelete(final
MasterProcedureEnv env) throws IOException {<a name="line.272"></a>
+<span class="sourceLineNo">273</span> // Checks whether the table is
allowed to be modified.<a name="line.273"></a>
+<span class="sourceLineNo">274</span>
MasterDDLOperationHelper.checkTableModifiable(env, tableName);<a
name="line.274"></a>
+<span class="sourceLineNo">275</span><a name="line.275"></a>
+<span class="sourceLineNo">276</span> // In order to update the descriptor,
we need to retrieve the old descriptor for comparison.<a name="line.276"></a>
+<span class="sourceLineNo">277</span> unmodifiedHTableDescriptor =
env.getMasterServices().getTableDescriptors().get(tableName);<a
name="line.277"></a>
+<span class="sourceLineNo">278</span> if (unmodifiedHTableDescriptor ==
null) {<a name="line.278"></a>
+<span class="sourceLineNo">279</span> throw new
IOException("HTableDescriptor missing for " + tableName);<a name="line.279"></a>
+<span class="sourceLineNo">280</span> }<a name="line.280"></a>
+<span class="sourceLineNo">281</span> if
(!unmodifiedHTableDescriptor.hasFamily(familyName)) {<a name="line.281"></a>
+<span class="sourceLineNo">282</span> throw new
InvalidFamilyOperationException("Family '" + getColumnFamilyName()<a
name="line.282"></a>
+<span class="sourceLineNo">283</span> + "' does not exist, so it
cannot be deleted");<a name="line.283"></a>
+<span class="sourceLineNo">284</span> }<a name="line.284"></a>
+<span class="sourceLineNo">285</span><a name="line.285"></a>
+<span class="sourceLineNo">286</span> if
(unmodifiedHTableDescriptor.getColumnFamilies().length == 1) {<a
name="line.286"></a>
+<span class="sourceLineNo">287</span> throw new
InvalidFamilyOperationException("Family '" + getColumnFamilyName()<a
name="line.287"></a>
+<span class="sourceLineNo">288</span> + "' is the only column family in
the table, so it cannot be deleted");<a name="line.288"></a>
+<span class="sourceLineNo">289</span> }<a name="line.289"></a>
+<span class="sourceLineNo">290</span><a name="line.290"></a>
+<span class="sourceLineNo">291</span> // whether mob family<a
name="line.291"></a>
+<span class="sourceLineNo">292</span> hasMob =
unmodifiedHTableDescriptor.getFamily(familyName).isMobEnabled();<a
name="line.292"></a>
+<span class="sourceLineNo">293</span> }<a name="line.293"></a>
+<span class="sourceLineNo">294</span><a name="line.294"></a>
+<span class="sourceLineNo">295</span> /**<a name="line.295"></a>
+<span class="sourceLineNo">296</span> * Action before deleting column
family.<a name="line.296"></a>
+<span class="sourceLineNo">297</span> * @param env MasterProcedureEnv<a
name="line.297"></a>
+<span class="sourceLineNo">298</span> * @param state the procedure state<a
name="line.298"></a>
+<span class="sourceLineNo">299</span> * @throws IOException<a
name="line.299"></a>
+<span class="sourceLineNo">300</span> * @throws InterruptedException<a
name="line.300"></a>
+<span class="sourceLineNo">301</span> */<a name="line.301"></a>
+<span class="sourceLineNo">302</span> private void preDelete(final
MasterProcedureEnv env, final DeleteColumnFamilyState state)<a
name="line.302"></a>
+<span class="sourceLineNo">303</span> throws IOException,
InterruptedException {<a name="line.303"></a>
+<span class="sourceLineNo">304</span> runCoprocessorAction(env, state);<a
name="line.304"></a>
+<span class="sourceLineNo">305</span> }<a name="line.305"></a>
+<span class="sourceLineNo">306</span><a name="line.306"></a>
+<span class="sourceLineNo">307</span> /**<a name="line.307"></a>
+<span class="sourceLineNo">308</span> * Remove the column family from the
file system and update the table descriptor<a name="line.308"></a>
+<span class="sourceLineNo">309</span> */<a name="line.309"></a>
+<span class="sourceLineNo">310</span> private void
updateTableDescriptor(final MasterProcedureEnv env) throws IOException {<a
name="line.310"></a>
+<span class="sourceLineNo">311</span> // Update table descriptor<a
name="line.311"></a>
+<span class="sourceLineNo">312</span> LOG.info("DeleteColumn. Table = " +
tableName + " family = " + getColumnFamilyName());<a name="line.312"></a>
+<span class="sourceLineNo">313</span><a name="line.313"></a>
+<span class="sourceLineNo">314</span> HTableDescriptor htd =
env.getMasterServices().getTableDescriptors().get(tableName);<a
name="line.314"></a>
+<span class="sourceLineNo">315</span><a name="line.315"></a>
+<span class="sourceLineNo">316</span> if (!htd.hasFamily(familyName)) {<a
name="line.316"></a>
+<span class="sourceLineNo">317</span> // It is possible to reach this
situation, as we could already delete the column family<a name="line.317"></a>
+<span class="sourceLineNo">318</span> // from table descriptor, but the
master failover happens before we complete this state.<a name="line.318"></a>
+<span class="sourceLineNo">319</span> // We should be able to handle
running this function multiple times without causing problem.<a
name="line.319"></a>
+<span class="sourceLineNo">320</span> return;<a name="line.320"></a>
+<span class="sourceLineNo">321</span> }<a name="line.321"></a>
+<span class="sourceLineNo">322</span><a name="line.322"></a>
+<span class="sourceLineNo">323</span> htd.removeFamily(familyName);<a
name="line.323"></a>
+<span class="sourceLineNo">324</span>
env.getMasterServices().getTableDescriptors().add(htd);<a name="line.324"></a>
+<span class="sourceLineNo">325</span> }<a name="line.325"></a>
+<span class="sourceLineNo">326</span><a name="line.326"></a>
+<span class="sourceLineNo">327</span> /**<a name="line.327"></a>
+<span class="sourceLineNo">328</span> * Restore back to the old descriptor<a
name="line.328"></a>
+<span class="sourceLineNo">329</span> * @param env MasterProcedureEnv<a
name="line.329"></a>
+<span class="sourceLineNo">330</span> * @throws IOException<a
name="line.330"></a>
+<span class="sourceLineNo">331</span> **/<a name="line.331"></a>
+<span class="sourceLineNo">332</span> private void
restoreTableDescriptor(final MasterProcedureEnv env) throws IOException {<a
name="line.332"></a>
+<span class="sourceLineNo">333</span>
env.getMasterServices().getTableDescriptors().add(unmodifiedHTableDescriptor);<a
name="line.333"></a>
+<span class="sourceLineNo">334</span><a name="line.334"></a>
+<span class="sourceLineNo">335</span> // Make sure regions are opened after
table descriptor is updated.<a name="line.335"></a>
+<span class="sourceLineNo">336</span>
reOpenAllRegionsIfTableIsOnline(env);<a name="line.336"></a>
+<span class="sourceLineNo">337</span> }<a name="line.337"></a>
+<span class="sourceLineNo">338</span><a name="line.338"></a>
+<span class="sourceLineNo">339</span> /**<a name="line.339"></a>
+<span class="sourceLineNo">340</span> * Remove the column family from the
file system<a name="line.340"></a>
+<span class="sourceLineNo">341</span> **/<a name="line.341"></a>
+<span class="sourceLineNo">342</span> private void deleteFromFs(final
MasterProcedureEnv env) throws IOException {<a name="line.342"></a>
+<span class="sourceLineNo">343</span>
MasterDDLOperationHelper.deleteColumnFamilyFromFileSystem(env, tableName,<a
name="line.343"></a>
+<span class="sourceLineNo">344</span> getRegionInfoList(env), familyName,
hasMob);<a name="line.344"></a>
+<span class="sourceLineNo">345</span> }<a name="line.345"></a>
+<span class="sourceLineNo">346</span><a name="line.346"></a>
+<span class="sourceLineNo">347</span> /**<a name="line.347"></a>
+<span class="sourceLineNo">348</span> * Action after deleting column
family.<a name="line.348"></a>
+<span class="sourceLineNo">349</span> * @param env MasterProcedureEnv<a
name="line.349"></a>
+<span class="sourceLineNo">350</span> * @param state the procedure state<a
name="line.350"></a>
+<span class="sourceLineNo">351</span> * @throws IOException<a
name="line.351"></a>
+<span class="sourceLineNo">352</span> * @throws InterruptedException<a
name="line.352"></a>
+<span class="sourceLineNo">353</span> */<a name="line.353"></a>
+<span class="sourceLineNo">354</span> private void postDelete(final
MasterProcedureEnv env, final DeleteColumnFamilyState state)<a
name="line.354"></a>
+<span class="sourceLineNo">355</span> throws IOException,
InterruptedException {<a name="line.355"></a>
+<span class="sourceLineNo">356</span> runCoprocessorAction(env, state);<a
name="line.356"></a>
+<span class="sourceLineNo">357</span> }<a name="line.357"></a>
+<span class="sourceLineNo">358</span><a name="line.358"></a>
+<span class="sourceLineNo">359</span> /**<a name="line.359"></a>
+<span class="sourceLineNo">360</span> * Last action from the procedure -
executed when online schema change is supported.<a name="line.360"></a>
+<span class="sourceLineNo">361</span> * @param env MasterProcedureEnv<a
name="line.361"></a>
+<span class="sourceLineNo">362</span> * @throws IOException<a
name="line.362"></a>
+<span class="sourceLineNo">363</span> */<a name="line.363"></a>
+<span class="sourceLineNo">364</span> private void
reOpenAllRegionsIfTableIsOnline(final MasterProcedureEnv env) throws
IOException {<a name="line.364"></a>
+<span class="sourceLineNo">365</span> // This operation only run when the
table is enabled.<a name="line.365"></a>
+<span class="sourceLineNo">366</span> if
(!env.getMasterServices().getAssignmentManager().getTableStateManager()<a
name="line.366"></a>
+<span class="sourceLineNo">367</span> .isTableState(getTableName(),
TableState.State.ENABLED)) {<a name="line.367"></a>
+<span class="sourceLineNo">368</span> return;<a name="line.368"></a>
+<span class="sourceLineNo">369</span> }<a name="line.369"></a>
+<span class="sourceLineNo">370</span><a name="line.370"></a>
+<span class="sourceLineNo">371</span> if
(MasterDDLOperationHelper.reOpenAllRegions(env, getTableName(),
getRegionInfoList(env))) {<a name="line.371"></a>
+<span class="sourceLineNo">372</span> LOG.info("Completed delete column
family operation on table " + getTableName());<a name="line.372"></a>
+<span class="sourceLineNo">373</span> } else {<a name="line.373"></a>
+<span class="sourceLineNo">374</span> LOG.warn("Error on reopening the
regions on table " + getTableName());<a name="line.374"></a>
+<span class="sourceLineNo">375</span> }<a name="line.375"></a>
+<span class="sourceLineNo">376</span> }<a name="line.376"></a>
+<span class="sourceLineNo">377</span><a name="line.377"></a>
+<span class="sourceLineNo">378</span> /**<a name="line.378"></a>
+<span class="sourceLineNo">379</span> * The procedure could be restarted
from a different machine. If the variable is null, we need to<a
name="line.379"></a>
+<span class="sourceLineNo">380</span> * retrieve it.<a name="line.380"></a>
+<span class="sourceLineNo">381</span> * @return traceEnabled<a
name="line.381"></a>
+<span class="sourceLineNo">382</span> */<a name="line.382"></a>
+<span class="sourceLineNo">383</span> private Boolean isTraceEnabled() {<a
name="line.383"></a>
+<span class="sourceLineNo">384</span> if (traceEnabled == null) {<a
name="line.384"></a>
+<span class="sourceLineNo">385</span> traceEnabled =
LOG.isTraceEnabled();<a name="line.385"></a>
+<span class="sourceLineNo">386</span> }<a name="line.386"></a>
+<span class="sourceLineNo">387</span> return traceEnabled;<a
name="line.387"></a>
+<span class="sourceLineNo">388</span> }<a name="line.388"></a>
+<span class="sourceLineNo">389</span><a name="line.389"></a>
+<span class="sourceLineNo">390</span> private String getColumnFamilyName()
{<a name="line.390"></a>
+<span class="sourceLineNo">391</span> return Bytes.toString(familyName);<a
name="line.391"></a>
+<span class="sourceLineNo">392</span> }<a name="line.392"></a>
+<span class="sourceLineNo">393</span><a name="line.393"></a>
+<span class="sourceLineNo">394</span> /**<a name="line.394"></a>
+<span class="sourceLineNo">395</span> * Coprocessor Action.<a
name="line.395"></a>
+<span class="sourceLineNo">396</span> * @param env MasterProcedureEnv<a
name="line.396"></a>
+<span class="sourceLineNo">397</span> * @param state the procedure state<a
name="line.397"></a>
+<span class="sourceLineNo">398</span> * @throws IOException<a
name="line.398"></a>
+<span class="sourceLineNo">399</span> * @throws InterruptedException<a
name="line.399"></a>
+<span class="sourceLineNo">400</span> */<a name="line.400"></a>
+<span class="sourceLineNo">401</span> private void runCoprocessorAction(final
MasterProcedureEnv env,<a name="line.401"></a>
+<span class="sourceLineNo">402</span> final DeleteColumnFamilyState
state) throws IOException, InterruptedException {<a name="line.402"></a>
+<span class="sourceLineNo">403</span> final MasterCoprocessorHost cpHost =
env.getMasterCoprocessorHost();<a name="line.403"></a>
+<span class="sourceLineNo">404</span> if (cpHost != null) {<a
name="line.404"></a>
+<span class="sourceLineNo">405</span> user.doAs(new
PrivilegedExceptionAction<Void>() {<a name="line.405"></a>
+<span class="sourceLineNo">406</span> @Override<a name="line.406"></a>
+<span class="sourceLineNo">407</span> public Void run() throws
Exception {<a name="line.407"></a>
+<span class="sourceLineNo">408</span> switch (state) {<a
name="line.408"></a>
+<span class="sourceLineNo">409</span> case
DELETE_COLUMN_FAMILY_PRE_OPERATION:<a name="line.409"></a>
+<span class="sourceLineNo">410</span>
cpHost.preDeleteColumnHandler(tableName, familyName);<a name="line.410"></a>
+<span class="sourceLineNo">411</span> break;<a name="line.411"></a>
+<span class="sourceLineNo">412</span> case
DELETE_COLUMN_FAMILY_POST_OPERATION:<a name="line.412"></a>
+<span class="sourceLineNo">413</span>
cpHost.postDeleteColumnHandler(tableName, familyName);<a name="line.413"></a>
<span class="sourceLineNo">414</span> break;<a name="line.414"></a>
-<span class="sourceLineNo">415</span> case
DELETE_COLUMN_FAMILY_POST_OPERATION:<a name="line.415"></a>
-<span class="sourceLineNo">416</span>
cpHost.postDeleteColumnHandler(tableName, familyName);<a name="line.416"></a>
-<span class="sourceLineNo">417</span> break;<a name="line.417"></a>
-<span class="sourceLineNo">418</span> default:<a name="line.418"></a>
-<span class="sourceLineNo">419</span> throw new
UnsupportedOperationException(this + " unhandled state=" + state);<a
name="line.419"></a>
-<span class="sourceLineNo">420</span> }<a name="line.420"></a>
-<span class="sourceLineNo">421</span> return null;<a
name="line.421"></a>
-<span class="sourceLineNo">422</span> }<a name="line.422"></a>
-<span class="sourceLineNo">423</span> });<a name="line.423"></a>
-<span class="sourceLineNo">424</span> }<a name="line.424"></a>
-<span class="sourceLineNo">425</span> }<a name="line.425"></a>
-<span class="sourceLineNo">426</span><a name="line.426"></a>
-<span class="sourceLineNo">427</span> /*<a name="line.427"></a>
-<span class="sourceLineNo">428</span> * Check whether we are in the state
that can be rollback<a name="line.428"></a>
-<span class="sourceLineNo">429</span> */<a name="line.429"></a>
-<span class="sourceLineNo">430</span> private boolean
isRollbackSupported(final DeleteColumnFamilyState state) {<a
name="line.430"></a>
-<span class="sourceLineNo">431</span> switch (state) {<a
name="line.431"></a>
-<span class="sourceLineNo">432</span> case
DELETE_COLUMN_FAMILY_REOPEN_ALL_REGIONS:<a name="line.432"></a>
-<span class="sourceLineNo">433</span> case
DELETE_COLUMN_FAMILY_POST_OPERATION:<a name="line.433"></a>
-<span class="sourceLineNo">434</span> case
DELETE_COLUMN_FAMILY_DELETE_FS_LAYOUT:<a name="line.434"></a>
-<span class="sourceLineNo">435</span> // It is not safe to rollback if
we reach to these states.<a name="line.435"></a>
-<span class="sourceLineNo">436</span> return false;<a
name="line.436"></a>
-<span class="sourceLineNo">437</span> default:<a name="line.437"></a>
-<span class="sourceLineNo">438</span> break;<a name="line.438"></a>
-<span class="sourceLineNo">439</span> }<a name="line.439"></a>
-<span class="sourceLineNo">440</span> return true;<a name="line.440"></a>
-<span class="sourceLineNo">441</span> }<a name="line.441"></a>
-<span class="sourceLineNo">442</span><a name="line.442"></a>
-<span class="sourceLineNo">443</span> private List<HRegionInfo>
getRegionInfoList(final MasterProcedureEnv env) throws IOException {<a
name="line.443"></a>
-<span class="sourceLineNo">444</span> if (regionInfoList == null) {<a
name="line.444"></a>
-<span class="sourceLineNo">445</span> regionInfoList =
ProcedureSyncWait.getRegionsFromMeta(env, getTableName());<a
name="line.445"></a>
-<span class="sourceLineNo">446</span> }<a name="line.446"></a>
-<span class="sourceLineNo">447</span> return regionInfoList;<a
name="line.447"></a>
-<span class="sourceLineNo">448</span> }<a name="line.448"></a>
-<span class="sourceLineNo">449</span>}<a name="line.449"></a>
+<span class="sourceLineNo">415</span> default:<a name="line.415"></a>
+<span class="sourceLineNo">416</span> throw new
UnsupportedOperationException(this + " unhandled state=" + state);<a
name="line.416"></a>
+<span class="sourceLineNo">417</span> }<a name="line.417"></a>
+<span class="sourceLineNo">418</span> return null;<a
name="line.418"></a>
+<span class="sourceLineNo">419</span> }<a name="line.419"></a>
+<span class="sourceLineNo">420</span> });<a name="line.420"></a>
+<span class="sourceLineNo">421</span> }<a name="line.421"></a>
+<span class="sourceLineNo">422</span> }<a name="line.422"></a>
+<span class="sourceLineNo">423</span><a name="line.423"></a>
+<span class="sourceLineNo">424</span> /*<a name="line.424"></a>
+<span class="sourceLineNo">425</span> * Check whether we are in the state
that can be rollback<a name="line.425"></a>
+<span class="sourceLineNo">426</span> */<a name="line.426"></a>
+<span class="sourceLineNo">427</span> private boolean
isRollbackSupported(final DeleteColumnFamilyState state) {<a
name="line.427"></a>
+<span class="sourceLineNo">428</span> switch (state) {<a
name="line.428"></a>
+<span class="sourceLineNo">429</span> case
DELETE_COLUMN_FAMILY_REOPEN_ALL_REGIONS:<a name="line.429"></a>
+<span class="sourceLineNo">430</span> case
DELETE_COLUMN_FAMILY_POST_OPERATION:<a name="line.430"></a>
+<span class="sourceLineNo">431</span> case
DELETE_COLUMN_FAMILY_DELETE_FS_LAYOUT:<a name="line.431"></a>
+<span class="sourceLineNo">432</span> // It is not safe to rollback if
we reach to these states.<a name="line.432"></a>
+<span class="sourceLineNo">433</span> return false;<a
name="line.433"></a>
+<span class="sourceLineNo">434</span> default:<a name="line.434"></a>
+<span class="sourceLineNo">435</span> break;<a name="line.435"></a>
+<span class="sourceLineNo">436</span> }<a name="line.436"></a>
+<span class="sourceLineNo">437</span> return true;<a name="line.437"></a>
+<span class="sourceLineNo">438</span> }<a name="line.438"></a>
+<span class="sourceLineNo">439</span><a name="line.439"></a>
+<span class="sourceLineNo">440</span> private List<HRegionInfo>
getRegionInfoList(final MasterProcedureEnv env) throws IOException {<a
name="line.440"></a>
+<span class="sourceLineNo">441</span> if (regionInfoList == null) {<a
name="line.441"></a>
+<span class="sourceLineNo">442</span> regionInfoList =
ProcedureSyncWait.getRegionsFromMeta(env, getTableName());<a
name="line.442"></a>
+<span class="sourceLineNo">443</span> }<a name="line.443"></a>
+<span class="sourceLineNo">444</span> return regionInfoList;<a
name="line.444"></a>
+<span class="sourceLineNo">445</span> }<a name="line.445"></a>
+<span class="sourceLineNo">446</span>}<a name="line.446"></a>