HBASE-15794 Fix Findbugs instanceof always true issue in MultiServerCallable
Signed-off-by: stack <st...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/ac31ceb8 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/ac31ceb8 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/ac31ceb8 Branch: refs/heads/hbase-12439 Commit: ac31ceb835b303287b367780c17723cb49d54fba Parents: e71ae60 Author: Jurriaan Mous <jurm...@jurmo.us> Authored: Sat May 7 14:40:51 2016 +0200 Committer: stack <st...@apache.org> Committed: Sat May 7 10:10:23 2016 -0700 ---------------------------------------------------------------------- .../org/apache/hadoop/hbase/client/MultiServerCallable.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/ac31ceb8/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java ---------------------------------------------------------------------- diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java index f78f348..e764ceb 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java @@ -137,9 +137,8 @@ class MultiServerCallable<R> extends PayloadCarryingServerCallable<MultiResponse private boolean isCellBlock() { // This is not exact -- the configuration could have changed on us after connection was set up // but it will do for now. - HConnection connection = getConnection(); - if (!(connection instanceof ClusterConnection)) return true; // Default is to do cellblocks. - return ((ClusterConnection) connection).hasCellBlockSupport(); + ClusterConnection conn = getConnection(); + return conn.hasCellBlockSupport(); } @Override
