HBASE-16045 endtime argument for VerifyReplication was incorrectly specified in usage
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/e18daa0c Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/e18daa0c Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/e18daa0c Branch: refs/heads/0.98 Commit: e18daa0c9c1653c1d6c409bf990893798ce53cbf Parents: 6a8206a Author: tedyu <yuzhih...@gmail.com> Authored: Thu Jun 16 15:52:16 2016 -0700 Committer: Andrew Purtell <apurt...@apache.org> Committed: Fri Jun 24 11:04:24 2016 -0700 ---------------------------------------------------------------------- .../hadoop/hbase/mapreduce/replication/VerifyReplication.java | 6 +++++- src/main/asciidoc/_chapters/ops_mgt.adoc | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/e18daa0c/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java index 44bfdfe..a5d1ddd 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java @@ -383,6 +383,10 @@ public class VerifyReplication extends Configured implements Tool { continue; } + if (cmd.startsWith("--")) { + printUsage("Invalid argument '" + cmd + "'"); + } + if (i == args.length-2) { peerId = cmd; } @@ -418,7 +422,7 @@ public class VerifyReplication extends Configured implements Tool { System.err.println("ERROR: " + errorMsg); } System.err.println("Usage: verifyrep [--starttime=X]" + - " [--stoptime=Y] [--families=A] [--row-prefixes=B] <peerid> <tablename>"); + " [--endtime=Y] [--families=A] [--row-prefixes=B] <peerid> <tablename>"); System.err.println(); System.err.println("Options:"); System.err.println(" starttime beginning of the time range"); http://git-wip-us.apache.org/repos/asf/hbase/blob/e18daa0c/src/main/asciidoc/_chapters/ops_mgt.adoc ---------------------------------------------------------------------- diff --git a/src/main/asciidoc/_chapters/ops_mgt.adoc b/src/main/asciidoc/_chapters/ops_mgt.adoc index d7ac987..fa31c8c 100644 --- a/src/main/asciidoc/_chapters/ops_mgt.adoc +++ b/src/main/asciidoc/_chapters/ops_mgt.adoc @@ -1358,7 +1358,7 @@ The `VerifyReplication` MapReduce job, which is included in HBase, performs a sy + [source,bash] ---- -$ HADOOP_CLASSPATH=`${HBASE_HOME}/bin/hbase classpath` "${HADOOP_HOME}/bin/hadoop" jar "${HBASE_HOME}/hbase-server-VERSION.jar" verifyrep --starttime=<timestamp> --stoptime=<timestamp> --families=<myFam> <ID> <tableName> +$ HADOOP_CLASSPATH=`${HBASE_HOME}/bin/hbase classpath` "${HADOOP_HOME}/bin/hadoop" jar "${HBASE_HOME}/hbase-server-VERSION.jar" verifyrep --starttime=<timestamp> --endtime=<timestamp> --families=<myFam> <ID> <tableName> ---- + The `VerifyReplication` command prints out `GOODROWS` and `BADROWS` counters to indicate rows that did and did not replicate correctly.