http://git-wip-us.apache.org/repos/asf/hbase-site/blob/45a663dd/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/AbstractMemStore.html
----------------------------------------------------------------------
diff --git 
a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/AbstractMemStore.html
 
b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/AbstractMemStore.html
index 7a59e03..ccc41ab 100644
--- 
a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/AbstractMemStore.html
+++ 
b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/AbstractMemStore.html
@@ -43,440 +43,441 @@
 <span class="sourceLineNo">035</span>import 
org.apache.hadoop.hbase.KeyValueUtil;<a name="line.35"></a>
 <span class="sourceLineNo">036</span>import 
org.apache.hadoop.hbase.ShareableMemory;<a name="line.36"></a>
 <span class="sourceLineNo">037</span>import 
org.apache.hadoop.hbase.classification.InterfaceAudience;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import 
org.apache.hadoop.hbase.util.Bytes;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import 
org.apache.hadoop.hbase.util.ClassSize;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import 
org.apache.hadoop.hbase.util.EnvironmentEdgeManager;<a name="line.40"></a>
-<span class="sourceLineNo">041</span><a name="line.41"></a>
-<span class="sourceLineNo">042</span>/**<a name="line.42"></a>
-<span class="sourceLineNo">043</span> * An abstract class, which implements 
the behaviour shared by all concrete memstore instances.<a name="line.43"></a>
-<span class="sourceLineNo">044</span> */<a name="line.44"></a>
-<span class="sourceLineNo">045</span>@InterfaceAudience.Private<a 
name="line.45"></a>
-<span class="sourceLineNo">046</span>public abstract class AbstractMemStore 
implements MemStore {<a name="line.46"></a>
-<span class="sourceLineNo">047</span><a name="line.47"></a>
-<span class="sourceLineNo">048</span>  private static final long 
NO_SNAPSHOT_ID = -1;<a name="line.48"></a>
-<span class="sourceLineNo">049</span><a name="line.49"></a>
-<span class="sourceLineNo">050</span>  private final Configuration conf;<a 
name="line.50"></a>
-<span class="sourceLineNo">051</span>  private final CellComparator 
comparator;<a name="line.51"></a>
-<span class="sourceLineNo">052</span><a name="line.52"></a>
-<span class="sourceLineNo">053</span>  // active segment absorbs write 
operations<a name="line.53"></a>
-<span class="sourceLineNo">054</span>  private volatile MutableSegment 
active;<a name="line.54"></a>
-<span class="sourceLineNo">055</span>  // Snapshot of memstore.  Made for 
flusher.<a name="line.55"></a>
-<span class="sourceLineNo">056</span>  private volatile ImmutableSegment 
snapshot;<a name="line.56"></a>
-<span class="sourceLineNo">057</span>  protected volatile long snapshotId;<a 
name="line.57"></a>
-<span class="sourceLineNo">058</span>  // Used to track when to flush<a 
name="line.58"></a>
-<span class="sourceLineNo">059</span>  private volatile long 
timeOfOldestEdit;<a name="line.59"></a>
-<span class="sourceLineNo">060</span><a name="line.60"></a>
-<span class="sourceLineNo">061</span>  public final static long FIXED_OVERHEAD 
= ClassSize.align(<a name="line.61"></a>
-<span class="sourceLineNo">062</span>      ClassSize.OBJECT +<a 
name="line.62"></a>
-<span class="sourceLineNo">063</span>          (4 * ClassSize.REFERENCE) +<a 
name="line.63"></a>
-<span class="sourceLineNo">064</span>          (2 * Bytes.SIZEOF_LONG));<a 
name="line.64"></a>
-<span class="sourceLineNo">065</span><a name="line.65"></a>
-<span class="sourceLineNo">066</span>  public final static long DEEP_OVERHEAD 
= ClassSize.align(FIXED_OVERHEAD +<a name="line.66"></a>
-<span class="sourceLineNo">067</span>      (ClassSize.ATOMIC_LONG + 
ClassSize.TIMERANGE_TRACKER +<a name="line.67"></a>
-<span class="sourceLineNo">068</span>      ClassSize.CELL_SET + 
ClassSize.CONCURRENT_SKIPLISTMAP));<a name="line.68"></a>
-<span class="sourceLineNo">069</span><a name="line.69"></a>
+<span class="sourceLineNo">038</span>import 
org.apache.hadoop.hbase.exceptions.UnexpectedStateException;<a 
name="line.38"></a>
+<span class="sourceLineNo">039</span>import 
org.apache.hadoop.hbase.util.Bytes;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import 
org.apache.hadoop.hbase.util.ClassSize;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import 
org.apache.hadoop.hbase.util.EnvironmentEdgeManager;<a name="line.41"></a>
+<span class="sourceLineNo">042</span><a name="line.42"></a>
+<span class="sourceLineNo">043</span>/**<a name="line.43"></a>
+<span class="sourceLineNo">044</span> * An abstract class, which implements 
the behaviour shared by all concrete memstore instances.<a name="line.44"></a>
+<span class="sourceLineNo">045</span> */<a name="line.45"></a>
+<span class="sourceLineNo">046</span>@InterfaceAudience.Private<a 
name="line.46"></a>
+<span class="sourceLineNo">047</span>public abstract class AbstractMemStore 
implements MemStore {<a name="line.47"></a>
+<span class="sourceLineNo">048</span><a name="line.48"></a>
+<span class="sourceLineNo">049</span>  private static final long 
NO_SNAPSHOT_ID = -1;<a name="line.49"></a>
+<span class="sourceLineNo">050</span><a name="line.50"></a>
+<span class="sourceLineNo">051</span>  private final Configuration conf;<a 
name="line.51"></a>
+<span class="sourceLineNo">052</span>  private final CellComparator 
comparator;<a name="line.52"></a>
+<span class="sourceLineNo">053</span><a name="line.53"></a>
+<span class="sourceLineNo">054</span>  // active segment absorbs write 
operations<a name="line.54"></a>
+<span class="sourceLineNo">055</span>  private volatile MutableSegment 
active;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>  // Snapshot of memstore.  Made for 
flusher.<a name="line.56"></a>
+<span class="sourceLineNo">057</span>  private volatile ImmutableSegment 
snapshot;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>  protected volatile long snapshotId;<a 
name="line.58"></a>
+<span class="sourceLineNo">059</span>  // Used to track when to flush<a 
name="line.59"></a>
+<span class="sourceLineNo">060</span>  private volatile long 
timeOfOldestEdit;<a name="line.60"></a>
+<span class="sourceLineNo">061</span><a name="line.61"></a>
+<span class="sourceLineNo">062</span>  public final static long FIXED_OVERHEAD 
= ClassSize.align(<a name="line.62"></a>
+<span class="sourceLineNo">063</span>      ClassSize.OBJECT +<a 
name="line.63"></a>
+<span class="sourceLineNo">064</span>          (4 * ClassSize.REFERENCE) +<a 
name="line.64"></a>
+<span class="sourceLineNo">065</span>          (2 * Bytes.SIZEOF_LONG));<a 
name="line.65"></a>
+<span class="sourceLineNo">066</span><a name="line.66"></a>
+<span class="sourceLineNo">067</span>  public final static long DEEP_OVERHEAD 
= ClassSize.align(FIXED_OVERHEAD +<a name="line.67"></a>
+<span class="sourceLineNo">068</span>      (ClassSize.ATOMIC_LONG + 
ClassSize.TIMERANGE_TRACKER +<a name="line.68"></a>
+<span class="sourceLineNo">069</span>      ClassSize.CELL_SET + 
ClassSize.CONCURRENT_SKIPLISTMAP));<a name="line.69"></a>
 <span class="sourceLineNo">070</span><a name="line.70"></a>
-<span class="sourceLineNo">071</span>  protected AbstractMemStore(final 
Configuration conf, final CellComparator c) {<a name="line.71"></a>
-<span class="sourceLineNo">072</span>    this.conf = conf;<a 
name="line.72"></a>
-<span class="sourceLineNo">073</span>    this.comparator = c;<a 
name="line.73"></a>
-<span class="sourceLineNo">074</span>    resetActive();<a name="line.74"></a>
-<span class="sourceLineNo">075</span>    this.snapshot = 
SegmentFactory.instance().createImmutableSegment(c, 0);<a name="line.75"></a>
-<span class="sourceLineNo">076</span>    this.snapshotId = NO_SNAPSHOT_ID;<a 
name="line.76"></a>
-<span class="sourceLineNo">077</span>  }<a name="line.77"></a>
-<span class="sourceLineNo">078</span><a name="line.78"></a>
-<span class="sourceLineNo">079</span>  protected void resetActive() {<a 
name="line.79"></a>
-<span class="sourceLineNo">080</span>    // Reset heap to not include any 
keys<a name="line.80"></a>
-<span class="sourceLineNo">081</span>    this.active = 
SegmentFactory.instance().createMutableSegment(conf, comparator, 
DEEP_OVERHEAD);<a name="line.81"></a>
-<span class="sourceLineNo">082</span>    this.timeOfOldestEdit = 
Long.MAX_VALUE;<a name="line.82"></a>
-<span class="sourceLineNo">083</span>  }<a name="line.83"></a>
-<span class="sourceLineNo">084</span><a name="line.84"></a>
-<span class="sourceLineNo">085</span>  /*<a name="line.85"></a>
-<span class="sourceLineNo">086</span>  * Calculate how the MemStore size has 
changed.  Includes overhead of the<a name="line.86"></a>
-<span class="sourceLineNo">087</span>  * backing Map.<a name="line.87"></a>
-<span class="sourceLineNo">088</span>  * @param cell<a name="line.88"></a>
-<span class="sourceLineNo">089</span>  * @param notPresent True if the cell 
was NOT present in the set.<a name="line.89"></a>
-<span class="sourceLineNo">090</span>  * @return change in size<a 
name="line.90"></a>
-<span class="sourceLineNo">091</span>  */<a name="line.91"></a>
-<span class="sourceLineNo">092</span>  static long heapSizeChange(final Cell 
cell, final boolean notPresent) {<a name="line.92"></a>
-<span class="sourceLineNo">093</span>    return notPresent ? 
ClassSize.align(ClassSize.CONCURRENT_SKIPLISTMAP_ENTRY<a name="line.93"></a>
-<span class="sourceLineNo">094</span>        + 
CellUtil.estimatedHeapSizeOf(cell)) : 0;<a name="line.94"></a>
-<span class="sourceLineNo">095</span>  }<a name="line.95"></a>
-<span class="sourceLineNo">096</span><a name="line.96"></a>
-<span class="sourceLineNo">097</span>  /**<a name="line.97"></a>
-<span class="sourceLineNo">098</span>   * Updates the wal with the lowest 
sequence id (oldest entry) that is still in memory<a name="line.98"></a>
-<span class="sourceLineNo">099</span>   * @param onlyIfMoreRecent a flag that 
marks whether to update the sequence id no matter what or<a name="line.99"></a>
-<span class="sourceLineNo">100</span>   *                      only if it is 
greater than the previous sequence id<a name="line.100"></a>
-<span class="sourceLineNo">101</span>   */<a name="line.101"></a>
-<span class="sourceLineNo">102</span>  public abstract void 
updateLowestUnflushedSequenceIdInWAL(boolean onlyIfMoreRecent);<a 
name="line.102"></a>
-<span class="sourceLineNo">103</span><a name="line.103"></a>
-<span class="sourceLineNo">104</span>  /**<a name="line.104"></a>
-<span class="sourceLineNo">105</span>   * Write an update<a 
name="line.105"></a>
-<span class="sourceLineNo">106</span>   * @param cell the cell to be added<a 
name="line.106"></a>
-<span class="sourceLineNo">107</span>   * @return approximate size of the 
passed cell &amp; newly added cell which maybe different than the<a 
name="line.107"></a>
-<span class="sourceLineNo">108</span>   *         passed-in cell<a 
name="line.108"></a>
-<span class="sourceLineNo">109</span>   */<a name="line.109"></a>
-<span class="sourceLineNo">110</span>  @Override<a name="line.110"></a>
-<span class="sourceLineNo">111</span>  public long add(Cell cell) {<a 
name="line.111"></a>
-<span class="sourceLineNo">112</span>    Cell toAdd = 
maybeCloneWithAllocator(cell);<a name="line.112"></a>
-<span class="sourceLineNo">113</span>    boolean mslabUsed = (toAdd != 
cell);<a name="line.113"></a>
-<span class="sourceLineNo">114</span>    // This cell data is backed by the 
same byte[] where we read request in RPC(See HBASE-15180). By<a 
name="line.114"></a>
-<span class="sourceLineNo">115</span>    // default MSLAB is ON and we might 
have copied cell to MSLAB area. If not we must do below deep<a 
name="line.115"></a>
-<span class="sourceLineNo">116</span>    // copy. Or else we will keep 
referring to the bigger chunk of memory and prevent it from<a 
name="line.116"></a>
-<span class="sourceLineNo">117</span>    // getting GCed.<a 
name="line.117"></a>
-<span class="sourceLineNo">118</span>    // Copy to MSLAB would not have 
happened if<a name="line.118"></a>
-<span class="sourceLineNo">119</span>    // 1. MSLAB is turned OFF. See 
"hbase.hregion.memstore.mslab.enabled"<a name="line.119"></a>
-<span class="sourceLineNo">120</span>    // 2. When the size of the cell is 
bigger than the max size supported by MSLAB. See<a name="line.120"></a>
-<span class="sourceLineNo">121</span>    // 
"hbase.hregion.memstore.mslab.max.allocation". This defaults to 256 KB<a 
name="line.121"></a>
-<span class="sourceLineNo">122</span>    // 3. When cells are from 
Append/Increment operation.<a name="line.122"></a>
-<span class="sourceLineNo">123</span>    if (!mslabUsed) {<a 
name="line.123"></a>
-<span class="sourceLineNo">124</span>      toAdd = deepCopyIfNeeded(toAdd);<a 
name="line.124"></a>
-<span class="sourceLineNo">125</span>    }<a name="line.125"></a>
-<span class="sourceLineNo">126</span>    return internalAdd(toAdd, 
mslabUsed);<a name="line.126"></a>
-<span class="sourceLineNo">127</span>  }<a name="line.127"></a>
-<span class="sourceLineNo">128</span><a name="line.128"></a>
-<span class="sourceLineNo">129</span>  private static Cell 
deepCopyIfNeeded(Cell cell) {<a name="line.129"></a>
-<span class="sourceLineNo">130</span>    // When Cell is backed by a shared 
memory chunk (this can be a chunk of memory where we read the<a 
name="line.130"></a>
-<span class="sourceLineNo">131</span>    // req into) the Cell instance will 
be of type ShareableMemory. Later we will add feature to<a name="line.131"></a>
-<span class="sourceLineNo">132</span>    // read the RPC request into pooled 
direct ByteBuffers.<a name="line.132"></a>
-<span class="sourceLineNo">133</span>    if (cell instanceof ShareableMemory) 
{<a name="line.133"></a>
-<span class="sourceLineNo">134</span>      return ((ShareableMemory) 
cell).cloneToCell();<a name="line.134"></a>
-<span class="sourceLineNo">135</span>    }<a name="line.135"></a>
-<span class="sourceLineNo">136</span>    return cell;<a name="line.136"></a>
-<span class="sourceLineNo">137</span>  }<a name="line.137"></a>
-<span class="sourceLineNo">138</span><a name="line.138"></a>
-<span class="sourceLineNo">139</span>  /**<a name="line.139"></a>
-<span class="sourceLineNo">140</span>   * Update or insert the specified 
Cells.<a name="line.140"></a>
-<span class="sourceLineNo">141</span>   * &lt;p&gt;<a name="line.141"></a>
-<span class="sourceLineNo">142</span>   * For each Cell, insert into MemStore. 
 This will atomically upsert the<a name="line.142"></a>
-<span class="sourceLineNo">143</span>   * value for that row/family/qualifier. 
 If a Cell did already exist,<a name="line.143"></a>
-<span class="sourceLineNo">144</span>   * it will then be removed.<a 
name="line.144"></a>
-<span class="sourceLineNo">145</span>   * &lt;p&gt;<a name="line.145"></a>
-<span class="sourceLineNo">146</span>   * Currently the memstoreTS is kept at 
0 so as each insert happens, it will<a name="line.146"></a>
-<span class="sourceLineNo">147</span>   * be immediately visible.  May want to 
change this so it is atomic across<a name="line.147"></a>
-<span class="sourceLineNo">148</span>   * all Cells.<a name="line.148"></a>
-<span class="sourceLineNo">149</span>   * &lt;p&gt;<a name="line.149"></a>
-<span class="sourceLineNo">150</span>   * This is called under row lock, so 
Get operations will still see updates<a name="line.150"></a>
-<span class="sourceLineNo">151</span>   * atomically.  Scans will only see 
each Cell update as atomic.<a name="line.151"></a>
-<span class="sourceLineNo">152</span>   *<a name="line.152"></a>
-<span class="sourceLineNo">153</span>   * @param cells the cells to be 
updated<a name="line.153"></a>
-<span class="sourceLineNo">154</span>   * @param readpoint readpoint below 
which we can safely remove duplicate KVs<a name="line.154"></a>
-<span class="sourceLineNo">155</span>   * @return change in memstore size<a 
name="line.155"></a>
-<span class="sourceLineNo">156</span>   */<a name="line.156"></a>
-<span class="sourceLineNo">157</span>  @Override<a name="line.157"></a>
-<span class="sourceLineNo">158</span>  public long upsert(Iterable&lt;Cell&gt; 
cells, long readpoint) {<a name="line.158"></a>
-<span class="sourceLineNo">159</span>    long size = 0;<a name="line.159"></a>
-<span class="sourceLineNo">160</span>    for (Cell cell : cells) {<a 
name="line.160"></a>
-<span class="sourceLineNo">161</span>      size += upsert(cell, readpoint);<a 
name="line.161"></a>
-<span class="sourceLineNo">162</span>    }<a name="line.162"></a>
-<span class="sourceLineNo">163</span>    return size;<a name="line.163"></a>
-<span class="sourceLineNo">164</span>  }<a name="line.164"></a>
-<span class="sourceLineNo">165</span><a name="line.165"></a>
-<span class="sourceLineNo">166</span>  /**<a name="line.166"></a>
-<span class="sourceLineNo">167</span>   * @return Oldest timestamp of all the 
Cells in the MemStore<a name="line.167"></a>
-<span class="sourceLineNo">168</span>   */<a name="line.168"></a>
-<span class="sourceLineNo">169</span>  @Override<a name="line.169"></a>
-<span class="sourceLineNo">170</span>  public long timeOfOldestEdit() {<a 
name="line.170"></a>
-<span class="sourceLineNo">171</span>    return timeOfOldestEdit;<a 
name="line.171"></a>
-<span class="sourceLineNo">172</span>  }<a name="line.172"></a>
-<span class="sourceLineNo">173</span><a name="line.173"></a>
+<span class="sourceLineNo">071</span><a name="line.71"></a>
+<span class="sourceLineNo">072</span>  protected AbstractMemStore(final 
Configuration conf, final CellComparator c) {<a name="line.72"></a>
+<span class="sourceLineNo">073</span>    this.conf = conf;<a 
name="line.73"></a>
+<span class="sourceLineNo">074</span>    this.comparator = c;<a 
name="line.74"></a>
+<span class="sourceLineNo">075</span>    resetActive();<a name="line.75"></a>
+<span class="sourceLineNo">076</span>    this.snapshot = 
SegmentFactory.instance().createImmutableSegment(c, 0);<a name="line.76"></a>
+<span class="sourceLineNo">077</span>    this.snapshotId = NO_SNAPSHOT_ID;<a 
name="line.77"></a>
+<span class="sourceLineNo">078</span>  }<a name="line.78"></a>
+<span class="sourceLineNo">079</span><a name="line.79"></a>
+<span class="sourceLineNo">080</span>  protected void resetActive() {<a 
name="line.80"></a>
+<span class="sourceLineNo">081</span>    // Reset heap to not include any 
keys<a name="line.81"></a>
+<span class="sourceLineNo">082</span>    this.active = 
SegmentFactory.instance().createMutableSegment(conf, comparator, 
DEEP_OVERHEAD);<a name="line.82"></a>
+<span class="sourceLineNo">083</span>    this.timeOfOldestEdit = 
Long.MAX_VALUE;<a name="line.83"></a>
+<span class="sourceLineNo">084</span>  }<a name="line.84"></a>
+<span class="sourceLineNo">085</span><a name="line.85"></a>
+<span class="sourceLineNo">086</span>  /*<a name="line.86"></a>
+<span class="sourceLineNo">087</span>  * Calculate how the MemStore size has 
changed.  Includes overhead of the<a name="line.87"></a>
+<span class="sourceLineNo">088</span>  * backing Map.<a name="line.88"></a>
+<span class="sourceLineNo">089</span>  * @param cell<a name="line.89"></a>
+<span class="sourceLineNo">090</span>  * @param notPresent True if the cell 
was NOT present in the set.<a name="line.90"></a>
+<span class="sourceLineNo">091</span>  * @return change in size<a 
name="line.91"></a>
+<span class="sourceLineNo">092</span>  */<a name="line.92"></a>
+<span class="sourceLineNo">093</span>  static long heapSizeChange(final Cell 
cell, final boolean notPresent) {<a name="line.93"></a>
+<span class="sourceLineNo">094</span>    return notPresent ? 
ClassSize.align(ClassSize.CONCURRENT_SKIPLISTMAP_ENTRY<a name="line.94"></a>
+<span class="sourceLineNo">095</span>        + 
CellUtil.estimatedHeapSizeOf(cell)) : 0;<a name="line.95"></a>
+<span class="sourceLineNo">096</span>  }<a name="line.96"></a>
+<span class="sourceLineNo">097</span><a name="line.97"></a>
+<span class="sourceLineNo">098</span>  /**<a name="line.98"></a>
+<span class="sourceLineNo">099</span>   * Updates the wal with the lowest 
sequence id (oldest entry) that is still in memory<a name="line.99"></a>
+<span class="sourceLineNo">100</span>   * @param onlyIfMoreRecent a flag that 
marks whether to update the sequence id no matter what or<a name="line.100"></a>
+<span class="sourceLineNo">101</span>   *                      only if it is 
greater than the previous sequence id<a name="line.101"></a>
+<span class="sourceLineNo">102</span>   */<a name="line.102"></a>
+<span class="sourceLineNo">103</span>  public abstract void 
updateLowestUnflushedSequenceIdInWAL(boolean onlyIfMoreRecent);<a 
name="line.103"></a>
+<span class="sourceLineNo">104</span><a name="line.104"></a>
+<span class="sourceLineNo">105</span>  /**<a name="line.105"></a>
+<span class="sourceLineNo">106</span>   * Write an update<a 
name="line.106"></a>
+<span class="sourceLineNo">107</span>   * @param cell the cell to be added<a 
name="line.107"></a>
+<span class="sourceLineNo">108</span>   * @return approximate size of the 
passed cell &amp; newly added cell which maybe different than the<a 
name="line.108"></a>
+<span class="sourceLineNo">109</span>   *         passed-in cell<a 
name="line.109"></a>
+<span class="sourceLineNo">110</span>   */<a name="line.110"></a>
+<span class="sourceLineNo">111</span>  @Override<a name="line.111"></a>
+<span class="sourceLineNo">112</span>  public long add(Cell cell) {<a 
name="line.112"></a>
+<span class="sourceLineNo">113</span>    Cell toAdd = 
maybeCloneWithAllocator(cell);<a name="line.113"></a>
+<span class="sourceLineNo">114</span>    boolean mslabUsed = (toAdd != 
cell);<a name="line.114"></a>
+<span class="sourceLineNo">115</span>    // This cell data is backed by the 
same byte[] where we read request in RPC(See HBASE-15180). By<a 
name="line.115"></a>
+<span class="sourceLineNo">116</span>    // default MSLAB is ON and we might 
have copied cell to MSLAB area. If not we must do below deep<a 
name="line.116"></a>
+<span class="sourceLineNo">117</span>    // copy. Or else we will keep 
referring to the bigger chunk of memory and prevent it from<a 
name="line.117"></a>
+<span class="sourceLineNo">118</span>    // getting GCed.<a 
name="line.118"></a>
+<span class="sourceLineNo">119</span>    // Copy to MSLAB would not have 
happened if<a name="line.119"></a>
+<span class="sourceLineNo">120</span>    // 1. MSLAB is turned OFF. See 
"hbase.hregion.memstore.mslab.enabled"<a name="line.120"></a>
+<span class="sourceLineNo">121</span>    // 2. When the size of the cell is 
bigger than the max size supported by MSLAB. See<a name="line.121"></a>
+<span class="sourceLineNo">122</span>    // 
"hbase.hregion.memstore.mslab.max.allocation". This defaults to 256 KB<a 
name="line.122"></a>
+<span class="sourceLineNo">123</span>    // 3. When cells are from 
Append/Increment operation.<a name="line.123"></a>
+<span class="sourceLineNo">124</span>    if (!mslabUsed) {<a 
name="line.124"></a>
+<span class="sourceLineNo">125</span>      toAdd = deepCopyIfNeeded(toAdd);<a 
name="line.125"></a>
+<span class="sourceLineNo">126</span>    }<a name="line.126"></a>
+<span class="sourceLineNo">127</span>    return internalAdd(toAdd, 
mslabUsed);<a name="line.127"></a>
+<span class="sourceLineNo">128</span>  }<a name="line.128"></a>
+<span class="sourceLineNo">129</span><a name="line.129"></a>
+<span class="sourceLineNo">130</span>  private static Cell 
deepCopyIfNeeded(Cell cell) {<a name="line.130"></a>
+<span class="sourceLineNo">131</span>    // When Cell is backed by a shared 
memory chunk (this can be a chunk of memory where we read the<a 
name="line.131"></a>
+<span class="sourceLineNo">132</span>    // req into) the Cell instance will 
be of type ShareableMemory. Later we will add feature to<a name="line.132"></a>
+<span class="sourceLineNo">133</span>    // read the RPC request into pooled 
direct ByteBuffers.<a name="line.133"></a>
+<span class="sourceLineNo">134</span>    if (cell instanceof ShareableMemory) 
{<a name="line.134"></a>
+<span class="sourceLineNo">135</span>      return ((ShareableMemory) 
cell).cloneToCell();<a name="line.135"></a>
+<span class="sourceLineNo">136</span>    }<a name="line.136"></a>
+<span class="sourceLineNo">137</span>    return cell;<a name="line.137"></a>
+<span class="sourceLineNo">138</span>  }<a name="line.138"></a>
+<span class="sourceLineNo">139</span><a name="line.139"></a>
+<span class="sourceLineNo">140</span>  /**<a name="line.140"></a>
+<span class="sourceLineNo">141</span>   * Update or insert the specified 
Cells.<a name="line.141"></a>
+<span class="sourceLineNo">142</span>   * &lt;p&gt;<a name="line.142"></a>
+<span class="sourceLineNo">143</span>   * For each Cell, insert into MemStore. 
 This will atomically upsert the<a name="line.143"></a>
+<span class="sourceLineNo">144</span>   * value for that row/family/qualifier. 
 If a Cell did already exist,<a name="line.144"></a>
+<span class="sourceLineNo">145</span>   * it will then be removed.<a 
name="line.145"></a>
+<span class="sourceLineNo">146</span>   * &lt;p&gt;<a name="line.146"></a>
+<span class="sourceLineNo">147</span>   * Currently the memstoreTS is kept at 
0 so as each insert happens, it will<a name="line.147"></a>
+<span class="sourceLineNo">148</span>   * be immediately visible.  May want to 
change this so it is atomic across<a name="line.148"></a>
+<span class="sourceLineNo">149</span>   * all Cells.<a name="line.149"></a>
+<span class="sourceLineNo">150</span>   * &lt;p&gt;<a name="line.150"></a>
+<span class="sourceLineNo">151</span>   * This is called under row lock, so 
Get operations will still see updates<a name="line.151"></a>
+<span class="sourceLineNo">152</span>   * atomically.  Scans will only see 
each Cell update as atomic.<a name="line.152"></a>
+<span class="sourceLineNo">153</span>   *<a name="line.153"></a>
+<span class="sourceLineNo">154</span>   * @param cells the cells to be 
updated<a name="line.154"></a>
+<span class="sourceLineNo">155</span>   * @param readpoint readpoint below 
which we can safely remove duplicate KVs<a name="line.155"></a>
+<span class="sourceLineNo">156</span>   * @return change in memstore size<a 
name="line.156"></a>
+<span class="sourceLineNo">157</span>   */<a name="line.157"></a>
+<span class="sourceLineNo">158</span>  @Override<a name="line.158"></a>
+<span class="sourceLineNo">159</span>  public long upsert(Iterable&lt;Cell&gt; 
cells, long readpoint) {<a name="line.159"></a>
+<span class="sourceLineNo">160</span>    long size = 0;<a name="line.160"></a>
+<span class="sourceLineNo">161</span>    for (Cell cell : cells) {<a 
name="line.161"></a>
+<span class="sourceLineNo">162</span>      size += upsert(cell, readpoint);<a 
name="line.162"></a>
+<span class="sourceLineNo">163</span>    }<a name="line.163"></a>
+<span class="sourceLineNo">164</span>    return size;<a name="line.164"></a>
+<span class="sourceLineNo">165</span>  }<a name="line.165"></a>
+<span class="sourceLineNo">166</span><a name="line.166"></a>
+<span class="sourceLineNo">167</span>  /**<a name="line.167"></a>
+<span class="sourceLineNo">168</span>   * @return Oldest timestamp of all the 
Cells in the MemStore<a name="line.168"></a>
+<span class="sourceLineNo">169</span>   */<a name="line.169"></a>
+<span class="sourceLineNo">170</span>  @Override<a name="line.170"></a>
+<span class="sourceLineNo">171</span>  public long timeOfOldestEdit() {<a 
name="line.171"></a>
+<span class="sourceLineNo">172</span>    return timeOfOldestEdit;<a 
name="line.172"></a>
+<span class="sourceLineNo">173</span>  }<a name="line.173"></a>
 <span class="sourceLineNo">174</span><a name="line.174"></a>
-<span class="sourceLineNo">175</span>  /**<a name="line.175"></a>
-<span class="sourceLineNo">176</span>   * Write a delete<a name="line.176"></a>
-<span class="sourceLineNo">177</span>   * @param deleteCell the cell to be 
deleted<a name="line.177"></a>
-<span class="sourceLineNo">178</span>   * @return approximate size of the 
passed key and value.<a name="line.178"></a>
-<span class="sourceLineNo">179</span>   */<a name="line.179"></a>
-<span class="sourceLineNo">180</span>  @Override<a name="line.180"></a>
-<span class="sourceLineNo">181</span>  public long delete(Cell deleteCell) {<a 
name="line.181"></a>
-<span class="sourceLineNo">182</span>    // Delete operation just adds the 
delete marker cell coming here.<a name="line.182"></a>
-<span class="sourceLineNo">183</span>    return add(deleteCell);<a 
name="line.183"></a>
-<span class="sourceLineNo">184</span>  }<a name="line.184"></a>
-<span class="sourceLineNo">185</span><a name="line.185"></a>
-<span class="sourceLineNo">186</span>  /**<a name="line.186"></a>
-<span class="sourceLineNo">187</span>   * The passed snapshot was successfully 
persisted; it can be let go.<a name="line.187"></a>
-<span class="sourceLineNo">188</span>   * @param id Id of the snapshot to 
clean out.<a name="line.188"></a>
-<span class="sourceLineNo">189</span>   * @see MemStore#snapshot()<a 
name="line.189"></a>
-<span class="sourceLineNo">190</span>   */<a name="line.190"></a>
-<span class="sourceLineNo">191</span>  @Override<a name="line.191"></a>
-<span class="sourceLineNo">192</span>  public void clearSnapshot(long id) 
throws UnexpectedStateException {<a name="line.192"></a>
-<span class="sourceLineNo">193</span>    if (this.snapshotId == -1) return;  
// already cleared<a name="line.193"></a>
-<span class="sourceLineNo">194</span>    if (this.snapshotId != id) {<a 
name="line.194"></a>
-<span class="sourceLineNo">195</span>      throw new 
UnexpectedStateException("Current snapshot id is " + this.snapshotId + ",passed 
"<a name="line.195"></a>
-<span class="sourceLineNo">196</span>          + id);<a name="line.196"></a>
-<span class="sourceLineNo">197</span>    }<a name="line.197"></a>
-<span class="sourceLineNo">198</span>    // OK. Passed in snapshot is same as 
current snapshot. If not-empty,<a name="line.198"></a>
-<span class="sourceLineNo">199</span>    // create a new snapshot and let the 
old one go.<a name="line.199"></a>
-<span class="sourceLineNo">200</span>    Segment oldSnapshot = 
this.snapshot;<a name="line.200"></a>
-<span class="sourceLineNo">201</span>    if (!this.snapshot.isEmpty()) {<a 
name="line.201"></a>
-<span class="sourceLineNo">202</span>      this.snapshot = 
SegmentFactory.instance().createImmutableSegment(<a name="line.202"></a>
-<span class="sourceLineNo">203</span>          getComparator(), 0);<a 
name="line.203"></a>
-<span class="sourceLineNo">204</span>    }<a name="line.204"></a>
-<span class="sourceLineNo">205</span>    this.snapshotId = NO_SNAPSHOT_ID;<a 
name="line.205"></a>
-<span class="sourceLineNo">206</span>    oldSnapshot.close();<a 
name="line.206"></a>
-<span class="sourceLineNo">207</span>  }<a name="line.207"></a>
-<span class="sourceLineNo">208</span><a name="line.208"></a>
-<span class="sourceLineNo">209</span>  /**<a name="line.209"></a>
-<span class="sourceLineNo">210</span>   * Get the entire heap usage for this 
MemStore not including keys in the<a name="line.210"></a>
-<span class="sourceLineNo">211</span>   * snapshot.<a name="line.211"></a>
-<span class="sourceLineNo">212</span>   */<a name="line.212"></a>
-<span class="sourceLineNo">213</span>  @Override<a name="line.213"></a>
-<span class="sourceLineNo">214</span>  public long heapSize() {<a 
name="line.214"></a>
-<span class="sourceLineNo">215</span>    return getActive().getSize();<a 
name="line.215"></a>
-<span class="sourceLineNo">216</span>  }<a name="line.216"></a>
-<span class="sourceLineNo">217</span><a name="line.217"></a>
-<span class="sourceLineNo">218</span>  @Override<a name="line.218"></a>
-<span class="sourceLineNo">219</span>  public long getSnapshotSize() {<a 
name="line.219"></a>
-<span class="sourceLineNo">220</span>    return getSnapshot().getSize();<a 
name="line.220"></a>
-<span class="sourceLineNo">221</span>  }<a name="line.221"></a>
-<span class="sourceLineNo">222</span><a name="line.222"></a>
-<span class="sourceLineNo">223</span>  @Override<a name="line.223"></a>
-<span class="sourceLineNo">224</span>  public String toString() {<a 
name="line.224"></a>
-<span class="sourceLineNo">225</span>    StringBuffer buf = new 
StringBuffer();<a name="line.225"></a>
-<span class="sourceLineNo">226</span>    int i = 1;<a name="line.226"></a>
-<span class="sourceLineNo">227</span>    try {<a name="line.227"></a>
-<span class="sourceLineNo">228</span>      for (Segment segment : 
getSegments()) {<a name="line.228"></a>
-<span class="sourceLineNo">229</span>        buf.append("Segment (" + i + ") " 
+ segment.toString() + "; ");<a name="line.229"></a>
-<span class="sourceLineNo">230</span>        i++;<a name="line.230"></a>
-<span class="sourceLineNo">231</span>      }<a name="line.231"></a>
-<span class="sourceLineNo">232</span>    } catch (IOException e){<a 
name="line.232"></a>
-<span class="sourceLineNo">233</span>      return e.toString();<a 
name="line.233"></a>
-<span class="sourceLineNo">234</span>    }<a name="line.234"></a>
-<span class="sourceLineNo">235</span>    return buf.toString();<a 
name="line.235"></a>
-<span class="sourceLineNo">236</span>  }<a name="line.236"></a>
-<span class="sourceLineNo">237</span><a name="line.237"></a>
-<span class="sourceLineNo">238</span>  protected Configuration 
getConfiguration() {<a name="line.238"></a>
-<span class="sourceLineNo">239</span>    return conf;<a name="line.239"></a>
-<span class="sourceLineNo">240</span>  }<a name="line.240"></a>
-<span class="sourceLineNo">241</span><a name="line.241"></a>
-<span class="sourceLineNo">242</span>  protected void dump(Log log) {<a 
name="line.242"></a>
-<span class="sourceLineNo">243</span>    active.dump(log);<a 
name="line.243"></a>
-<span class="sourceLineNo">244</span>    snapshot.dump(log);<a 
name="line.244"></a>
-<span class="sourceLineNo">245</span>  }<a name="line.245"></a>
-<span class="sourceLineNo">246</span><a name="line.246"></a>
+<span class="sourceLineNo">175</span><a name="line.175"></a>
+<span class="sourceLineNo">176</span>  /**<a name="line.176"></a>
+<span class="sourceLineNo">177</span>   * Write a delete<a name="line.177"></a>
+<span class="sourceLineNo">178</span>   * @param deleteCell the cell to be 
deleted<a name="line.178"></a>
+<span class="sourceLineNo">179</span>   * @return approximate size of the 
passed key and value.<a name="line.179"></a>
+<span class="sourceLineNo">180</span>   */<a name="line.180"></a>
+<span class="sourceLineNo">181</span>  @Override<a name="line.181"></a>
+<span class="sourceLineNo">182</span>  public long delete(Cell deleteCell) {<a 
name="line.182"></a>
+<span class="sourceLineNo">183</span>    // Delete operation just adds the 
delete marker cell coming here.<a name="line.183"></a>
+<span class="sourceLineNo">184</span>    return add(deleteCell);<a 
name="line.184"></a>
+<span class="sourceLineNo">185</span>  }<a name="line.185"></a>
+<span class="sourceLineNo">186</span><a name="line.186"></a>
+<span class="sourceLineNo">187</span>  /**<a name="line.187"></a>
+<span class="sourceLineNo">188</span>   * The passed snapshot was successfully 
persisted; it can be let go.<a name="line.188"></a>
+<span class="sourceLineNo">189</span>   * @param id Id of the snapshot to 
clean out.<a name="line.189"></a>
+<span class="sourceLineNo">190</span>   * @see MemStore#snapshot()<a 
name="line.190"></a>
+<span class="sourceLineNo">191</span>   */<a name="line.191"></a>
+<span class="sourceLineNo">192</span>  @Override<a name="line.192"></a>
+<span class="sourceLineNo">193</span>  public void clearSnapshot(long id) 
throws UnexpectedStateException {<a name="line.193"></a>
+<span class="sourceLineNo">194</span>    if (this.snapshotId == -1) return;  
// already cleared<a name="line.194"></a>
+<span class="sourceLineNo">195</span>    if (this.snapshotId != id) {<a 
name="line.195"></a>
+<span class="sourceLineNo">196</span>      throw new 
UnexpectedStateException("Current snapshot id is " + this.snapshotId + ",passed 
"<a name="line.196"></a>
+<span class="sourceLineNo">197</span>          + id);<a name="line.197"></a>
+<span class="sourceLineNo">198</span>    }<a name="line.198"></a>
+<span class="sourceLineNo">199</span>    // OK. Passed in snapshot is same as 
current snapshot. If not-empty,<a name="line.199"></a>
+<span class="sourceLineNo">200</span>    // create a new snapshot and let the 
old one go.<a name="line.200"></a>
+<span class="sourceLineNo">201</span>    Segment oldSnapshot = 
this.snapshot;<a name="line.201"></a>
+<span class="sourceLineNo">202</span>    if (!this.snapshot.isEmpty()) {<a 
name="line.202"></a>
+<span class="sourceLineNo">203</span>      this.snapshot = 
SegmentFactory.instance().createImmutableSegment(<a name="line.203"></a>
+<span class="sourceLineNo">204</span>          getComparator(), 0);<a 
name="line.204"></a>
+<span class="sourceLineNo">205</span>    }<a name="line.205"></a>
+<span class="sourceLineNo">206</span>    this.snapshotId = NO_SNAPSHOT_ID;<a 
name="line.206"></a>
+<span class="sourceLineNo">207</span>    oldSnapshot.close();<a 
name="line.207"></a>
+<span class="sourceLineNo">208</span>  }<a name="line.208"></a>
+<span class="sourceLineNo">209</span><a name="line.209"></a>
+<span class="sourceLineNo">210</span>  /**<a name="line.210"></a>
+<span class="sourceLineNo">211</span>   * Get the entire heap usage for this 
MemStore not including keys in the<a name="line.211"></a>
+<span class="sourceLineNo">212</span>   * snapshot.<a name="line.212"></a>
+<span class="sourceLineNo">213</span>   */<a name="line.213"></a>
+<span class="sourceLineNo">214</span>  @Override<a name="line.214"></a>
+<span class="sourceLineNo">215</span>  public long heapSize() {<a 
name="line.215"></a>
+<span class="sourceLineNo">216</span>    return getActive().getSize();<a 
name="line.216"></a>
+<span class="sourceLineNo">217</span>  }<a name="line.217"></a>
+<span class="sourceLineNo">218</span><a name="line.218"></a>
+<span class="sourceLineNo">219</span>  @Override<a name="line.219"></a>
+<span class="sourceLineNo">220</span>  public long getSnapshotSize() {<a 
name="line.220"></a>
+<span class="sourceLineNo">221</span>    return getSnapshot().getSize();<a 
name="line.221"></a>
+<span class="sourceLineNo">222</span>  }<a name="line.222"></a>
+<span class="sourceLineNo">223</span><a name="line.223"></a>
+<span class="sourceLineNo">224</span>  @Override<a name="line.224"></a>
+<span class="sourceLineNo">225</span>  public String toString() {<a 
name="line.225"></a>
+<span class="sourceLineNo">226</span>    StringBuffer buf = new 
StringBuffer();<a name="line.226"></a>
+<span class="sourceLineNo">227</span>    int i = 1;<a name="line.227"></a>
+<span class="sourceLineNo">228</span>    try {<a name="line.228"></a>
+<span class="sourceLineNo">229</span>      for (Segment segment : 
getSegments()) {<a name="line.229"></a>
+<span class="sourceLineNo">230</span>        buf.append("Segment (" + i + ") " 
+ segment.toString() + "; ");<a name="line.230"></a>
+<span class="sourceLineNo">231</span>        i++;<a name="line.231"></a>
+<span class="sourceLineNo">232</span>      }<a name="line.232"></a>
+<span class="sourceLineNo">233</span>    } catch (IOException e){<a 
name="line.233"></a>
+<span class="sourceLineNo">234</span>      return e.toString();<a 
name="line.234"></a>
+<span class="sourceLineNo">235</span>    }<a name="line.235"></a>
+<span class="sourceLineNo">236</span>    return buf.toString();<a 
name="line.236"></a>
+<span class="sourceLineNo">237</span>  }<a name="line.237"></a>
+<span class="sourceLineNo">238</span><a name="line.238"></a>
+<span class="sourceLineNo">239</span>  protected Configuration 
getConfiguration() {<a name="line.239"></a>
+<span class="sourceLineNo">240</span>    return conf;<a name="line.240"></a>
+<span class="sourceLineNo">241</span>  }<a name="line.241"></a>
+<span class="sourceLineNo">242</span><a name="line.242"></a>
+<span class="sourceLineNo">243</span>  protected void dump(Log log) {<a 
name="line.243"></a>
+<span class="sourceLineNo">244</span>    active.dump(log);<a 
name="line.244"></a>
+<span class="sourceLineNo">245</span>    snapshot.dump(log);<a 
name="line.245"></a>
+<span class="sourceLineNo">246</span>  }<a name="line.246"></a>
 <span class="sourceLineNo">247</span><a name="line.247"></a>
-<span class="sourceLineNo">248</span>  /**<a name="line.248"></a>
-<span class="sourceLineNo">249</span>   * Inserts the specified Cell into 
MemStore and deletes any existing<a name="line.249"></a>
-<span class="sourceLineNo">250</span>   * versions of the same 
row/family/qualifier as the specified Cell.<a name="line.250"></a>
-<span class="sourceLineNo">251</span>   * &lt;p&gt;<a name="line.251"></a>
-<span class="sourceLineNo">252</span>   * First, the specified Cell is 
inserted into the Memstore.<a name="line.252"></a>
-<span class="sourceLineNo">253</span>   * &lt;p&gt;<a name="line.253"></a>
-<span class="sourceLineNo">254</span>   * If there are any existing Cell in 
this MemStore with the same row,<a name="line.254"></a>
-<span class="sourceLineNo">255</span>   * family, and qualifier, they are 
removed.<a name="line.255"></a>
-<span class="sourceLineNo">256</span>   * &lt;p&gt;<a name="line.256"></a>
-<span class="sourceLineNo">257</span>   * Callers must hold the read lock.<a 
name="line.257"></a>
-<span class="sourceLineNo">258</span>   *<a name="line.258"></a>
-<span class="sourceLineNo">259</span>   * @param cell the cell to be updated<a 
name="line.259"></a>
-<span class="sourceLineNo">260</span>   * @param readpoint readpoint below 
which we can safely remove duplicate KVs<a name="line.260"></a>
-<span class="sourceLineNo">261</span>   * @return change in size of MemStore<a 
name="line.261"></a>
-<span class="sourceLineNo">262</span>   */<a name="line.262"></a>
-<span class="sourceLineNo">263</span>  private long upsert(Cell cell, long 
readpoint) {<a name="line.263"></a>
-<span class="sourceLineNo">264</span>    // Add the Cell to the MemStore<a 
name="line.264"></a>
-<span class="sourceLineNo">265</span>    // Use the internalAdd method here 
since we (a) already have a lock<a name="line.265"></a>
-<span class="sourceLineNo">266</span>    // and (b) cannot safely use the 
MSLAB here without potentially<a name="line.266"></a>
-<span class="sourceLineNo">267</span>    // hitting OOME - see 
TestMemStore.testUpsertMSLAB for a<a name="line.267"></a>
-<span class="sourceLineNo">268</span>    // test that triggers the 
pathological case if we don't avoid MSLAB<a name="line.268"></a>
-<span class="sourceLineNo">269</span>    // here.<a name="line.269"></a>
-<span class="sourceLineNo">270</span>    // This cell data is backed by the 
same byte[] where we read request in RPC(See HBASE-15180). We<a 
name="line.270"></a>
-<span class="sourceLineNo">271</span>    // must do below deep copy. Or else 
we will keep referring to the bigger chunk of memory and<a name="line.271"></a>
-<span class="sourceLineNo">272</span>    // prevent it from getting GCed.<a 
name="line.272"></a>
-<span class="sourceLineNo">273</span>    cell = deepCopyIfNeeded(cell);<a 
name="line.273"></a>
-<span class="sourceLineNo">274</span>    long addedSize = internalAdd(cell, 
false);<a name="line.274"></a>
-<span class="sourceLineNo">275</span><a name="line.275"></a>
-<span class="sourceLineNo">276</span>    // Get the Cells for the 
row/family/qualifier regardless of timestamp.<a name="line.276"></a>
-<span class="sourceLineNo">277</span>    // For this case we want to clean up 
any other puts<a name="line.277"></a>
-<span class="sourceLineNo">278</span>    Cell firstCell = 
KeyValueUtil.createFirstOnRow(<a name="line.278"></a>
-<span class="sourceLineNo">279</span>        cell.getRowArray(), 
cell.getRowOffset(), cell.getRowLength(),<a name="line.279"></a>
-<span class="sourceLineNo">280</span>        cell.getFamilyArray(), 
cell.getFamilyOffset(), cell.getFamilyLength(),<a name="line.280"></a>
-<span class="sourceLineNo">281</span>        cell.getQualifierArray(), 
cell.getQualifierOffset(), cell.getQualifierLength());<a name="line.281"></a>
-<span class="sourceLineNo">282</span>    SortedSet&lt;Cell&gt; ss = 
active.tailSet(firstCell);<a name="line.282"></a>
-<span class="sourceLineNo">283</span>    Iterator&lt;Cell&gt; it = 
ss.iterator();<a name="line.283"></a>
-<span class="sourceLineNo">284</span>    // versions visible to oldest 
scanner<a name="line.284"></a>
-<span class="sourceLineNo">285</span>    int versionsVisible = 0;<a 
name="line.285"></a>
-<span class="sourceLineNo">286</span>    while (it.hasNext()) {<a 
name="line.286"></a>
-<span class="sourceLineNo">287</span>      Cell cur = it.next();<a 
name="line.287"></a>
-<span class="sourceLineNo">288</span><a name="line.288"></a>
-<span class="sourceLineNo">289</span>      if (cell == cur) {<a 
name="line.289"></a>
-<span class="sourceLineNo">290</span>        // ignore the one just put in<a 
name="line.290"></a>
-<span class="sourceLineNo">291</span>        continue;<a name="line.291"></a>
-<span class="sourceLineNo">292</span>      }<a name="line.292"></a>
-<span class="sourceLineNo">293</span>      // check that this is the row and 
column we are interested in, otherwise bail<a name="line.293"></a>
-<span class="sourceLineNo">294</span>      if (CellUtil.matchingRow(cell, cur) 
&amp;&amp; CellUtil.matchingQualifier(cell, cur)) {<a name="line.294"></a>
-<span class="sourceLineNo">295</span>        // only remove Puts that 
concurrent scanners cannot possibly see<a name="line.295"></a>
-<span class="sourceLineNo">296</span>        if (cur.getTypeByte() == 
KeyValue.Type.Put.getCode() &amp;&amp;<a name="line.296"></a>
-<span class="sourceLineNo">297</span>            cur.getSequenceId() &lt;= 
readpoint) {<a name="line.297"></a>
-<span class="sourceLineNo">298</span>          if (versionsVisible &gt;= 1) 
{<a name="line.298"></a>
-<span class="sourceLineNo">299</span>            // if we get here we have 
seen at least one version visible to the oldest scanner,<a name="line.299"></a>
-<span class="sourceLineNo">300</span>            // which means we can prove 
that no scanner will see this version<a name="line.300"></a>
-<span class="sourceLineNo">301</span><a name="line.301"></a>
-<span class="sourceLineNo">302</span>            // false means there was a 
change, so give us the size.<a name="line.302"></a>
-<span class="sourceLineNo">303</span>            long delta = 
heapSizeChange(cur, true);<a name="line.303"></a>
-<span class="sourceLineNo">304</span>            addedSize -= delta;<a 
name="line.304"></a>
-<span class="sourceLineNo">305</span>            active.incSize(-delta);<a 
name="line.305"></a>
-<span class="sourceLineNo">306</span>            it.remove();<a 
name="line.306"></a>
-<span class="sourceLineNo">307</span>            setOldestEditTimeToNow();<a 
name="line.307"></a>
-<span class="sourceLineNo">308</span>          } else {<a name="line.308"></a>
-<span class="sourceLineNo">309</span>            versionsVisible++;<a 
name="line.309"></a>
-<span class="sourceLineNo">310</span>          }<a name="line.310"></a>
-<span class="sourceLineNo">311</span>        }<a name="line.311"></a>
-<span class="sourceLineNo">312</span>      } else {<a name="line.312"></a>
-<span class="sourceLineNo">313</span>        // past the row or column, done<a 
name="line.313"></a>
-<span class="sourceLineNo">314</span>        break;<a name="line.314"></a>
-<span class="sourceLineNo">315</span>      }<a name="line.315"></a>
-<span class="sourceLineNo">316</span>    }<a name="line.316"></a>
-<span class="sourceLineNo">317</span>    return addedSize;<a 
name="line.317"></a>
-<span class="sourceLineNo">318</span>  }<a name="line.318"></a>
-<span class="sourceLineNo">319</span><a name="line.319"></a>
-<span class="sourceLineNo">320</span>  /*<a name="line.320"></a>
-<span class="sourceLineNo">321</span>   * @param a<a name="line.321"></a>
-<span class="sourceLineNo">322</span>   * @param b<a name="line.322"></a>
-<span class="sourceLineNo">323</span>   * @return Return lowest of a or b or 
null if both a and b are null<a name="line.323"></a>
-<span class="sourceLineNo">324</span>   */<a name="line.324"></a>
-<span class="sourceLineNo">325</span>  protected Cell getLowest(final Cell a, 
final Cell b) {<a name="line.325"></a>
-<span class="sourceLineNo">326</span>    if (a == null) {<a 
name="line.326"></a>
-<span class="sourceLineNo">327</span>      return b;<a name="line.327"></a>
-<span class="sourceLineNo">328</span>    }<a name="line.328"></a>
-<span class="sourceLineNo">329</span>    if (b == null) {<a 
name="line.329"></a>
-<span class="sourceLineNo">330</span>      return a;<a name="line.330"></a>
-<span class="sourceLineNo">331</span>    }<a name="line.331"></a>
-<span class="sourceLineNo">332</span>    return comparator.compareRows(a, b) 
&lt;= 0? a: b;<a name="line.332"></a>
-<span class="sourceLineNo">333</span>  }<a name="line.333"></a>
-<span class="sourceLineNo">334</span><a name="line.334"></a>
-<span class="sourceLineNo">335</span>  /*<a name="line.335"></a>
-<span class="sourceLineNo">336</span>   * @param key Find row that follows 
this one.  If null, return first.<a name="line.336"></a>
-<span class="sourceLineNo">337</span>   * @param set Set to look in for a row 
beyond &lt;code&gt;row&lt;/code&gt;.<a name="line.337"></a>
-<span class="sourceLineNo">338</span>   * @return Next row or null if none 
found.  If one found, will be a new<a name="line.338"></a>
-<span class="sourceLineNo">339</span>   * KeyValue -- can be destroyed by 
subsequent calls to this method.<a name="line.339"></a>
-<span class="sourceLineNo">340</span>   */<a name="line.340"></a>
-<span class="sourceLineNo">341</span>  protected Cell getNextRow(final Cell 
key,<a name="line.341"></a>
-<span class="sourceLineNo">342</span>      final NavigableSet&lt;Cell&gt; set) 
{<a name="line.342"></a>
-<span class="sourceLineNo">343</span>    Cell result = null;<a 
name="line.343"></a>
-<span class="sourceLineNo">344</span>    SortedSet&lt;Cell&gt; tail = key == 
null? set: set.tailSet(key);<a name="line.344"></a>
-<span class="sourceLineNo">345</span>    // Iterate until we fall into the 
next row; i.e. move off current row<a name="line.345"></a>
-<span class="sourceLineNo">346</span>    for (Cell cell: tail) {<a 
name="line.346"></a>
-<span class="sourceLineNo">347</span>      if (comparator.compareRows(cell, 
key) &lt;= 0) {<a name="line.347"></a>
-<span class="sourceLineNo">348</span>        continue;<a name="line.348"></a>
-<span class="sourceLineNo">349</span>      }<a name="line.349"></a>
-<span class="sourceLineNo">350</span>      // Note: Not suppressing deletes or 
expired cells.  Needs to be handled<a name="line.350"></a>
-<span class="sourceLineNo">351</span>      // by higher up functions.<a 
name="line.351"></a>
-<span class="sourceLineNo">352</span>      result = cell;<a 
name="line.352"></a>
-<span class="sourceLineNo">353</span>      break;<a name="line.353"></a>
-<span class="sourceLineNo">354</span>    }<a name="line.354"></a>
-<span class="sourceLineNo">355</span>    return result;<a name="line.355"></a>
-<span class="sourceLineNo">356</span>  }<a name="line.356"></a>
-<span class="sourceLineNo">357</span><a name="line.357"></a>
-<span class="sourceLineNo">358</span>  /**<a name="line.358"></a>
-<span class="sourceLineNo">359</span>   * Given the specs of a column, update 
it, first by inserting a new record,<a name="line.359"></a>
-<span class="sourceLineNo">360</span>   * then removing the old one.  Since 
there is only 1 KeyValue involved, the memstoreTS<a name="line.360"></a>
-<span class="sourceLineNo">361</span>   * will be set to 0, thus ensuring that 
they instantly appear to anyone. The underlying<a name="line.361"></a>
-<span class="sourceLineNo">362</span>   * store will ensure that the 
insert/delete each are atomic. A scanner/reader will either<a 
name="line.362"></a>
-<span class="sourceLineNo">363</span>   * get the new value, or the old value 
and all readers will eventually only see the new<a name="line.363"></a>
-<span class="sourceLineNo">364</span>   * value after the old was removed.<a 
name="line.364"></a>
-<span class="sourceLineNo">365</span>   */<a name="line.365"></a>
-<span class="sourceLineNo">366</span>  @VisibleForTesting<a 
name="line.366"></a>
-<span class="sourceLineNo">367</span>  @Override<a name="line.367"></a>
-<span class="sourceLineNo">368</span>  public long updateColumnValue(byte[] 
row, byte[] family, byte[] qualifier,<a name="line.368"></a>
-<span class="sourceLineNo">369</span>      long newValue, long now) {<a 
name="line.369"></a>
-<span class="sourceLineNo">370</span>    Cell firstCell = 
KeyValueUtil.createFirstOnRow(row, family, qualifier);<a name="line.370"></a>
-<span class="sourceLineNo">371</span>    // Is there a Cell in 'snapshot' with 
the same TS? If so, upgrade the timestamp a bit.<a name="line.371"></a>
-<span class="sourceLineNo">372</span>    Cell snc = 
snapshot.getFirstAfter(firstCell);<a name="line.372"></a>
-<span class="sourceLineNo">373</span>    if(snc != null) {<a 
name="line.373"></a>
-<span class="sourceLineNo">374</span>      // is there a matching Cell in the 
snapshot?<a name="line.374"></a>
-<span class="sourceLineNo">375</span>      if (CellUtil.matchingRow(snc, 
firstCell) &amp;&amp; CellUtil.matchingQualifier(snc, firstCell)) {<a 
name="line.375"></a>
-<span class="sourceLineNo">376</span>        if (snc.getTimestamp() == now) 
{<a name="line.376"></a>
-<span class="sourceLineNo">377</span>          now += 1;<a name="line.377"></a>
-<span class="sourceLineNo">378</span>        }<a name="line.378"></a>
-<span class="sourceLineNo">379</span>      }<a name="line.379"></a>
-<span class="sourceLineNo">380</span>    }<a name="line.380"></a>
-<span class="sourceLineNo">381</span>    // logic here: the new ts MUST be at 
least 'now'. But it could be larger if necessary.<a name="line.381"></a>
-<span class="sourceLineNo">382</span>    // But the timestamp should also be 
max(now, mostRecentTsInMemstore)<a name="line.382"></a>
-<span class="sourceLineNo">383</span><a name="line.383"></a>
-<span class="sourceLineNo">384</span>    // so we cant add the new Cell w/o 
knowing what's there already, but we also<a name="line.384"></a>
-<span class="sourceLineNo">385</span>    // want to take this chance to delete 
some cells. So two loops (sad)<a name="line.385"></a>
-<span class="sourceLineNo">386</span><a name="line.386"></a>
-<span class="sourceLineNo">387</span>    SortedSet&lt;Cell&gt; ss = 
getActive().tailSet(firstCell);<a name="line.387"></a>
-<span class="sourceLineNo">388</span>    for (Cell cell : ss) {<a 
name="line.388"></a>
-<span class="sourceLineNo">389</span>      // if this isnt the row we are 
interested in, then bail:<a name="line.389"></a>
-<span class="sourceLineNo">390</span>      if (!CellUtil.matchingColumn(cell, 
family, qualifier)<a name="line.390"></a>
-<span class="sourceLineNo">391</span>          || !CellUtil.matchingRow(cell, 
firstCell)) {<a name="line.391"></a>
-<span class="sourceLineNo">392</span>        break; // rows dont match, 
bail.<a name="line.392"></a>
-<span class="sourceLineNo">393</span>      }<a name="line.393"></a>
-<span class="sourceLineNo">394</span><a name="line.394"></a>
-<span class="sourceLineNo">395</span>      // if the qualifier matches and 
it's a put, just RM it out of the active.<a name="line.395"></a>
-<span class="sourceLineNo">396</span>      if (cell.getTypeByte() == 
KeyValue.Type.Put.getCode() &amp;&amp;<a name="line.396"></a>
-<span class="sourceLineNo">397</span>          cell.getTimestamp() &gt; now 
&amp;&amp; CellUtil.matchingQualifier(firstCell, cell)) {<a name="line.397"></a>
-<span class="sourceLineNo">398</span>        now = cell.getTimestamp();<a 
name="line.398"></a>
-<span class="sourceLineNo">399</span>      }<a name="line.399"></a>
-<span class="sourceLineNo">400</span>    }<a name="line.400"></a>
-<span class="sourceLineNo">401</span><a name="line.401"></a>
-<span class="sourceLineNo">402</span>    // create or update (upsert) a new 
Cell with<a name="line.402"></a>
-<span class="sourceLineNo">403</span>    // 'now' and a 0 memstoreTS == 
immediately visible<a name="line.403"></a>
-<span class="sourceLineNo">404</span>    List&lt;Cell&gt; cells = new 
ArrayList&lt;Cell&gt;(1);<a name="line.404"></a>
-<span class="sourceLineNo">405</span>    cells.add(new KeyValue(row, family, 
qualifier, now, Bytes.toBytes(newValue)));<a name="line.405"></a>
-<span class="sourceLineNo">406</span>    return upsert(cells, 1L);<a 
name="line.406"></a>
-<span class="sourceLineNo">407</span>  }<a name="line.407"></a>
-<span class="sourceLineNo">408</span><a name="line.408"></a>
-<span class="sourceLineNo">409</span>  private Cell 
maybeCloneWithAllocator(Cell cell) {<a name="line.409"></a>
-<span class="sourceLineNo">410</span>    return 
active.maybeCloneWithAllocator(cell);<a name="line.410"></a>
-<span class="sourceLineNo">411</span>  }<a name="line.411"></a>
-<span class="sourceLineNo">412</span><a name="line.412"></a>
-<span class="sourceLineNo">413</span>  /**<a name="line.413"></a>
-<span class="sourceLineNo">414</span>   * Internal version of add() that 
doesn't clone Cells with the<a name="line.414"></a>
-<span class="sourceLineNo">415</span>   * allocator, and doesn't take the 
lock.<a name="line.415"></a>
-<span class="sourceLineNo">416</span>   *<a name="line.416"></a>
-<span class="sourceLineNo">417</span>   * Callers should ensure they already 
have the read lock taken<a name="line.417"></a>
-<span class="sourceLineNo">418</span>   * @param toAdd the cell to add<a 
name="line.418"></a>
-<span class="sourceLineNo">419</span>   * @param mslabUsed whether using 
MSLAB<a name="line.419"></a>
-<span class="sourceLineNo">420</span>   * @return the heap size change in 
bytes<a name="line.420"></a>
-<span class="sourceLineNo">421</span>   */<a name="line.421"></a>
-<span class="sourceLineNo">422</span>  private long internalAdd(final Cell 
toAdd, final boolean mslabUsed) {<a name="line.422"></a>
-<span class="sourceLineNo">423</span>    long s = active.add(toAdd, 
mslabUsed);<a name="line.423"></a>
-<span class="sourceLineNo">424</span>    setOldestEditTimeToNow();<a 
name="line.424"></a>
-<span class="sourceLineNo">425</span>    checkActiveSize();<a 
name="line.425"></a>
-<span class="sourceLineNo">426</span>    return s;<a name="line.426"></a>
-<span class="sourceLineNo">427</span>  }<a name="line.427"></a>
-<span class="sourceLineNo">428</span><a name="line.428"></a>
-<span class="sourceLineNo">429</span>  private void setOldestEditTimeToNow() 
{<a name="line.429"></a>
-<span class="sourceLineNo">430</span>    if (timeOfOldestEdit == 
Long.MAX_VALUE) {<a name="line.430"></a>
-<span class="sourceLineNo">431</span>      timeOfOldestEdit = 
EnvironmentEdgeManager.currentTime();<a name="line.431"></a>
-<span class="sourceLineNo">432</span>    }<a name="line.432"></a>
-<span class="sourceLineNo">433</span>  }<a name="line.433"></a>
-<span class="sourceLineNo">434</span><a name="line.434"></a>
-<span class="sourceLineNo">435</span>  protected long keySize() {<a 
name="line.435"></a>
-<span class="sourceLineNo">436</span>    return heapSize() - DEEP_OVERHEAD;<a 
name="line.436"></a>
-<span class="sourceLineNo">437</span>  }<a name="line.437"></a>
-<span class="sourceLineNo">438</span><a name="line.438"></a>
-<span class="sourceLineNo">439</span>  protected CellComparator 
getComparator() {<a name="line.439"></a>
-<span class="sourceLineNo">440</span>    return comparator;<a 
name="line.440"></a>
-<span class="sourceLineNo">441</span>  }<a name="line.441"></a>
-<span class="sourceLineNo">442</span><a name="line.442"></a>
-<span class="sourceLineNo">443</span>  protected MutableSegment getActive() 
{<a name="line.443"></a>
-<span class="sourceLineNo">444</span>    return active;<a name="line.444"></a>
-<span class="sourceLineNo">445</span>  }<a name="line.445"></a>
-<span class="sourceLineNo">446</span><a name="line.446"></a>
-<span class="sourceLineNo">447</span>  protected ImmutableSegment 
getSnapshot() {<a name="line.447"></a>
-<span class="sourceLineNo">448</span>    return snapshot;<a 
name="line.448"></a>
-<span class="sourceLineNo">449</span>  }<a name="line.449"></a>
-<span class="sourceLineNo">450</span><a name="line.450"></a>
-<span class="sourceLineNo">451</span>  protected AbstractMemStore 
setSnapshot(ImmutableSegment snapshot) {<a name="line.451"></a>
-<span class="sourceLineNo">452</span>    this.snapshot = snapshot;<a 
name="line.452"></a>
-<span class="sourceLineNo">453</span>    return this;<a name="line.453"></a>
-<span class="sourceLineNo">454</span>  }<a name="line.454"></a>
-<span class="sourceLineNo">455</span><a name="line.455"></a>
-<span class="sourceLineNo">456</span>  protected void setSnapshotSize(long 
snapshotSize) {<a name="line.456"></a>
-<span class="sourceLineNo">457</span>    
getSnapshot().setSize(snapshotSize);<a name="line.457"></a>
-<span class="sourceLineNo">458</span>  }<a name="line.458"></a>
-<span class="sourceLineNo">459</span><a name="line.459"></a>
-<span class="sourceLineNo">460</span>  /**<a name="line.460"></a>
-<span class="sourceLineNo">461</span>   * Check whether anything need to be 
done based on the current active set size<a name="line.461"></a>
-<span class="sourceLineNo">462</span>   */<a name="line.462"></a>
-<span class="sourceLineNo">463</span>  protected abstract void 
checkActiveSize();<a name="line.463"></a>
-<span class="sourceLineNo">464</span><a name="line.464"></a>
-<span class="sourceLineNo">465</span>  /**<a name="line.465"></a>
-<span class="sourceLineNo">466</span>   * Returns an ordered list of segments 
from most recent to oldest in memstore<a name="line.466"></a>
-<span class="sourceLineNo">467</span>   * @return an ordered list of segments 
from most recent to oldest in memstore<a name="line.467"></a>
-<span class="sourceLineNo">468</span>   */<a name="line.468"></a>
-<span class="sourceLineNo">469</span>  protected abstract List&lt;Segment&gt; 
getSegments() throws IOException;<a name="line.469"></a>
-<span class="sourceLineNo">470</span><a name="line.470"></a>
-<span class="sourceLineNo">471</span>}<a name="line.471"></a>
+<span class="sourceLineNo">248</span><a name="line.248"></a>
+<span class="sourceLineNo">249</span>  /**<a name="line.249"></a>
+<span class="sourceLineNo">250</span>   * Inserts the specified Cell into 
MemStore and deletes any existing<a name="line.250"></a>
+<span class="sourceLineNo">251</span>   * versions of the same 
row/family/qualifier as the specified Cell.<a name="line.251"></a>
+<span class="sourceLineNo">252</span>   * &lt;p&gt;<a name="line.252"></a>
+<span class="sourceLineNo">253</span>   * First, the specified Cell is 
inserted into the Memstore.<a name="line.253"></a>
+<span class="sourceLineNo">254</span>   * &lt;p&gt;<a name="line.254"></a>
+<span class="sourceLineNo">255</span>   * If there are any existing Cell in 
this MemStore with the same row,<a name="line.255"></a>
+<span class="sourceLineNo">256</span>   * family, and qualifier, they are 
removed.<a name="line.256"></a>
+<span class="sourceLineNo">257</span>   * &lt;p&gt;<a name="line.257"></a>
+<span class="sourceLineNo">258</span>   * Callers must hold the read lock.<a 
name="line.258"></a>
+<span class="sourceLineNo">259</span>   *<a name="line.259"></a>
+<span class="sourceLineNo">260</span>   * @param cell the cell to be updated<a 
name="line.260"></a>
+<span class="sourceLineNo">261</span>   * @param readpoint readpoint below 
which we can safely remove duplicate KVs<a name="line.261"></a>
+<span class="sourceLineNo">262</span>   * @return change in size of MemStore<a 
name="line.262"></a>
+<span class="sourceLineNo">263</span>   */<a name="line.263"></a>
+<span class="sourceLineNo">264</span>  private long upsert(Cell cell, long 
readpoint) {<a name="line.264"></a>
+<span class="sourceLineNo">265</span>    // Add the Cell to the MemStore<a 
name="line.265"></a>
+<span class="sourceLineNo">266</span>    // Use the internalAdd method here 
since we (a) already have a lock<a name="line.266"></a>
+<span class="sourceLineNo">267</span>    // and (b) cannot safely use the 
MSLAB here without potentially<a name="line.267"></a>
+<span class="sourceLineNo">268</span>    // hitting OOME - see 
TestMemStore.testUpsertMSLAB for a<a name="line.268"></a>
+<span class="sourceLineNo">269</span>    // test that triggers the 
pathological case if we don't avoid MSLAB<a name="line.269"></a>
+<span class="sourceLineNo">270</span>    // here.<a name="line.270"></a>
+<span class="sourceLineNo">271</span>    // This cell data is backed by the 
same byte[] where we read request in RPC(See HBASE-15180). We<a 
name="line.271"></a>
+<span class="sourceLineNo">272</span>    // must do below deep copy. Or else 
we will keep referring to the bigger chunk of memory and<a name="line.272"></a>
+<span class="sourceLineNo">273</span>    // prevent it from getting GCed.<a 
name="line.273"></a>
+<span class="sourceLineNo">274</span>    cell = deepCopyIfNeeded(cell);<a 
name="line.274"></a>
+<span class="sourceLineNo">275</span>    long addedSize = internalAdd(cell, 
false);<a name="line.275"></a>
+<span class="sourceLineNo">276</span><a name="line.276"></a>
+<span class="sourceLineNo">277</span>    // Get the Cells for the 
row/family/qualifier regardless of timestamp.<a name="line.277"></a>
+<span class="sourceLineNo">278</span>    // For this case we want to clean up 
any other puts<a name="line.278"></a>
+<span class="sourceLineNo">279</span>    Cell firstCell = 
KeyValueUtil.createFirstOnRow(<a name="line.279"></a>
+<span class="sourceLineNo">280</span>        cell.getRowArray(), 
cell.getRowOffset(), cell.getRowLength(),<a name="line.280"></a>
+<span class="sourceLineNo">281</span>        cell.getFamilyArray(), 
cell.getFamilyOffset(), cell.getFamilyLength(),<a name="line.281"></a>
+<span class="sourceLineNo">282</span>        cell.getQualifierArray(), 
cell.getQualifierOffset(), cell.getQualifierLength());<a name="line.282"></a>
+<span class="sourceLineNo">283</span>    SortedSet&lt;Cell&gt; ss = 
active.tailSet(firstCell);<a name="line.283"></a>
+<span class="sourceLineNo">284</span>    Iterator&lt;Cell&gt; it = 
ss.iterator();<a name="line.284"></a>
+<span class="sourceLineNo">285</span>    // versions visible to oldest 
scanner<a name="line.285"></a>
+<span class="sourceLineNo">286</span>    int versionsVisible = 0;<a 
name="line.286"></a>
+<span class="sourceLineNo">287</span>    while (it.hasNext()) {<a 
name="line.287"></a>
+<span class="sourceLineNo">288</span>      Cell cur = it.next();<a 
name="line.288"></a>
+<span class="sourceLineNo">289</span><a name="line.289"></a>
+<span class="sourceLineNo">290</span>      if (cell == cur) {<a 
name="line.290"></a>
+<span class="sourceLineNo">291</span>        // ignore the one just put in<a 
name="line.291"></a>
+<span class="sourceLineNo">292</span>        continue;<a name="line.292"></a>
+<span class="sourceLineNo">293</span>      }<a name="line.293"></a>
+<span class="sourceLineNo">294</span>      // check that this is the row and 
column we are interested in, otherwise bail<a name="line.294"></a>
+<span class="sourceLineNo">295</span>      if (CellUtil.matchingRow(cell, cur) 
&amp;&amp; CellUtil.matchingQualifier(cell, cur)) {<a name="line.295"></a>
+<span class="sourceLineNo">296</span>        // only remove Puts that 
concurrent scanners cannot possibly see<a name="line.296"></a>
+<span class="sourceLineNo">297</span>        if (cur.getTypeByte() == 
KeyValue.Type.Put.getCode() &amp;&amp;<a name="line.297"></a>
+<span class="sourceLineNo">298</span>            cur.getSequenceId() &lt;= 
readpoint) {<a name="line.298"></a>
+<span class="sourceLineNo">299</span>          if (versionsVisible &gt;= 1) 
{<a name="line.299"></a>
+<span class="sourceLineNo">300</span>            // if we get here we have 
seen at least one version visible to the oldest scanner,<a name="line.300"></a>
+<span class="sourceLineNo">301</span>            // which means we can prove 
that no scanner will see this version<a name="line.301"></a>
+<span class="sourceLineNo">302</span><a name="line.302"></a>
+<span class="sourceLineNo">303</span>            // false means there was a 
change, so give us the size.<a name="line.303"></a>
+<span class="sourceLineNo">304</span>            long delta = 
heapSizeChange(cur, true);<a name="line.304"></a>
+<span class="sourceLineNo">305</span>            addedSize -= delta;<a 
name="line.305"></a>
+<span class="sourceLineNo">306</span>            active.incSize(-delta);<a 
name="line.306"></a>
+<span class="sourceLineNo">307</span>            it.remove();<a 
name="line.307"></a>
+<span class="sourceLineNo">308</span>            setOldestEditTimeToNow();<a 
name="line.308"></a>
+<span class="sourceLineNo">309</span>          } else {<a name="line.309"></a>
+<span class="sourceLineNo">310</span>            versionsVisible++;<a 
name="line.310"></a>
+<span class="sourceLineNo">311</span>          }<a name="line.311"></a>
+<span class="sourceLineNo">312</span>        }<a name="line.312"></a>
+<span class="sourceLineNo">313</span>      } else {<a name="line.313"></a>
+<span class="sourceLineNo">314</span>        // past the row or column, done<a 
name="line.314"></a>
+<span class="sourceLineNo">315</span>        break;<a name="line.315"></a>
+<span class="sourceLineNo">316</span>      }<a name="line.316"></a>
+<span class="sourceLineNo">317</span>    }<a name="line.317"></a>
+<span class="sourceLineNo">318</span>    return addedSize;<a 
name="line.318"></a>
+<span class="sourceLineNo">319</span>  }<a name="line.319"></a>
+<span class="sourceLineNo">320</span><a name="line.320"></a>
+<span class="sourceLineNo">321</span>  /*<a name="line.321"></a>
+<span class="sourceLineNo">322</span>   * @param a<a name="line.322"></a>
+<span class="sourceLineNo">323</span>   * @param b<a name="line.323"></a>
+<span class="sourceLineNo">324</span>   * @return Return lowest of a or b or 
null if both a and b are null<a name="line.324"></a>
+<span class="sourceLineNo">325</span>   */<a name="line.325"></a>
+<span class="sourceLineNo">326</span>  protected Cell getLowest(final Cell a, 
final Cell b) {<a name="line.326"></a>
+<span class="sourceLineNo">327</span>    if (a == null) {<a 
name="line.327"></a>
+<span class="sourceLineNo">328</span>      return b;<a name="line.328"></a>
+<span class="sourceLineNo">329</span>    }<a name="line.329"></a>
+<span class="sourceLineNo">330</span>    if (b == null) {<a 
name="line.330"></a>
+<span class="sourceLineNo">331</span>      return a;<a name="line.331"></a>
+<span class="sourceLineNo">332</span>    }<a name="line.332"></a>
+<span class="sourceLineNo">333</span>    return comparator.compareRows(a, b) 
&lt;= 0? a: b;<a name="line.333"></a>
+<span class="sourceLineNo">334</span>  }<a name="line.334"></a>
+<span class="sourceLineNo">335</span><a name="line.335"></a>
+<span class="sourceLineNo">336</span>  /*<a name="line.336"></a>
+<span class="sourceLineNo">337</span>   * @param key Find row that follows 
this one.  If null, return first.<a name="line.337"></a>
+<span class="sourceLineNo">338</span>   * @param set Set to look in for a row 
beyond &lt;code&gt;row&lt;/code&gt;.<a name="line.338"></a>
+<span class="sourceLineNo">339</span>   * @return Next row or null if none 
found.  If one found, will be a new<a name="line.339"></a>
+<span class="sourceLineNo">340</span>   * KeyValue -- can be destroyed by 
subsequent calls to this method.<a name="line.340"></a>
+<span class="sourceLineNo">341</span>   */<a name="line.341"></a>
+<span class="sourceLineNo">342</span>  protected Cell getNextRow(final Cell 
key,<a name="line.342"></a>
+<span class="sourceLineNo">343</span>      final NavigableSet&lt;Cell&gt; set) 
{<a name="line.343"></a>
+<span class="sourceLineNo">344</span>    Cell result = null;<a 
name="line.344"></a>
+<span class="sourceLineNo">345</span>    SortedSet&lt;Cell&gt; tail = key == 
null? set: set.tailSet(key);<a name="line.345"></a>
+<span class="sourceLineNo">346</span>    // Iterate until we fall into the 
next row; i.e. move off current row<a name="line.346"></a>
+<span class="sourceLineNo">347</span>    for (Cell cell: tail) {<a 
name="line.347"></a>
+<span class="sourceLineNo">348</span>      if (comparator.compareRows(cell, 
key) &lt;= 0) {<a name="line.348"></a>
+<span class="sourceLineNo">349</span>        continue;<a name="line.349"></a>
+<span class="sourceLineNo">350</span>      }<a name="line.350"></a>
+<span class="sourceLineNo">351</span>      // Note: Not suppressing deletes or 
expired cells.  Needs to be handled<a name="line.351"></a>
+<span class="sourceLineNo">352</span>      // by higher up functions.<a 
name="line.352"></a>
+<span class="sourceLineNo">353</span>      result = cell;<a 
name="line.353"></a>
+<span class="sourceLineNo">354</span>      break;<a name="line.354"></a>
+<span class="sourceLineNo">355</span>    }<a name="line.355"></a>
+<span class="sourceLineNo">356</span>    return result;<a name="line.356"></a>
+<span class="sourceLineNo">357</span>  }<a name="line.357"></a>
+<span class="sourceLineNo">358</span><a name="line.358"></a>
+<span class="sourceLineNo">359</span>  /**<a name="line.359"></a>
+<span class="sourceLineNo">360</span>   * Given the specs of a column, update 
it, first by inserting a new record,<a name="line.360"></a>
+<span class="sourceLineNo">361</span>   * then removing the old one.  Since 
there is only 1 KeyValue involved, the memstoreTS<a name="line.361"></a>
+<span class="sourceLineNo">362</span>   * will be set to 0, thus ensuring that 
they instantly appear to anyone. The underlying<a name="line.362"></a>
+<span class="sourceLineNo">363</span>   * store will ensure that the 
insert/delete each are atomic. A scanner/reader will either<a 
name="line.363"></a>
+<span class="sourceLineNo">364</span>   * get the new value, or the old value 
and all readers will eventually only see the new<a name="line.364"></a>
+<span class="sourceLineNo">365</span>   * value after the old was removed.<a 
name="line.365"></a>
+<span class="sourceLineNo">366</span>   */<a name="line.366"></a>
+<span class="sourceLineNo">367</span>  @VisibleForTesting<a 
name="line.367"></a>
+<span class="sourceLineNo">368</span>  @Override<a name="line.368"></a>
+<span class="sourceLineNo">369</span>  public long updateColumnValue(byte[] 
row, byte[] family, byte[] qualifier,<a name="line.369"></a>
+<span class="sourceLineNo">370</span>      long newValue, long now) {<a 
name="line.370"></a>
+<span class="sourceLineNo">371</span>    Cell firstCell = 
KeyValueUtil.createFirstOnRow(row, family, qualifier);<a name="line.371"></a>
+<span class="sourceLineNo">372</span>    // Is there a Cell in 'snapshot' with 
the same TS? If so, upgrade the timestamp a bit.<a name="line.372"></a>
+<span class="sourceLineNo">373</span>    Cell snc = 
snapshot.getFirstAfter(firstCell);<a name="line.373"></a>
+<span class="sourceLineNo">374</span>    if(snc != null) {<a 
name="line.374"></a>
+<span class="sourceLineNo">375</span>      // is there a matching Cell in the 
snapshot?<a name="line.375"></a>
+<span class="sourceLineNo">376</span>      if (CellUtil.matchingRow(snc, 
firstCell) &amp;&amp; CellUtil.matchingQualifier(snc, firstCell)) {<a 
name="line.376"></a>
+<span class="sourceLineNo">377</span>        if (snc.getTimestamp() == now) 
{<a name="line.377"></a>
+<span class="sourceLineNo">378</span>          now += 1;<a name="line.378"></a>
+<span class="sourceLineNo">379</span>        }<a name="line.379"></a>
+<span class="sourceLineNo">380</span>      }<a name="line.380"></a>
+<span class="sourceLineNo">381</span>    }<a name="line.381"></a>
+<span class="sourceLineNo">382</span>    // logic here: the new ts MUST be at 
least 'now'. But it could be larger if necessary.<a name="line.382"></a>
+<span class="sourceLineNo">383</span>    // But the timestamp should also be 
max(now, mostRecentTsInMemstore)<a name="line.383"></a>
+<span class="sourceLineNo">384</span><a name="line.384"></a>
+<span class="sourceLineNo">385</span>    // so we cant add the new Cell w/o 
knowing what's there already, but we also<a name="line.385"></a>
+<span class="sourceLineNo">386</span>    // want to take this chance to delete 
some cells. So two loops (sad)<a name="line.386"></a>
+<span class="sourceLineNo">387</span><a name="line.387"></a>
+<span class="sourceLineNo">388</span>    SortedSet&lt;Cell&gt; ss = 
getActive().tailSet(firstCell);<a name="line.388"></a>
+<span class="sourceLineNo">389</span>    for (Cell cell : ss) {<a 
name="line.389"></a>
+<span class="sourceLineNo">390</span>      // if this isnt the row we are 
interested in, then bail:<a name="line.390"></a>
+<span class="sourceLineNo">391</span>      if (!CellUtil.matchingColumn(cell, 
family, qualifier)<a name="line.391"></a>
+<span class="sourceLineNo">392</span>          || !CellUtil.matchingRow(cell, 
firstCell)) {<a name="line.392"></a>
+<span class="sourceLineNo">393</span>        break; // rows dont match, 
bail.<a name="line.393"></a>
+<span class="sourceLineNo">394</span>      }<a name="line.394"></a>
+<span class="sourceLineNo">395</span><a name="line.395"></a>
+<span class="sourceLineNo">396</span>      // if the qualifier matches and 
it's a put, just RM it out of the active.<a name="line.396"></a>
+<span class="sourceLineNo">397</span>      if (cell.getTypeByte() == 
KeyValue.Type.Put.getCode() &amp;&amp;<a name="line.397"></a>
+<span class="sourceLineNo">398</span>          cell.getTimestamp() &gt; now 
&amp;&amp; CellUtil.matchingQualifier(firstCell, cell)) {<a name="line.398"></a>
+<span class="sourceLineNo">399</span>        now = cell.getTimestamp();<a 
name="line.399"></a>
+<span class="sourceLineNo">400</span>      }<a name="line.400"></a>
+<span class="sourceLineNo">401</span>    }<a name="line.401"></a>
+<span class="sourceLineNo">402</span><a name="line.402"></a>
+<span class="sourceLineNo">403</span>    // create or update (upsert) a new 
Cell with<a name="line.403"></a>
+<span class="sourceLineNo">404</span>    // 'now' and a 0 memstoreTS == 
immediately visible<a name="line.404"></a>
+<span class="sourceLineNo">405</span>    List&lt;Cell&gt; cells = new 
ArrayList&lt;Cell&gt;(1);<a name="line.405"></a>
+<span class="sourceLineNo">406</span>    cells.add(new KeyValue(row, family, 
qualifier, now, Bytes.toBytes(newValue)));<a name="line.406"></a>
+<span class="sourceLineNo">407</span>    return upsert(cells, 1L);<a 
name="line.407"></a>
+<span class="sourceLineNo">408</span>  }<a name="line.408"></a>
+<span class="sourceLineNo">409</span><a name="line.409"></a>
+<span class="sourceLineNo">410</span>  private Cell 
maybeCloneWithAllocator(Cell cell) {<a name="line.410"></a>
+<span class="sourceLineNo">411</span>    return 
active.maybeCloneWithAllocator(cell);<a name="line.411"></a>
+<span class="sourceLineNo">412</span>  }<a name="line.412"></a>
+<span class="sourceLineNo">413</span><a name="line.413"></a>
+<span class="sourceLineNo">414</span>  /**<a name="line.414"></a>
+<span class="sourceLineNo">415</span>   * Internal version of add() that 
doesn't clone Cells with the<a name="line.415"></a>
+<span class="sourceLineNo">416</span>   * allocator, and doesn't take the 
lock.<a name="line.416"></a>
+<span class="sourceLineNo">417</span>   *<a name="line.417"></a>
+<span class="sourceLineNo">418</span>   * Callers should ensure they already 
have the read lock taken<a name="line.418"></a>
+<span class="sourceLineNo">419</span>   * @param toAdd the cell to add<a 
name="line.419"></a>
+<span class="sourceLineNo">420</span>   * @param mslabUsed whether using 
MSLAB<a name="line.420"></a>
+<span class="sourceLineNo">421</span>   * @return the heap size change in 
bytes<a name="line.421"></a>
+<span class="sourceLineNo">422</span>   */<a name="line.422"></a>
+<span class="sourceLineNo">423</span>  private long internalAdd(final Cell 
toAdd, final boolean mslabUsed) {<a name="line.423"></a>
+<span class="sourceLineNo">424</span>    long s = active.add(toAdd, 
mslabUsed);<a name="line.424"></a>
+<span class="sourceLineNo">425</span>    setOldestEditTimeToNow();<a 
name="line.425"></a>
+<span class="sourceLineNo">426</span>    checkActiveSize();<a 
name="line.426"></a>
+<span class="sourceLineNo">427</span>    return s;<a name="line.427"></a>
+<span class="sourceLineNo">428</span>  }<a name="line.428"></a>
+<span class="sourceLineNo">429</span><a name="line.429"></a>
+<span class="sourceLineNo">430</span>  private void setOldestEditTimeToNow() 
{<a name="line.430"></a>
+<span class="sourceLineNo">431</span>    if (timeOfOldestEdit == 
Long.MAX_VALUE) {<a name="line.431"></a>
+<span class="sourceLineNo">432</span>      timeOfOldestEdit = 
EnvironmentEdgeManager.currentTime();<a name="line.432"></a>
+<span class="sourceLineNo">433</span>    }<a name="line.433"></a>
+<span class="sourceLineNo">434</span>  }<a name="line.434"></a>
+<span class="sourceLineNo">435</span><a name="line.435"></a>
+<span class="sourceLineNo">436</span>  protected long keySize() {<a 
name="line.436"></a>
+<span class="sourceLineNo">437</span>    return heapSize() - DEEP_OVERHEAD;<a 
name="line.437"></a>
+<span class="sourceLineNo">438</span>  }<a name="line.438"></a>
+<span class="sourceLineNo">439</span><a name="line.439"></a>
+<span class="sourceLineNo">440</span>  protected CellComparator 
getComparator() {<a name="line.440"></a>
+<span class="sourceLineNo">441</span>    return comparator;<a 
name="line.441"></a>
+<span class="sourceLineNo">442</span>  }<a name="line.442"></a>
+<span class="sourceLineNo">443</span><a name="line.443"></a>
+<span class="sourceLineNo">444</span>  protected MutableSegment getActive() 
{<a name="line.444"></a>
+<span class="sourceLineNo">445</span>    return active;<a name="line.445"></a>
+<span class="sourceLineNo">446</span>  }<a name="line.446"></a>
+<span class="sourceLineNo">447</span><a name="line.447"></a>
+<span class="sourceLineNo">448</span>  protected ImmutableSegment 
getSnapshot() {<a name="line.448"></a>
+<span class="sourceLineNo">449</span>    return snapshot;<a 
name="line.449"></a>
+<span class="sourceLineNo">450</span>  }<a name="line.450"></a>
+<span class="sourceLineNo">451</span><a name="line.451"></a>
+<span class="sourceLineNo">452</span>  protected AbstractMemStore 
setSnapshot(ImmutableSegment snapshot) {<a name="line.452"></a>
+<span class="sourceLineNo">453</span>    this.snapshot = snapshot;<a 
name="line.453"></a>
+<span class="sourceLineNo">454</span>    return this;<a name="line.454"></a>
+<span class="sourceLineNo">455</span>  }<a name="line.455"></a>
+<span class="sourceLineNo">456</span><a name="line.456"></a>
+<span class="sourceLineNo">457</span>  protected void setSnapshotSize(long 
snapshotSize) {<a name="line.457"></a>
+<span class="sourceLineNo">458</span>    
getSnapshot().setSize(snapshotSize);<a name="line.458"></a>
+<span class="sourceLineNo">459</span>  }<a name="line.459"></a>
+<span class="sourceLineNo">460</span><a name="line.460"></a>
+<span class="sourceLineNo">461</span>  /**<a name="line.461"></a>
+<span class="sourceLineNo">462</span>   * Check whether anything need to be 
done based on the current active set size<a name="line.462"></a>
+<span class="sourceLineNo">463</span>   */<a name="line.463"></a>
+<span class="sourceLineNo">464</span>  protected abstract void 
checkActiveSize();<a name="line.464"></a>
+<span class="sourceLineNo">465</span><a name="line.465"></a>
+<span class="sourceLineNo">466</span>  /**<a name="line.466"></a>
+<span class="sourceLineNo">467</span>   * Returns an ordered list of segments 
from most recent to oldest in memstore<a name="line.467"></a>
+<span class="sourceLineNo">468</span>   * @return an ordered list of segments 
from most recent to oldest in memstore<a name="line.468"></a>
+<span class="sourceLineNo">469</span>   */<a name="line.469"></a>
+<span class="sourceLineNo">470</span>  protected abstract List&lt;Segment&gt; 
getSegments() throws IOException;<a name="line.470"></a>
+<span class="sourceLineNo">471</span><a name="line.471"></a>
+<span class="sourceLineNo">472</span>}<a name="line.472"></a>
 
 
 

Reply via email to