Repository: hbase Updated Branches: refs/heads/branch-1 abf03da41 -> 8c313d5be
HBASE-18094 Display the return value of the command append Signed-off-by: tedyu <yuzhih...@gmail.com> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/8c313d5b Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/8c313d5b Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/8c313d5b Branch: refs/heads/branch-1 Commit: 8c313d5be46a02c212d38a1ee782cbff570f007f Parents: abf03da Author: Guangxu Cheng <guangxuch...@gmail.com> Authored: Tue May 23 19:34:58 2017 +0800 Committer: tedyu <yuzhih...@gmail.com> Committed: Tue May 23 08:59:54 2017 -0700 ---------------------------------------------------------------------- hbase-shell/src/main/ruby/hbase/table.rb | 7 ++++++- hbase-shell/src/main/ruby/shell/commands/append.rb | 6 ++++-- hbase-shell/src/test/ruby/hbase/table_test.rb | 1 + 3 files changed, 11 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/8c313d5b/hbase-shell/src/main/ruby/hbase/table.rb ---------------------------------------------------------------------- diff --git a/hbase-shell/src/main/ruby/hbase/table.rb b/hbase-shell/src/main/ruby/hbase/table.rb index 057adca..36c6509 100644 --- a/hbase-shell/src/main/ruby/hbase/table.rb +++ b/hbase-shell/src/main/ruby/hbase/table.rb @@ -244,7 +244,12 @@ EOF set_op_ttl(append, ttl) if ttl end append.add(family, qualifier, value.to_s.to_java_bytes) - @table.append(append) + result = @table.append(append) + return nil if result.isEmpty + + # Fetch cell value + cell = result.listCells[0] + org.apache.hadoop.hbase.util.Bytes::toStringBinary(cell.getValue) end #---------------------------------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/8c313d5b/hbase-shell/src/main/ruby/shell/commands/append.rb ---------------------------------------------------------------------- diff --git a/hbase-shell/src/main/ruby/shell/commands/append.rb b/hbase-shell/src/main/ruby/shell/commands/append.rb index a0ef36d..adf1184 100644 --- a/hbase-shell/src/main/ruby/shell/commands/append.rb +++ b/hbase-shell/src/main/ruby/shell/commands/append.rb @@ -40,8 +40,10 @@ EOF end def append(table, row, column, value, args={}) - format_simple_command do - table._append_internal(row, column, value, args) + format_simple_command do + if current_value = table._append_internal(row, column, value, args) + puts "CURRENT VALUE = #{current_value}" + end end end end http://git-wip-us.apache.org/repos/asf/hbase/blob/8c313d5b/hbase-shell/src/test/ruby/hbase/table_test.rb ---------------------------------------------------------------------- diff --git a/hbase-shell/src/test/ruby/hbase/table_test.rb b/hbase-shell/src/test/ruby/hbase/table_test.rb index 0fb5a14..b6801da 100644 --- a/hbase-shell/src/test/ruby/hbase/table_test.rb +++ b/hbase-shell/src/test/ruby/hbase/table_test.rb @@ -183,6 +183,7 @@ module Hbase define_test "append should work with value" do @test_table.append("123", 'x:cnt2', '123') + assert_equal("123123", @test_table._append_internal("123", 'x:cnt2', '123')) end #-------------------------------------------------------------------------------
