http://git-wip-us.apache.org/repos/asf/hbase-site/blob/be6f38d2/testdevapidocs/src-html/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.TestTableSnapshotReducer.html
----------------------------------------------------------------------
diff --git
a/testdevapidocs/src-html/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.TestTableSnapshotReducer.html
b/testdevapidocs/src-html/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.TestTableSnapshotReducer.html
index 98eb846..d267e30 100644
---
a/testdevapidocs/src-html/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.TestTableSnapshotReducer.html
+++
b/testdevapidocs/src-html/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.TestTableSnapshotReducer.html
@@ -38,281 +38,352 @@
<span class="sourceLineNo">030</span>import
org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.30"></a>
<span class="sourceLineNo">031</span>import
org.apache.hadoop.hbase.HConstants;<a name="line.31"></a>
<span class="sourceLineNo">032</span>import
org.apache.hadoop.hbase.HDFSBlocksDistribution;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import
org.apache.hadoop.hbase.TableName;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import
org.apache.hadoop.hbase.client.Result;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import
org.apache.hadoop.hbase.client.Scan;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import
org.apache.hadoop.hbase.io.ImmutableBytesWritable;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import
org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormat.TableSnapshotRegionSplit;<a
name="line.37"></a>
-<span class="sourceLineNo">038</span>import
org.apache.hadoop.hbase.testclassification.LargeTests;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import
org.apache.hadoop.hbase.testclassification.VerySlowMapReduceTests;<a
name="line.39"></a>
-<span class="sourceLineNo">040</span>import
org.apache.hadoop.hbase.util.Bytes;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import
org.apache.hadoop.io.NullWritable;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import
org.apache.hadoop.mapreduce.InputSplit;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import org.apache.hadoop.mapreduce.Job;<a
name="line.43"></a>
-<span class="sourceLineNo">044</span>import
org.apache.hadoop.mapreduce.RecordReader;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import
org.apache.hadoop.mapreduce.Reducer;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import
org.apache.hadoop.mapreduce.TaskAttemptContext;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import
org.apache.hadoop.mapreduce.lib.output.NullOutputFormat;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.junit.After;<a
name="line.48"></a>
-<span class="sourceLineNo">049</span>import org.junit.Assert;<a
name="line.49"></a>
-<span class="sourceLineNo">050</span>import org.junit.Rule;<a
name="line.50"></a>
-<span class="sourceLineNo">051</span>import org.junit.Test;<a
name="line.51"></a>
-<span class="sourceLineNo">052</span>import
org.junit.experimental.categories.Category;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>import org.junit.rules.TestName;<a
name="line.53"></a>
-<span class="sourceLineNo">054</span>import org.junit.rules.TestRule;<a
name="line.54"></a>
-<span class="sourceLineNo">055</span><a name="line.55"></a>
-<span class="sourceLineNo">056</span>import com.google.common.collect.Lists;<a
name="line.56"></a>
-<span class="sourceLineNo">057</span><a name="line.57"></a>
-<span class="sourceLineNo">058</span>@Category({VerySlowMapReduceTests.class,
LargeTests.class})<a name="line.58"></a>
-<span class="sourceLineNo">059</span>public class TestTableSnapshotInputFormat
extends TableSnapshotInputFormatTestBase {<a name="line.59"></a>
-<span class="sourceLineNo">060</span> @Rule public final TestRule timeout =
CategoryBasedTimeout.builder().<a name="line.60"></a>
-<span class="sourceLineNo">061</span>
withTimeout(this.getClass()).withLookingForStuckThread(true).build();<a
name="line.61"></a>
-<span class="sourceLineNo">062</span><a name="line.62"></a>
-<span class="sourceLineNo">063</span> private static final byte[] bbb =
Bytes.toBytes("bbb");<a name="line.63"></a>
-<span class="sourceLineNo">064</span> private static final byte[] yyy =
Bytes.toBytes("yyy");<a name="line.64"></a>
+<span class="sourceLineNo">033</span>import
org.apache.hadoop.hbase.HRegionInfo;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import
org.apache.hadoop.hbase.TableName;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import
org.apache.hadoop.hbase.client.Result;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import
org.apache.hadoop.hbase.client.Scan;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import
org.apache.hadoop.hbase.io.ImmutableBytesWritable;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import
org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormat.TableSnapshotRegionSplit;<a
name="line.38"></a>
+<span class="sourceLineNo">039</span>import
org.apache.hadoop.hbase.testclassification.LargeTests;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import
org.apache.hadoop.hbase.testclassification.VerySlowMapReduceTests;<a
name="line.40"></a>
+<span class="sourceLineNo">041</span>import
org.apache.hadoop.hbase.util.Bytes;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import
org.apache.hadoop.io.NullWritable;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import
org.apache.hadoop.mapreduce.InputSplit;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.mapreduce.Job;<a
name="line.44"></a>
+<span class="sourceLineNo">045</span>import
org.apache.hadoop.mapreduce.RecordReader;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import
org.apache.hadoop.mapreduce.Reducer;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import
org.apache.hadoop.mapreduce.TaskAttemptContext;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import
org.apache.hadoop.mapreduce.lib.output.NullOutputFormat;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.junit.After;<a
name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.junit.Assert;<a
name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.junit.Rule;<a
name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.junit.Test;<a
name="line.52"></a>
+<span class="sourceLineNo">053</span>import
org.junit.experimental.categories.Category;<a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.junit.rules.TestName;<a
name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.junit.rules.TestRule;<a
name="line.55"></a>
+<span class="sourceLineNo">056</span><a name="line.56"></a>
+<span class="sourceLineNo">057</span>import com.google.common.collect.Lists;<a
name="line.57"></a>
+<span class="sourceLineNo">058</span><a name="line.58"></a>
+<span class="sourceLineNo">059</span>import java.util.Arrays;<a
name="line.59"></a>
+<span class="sourceLineNo">060</span>import org.apache.hadoop.fs.FileSystem;<a
name="line.60"></a>
+<span class="sourceLineNo">061</span>import
org.apache.hadoop.hbase.client.Admin;<a name="line.61"></a>
+<span class="sourceLineNo">062</span>import
org.apache.hadoop.hbase.client.Table;<a name="line.62"></a>
+<span class="sourceLineNo">063</span>import
org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils;<a name="line.63"></a>
+<span class="sourceLineNo">064</span>import
org.apache.hadoop.hbase.util.FSUtils;<a name="line.64"></a>
<span class="sourceLineNo">065</span><a name="line.65"></a>
-<span class="sourceLineNo">066</span> @Rule<a name="line.66"></a>
-<span class="sourceLineNo">067</span> public TestName name = new
TestName();<a name="line.67"></a>
-<span class="sourceLineNo">068</span><a name="line.68"></a>
-<span class="sourceLineNo">069</span> @Override<a name="line.69"></a>
-<span class="sourceLineNo">070</span> protected byte[] getStartRow() {<a
name="line.70"></a>
-<span class="sourceLineNo">071</span> return bbb;<a name="line.71"></a>
-<span class="sourceLineNo">072</span> }<a name="line.72"></a>
+<span class="sourceLineNo">066</span>@Category({VerySlowMapReduceTests.class,
LargeTests.class})<a name="line.66"></a>
+<span class="sourceLineNo">067</span>public class TestTableSnapshotInputFormat
extends TableSnapshotInputFormatTestBase {<a name="line.67"></a>
+<span class="sourceLineNo">068</span> @Rule public final TestRule timeout =
CategoryBasedTimeout.builder().<a name="line.68"></a>
+<span class="sourceLineNo">069</span>
withTimeout(this.getClass()).withLookingForStuckThread(true).build();<a
name="line.69"></a>
+<span class="sourceLineNo">070</span><a name="line.70"></a>
+<span class="sourceLineNo">071</span> private static final byte[] bbb =
Bytes.toBytes("bbb");<a name="line.71"></a>
+<span class="sourceLineNo">072</span> private static final byte[] yyy =
Bytes.toBytes("yyy");<a name="line.72"></a>
<span class="sourceLineNo">073</span><a name="line.73"></a>
-<span class="sourceLineNo">074</span> @Override<a name="line.74"></a>
-<span class="sourceLineNo">075</span> protected byte[] getEndRow() {<a
name="line.75"></a>
-<span class="sourceLineNo">076</span> return yyy;<a name="line.76"></a>
-<span class="sourceLineNo">077</span> }<a name="line.77"></a>
-<span class="sourceLineNo">078</span><a name="line.78"></a>
-<span class="sourceLineNo">079</span> @After<a name="line.79"></a>
-<span class="sourceLineNo">080</span> public void tearDown() throws Exception
{<a name="line.80"></a>
-<span class="sourceLineNo">081</span> }<a name="line.81"></a>
-<span class="sourceLineNo">082</span><a name="line.82"></a>
-<span class="sourceLineNo">083</span> @Test<a name="line.83"></a>
-<span class="sourceLineNo">084</span> public void testGetBestLocations()
throws IOException {<a name="line.84"></a>
-<span class="sourceLineNo">085</span> TableSnapshotInputFormatImpl tsif =
new TableSnapshotInputFormatImpl();<a name="line.85"></a>
-<span class="sourceLineNo">086</span> Configuration conf =
UTIL.getConfiguration();<a name="line.86"></a>
-<span class="sourceLineNo">087</span><a name="line.87"></a>
-<span class="sourceLineNo">088</span> HDFSBlocksDistribution
blockDistribution = new HDFSBlocksDistribution();<a name="line.88"></a>
-<span class="sourceLineNo">089</span>
Assert.assertEquals(Lists.newArrayList(),<a name="line.89"></a>
-<span class="sourceLineNo">090</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.90"></a>
-<span class="sourceLineNo">091</span><a name="line.91"></a>
-<span class="sourceLineNo">092</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h1"}, 1);<a
name="line.92"></a>
-<span class="sourceLineNo">093</span>
Assert.assertEquals(Lists.newArrayList("h1"),<a name="line.93"></a>
-<span class="sourceLineNo">094</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.94"></a>
+<span class="sourceLineNo">074</span> @Rule<a name="line.74"></a>
+<span class="sourceLineNo">075</span> public TestName name = new
TestName();<a name="line.75"></a>
+<span class="sourceLineNo">076</span><a name="line.76"></a>
+<span class="sourceLineNo">077</span> @Override<a name="line.77"></a>
+<span class="sourceLineNo">078</span> protected byte[] getStartRow() {<a
name="line.78"></a>
+<span class="sourceLineNo">079</span> return bbb;<a name="line.79"></a>
+<span class="sourceLineNo">080</span> }<a name="line.80"></a>
+<span class="sourceLineNo">081</span><a name="line.81"></a>
+<span class="sourceLineNo">082</span> @Override<a name="line.82"></a>
+<span class="sourceLineNo">083</span> protected byte[] getEndRow() {<a
name="line.83"></a>
+<span class="sourceLineNo">084</span> return yyy;<a name="line.84"></a>
+<span class="sourceLineNo">085</span> }<a name="line.85"></a>
+<span class="sourceLineNo">086</span><a name="line.86"></a>
+<span class="sourceLineNo">087</span> @After<a name="line.87"></a>
+<span class="sourceLineNo">088</span> public void tearDown() throws Exception
{<a name="line.88"></a>
+<span class="sourceLineNo">089</span> }<a name="line.89"></a>
+<span class="sourceLineNo">090</span><a name="line.90"></a>
+<span class="sourceLineNo">091</span> @Test<a name="line.91"></a>
+<span class="sourceLineNo">092</span> public void testGetBestLocations()
throws IOException {<a name="line.92"></a>
+<span class="sourceLineNo">093</span> TableSnapshotInputFormatImpl tsif =
new TableSnapshotInputFormatImpl();<a name="line.93"></a>
+<span class="sourceLineNo">094</span> Configuration conf =
UTIL.getConfiguration();<a name="line.94"></a>
<span class="sourceLineNo">095</span><a name="line.95"></a>
-<span class="sourceLineNo">096</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h1"}, 1);<a
name="line.96"></a>
-<span class="sourceLineNo">097</span>
Assert.assertEquals(Lists.newArrayList("h1"),<a name="line.97"></a>
+<span class="sourceLineNo">096</span> HDFSBlocksDistribution
blockDistribution = new HDFSBlocksDistribution();<a name="line.96"></a>
+<span class="sourceLineNo">097</span>
Assert.assertEquals(Lists.newArrayList(),<a name="line.97"></a>
<span class="sourceLineNo">098</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.98"></a>
<span class="sourceLineNo">099</span><a name="line.99"></a>
-<span class="sourceLineNo">100</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h2"}, 1);<a
name="line.100"></a>
+<span class="sourceLineNo">100</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h1"}, 1);<a
name="line.100"></a>
<span class="sourceLineNo">101</span>
Assert.assertEquals(Lists.newArrayList("h1"),<a name="line.101"></a>
<span class="sourceLineNo">102</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.102"></a>
<span class="sourceLineNo">103</span><a name="line.103"></a>
-<span class="sourceLineNo">104</span> blockDistribution = new
HDFSBlocksDistribution();<a name="line.104"></a>
-<span class="sourceLineNo">105</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h1"}, 10);<a
name="line.105"></a>
-<span class="sourceLineNo">106</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h2"}, 7);<a
name="line.106"></a>
-<span class="sourceLineNo">107</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h3"}, 5);<a
name="line.107"></a>
-<span class="sourceLineNo">108</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h4"}, 1);<a
name="line.108"></a>
+<span class="sourceLineNo">104</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h1"}, 1);<a
name="line.104"></a>
+<span class="sourceLineNo">105</span>
Assert.assertEquals(Lists.newArrayList("h1"),<a name="line.105"></a>
+<span class="sourceLineNo">106</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.106"></a>
+<span class="sourceLineNo">107</span><a name="line.107"></a>
+<span class="sourceLineNo">108</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h2"}, 1);<a
name="line.108"></a>
<span class="sourceLineNo">109</span>
Assert.assertEquals(Lists.newArrayList("h1"),<a name="line.109"></a>
<span class="sourceLineNo">110</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.110"></a>
<span class="sourceLineNo">111</span><a name="line.111"></a>
-<span class="sourceLineNo">112</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h2"}, 2);<a
name="line.112"></a>
-<span class="sourceLineNo">113</span>
Assert.assertEquals(Lists.newArrayList("h1", "h2"),<a name="line.113"></a>
-<span class="sourceLineNo">114</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.114"></a>
-<span class="sourceLineNo">115</span><a name="line.115"></a>
-<span class="sourceLineNo">116</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h2"}, 3);<a
name="line.116"></a>
-<span class="sourceLineNo">117</span>
Assert.assertEquals(Lists.newArrayList("h2", "h1"),<a name="line.117"></a>
+<span class="sourceLineNo">112</span> blockDistribution = new
HDFSBlocksDistribution();<a name="line.112"></a>
+<span class="sourceLineNo">113</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h1"}, 10);<a
name="line.113"></a>
+<span class="sourceLineNo">114</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h2"}, 7);<a
name="line.114"></a>
+<span class="sourceLineNo">115</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h3"}, 5);<a
name="line.115"></a>
+<span class="sourceLineNo">116</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h4"}, 1);<a
name="line.116"></a>
+<span class="sourceLineNo">117</span>
Assert.assertEquals(Lists.newArrayList("h1"),<a name="line.117"></a>
<span class="sourceLineNo">118</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.118"></a>
<span class="sourceLineNo">119</span><a name="line.119"></a>
-<span class="sourceLineNo">120</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h3"}, 6);<a
name="line.120"></a>
-<span class="sourceLineNo">121</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h4"}, 9);<a
name="line.121"></a>
-<span class="sourceLineNo">122</span><a name="line.122"></a>
-<span class="sourceLineNo">123</span>
Assert.assertEquals(Lists.newArrayList("h2", "h3", "h4", "h1"),<a
name="line.123"></a>
-<span class="sourceLineNo">124</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.124"></a>
-<span class="sourceLineNo">125</span> }<a name="line.125"></a>
-<span class="sourceLineNo">126</span><a name="line.126"></a>
-<span class="sourceLineNo">127</span> public static enum
TestTableSnapshotCounters {<a name="line.127"></a>
-<span class="sourceLineNo">128</span> VALIDATION_ERROR<a
name="line.128"></a>
-<span class="sourceLineNo">129</span> }<a name="line.129"></a>
+<span class="sourceLineNo">120</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h2"}, 2);<a
name="line.120"></a>
+<span class="sourceLineNo">121</span>
Assert.assertEquals(Lists.newArrayList("h1", "h2"),<a name="line.121"></a>
+<span class="sourceLineNo">122</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.122"></a>
+<span class="sourceLineNo">123</span><a name="line.123"></a>
+<span class="sourceLineNo">124</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h2"}, 3);<a
name="line.124"></a>
+<span class="sourceLineNo">125</span>
Assert.assertEquals(Lists.newArrayList("h2", "h1"),<a name="line.125"></a>
+<span class="sourceLineNo">126</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.126"></a>
+<span class="sourceLineNo">127</span><a name="line.127"></a>
+<span class="sourceLineNo">128</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h3"}, 6);<a
name="line.128"></a>
+<span class="sourceLineNo">129</span>
blockDistribution.addHostsAndBlockWeight(new String[] {"h4"}, 9);<a
name="line.129"></a>
<span class="sourceLineNo">130</span><a name="line.130"></a>
-<span class="sourceLineNo">131</span> public static class
TestTableSnapshotMapper<a name="line.131"></a>
-<span class="sourceLineNo">132</span> extends
TableMapper<ImmutableBytesWritable, NullWritable> {<a name="line.132"></a>
-<span class="sourceLineNo">133</span> @Override<a name="line.133"></a>
-<span class="sourceLineNo">134</span> protected void
map(ImmutableBytesWritable key, Result value,<a name="line.134"></a>
-<span class="sourceLineNo">135</span> Context context) throws
IOException, InterruptedException {<a name="line.135"></a>
-<span class="sourceLineNo">136</span> // Validate a single row coming
from the snapshot, and emit the row key<a name="line.136"></a>
-<span class="sourceLineNo">137</span> verifyRowFromMap(key, value);<a
name="line.137"></a>
-<span class="sourceLineNo">138</span> context.write(key,
NullWritable.get());<a name="line.138"></a>
-<span class="sourceLineNo">139</span> }<a name="line.139"></a>
-<span class="sourceLineNo">140</span> }<a name="line.140"></a>
-<span class="sourceLineNo">141</span><a name="line.141"></a>
-<span class="sourceLineNo">142</span> public static class
TestTableSnapshotReducer<a name="line.142"></a>
-<span class="sourceLineNo">143</span> extends
Reducer<ImmutableBytesWritable, NullWritable, NullWritable, NullWritable>
{<a name="line.143"></a>
-<span class="sourceLineNo">144</span> HBaseTestingUtility.SeenRowTracker
rowTracker =<a name="line.144"></a>
-<span class="sourceLineNo">145</span> new
HBaseTestingUtility.SeenRowTracker(bbb, yyy);<a name="line.145"></a>
-<span class="sourceLineNo">146</span> @Override<a name="line.146"></a>
-<span class="sourceLineNo">147</span> protected void
reduce(ImmutableBytesWritable key, Iterable<NullWritable> values,<a
name="line.147"></a>
-<span class="sourceLineNo">148</span> Context context) throws
IOException, InterruptedException {<a name="line.148"></a>
-<span class="sourceLineNo">149</span> rowTracker.addRow(key.get());<a
name="line.149"></a>
-<span class="sourceLineNo">150</span> }<a name="line.150"></a>
-<span class="sourceLineNo">151</span><a name="line.151"></a>
-<span class="sourceLineNo">152</span> @Override<a name="line.152"></a>
-<span class="sourceLineNo">153</span> protected void cleanup(Context
context) throws IOException,<a name="line.153"></a>
-<span class="sourceLineNo">154</span> InterruptedException {<a
name="line.154"></a>
-<span class="sourceLineNo">155</span> rowTracker.validate();<a
name="line.155"></a>
-<span class="sourceLineNo">156</span> }<a name="line.156"></a>
-<span class="sourceLineNo">157</span> }<a name="line.157"></a>
-<span class="sourceLineNo">158</span><a name="line.158"></a>
-<span class="sourceLineNo">159</span> @Test<a name="line.159"></a>
-<span class="sourceLineNo">160</span> public void
testInitTableSnapshotMapperJobConfig() throws Exception {<a name="line.160"></a>
-<span class="sourceLineNo">161</span> setupCluster();<a name="line.161"></a>
-<span class="sourceLineNo">162</span> final TableName tableName =
TableName.valueOf(name.getMethodName());<a name="line.162"></a>
-<span class="sourceLineNo">163</span> String snapshotName = "foo";<a
name="line.163"></a>
-<span class="sourceLineNo">164</span><a name="line.164"></a>
-<span class="sourceLineNo">165</span> try {<a name="line.165"></a>
-<span class="sourceLineNo">166</span> createTableAndSnapshot(UTIL,
tableName, snapshotName, getStartRow(), getEndRow(), 1);<a name="line.166"></a>
-<span class="sourceLineNo">167</span> Job job = new
Job(UTIL.getConfiguration());<a name="line.167"></a>
-<span class="sourceLineNo">168</span> Path tmpTableDir =
UTIL.getDataTestDirOnTestFS(snapshotName);<a name="line.168"></a>
-<span class="sourceLineNo">169</span><a name="line.169"></a>
-<span class="sourceLineNo">170</span>
TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName,<a
name="line.170"></a>
-<span class="sourceLineNo">171</span> new Scan(),
TestTableSnapshotMapper.class, ImmutableBytesWritable.class,<a
name="line.171"></a>
-<span class="sourceLineNo">172</span> NullWritable.class, job, false,
tmpTableDir);<a name="line.172"></a>
-<span class="sourceLineNo">173</span><a name="line.173"></a>
-<span class="sourceLineNo">174</span> // TODO: would be better to examine
directly the cache instance that results from this<a name="line.174"></a>
-<span class="sourceLineNo">175</span> // config. Currently this is not
possible because BlockCache initialization is static.<a name="line.175"></a>
-<span class="sourceLineNo">176</span> Assert.assertEquals(<a
name="line.176"></a>
-<span class="sourceLineNo">177</span> "Snapshot job should be
configured for default LruBlockCache.",<a name="line.177"></a>
-<span class="sourceLineNo">178</span>
HConstants.HFILE_BLOCK_CACHE_SIZE_DEFAULT,<a name="line.178"></a>
-<span class="sourceLineNo">179</span>
job.getConfiguration().getFloat(HConstants.HFILE_BLOCK_CACHE_SIZE_KEY, -1),
0.01);<a name="line.179"></a>
-<span class="sourceLineNo">180</span> Assert.assertEquals(<a
name="line.180"></a>
-<span class="sourceLineNo">181</span> "Snapshot job should not use
BucketCache.",<a name="line.181"></a>
-<span class="sourceLineNo">182</span> 0,
job.getConfiguration().getFloat("hbase.bucketcache.size", -1), 0.01);<a
name="line.182"></a>
-<span class="sourceLineNo">183</span> } finally {<a name="line.183"></a>
-<span class="sourceLineNo">184</span>
UTIL.getAdmin().deleteSnapshot(snapshotName);<a name="line.184"></a>
-<span class="sourceLineNo">185</span> UTIL.deleteTable(tableName);<a
name="line.185"></a>
-<span class="sourceLineNo">186</span> tearDownCluster();<a
name="line.186"></a>
-<span class="sourceLineNo">187</span> }<a name="line.187"></a>
-<span class="sourceLineNo">188</span> }<a name="line.188"></a>
-<span class="sourceLineNo">189</span><a name="line.189"></a>
-<span class="sourceLineNo">190</span> @Override<a name="line.190"></a>
-<span class="sourceLineNo">191</span> public void
testRestoreSnapshotDoesNotCreateBackRefLinksInit(TableName tableName,<a
name="line.191"></a>
-<span class="sourceLineNo">192</span> String snapshotName, Path
tmpTableDir) throws Exception {<a name="line.192"></a>
-<span class="sourceLineNo">193</span> Job job = new
Job(UTIL.getConfiguration());<a name="line.193"></a>
-<span class="sourceLineNo">194</span>
TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName,<a
name="line.194"></a>
-<span class="sourceLineNo">195</span> new Scan(),
TestTableSnapshotMapper.class, ImmutableBytesWritable.class,<a
name="line.195"></a>
-<span class="sourceLineNo">196</span> NullWritable.class, job, false,
tmpTableDir);<a name="line.196"></a>
-<span class="sourceLineNo">197</span> }<a name="line.197"></a>
-<span class="sourceLineNo">198</span><a name="line.198"></a>
-<span class="sourceLineNo">199</span> @Override<a name="line.199"></a>
-<span class="sourceLineNo">200</span> public void
testWithMockedMapReduce(HBaseTestingUtility util, String snapshotName,<a
name="line.200"></a>
-<span class="sourceLineNo">201</span> int numRegions, int
expectedNumSplits) throws Exception {<a name="line.201"></a>
-<span class="sourceLineNo">202</span> setupCluster();<a name="line.202"></a>
-<span class="sourceLineNo">203</span> final TableName tableName =
TableName.valueOf(name.getMethodName());<a name="line.203"></a>
-<span class="sourceLineNo">204</span> try {<a name="line.204"></a>
-<span class="sourceLineNo">205</span> createTableAndSnapshot(<a
name="line.205"></a>
-<span class="sourceLineNo">206</span> util, tableName, snapshotName,
getStartRow(), getEndRow(), numRegions);<a name="line.206"></a>
-<span class="sourceLineNo">207</span><a name="line.207"></a>
-<span class="sourceLineNo">208</span> Job job = new
Job(util.getConfiguration());<a name="line.208"></a>
-<span class="sourceLineNo">209</span> Path tmpTableDir =
util.getDataTestDirOnTestFS(snapshotName);<a name="line.209"></a>
-<span class="sourceLineNo">210</span> Scan scan = new Scan(getStartRow(),
getEndRow()); // limit the scan<a name="line.210"></a>
-<span class="sourceLineNo">211</span><a name="line.211"></a>
-<span class="sourceLineNo">212</span>
TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName,<a
name="line.212"></a>
-<span class="sourceLineNo">213</span> scan,
TestTableSnapshotMapper.class, ImmutableBytesWritable.class,<a
name="line.213"></a>
-<span class="sourceLineNo">214</span> NullWritable.class, job, false,
tmpTableDir);<a name="line.214"></a>
+<span class="sourceLineNo">131</span>
Assert.assertEquals(Lists.newArrayList("h2", "h3", "h4", "h1"),<a
name="line.131"></a>
+<span class="sourceLineNo">132</span>
TableSnapshotInputFormatImpl.getBestLocations(conf, blockDistribution));<a
name="line.132"></a>
+<span class="sourceLineNo">133</span> }<a name="line.133"></a>
+<span class="sourceLineNo">134</span><a name="line.134"></a>
+<span class="sourceLineNo">135</span> public static enum
TestTableSnapshotCounters {<a name="line.135"></a>
+<span class="sourceLineNo">136</span> VALIDATION_ERROR<a
name="line.136"></a>
+<span class="sourceLineNo">137</span> }<a name="line.137"></a>
+<span class="sourceLineNo">138</span><a name="line.138"></a>
+<span class="sourceLineNo">139</span> public static class
TestTableSnapshotMapper<a name="line.139"></a>
+<span class="sourceLineNo">140</span> extends
TableMapper<ImmutableBytesWritable, NullWritable> {<a name="line.140"></a>
+<span class="sourceLineNo">141</span> @Override<a name="line.141"></a>
+<span class="sourceLineNo">142</span> protected void
map(ImmutableBytesWritable key, Result value,<a name="line.142"></a>
+<span class="sourceLineNo">143</span> Context context) throws
IOException, InterruptedException {<a name="line.143"></a>
+<span class="sourceLineNo">144</span> // Validate a single row coming
from the snapshot, and emit the row key<a name="line.144"></a>
+<span class="sourceLineNo">145</span> verifyRowFromMap(key, value);<a
name="line.145"></a>
+<span class="sourceLineNo">146</span> context.write(key,
NullWritable.get());<a name="line.146"></a>
+<span class="sourceLineNo">147</span> }<a name="line.147"></a>
+<span class="sourceLineNo">148</span> }<a name="line.148"></a>
+<span class="sourceLineNo">149</span><a name="line.149"></a>
+<span class="sourceLineNo">150</span> public static class
TestTableSnapshotReducer<a name="line.150"></a>
+<span class="sourceLineNo">151</span> extends
Reducer<ImmutableBytesWritable, NullWritable, NullWritable, NullWritable>
{<a name="line.151"></a>
+<span class="sourceLineNo">152</span> HBaseTestingUtility.SeenRowTracker
rowTracker =<a name="line.152"></a>
+<span class="sourceLineNo">153</span> new
HBaseTestingUtility.SeenRowTracker(bbb, yyy);<a name="line.153"></a>
+<span class="sourceLineNo">154</span> @Override<a name="line.154"></a>
+<span class="sourceLineNo">155</span> protected void
reduce(ImmutableBytesWritable key, Iterable<NullWritable> values,<a
name="line.155"></a>
+<span class="sourceLineNo">156</span> Context context) throws
IOException, InterruptedException {<a name="line.156"></a>
+<span class="sourceLineNo">157</span> rowTracker.addRow(key.get());<a
name="line.157"></a>
+<span class="sourceLineNo">158</span> }<a name="line.158"></a>
+<span class="sourceLineNo">159</span><a name="line.159"></a>
+<span class="sourceLineNo">160</span> @Override<a name="line.160"></a>
+<span class="sourceLineNo">161</span> protected void cleanup(Context
context) throws IOException,<a name="line.161"></a>
+<span class="sourceLineNo">162</span> InterruptedException {<a
name="line.162"></a>
+<span class="sourceLineNo">163</span> rowTracker.validate();<a
name="line.163"></a>
+<span class="sourceLineNo">164</span> }<a name="line.164"></a>
+<span class="sourceLineNo">165</span> }<a name="line.165"></a>
+<span class="sourceLineNo">166</span><a name="line.166"></a>
+<span class="sourceLineNo">167</span> @Test<a name="line.167"></a>
+<span class="sourceLineNo">168</span> public void
testInitTableSnapshotMapperJobConfig() throws Exception {<a name="line.168"></a>
+<span class="sourceLineNo">169</span> setupCluster();<a name="line.169"></a>
+<span class="sourceLineNo">170</span> final TableName tableName =
TableName.valueOf(name.getMethodName());<a name="line.170"></a>
+<span class="sourceLineNo">171</span> String snapshotName = "foo";<a
name="line.171"></a>
+<span class="sourceLineNo">172</span><a name="line.172"></a>
+<span class="sourceLineNo">173</span> try {<a name="line.173"></a>
+<span class="sourceLineNo">174</span> createTableAndSnapshot(UTIL,
tableName, snapshotName, getStartRow(), getEndRow(), 1);<a name="line.174"></a>
+<span class="sourceLineNo">175</span> Job job = new
Job(UTIL.getConfiguration());<a name="line.175"></a>
+<span class="sourceLineNo">176</span> Path tmpTableDir =
UTIL.getDataTestDirOnTestFS(snapshotName);<a name="line.176"></a>
+<span class="sourceLineNo">177</span><a name="line.177"></a>
+<span class="sourceLineNo">178</span>
TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName,<a
name="line.178"></a>
+<span class="sourceLineNo">179</span> new Scan(),
TestTableSnapshotMapper.class, ImmutableBytesWritable.class,<a
name="line.179"></a>
+<span class="sourceLineNo">180</span> NullWritable.class, job, false,
tmpTableDir);<a name="line.180"></a>
+<span class="sourceLineNo">181</span><a name="line.181"></a>
+<span class="sourceLineNo">182</span> // TODO: would be better to examine
directly the cache instance that results from this<a name="line.182"></a>
+<span class="sourceLineNo">183</span> // config. Currently this is not
possible because BlockCache initialization is static.<a name="line.183"></a>
+<span class="sourceLineNo">184</span> Assert.assertEquals(<a
name="line.184"></a>
+<span class="sourceLineNo">185</span> "Snapshot job should be
configured for default LruBlockCache.",<a name="line.185"></a>
+<span class="sourceLineNo">186</span>
HConstants.HFILE_BLOCK_CACHE_SIZE_DEFAULT,<a name="line.186"></a>
+<span class="sourceLineNo">187</span>
job.getConfiguration().getFloat(HConstants.HFILE_BLOCK_CACHE_SIZE_KEY, -1),
0.01);<a name="line.187"></a>
+<span class="sourceLineNo">188</span> Assert.assertEquals(<a
name="line.188"></a>
+<span class="sourceLineNo">189</span> "Snapshot job should not use
BucketCache.",<a name="line.189"></a>
+<span class="sourceLineNo">190</span> 0,
job.getConfiguration().getFloat("hbase.bucketcache.size", -1), 0.01);<a
name="line.190"></a>
+<span class="sourceLineNo">191</span> } finally {<a name="line.191"></a>
+<span class="sourceLineNo">192</span>
UTIL.getAdmin().deleteSnapshot(snapshotName);<a name="line.192"></a>
+<span class="sourceLineNo">193</span> UTIL.deleteTable(tableName);<a
name="line.193"></a>
+<span class="sourceLineNo">194</span> tearDownCluster();<a
name="line.194"></a>
+<span class="sourceLineNo">195</span> }<a name="line.195"></a>
+<span class="sourceLineNo">196</span> }<a name="line.196"></a>
+<span class="sourceLineNo">197</span><a name="line.197"></a>
+<span class="sourceLineNo">198</span> @Override<a name="line.198"></a>
+<span class="sourceLineNo">199</span> public void
testRestoreSnapshotDoesNotCreateBackRefLinksInit(TableName tableName,<a
name="line.199"></a>
+<span class="sourceLineNo">200</span> String snapshotName, Path
tmpTableDir) throws Exception {<a name="line.200"></a>
+<span class="sourceLineNo">201</span> Job job = new
Job(UTIL.getConfiguration());<a name="line.201"></a>
+<span class="sourceLineNo">202</span>
TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName,<a
name="line.202"></a>
+<span class="sourceLineNo">203</span> new Scan(),
TestTableSnapshotMapper.class, ImmutableBytesWritable.class,<a
name="line.203"></a>
+<span class="sourceLineNo">204</span> NullWritable.class, job, false,
tmpTableDir);<a name="line.204"></a>
+<span class="sourceLineNo">205</span> }<a name="line.205"></a>
+<span class="sourceLineNo">206</span><a name="line.206"></a>
+<span class="sourceLineNo">207</span> @Override<a name="line.207"></a>
+<span class="sourceLineNo">208</span> public void
testWithMockedMapReduce(HBaseTestingUtility util, String snapshotName,<a
name="line.208"></a>
+<span class="sourceLineNo">209</span> int numRegions, int
expectedNumSplits) throws Exception {<a name="line.209"></a>
+<span class="sourceLineNo">210</span> setupCluster();<a name="line.210"></a>
+<span class="sourceLineNo">211</span> final TableName tableName =
TableName.valueOf(name.getMethodName());<a name="line.211"></a>
+<span class="sourceLineNo">212</span> try {<a name="line.212"></a>
+<span class="sourceLineNo">213</span> createTableAndSnapshot(<a
name="line.213"></a>
+<span class="sourceLineNo">214</span> util, tableName, snapshotName,
getStartRow(), getEndRow(), numRegions);<a name="line.214"></a>
<span class="sourceLineNo">215</span><a name="line.215"></a>
-<span class="sourceLineNo">216</span> verifyWithMockedMapReduce(job,
numRegions, expectedNumSplits, getStartRow(), getEndRow());<a
name="line.216"></a>
-<span class="sourceLineNo">217</span><a name="line.217"></a>
-<span class="sourceLineNo">218</span> } finally {<a name="line.218"></a>
-<span class="sourceLineNo">219</span>
util.getAdmin().deleteSnapshot(snapshotName);<a name="line.219"></a>
-<span class="sourceLineNo">220</span> util.deleteTable(tableName);<a
name="line.220"></a>
-<span class="sourceLineNo">221</span> tearDownCluster();<a
name="line.221"></a>
-<span class="sourceLineNo">222</span> }<a name="line.222"></a>
-<span class="sourceLineNo">223</span> }<a name="line.223"></a>
-<span class="sourceLineNo">224</span><a name="line.224"></a>
-<span class="sourceLineNo">225</span> private void
verifyWithMockedMapReduce(Job job, int numRegions, int expectedNumSplits,<a
name="line.225"></a>
-<span class="sourceLineNo">226</span> byte[] startRow, byte[] stopRow)<a
name="line.226"></a>
-<span class="sourceLineNo">227</span> throws IOException,
InterruptedException {<a name="line.227"></a>
-<span class="sourceLineNo">228</span> TableSnapshotInputFormat tsif = new
TableSnapshotInputFormat();<a name="line.228"></a>
-<span class="sourceLineNo">229</span> List<InputSplit> splits =
tsif.getSplits(job);<a name="line.229"></a>
-<span class="sourceLineNo">230</span><a name="line.230"></a>
-<span class="sourceLineNo">231</span>
Assert.assertEquals(expectedNumSplits, splits.size());<a name="line.231"></a>
+<span class="sourceLineNo">216</span> Job job = new
Job(util.getConfiguration());<a name="line.216"></a>
+<span class="sourceLineNo">217</span> Path tmpTableDir =
util.getDataTestDirOnTestFS(snapshotName);<a name="line.217"></a>
+<span class="sourceLineNo">218</span> Scan scan = new Scan(getStartRow(),
getEndRow()); // limit the scan<a name="line.218"></a>
+<span class="sourceLineNo">219</span><a name="line.219"></a>
+<span class="sourceLineNo">220</span>
TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName,<a
name="line.220"></a>
+<span class="sourceLineNo">221</span> scan,
TestTableSnapshotMapper.class, ImmutableBytesWritable.class,<a
name="line.221"></a>
+<span class="sourceLineNo">222</span> NullWritable.class, job, false,
tmpTableDir);<a name="line.222"></a>
+<span class="sourceLineNo">223</span><a name="line.223"></a>
+<span class="sourceLineNo">224</span> verifyWithMockedMapReduce(job,
numRegions, expectedNumSplits, getStartRow(), getEndRow());<a
name="line.224"></a>
+<span class="sourceLineNo">225</span><a name="line.225"></a>
+<span class="sourceLineNo">226</span> } finally {<a name="line.226"></a>
+<span class="sourceLineNo">227</span>
util.getAdmin().deleteSnapshot(snapshotName);<a name="line.227"></a>
+<span class="sourceLineNo">228</span> util.deleteTable(tableName);<a
name="line.228"></a>
+<span class="sourceLineNo">229</span> tearDownCluster();<a
name="line.229"></a>
+<span class="sourceLineNo">230</span> }<a name="line.230"></a>
+<span class="sourceLineNo">231</span> }<a name="line.231"></a>
<span class="sourceLineNo">232</span><a name="line.232"></a>
-<span class="sourceLineNo">233</span> HBaseTestingUtility.SeenRowTracker
rowTracker =<a name="line.233"></a>
-<span class="sourceLineNo">234</span> new
HBaseTestingUtility.SeenRowTracker(startRow, stopRow);<a name="line.234"></a>
-<span class="sourceLineNo">235</span><a name="line.235"></a>
-<span class="sourceLineNo">236</span> for (int i = 0; i < splits.size();
i++) {<a name="line.236"></a>
-<span class="sourceLineNo">237</span> // validate input split<a
name="line.237"></a>
-<span class="sourceLineNo">238</span> InputSplit split = splits.get(i);<a
name="line.238"></a>
-<span class="sourceLineNo">239</span> Assert.assertTrue(split instanceof
TableSnapshotRegionSplit);<a name="line.239"></a>
-<span class="sourceLineNo">240</span><a name="line.240"></a>
-<span class="sourceLineNo">241</span> // validate record reader<a
name="line.241"></a>
-<span class="sourceLineNo">242</span> TaskAttemptContext
taskAttemptContext = mock(TaskAttemptContext.class);<a name="line.242"></a>
-<span class="sourceLineNo">243</span>
when(taskAttemptContext.getConfiguration()).thenReturn(job.getConfiguration());<a
name="line.243"></a>
-<span class="sourceLineNo">244</span>
RecordReader<ImmutableBytesWritable, Result> rr =<a name="line.244"></a>
-<span class="sourceLineNo">245</span> tsif.createRecordReader(split,
taskAttemptContext);<a name="line.245"></a>
-<span class="sourceLineNo">246</span> rr.initialize(split,
taskAttemptContext);<a name="line.246"></a>
-<span class="sourceLineNo">247</span><a name="line.247"></a>
-<span class="sourceLineNo">248</span> // validate we can read all the
data back<a name="line.248"></a>
-<span class="sourceLineNo">249</span> while (rr.nextKeyValue()) {<a
name="line.249"></a>
-<span class="sourceLineNo">250</span> byte[] row =
rr.getCurrentKey().get();<a name="line.250"></a>
-<span class="sourceLineNo">251</span>
verifyRowFromMap(rr.getCurrentKey(), rr.getCurrentValue());<a
name="line.251"></a>
-<span class="sourceLineNo">252</span> rowTracker.addRow(row);<a
name="line.252"></a>
-<span class="sourceLineNo">253</span> }<a name="line.253"></a>
-<span class="sourceLineNo">254</span><a name="line.254"></a>
-<span class="sourceLineNo">255</span> rr.close();<a name="line.255"></a>
-<span class="sourceLineNo">256</span> }<a name="line.256"></a>
-<span class="sourceLineNo">257</span><a name="line.257"></a>
-<span class="sourceLineNo">258</span> // validate all rows are seen<a
name="line.258"></a>
-<span class="sourceLineNo">259</span> rowTracker.validate();<a
name="line.259"></a>
-<span class="sourceLineNo">260</span> }<a name="line.260"></a>
-<span class="sourceLineNo">261</span><a name="line.261"></a>
-<span class="sourceLineNo">262</span> @Override<a name="line.262"></a>
-<span class="sourceLineNo">263</span> protected void
testWithMapReduceImpl(HBaseTestingUtility util, TableName tableName,<a
name="line.263"></a>
-<span class="sourceLineNo">264</span> String snapshotName, Path tableDir,
int numRegions, int expectedNumSplits,<a name="line.264"></a>
-<span class="sourceLineNo">265</span> boolean shutdownCluster) throws
Exception {<a name="line.265"></a>
-<span class="sourceLineNo">266</span> doTestWithMapReduce(util, tableName,
snapshotName, getStartRow(), getEndRow(), tableDir,<a name="line.266"></a>
-<span class="sourceLineNo">267</span> numRegions, expectedNumSplits,
shutdownCluster);<a name="line.267"></a>
-<span class="sourceLineNo">268</span> }<a name="line.268"></a>
-<span class="sourceLineNo">269</span><a name="line.269"></a>
-<span class="sourceLineNo">270</span> // this is also called by the
IntegrationTestTableSnapshotInputFormat<a name="line.270"></a>
-<span class="sourceLineNo">271</span> public static void
doTestWithMapReduce(HBaseTestingUtility util, TableName tableName,<a
name="line.271"></a>
-<span class="sourceLineNo">272</span> String snapshotName, byte[]
startRow, byte[] endRow, Path tableDir, int numRegions,<a name="line.272"></a>
-<span class="sourceLineNo">273</span> int expectedNumSplits, boolean
shutdownCluster) throws Exception {<a name="line.273"></a>
+<span class="sourceLineNo">233</span> public static void
blockUntilSplitFinished(HBaseTestingUtility util, TableName tableName,<a
name="line.233"></a>
+<span class="sourceLineNo">234</span> int expectedRegionSize) throws
Exception {<a name="line.234"></a>
+<span class="sourceLineNo">235</span> for (int i = 0; i < 100; i++) {<a
name="line.235"></a>
+<span class="sourceLineNo">236</span> List<HRegionInfo>
hRegionInfoList = util.getAdmin().getTableRegions(tableName);<a
name="line.236"></a>
+<span class="sourceLineNo">237</span> if (hRegionInfoList.size() >=
expectedRegionSize) {<a name="line.237"></a>
+<span class="sourceLineNo">238</span> break;<a name="line.238"></a>
+<span class="sourceLineNo">239</span> }<a name="line.239"></a>
+<span class="sourceLineNo">240</span> Thread.sleep(1000);<a
name="line.240"></a>
+<span class="sourceLineNo">241</span> }<a name="line.241"></a>
+<span class="sourceLineNo">242</span> }<a name="line.242"></a>
+<span class="sourceLineNo">243</span><a name="line.243"></a>
+<span class="sourceLineNo">244</span> @Test<a name="line.244"></a>
+<span class="sourceLineNo">245</span> public void
testNoDuplicateResultsWhenSplitting() throws Exception {<a name="line.245"></a>
+<span class="sourceLineNo">246</span> setupCluster();<a name="line.246"></a>
+<span class="sourceLineNo">247</span> TableName tableName =
TableName.valueOf("testNoDuplicateResultsWhenSplitting");<a name="line.247"></a>
+<span class="sourceLineNo">248</span> String snapshotName =
"testSnapshotBug";<a name="line.248"></a>
+<span class="sourceLineNo">249</span> try {<a name="line.249"></a>
+<span class="sourceLineNo">250</span> if
(UTIL.getAdmin().tableExists(tableName)) {<a name="line.250"></a>
+<span class="sourceLineNo">251</span> UTIL.deleteTable(tableName);<a
name="line.251"></a>
+<span class="sourceLineNo">252</span> }<a name="line.252"></a>
+<span class="sourceLineNo">253</span><a name="line.253"></a>
+<span class="sourceLineNo">254</span> UTIL.createTable(tableName,
FAMILIES);<a name="line.254"></a>
+<span class="sourceLineNo">255</span> Admin admin = UTIL.getAdmin();<a
name="line.255"></a>
+<span class="sourceLineNo">256</span><a name="line.256"></a>
+<span class="sourceLineNo">257</span> // put some stuff in the table<a
name="line.257"></a>
+<span class="sourceLineNo">258</span> Table table =
UTIL.getConnection().getTable(tableName);<a name="line.258"></a>
+<span class="sourceLineNo">259</span> UTIL.loadTable(table, FAMILIES);<a
name="line.259"></a>
+<span class="sourceLineNo">260</span><a name="line.260"></a>
+<span class="sourceLineNo">261</span> // split to 2 regions<a
name="line.261"></a>
+<span class="sourceLineNo">262</span> admin.split(tableName,
Bytes.toBytes("eee"));<a name="line.262"></a>
+<span class="sourceLineNo">263</span> blockUntilSplitFinished(UTIL,
tableName, 2);<a name="line.263"></a>
+<span class="sourceLineNo">264</span><a name="line.264"></a>
+<span class="sourceLineNo">265</span> Path rootDir =
FSUtils.getRootDir(UTIL.getConfiguration());<a name="line.265"></a>
+<span class="sourceLineNo">266</span> FileSystem fs =
rootDir.getFileSystem(UTIL.getConfiguration());<a name="line.266"></a>
+<span class="sourceLineNo">267</span><a name="line.267"></a>
+<span class="sourceLineNo">268</span>
SnapshotTestingUtils.createSnapshotAndValidate(admin, tableName,
Arrays.asList(FAMILIES),<a name="line.268"></a>
+<span class="sourceLineNo">269</span> null, snapshotName, rootDir, fs,
true);<a name="line.269"></a>
+<span class="sourceLineNo">270</span><a name="line.270"></a>
+<span class="sourceLineNo">271</span> // load different values<a
name="line.271"></a>
+<span class="sourceLineNo">272</span> byte[] value =
Bytes.toBytes("after_snapshot_value");<a name="line.272"></a>
+<span class="sourceLineNo">273</span> UTIL.loadTable(table, FAMILIES,
value);<a name="line.273"></a>
<span class="sourceLineNo">274</span><a name="line.274"></a>
-<span class="sourceLineNo">275</span> //create the table and snapshot<a
name="line.275"></a>
-<span class="sourceLineNo">276</span> createTableAndSnapshot(util,
tableName, snapshotName, startRow, endRow, numRegions);<a name="line.276"></a>
-<span class="sourceLineNo">277</span><a name="line.277"></a>
-<span class="sourceLineNo">278</span> if (shutdownCluster) {<a
name="line.278"></a>
-<span class="sourceLineNo">279</span> util.shutdownMiniHBaseCluster();<a
name="line.279"></a>
-<span class="sourceLineNo">280</span> }<a name="line.280"></a>
-<span class="sourceLineNo">281</span><a name="line.281"></a>
-<span class="sourceLineNo">282</span> try {<a name="line.282"></a>
-<span class="sourceLineNo">283</span> // create the job<a
name="line.283"></a>
-<span class="sourceLineNo">284</span> Job job = new
Job(util.getConfiguration());<a name="line.284"></a>
-<span class="sourceLineNo">285</span> Scan scan = new Scan(startRow,
endRow); // limit the scan<a name="line.285"></a>
-<span class="sourceLineNo">286</span><a name="line.286"></a>
-<span class="sourceLineNo">287</span>
job.setJarByClass(util.getClass());<a name="line.287"></a>
-<span class="sourceLineNo">288</span>
TableMapReduceUtil.addDependencyJarsForClasses(job.getConfiguration(),<a
name="line.288"></a>
-<span class="sourceLineNo">289</span>
TestTableSnapshotInputFormat.class);<a name="line.289"></a>
-<span class="sourceLineNo">290</span><a name="line.290"></a>
-<span class="sourceLineNo">291</span>
TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName,<a
name="line.291"></a>
-<span class="sourceLineNo">292</span> scan,
TestTableSnapshotMapper.class, ImmutableBytesWritable.class,<a
name="line.292"></a>
-<span class="sourceLineNo">293</span> NullWritable.class, job, true,
tableDir);<a name="line.293"></a>
-<span class="sourceLineNo">294</span><a name="line.294"></a>
-<span class="sourceLineNo">295</span>
job.setReducerClass(TestTableSnapshotInputFormat.TestTableSnapshotReducer.class);<a
name="line.295"></a>
-<span class="sourceLineNo">296</span> job.setNumReduceTasks(1);<a
name="line.296"></a>
-<span class="sourceLineNo">297</span>
job.setOutputFormatClass(NullOutputFormat.class);<a name="line.297"></a>
-<span class="sourceLineNo">298</span><a name="line.298"></a>
-<span class="sourceLineNo">299</span>
Assert.assertTrue(job.waitForCompletion(true));<a name="line.299"></a>
-<span class="sourceLineNo">300</span> } finally {<a name="line.300"></a>
-<span class="sourceLineNo">301</span> if (!shutdownCluster) {<a
name="line.301"></a>
-<span class="sourceLineNo">302</span>
util.getAdmin().deleteSnapshot(snapshotName);<a name="line.302"></a>
-<span class="sourceLineNo">303</span> util.deleteTable(tableName);<a
name="line.303"></a>
-<span class="sourceLineNo">304</span> }<a name="line.304"></a>
-<span class="sourceLineNo">305</span> }<a name="line.305"></a>
-<span class="sourceLineNo">306</span> }<a name="line.306"></a>
-<span class="sourceLineNo">307</span>}<a name="line.307"></a>
+<span class="sourceLineNo">275</span> // cause flush to create new files
in the region<a name="line.275"></a>
+<span class="sourceLineNo">276</span> admin.flush(tableName);<a
name="line.276"></a>
+<span class="sourceLineNo">277</span> table.close();<a
name="line.277"></a>
+<span class="sourceLineNo">278</span><a name="line.278"></a>
+<span class="sourceLineNo">279</span> Job job = new
Job(UTIL.getConfiguration());<a name="line.279"></a>
+<span class="sourceLineNo">280</span> Path tmpTableDir =
UTIL.getDataTestDirOnTestFS(snapshotName);<a name="line.280"></a>
+<span class="sourceLineNo">281</span> // limit the scan<a
name="line.281"></a>
+<span class="sourceLineNo">282</span> Scan scan = new
Scan().withStartRow(getStartRow()).withStopRow(getEndRow());<a
name="line.282"></a>
+<span class="sourceLineNo">283</span><a name="line.283"></a>
+<span class="sourceLineNo">284</span>
TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName, scan,<a
name="line.284"></a>
+<span class="sourceLineNo">285</span> TestTableSnapshotMapper.class,
ImmutableBytesWritable.class, NullWritable.class, job, false,<a
name="line.285"></a>
+<span class="sourceLineNo">286</span> tmpTableDir);<a
name="line.286"></a>
+<span class="sourceLineNo">287</span><a name="line.287"></a>
+<span class="sourceLineNo">288</span> verifyWithMockedMapReduce(job, 2,
2, getStartRow(), getEndRow());<a name="line.288"></a>
+<span class="sourceLineNo">289</span> } finally {<a name="line.289"></a>
+<span class="sourceLineNo">290</span>
UTIL.getAdmin().deleteSnapshot(snapshotName);<a name="line.290"></a>
+<span class="sourceLineNo">291</span> UTIL.deleteTable(tableName);<a
name="line.291"></a>
+<span class="sourceLineNo">292</span> tearDownCluster();<a
name="line.292"></a>
+<span class="sourceLineNo">293</span> }<a name="line.293"></a>
+<span class="sourceLineNo">294</span> }<a name="line.294"></a>
+<span class="sourceLineNo">295</span><a name="line.295"></a>
+<span class="sourceLineNo">296</span> private void
verifyWithMockedMapReduce(Job job, int numRegions, int expectedNumSplits,<a
name="line.296"></a>
+<span class="sourceLineNo">297</span> byte[] startRow, byte[] stopRow)<a
name="line.297"></a>
+<span class="sourceLineNo">298</span> throws IOException,
InterruptedException {<a name="line.298"></a>
+<span class="sourceLineNo">299</span> TableSnapshotInputFormat tsif = new
TableSnapshotInputFormat();<a name="line.299"></a>
+<span class="sourceLineNo">300</span> List<InputSplit> splits =
tsif.getSplits(job);<a name="line.300"></a>
+<span class="sourceLineNo">301</span><a name="line.301"></a>
+<span class="sourceLineNo">302</span>
Assert.assertEquals(expectedNumSplits, splits.size());<a name="line.302"></a>
+<span class="sourceLineNo">303</span><a name="line.303"></a>
+<span class="sourceLineNo">304</span> HBaseTestingUtility.SeenRowTracker
rowTracker =<a name="line.304"></a>
+<span class="sourceLineNo">305</span> new
HBaseTestingUtility.SeenRowTracker(startRow, stopRow);<a name="line.305"></a>
+<span class="sourceLineNo">306</span><a name="line.306"></a>
+<span class="sourceLineNo">307</span> for (int i = 0; i < splits.size();
i++) {<a name="line.307"></a>
+<span class="sourceLineNo">308</span> // validate input split<a
name="line.308"></a>
+<span class="sourceLineNo">309</span> InputSplit split = splits.get(i);<a
name="line.309"></a>
+<span class="sourceLineNo">310</span> Assert.assertTrue(split instanceof
TableSnapshotRegionSplit);<a name="line.310"></a>
+<span class="sourceLineNo">311</span><a name="line.311"></a>
+<span class="sourceLineNo">312</span> // validate record reader<a
name="line.312"></a>
+<span class="sourceLineNo">313</span> TaskAttemptContext
taskAttemptContext = mock(TaskAttemptContext.class);<a name="line.313"></a>
+<span class="sourceLineNo">314</span>
when(taskAttemptContext.getConfiguration()).thenReturn(job.getConfiguration());<a
name="line.314"></a>
+<span class="sourceLineNo">315</span>
RecordReader<ImmutableBytesWritable, Result> rr =<a name="line.315"></a>
+<span class="sourceLineNo">316</span> tsif.createRecordReader(split,
taskAttemptContext);<a name="line.316"></a>
+<span class="sourceLineNo">317</span> rr.initialize(split,
taskAttemptContext);<a name="line.317"></a>
+<span class="sourceLineNo">318</span><a name="line.318"></a>
+<span class="sourceLineNo">319</span> // validate we can read all the
data back<a name="line.319"></a>
+<span class="sourceLineNo">320</span> while (rr.nextKeyValue()) {<a
name="line.320"></a>
+<span class="sourceLineNo">321</span> byte[] row =
rr.getCurrentKey().get();<a name="line.321"></a>
+<span class="sourceLineNo">322</span>
verifyRowFromMap(rr.getCurrentKey(), rr.getCurrentValue());<a
name="line.322"></a>
+<span class="sourceLineNo">323</span> rowTracker.addRow(row);<a
name="line.323"></a>
+<span class="sourceLineNo">324</span> }<a name="line.324"></a>
+<span class="sourceLineNo">325</span><a name="line.325"></a>
+<span class="sourceLineNo">326</span> rr.close();<a name="line.326"></a>
+<span class="sourceLineNo">327</span> }<a name="line.327"></a>
+<span class="sourceLineNo">328</span><a name="line.328"></a>
+<span class="sourceLineNo">329</span> // validate all rows are seen<a
name="line.329"></a>
+<span class="sourceLineNo">330</span> rowTracker.validate();<a
name="line.330"></a>
+<span class="sourceLineNo">331</span> }<a name="line.331"></a>
+<span class="sourceLineNo">332</span><a name="line.332"></a>
+<span class="sourceLineNo">333</span> @Override<a name="line.333"></a>
+<span class="sourceLineNo">334</span> protected void
testWithMapReduceImpl(HBaseTestingUtility util, TableName tableName,<a
name="line.334"></a>
+<span class="sourceLineNo">335</span> String snapshotName, Path tableDir,
int numRegions, int expectedNumSplits,<a name="line.335"></a>
+<span class="sourceLineNo">336</span> boolean shutdownCluster) throws
Exception {<a name="line.336"></a>
+<span class="sourceLineNo">337</span> doTestWithMapReduce(util, tableName,
snapshotName, getStartRow(), getEndRow(), tableDir,<a name="line.337"></a>
+<span class="sourceLineNo">338</span> numRegions, expectedNumSplits,
shutdownCluster);<a name="line.338"></a>
+<span class="sourceLineNo">339</span> }<a name="line.339"></a>
+<span class="sourceLineNo">340</span><a name="line.340"></a>
+<span class="sourceLineNo">341</span> // this is also called by the
IntegrationTestTableSnapshotInputFormat<a name="line.341"></a>
+<span class="sourceLineNo">342</span> public static void
doTestWithMapReduce(HBaseTestingUtility util, TableName tableName,<a
name="line.342"></a>
+<span class="sourceLineNo">343</span> String snapshotName, byte[]
startRow, byte[] endRow, Path tableDir, int numRegions,<a name="line.343"></a>
+<span class="sourceLineNo">344</span> int expectedNumSplits, boolean
shutdownCluster) throws Exception {<a name="line.344"></a>
+<span class="sourceLineNo">345</span><a name="line.345"></a>
+<span class="sourceLineNo">346</span> //create the table and snapshot<a
name="line.346"></a>
+<span class="sourceLineNo">347</span> createTableAndSnapshot(util,
tableName, snapshotName, startRow, endRow, numRegions);<a name="line.347"></a>
+<span class="sourceLineNo">348</span><a name="line.348"></a>
+<span class="sourceLineNo">349</span> if (shutdownCluster) {<a
name="line.349"></a>
+<span class="sourceLineNo">350</span> util.shutdownMiniHBaseCluster();<a
name="line.350"></a>
+<span class="sourceLineNo">351</span> }<a name="line.351"></a>
+<span class="sourceLineNo">352</span><a name="line.352"></a>
+<span class="sourceLineNo">353</span> try {<a name="line.353"></a>
+<span class="sourceLineNo">354</span> // create the job<a
name="line.354"></a>
+<span class="sourceLineNo">355</span> Job job = new
Job(util.getConfiguration());<a name="line.355"></a>
+<span class="sourceLineNo">356</span> Scan scan = new Scan(startRow,
endRow); // limit the scan<a name="line.356"></a>
+<span class="sourceLineNo">357</span><a name="line.357"></a>
+<span class="sourceLineNo">358</span>
job.setJarByClass(util.getClass());<a name="line.358"></a>
+<span class="sourceLineNo">359</span>
TableMapReduceUtil.addDependencyJarsForClasses(job.getConfiguration(),<a
name="line.359"></a>
+<span class="sourceLineNo">360</span>
TestTableSnapshotInputFormat.class);<a name="line.360"></a>
+<span class="sourceLineNo">361</span><a name="line.361"></a>
+<span class="sourceLineNo">362</span>
TableMapReduceUtil.initTableSnapshotMapperJob(snapshotName,<a
name="line.362"></a>
+<span class="sourceLineNo">363</span> scan,
TestTableSnapshotMapper.class, ImmutableBytesWritable.class,<a
name="line.363"></a>
+<span class="sourceLineNo">364</span> NullWritable.class, job, true,
tableDir);<a name="line.364"></a>
+<span class="sourceLineNo">365</span><a name="line.365"></a>
+<span class="sourceLineNo">366</span>
job.setReducerClass(TestTableSnapshotInputFormat.TestTableSnapshotReducer.class);<a
name="line.366"></a>
+<span class="sourceLineNo">367</span> job.setNumReduceTasks(1);<a
name="line.367"></a>
+<span class="sourceLineNo">368</span>
job.setOutputFormatClass(NullOutputFormat.class);<a name="line.368"></a>
+<span class="sourceLineNo">369</span><a name="line.369"></a>
+<span class="sourceLineNo">370</span>
Assert.assertTrue(job.waitForCompletion(true));<a name="line.370"></a>
+<span class="sourceLineNo">371</span> } finally {<a name="line.371"></a>
+<span class="sourceLineNo">372</span> if (!shutdownCluster) {<a
name="line.372"></a>
+<span class="sourceLineNo">373</span>
util.getAdmin().deleteSnapshot(snapshotName);<a name="line.373"></a>
+<span class="sourceLineNo">374</span> util.deleteTable(tableName);<a
name="line.374"></a>
+<span class="sourceLineNo">375</span> }<a name="line.375"></a>
+<span class="sourceLineNo">376</span> }<a name="line.376"></a>
+<span class="sourceLineNo">377</span> }<a name="line.377"></a>
+<span class="sourceLineNo">378</span>}<a name="line.378"></a>
