Repository: hbase Updated Branches: refs/heads/branch-1 d5bba5079 -> 74e9d3147
HBASE-18164 Fast locality computation in balancer - addendum handles NaN -Added new LocalityCostFunction and LocalityCandidateGenerator that cache localities of every region/rack combination and mappings of every region to its most local server and to its most local rack. -Made LocalityCostFunction incremental so that it only computes locality based on most recent region moves/swaps, rather than recomputing the locality of every region in the cluster at every iteration of the balancer -Changed locality cost function to reflect the ratio of: (Current locality) / (Best locality possible given current cluster) Signed-off-by: tedyu <yuzhih...@gmail.com> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/74e9d314 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/74e9d314 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/74e9d314 Branch: refs/heads/branch-1 Commit: 74e9d314749a24ecdeebecfb801416efd71c3b79 Parents: d5bba50 Author: Kahlil Oppenheimer <kahliloppenhei...@gmail.com> Authored: Tue Jun 6 15:53:43 2017 -0400 Committer: tedyu <yuzhih...@gmail.com> Committed: Mon Jun 26 12:40:30 2017 -0700 ---------------------------------------------------------------------- .../hadoop/hbase/master/balancer/StochasticLoadBalancer.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/74e9d314/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java index 6f99f44..419f051 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java @@ -1279,8 +1279,9 @@ public class StochasticLoadBalancer extends BaseLoadBalancer { } // We normalize locality to be a score between 0 and 1.0 representing how good it - // is compared to how good it could be - locality /= bestLocality; + // is compared to how good it could be. If bestLocality is 0, assume locality is 100 + // (and the cost is 0) + locality = bestLocality == 0 ? 1 : locality / bestLocality; } @Override @@ -1291,7 +1292,7 @@ public class StochasticLoadBalancer extends BaseLoadBalancer { return; } double localityDelta = getWeightedLocality(region, newEntity) - getWeightedLocality(region, oldEntity); - double normalizedDelta = localityDelta / bestLocality; + double normalizedDelta = bestLocality == 0 ? 0.0 : localityDelta / bestLocality; locality += normalizedDelta; }
