Repository: hbase Updated Branches: refs/heads/branch-2 590979aac -> 29ec74936
HBASE-18314 Eliminate the findbugs warnings for hbase-examples Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/29ec7493 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/29ec7493 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/29ec7493 Branch: refs/heads/branch-2 Commit: 29ec7493639cc0820641dc15902646876eed4bbb Parents: 590979a Author: Chia-Ping Tsai <[email protected]> Authored: Wed Jul 5 09:55:37 2017 +0800 Committer: Chia-Ping Tsai <[email protected]> Committed: Wed Jul 5 09:55:37 2017 +0800 ---------------------------------------------------------------------- .../apache/hadoop/hbase/client/example/AsyncClientExample.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/29ec7493/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/AsyncClientExample.java ---------------------------------------------------------------------- diff --git a/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/AsyncClientExample.java b/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/AsyncClientExample.java index 2d587bf..2105547 100644 --- a/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/AsyncClientExample.java +++ b/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/AsyncClientExample.java @@ -97,6 +97,8 @@ public class AsyncClientExample extends Configured implements Tool { } } + @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="NP_NONNULL_PARAM_VIOLATION", + justification="it is valid to pass NULL to CompletableFuture#completedFuture") private CompletableFuture<Void> closeConn() { CompletableFuture<AsyncConnection> f = future.get(); if (f == null) { @@ -150,7 +152,7 @@ public class AsyncClientExample extends Configured implements Tool { LOG.info("put for " + i + " succeeded, try getting"); table.get(new Get(getKey(i))).whenComplete((result, getErr) -> { if (getErr != null) { - LOG.warn("get failed for " + i, putErr); + LOG.warn("get failed for " + i); latch.countDown(); return; }
