http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.Bucket.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.Bucket.html b/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.Bucket.html index eaa2b13..6a0c52a 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.Bucket.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.Bucket.html @@ -323,7 +323,7 @@ <span class="sourceLineNo">315</span> this.bucketSizes = bucketSizes == null ? DEFAULT_BUCKET_SIZES : bucketSizes;<a name="line.315"></a> <span class="sourceLineNo">316</span> Arrays.sort(this.bucketSizes);<a name="line.316"></a> <span class="sourceLineNo">317</span> this.bigItemSize = Ints.max(this.bucketSizes);<a name="line.317"></a> -<span class="sourceLineNo">318</span> this.bucketCapacity = FEWEST_ITEMS_IN_BUCKET * bigItemSize;<a name="line.318"></a> +<span class="sourceLineNo">318</span> this.bucketCapacity = FEWEST_ITEMS_IN_BUCKET * (long) bigItemSize;<a name="line.318"></a> <span class="sourceLineNo">319</span> buckets = new Bucket[(int) (availableSpace / bucketCapacity)];<a name="line.319"></a> <span class="sourceLineNo">320</span> if (buckets.length < this.bucketSizes.length)<a name="line.320"></a> <span class="sourceLineNo">321</span> throw new BucketAllocatorException("Bucket allocator size too small (" + buckets.length +<a name="line.321"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.BucketSizeInfo.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.BucketSizeInfo.html b/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.BucketSizeInfo.html index eaa2b13..6a0c52a 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.BucketSizeInfo.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.BucketSizeInfo.html @@ -323,7 +323,7 @@ <span class="sourceLineNo">315</span> this.bucketSizes = bucketSizes == null ? DEFAULT_BUCKET_SIZES : bucketSizes;<a name="line.315"></a> <span class="sourceLineNo">316</span> Arrays.sort(this.bucketSizes);<a name="line.316"></a> <span class="sourceLineNo">317</span> this.bigItemSize = Ints.max(this.bucketSizes);<a name="line.317"></a> -<span class="sourceLineNo">318</span> this.bucketCapacity = FEWEST_ITEMS_IN_BUCKET * bigItemSize;<a name="line.318"></a> +<span class="sourceLineNo">318</span> this.bucketCapacity = FEWEST_ITEMS_IN_BUCKET * (long) bigItemSize;<a name="line.318"></a> <span class="sourceLineNo">319</span> buckets = new Bucket[(int) (availableSpace / bucketCapacity)];<a name="line.319"></a> <span class="sourceLineNo">320</span> if (buckets.length < this.bucketSizes.length)<a name="line.320"></a> <span class="sourceLineNo">321</span> throw new BucketAllocatorException("Bucket allocator size too small (" + buckets.length +<a name="line.321"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.IndexStatistics.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.IndexStatistics.html b/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.IndexStatistics.html index eaa2b13..6a0c52a 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.IndexStatistics.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.IndexStatistics.html @@ -323,7 +323,7 @@ <span class="sourceLineNo">315</span> this.bucketSizes = bucketSizes == null ? DEFAULT_BUCKET_SIZES : bucketSizes;<a name="line.315"></a> <span class="sourceLineNo">316</span> Arrays.sort(this.bucketSizes);<a name="line.316"></a> <span class="sourceLineNo">317</span> this.bigItemSize = Ints.max(this.bucketSizes);<a name="line.317"></a> -<span class="sourceLineNo">318</span> this.bucketCapacity = FEWEST_ITEMS_IN_BUCKET * bigItemSize;<a name="line.318"></a> +<span class="sourceLineNo">318</span> this.bucketCapacity = FEWEST_ITEMS_IN_BUCKET * (long) bigItemSize;<a name="line.318"></a> <span class="sourceLineNo">319</span> buckets = new Bucket[(int) (availableSpace / bucketCapacity)];<a name="line.319"></a> <span class="sourceLineNo">320</span> if (buckets.length < this.bucketSizes.length)<a name="line.320"></a> <span class="sourceLineNo">321</span> throw new BucketAllocatorException("Bucket allocator size too small (" + buckets.length +<a name="line.321"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.html b/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.html index eaa2b13..6a0c52a 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.html @@ -323,7 +323,7 @@ <span class="sourceLineNo">315</span> this.bucketSizes = bucketSizes == null ? DEFAULT_BUCKET_SIZES : bucketSizes;<a name="line.315"></a> <span class="sourceLineNo">316</span> Arrays.sort(this.bucketSizes);<a name="line.316"></a> <span class="sourceLineNo">317</span> this.bigItemSize = Ints.max(this.bucketSizes);<a name="line.317"></a> -<span class="sourceLineNo">318</span> this.bucketCapacity = FEWEST_ITEMS_IN_BUCKET * bigItemSize;<a name="line.318"></a> +<span class="sourceLineNo">318</span> this.bucketCapacity = FEWEST_ITEMS_IN_BUCKET * (long) bigItemSize;<a name="line.318"></a> <span class="sourceLineNo">319</span> buckets = new Bucket[(int) (availableSpace / bucketCapacity)];<a name="line.319"></a> <span class="sourceLineNo">320</span> if (buckets.length < this.bucketSizes.length)<a name="line.320"></a> <span class="sourceLineNo">321</span> throw new BucketAllocatorException("Bucket allocator size too small (" + buckets.length +<a name="line.321"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.CallSender.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.CallSender.html b/devapidocs/src-html/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.CallSender.html index 08be6f5..922302c 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.CallSender.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.CallSender.html @@ -496,7 +496,7 @@ <span class="sourceLineNo">488</span> closeSocket();<a name="line.488"></a> <span class="sourceLineNo">489</span> IOException e = ExceptionUtil.asInterrupt(t);<a name="line.489"></a> <span class="sourceLineNo">490</span> if (e == null) {<a name="line.490"></a> -<span class="sourceLineNo">491</span> this.rpcClient.failedServers.addToFailedServers(remoteId.address);<a name="line.491"></a> +<span class="sourceLineNo">491</span> this.rpcClient.failedServers.addToFailedServers(remoteId.address, t);<a name="line.491"></a> <span class="sourceLineNo">492</span> if (t instanceof LinkageError) {<a name="line.492"></a> <span class="sourceLineNo">493</span> // probably the hbase hadoop version does not match the running hadoop version<a name="line.493"></a> <span class="sourceLineNo">494</span> e = new DoNotRetryIOException(t);<a name="line.494"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.html b/devapidocs/src-html/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.html index 08be6f5..922302c 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.html @@ -496,7 +496,7 @@ <span class="sourceLineNo">488</span> closeSocket();<a name="line.488"></a> <span class="sourceLineNo">489</span> IOException e = ExceptionUtil.asInterrupt(t);<a name="line.489"></a> <span class="sourceLineNo">490</span> if (e == null) {<a name="line.490"></a> -<span class="sourceLineNo">491</span> this.rpcClient.failedServers.addToFailedServers(remoteId.address);<a name="line.491"></a> +<span class="sourceLineNo">491</span> this.rpcClient.failedServers.addToFailedServers(remoteId.address, t);<a name="line.491"></a> <span class="sourceLineNo">492</span> if (t instanceof LinkageError) {<a name="line.492"></a> <span class="sourceLineNo">493</span> // probably the hbase hadoop version does not match the running hadoop version<a name="line.493"></a> <span class="sourceLineNo">494</span> e = new DoNotRetryIOException(t);<a name="line.494"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/FailedServers.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/FailedServers.html b/devapidocs/src-html/org/apache/hadoop/hbase/ipc/FailedServers.html index 6f7345c..90a9d51 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/FailedServers.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/ipc/FailedServers.html @@ -31,61 +31,69 @@ <span class="sourceLineNo">023</span>import java.util.LinkedList;<a name="line.23"></a> <span class="sourceLineNo">024</span>import java.util.Map;<a name="line.24"></a> <span class="sourceLineNo">025</span><a name="line.25"></a> -<span class="sourceLineNo">026</span>import org.apache.hadoop.conf.Configuration;<a name="line.26"></a> -<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.classification.InterfaceAudience;<a name="line.27"></a> -<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;<a name="line.28"></a> -<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.util.Pair;<a name="line.29"></a> -<span class="sourceLineNo">030</span><a name="line.30"></a> -<span class="sourceLineNo">031</span>/**<a name="line.31"></a> -<span class="sourceLineNo">032</span> * A class to manage a list of servers that failed recently.<a name="line.32"></a> -<span class="sourceLineNo">033</span> */<a name="line.33"></a> -<span class="sourceLineNo">034</span>@InterfaceAudience.Private<a name="line.34"></a> -<span class="sourceLineNo">035</span>public class FailedServers {<a name="line.35"></a> -<span class="sourceLineNo">036</span> private final Map<String, Long> failedServers = new HashMap<String, Long>();<a name="line.36"></a> -<span class="sourceLineNo">037</span> private long latestExpiry = 0;<a name="line.37"></a> -<span class="sourceLineNo">038</span> private final int recheckServersTimeout;<a name="line.38"></a> -<span class="sourceLineNo">039</span><a name="line.39"></a> -<span class="sourceLineNo">040</span> public FailedServers(Configuration conf) {<a name="line.40"></a> -<span class="sourceLineNo">041</span> this.recheckServersTimeout = conf.getInt(<a name="line.41"></a> -<span class="sourceLineNo">042</span> RpcClient.FAILED_SERVER_EXPIRY_KEY, RpcClient.FAILED_SERVER_EXPIRY_DEFAULT);<a name="line.42"></a> -<span class="sourceLineNo">043</span> }<a name="line.43"></a> -<span class="sourceLineNo">044</span><a name="line.44"></a> -<span class="sourceLineNo">045</span> /**<a name="line.45"></a> -<span class="sourceLineNo">046</span> * Add an address to the list of the failed servers list.<a name="line.46"></a> -<span class="sourceLineNo">047</span> */<a name="line.47"></a> -<span class="sourceLineNo">048</span> public synchronized void addToFailedServers(InetSocketAddress address) {<a name="line.48"></a> -<span class="sourceLineNo">049</span> final long expiry = EnvironmentEdgeManager.currentTime() + recheckServersTimeout;<a name="line.49"></a> -<span class="sourceLineNo">050</span> this.failedServers.put(address.toString(), expiry);<a name="line.50"></a> -<span class="sourceLineNo">051</span> this.latestExpiry = expiry;<a name="line.51"></a> -<span class="sourceLineNo">052</span> }<a name="line.52"></a> -<span class="sourceLineNo">053</span><a name="line.53"></a> -<span class="sourceLineNo">054</span> /**<a name="line.54"></a> -<span class="sourceLineNo">055</span> * Check if the server should be considered as bad. Clean the old entries of the list.<a name="line.55"></a> -<span class="sourceLineNo">056</span> *<a name="line.56"></a> -<span class="sourceLineNo">057</span> * @return true if the server is in the failed servers list<a name="line.57"></a> -<span class="sourceLineNo">058</span> */<a name="line.58"></a> -<span class="sourceLineNo">059</span> public synchronized boolean isFailedServer(final InetSocketAddress address) {<a name="line.59"></a> -<span class="sourceLineNo">060</span> if (failedServers.isEmpty()) {<a name="line.60"></a> -<span class="sourceLineNo">061</span> return false;<a name="line.61"></a> -<span class="sourceLineNo">062</span> }<a name="line.62"></a> -<span class="sourceLineNo">063</span> final long now = EnvironmentEdgeManager.currentTime();<a name="line.63"></a> -<span class="sourceLineNo">064</span> if (now > this.latestExpiry) {<a name="line.64"></a> -<span class="sourceLineNo">065</span> failedServers.clear();<a name="line.65"></a> -<span class="sourceLineNo">066</span> return false;<a name="line.66"></a> -<span class="sourceLineNo">067</span> }<a name="line.67"></a> -<span class="sourceLineNo">068</span> String key = address.toString();<a name="line.68"></a> -<span class="sourceLineNo">069</span> Long expiry = this.failedServers.get(key);<a name="line.69"></a> -<span class="sourceLineNo">070</span> if (expiry == null) {<a name="line.70"></a> -<span class="sourceLineNo">071</span> return false;<a name="line.71"></a> -<span class="sourceLineNo">072</span> }<a name="line.72"></a> -<span class="sourceLineNo">073</span> if (expiry >= now) {<a name="line.73"></a> -<span class="sourceLineNo">074</span> return true;<a name="line.74"></a> -<span class="sourceLineNo">075</span> } else {<a name="line.75"></a> -<span class="sourceLineNo">076</span> this.failedServers.remove(key);<a name="line.76"></a> -<span class="sourceLineNo">077</span> }<a name="line.77"></a> -<span class="sourceLineNo">078</span> return false;<a name="line.78"></a> -<span class="sourceLineNo">079</span> }<a name="line.79"></a> -<span class="sourceLineNo">080</span>}<a name="line.80"></a> +<span class="sourceLineNo">026</span>import org.apache.commons.logging.Log;<a name="line.26"></a> +<span class="sourceLineNo">027</span>import org.apache.commons.logging.LogFactory;<a name="line.27"></a> +<span class="sourceLineNo">028</span>import org.apache.hadoop.conf.Configuration;<a name="line.28"></a> +<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.classification.InterfaceAudience;<a name="line.29"></a> +<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;<a name="line.30"></a> +<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.util.Pair;<a name="line.31"></a> +<span class="sourceLineNo">032</span><a name="line.32"></a> +<span class="sourceLineNo">033</span>/**<a name="line.33"></a> +<span class="sourceLineNo">034</span> * A class to manage a list of servers that failed recently.<a name="line.34"></a> +<span class="sourceLineNo">035</span> */<a name="line.35"></a> +<span class="sourceLineNo">036</span>@InterfaceAudience.Private<a name="line.36"></a> +<span class="sourceLineNo">037</span>public class FailedServers {<a name="line.37"></a> +<span class="sourceLineNo">038</span> private final Map<String, Long> failedServers = new HashMap<String, Long>();<a name="line.38"></a> +<span class="sourceLineNo">039</span> private long latestExpiry = 0;<a name="line.39"></a> +<span class="sourceLineNo">040</span> private final int recheckServersTimeout;<a name="line.40"></a> +<span class="sourceLineNo">041</span> private static final Log LOG = LogFactory.getLog(FailedServers.class);<a name="line.41"></a> +<span class="sourceLineNo">042</span><a name="line.42"></a> +<span class="sourceLineNo">043</span> public FailedServers(Configuration conf) {<a name="line.43"></a> +<span class="sourceLineNo">044</span> this.recheckServersTimeout = conf.getInt(<a name="line.44"></a> +<span class="sourceLineNo">045</span> RpcClient.FAILED_SERVER_EXPIRY_KEY, RpcClient.FAILED_SERVER_EXPIRY_DEFAULT);<a name="line.45"></a> +<span class="sourceLineNo">046</span> }<a name="line.46"></a> +<span class="sourceLineNo">047</span><a name="line.47"></a> +<span class="sourceLineNo">048</span> /**<a name="line.48"></a> +<span class="sourceLineNo">049</span> * Add an address to the list of the failed servers list.<a name="line.49"></a> +<span class="sourceLineNo">050</span> */<a name="line.50"></a> +<span class="sourceLineNo">051</span> public synchronized void addToFailedServers(InetSocketAddress address, Throwable throwable) {<a name="line.51"></a> +<span class="sourceLineNo">052</span> final long expiry = EnvironmentEdgeManager.currentTime() + recheckServersTimeout;<a name="line.52"></a> +<span class="sourceLineNo">053</span> this.failedServers.put(address.toString(), expiry);<a name="line.53"></a> +<span class="sourceLineNo">054</span> this.latestExpiry = expiry;<a name="line.54"></a> +<span class="sourceLineNo">055</span> if (LOG.isDebugEnabled()) {<a name="line.55"></a> +<span class="sourceLineNo">056</span> LOG.debug(<a name="line.56"></a> +<span class="sourceLineNo">057</span> "Added failed server with address " + address.toString() + " to list caused by "<a name="line.57"></a> +<span class="sourceLineNo">058</span> + throwable.toString());<a name="line.58"></a> +<span class="sourceLineNo">059</span> }<a name="line.59"></a> +<span class="sourceLineNo">060</span> }<a name="line.60"></a> +<span class="sourceLineNo">061</span><a name="line.61"></a> +<span class="sourceLineNo">062</span> /**<a name="line.62"></a> +<span class="sourceLineNo">063</span> * Check if the server should be considered as bad. Clean the old entries of the list.<a name="line.63"></a> +<span class="sourceLineNo">064</span> *<a name="line.64"></a> +<span class="sourceLineNo">065</span> * @return true if the server is in the failed servers list<a name="line.65"></a> +<span class="sourceLineNo">066</span> */<a name="line.66"></a> +<span class="sourceLineNo">067</span> public synchronized boolean isFailedServer(final InetSocketAddress address) {<a name="line.67"></a> +<span class="sourceLineNo">068</span> if (failedServers.isEmpty()) {<a name="line.68"></a> +<span class="sourceLineNo">069</span> return false;<a name="line.69"></a> +<span class="sourceLineNo">070</span> }<a name="line.70"></a> +<span class="sourceLineNo">071</span> final long now = EnvironmentEdgeManager.currentTime();<a name="line.71"></a> +<span class="sourceLineNo">072</span> if (now > this.latestExpiry) {<a name="line.72"></a> +<span class="sourceLineNo">073</span> failedServers.clear();<a name="line.73"></a> +<span class="sourceLineNo">074</span> return false;<a name="line.74"></a> +<span class="sourceLineNo">075</span> }<a name="line.75"></a> +<span class="sourceLineNo">076</span> String key = address.toString();<a name="line.76"></a> +<span class="sourceLineNo">077</span> Long expiry = this.failedServers.get(key);<a name="line.77"></a> +<span class="sourceLineNo">078</span> if (expiry == null) {<a name="line.78"></a> +<span class="sourceLineNo">079</span> return false;<a name="line.79"></a> +<span class="sourceLineNo">080</span> }<a name="line.80"></a> +<span class="sourceLineNo">081</span> if (expiry >= now) {<a name="line.81"></a> +<span class="sourceLineNo">082</span> return true;<a name="line.82"></a> +<span class="sourceLineNo">083</span> } else {<a name="line.83"></a> +<span class="sourceLineNo">084</span> this.failedServers.remove(key);<a name="line.84"></a> +<span class="sourceLineNo">085</span> }<a name="line.85"></a> +<span class="sourceLineNo">086</span> return false;<a name="line.86"></a> +<span class="sourceLineNo">087</span> }<a name="line.87"></a> +<span class="sourceLineNo">088</span>}<a name="line.88"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/NettyRpcConnection.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/NettyRpcConnection.html b/devapidocs/src-html/org/apache/hadoop/hbase/ipc/NettyRpcConnection.html index f627b29..3aed1dd 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/NettyRpcConnection.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/ipc/NettyRpcConnection.html @@ -274,7 +274,7 @@ <span class="sourceLineNo">266</span> Channel ch = future.channel();<a name="line.266"></a> <span class="sourceLineNo">267</span> if (!future.isSuccess()) {<a name="line.267"></a> <span class="sourceLineNo">268</span> failInit(ch, toIOE(future.cause()));<a name="line.268"></a> -<span class="sourceLineNo">269</span> rpcClient.failedServers.addToFailedServers(remoteId.address);<a name="line.269"></a> +<span class="sourceLineNo">269</span> rpcClient.failedServers.addToFailedServers(remoteId.address, future.cause());<a name="line.269"></a> <span class="sourceLineNo">270</span> return;<a name="line.270"></a> <span class="sourceLineNo">271</span> }<a name="line.271"></a> <span class="sourceLineNo">272</span> ch.writeAndFlush(connectionHeaderPreamble.retainedDuplicate());<a name="line.272"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.html b/devapidocs/src-html/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.html index c9c92b3..29545f8 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.html @@ -99,163 +99,164 @@ <span class="sourceLineNo">091</span> : sizeWithoutCellBlock;<a name="line.91"></a> <span class="sourceLineNo">092</span> ByteBuf buf = ctx.alloc().buffer(sizeWithoutCellBlock + 4);<a name="line.92"></a> <span class="sourceLineNo">093</span> buf.writeInt(totalSize);<a name="line.93"></a> -<span class="sourceLineNo">094</span> ByteBufOutputStream bbos = new ByteBufOutputStream(buf);<a name="line.94"></a> -<span class="sourceLineNo">095</span> requestHeader.writeDelimitedTo(bbos);<a name="line.95"></a> -<span class="sourceLineNo">096</span> if (call.param != null) {<a name="line.96"></a> -<span class="sourceLineNo">097</span> call.param.writeDelimitedTo(bbos);<a name="line.97"></a> -<span class="sourceLineNo">098</span> }<a name="line.98"></a> -<span class="sourceLineNo">099</span> if (cellBlock != null) {<a name="line.99"></a> -<span class="sourceLineNo">100</span> ChannelPromise withoutCellBlockPromise = ctx.newPromise();<a name="line.100"></a> -<span class="sourceLineNo">101</span> ctx.write(buf, withoutCellBlockPromise);<a name="line.101"></a> -<span class="sourceLineNo">102</span> ChannelPromise cellBlockPromise = ctx.newPromise();<a name="line.102"></a> -<span class="sourceLineNo">103</span> ctx.write(cellBlock, cellBlockPromise);<a name="line.103"></a> -<span class="sourceLineNo">104</span> PromiseCombiner combiner = new PromiseCombiner();<a name="line.104"></a> -<span class="sourceLineNo">105</span> combiner.addAll(withoutCellBlockPromise, cellBlockPromise);<a name="line.105"></a> -<span class="sourceLineNo">106</span> combiner.finish(promise);<a name="line.106"></a> -<span class="sourceLineNo">107</span> } else {<a name="line.107"></a> -<span class="sourceLineNo">108</span> ctx.write(buf, promise);<a name="line.108"></a> -<span class="sourceLineNo">109</span> }<a name="line.109"></a> -<span class="sourceLineNo">110</span> }<a name="line.110"></a> -<span class="sourceLineNo">111</span><a name="line.111"></a> -<span class="sourceLineNo">112</span> @Override<a name="line.112"></a> -<span class="sourceLineNo">113</span> public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise)<a name="line.113"></a> -<span class="sourceLineNo">114</span> throws Exception {<a name="line.114"></a> -<span class="sourceLineNo">115</span> if (msg instanceof Call) {<a name="line.115"></a> -<span class="sourceLineNo">116</span> writeRequest(ctx, (Call) msg, promise);<a name="line.116"></a> -<span class="sourceLineNo">117</span> } else {<a name="line.117"></a> -<span class="sourceLineNo">118</span> ctx.write(msg, promise);<a name="line.118"></a> -<span class="sourceLineNo">119</span> }<a name="line.119"></a> -<span class="sourceLineNo">120</span> }<a name="line.120"></a> -<span class="sourceLineNo">121</span><a name="line.121"></a> -<span class="sourceLineNo">122</span> private void readResponse(ChannelHandlerContext ctx, ByteBuf buf) throws IOException {<a name="line.122"></a> -<span class="sourceLineNo">123</span> int totalSize = buf.readInt();<a name="line.123"></a> -<span class="sourceLineNo">124</span> ByteBufInputStream in = new ByteBufInputStream(buf);<a name="line.124"></a> -<span class="sourceLineNo">125</span> ResponseHeader responseHeader = ResponseHeader.parseDelimitedFrom(in);<a name="line.125"></a> -<span class="sourceLineNo">126</span> int id = responseHeader.getCallId();<a name="line.126"></a> -<span class="sourceLineNo">127</span> if (LOG.isTraceEnabled()) {<a name="line.127"></a> -<span class="sourceLineNo">128</span> LOG.trace("got response header " + TextFormat.shortDebugString(responseHeader)<a name="line.128"></a> -<span class="sourceLineNo">129</span> + ", totalSize: " + totalSize + " bytes");<a name="line.129"></a> -<span class="sourceLineNo">130</span> }<a name="line.130"></a> -<span class="sourceLineNo">131</span> RemoteException remoteExc;<a name="line.131"></a> -<span class="sourceLineNo">132</span> if (responseHeader.hasException()) {<a name="line.132"></a> -<span class="sourceLineNo">133</span> ExceptionResponse exceptionResponse = responseHeader.getException();<a name="line.133"></a> -<span class="sourceLineNo">134</span> remoteExc = IPCUtil.createRemoteException(exceptionResponse);<a name="line.134"></a> -<span class="sourceLineNo">135</span> if (IPCUtil.isFatalConnectionException(exceptionResponse)) {<a name="line.135"></a> -<span class="sourceLineNo">136</span> // Here we will cleanup all calls so do not need to fall back, just return.<a name="line.136"></a> -<span class="sourceLineNo">137</span> exceptionCaught(ctx, remoteExc);<a name="line.137"></a> -<span class="sourceLineNo">138</span> return;<a name="line.138"></a> -<span class="sourceLineNo">139</span> }<a name="line.139"></a> -<span class="sourceLineNo">140</span> } else {<a name="line.140"></a> -<span class="sourceLineNo">141</span> remoteExc = null;<a name="line.141"></a> -<span class="sourceLineNo">142</span> }<a name="line.142"></a> -<span class="sourceLineNo">143</span> Call call = id2Call.remove(id);<a name="line.143"></a> -<span class="sourceLineNo">144</span> if (call == null) {<a name="line.144"></a> -<span class="sourceLineNo">145</span> // So we got a response for which we have no corresponding 'call' here on the client-side.<a name="line.145"></a> -<span class="sourceLineNo">146</span> // We probably timed out waiting, cleaned up all references, and now the server decides<a name="line.146"></a> -<span class="sourceLineNo">147</span> // to return a response. There is nothing we can do w/ the response at this stage. Clean<a name="line.147"></a> -<span class="sourceLineNo">148</span> // out the wire of the response so its out of the way and we can get other responses on<a name="line.148"></a> -<span class="sourceLineNo">149</span> // this connection.<a name="line.149"></a> -<span class="sourceLineNo">150</span> int readSoFar = IPCUtil.getTotalSizeWhenWrittenDelimited(responseHeader);<a name="line.150"></a> -<span class="sourceLineNo">151</span> int whatIsLeftToRead = totalSize - readSoFar;<a name="line.151"></a> -<span class="sourceLineNo">152</span> if (LOG.isDebugEnabled()) {<a name="line.152"></a> -<span class="sourceLineNo">153</span> LOG.debug("Unknown callId: " + id + ", skipping over this response of " + whatIsLeftToRead<a name="line.153"></a> -<span class="sourceLineNo">154</span> + " bytes");<a name="line.154"></a> -<span class="sourceLineNo">155</span> }<a name="line.155"></a> -<span class="sourceLineNo">156</span> return;<a name="line.156"></a> -<span class="sourceLineNo">157</span> }<a name="line.157"></a> -<span class="sourceLineNo">158</span> if (remoteExc != null) {<a name="line.158"></a> -<span class="sourceLineNo">159</span> call.setException(remoteExc);<a name="line.159"></a> -<span class="sourceLineNo">160</span> return;<a name="line.160"></a> -<span class="sourceLineNo">161</span> }<a name="line.161"></a> -<span class="sourceLineNo">162</span> Message value;<a name="line.162"></a> -<span class="sourceLineNo">163</span> if (call.responseDefaultType != null) {<a name="line.163"></a> -<span class="sourceLineNo">164</span> Builder builder = call.responseDefaultType.newBuilderForType();<a name="line.164"></a> -<span class="sourceLineNo">165</span> builder.mergeDelimitedFrom(in);<a name="line.165"></a> -<span class="sourceLineNo">166</span> value = builder.build();<a name="line.166"></a> -<span class="sourceLineNo">167</span> } else {<a name="line.167"></a> -<span class="sourceLineNo">168</span> value = null;<a name="line.168"></a> -<span class="sourceLineNo">169</span> }<a name="line.169"></a> -<span class="sourceLineNo">170</span> CellScanner cellBlockScanner;<a name="line.170"></a> -<span class="sourceLineNo">171</span> if (responseHeader.hasCellBlockMeta()) {<a name="line.171"></a> -<span class="sourceLineNo">172</span> int size = responseHeader.getCellBlockMeta().getLength();<a name="line.172"></a> -<span class="sourceLineNo">173</span> // Maybe we could read directly from the ByteBuf.<a name="line.173"></a> -<span class="sourceLineNo">174</span> // The problem here is that we do not know when to release it.<a name="line.174"></a> -<span class="sourceLineNo">175</span> byte[] cellBlock = new byte[size];<a name="line.175"></a> -<span class="sourceLineNo">176</span> buf.readBytes(cellBlock);<a name="line.176"></a> -<span class="sourceLineNo">177</span> cellBlockScanner = cellBlockBuilder.createCellScanner(this.codec, this.compressor, cellBlock);<a name="line.177"></a> -<span class="sourceLineNo">178</span> } else {<a name="line.178"></a> -<span class="sourceLineNo">179</span> cellBlockScanner = null;<a name="line.179"></a> -<span class="sourceLineNo">180</span> }<a name="line.180"></a> -<span class="sourceLineNo">181</span> call.setResponse(value, cellBlockScanner);<a name="line.181"></a> -<span class="sourceLineNo">182</span> }<a name="line.182"></a> -<span class="sourceLineNo">183</span><a name="line.183"></a> -<span class="sourceLineNo">184</span> @Override<a name="line.184"></a> -<span class="sourceLineNo">185</span> public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {<a name="line.185"></a> -<span class="sourceLineNo">186</span> if (msg instanceof ByteBuf) {<a name="line.186"></a> -<span class="sourceLineNo">187</span> ByteBuf buf = (ByteBuf) msg;<a name="line.187"></a> -<span class="sourceLineNo">188</span> try {<a name="line.188"></a> -<span class="sourceLineNo">189</span> readResponse(ctx, buf);<a name="line.189"></a> -<span class="sourceLineNo">190</span> } finally {<a name="line.190"></a> -<span class="sourceLineNo">191</span> buf.release();<a name="line.191"></a> -<span class="sourceLineNo">192</span> }<a name="line.192"></a> -<span class="sourceLineNo">193</span> } else {<a name="line.193"></a> -<span class="sourceLineNo">194</span> super.channelRead(ctx, msg);<a name="line.194"></a> -<span class="sourceLineNo">195</span> }<a name="line.195"></a> -<span class="sourceLineNo">196</span> }<a name="line.196"></a> -<span class="sourceLineNo">197</span><a name="line.197"></a> -<span class="sourceLineNo">198</span> private void cleanupCalls(ChannelHandlerContext ctx, IOException error) {<a name="line.198"></a> -<span class="sourceLineNo">199</span> for (Call call : id2Call.values()) {<a name="line.199"></a> -<span class="sourceLineNo">200</span> call.setException(error);<a name="line.200"></a> -<span class="sourceLineNo">201</span> }<a name="line.201"></a> -<span class="sourceLineNo">202</span> id2Call.clear();<a name="line.202"></a> -<span class="sourceLineNo">203</span> }<a name="line.203"></a> -<span class="sourceLineNo">204</span><a name="line.204"></a> -<span class="sourceLineNo">205</span> @Override<a name="line.205"></a> -<span class="sourceLineNo">206</span> public void channelInactive(ChannelHandlerContext ctx) throws Exception {<a name="line.206"></a> -<span class="sourceLineNo">207</span> if (!id2Call.isEmpty()) {<a name="line.207"></a> -<span class="sourceLineNo">208</span> cleanupCalls(ctx, new IOException("Connection closed"));<a name="line.208"></a> -<span class="sourceLineNo">209</span> }<a name="line.209"></a> -<span class="sourceLineNo">210</span> conn.shutdown();<a name="line.210"></a> -<span class="sourceLineNo">211</span> ctx.fireChannelInactive();<a name="line.211"></a> -<span class="sourceLineNo">212</span> }<a name="line.212"></a> -<span class="sourceLineNo">213</span><a name="line.213"></a> -<span class="sourceLineNo">214</span> @Override<a name="line.214"></a> -<span class="sourceLineNo">215</span> public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {<a name="line.215"></a> -<span class="sourceLineNo">216</span> if (!id2Call.isEmpty()) {<a name="line.216"></a> -<span class="sourceLineNo">217</span> cleanupCalls(ctx, IPCUtil.toIOE(cause));<a name="line.217"></a> -<span class="sourceLineNo">218</span> }<a name="line.218"></a> -<span class="sourceLineNo">219</span> conn.shutdown();<a name="line.219"></a> -<span class="sourceLineNo">220</span> }<a name="line.220"></a> -<span class="sourceLineNo">221</span><a name="line.221"></a> -<span class="sourceLineNo">222</span> @Override<a name="line.222"></a> -<span class="sourceLineNo">223</span> public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception {<a name="line.223"></a> -<span class="sourceLineNo">224</span> if (evt instanceof IdleStateEvent) {<a name="line.224"></a> -<span class="sourceLineNo">225</span> IdleStateEvent idleEvt = (IdleStateEvent) evt;<a name="line.225"></a> -<span class="sourceLineNo">226</span> switch (idleEvt.state()) {<a name="line.226"></a> -<span class="sourceLineNo">227</span> case WRITER_IDLE:<a name="line.227"></a> -<span class="sourceLineNo">228</span> if (id2Call.isEmpty()) {<a name="line.228"></a> -<span class="sourceLineNo">229</span> if (LOG.isTraceEnabled()) {<a name="line.229"></a> -<span class="sourceLineNo">230</span> LOG.trace("shutdown connection to " + conn.remoteId().address<a name="line.230"></a> -<span class="sourceLineNo">231</span> + " because idle for a long time");<a name="line.231"></a> -<span class="sourceLineNo">232</span> }<a name="line.232"></a> -<span class="sourceLineNo">233</span> // It may happen that there are still some pending calls in the event loop queue and<a name="line.233"></a> -<span class="sourceLineNo">234</span> // they will get a closed channel exception. But this is not a big deal as it rarely<a name="line.234"></a> -<span class="sourceLineNo">235</span> // rarely happens and the upper layer could retry immediately.<a name="line.235"></a> -<span class="sourceLineNo">236</span> conn.shutdown();<a name="line.236"></a> -<span class="sourceLineNo">237</span> }<a name="line.237"></a> -<span class="sourceLineNo">238</span> break;<a name="line.238"></a> -<span class="sourceLineNo">239</span> default:<a name="line.239"></a> -<span class="sourceLineNo">240</span> LOG.warn("Unrecognized idle state " + idleEvt.state());<a name="line.240"></a> -<span class="sourceLineNo">241</span> break;<a name="line.241"></a> -<span class="sourceLineNo">242</span> }<a name="line.242"></a> -<span class="sourceLineNo">243</span> } else if (evt instanceof CallEvent) {<a name="line.243"></a> -<span class="sourceLineNo">244</span> // just remove the call for now until we add other call event other than timeout and cancel.<a name="line.244"></a> -<span class="sourceLineNo">245</span> id2Call.remove(((CallEvent) evt).call.id);<a name="line.245"></a> -<span class="sourceLineNo">246</span> } else {<a name="line.246"></a> -<span class="sourceLineNo">247</span> ctx.fireUserEventTriggered(evt);<a name="line.247"></a> -<span class="sourceLineNo">248</span> }<a name="line.248"></a> -<span class="sourceLineNo">249</span> }<a name="line.249"></a> -<span class="sourceLineNo">250</span>}<a name="line.250"></a> +<span class="sourceLineNo">094</span> try (ByteBufOutputStream bbos = new ByteBufOutputStream(buf)) {<a name="line.94"></a> +<span class="sourceLineNo">095</span> requestHeader.writeDelimitedTo(bbos);<a name="line.95"></a> +<span class="sourceLineNo">096</span> if (call.param != null) {<a name="line.96"></a> +<span class="sourceLineNo">097</span> call.param.writeDelimitedTo(bbos);<a name="line.97"></a> +<span class="sourceLineNo">098</span> }<a name="line.98"></a> +<span class="sourceLineNo">099</span> if (cellBlock != null) {<a name="line.99"></a> +<span class="sourceLineNo">100</span> ChannelPromise withoutCellBlockPromise = ctx.newPromise();<a name="line.100"></a> +<span class="sourceLineNo">101</span> ctx.write(buf, withoutCellBlockPromise);<a name="line.101"></a> +<span class="sourceLineNo">102</span> ChannelPromise cellBlockPromise = ctx.newPromise();<a name="line.102"></a> +<span class="sourceLineNo">103</span> ctx.write(cellBlock, cellBlockPromise);<a name="line.103"></a> +<span class="sourceLineNo">104</span> PromiseCombiner combiner = new PromiseCombiner();<a name="line.104"></a> +<span class="sourceLineNo">105</span> combiner.addAll(withoutCellBlockPromise, cellBlockPromise);<a name="line.105"></a> +<span class="sourceLineNo">106</span> combiner.finish(promise);<a name="line.106"></a> +<span class="sourceLineNo">107</span> } else {<a name="line.107"></a> +<span class="sourceLineNo">108</span> ctx.write(buf, promise);<a name="line.108"></a> +<span class="sourceLineNo">109</span> }<a name="line.109"></a> +<span class="sourceLineNo">110</span> }<a name="line.110"></a> +<span class="sourceLineNo">111</span> }<a name="line.111"></a> +<span class="sourceLineNo">112</span><a name="line.112"></a> +<span class="sourceLineNo">113</span> @Override<a name="line.113"></a> +<span class="sourceLineNo">114</span> public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise)<a name="line.114"></a> +<span class="sourceLineNo">115</span> throws Exception {<a name="line.115"></a> +<span class="sourceLineNo">116</span> if (msg instanceof Call) {<a name="line.116"></a> +<span class="sourceLineNo">117</span> writeRequest(ctx, (Call) msg, promise);<a name="line.117"></a> +<span class="sourceLineNo">118</span> } else {<a name="line.118"></a> +<span class="sourceLineNo">119</span> ctx.write(msg, promise);<a name="line.119"></a> +<span class="sourceLineNo">120</span> }<a name="line.120"></a> +<span class="sourceLineNo">121</span> }<a name="line.121"></a> +<span class="sourceLineNo">122</span><a name="line.122"></a> +<span class="sourceLineNo">123</span> private void readResponse(ChannelHandlerContext ctx, ByteBuf buf) throws IOException {<a name="line.123"></a> +<span class="sourceLineNo">124</span> int totalSize = buf.readInt();<a name="line.124"></a> +<span class="sourceLineNo">125</span> ByteBufInputStream in = new ByteBufInputStream(buf);<a name="line.125"></a> +<span class="sourceLineNo">126</span> ResponseHeader responseHeader = ResponseHeader.parseDelimitedFrom(in);<a name="line.126"></a> +<span class="sourceLineNo">127</span> int id = responseHeader.getCallId();<a name="line.127"></a> +<span class="sourceLineNo">128</span> if (LOG.isTraceEnabled()) {<a name="line.128"></a> +<span class="sourceLineNo">129</span> LOG.trace("got response header " + TextFormat.shortDebugString(responseHeader)<a name="line.129"></a> +<span class="sourceLineNo">130</span> + ", totalSize: " + totalSize + " bytes");<a name="line.130"></a> +<span class="sourceLineNo">131</span> }<a name="line.131"></a> +<span class="sourceLineNo">132</span> RemoteException remoteExc;<a name="line.132"></a> +<span class="sourceLineNo">133</span> if (responseHeader.hasException()) {<a name="line.133"></a> +<span class="sourceLineNo">134</span> ExceptionResponse exceptionResponse = responseHeader.getException();<a name="line.134"></a> +<span class="sourceLineNo">135</span> remoteExc = IPCUtil.createRemoteException(exceptionResponse);<a name="line.135"></a> +<span class="sourceLineNo">136</span> if (IPCUtil.isFatalConnectionException(exceptionResponse)) {<a name="line.136"></a> +<span class="sourceLineNo">137</span> // Here we will cleanup all calls so do not need to fall back, just return.<a name="line.137"></a> +<span class="sourceLineNo">138</span> exceptionCaught(ctx, remoteExc);<a name="line.138"></a> +<span class="sourceLineNo">139</span> return;<a name="line.139"></a> +<span class="sourceLineNo">140</span> }<a name="line.140"></a> +<span class="sourceLineNo">141</span> } else {<a name="line.141"></a> +<span class="sourceLineNo">142</span> remoteExc = null;<a name="line.142"></a> +<span class="sourceLineNo">143</span> }<a name="line.143"></a> +<span class="sourceLineNo">144</span> Call call = id2Call.remove(id);<a name="line.144"></a> +<span class="sourceLineNo">145</span> if (call == null) {<a name="line.145"></a> +<span class="sourceLineNo">146</span> // So we got a response for which we have no corresponding 'call' here on the client-side.<a name="line.146"></a> +<span class="sourceLineNo">147</span> // We probably timed out waiting, cleaned up all references, and now the server decides<a name="line.147"></a> +<span class="sourceLineNo">148</span> // to return a response. There is nothing we can do w/ the response at this stage. Clean<a name="line.148"></a> +<span class="sourceLineNo">149</span> // out the wire of the response so its out of the way and we can get other responses on<a name="line.149"></a> +<span class="sourceLineNo">150</span> // this connection.<a name="line.150"></a> +<span class="sourceLineNo">151</span> int readSoFar = IPCUtil.getTotalSizeWhenWrittenDelimited(responseHeader);<a name="line.151"></a> +<span class="sourceLineNo">152</span> int whatIsLeftToRead = totalSize - readSoFar;<a name="line.152"></a> +<span class="sourceLineNo">153</span> if (LOG.isDebugEnabled()) {<a name="line.153"></a> +<span class="sourceLineNo">154</span> LOG.debug("Unknown callId: " + id + ", skipping over this response of " + whatIsLeftToRead<a name="line.154"></a> +<span class="sourceLineNo">155</span> + " bytes");<a name="line.155"></a> +<span class="sourceLineNo">156</span> }<a name="line.156"></a> +<span class="sourceLineNo">157</span> return;<a name="line.157"></a> +<span class="sourceLineNo">158</span> }<a name="line.158"></a> +<span class="sourceLineNo">159</span> if (remoteExc != null) {<a name="line.159"></a> +<span class="sourceLineNo">160</span> call.setException(remoteExc);<a name="line.160"></a> +<span class="sourceLineNo">161</span> return;<a name="line.161"></a> +<span class="sourceLineNo">162</span> }<a name="line.162"></a> +<span class="sourceLineNo">163</span> Message value;<a name="line.163"></a> +<span class="sourceLineNo">164</span> if (call.responseDefaultType != null) {<a name="line.164"></a> +<span class="sourceLineNo">165</span> Builder builder = call.responseDefaultType.newBuilderForType();<a name="line.165"></a> +<span class="sourceLineNo">166</span> builder.mergeDelimitedFrom(in);<a name="line.166"></a> +<span class="sourceLineNo">167</span> value = builder.build();<a name="line.167"></a> +<span class="sourceLineNo">168</span> } else {<a name="line.168"></a> +<span class="sourceLineNo">169</span> value = null;<a name="line.169"></a> +<span class="sourceLineNo">170</span> }<a name="line.170"></a> +<span class="sourceLineNo">171</span> CellScanner cellBlockScanner;<a name="line.171"></a> +<span class="sourceLineNo">172</span> if (responseHeader.hasCellBlockMeta()) {<a name="line.172"></a> +<span class="sourceLineNo">173</span> int size = responseHeader.getCellBlockMeta().getLength();<a name="line.173"></a> +<span class="sourceLineNo">174</span> // Maybe we could read directly from the ByteBuf.<a name="line.174"></a> +<span class="sourceLineNo">175</span> // The problem here is that we do not know when to release it.<a name="line.175"></a> +<span class="sourceLineNo">176</span> byte[] cellBlock = new byte[size];<a name="line.176"></a> +<span class="sourceLineNo">177</span> buf.readBytes(cellBlock);<a name="line.177"></a> +<span class="sourceLineNo">178</span> cellBlockScanner = cellBlockBuilder.createCellScanner(this.codec, this.compressor, cellBlock);<a name="line.178"></a> +<span class="sourceLineNo">179</span> } else {<a name="line.179"></a> +<span class="sourceLineNo">180</span> cellBlockScanner = null;<a name="line.180"></a> +<span class="sourceLineNo">181</span> }<a name="line.181"></a> +<span class="sourceLineNo">182</span> call.setResponse(value, cellBlockScanner);<a name="line.182"></a> +<span class="sourceLineNo">183</span> }<a name="line.183"></a> +<span class="sourceLineNo">184</span><a name="line.184"></a> +<span class="sourceLineNo">185</span> @Override<a name="line.185"></a> +<span class="sourceLineNo">186</span> public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {<a name="line.186"></a> +<span class="sourceLineNo">187</span> if (msg instanceof ByteBuf) {<a name="line.187"></a> +<span class="sourceLineNo">188</span> ByteBuf buf = (ByteBuf) msg;<a name="line.188"></a> +<span class="sourceLineNo">189</span> try {<a name="line.189"></a> +<span class="sourceLineNo">190</span> readResponse(ctx, buf);<a name="line.190"></a> +<span class="sourceLineNo">191</span> } finally {<a name="line.191"></a> +<span class="sourceLineNo">192</span> buf.release();<a name="line.192"></a> +<span class="sourceLineNo">193</span> }<a name="line.193"></a> +<span class="sourceLineNo">194</span> } else {<a name="line.194"></a> +<span class="sourceLineNo">195</span> super.channelRead(ctx, msg);<a name="line.195"></a> +<span class="sourceLineNo">196</span> }<a name="line.196"></a> +<span class="sourceLineNo">197</span> }<a name="line.197"></a> +<span class="sourceLineNo">198</span><a name="line.198"></a> +<span class="sourceLineNo">199</span> private void cleanupCalls(ChannelHandlerContext ctx, IOException error) {<a name="line.199"></a> +<span class="sourceLineNo">200</span> for (Call call : id2Call.values()) {<a name="line.200"></a> +<span class="sourceLineNo">201</span> call.setException(error);<a name="line.201"></a> +<span class="sourceLineNo">202</span> }<a name="line.202"></a> +<span class="sourceLineNo">203</span> id2Call.clear();<a name="line.203"></a> +<span class="sourceLineNo">204</span> }<a name="line.204"></a> +<span class="sourceLineNo">205</span><a name="line.205"></a> +<span class="sourceLineNo">206</span> @Override<a name="line.206"></a> +<span class="sourceLineNo">207</span> public void channelInactive(ChannelHandlerContext ctx) throws Exception {<a name="line.207"></a> +<span class="sourceLineNo">208</span> if (!id2Call.isEmpty()) {<a name="line.208"></a> +<span class="sourceLineNo">209</span> cleanupCalls(ctx, new IOException("Connection closed"));<a name="line.209"></a> +<span class="sourceLineNo">210</span> }<a name="line.210"></a> +<span class="sourceLineNo">211</span> conn.shutdown();<a name="line.211"></a> +<span class="sourceLineNo">212</span> ctx.fireChannelInactive();<a name="line.212"></a> +<span class="sourceLineNo">213</span> }<a name="line.213"></a> +<span class="sourceLineNo">214</span><a name="line.214"></a> +<span class="sourceLineNo">215</span> @Override<a name="line.215"></a> +<span class="sourceLineNo">216</span> public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {<a name="line.216"></a> +<span class="sourceLineNo">217</span> if (!id2Call.isEmpty()) {<a name="line.217"></a> +<span class="sourceLineNo">218</span> cleanupCalls(ctx, IPCUtil.toIOE(cause));<a name="line.218"></a> +<span class="sourceLineNo">219</span> }<a name="line.219"></a> +<span class="sourceLineNo">220</span> conn.shutdown();<a name="line.220"></a> +<span class="sourceLineNo">221</span> }<a name="line.221"></a> +<span class="sourceLineNo">222</span><a name="line.222"></a> +<span class="sourceLineNo">223</span> @Override<a name="line.223"></a> +<span class="sourceLineNo">224</span> public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception {<a name="line.224"></a> +<span class="sourceLineNo">225</span> if (evt instanceof IdleStateEvent) {<a name="line.225"></a> +<span class="sourceLineNo">226</span> IdleStateEvent idleEvt = (IdleStateEvent) evt;<a name="line.226"></a> +<span class="sourceLineNo">227</span> switch (idleEvt.state()) {<a name="line.227"></a> +<span class="sourceLineNo">228</span> case WRITER_IDLE:<a name="line.228"></a> +<span class="sourceLineNo">229</span> if (id2Call.isEmpty()) {<a name="line.229"></a> +<span class="sourceLineNo">230</span> if (LOG.isTraceEnabled()) {<a name="line.230"></a> +<span class="sourceLineNo">231</span> LOG.trace("shutdown connection to " + conn.remoteId().address<a name="line.231"></a> +<span class="sourceLineNo">232</span> + " because idle for a long time");<a name="line.232"></a> +<span class="sourceLineNo">233</span> }<a name="line.233"></a> +<span class="sourceLineNo">234</span> // It may happen that there are still some pending calls in the event loop queue and<a name="line.234"></a> +<span class="sourceLineNo">235</span> // they will get a closed channel exception. But this is not a big deal as it rarely<a name="line.235"></a> +<span class="sourceLineNo">236</span> // rarely happens and the upper layer could retry immediately.<a name="line.236"></a> +<span class="sourceLineNo">237</span> conn.shutdown();<a name="line.237"></a> +<span class="sourceLineNo">238</span> }<a name="line.238"></a> +<span class="sourceLineNo">239</span> break;<a name="line.239"></a> +<span class="sourceLineNo">240</span> default:<a name="line.240"></a> +<span class="sourceLineNo">241</span> LOG.warn("Unrecognized idle state " + idleEvt.state());<a name="line.241"></a> +<span class="sourceLineNo">242</span> break;<a name="line.242"></a> +<span class="sourceLineNo">243</span> }<a name="line.243"></a> +<span class="sourceLineNo">244</span> } else if (evt instanceof CallEvent) {<a name="line.244"></a> +<span class="sourceLineNo">245</span> // just remove the call for now until we add other call event other than timeout and cancel.<a name="line.245"></a> +<span class="sourceLineNo">246</span> id2Call.remove(((CallEvent) evt).call.id);<a name="line.246"></a> +<span class="sourceLineNo">247</span> } else {<a name="line.247"></a> +<span class="sourceLineNo">248</span> ctx.fireUserEventTriggered(evt);<a name="line.248"></a> +<span class="sourceLineNo">249</span> }<a name="line.249"></a> +<span class="sourceLineNo">250</span> }<a name="line.250"></a> +<span class="sourceLineNo">251</span>}<a name="line.251"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterDumpServlet.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterDumpServlet.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterDumpServlet.html index e3d7c17..321cae3 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterDumpServlet.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterDumpServlet.html @@ -62,89 +62,90 @@ <span class="sourceLineNo">054</span><a name="line.54"></a> <span class="sourceLineNo">055</span> response.setContentType("text/plain");<a name="line.55"></a> <span class="sourceLineNo">056</span> OutputStream os = response.getOutputStream();<a name="line.56"></a> -<span class="sourceLineNo">057</span> PrintWriter out = new PrintWriter(os);<a name="line.57"></a> +<span class="sourceLineNo">057</span> try (PrintWriter out = new PrintWriter(os)) {<a name="line.57"></a> <span class="sourceLineNo">058</span><a name="line.58"></a> -<span class="sourceLineNo">059</span> out.println("Master status for " + master.getServerName()<a name="line.59"></a> +<span class="sourceLineNo">059</span> out.println("Master status for " + master.getServerName()<a name="line.59"></a> <span class="sourceLineNo">060</span> + " as of " + new Date());<a name="line.60"></a> <span class="sourceLineNo">061</span><a name="line.61"></a> -<span class="sourceLineNo">062</span> out.println("\n\nVersion Info:");<a name="line.62"></a> -<span class="sourceLineNo">063</span> out.println(LINE);<a name="line.63"></a> -<span class="sourceLineNo">064</span> dumpVersionInfo(out);<a name="line.64"></a> +<span class="sourceLineNo">062</span> out.println("\n\nVersion Info:");<a name="line.62"></a> +<span class="sourceLineNo">063</span> out.println(LINE);<a name="line.63"></a> +<span class="sourceLineNo">064</span> dumpVersionInfo(out);<a name="line.64"></a> <span class="sourceLineNo">065</span><a name="line.65"></a> -<span class="sourceLineNo">066</span> out.println("\n\nTasks:");<a name="line.66"></a> -<span class="sourceLineNo">067</span> out.println(LINE);<a name="line.67"></a> -<span class="sourceLineNo">068</span> TaskMonitor.get().dumpAsText(out);<a name="line.68"></a> +<span class="sourceLineNo">066</span> out.println("\n\nTasks:");<a name="line.66"></a> +<span class="sourceLineNo">067</span> out.println(LINE);<a name="line.67"></a> +<span class="sourceLineNo">068</span> TaskMonitor.get().dumpAsText(out);<a name="line.68"></a> <span class="sourceLineNo">069</span><a name="line.69"></a> -<span class="sourceLineNo">070</span> out.println("\n\nServers:");<a name="line.70"></a> -<span class="sourceLineNo">071</span> out.println(LINE);<a name="line.71"></a> -<span class="sourceLineNo">072</span> dumpServers(master, out);<a name="line.72"></a> +<span class="sourceLineNo">070</span> out.println("\n\nServers:");<a name="line.70"></a> +<span class="sourceLineNo">071</span> out.println(LINE);<a name="line.71"></a> +<span class="sourceLineNo">072</span> dumpServers(master, out);<a name="line.72"></a> <span class="sourceLineNo">073</span><a name="line.73"></a> -<span class="sourceLineNo">074</span> out.println("\n\nRegions-in-transition:");<a name="line.74"></a> -<span class="sourceLineNo">075</span> out.println(LINE);<a name="line.75"></a> -<span class="sourceLineNo">076</span> dumpRIT(master, out);<a name="line.76"></a> +<span class="sourceLineNo">074</span> out.println("\n\nRegions-in-transition:");<a name="line.74"></a> +<span class="sourceLineNo">075</span> out.println(LINE);<a name="line.75"></a> +<span class="sourceLineNo">076</span> dumpRIT(master, out);<a name="line.76"></a> <span class="sourceLineNo">077</span><a name="line.77"></a> -<span class="sourceLineNo">078</span> out.println("\n\nExecutors:");<a name="line.78"></a> -<span class="sourceLineNo">079</span> out.println(LINE);<a name="line.79"></a> -<span class="sourceLineNo">080</span> dumpExecutors(master.getExecutorService(), out);<a name="line.80"></a> +<span class="sourceLineNo">078</span> out.println("\n\nExecutors:");<a name="line.78"></a> +<span class="sourceLineNo">079</span> out.println(LINE);<a name="line.79"></a> +<span class="sourceLineNo">080</span> dumpExecutors(master.getExecutorService(), out);<a name="line.80"></a> <span class="sourceLineNo">081</span><a name="line.81"></a> -<span class="sourceLineNo">082</span> out.println("\n\nStacks:");<a name="line.82"></a> -<span class="sourceLineNo">083</span> out.println(LINE);<a name="line.83"></a> -<span class="sourceLineNo">084</span> out.flush();<a name="line.84"></a> -<span class="sourceLineNo">085</span> PrintStream ps = new PrintStream(response.getOutputStream(), false, "UTF-8");<a name="line.85"></a> -<span class="sourceLineNo">086</span> Threads.printThreadInfo(ps, "");<a name="line.86"></a> -<span class="sourceLineNo">087</span> ps.flush();<a name="line.87"></a> +<span class="sourceLineNo">082</span> out.println("\n\nStacks:");<a name="line.82"></a> +<span class="sourceLineNo">083</span> out.println(LINE);<a name="line.83"></a> +<span class="sourceLineNo">084</span> out.flush();<a name="line.84"></a> +<span class="sourceLineNo">085</span> PrintStream ps = new PrintStream(response.getOutputStream(), false, "UTF-8");<a name="line.85"></a> +<span class="sourceLineNo">086</span> Threads.printThreadInfo(ps, "");<a name="line.86"></a> +<span class="sourceLineNo">087</span> ps.flush();<a name="line.87"></a> <span class="sourceLineNo">088</span><a name="line.88"></a> -<span class="sourceLineNo">089</span> out.println("\n\nMaster configuration:");<a name="line.89"></a> -<span class="sourceLineNo">090</span> out.println(LINE);<a name="line.90"></a> -<span class="sourceLineNo">091</span> Configuration conf = master.getConfiguration();<a name="line.91"></a> -<span class="sourceLineNo">092</span> out.flush();<a name="line.92"></a> -<span class="sourceLineNo">093</span> conf.writeXml(os);<a name="line.93"></a> -<span class="sourceLineNo">094</span> os.flush();<a name="line.94"></a> +<span class="sourceLineNo">089</span> out.println("\n\nMaster configuration:");<a name="line.89"></a> +<span class="sourceLineNo">090</span> out.println(LINE);<a name="line.90"></a> +<span class="sourceLineNo">091</span> Configuration conf = master.getConfiguration();<a name="line.91"></a> +<span class="sourceLineNo">092</span> out.flush();<a name="line.92"></a> +<span class="sourceLineNo">093</span> conf.writeXml(os);<a name="line.93"></a> +<span class="sourceLineNo">094</span> os.flush();<a name="line.94"></a> <span class="sourceLineNo">095</span><a name="line.95"></a> -<span class="sourceLineNo">096</span> out.println("\n\nRecent regionserver aborts:");<a name="line.96"></a> -<span class="sourceLineNo">097</span> out.println(LINE);<a name="line.97"></a> -<span class="sourceLineNo">098</span> master.getRegionServerFatalLogBuffer().dumpTo(out);<a name="line.98"></a> +<span class="sourceLineNo">096</span> out.println("\n\nRecent regionserver aborts:");<a name="line.96"></a> +<span class="sourceLineNo">097</span> out.println(LINE);<a name="line.97"></a> +<span class="sourceLineNo">098</span> master.getRegionServerFatalLogBuffer().dumpTo(out);<a name="line.98"></a> <span class="sourceLineNo">099</span><a name="line.99"></a> -<span class="sourceLineNo">100</span> out.println("\n\nLogs");<a name="line.100"></a> -<span class="sourceLineNo">101</span> out.println(LINE);<a name="line.101"></a> -<span class="sourceLineNo">102</span> long tailKb = getTailKbParam(request);<a name="line.102"></a> -<span class="sourceLineNo">103</span> LogMonitoring.dumpTailOfLogs(out, tailKb);<a name="line.103"></a> +<span class="sourceLineNo">100</span> out.println("\n\nLogs");<a name="line.100"></a> +<span class="sourceLineNo">101</span> out.println(LINE);<a name="line.101"></a> +<span class="sourceLineNo">102</span> long tailKb = getTailKbParam(request);<a name="line.102"></a> +<span class="sourceLineNo">103</span> LogMonitoring.dumpTailOfLogs(out, tailKb);<a name="line.103"></a> <span class="sourceLineNo">104</span><a name="line.104"></a> -<span class="sourceLineNo">105</span> out.println("\n\nRS Queue:");<a name="line.105"></a> -<span class="sourceLineNo">106</span> out.println(LINE);<a name="line.106"></a> -<span class="sourceLineNo">107</span> if(isShowQueueDump(conf)) {<a name="line.107"></a> -<span class="sourceLineNo">108</span> RSDumpServlet.dumpQueue(master, out);<a name="line.108"></a> -<span class="sourceLineNo">109</span> }<a name="line.109"></a> -<span class="sourceLineNo">110</span> out.flush();<a name="line.110"></a> -<span class="sourceLineNo">111</span> }<a name="line.111"></a> -<span class="sourceLineNo">112</span><a name="line.112"></a> +<span class="sourceLineNo">105</span> out.println("\n\nRS Queue:");<a name="line.105"></a> +<span class="sourceLineNo">106</span> out.println(LINE);<a name="line.106"></a> +<span class="sourceLineNo">107</span> if (isShowQueueDump(conf)) {<a name="line.107"></a> +<span class="sourceLineNo">108</span> RSDumpServlet.dumpQueue(master, out);<a name="line.108"></a> +<span class="sourceLineNo">109</span> }<a name="line.109"></a> +<span class="sourceLineNo">110</span> out.flush();<a name="line.110"></a> +<span class="sourceLineNo">111</span> }<a name="line.111"></a> +<span class="sourceLineNo">112</span> }<a name="line.112"></a> <span class="sourceLineNo">113</span><a name="line.113"></a> -<span class="sourceLineNo">114</span> private void dumpRIT(HMaster master, PrintWriter out) {<a name="line.114"></a> -<span class="sourceLineNo">115</span> AssignmentManager am = master.getAssignmentManager();<a name="line.115"></a> -<span class="sourceLineNo">116</span> if (am == null) {<a name="line.116"></a> -<span class="sourceLineNo">117</span> out.println("AssignmentManager is not initialized");<a name="line.117"></a> -<span class="sourceLineNo">118</span> return;<a name="line.118"></a> -<span class="sourceLineNo">119</span> }<a name="line.119"></a> -<span class="sourceLineNo">120</span><a name="line.120"></a> -<span class="sourceLineNo">121</span> for (RegionStateNode rs : am.getRegionsInTransition()) {<a name="line.121"></a> -<span class="sourceLineNo">122</span> String rid = rs.getRegionInfo().getEncodedName();<a name="line.122"></a> -<span class="sourceLineNo">123</span> out.println("Region " + rid + ": " + rs.toDescriptiveString());<a name="line.123"></a> -<span class="sourceLineNo">124</span> }<a name="line.124"></a> -<span class="sourceLineNo">125</span> }<a name="line.125"></a> -<span class="sourceLineNo">126</span><a name="line.126"></a> -<span class="sourceLineNo">127</span> private void dumpServers(HMaster master, PrintWriter out) {<a name="line.127"></a> -<span class="sourceLineNo">128</span> ServerManager sm = master.getServerManager();<a name="line.128"></a> -<span class="sourceLineNo">129</span> if (sm == null) {<a name="line.129"></a> -<span class="sourceLineNo">130</span> out.println("ServerManager is not initialized");<a name="line.130"></a> -<span class="sourceLineNo">131</span> return;<a name="line.131"></a> -<span class="sourceLineNo">132</span> }<a name="line.132"></a> -<span class="sourceLineNo">133</span><a name="line.133"></a> -<span class="sourceLineNo">134</span> Map<ServerName, ServerLoad> servers = sm.getOnlineServers();<a name="line.134"></a> -<span class="sourceLineNo">135</span> for (Map.Entry<ServerName, ServerLoad> e : servers.entrySet()) {<a name="line.135"></a> -<span class="sourceLineNo">136</span> out.println(e.getKey() + ": " + e.getValue());<a name="line.136"></a> -<span class="sourceLineNo">137</span> }<a name="line.137"></a> -<span class="sourceLineNo">138</span> }<a name="line.138"></a> -<span class="sourceLineNo">139</span>}<a name="line.139"></a> +<span class="sourceLineNo">114</span><a name="line.114"></a> +<span class="sourceLineNo">115</span> private void dumpRIT(HMaster master, PrintWriter out) {<a name="line.115"></a> +<span class="sourceLineNo">116</span> AssignmentManager am = master.getAssignmentManager();<a name="line.116"></a> +<span class="sourceLineNo">117</span> if (am == null) {<a name="line.117"></a> +<span class="sourceLineNo">118</span> out.println("AssignmentManager is not initialized");<a name="line.118"></a> +<span class="sourceLineNo">119</span> return;<a name="line.119"></a> +<span class="sourceLineNo">120</span> }<a name="line.120"></a> +<span class="sourceLineNo">121</span><a name="line.121"></a> +<span class="sourceLineNo">122</span> for (RegionStateNode rs : am.getRegionsInTransition()) {<a name="line.122"></a> +<span class="sourceLineNo">123</span> String rid = rs.getRegionInfo().getEncodedName();<a name="line.123"></a> +<span class="sourceLineNo">124</span> out.println("Region " + rid + ": " + rs.toDescriptiveString());<a name="line.124"></a> +<span class="sourceLineNo">125</span> }<a name="line.125"></a> +<span class="sourceLineNo">126</span> }<a name="line.126"></a> +<span class="sourceLineNo">127</span><a name="line.127"></a> +<span class="sourceLineNo">128</span> private void dumpServers(HMaster master, PrintWriter out) {<a name="line.128"></a> +<span class="sourceLineNo">129</span> ServerManager sm = master.getServerManager();<a name="line.129"></a> +<span class="sourceLineNo">130</span> if (sm == null) {<a name="line.130"></a> +<span class="sourceLineNo">131</span> out.println("ServerManager is not initialized");<a name="line.131"></a> +<span class="sourceLineNo">132</span> return;<a name="line.132"></a> +<span class="sourceLineNo">133</span> }<a name="line.133"></a> +<span class="sourceLineNo">134</span><a name="line.134"></a> +<span class="sourceLineNo">135</span> Map<ServerName, ServerLoad> servers = sm.getOnlineServers();<a name="line.135"></a> +<span class="sourceLineNo">136</span> for (Map.Entry<ServerName, ServerLoad> e : servers.entrySet()) {<a name="line.136"></a> +<span class="sourceLineNo">137</span> out.println(e.getKey() + ": " + e.getValue());<a name="line.137"></a> +<span class="sourceLineNo">138</span> }<a name="line.138"></a> +<span class="sourceLineNo">139</span> }<a name="line.139"></a> +<span class="sourceLineNo">140</span>}<a name="line.140"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterRpcServices.BalanceSwitchMode.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterRpcServices.BalanceSwitchMode.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterRpcServices.BalanceSwitchMode.html index 9f31bd3..791ba09 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterRpcServices.BalanceSwitchMode.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterRpcServices.BalanceSwitchMode.html @@ -1299,7 +1299,7 @@ <span class="sourceLineNo">1291</span> throws ServiceException {<a name="line.1291"></a> <span class="sourceLineNo">1292</span> try {<a name="line.1292"></a> <span class="sourceLineNo">1293</span> master.checkInitialized();<a name="line.1293"></a> -<span class="sourceLineNo">1294</span> Boolean result = master.getHFileCleaner().runCleaner() && master.getLogCleaner().runCleaner();<a name="line.1294"></a> +<span class="sourceLineNo">1294</span> boolean result = master.getHFileCleaner().runCleaner() && master.getLogCleaner().runCleaner();<a name="line.1294"></a> <span class="sourceLineNo">1295</span> return ResponseConverter.buildRunCleanerChoreResponse(result);<a name="line.1295"></a> <span class="sourceLineNo">1296</span> } catch (IOException ioe) {<a name="line.1296"></a> <span class="sourceLineNo">1297</span> throw new ServiceException(ioe);<a name="line.1297"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/21766f4a/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterRpcServices.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterRpcServices.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterRpcServices.html index 9f31bd3..791ba09 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterRpcServices.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/MasterRpcServices.html @@ -1299,7 +1299,7 @@ <span class="sourceLineNo">1291</span> throws ServiceException {<a name="line.1291"></a> <span class="sourceLineNo">1292</span> try {<a name="line.1292"></a> <span class="sourceLineNo">1293</span> master.checkInitialized();<a name="line.1293"></a> -<span class="sourceLineNo">1294</span> Boolean result = master.getHFileCleaner().runCleaner() && master.getLogCleaner().runCleaner();<a name="line.1294"></a> +<span class="sourceLineNo">1294</span> boolean result = master.getHFileCleaner().runCleaner() && master.getLogCleaner().runCleaner();<a name="line.1294"></a> <span class="sourceLineNo">1295</span> return ResponseConverter.buildRunCleanerChoreResponse(result);<a name="line.1295"></a> <span class="sourceLineNo">1296</span> } catch (IOException ioe) {<a name="line.1296"></a> <span class="sourceLineNo">1297</span> throw new ServiceException(ioe);<a name="line.1297"></a>
