http://git-wip-us.apache.org/repos/asf/hbase-site/blob/c0fcd7f3/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.GoodSplitExecutor.html
----------------------------------------------------------------------
diff --git 
a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.GoodSplitExecutor.html
 
b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.GoodSplitExecutor.html
index 785d459..62da186 100644
--- 
a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.GoodSplitExecutor.html
+++ 
b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.GoodSplitExecutor.html
@@ -251,7 +251,7 @@
 <span class="sourceLineNo">243</span>    }<a name="line.243"></a>
 <span class="sourceLineNo">244</span>  }<a name="line.244"></a>
 <span class="sourceLineNo">245</span><a name="line.245"></a>
-<span class="sourceLineNo">246</span>  @Test<a name="line.246"></a>
+<span class="sourceLineNo">246</span>  @Ignore @Test // Disabled for now. 
Since HBASE-18551, this mock is insufficient.<a name="line.246"></a>
 <span class="sourceLineNo">247</span>  public void testSocketTimeout() throws 
Exception {<a name="line.247"></a>
 <span class="sourceLineNo">248</span>    final TableName tableName = 
TableName.valueOf(this.name.getMethodName());<a name="line.248"></a>
 <span class="sourceLineNo">249</span>    final HRegionInfo hri = 
createRegionInfo(tableName, 1);<a name="line.249"></a>
@@ -262,580 +262,579 @@
 <span class="sourceLineNo">254</span>    rsDispatcher.setMockRsExecutor(new 
SocketTimeoutRsExecutor(20, 3));<a name="line.254"></a>
 <span class="sourceLineNo">255</span>    
waitOnFuture(submitProcedure(am.createAssignProcedure(hri, false)));<a 
name="line.255"></a>
 <span class="sourceLineNo">256</span><a name="line.256"></a>
-<span class="sourceLineNo">257</span>    rsDispatcher.setMockRsExecutor(new 
SocketTimeoutRsExecutor(20, 3));<a name="line.257"></a>
-<span class="sourceLineNo">258</span><a name="line.258"></a>
-<span class="sourceLineNo">259</span>    
exception.expect(ServerCrashException.class);<a name="line.259"></a>
-<span class="sourceLineNo">260</span>    
waitOnFuture(submitProcedure(am.createUnassignProcedure(hri, null, false)));<a 
name="line.260"></a>
-<span class="sourceLineNo">261</span><a name="line.261"></a>
-<span class="sourceLineNo">262</span>    assertEquals(assignSubmittedCount + 
1, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.262"></a>
-<span class="sourceLineNo">263</span>    assertEquals(assignFailedCount, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.263"></a>
-<span class="sourceLineNo">264</span>    assertEquals(unassignSubmittedCount + 
1, unassignProcMetrics.getSubmittedCounter().getCount());<a name="line.264"></a>
-<span class="sourceLineNo">265</span>    assertEquals(unassignFailedCount + 1, 
unassignProcMetrics.getFailedCounter().getCount());<a name="line.265"></a>
-<span class="sourceLineNo">266</span>  }<a name="line.266"></a>
-<span class="sourceLineNo">267</span><a name="line.267"></a>
-<span class="sourceLineNo">268</span>  @Test<a name="line.268"></a>
-<span class="sourceLineNo">269</span>  public void testServerNotYetRunning() 
throws Exception {<a name="line.269"></a>
-<span class="sourceLineNo">270</span>    
testRetriesExhaustedFailure(TableName.valueOf(this.name.getMethodName()),<a 
name="line.270"></a>
-<span class="sourceLineNo">271</span>      new 
ServerNotYetRunningRsExecutor());<a name="line.271"></a>
-<span class="sourceLineNo">272</span>  }<a name="line.272"></a>
-<span class="sourceLineNo">273</span><a name="line.273"></a>
-<span class="sourceLineNo">274</span>  private void 
testRetriesExhaustedFailure(final TableName tableName,<a name="line.274"></a>
-<span class="sourceLineNo">275</span>      final MockRSExecutor executor) 
throws Exception {<a name="line.275"></a>
-<span class="sourceLineNo">276</span>    final HRegionInfo hri = 
createRegionInfo(tableName, 1);<a name="line.276"></a>
-<span class="sourceLineNo">277</span><a name="line.277"></a>
-<span class="sourceLineNo">278</span>    // collect AM metrics before test<a 
name="line.278"></a>
-<span class="sourceLineNo">279</span>    collectAssignmentManagerMetrics();<a 
name="line.279"></a>
-<span class="sourceLineNo">280</span><a name="line.280"></a>
-<span class="sourceLineNo">281</span>    // Test Assign operation failure<a 
name="line.281"></a>
-<span class="sourceLineNo">282</span>    
rsDispatcher.setMockRsExecutor(executor);<a name="line.282"></a>
-<span class="sourceLineNo">283</span>    try {<a name="line.283"></a>
-<span class="sourceLineNo">284</span>      
waitOnFuture(submitProcedure(am.createAssignProcedure(hri, false)));<a 
name="line.284"></a>
-<span class="sourceLineNo">285</span>      fail("unexpected assign 
completion");<a name="line.285"></a>
-<span class="sourceLineNo">286</span>    } catch (RetriesExhaustedException e) 
{<a name="line.286"></a>
-<span class="sourceLineNo">287</span>      // expected exception<a 
name="line.287"></a>
-<span class="sourceLineNo">288</span>      LOG.info("expected exception from 
assign operation: " + e.getMessage(), e);<a name="line.288"></a>
-<span class="sourceLineNo">289</span>    }<a name="line.289"></a>
-<span class="sourceLineNo">290</span><a name="line.290"></a>
-<span class="sourceLineNo">291</span>    // Assign the region (without 
problems)<a name="line.291"></a>
-<span class="sourceLineNo">292</span>    rsDispatcher.setMockRsExecutor(new 
GoodRsExecutor());<a name="line.292"></a>
-<span class="sourceLineNo">293</span>    
waitOnFuture(submitProcedure(am.createAssignProcedure(hri, false)));<a 
name="line.293"></a>
-<span class="sourceLineNo">294</span><a name="line.294"></a>
-<span class="sourceLineNo">295</span>    // TODO: Currently unassign just 
keeps trying until it sees a server crash.<a name="line.295"></a>
-<span class="sourceLineNo">296</span>    // There is no count on unassign.<a 
name="line.296"></a>
-<span class="sourceLineNo">297</span>    /*<a name="line.297"></a>
-<span class="sourceLineNo">298</span>    // Test Unassign operation failure<a 
name="line.298"></a>
-<span class="sourceLineNo">299</span>    
rsDispatcher.setMockRsExecutor(executor);<a name="line.299"></a>
-<span class="sourceLineNo">300</span>    
waitOnFuture(submitProcedure(am.createUnassignProcedure(hri, null, false)));<a 
name="line.300"></a>
-<span class="sourceLineNo">301</span><a name="line.301"></a>
-<span class="sourceLineNo">302</span>    assertEquals(assignSubmittedCount + 
2, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.302"></a>
-<span class="sourceLineNo">303</span>    assertEquals(assignFailedCount + 1, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.303"></a>
-<span class="sourceLineNo">304</span>    assertEquals(unassignSubmittedCount + 
1, unassignProcMetrics.getSubmittedCounter().getCount());<a name="line.304"></a>
-<span class="sourceLineNo">305</span><a name="line.305"></a>
-<span class="sourceLineNo">306</span>    // TODO: We supposed to have 1 failed 
assign, 1 successful assign and a failed unassign<a name="line.306"></a>
-<span class="sourceLineNo">307</span>    // operation. But ProcV2 framework 
marks aborted unassign operation as success. Fix it!<a name="line.307"></a>
-<span class="sourceLineNo">308</span>    assertEquals(unassignFailedCount, 
unassignProcMetrics.getFailedCounter().getCount());<a name="line.308"></a>
-<span class="sourceLineNo">309</span>    */<a name="line.309"></a>
-<span class="sourceLineNo">310</span>  }<a name="line.310"></a>
+<span class="sourceLineNo">257</span>    rsDispatcher.setMockRsExecutor(new 
SocketTimeoutRsExecutor(20, 1));<a name="line.257"></a>
+<span class="sourceLineNo">258</span>    // 
exception.expect(ServerCrashException.class);<a name="line.258"></a>
+<span class="sourceLineNo">259</span>    
waitOnFuture(submitProcedure(am.createUnassignProcedure(hri, null, false)));<a 
name="line.259"></a>
+<span class="sourceLineNo">260</span><a name="line.260"></a>
+<span class="sourceLineNo">261</span>    assertEquals(assignSubmittedCount + 
1, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.261"></a>
+<span class="sourceLineNo">262</span>    assertEquals(assignFailedCount, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.262"></a>
+<span class="sourceLineNo">263</span>    assertEquals(unassignSubmittedCount + 
1, unassignProcMetrics.getSubmittedCounter().getCount());<a name="line.263"></a>
+<span class="sourceLineNo">264</span>    assertEquals(unassignFailedCount + 1, 
unassignProcMetrics.getFailedCounter().getCount());<a name="line.264"></a>
+<span class="sourceLineNo">265</span>  }<a name="line.265"></a>
+<span class="sourceLineNo">266</span><a name="line.266"></a>
+<span class="sourceLineNo">267</span>  @Test<a name="line.267"></a>
+<span class="sourceLineNo">268</span>  public void testServerNotYetRunning() 
throws Exception {<a name="line.268"></a>
+<span class="sourceLineNo">269</span>    
testRetriesExhaustedFailure(TableName.valueOf(this.name.getMethodName()),<a 
name="line.269"></a>
+<span class="sourceLineNo">270</span>      new 
ServerNotYetRunningRsExecutor());<a name="line.270"></a>
+<span class="sourceLineNo">271</span>  }<a name="line.271"></a>
+<span class="sourceLineNo">272</span><a name="line.272"></a>
+<span class="sourceLineNo">273</span>  private void 
testRetriesExhaustedFailure(final TableName tableName,<a name="line.273"></a>
+<span class="sourceLineNo">274</span>      final MockRSExecutor executor) 
throws Exception {<a name="line.274"></a>
+<span class="sourceLineNo">275</span>    final HRegionInfo hri = 
createRegionInfo(tableName, 1);<a name="line.275"></a>
+<span class="sourceLineNo">276</span><a name="line.276"></a>
+<span class="sourceLineNo">277</span>    // collect AM metrics before test<a 
name="line.277"></a>
+<span class="sourceLineNo">278</span>    collectAssignmentManagerMetrics();<a 
name="line.278"></a>
+<span class="sourceLineNo">279</span><a name="line.279"></a>
+<span class="sourceLineNo">280</span>    // Test Assign operation failure<a 
name="line.280"></a>
+<span class="sourceLineNo">281</span>    
rsDispatcher.setMockRsExecutor(executor);<a name="line.281"></a>
+<span class="sourceLineNo">282</span>    try {<a name="line.282"></a>
+<span class="sourceLineNo">283</span>      
waitOnFuture(submitProcedure(am.createAssignProcedure(hri, false)));<a 
name="line.283"></a>
+<span class="sourceLineNo">284</span>      fail("unexpected assign 
completion");<a name="line.284"></a>
+<span class="sourceLineNo">285</span>    } catch (RetriesExhaustedException e) 
{<a name="line.285"></a>
+<span class="sourceLineNo">286</span>      // expected exception<a 
name="line.286"></a>
+<span class="sourceLineNo">287</span>      LOG.info("expected exception from 
assign operation: " + e.getMessage(), e);<a name="line.287"></a>
+<span class="sourceLineNo">288</span>    }<a name="line.288"></a>
+<span class="sourceLineNo">289</span><a name="line.289"></a>
+<span class="sourceLineNo">290</span>    // Assign the region (without 
problems)<a name="line.290"></a>
+<span class="sourceLineNo">291</span>    rsDispatcher.setMockRsExecutor(new 
GoodRsExecutor());<a name="line.291"></a>
+<span class="sourceLineNo">292</span>    
waitOnFuture(submitProcedure(am.createAssignProcedure(hri, false)));<a 
name="line.292"></a>
+<span class="sourceLineNo">293</span><a name="line.293"></a>
+<span class="sourceLineNo">294</span>    // TODO: Currently unassign just 
keeps trying until it sees a server crash.<a name="line.294"></a>
+<span class="sourceLineNo">295</span>    // There is no count on unassign.<a 
name="line.295"></a>
+<span class="sourceLineNo">296</span>    /*<a name="line.296"></a>
+<span class="sourceLineNo">297</span>    // Test Unassign operation failure<a 
name="line.297"></a>
+<span class="sourceLineNo">298</span>    
rsDispatcher.setMockRsExecutor(executor);<a name="line.298"></a>
+<span class="sourceLineNo">299</span>    
waitOnFuture(submitProcedure(am.createUnassignProcedure(hri, null, false)));<a 
name="line.299"></a>
+<span class="sourceLineNo">300</span><a name="line.300"></a>
+<span class="sourceLineNo">301</span>    assertEquals(assignSubmittedCount + 
2, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.301"></a>
+<span class="sourceLineNo">302</span>    assertEquals(assignFailedCount + 1, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.302"></a>
+<span class="sourceLineNo">303</span>    assertEquals(unassignSubmittedCount + 
1, unassignProcMetrics.getSubmittedCounter().getCount());<a name="line.303"></a>
+<span class="sourceLineNo">304</span><a name="line.304"></a>
+<span class="sourceLineNo">305</span>    // TODO: We supposed to have 1 failed 
assign, 1 successful assign and a failed unassign<a name="line.305"></a>
+<span class="sourceLineNo">306</span>    // operation. But ProcV2 framework 
marks aborted unassign operation as success. Fix it!<a name="line.306"></a>
+<span class="sourceLineNo">307</span>    assertEquals(unassignFailedCount, 
unassignProcMetrics.getFailedCounter().getCount());<a name="line.307"></a>
+<span class="sourceLineNo">308</span>    */<a name="line.308"></a>
+<span class="sourceLineNo">309</span>  }<a name="line.309"></a>
+<span class="sourceLineNo">310</span><a name="line.310"></a>
 <span class="sourceLineNo">311</span><a name="line.311"></a>
-<span class="sourceLineNo">312</span><a name="line.312"></a>
-<span class="sourceLineNo">313</span>  @Test<a name="line.313"></a>
-<span class="sourceLineNo">314</span>  public void 
testIOExceptionOnAssignment() throws Exception {<a name="line.314"></a>
-<span class="sourceLineNo">315</span>    // collect AM metrics before test<a 
name="line.315"></a>
-<span class="sourceLineNo">316</span>    collectAssignmentManagerMetrics();<a 
name="line.316"></a>
-<span class="sourceLineNo">317</span><a name="line.317"></a>
-<span class="sourceLineNo">318</span>    
testFailedOpen(TableName.valueOf("testExceptionOnAssignment"),<a 
name="line.318"></a>
-<span class="sourceLineNo">319</span>      new FaultyRsExecutor(new 
IOException("test fault")));<a name="line.319"></a>
-<span class="sourceLineNo">320</span><a name="line.320"></a>
-<span class="sourceLineNo">321</span>    assertEquals(assignSubmittedCount + 
1, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.321"></a>
-<span class="sourceLineNo">322</span>    assertEquals(assignFailedCount + 1, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.322"></a>
-<span class="sourceLineNo">323</span>  }<a name="line.323"></a>
-<span class="sourceLineNo">324</span><a name="line.324"></a>
-<span class="sourceLineNo">325</span>  @Test<a name="line.325"></a>
-<span class="sourceLineNo">326</span>  public void 
testDoNotRetryExceptionOnAssignment() throws Exception {<a name="line.326"></a>
-<span class="sourceLineNo">327</span>    // collect AM metrics before test<a 
name="line.327"></a>
-<span class="sourceLineNo">328</span>    collectAssignmentManagerMetrics();<a 
name="line.328"></a>
-<span class="sourceLineNo">329</span><a name="line.329"></a>
-<span class="sourceLineNo">330</span>    
testFailedOpen(TableName.valueOf("testDoNotRetryExceptionOnAssignment"),<a 
name="line.330"></a>
-<span class="sourceLineNo">331</span>      new FaultyRsExecutor(new 
DoNotRetryIOException("test do not retry fault")));<a name="line.331"></a>
-<span class="sourceLineNo">332</span><a name="line.332"></a>
-<span class="sourceLineNo">333</span>    assertEquals(assignSubmittedCount + 
1, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.333"></a>
-<span class="sourceLineNo">334</span>    assertEquals(assignFailedCount + 1, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.334"></a>
-<span class="sourceLineNo">335</span>  }<a name="line.335"></a>
-<span class="sourceLineNo">336</span><a name="line.336"></a>
-<span class="sourceLineNo">337</span>  private void testFailedOpen(final 
TableName tableName,<a name="line.337"></a>
-<span class="sourceLineNo">338</span>      final MockRSExecutor executor) 
throws Exception {<a name="line.338"></a>
-<span class="sourceLineNo">339</span>    final HRegionInfo hri = 
createRegionInfo(tableName, 1);<a name="line.339"></a>
-<span class="sourceLineNo">340</span><a name="line.340"></a>
-<span class="sourceLineNo">341</span>    // Test Assign operation failure<a 
name="line.341"></a>
-<span class="sourceLineNo">342</span>    
rsDispatcher.setMockRsExecutor(executor);<a name="line.342"></a>
-<span class="sourceLineNo">343</span>    try {<a name="line.343"></a>
-<span class="sourceLineNo">344</span>      
waitOnFuture(submitProcedure(am.createAssignProcedure(hri, false)));<a 
name="line.344"></a>
-<span class="sourceLineNo">345</span>      fail("unexpected assign 
completion");<a name="line.345"></a>
-<span class="sourceLineNo">346</span>    } catch (RetriesExhaustedException e) 
{<a name="line.346"></a>
-<span class="sourceLineNo">347</span>      // expected exception<a 
name="line.347"></a>
-<span class="sourceLineNo">348</span>      LOG.info("REGION STATE " + 
am.getRegionStates().getRegionNode(hri));<a name="line.348"></a>
-<span class="sourceLineNo">349</span>      LOG.info("expected exception from 
assign operation: " + e.getMessage(), e);<a name="line.349"></a>
-<span class="sourceLineNo">350</span>      assertEquals(true, 
am.getRegionStates().getRegionState(hri).isFailedOpen());<a name="line.350"></a>
-<span class="sourceLineNo">351</span>    }<a name="line.351"></a>
-<span class="sourceLineNo">352</span>  }<a name="line.352"></a>
-<span class="sourceLineNo">353</span><a name="line.353"></a>
-<span class="sourceLineNo">354</span>  private void testAssign(final 
MockRSExecutor executor) throws Exception {<a name="line.354"></a>
-<span class="sourceLineNo">355</span>    testAssign(executor, NREGIONS);<a 
name="line.355"></a>
-<span class="sourceLineNo">356</span>  }<a name="line.356"></a>
-<span class="sourceLineNo">357</span><a name="line.357"></a>
-<span class="sourceLineNo">358</span>  private void testAssign(final 
MockRSExecutor executor, final int nregions) throws Exception {<a 
name="line.358"></a>
-<span class="sourceLineNo">359</span>    
rsDispatcher.setMockRsExecutor(executor);<a name="line.359"></a>
-<span class="sourceLineNo">360</span><a name="line.360"></a>
-<span class="sourceLineNo">361</span>    AssignProcedure[] assignments = new 
AssignProcedure[nregions];<a name="line.361"></a>
-<span class="sourceLineNo">362</span><a name="line.362"></a>
-<span class="sourceLineNo">363</span>    long st = 
System.currentTimeMillis();<a name="line.363"></a>
-<span class="sourceLineNo">364</span>    bulkSubmit(assignments);<a 
name="line.364"></a>
-<span class="sourceLineNo">365</span><a name="line.365"></a>
-<span class="sourceLineNo">366</span>    for (int i = 0; i &lt; 
assignments.length; ++i) {<a name="line.366"></a>
-<span class="sourceLineNo">367</span>      
ProcedureTestingUtility.waitProcedure(<a name="line.367"></a>
-<span class="sourceLineNo">368</span>        
master.getMasterProcedureExecutor(), assignments[i]);<a name="line.368"></a>
-<span class="sourceLineNo">369</span>      
assertTrue(assignments[i].toString(), assignments[i].isSuccess());<a 
name="line.369"></a>
-<span class="sourceLineNo">370</span>    }<a name="line.370"></a>
-<span class="sourceLineNo">371</span>    long et = 
System.currentTimeMillis();<a name="line.371"></a>
-<span class="sourceLineNo">372</span>    float sec = ((et - st) / 1000.0f);<a 
name="line.372"></a>
-<span class="sourceLineNo">373</span>    LOG.info(String.format("[T] Assigning 
%dprocs in %s (%.2fproc/sec)",<a name="line.373"></a>
-<span class="sourceLineNo">374</span>        assignments.length, 
StringUtils.humanTimeDiff(et - st), assignments.length / sec));<a 
name="line.374"></a>
-<span class="sourceLineNo">375</span>  }<a name="line.375"></a>
-<span class="sourceLineNo">376</span><a name="line.376"></a>
-<span class="sourceLineNo">377</span>  @Test<a name="line.377"></a>
-<span class="sourceLineNo">378</span>  public void 
testAssignAnAssignedRegion() throws Exception {<a name="line.378"></a>
-<span class="sourceLineNo">379</span>    final TableName tableName = 
TableName.valueOf("testAssignAnAssignedRegion");<a name="line.379"></a>
-<span class="sourceLineNo">380</span>    final HRegionInfo hri = 
createRegionInfo(tableName, 1);<a name="line.380"></a>
-<span class="sourceLineNo">381</span><a name="line.381"></a>
-<span class="sourceLineNo">382</span>    // collect AM metrics before test<a 
name="line.382"></a>
-<span class="sourceLineNo">383</span>    collectAssignmentManagerMetrics();<a 
name="line.383"></a>
-<span class="sourceLineNo">384</span><a name="line.384"></a>
-<span class="sourceLineNo">385</span>    rsDispatcher.setMockRsExecutor(new 
GoodRsExecutor());<a name="line.385"></a>
-<span class="sourceLineNo">386</span><a name="line.386"></a>
-<span class="sourceLineNo">387</span>    final Future&lt;byte[]&gt; futureA = 
submitProcedure(am.createAssignProcedure(hri, false));<a name="line.387"></a>
-<span class="sourceLineNo">388</span><a name="line.388"></a>
-<span class="sourceLineNo">389</span>    // wait first assign<a 
name="line.389"></a>
-<span class="sourceLineNo">390</span>    waitOnFuture(futureA);<a 
name="line.390"></a>
-<span class="sourceLineNo">391</span>    
am.getRegionStates().isRegionInState(hri, State.OPEN);<a name="line.391"></a>
-<span class="sourceLineNo">392</span>    // Second should be a noop. We should 
recognize region is already OPEN internally<a name="line.392"></a>
-<span class="sourceLineNo">393</span>    // and skip out doing nothing.<a 
name="line.393"></a>
-<span class="sourceLineNo">394</span>    // wait second assign<a 
name="line.394"></a>
-<span class="sourceLineNo">395</span>    final Future&lt;byte[]&gt; futureB = 
submitProcedure(am.createAssignProcedure(hri, false));<a name="line.395"></a>
-<span class="sourceLineNo">396</span>    waitOnFuture(futureB);<a 
name="line.396"></a>
-<span class="sourceLineNo">397</span>    
am.getRegionStates().isRegionInState(hri, State.OPEN);<a name="line.397"></a>
-<span class="sourceLineNo">398</span>    // TODO: What else can we do to 
ensure just a noop.<a name="line.398"></a>
-<span class="sourceLineNo">399</span><a name="line.399"></a>
-<span class="sourceLineNo">400</span>    // TODO: Though second assign is 
noop, it's considered success, can noop be handled in a<a name="line.400"></a>
-<span class="sourceLineNo">401</span>    // better way?<a name="line.401"></a>
-<span class="sourceLineNo">402</span>    assertEquals(assignSubmittedCount + 
2, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.402"></a>
-<span class="sourceLineNo">403</span>    assertEquals(assignFailedCount, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.403"></a>
-<span class="sourceLineNo">404</span><a name="line.404"></a>
-<span class="sourceLineNo">405</span>  }<a name="line.405"></a>
-<span class="sourceLineNo">406</span><a name="line.406"></a>
-<span class="sourceLineNo">407</span>  @Test<a name="line.407"></a>
-<span class="sourceLineNo">408</span>  public void 
testUnassignAnUnassignedRegion() throws Exception {<a name="line.408"></a>
-<span class="sourceLineNo">409</span>    final TableName tableName = 
TableName.valueOf("testUnassignAnUnassignedRegion");<a name="line.409"></a>
-<span class="sourceLineNo">410</span>    final HRegionInfo hri = 
createRegionInfo(tableName, 1);<a name="line.410"></a>
-<span class="sourceLineNo">411</span><a name="line.411"></a>
-<span class="sourceLineNo">412</span>    // collect AM metrics before test<a 
name="line.412"></a>
-<span class="sourceLineNo">413</span>    collectAssignmentManagerMetrics();<a 
name="line.413"></a>
-<span class="sourceLineNo">414</span><a name="line.414"></a>
-<span class="sourceLineNo">415</span>    rsDispatcher.setMockRsExecutor(new 
GoodRsExecutor());<a name="line.415"></a>
-<span class="sourceLineNo">416</span><a name="line.416"></a>
-<span class="sourceLineNo">417</span>    // assign the region first<a 
name="line.417"></a>
-<span class="sourceLineNo">418</span>    
waitOnFuture(submitProcedure(am.createAssignProcedure(hri, false)));<a 
name="line.418"></a>
-<span class="sourceLineNo">419</span><a name="line.419"></a>
-<span class="sourceLineNo">420</span>    final Future&lt;byte[]&gt; futureA = 
submitProcedure(am.createUnassignProcedure(hri, null, false));<a 
name="line.420"></a>
-<span class="sourceLineNo">421</span><a name="line.421"></a>
-<span class="sourceLineNo">422</span>    // Wait first unassign.<a 
name="line.422"></a>
-<span class="sourceLineNo">423</span>    waitOnFuture(futureA);<a 
name="line.423"></a>
-<span class="sourceLineNo">424</span>    
am.getRegionStates().isRegionInState(hri, State.CLOSED);<a name="line.424"></a>
-<span class="sourceLineNo">425</span>    // Second should be a noop. We should 
recognize region is already CLOSED internally<a name="line.425"></a>
-<span class="sourceLineNo">426</span>    // and skip out doing nothing.<a 
name="line.426"></a>
-<span class="sourceLineNo">427</span>    final Future&lt;byte[]&gt; futureB 
=<a name="line.427"></a>
-<span class="sourceLineNo">428</span>        
submitProcedure(am.createUnassignProcedure(hri,<a name="line.428"></a>
-<span class="sourceLineNo">429</span>            
ServerName.valueOf("example.org,1234,1"), false));<a name="line.429"></a>
-<span class="sourceLineNo">430</span>    waitOnFuture(futureB);<a 
name="line.430"></a>
-<span class="sourceLineNo">431</span>    // Ensure we are still CLOSED.<a 
name="line.431"></a>
-<span class="sourceLineNo">432</span>    
am.getRegionStates().isRegionInState(hri, State.CLOSED);<a name="line.432"></a>
-<span class="sourceLineNo">433</span>    // TODO: What else can we do to 
ensure just a noop.<a name="line.433"></a>
-<span class="sourceLineNo">434</span><a name="line.434"></a>
-<span class="sourceLineNo">435</span>    assertEquals(assignSubmittedCount + 
1, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.435"></a>
-<span class="sourceLineNo">436</span>    assertEquals(assignFailedCount, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.436"></a>
-<span class="sourceLineNo">437</span>    // TODO: Though second unassign is 
noop, it's considered success, can noop be handled in a<a name="line.437"></a>
-<span class="sourceLineNo">438</span>    // better way?<a name="line.438"></a>
-<span class="sourceLineNo">439</span>    assertEquals(unassignSubmittedCount + 
2, unassignProcMetrics.getSubmittedCounter().getCount());<a name="line.439"></a>
-<span class="sourceLineNo">440</span>    assertEquals(unassignFailedCount, 
unassignProcMetrics.getFailedCounter().getCount());<a name="line.440"></a>
-<span class="sourceLineNo">441</span>  }<a name="line.441"></a>
-<span class="sourceLineNo">442</span><a name="line.442"></a>
-<span class="sourceLineNo">443</span>  private Future&lt;byte[]&gt; 
submitProcedure(final Procedure proc) {<a name="line.443"></a>
-<span class="sourceLineNo">444</span>    return 
ProcedureSyncWait.submitProcedure(master.getMasterProcedureExecutor(), proc);<a 
name="line.444"></a>
-<span class="sourceLineNo">445</span>  }<a name="line.445"></a>
-<span class="sourceLineNo">446</span><a name="line.446"></a>
-<span class="sourceLineNo">447</span>  private byte[] waitOnFuture(final 
Future&lt;byte[]&gt; future) throws Exception {<a name="line.447"></a>
-<span class="sourceLineNo">448</span>    try {<a name="line.448"></a>
-<span class="sourceLineNo">449</span>      return future.get(5, 
TimeUnit.SECONDS);<a name="line.449"></a>
-<span class="sourceLineNo">450</span>    } catch (ExecutionException e) {<a 
name="line.450"></a>
-<span class="sourceLineNo">451</span>      LOG.info("ExecutionException", 
e);<a name="line.451"></a>
-<span class="sourceLineNo">452</span>      throw (Exception)e.getCause();<a 
name="line.452"></a>
-<span class="sourceLineNo">453</span>    }<a name="line.453"></a>
-<span class="sourceLineNo">454</span>  }<a name="line.454"></a>
-<span class="sourceLineNo">455</span><a name="line.455"></a>
-<span class="sourceLineNo">456</span>  // 
============================================================================================<a
 name="line.456"></a>
-<span class="sourceLineNo">457</span>  //  Helpers<a name="line.457"></a>
-<span class="sourceLineNo">458</span>  // 
============================================================================================<a
 name="line.458"></a>
-<span class="sourceLineNo">459</span>  private void bulkSubmit(final 
AssignProcedure[] procs) throws Exception {<a name="line.459"></a>
-<span class="sourceLineNo">460</span>    final Thread[] threads = new 
Thread[PROC_NTHREADS];<a name="line.460"></a>
-<span class="sourceLineNo">461</span>    for (int i = 0; i &lt; 
threads.length; ++i) {<a name="line.461"></a>
-<span class="sourceLineNo">462</span>      final int threadId = i;<a 
name="line.462"></a>
-<span class="sourceLineNo">463</span>      threads[i] = new Thread() {<a 
name="line.463"></a>
-<span class="sourceLineNo">464</span>        @Override<a name="line.464"></a>
-<span class="sourceLineNo">465</span>        public void run() {<a 
name="line.465"></a>
-<span class="sourceLineNo">466</span>          TableName tableName = 
TableName.valueOf("table-" + threadId);<a name="line.466"></a>
-<span class="sourceLineNo">467</span>          int n = (procs.length / 
threads.length);<a name="line.467"></a>
-<span class="sourceLineNo">468</span>          int start = threadId * n;<a 
name="line.468"></a>
-<span class="sourceLineNo">469</span>          int stop = start + n;<a 
name="line.469"></a>
-<span class="sourceLineNo">470</span>          for (int j = start; j &lt; 
stop; ++j) {<a name="line.470"></a>
-<span class="sourceLineNo">471</span>            procs[j] = 
createAndSubmitAssign(tableName, j);<a name="line.471"></a>
-<span class="sourceLineNo">472</span>          }<a name="line.472"></a>
-<span class="sourceLineNo">473</span>        }<a name="line.473"></a>
-<span class="sourceLineNo">474</span>      };<a name="line.474"></a>
-<span class="sourceLineNo">475</span>      threads[i].start();<a 
name="line.475"></a>
-<span class="sourceLineNo">476</span>    }<a name="line.476"></a>
-<span class="sourceLineNo">477</span>    for (int i = 0; i &lt; 
threads.length; ++i) {<a name="line.477"></a>
-<span class="sourceLineNo">478</span>      threads[i].join();<a 
name="line.478"></a>
-<span class="sourceLineNo">479</span>    }<a name="line.479"></a>
-<span class="sourceLineNo">480</span>    for (int i = procs.length - 1; i 
&gt;= 0 &amp;&amp; procs[i] == null; --i) {<a name="line.480"></a>
-<span class="sourceLineNo">481</span>      procs[i] = 
createAndSubmitAssign(TableName.valueOf("table-sync"), i);<a 
name="line.481"></a>
-<span class="sourceLineNo">482</span>    }<a name="line.482"></a>
-<span class="sourceLineNo">483</span>  }<a name="line.483"></a>
-<span class="sourceLineNo">484</span><a name="line.484"></a>
-<span class="sourceLineNo">485</span>  private AssignProcedure 
createAndSubmitAssign(TableName tableName, int regionId) {<a 
name="line.485"></a>
-<span class="sourceLineNo">486</span>    HRegionInfo hri = 
createRegionInfo(tableName, regionId);<a name="line.486"></a>
-<span class="sourceLineNo">487</span>    AssignProcedure proc = 
am.createAssignProcedure(hri, false);<a name="line.487"></a>
-<span class="sourceLineNo">488</span>    
master.getMasterProcedureExecutor().submitProcedure(proc);<a 
name="line.488"></a>
-<span class="sourceLineNo">489</span>    return proc;<a name="line.489"></a>
-<span class="sourceLineNo">490</span>  }<a name="line.490"></a>
-<span class="sourceLineNo">491</span><a name="line.491"></a>
-<span class="sourceLineNo">492</span>  private UnassignProcedure 
createAndSubmitUnassign(TableName tableName, int regionId) {<a 
name="line.492"></a>
-<span class="sourceLineNo">493</span>    HRegionInfo hri = 
createRegionInfo(tableName, regionId);<a name="line.493"></a>
-<span class="sourceLineNo">494</span>    UnassignProcedure proc = 
am.createUnassignProcedure(hri, null, false);<a name="line.494"></a>
-<span class="sourceLineNo">495</span>    
master.getMasterProcedureExecutor().submitProcedure(proc);<a 
name="line.495"></a>
-<span class="sourceLineNo">496</span>    return proc;<a name="line.496"></a>
-<span class="sourceLineNo">497</span>  }<a name="line.497"></a>
-<span class="sourceLineNo">498</span><a name="line.498"></a>
-<span class="sourceLineNo">499</span>  private HRegionInfo 
createRegionInfo(final TableName tableName, final long regionId) {<a 
name="line.499"></a>
-<span class="sourceLineNo">500</span>    return new HRegionInfo(tableName,<a 
name="line.500"></a>
-<span class="sourceLineNo">501</span>      Bytes.toBytes(regionId), 
Bytes.toBytes(regionId + 1), false, 0);<a name="line.501"></a>
-<span class="sourceLineNo">502</span>  }<a name="line.502"></a>
-<span class="sourceLineNo">503</span><a name="line.503"></a>
-<span class="sourceLineNo">504</span>  private void sendTransitionReport(final 
ServerName serverName,<a name="line.504"></a>
-<span class="sourceLineNo">505</span>      final RegionInfo regionInfo, final 
TransitionCode state) throws IOException {<a name="line.505"></a>
-<span class="sourceLineNo">506</span>    
ReportRegionStateTransitionRequest.Builder req =<a name="line.506"></a>
-<span class="sourceLineNo">507</span>      
ReportRegionStateTransitionRequest.newBuilder();<a name="line.507"></a>
-<span class="sourceLineNo">508</span>    
req.setServer(ProtobufUtil.toServerName(serverName));<a name="line.508"></a>
-<span class="sourceLineNo">509</span>    
req.addTransition(RegionStateTransition.newBuilder()<a name="line.509"></a>
-<span class="sourceLineNo">510</span>      .addRegionInfo(regionInfo)<a 
name="line.510"></a>
-<span class="sourceLineNo">511</span>      .setTransitionCode(state)<a 
name="line.511"></a>
-<span class="sourceLineNo">512</span>      .setOpenSeqNum(1)<a 
name="line.512"></a>
-<span class="sourceLineNo">513</span>      .build());<a name="line.513"></a>
-<span class="sourceLineNo">514</span>    
am.reportRegionStateTransition(req.build());<a name="line.514"></a>
-<span class="sourceLineNo">515</span>  }<a name="line.515"></a>
-<span class="sourceLineNo">516</span><a name="line.516"></a>
-<span class="sourceLineNo">517</span>  private void doCrash(final ServerName 
serverName) {<a name="line.517"></a>
-<span class="sourceLineNo">518</span>    this.am.submitServerCrash(serverName, 
false/*No WALs here*/);<a name="line.518"></a>
-<span class="sourceLineNo">519</span>  }<a name="line.519"></a>
-<span class="sourceLineNo">520</span><a name="line.520"></a>
-<span class="sourceLineNo">521</span>  private class NoopRsExecutor implements 
MockRSExecutor {<a name="line.521"></a>
-<span class="sourceLineNo">522</span>    public ExecuteProceduresResponse 
sendRequest(ServerName server,<a name="line.522"></a>
-<span class="sourceLineNo">523</span>        ExecuteProceduresRequest request) 
throws IOException {<a name="line.523"></a>
-<span class="sourceLineNo">524</span>      ExecuteProceduresResponse.Builder 
builder = ExecuteProceduresResponse.newBuilder();<a name="line.524"></a>
-<span class="sourceLineNo">525</span>      if (request.getOpenRegionCount() 
&gt; 0) {<a name="line.525"></a>
-<span class="sourceLineNo">526</span>        for (OpenRegionRequest req: 
request.getOpenRegionList()) {<a name="line.526"></a>
-<span class="sourceLineNo">527</span>          OpenRegionResponse.Builder resp 
= OpenRegionResponse.newBuilder();<a name="line.527"></a>
-<span class="sourceLineNo">528</span>          for (RegionOpenInfo openReq: 
req.getOpenInfoList()) {<a name="line.528"></a>
-<span class="sourceLineNo">529</span>            RegionOpeningState state = 
execOpenRegion(server, openReq);<a name="line.529"></a>
-<span class="sourceLineNo">530</span>            if (state != null) {<a 
name="line.530"></a>
-<span class="sourceLineNo">531</span>              
resp.addOpeningState(state);<a name="line.531"></a>
-<span class="sourceLineNo">532</span>            }<a name="line.532"></a>
-<span class="sourceLineNo">533</span>          }<a name="line.533"></a>
-<span class="sourceLineNo">534</span>          
builder.addOpenRegion(resp.build());<a name="line.534"></a>
-<span class="sourceLineNo">535</span>        }<a name="line.535"></a>
-<span class="sourceLineNo">536</span>      }<a name="line.536"></a>
-<span class="sourceLineNo">537</span>      if (request.getCloseRegionCount() 
&gt; 0) {<a name="line.537"></a>
-<span class="sourceLineNo">538</span>        for (CloseRegionRequest req: 
request.getCloseRegionList()) {<a name="line.538"></a>
-<span class="sourceLineNo">539</span>          CloseRegionResponse resp = 
execCloseRegion(server,<a name="line.539"></a>
-<span class="sourceLineNo">540</span>              
req.getRegion().getValue().toByteArray());<a name="line.540"></a>
-<span class="sourceLineNo">541</span>          if (resp != null) {<a 
name="line.541"></a>
-<span class="sourceLineNo">542</span>            
builder.addCloseRegion(resp);<a name="line.542"></a>
-<span class="sourceLineNo">543</span>          }<a name="line.543"></a>
-<span class="sourceLineNo">544</span>        }<a name="line.544"></a>
-<span class="sourceLineNo">545</span>      }<a name="line.545"></a>
-<span class="sourceLineNo">546</span>      return 
ExecuteProceduresResponse.newBuilder().build();<a name="line.546"></a>
-<span class="sourceLineNo">547</span>    }<a name="line.547"></a>
-<span class="sourceLineNo">548</span><a name="line.548"></a>
-<span class="sourceLineNo">549</span>    protected RegionOpeningState 
execOpenRegion(ServerName server, RegionOpenInfo regionInfo)<a 
name="line.549"></a>
-<span class="sourceLineNo">550</span>        throws IOException {<a 
name="line.550"></a>
-<span class="sourceLineNo">551</span>      return null;<a name="line.551"></a>
-<span class="sourceLineNo">552</span>    }<a name="line.552"></a>
-<span class="sourceLineNo">553</span><a name="line.553"></a>
-<span class="sourceLineNo">554</span>    protected CloseRegionResponse 
execCloseRegion(ServerName server, byte[] regionName)<a name="line.554"></a>
-<span class="sourceLineNo">555</span>        throws IOException {<a 
name="line.555"></a>
-<span class="sourceLineNo">556</span>      return null;<a name="line.556"></a>
-<span class="sourceLineNo">557</span>    }<a name="line.557"></a>
-<span class="sourceLineNo">558</span>  }<a name="line.558"></a>
-<span class="sourceLineNo">559</span><a name="line.559"></a>
-<span class="sourceLineNo">560</span>  private class GoodRsExecutor extends 
NoopRsExecutor {<a name="line.560"></a>
-<span class="sourceLineNo">561</span>    @Override<a name="line.561"></a>
-<span class="sourceLineNo">562</span>    protected RegionOpeningState 
execOpenRegion(ServerName server, RegionOpenInfo openReq)<a name="line.562"></a>
-<span class="sourceLineNo">563</span>        throws IOException {<a 
name="line.563"></a>
-<span class="sourceLineNo">564</span>      sendTransitionReport(server, 
openReq.getRegion(), TransitionCode.OPENED);<a name="line.564"></a>
-<span class="sourceLineNo">565</span>      // Concurrency?<a 
name="line.565"></a>
-<span class="sourceLineNo">566</span>      // Now update the state of our 
cluster in regionsToRegionServers.<a name="line.566"></a>
-<span class="sourceLineNo">567</span>      SortedSet&lt;byte []&gt; regions = 
regionsToRegionServers.get(server);<a name="line.567"></a>
-<span class="sourceLineNo">568</span>      if (regions == null) {<a 
name="line.568"></a>
-<span class="sourceLineNo">569</span>        regions = new 
ConcurrentSkipListSet&lt;byte[]&gt;(Bytes.BYTES_COMPARATOR);<a 
name="line.569"></a>
-<span class="sourceLineNo">570</span>        
regionsToRegionServers.put(server, regions);<a name="line.570"></a>
-<span class="sourceLineNo">571</span>      }<a name="line.571"></a>
-<span class="sourceLineNo">572</span>      HRegionInfo hri = 
HRegionInfo.convert(openReq.getRegion());<a name="line.572"></a>
-<span class="sourceLineNo">573</span>      if 
(regions.contains(hri.getRegionName())) {<a name="line.573"></a>
-<span class="sourceLineNo">574</span>        throw new 
UnsupportedOperationException(hri.getRegionNameAsString());<a 
name="line.574"></a>
-<span class="sourceLineNo">575</span>      }<a name="line.575"></a>
-<span class="sourceLineNo">576</span>      regions.add(hri.getRegionName());<a 
name="line.576"></a>
-<span class="sourceLineNo">577</span>      return RegionOpeningState.OPENED;<a 
name="line.577"></a>
-<span class="sourceLineNo">578</span>    }<a name="line.578"></a>
-<span class="sourceLineNo">579</span><a name="line.579"></a>
-<span class="sourceLineNo">580</span>    @Override<a name="line.580"></a>
-<span class="sourceLineNo">581</span>    protected CloseRegionResponse 
execCloseRegion(ServerName server, byte[] regionName)<a name="line.581"></a>
-<span class="sourceLineNo">582</span>        throws IOException {<a 
name="line.582"></a>
-<span class="sourceLineNo">583</span>      HRegionInfo hri = 
am.getRegionInfo(regionName);<a name="line.583"></a>
-<span class="sourceLineNo">584</span>      sendTransitionReport(server, 
HRegionInfo.convert(hri), TransitionCode.CLOSED);<a name="line.584"></a>
-<span class="sourceLineNo">585</span>      return 
CloseRegionResponse.newBuilder().setClosed(true).build();<a name="line.585"></a>
-<span class="sourceLineNo">586</span>    }<a name="line.586"></a>
-<span class="sourceLineNo">587</span>  }<a name="line.587"></a>
-<span class="sourceLineNo">588</span><a name="line.588"></a>
-<span class="sourceLineNo">589</span>  private static class 
ServerNotYetRunningRsExecutor implements MockRSExecutor {<a name="line.589"></a>
-<span class="sourceLineNo">590</span>    public ExecuteProceduresResponse 
sendRequest(ServerName server, ExecuteProceduresRequest req)<a 
name="line.590"></a>
-<span class="sourceLineNo">591</span>        throws IOException {<a 
name="line.591"></a>
-<span class="sourceLineNo">592</span>      throw new 
ServerNotRunningYetException("wait on server startup");<a name="line.592"></a>
-<span class="sourceLineNo">593</span>    }<a name="line.593"></a>
-<span class="sourceLineNo">594</span>  }<a name="line.594"></a>
-<span class="sourceLineNo">595</span><a name="line.595"></a>
-<span class="sourceLineNo">596</span>  private static class FaultyRsExecutor 
implements MockRSExecutor {<a name="line.596"></a>
-<span class="sourceLineNo">597</span>    private final IOException 
exception;<a name="line.597"></a>
-<span class="sourceLineNo">598</span><a name="line.598"></a>
-<span class="sourceLineNo">599</span>    public FaultyRsExecutor(final 
IOException exception) {<a name="line.599"></a>
-<span class="sourceLineNo">600</span>      this.exception = exception;<a 
name="line.600"></a>
-<span class="sourceLineNo">601</span>    }<a name="line.601"></a>
-<span class="sourceLineNo">602</span><a name="line.602"></a>
-<span class="sourceLineNo">603</span>    public ExecuteProceduresResponse 
sendRequest(ServerName server, ExecuteProceduresRequest req)<a 
name="line.603"></a>
-<span class="sourceLineNo">604</span>        throws IOException {<a 
name="line.604"></a>
-<span class="sourceLineNo">605</span>      throw exception;<a 
name="line.605"></a>
-<span class="sourceLineNo">606</span>    }<a name="line.606"></a>
-<span class="sourceLineNo">607</span>  }<a name="line.607"></a>
-<span class="sourceLineNo">608</span><a name="line.608"></a>
-<span class="sourceLineNo">609</span>  private class SocketTimeoutRsExecutor 
extends GoodRsExecutor {<a name="line.609"></a>
-<span class="sourceLineNo">610</span>    private final int 
maxSocketTimeoutRetries;<a name="line.610"></a>
-<span class="sourceLineNo">611</span>    private final int maxServerRetries;<a 
name="line.611"></a>
-<span class="sourceLineNo">612</span><a name="line.612"></a>
-<span class="sourceLineNo">613</span>    private ServerName lastServer;<a 
name="line.613"></a>
-<span class="sourceLineNo">614</span>    private int sockTimeoutRetries;<a 
name="line.614"></a>
-<span class="sourceLineNo">615</span>    private int serverRetries;<a 
name="line.615"></a>
-<span class="sourceLineNo">616</span><a name="line.616"></a>
-<span class="sourceLineNo">617</span>    public SocketTimeoutRsExecutor(int 
maxSocketTimeoutRetries, int maxServerRetries) {<a name="line.617"></a>
-<span class="sourceLineNo">618</span>      this.maxServerRetries = 
maxServerRetries;<a name="line.618"></a>
-<span class="sourceLineNo">619</span>      this.maxSocketTimeoutRetries = 
maxSocketTimeoutRetries;<a name="line.619"></a>
-<span class="sourceLineNo">620</span>    }<a name="line.620"></a>
-<span class="sourceLineNo">621</span><a name="line.621"></a>
-<span class="sourceLineNo">622</span>    public ExecuteProceduresResponse 
sendRequest(ServerName server, ExecuteProceduresRequest req)<a 
name="line.622"></a>
-<span class="sourceLineNo">623</span>        throws IOException {<a 
name="line.623"></a>
-<span class="sourceLineNo">624</span>      // SocketTimeoutException should be 
a temporary problem<a name="line.624"></a>
-<span class="sourceLineNo">625</span>      // unless the server will be 
declared dead.<a name="line.625"></a>
-<span class="sourceLineNo">626</span>      if (sockTimeoutRetries++ &lt; 
maxSocketTimeoutRetries) {<a name="line.626"></a>
-<span class="sourceLineNo">627</span>        if (sockTimeoutRetries == 1) 
assertNotEquals(lastServer, server);<a name="line.627"></a>
-<span class="sourceLineNo">628</span>        lastServer = server;<a 
name="line.628"></a>
-<span class="sourceLineNo">629</span>        LOG.debug("Socket timeout for 
server=" + server + " retries=" + sockTimeoutRetries);<a name="line.629"></a>
-<span class="sourceLineNo">630</span>        throw new 
SocketTimeoutException("simulate socket timeout");<a name="line.630"></a>
-<span class="sourceLineNo">631</span>      } else if (serverRetries++ &lt; 
maxServerRetries) {<a name="line.631"></a>
-<span class="sourceLineNo">632</span>        LOG.info("Mark server=" + server 
+ " as dead. serverRetries=" + serverRetries);<a name="line.632"></a>
-<span class="sourceLineNo">633</span>        
master.getServerManager().moveFromOnlineToDeadServers(server);<a 
name="line.633"></a>
-<span class="sourceLineNo">634</span>        sockTimeoutRetries = 0;<a 
name="line.634"></a>
-<span class="sourceLineNo">635</span>        throw new 
SocketTimeoutException("simulate socket timeout");<a name="line.635"></a>
-<span class="sourceLineNo">636</span>      } else {<a name="line.636"></a>
-<span class="sourceLineNo">637</span>        return super.sendRequest(server, 
req);<a name="line.637"></a>
-<span class="sourceLineNo">638</span>      }<a name="line.638"></a>
-<span class="sourceLineNo">639</span>    }<a name="line.639"></a>
-<span class="sourceLineNo">640</span>  }<a name="line.640"></a>
-<span class="sourceLineNo">641</span><a name="line.641"></a>
-<span class="sourceLineNo">642</span>  /**<a name="line.642"></a>
-<span class="sourceLineNo">643</span>   * Takes open request and then returns 
nothing so acts like a RS that went zombie.<a name="line.643"></a>
-<span class="sourceLineNo">644</span>   * No response (so proc is 
stuck/suspended on the Master and won't wake up.). We<a name="line.644"></a>
-<span class="sourceLineNo">645</span>   * then send in a crash for this server 
after a few seconds; crash is supposed to<a name="line.645"></a>
-<span class="sourceLineNo">646</span>   * take care of the suspended 
procedures.<a name="line.646"></a>
-<span class="sourceLineNo">647</span>   */<a name="line.647"></a>
-<span class="sourceLineNo">648</span>  private class HangThenRSCrashExecutor 
extends GoodRsExecutor {<a name="line.648"></a>
-<span class="sourceLineNo">649</span>    private int invocations;<a 
name="line.649"></a>
-<span class="sourceLineNo">650</span><a name="line.650"></a>
-<span class="sourceLineNo">651</span>    @Override<a name="line.651"></a>
-<span class="sourceLineNo">652</span>    protected RegionOpeningState 
execOpenRegion(final ServerName server, RegionOpenInfo openReq)<a 
name="line.652"></a>
-<span class="sourceLineNo">653</span>    throws IOException {<a 
name="line.653"></a>
-<span class="sourceLineNo">654</span>      if (this.invocations++ &gt; 0) {<a 
name="line.654"></a>
-<span class="sourceLineNo">655</span>        // Return w/o problem the second 
time through here.<a name="line.655"></a>
-<span class="sourceLineNo">656</span>        return 
super.execOpenRegion(server, openReq);<a name="line.656"></a>
-<span class="sourceLineNo">657</span>      }<a name="line.657"></a>
-<span class="sourceLineNo">658</span>      // The procedure on master will 
just hang forever because nothing comes back<a name="line.658"></a>
-<span class="sourceLineNo">659</span>      // from the RS in this case.<a 
name="line.659"></a>
-<span class="sourceLineNo">660</span>      LOG.info("Return null response from 
serverName=" + server + "; means STUCK...TODO timeout");<a name="line.660"></a>
-<span class="sourceLineNo">661</span>      executor.schedule(new Runnable() 
{<a name="line.661"></a>
-<span class="sourceLineNo">662</span>        @Override<a name="line.662"></a>
-<span class="sourceLineNo">663</span>        public void run() {<a 
name="line.663"></a>
-<span class="sourceLineNo">664</span>          LOG.info("Sending in CRASH of " 
+ server);<a name="line.664"></a>
-<span class="sourceLineNo">665</span>          doCrash(server);<a 
name="line.665"></a>
-<span class="sourceLineNo">666</span>        }<a name="line.666"></a>
-<span class="sourceLineNo">667</span>      }, 1, TimeUnit.SECONDS);<a 
name="line.667"></a>
-<span class="sourceLineNo">668</span>      return null;<a name="line.668"></a>
-<span class="sourceLineNo">669</span>    }<a name="line.669"></a>
-<span class="sourceLineNo">670</span>  }<a name="line.670"></a>
-<span class="sourceLineNo">671</span><a name="line.671"></a>
-<span class="sourceLineNo">672</span>  private class 
HangOnCloseThenRSCrashExecutor extends GoodRsExecutor {<a name="line.672"></a>
-<span class="sourceLineNo">673</span>    public static final int 
TYPES_OF_FAILURE = 6;<a name="line.673"></a>
-<span class="sourceLineNo">674</span>    private int invocations;<a 
name="line.674"></a>
-<span class="sourceLineNo">675</span><a name="line.675"></a>
-<span class="sourceLineNo">676</span>    @Override<a name="line.676"></a>
-<span class="sourceLineNo">677</span>    protected CloseRegionResponse 
execCloseRegion(ServerName server, byte[] regionName)<a name="line.677"></a>
-<span class="sourceLineNo">678</span>        throws IOException {<a 
name="line.678"></a>
-<span class="sourceLineNo">679</span>      switch (this.invocations++) {<a 
name="line.679"></a>
-<span class="sourceLineNo">680</span>      case 0: throw new 
NotServingRegionException("Fake");<a name="line.680"></a>
-<span class="sourceLineNo">681</span>      case 1: throw new 
RegionServerAbortedException("Fake!");<a name="line.681"></a>
-<span class="sourceLineNo">682</span>      case 2: throw new 
RegionServerStoppedException("Fake!");<a name="line.682"></a>
-<span class="sourceLineNo">683</span>      case 3: throw new 
ServerNotRunningYetException("Fake!");<a name="line.683"></a>
-<span class="sourceLineNo">684</span>      case 4:<a name="line.684"></a>
-<span class="sourceLineNo">685</span>        LOG.info("Return null response 
from serverName=" + server + "; means STUCK...TODO timeout");<a 
name="line.685"></a>
-<span class="sourceLineNo">686</span>        executor.schedule(new Runnable() 
{<a name="line.686"></a>
-<span class="sourceLineNo">687</span>          @Override<a name="line.687"></a>
-<span class="sourceLineNo">688</span>          public void run() {<a 
name="line.688"></a>
-<span class="sourceLineNo">689</span>            LOG.info("Sending in CRASH of 
" + server);<a name="line.689"></a>
-<span class="sourceLineNo">690</span>            doCrash(server);<a 
name="line.690"></a>
-<span class="sourceLineNo">691</span>          }<a name="line.691"></a>
-<span class="sourceLineNo">692</span>        }, 1, TimeUnit.SECONDS);<a 
name="line.692"></a>
-<span class="sourceLineNo">693</span>        return null;<a 
name="line.693"></a>
-<span class="sourceLineNo">694</span>      default:<a name="line.694"></a>
-<span class="sourceLineNo">695</span>        return 
super.execCloseRegion(server, regionName);<a name="line.695"></a>
-<span class="sourceLineNo">696</span>      }<a name="line.696"></a>
-<span class="sourceLineNo">697</span>    }<a name="line.697"></a>
-<span class="sourceLineNo">698</span>  }<a name="line.698"></a>
-<span class="sourceLineNo">699</span><a name="line.699"></a>
-<span class="sourceLineNo">700</span>  private class RandRsExecutor extends 
NoopRsExecutor {<a name="line.700"></a>
-<span class="sourceLineNo">701</span>    private final Random rand = new 
Random();<a name="line.701"></a>
-<span class="sourceLineNo">702</span><a name="line.702"></a>
-<span class="sourceLineNo">703</span>    public ExecuteProceduresResponse 
sendRequest(ServerName server, ExecuteProceduresRequest req)<a 
name="line.703"></a>
-<span class="sourceLineNo">704</span>        throws IOException {<a 
name="line.704"></a>
-<span class="sourceLineNo">705</span>      switch (rand.nextInt(5)) {<a 
name="line.705"></a>
-<span class="sourceLineNo">706</span>        case 0: throw new 
ServerNotRunningYetException("wait on server startup");<a name="line.706"></a>
-<span class="sourceLineNo">707</span>        case 1: throw new 
SocketTimeoutException("simulate socket timeout");<a name="line.707"></a>
-<span class="sourceLineNo">708</span>        case 2: throw new 
RemoteException("java.io.IOException", "unexpected exception");<a 
name="line.708"></a>
-<span class="sourceLineNo">709</span>      }<a name="line.709"></a>
-<span class="sourceLineNo">710</span>      return super.sendRequest(server, 
req);<a name="line.710"></a>
-<span class="sourceLineNo">711</span>    }<a name="line.711"></a>
-<span class="sourceLineNo">712</span><a name="line.712"></a>
-<span class="sourceLineNo">713</span>    @Override<a name="line.713"></a>
-<span class="sourceLineNo">714</span>    protected RegionOpeningState 
execOpenRegion(final ServerName server, RegionOpenInfo openReq)<a 
name="line.714"></a>
-<span class="sourceLineNo">715</span>        throws IOException {<a 
name="line.715"></a>
-<span class="sourceLineNo">716</span>      switch (rand.nextInt(6)) {<a 
name="line.716"></a>
-<span class="sourceLineNo">717</span>        case 0:<a name="line.717"></a>
-<span class="sourceLineNo">718</span>          LOG.info("Return OPENED 
response");<a name="line.718"></a>
-<span class="sourceLineNo">719</span>          sendTransitionReport(server, 
openReq.getRegion(), TransitionCode.OPENED);<a name="line.719"></a>
-<span class="sourceLineNo">720</span>          return 
OpenRegionResponse.RegionOpeningState.OPENED;<a name="line.720"></a>
-<span class="sourceLineNo">721</span>        case 1:<a name="line.721"></a>
-<span class="sourceLineNo">722</span>          LOG.info("Return transition 
report that OPENED/ALREADY_OPENED response");<a name="line.722"></a>
-<span class="sourceLineNo">723</span>          sendTransitionReport(server, 
openReq.getRegion(), TransitionCode.OPENED);<a name="line.723"></a>
-<span class="sourceLineNo">724</span>          return 
OpenRegionResponse.RegionOpeningState.ALREADY_OPENED;<a name="line.724"></a>
-<span class="sourceLineNo">725</span>        case 2:<a name="line.725"></a>
-<span class="sourceLineNo">726</span>          LOG.info("Return transition 
report that FAILED_OPEN/FAILED_OPENING response");<a name="line.726"></a>
-<span class="sourceLineNo">727</span>          sendTransitionReport(server, 
openReq.getRegion(), TransitionCode.FAILED_OPEN);<a name="line.727"></a>
-<span class="sourceLineNo">728</span>          return 
OpenRegionResponse.RegionOpeningState.FAILED_OPENING;<a name="line.728"></a>
-<span class="sourceLineNo">729</span>      }<a name="line.729"></a>
-<span class="sourceLineNo">730</span>      // The procedure on master will 
just hang forever because nothing comes back<a name="line.730"></a>
-<span class="sourceLineNo">731</span>      // from the RS in this case.<a 
name="line.731"></a>
-<span class="sourceLineNo">732</span>      LOG.info("Return null as response; 
means proc stuck so we send in a crash report after a few seconds...");<a 
name="line.732"></a>
-<span class="sourceLineNo">733</span>      executor.schedule(new Runnable() 
{<a name="line.733"></a>
-<span class="sourceLineNo">734</span>        @Override<a name="line.734"></a>
-<span class="sourceLineNo">735</span>        public void run() {<a 
name="line.735"></a>
-<span class="sourceLineNo">736</span>          LOG.info("Delayed CRASHING of " 
+ server);<a name="line.736"></a>
-<span class="sourceLineNo">737</span>          doCrash(server);<a 
name="line.737"></a>
-<span class="sourceLineNo">738</span>        }<a name="line.738"></a>
-<span class="sourceLineNo">739</span>      }, 5, TimeUnit.SECONDS);<a 
name="line.739"></a>
-<span class="sourceLineNo">740</span>      return null;<a name="line.740"></a>
-<span class="sourceLineNo">741</span>    }<a name="line.741"></a>
-<span class="sourceLineNo">742</span><a name="line.742"></a>
-<span class="sourceLineNo">743</span>    @Override<a name="line.743"></a>
-<span class="sourceLineNo">744</span>    protected CloseRegionResponse 
execCloseRegion(ServerName server, byte[] regionName)<a name="line.744"></a>
-<span class="sourceLineNo">745</span>        throws IOException {<a 
name="line.745"></a>
-<span class="sourceLineNo">746</span>      CloseRegionResponse.Builder resp = 
CloseRegionResponse.newBuilder();<a name="line.746"></a>
-<span class="sourceLineNo">747</span>      boolean closed = 
rand.nextBoolean();<a name="line.747"></a>
-<span class="sourceLineNo">748</span>      if (closed) {<a name="line.748"></a>
-<span class="sourceLineNo">749</span>        HRegionInfo hri = 
am.getRegionInfo(regionName);<a name="line.749"></a>
-<span class="sourceLineNo">750</span>        sendTransitionReport(server, 
HRegionInfo.convert(hri), TransitionCode.CLOSED);<a name="line.750"></a>
-<span class="sourceLineNo">751</span>      }<a name="line.751"></a>
-<span class="sourceLineNo">752</span>      resp.setClosed(closed);<a 
name="line.752"></a>
-<span class="sourceLineNo">753</span>      return resp.build();<a 
name="line.753"></a>
-<span class="sourceLineNo">754</span>    }<a name="line.754"></a>
-<span class="sourceLineNo">755</span>  }<a name="line.755"></a>
-<span class="sourceLineNo">756</span><a name="line.756"></a>
-<span class="sourceLineNo">757</span>  private interface MockRSExecutor {<a 
name="line.757"></a>
-<span class="sourceLineNo">758</span>    ExecuteProceduresResponse 
sendRequest(ServerName server, ExecuteProceduresRequest req)<a 
name="line.758"></a>
-<span class="sourceLineNo">759</span>        throws IOException;<a 
name="line.759"></a>
-<span class="sourceLineNo">760</span>  }<a name="line.760"></a>
-<span class="sourceLineNo">761</span><a name="line.761"></a>
-<span class="sourceLineNo">762</span>  private class MockRSProcedureDispatcher 
extends RSProcedureDispatcher {<a name="line.762"></a>
-<span class="sourceLineNo">763</span>    private MockRSExecutor mockRsExec;<a 
name="line.763"></a>
-<span class="sourceLineNo">764</span><a name="line.764"></a>
-<span class="sourceLineNo">765</span>    public 
MockRSProcedureDispatcher(final MasterServices master) {<a name="line.765"></a>
-<span class="sourceLineNo">766</span>      super(master);<a 
name="line.766"></a>
-<span class="sourceLineNo">767</span>    }<a name="line.767"></a>
-<span class="sourceLineNo">768</span><a name="line.768"></a>
-<span class="sourceLineNo">769</span>    public void setMockRsExecutor(final 
MockRSExecutor mockRsExec) {<a name="line.769"></a>
-<span class="sourceLineNo">770</span>      this.mockRsExec = mockRsExec;<a 
name="line.770"></a>
-<span class="sourceLineNo">771</span>    }<a name="line.771"></a>
-<span class="sourceLineNo">772</span><a name="line.772"></a>
-<span class="sourceLineNo">773</span>    @Override<a name="line.773"></a>
-<span class="sourceLineNo">774</span>    protected void 
remoteDispatch(ServerName serverName, Set&lt;RemoteProcedure&gt; operations) 
{<a name="line.774"></a>
-<span class="sourceLineNo">775</span>      submitTask(new 
MockRemoteCall(serverName, operations));<a name="line.775"></a>
-<span class="sourceLineNo">776</span>    }<a name="line.776"></a>
-<span class="sourceLineNo">777</span><a name="line.777"></a>
-<span class="sourceLineNo">778</span>    private class MockRemoteCall extends 
ExecuteProceduresRemoteCall {<a name="line.778"></a>
-<span class="sourceLineNo">779</span>      public MockRemoteCall(final 
ServerName serverName,<a name="line.779"></a>
-<span class="sourceLineNo">780</span>          final 
Set&lt;RemoteProcedure&gt; operations) {<a name="line.780"></a>
-<span class="sourceLineNo">781</span>        super(serverName, operations);<a 
name="line.781"></a>
-<span class="sourceLineNo">782</span>      }<a name="line.782"></a>
-<span class="sourceLineNo">783</span><a name="line.783"></a>
-<span class="sourceLineNo">784</span>      @Override<a name="line.784"></a>
-<span class="sourceLineNo">785</span>      protected ExecuteProceduresResponse 
sendRequest(final ServerName serverName,<a name="line.785"></a>
-<span class="sourceLineNo">786</span>          final ExecuteProceduresRequest 
request) throws IOException {<a name="line.786"></a>
-<span class="sourceLineNo">787</span>        return 
mockRsExec.sendRequest(serverName, request);<a name="line.787"></a>
-<span class="sourceLineNo">788</span>      }<a name="line.788"></a>
-<span class="sourceLineNo">789</span>    }<a name="line.789"></a>
-<span class="sourceLineNo">790</span>  }<a name="line.790"></a>
-<span class="sourceLineNo">791</span><a name="line.791"></a>
-<span class="sourceLineNo">792</span>  private class GoodSplitExecutor extends 
NoopRsExecutor {<a name="line.792"></a>
-<span class="sourceLineNo">793</span>    <a name="line.793"></a>
-<span class="sourceLineNo">794</span>    /*<a name="line.794"></a>
-<span class="sourceLineNo">795</span>    @Override<a name="line.795"></a>
-<span class="sourceLineNo">796</span>    protected RegionOpeningState 
execOpenRegion(ServerName server, RegionOpenInfo openReq)<a name="line.796"></a>
-<span class="sourceLineNo">797</span>        throws IOException {<a 
name="line.797"></a>
-<span class="sourceLineNo">798</span>      sendTransitionReport(server, 
openReq.getRegion(), TransitionCode.OPENED);<a name="line.798"></a>
-<span class="sourceLineNo">799</span>      // Concurrency?<a 
name="line.799"></a>
-<span class="sourceLineNo">800</span>      // Now update the state of our 
cluster in regionsToRegionServers.<a name="line.800"></a>
-<span class="sourceLineNo">801</span>      SortedSet&lt;byte []&gt; regions = 
regionsToRegionServers.get(server);<a name="line.801"></a>
-<span class="sourceLineNo">802</span>      if (regions == null) {<a 
name="line.802"></a>
-<span class="sourceLineNo">803</span>        regions = new 
ConcurrentSkipListSet&lt;byte[]&gt;(Bytes.BYTES_COMPARATOR);<a 
name="line.803"></a>
-<span class="sourceLineNo">804</span>        
regionsToRegionServers.put(server, regions);<a name="line.804"></a>
-<span class="sourceLineNo">805</span>      }<a name="line.805"></a>
-<span class="sourceLineNo">806</span>      HRegionInfo hri = 
HRegionInfo.convert(openReq.getRegion());<a name="line.806"></a>
-<span class="sourceLineNo">807</span>      if 
(regions.contains(hri.getRegionName())) {<a name="line.807"></a>
-<span class="sourceLineNo">808</span>        throw new 
UnsupportedOperationException(hri.getRegionNameAsString());<a 
name="line.808"></a>
-<span class="sourceLineNo">809</span>      }<a name="line.809"></a>
-<span class="sourceLineNo">810</span>      regions.add(hri.getRegionName());<a 
name="line.810"></a>
-<span class="sourceLineNo">811</span>      return RegionOpeningState.OPENED;<a 
name="line.811"></a>
-<span class="sourceLineNo">812</span>    }<a name="line.812"></a>
-<span class="sourceLineNo">813</span><a name="line.813"></a>
-<span class="sourceLineNo">814</span>    @Override<a name="line.814"></a>
-<span class="sourceLineNo">815</span>    protected CloseRegionResponse 
execCloseRegion(ServerName server, byte[] regionName)<a name="line.815"></a>
-<span class="sourceLineNo">816</span>        throws IOException {<a 
name="line.816"></a>
-<span class="sourceLineNo">817</span>      HRegionInfo hri = 
am.getRegionInfo(regionName);<a name="line.817"></a>
-<span class="sourceLineNo">818</span>      sendTransitionReport(server, 
HRegionInfo.convert(hri), TransitionCode.CLOSED);<a name="line.818"></a>
-<span class="sourceLineNo">819</span>      return 
CloseRegionResponse.newBuilder().setClosed(true).build();<a name="line.819"></a>
-<span class="sourceLineNo">820</span>    }*/<a name="line.820"></a>
-<span class="sourceLineNo">821</span>    <a name="line.821"></a>
-<span class="sourceLineNo">822</span>  }<a name="line.822"></a>
-<span class="sourceLineNo">823</span><a name="line.823"></a>
-<span class="sourceLineNo">824</span>  private void 
collectAssignmentManagerMetrics() {<a name="line.824"></a>
-<span class="sourceLineNo">825</span>    assignSubmittedCount = 
assignProcMetrics.getSubmittedCounter().getCount();<a name="line.825"></a>
-<span class="sourceLineNo">826</span>    assignFailedCount = 
assignProcMetrics.getFailedCounter().getCount();<a name="line.826"></a>
-<span class="sourceLineNo">827</span>    unassignSubmittedCount = 
unassignProcMetrics.getSubmittedCounter().getCount();<a name="line.827"></a>
-<span class="sourceLineNo">828</span>    unassignFailedCount = 
unassignProcMetrics.getFailedCounter().getCount();<a name="line.828"></a>
-<span class="sourceLineNo">829</span>  }<a name="line.829"></a>
-<span class="sourceLineNo">830</span>}<a name="line.830"></a>
+<span class="sourceLineNo">312</span>  @Test<a name="line.312"></a>
+<span class="sourceLineNo">313</span>  public void 
testIOExceptionOnAssignment() throws Exception {<a name="line.313"></a>
+<span class="sourceLineNo">314</span>    // collect AM metrics before test<a 
name="line.314"></a>
+<span class="sourceLineNo">315</span>    collectAssignmentManagerMetrics();<a 
name="line.315"></a>
+<span class="sourceLineNo">316</span><a name="line.316"></a>
+<span class="sourceLineNo">317</span>    
testFailedOpen(TableName.valueOf("testExceptionOnAssignment"),<a 
name="line.317"></a>
+<span class="sourceLineNo">318</span>      new FaultyRsExecutor(new 
IOException("test fault")));<a name="line.318"></a>
+<span class="sourceLineNo">319</span><a name="line.319"></a>
+<span class="sourceLineNo">320</span>    assertEquals(assignSubmittedCount + 
1, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.320"></a>
+<span class="sourceLineNo">321</span>    assertEquals(assignFailedCount + 1, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.321"></a>
+<span class="sourceLineNo">322</span>  }<a name="line.322"></a>
+<span class="sourceLineNo">323</span><a name="line.323"></a>
+<span class="sourceLineNo">324</span>  @Test<a name="line.324"></a>
+<span class="sourceLineNo">325</span>  public void 
testDoNotRetryExceptionOnAssignment() throws Exception {<a name="line.325"></a>
+<span class="sourceLineNo">326</span>    // collect AM metrics before test<a 
name="line.326"></a>
+<span class="sourceLineNo">327</span>    collectAssignmentManagerMetrics();<a 
name="line.327"></a>
+<span class="sourceLineNo">328</span><a name="line.328"></a>
+<span class="sourceLineNo">329</span>    
testFailedOpen(TableName.valueOf("testDoNotRetryExceptionOnAssignment"),<a 
name="line.329"></a>
+<span class="sourceLineNo">330</span>      new FaultyRsExecutor(new 
DoNotRetryIOException("test do not retry fault")));<a name="line.330"></a>
+<span class="sourceLineNo">331</span><a name="line.331"></a>
+<span class="sourceLineNo">332</span>    assertEquals(assignSubmittedCount + 
1, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.332"></a>
+<span class="sourceLineNo">333</span>    assertEquals(assignFailedCount + 1, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.333"></a>
+<span class="sourceLineNo">334</span>  }<a name="line.334"></a>
+<span class="sourceLineNo">335</span><a name="line.335"></a>
+<span class="sourceLineNo">336</span>  private void testFailedOpen(final 
TableName tableName,<a name="line.336"></a>
+<span class="sourceLineNo">337</span>      final MockRSExecutor executor) 
throws Exception {<a name="line.337"></a>
+<span class="sourceLineNo">338</span>    final HRegionInfo hri = 
createRegionInfo(tableName, 1);<a name="line.338"></a>
+<span class="sourceLineNo">339</span><a name="line.339"></a>
+<span class="sourceLineNo">340</span>    // Test Assign operation failure<a 
name="line.340"></a>
+<span class="sourceLineNo">341</span>    
rsDispatcher.setMockRsExecutor(executor);<a name="line.341"></a>
+<span class="sourceLineNo">342</span>    try {<a name="line.342"></a>
+<span class="sourceLineNo">343</span>      
waitOnFuture(submitProcedure(am.createAssignProcedure(hri, false)));<a 
name="line.343"></a>
+<span class="sourceLineNo">344</span>      fail("unexpected assign 
completion");<a name="line.344"></a>
+<span class="sourceLineNo">345</span>    } catch (RetriesExhaustedException e) 
{<a name="line.345"></a>
+<span class="sourceLineNo">346</span>      // expected exception<a 
name="line.346"></a>
+<span class="sourceLineNo">347</span>      LOG.info("REGION STATE " + 
am.getRegionStates().getRegionNode(hri));<a name="line.347"></a>
+<span class="sourceLineNo">348</span>      LOG.info("expected exception from 
assign operation: " + e.getMessage(), e);<a name="line.348"></a>
+<span class="sourceLineNo">349</span>      assertEquals(true, 
am.getRegionStates().getRegionState(hri).isFailedOpen());<a name="line.349"></a>
+<span class="sourceLineNo">350</span>    }<a name="line.350"></a>
+<span class="sourceLineNo">351</span>  }<a name="line.351"></a>
+<span class="sourceLineNo">352</span><a name="line.352"></a>
+<span class="sourceLineNo">353</span>  private void testAssign(final 
MockRSExecutor executor) throws Exception {<a name="line.353"></a>
+<span class="sourceLineNo">354</span>    testAssign(executor, NREGIONS);<a 
name="line.354"></a>
+<span class="sourceLineNo">355</span>  }<a name="line.355"></a>
+<span class="sourceLineNo">356</span><a name="line.356"></a>
+<span class="sourceLineNo">357</span>  private void testAssign(final 
MockRSExecutor executor, final int nregions) throws Exception {<a 
name="line.357"></a>
+<span class="sourceLineNo">358</span>    
rsDispatcher.setMockRsExecutor(executor);<a name="line.358"></a>
+<span class="sourceLineNo">359</span><a name="line.359"></a>
+<span class="sourceLineNo">360</span>    AssignProcedure[] assignments = new 
AssignProcedure[nregions];<a name="line.360"></a>
+<span class="sourceLineNo">361</span><a name="line.361"></a>
+<span class="sourceLineNo">362</span>    long st = 
System.currentTimeMillis();<a name="line.362"></a>
+<span class="sourceLineNo">363</span>    bulkSubmit(assignments);<a 
name="line.363"></a>
+<span class="sourceLineNo">364</span><a name="line.364"></a>
+<span class="sourceLineNo">365</span>    for (int i = 0; i &lt; 
assignments.length; ++i) {<a name="line.365"></a>
+<span class="sourceLineNo">366</span>      
ProcedureTestingUtility.waitProcedure(<a name="line.366"></a>
+<span class="sourceLineNo">367</span>        
master.getMasterProcedureExecutor(), assignments[i]);<a name="line.367"></a>
+<span class="sourceLineNo">368</span>      
assertTrue(assignments[i].toString(), assignments[i].isSuccess());<a 
name="line.368"></a>
+<span class="sourceLineNo">369</span>    }<a name="line.369"></a>
+<span class="sourceLineNo">370</span>    long et = 
System.currentTimeMillis();<a name="line.370"></a>
+<span class="sourceLineNo">371</span>    float sec = ((et - st) / 1000.0f);<a 
name="line.371"></a>
+<span class="sourceLineNo">372</span>    LOG.info(String.format("[T] Assigning 
%dprocs in %s (%.2fproc/sec)",<a name="line.372"></a>
+<span class="sourceLineNo">373</span>        assignments.length, 
StringUtils.humanTimeDiff(et - st), assignments.length / sec));<a 
name="line.373"></a>
+<span class="sourceLineNo">374</span>  }<a name="line.374"></a>
+<span class="sourceLineNo">375</span><a name="line.375"></a>
+<span class="sourceLineNo">376</span>  @Test<a name="line.376"></a>
+<span class="sourceLineNo">377</span>  public void 
testAssignAnAssignedRegion() throws Exception {<a name="line.377"></a>
+<span class="sourceLineNo">378</span>    final TableName tableName = 
TableName.valueOf("testAssignAnAssignedRegion");<a name="line.378"></a>
+<span class="sourceLineNo">379</span>    final HRegionInfo hri = 
createRegionInfo(tableName, 1);<a name="line.379"></a>
+<span class="sourceLineNo">380</span><a name="line.380"></a>
+<span class="sourceLineNo">381</span>    // collect AM metrics before test<a 
name="line.381"></a>
+<span class="sourceLineNo">382</span>    collectAssignmentManagerMetrics();<a 
name="line.382"></a>
+<span class="sourceLineNo">383</span><a name="line.383"></a>
+<span class="sourceLineNo">384</span>    rsDispatcher.setMockRsExecutor(new 
GoodRsExecutor());<a name="line.384"></a>
+<span class="sourceLineNo">385</span><a name="line.385"></a>
+<span class="sourceLineNo">386</span>    final Future&lt;byte[]&gt; futureA = 
submitProcedure(am.createAssignProcedure(hri, false));<a name="line.386"></a>
+<span class="sourceLineNo">387</span><a name="line.387"></a>
+<span class="sourceLineNo">388</span>    // wait first assign<a 
name="line.388"></a>
+<span class="sourceLineNo">389</span>    waitOnFuture(futureA);<a 
name="line.389"></a>
+<span class="sourceLineNo">390</span>    
am.getRegionStates().isRegionInState(hri, State.OPEN);<a name="line.390"></a>
+<span class="sourceLineNo">391</span>    // Second should be a noop. We should 
recognize region is already OPEN internally<a name="line.391"></a>
+<span class="sourceLineNo">392</span>    // and skip out doing nothing.<a 
name="line.392"></a>
+<span class="sourceLineNo">393</span>    // wait second assign<a 
name="line.393"></a>
+<span class="sourceLineNo">394</span>    final Future&lt;byte[]&gt; futureB = 
submitProcedure(am.createAssignProcedure(hri, false));<a name="line.394"></a>
+<span class="sourceLineNo">395</span>    waitOnFuture(futureB);<a 
name="line.395"></a>
+<span class="sourceLineNo">396</span>    
am.getRegionStates().isRegionInState(hri, State.OPEN);<a name="line.396"></a>
+<span class="sourceLineNo">397</span>    // TODO: What else can we do to 
ensure just a noop.<a name="line.397"></a>
+<span class="sourceLineNo">398</span><a name="line.398"></a>
+<span class="sourceLineNo">399</span>    // TODO: Though second assign is 
noop, it's considered success, can noop be handled in a<a name="line.399"></a>
+<span class="sourceLineNo">400</span>    // better way?<a name="line.400"></a>
+<span class="sourceLineNo">401</span>    assertEquals(assignSubmittedCount + 
2, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.401"></a>
+<span class="sourceLineNo">402</span>    assertEquals(assignFailedCount, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.402"></a>
+<span class="sourceLineNo">403</span><a name="line.403"></a>
+<span class="sourceLineNo">404</span>  }<a name="line.404"></a>
+<span class="sourceLineNo">405</span><a name="line.405"></a>
+<span class="sourceLineNo">406</span>  @Test<a name="line.406"></a>
+<span class="sourceLineNo">407</span>  public void 
testUnassignAnUnassignedRegion() throws Exception {<a name="line.407"></a>
+<span class="sourceLineNo">408</span>    final TableName tableName = 
TableName.valueOf("testUnassignAnUnassignedRegion");<a name="line.408"></a>
+<span class="sourceLineNo">409</span>    final HRegionInfo hri = 
createRegionInfo(tableName, 1);<a name="line.409"></a>
+<span class="sourceLineNo">410</span><a name="line.410"></a>
+<span class="sourceLineNo">411</span>    // collect AM metrics before test<a 
name="line.411"></a>
+<span class="sourceLineNo">412</span>    collectAssignmentManagerMetrics();<a 
name="line.412"></a>
+<span class="sourceLineNo">413</span><a name="line.413"></a>
+<span class="sourceLineNo">414</span>    rsDispatcher.setMockRsExecutor(new 
GoodRsExecutor());<a name="line.414"></a>
+<span class="sourceLineNo">415</span><a name="line.415"></a>
+<span class="sourceLineNo">416</span>    // assign the region first<a 
name="line.416"></a>
+<span class="sourceLineNo">417</span>    
waitOnFuture(submitProcedure(am.createAssignProcedure(hri, false)));<a 
name="line.417"></a>
+<span class="sourceLineNo">418</span><a name="line.418"></a>
+<span class="sourceLineNo">419</span>    final Future&lt;byte[]&gt; futureA = 
submitProcedure(am.createUnassignProcedure(hri, null, false));<a 
name="line.419"></a>
+<span class="sourceLineNo">420</span><a name="line.420"></a>
+<span class="sourceLineNo">421</span>    // Wait first unassign.<a 
name="line.421"></a>
+<span class="sourceLineNo">422</span>    waitOnFuture(futureA);<a 
name="line.422"></a>
+<span class="sourceLineNo">423</span>    
am.getRegionStates().isRegionInState(hri, State.CLOSED);<a name="line.423"></a>
+<span class="sourceLineNo">424</span>    // Second should be a noop. We should 
recognize region is already CLOSED internally<a name="line.424"></a>
+<span class="sourceLineNo">425</span>    // and skip out doing nothing.<a 
name="line.425"></a>
+<span class="sourceLineNo">426</span>    final Future&lt;byte[]&gt; futureB 
=<a name="line.426"></a>
+<span class="sourceLineNo">427</span>        
submitProcedure(am.createUnassignProcedure(hri,<a name="line.427"></a>
+<span class="sourceLineNo">428</span>            
ServerName.valueOf("example.org,1234,1"), false));<a name="line.428"></a>
+<span class="sourceLineNo">429</span>    waitOnFuture(futureB);<a 
name="line.429"></a>
+<span class="sourceLineNo">430</span>    // Ensure we are still CLOSED.<a 
name="line.430"></a>
+<span class="sourceLineNo">431</span>    
am.getRegionStates().isRegionInState(hri, State.CLOSED);<a name="line.431"></a>
+<span class="sourceLineNo">432</span>    // TODO: What else can we do to 
ensure just a noop.<a name="line.432"></a>
+<span class="sourceLineNo">433</span><a name="line.433"></a>
+<span class="sourceLineNo">434</span>    assertEquals(assignSubmittedCount + 
1, assignProcMetrics.getSubmittedCounter().getCount());<a name="line.434"></a>
+<span class="sourceLineNo">435</span>    assertEquals(assignFailedCount, 
assignProcMetrics.getFailedCounter().getCount());<a name="line.435"></a>
+<span class="sourceLineNo">436</span>    // TODO: Though second unassign is 
noop, it's considered success, can noop be handled in a<a name="line.436"></a>
+<span class="sourceLineNo">437</span>    // better way?<a name="line.437"></a>
+<span class="sourceLineNo">438</span>    assertEquals(unassignSubmittedCount + 
2, unassignProcMetrics.getSubmittedCounter().getCount());<a name="line.438"></a>
+<span class="sourceLineNo">439</span>    assertEquals(unassignFailedCount, 
unassignProcMetrics.getFailedCounter().getCount());<a name="line.439"></a>
+<span class="sourceLineNo">440</span>  }<a name="line.440"></a>
+<span class="sourceLineNo">441</span><a name="line.441"></a>
+<span class="sourceLineNo">442</span>  private Future&lt;byte[]&gt; 
submitProcedure(final Procedure proc) {<a name="line.442"></a>
+<span class="sourceLineNo">443</span>    return 
ProcedureSyncWait.submitProcedure(master.getMasterProcedureExecutor(), proc);<a 
name="line.443"></a>
+<span class="sourceLineNo">444</span>  }<a name="line.444"></a>
+<span class="sourceLineNo">445</span><a name="line.445"></a>
+<span class="sourceLineNo">446</span>  private byte[] waitOnFuture(final 
Future&lt;byte[]&gt; future) throws Exception {<a name="line.446"></a>
+<span class="sourceLineNo">447</span>    try {<a name="line.447"></a>
+<span class="sourceLineNo">448</span>      return future.get(5, 
TimeUnit.SECONDS);<a name="line.448"></a>
+<span class="sourceLineNo">449</span>    } catch (ExecutionException e) {<a 
name="line.449"></a>
+<span class="sourceLineNo">450</span>      LOG.info("ExecutionException", 
e);<a name="line.450"></a>
+<span class="sourceLineNo">451</span>      throw (Exception)e.getCause();<a 
name="line.451"></a>
+<span class="sourceLineNo">452</span>    }<a name="line.452"></a>
+<span class="sourceLineNo">453</span>  }<a name="line.453"></a>
+<span class="sourceLineNo">454</span><a name="line.454"></a>
+<span class="sourceLineNo">455</span>  // 
============================================================================================<a
 name="line.455"></a>
+<span class="sourceLineNo">456</span>  //  Helpers<a name="line.456"></a>
+<span class="sourceLineNo">457</span>  // 
============================================================================================<a
 name="line.457"></a>
+<span class="sourceLineNo">458</span>  private void bulkSubmit(final 
AssignProcedure[] procs) throws Exception {<a name="line.458"></a>
+<span class="sourceLineNo">459</span>    final Thread[] threads = new 
Thread[PROC_NTHREADS];<a name="line.459"></a>
+<span class="sourceLineNo">460</span>    for (int i = 0; i &lt; 
threads.length; ++i) {<a name="line.460"></a>
+<span class="sourceLineNo">461</span>      final int threadId = i;<a 
name="line.461"></a>
+<span class="sourceLineNo">462</span>      threads[i] = new Thread() {<a 
name="line.462"></a>
+<span class="sourceLineNo">463</span>        @Override<a name="line.463"></a>
+<span class="sourceLineNo">464</span>        public void run() {<a 
name="line.464"></a>
+<span class="sourceLineNo">465</span>          TableName tableName = 
TableName.valueOf("table-" + threadId);<a name="line.465"></a>
+<span class="sourceLineNo">466</span>          int n = (procs.length / 
threads.length);<a name="line.466"></a>
+<span class="sourceLineNo">467</span>          int start = threadId * n;<a 
name="line.467"></a>
+<span class="sourceLineNo">468</span>          int stop = start + n;<a 
name="line.468"></a>
+<span class="sourceLineNo">469</span>          for (int j = start; j &lt; 
stop; ++j) {<a name="line.469"></a>
+<span class="sourceLineNo">470</span>            procs[j] = 
createAndSubmitAssign(tableName, j);<a name="line.470"></a>
+<span class="sourceLineNo">471</span>          }<a name="line.471"></a>
+<span class="sourceLineNo">472</span>        }<a name="line.472"></a>
+<span class="sourceLineNo">473</span>      };<a name="line.473"></a>
+<span class="sourceLineNo">474</span>      threads[i].start();<a 
name="line.474"></a>
+<span class="sourceLineNo">475</span>    }<a name="line.475"></a>
+<span class="sourceLineNo">476</span>    for (int i = 0; i &lt; 
threads.length; ++i) {<a name="line.476"></a>
+<span class="sourceLineNo">477</span>      threads[i].join();<a 
name="line.477"></a>
+<span class="sourceLineNo">478</span>    }<a name="line.478"></a>
+<span class="sourceLineNo">479</span>    for (int i = procs.length - 1; i 
&gt;= 0 &amp;&amp; procs[i] == null; --i) {<a name="line.479"></a>
+<span class="sourceLineNo">480</span>      procs[i] = 
createAndSubmitAssign(TableName.valueOf("table-sync"), i);<a 
name="line.480"></a>
+<span class="sourceLineNo">481</span>    }<a name="line.481"></a>
+<span class="sourceLineNo">482</span>  }<a name="line.482"></a>
+<span class="sourceLineNo">483</span><a name="line.483"></a>
+<span class="sourceLineNo">484</span>  private AssignProcedure 
createAndSubmitAssign(TableName tableName, int regionId) {<a 
name="line.484"></a>
+<span class="sourceLineNo">485</span>    HRegionInfo hri = 
createRegionInfo(tableName, regionId);<a name="line.485"></a>
+<span class="sourceLineNo">486</span>    AssignProcedure proc = 
am.createAssignProcedure(hri, false);<a name="line.486"></a>
+<span class="sourceLineNo">487</span>    
master.getMasterProcedureExecutor().submitProcedure(proc);<a 
name="line.487"></a>
+<span class="sourceLineNo">488</span>    return proc;<a name="line.488"></a>
+<span class="sourceLineNo">489</span>  }<a name="line.489"></a>
+<span class="sourceLineNo">490</span><a name="line.490"></a>
+<span class="sourceLineNo">491</span>  private UnassignProcedure 
createAndSubmitUnassign(TableName tableName, int regionId) {<a 
name="line.491"></a>
+<span class="sourceLineNo">492</span>    HRegionInfo hri = 
createRegionInfo(tableName, regionId);<a name="line.492"></a>
+<span class="sourceLineNo">493</span>    UnassignProcedure proc = 
am.createUnassignProcedure(hri, null, false);<a name="line.493"></a>
+<span class="sourceLineNo">494</span>    
master.getMasterProcedureExecutor().submitProcedure(proc);<a 
name="line.494"></a>
+<span class="sourceLineNo">495</span>    return proc;<a name="line.495"></a>
+<span class="sourceLineNo">496</span>  }<a name="line.496"></a>
+<span class="sourceLineNo">497</span><a name="line.497"></a>
+<span class="sourceLineNo">498</span>  private HRegionInfo 
createRegionInfo(final TableName tableName, final long regionId) {<a 
name="line.498"></a>
+<span class="sourceLineNo">499</span>    return new HRegionInfo(tableName,<a 
name="line.499"></a>
+<span class="sourceLineNo">500</span>      Bytes.toBytes(regionId), 
Bytes.toBytes(regionId + 1), false, 0);<a name="line.500"></a>
+<span class="sourceLineNo">501</span>  }<a name="line.501"></a>
+<span class="sourceLineNo">502</span><a name="line.502"></a>
+<span class="sourceLineNo">503</span>  private void sendTransitionReport(final 
ServerName serverName,<a name="line.503"></a>
+<span class="sourceLineNo">504</span>      final RegionInfo regionInfo, final 
TransitionCode state) throws IOException {<a name="line.504"></a>
+<span class="sourceLineNo">505</span>    
ReportRegionStateTransitionRequest.Builder req =<a name="line.505"></a>
+<span class="sourceLineNo">506</span>      
ReportRegionStateTransitionRequest.newBuilder();<a name="line.506"></a>
+<span class="sourceLineNo">507</span>    
req.setServer(ProtobufUtil.toServerName(serverName));<a name="line.507"></a>
+<span class="sourceLineNo">508</span>    
req.addTransition(RegionStateTransition.newBuilder()<a name="line.508"></a>
+<span class="sourceLineNo">509</span>      .addRegionInfo(regionInfo)<a 
name="line.509"></a>
+<span class="sourceLineNo">510</span>      .setTransitionCode(state)<a 
name="line.510"></a>
+<span class="sourceLineNo">511</span>      .setOpenSeqNum(1)<a 
name="line.511"></a>
+<span class="sourceLineNo">512</span>      .build());<a name="line.512"></a>
+<span class="sourceLineNo">513</span>    
am.reportRegionStateTransition(req.build());<a name="line.513"></a>
+<span class="sourceLineNo">514</span>  }<a name="line.514"></a>
+<span class="sourceLineNo">515</span><a name="line.515"></a>
+<span class="sourceLineNo">516</span>  private void doCrash(final ServerName 
serverName) {<a name="line.516"></a>
+<span class="sourceLineNo">517</span>    this.am.submitServerCrash(serverName, 
false/*No WALs here*/);<a name="line.517"></a>
+<span class="sourceLineNo">518</span>  }<a name="line.518"></a>
+<span class="sourceLineNo">519</span><a name="line.519"></a>
+<span class="sourceLineNo">520</span>  private class NoopRsExecutor implements 
MockRSExecutor {<a name="line.520"></a>
+<span class="sourceLineNo">521</span>    public ExecuteProceduresResponse 
sendRequest(ServerName server,<a name="line.521"></a>
+<span class="sourceLineNo">522</span>        ExecuteProceduresRequest request) 
throws IOException {<a name="line.522"></a>
+<span class="sourceLineNo">523</span>      ExecuteProceduresResponse.Builder 
builder = ExecuteProceduresResponse.newBuilder();<a name="line.523"></a>
+<span class="sourceLineNo">524</span>      if (request.getOpenRegionCount() 
&gt; 0) {<a name="line.524"></a>
+<span class="sourceLineNo">525</span>        for (OpenRegionRequest req: 
request.getOpenRegionList()) {<a name="line.525"></a>
+<span class="sourceLineNo">526</span>          OpenRegionResponse.Builder resp 
= OpenRegionResponse.newBuilder();<a name="line.526"></a>
+<span class="sourceLineNo">527</span>          for (RegionOpenInfo openReq: 
req.getOpenInfoList()) {<a name="line.527"></a>
+<span class="sourceLineNo">528</span>            RegionOpeningState state = 
execOpenRegion(server, openReq);<a name="line.528"></a>
+<span class="sourceLineNo">529</span>            if (state != null) {<a 
name="line.529"></a>
+<span class="sourceLineNo">530</span>              
resp.addOpeningState(state);<a name="line.530"></a>
+<span class="sourceLineNo">531</span>            }<a name="line.531"></a>
+<span class="sourceLineNo">532</span>          }<a name="line.532"></a>
+<span class="sourceLineNo">533</span>          
builder.addOpenRegion(resp.build());<a name="line.533"></a>
+<span class="sourceLineNo">534</span>        }<a name="line.534"></a>
+<span class="sourceLineNo">535</span>      }<a name="line.535"></a>
+<span class="sourceLineNo">536</span>      if (request.getCloseRegionCount() 
&gt; 0) {<a name="line.536"></a>
+<span class="sourceLineNo">537</span>        for (CloseRegionRequest req: 
request.getCloseRegionList()) {<a name="line.537"></a>
+<span class="sourceLineNo">538</span>          CloseRegionResponse resp = 
execCloseRegion(server,<a name="line.538"></a>
+<span class="sourceLineNo">539</span>              
req.getRegion().getValue().toByteArray());<a name="line.539"></a>
+<span class="sourceLineNo">540</span>          if (resp != null) {<a 
name="line.540"></a>
+<span class="sourceLineNo">541</span>            
builder.addCloseRegion(resp);<a name="line.541"></a>
+<span class="sourceLineNo">542</span>          }<a name="line.542"></a>
+<span c

<TRUNCATED>

Reply via email to