HBASE-18679 Add a null check around the result of getCounters() in ITBLL
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/2773510f Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/2773510f Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/2773510f Branch: refs/heads/HBASE-18467 Commit: 2773510f120730f926569fef30c3e7b766517e89 Parents: 439191e Author: Josh Elser <els...@apache.org> Authored: Thu Aug 24 17:52:13 2017 -0400 Committer: Josh Elser <els...@apache.org> Committed: Fri Aug 25 18:40:02 2017 -0400 ---------------------------------------------------------------------- .../hbase/test/IntegrationTestBigLinkedList.java | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/2773510f/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java ---------------------------------------------------------------------- diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java index 2fdfab6..f05ef66 100644 --- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java +++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java @@ -820,6 +820,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase { public boolean verify() { try { Counters counters = job.getCounters(); + if (counters == null) { + LOG.info("Counters object was null, Generator verification cannot be performed." + + " This is commonly a result of insufficient YARN configuration."); + return false; + } if (counters.findCounter(Counts.TERMINATING).getValue() > 0 || counters.findCounter(Counts.UNDEFINED).getValue() > 0 || @@ -1315,7 +1320,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase { if (success) { Counters counters = job.getCounters(); if (null == counters) { - LOG.warn("Counters were null, cannot verify Job completion"); + LOG.warn("Counters were null, cannot verify Job completion." + + " This is commonly a result of insufficient YARN configuration."); // We don't have access to the counters to know if we have "bad" counts return 0; } @@ -1337,6 +1343,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase { } Counters counters = job.getCounters(); + if (counters == null) { + LOG.info("Counters object was null, write verification cannot be performed." + + " This is commonly a result of insufficient YARN configuration."); + return false; + } // Run through each check, even if we fail one early boolean success = verifyExpectedValues(expectedReferenced, counters);
