[20/29] hbase-site git commit: Published site at .

git-site-role Mon, 09 Oct 2017 08:13:55 -0700
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/e6ae7c3e/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/StoreFileWriter.Builder.html
----------------------------------------------------------------------
diff --git 
a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/StoreFileWriter.Builder.html
 
b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/StoreFileWriter.Builder.html
index 02426b3..679955d 100644
--- 
a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/StoreFileWriter.Builder.html
+++ 
b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/StoreFileWriter.Builder.html
@@ -79,462 +79,413 @@
 <span class="sourceLineNo">071</span>  private long deleteFamilyCnt = 0;<a 
name="line.71"></a>
 <span class="sourceLineNo">072</span>  private BloomContext bloomContext = 
null;<a name="line.72"></a>
 <span class="sourceLineNo">073</span>  private BloomContext 
deleteFamilyBloomContext = null;<a name="line.73"></a>
-<span class="sourceLineNo">074</span><a name="line.74"></a>
-<span class="sourceLineNo">075</span>  /**<a name="line.75"></a>
-<span class="sourceLineNo">076</span>   * timeRangeTrackerSet is used to 
figure if we were passed a filled-out TimeRangeTracker or not.<a 
name="line.76"></a>
-<span class="sourceLineNo">077</span>   * When flushing a memstore, we set the 
TimeRangeTracker that it accumulated during updates to<a name="line.77"></a>
-<span class="sourceLineNo">078</span>   * memstore in here into this Writer 
and use this variable to indicate that we do not need to<a name="line.78"></a>
-<span class="sourceLineNo">079</span>   * recalculate the timeRangeTracker 
bounds; it was done already as part of add-to-memstore.<a name="line.79"></a>
-<span class="sourceLineNo">080</span>   * A completed TimeRangeTracker is not 
set in cases of compactions when it is recalculated.<a name="line.80"></a>
-<span class="sourceLineNo">081</span>   */<a name="line.81"></a>
-<span class="sourceLineNo">082</span>   private final boolean 
timeRangeTrackerSet;<a name="line.82"></a>
-<span class="sourceLineNo">083</span>   final TimeRangeTracker 
timeRangeTracker;<a name="line.83"></a>
-<span class="sourceLineNo">084</span><a name="line.84"></a>
-<span class="sourceLineNo">085</span>  protected HFile.Writer writer;<a 
name="line.85"></a>
-<span class="sourceLineNo">086</span><a name="line.86"></a>
-<span class="sourceLineNo">087</span>  /**<a name="line.87"></a>
-<span class="sourceLineNo">088</span>   * Creates an HFile.Writer that also 
write helpful meta data.<a name="line.88"></a>
-<span class="sourceLineNo">089</span>   * @param fs file system to write to<a 
name="line.89"></a>
-<span class="sourceLineNo">090</span>   * @param path file name to create<a 
name="line.90"></a>
-<span class="sourceLineNo">091</span>   * @param conf user configuration<a 
name="line.91"></a>
-<span class="sourceLineNo">092</span>   * @param comparator key comparator<a 
name="line.92"></a>
-<span class="sourceLineNo">093</span>   * @param bloomType bloom filter 
setting<a name="line.93"></a>
-<span class="sourceLineNo">094</span>   * @param maxKeys the expected maximum 
number of keys to be added. Was used<a name="line.94"></a>
-<span class="sourceLineNo">095</span>   *        for Bloom filter size in 
{@link HFile} format version 1.<a name="line.95"></a>
-<span class="sourceLineNo">096</span>   * @param fileContext - The HFile 
context<a name="line.96"></a>
-<span class="sourceLineNo">097</span>   * @param shouldDropCacheBehind Drop 
pages written to page cache after writing the store file.<a name="line.97"></a>
-<span class="sourceLineNo">098</span>   * @throws IOException problem writing 
to FS<a name="line.98"></a>
-<span class="sourceLineNo">099</span>   */<a name="line.99"></a>
-<span class="sourceLineNo">100</span>  StoreFileWriter(FileSystem fs, Path 
path, final Configuration conf, CacheConfig cacheConf,<a name="line.100"></a>
-<span class="sourceLineNo">101</span>      final CellComparator comparator, 
BloomType bloomType, long maxKeys,<a name="line.101"></a>
-<span class="sourceLineNo">102</span>      InetSocketAddress[] favoredNodes, 
HFileContext fileContext, boolean shouldDropCacheBehind)<a name="line.102"></a>
-<span class="sourceLineNo">103</span>          throws IOException {<a 
name="line.103"></a>
-<span class="sourceLineNo">104</span>      this(fs, path, conf, cacheConf, 
comparator, bloomType, maxKeys, favoredNodes, fileContext,<a 
name="line.104"></a>
-<span class="sourceLineNo">105</span>          shouldDropCacheBehind, null);<a 
name="line.105"></a>
-<span class="sourceLineNo">106</span>    }<a name="line.106"></a>
-<span class="sourceLineNo">107</span><a name="line.107"></a>
-<span class="sourceLineNo">108</span>    /**<a name="line.108"></a>
-<span class="sourceLineNo">109</span>     * Creates an HFile.Writer that also 
write helpful meta data.<a name="line.109"></a>
-<span class="sourceLineNo">110</span>     * @param fs file system to write 
to<a name="line.110"></a>
-<span class="sourceLineNo">111</span>     * @param path file name to create<a 
name="line.111"></a>
-<span class="sourceLineNo">112</span>     * @param conf user configuration<a 
name="line.112"></a>
-<span class="sourceLineNo">113</span>     * @param comparator key comparator<a 
name="line.113"></a>
-<span class="sourceLineNo">114</span>     * @param bloomType bloom filter 
setting<a name="line.114"></a>
-<span class="sourceLineNo">115</span>     * @param maxKeys the expected 
maximum number of keys to be added. Was used<a name="line.115"></a>
-<span class="sourceLineNo">116</span>     *        for Bloom filter size in 
{@link HFile} format version 1.<a name="line.116"></a>
-<span class="sourceLineNo">117</span>     * @param favoredNodes<a 
name="line.117"></a>
-<span class="sourceLineNo">118</span>     * @param fileContext - The HFile 
context<a name="line.118"></a>
-<span class="sourceLineNo">119</span>     * @param shouldDropCacheBehind Drop 
pages written to page cache after writing the store file.<a name="line.119"></a>
-<span class="sourceLineNo">120</span>     * @param trt Ready-made timetracker 
to use.<a name="line.120"></a>
-<span class="sourceLineNo">121</span>     * @throws IOException problem 
writing to FS<a name="line.121"></a>
-<span class="sourceLineNo">122</span>     */<a name="line.122"></a>
-<span class="sourceLineNo">123</span>    private StoreFileWriter(FileSystem 
fs, Path path,<a name="line.123"></a>
-<span class="sourceLineNo">124</span>        final Configuration conf,<a 
name="line.124"></a>
-<span class="sourceLineNo">125</span>        CacheConfig cacheConf,<a 
name="line.125"></a>
-<span class="sourceLineNo">126</span>        final CellComparator comparator, 
BloomType bloomType, long maxKeys,<a name="line.126"></a>
-<span class="sourceLineNo">127</span>        InetSocketAddress[] favoredNodes, 
HFileContext fileContext,<a name="line.127"></a>
-<span class="sourceLineNo">128</span>        boolean shouldDropCacheBehind, 
final TimeRangeTracker trt)<a name="line.128"></a>
-<span class="sourceLineNo">129</span>            throws IOException {<a 
name="line.129"></a>
-<span class="sourceLineNo">130</span>    // If passed a TimeRangeTracker, use 
it. Set timeRangeTrackerSet so we don't destroy it.<a name="line.130"></a>
-<span class="sourceLineNo">131</span>    // TODO: put the state of the TRT on 
the TRT; i.e. make a read-only version (TimeRange) when<a name="line.131"></a>
-<span class="sourceLineNo">132</span>    // it no longer writable.<a 
name="line.132"></a>
-<span class="sourceLineNo">133</span>    this.timeRangeTrackerSet = trt != 
null;<a name="line.133"></a>
-<span class="sourceLineNo">134</span>    this.timeRangeTracker = 
this.timeRangeTrackerSet? trt: 
TimeRangeTracker.create(TimeRangeTracker.Type.NON_SYNC);<a name="line.134"></a>
-<span class="sourceLineNo">135</span>    // TODO : Change all writers to be 
specifically created for compaction context<a name="line.135"></a>
-<span class="sourceLineNo">136</span>    writer = HFile.getWriterFactory(conf, 
cacheConf)<a name="line.136"></a>
-<span class="sourceLineNo">137</span>        .withPath(fs, path)<a 
name="line.137"></a>
-<span class="sourceLineNo">138</span>        .withComparator(comparator)<a 
name="line.138"></a>
-<span class="sourceLineNo">139</span>        .withFavoredNodes(favoredNodes)<a 
name="line.139"></a>
-<span class="sourceLineNo">140</span>        .withFileContext(fileContext)<a 
name="line.140"></a>
-<span class="sourceLineNo">141</span>        
.withShouldDropCacheBehind(shouldDropCacheBehind)<a name="line.141"></a>
-<span class="sourceLineNo">142</span>        .create();<a name="line.142"></a>
-<span class="sourceLineNo">143</span><a name="line.143"></a>
-<span class="sourceLineNo">144</span>    generalBloomFilterWriter = 
BloomFilterFactory.createGeneralBloomAtWrite(<a name="line.144"></a>
-<span class="sourceLineNo">145</span>        conf, cacheConf, bloomType,<a 
name="line.145"></a>
-<span class="sourceLineNo">146</span>        (int) Math.min(maxKeys, 
Integer.MAX_VALUE), writer);<a name="line.146"></a>
-<span class="sourceLineNo">147</span><a name="line.147"></a>
-<span class="sourceLineNo">148</span>    if (generalBloomFilterWriter != null) 
{<a name="line.148"></a>
-<span class="sourceLineNo">149</span>      this.bloomType = bloomType;<a 
name="line.149"></a>
-<span class="sourceLineNo">150</span>      if (LOG.isTraceEnabled()) {<a 
name="line.150"></a>
-<span class="sourceLineNo">151</span>        LOG.trace("Bloom filter type for 
" + path + ": " + this.bloomType + ", " +<a name="line.151"></a>
-<span class="sourceLineNo">152</span>            
generalBloomFilterWriter.getClass().getSimpleName());<a name="line.152"></a>
-<span class="sourceLineNo">153</span>      }<a name="line.153"></a>
-<span class="sourceLineNo">154</span>      // init bloom context<a 
name="line.154"></a>
-<span class="sourceLineNo">155</span>      switch (bloomType) {<a 
name="line.155"></a>
-<span class="sourceLineNo">156</span>      case ROW:<a name="line.156"></a>
-<span class="sourceLineNo">157</span>        bloomContext = new 
RowBloomContext(generalBloomFilterWriter, comparator);<a name="line.157"></a>
-<span class="sourceLineNo">158</span>        break;<a name="line.158"></a>
-<span class="sourceLineNo">159</span>      case ROWCOL:<a name="line.159"></a>
-<span class="sourceLineNo">160</span>        bloomContext = new 
RowColBloomContext(generalBloomFilterWriter, comparator);<a name="line.160"></a>
-<span class="sourceLineNo">161</span>        break;<a name="line.161"></a>
-<span class="sourceLineNo">162</span>      default:<a name="line.162"></a>
-<span class="sourceLineNo">163</span>        throw new IOException(<a 
name="line.163"></a>
-<span class="sourceLineNo">164</span>            "Invalid Bloom filter type: " 
+ bloomType + " (ROW or ROWCOL expected)");<a name="line.164"></a>
-<span class="sourceLineNo">165</span>      }<a name="line.165"></a>
-<span class="sourceLineNo">166</span>    } else {<a name="line.166"></a>
-<span class="sourceLineNo">167</span>      // Not using Bloom filters.<a 
name="line.167"></a>
-<span class="sourceLineNo">168</span>      this.bloomType = BloomType.NONE;<a 
name="line.168"></a>
-<span class="sourceLineNo">169</span>    }<a name="line.169"></a>
-<span class="sourceLineNo">170</span><a name="line.170"></a>
-<span class="sourceLineNo">171</span>    // initialize delete family Bloom 
filter when there is NO RowCol Bloom<a name="line.171"></a>
-<span class="sourceLineNo">172</span>    // filter<a name="line.172"></a>
-<span class="sourceLineNo">173</span>    if (this.bloomType != 
BloomType.ROWCOL) {<a name="line.173"></a>
-<span class="sourceLineNo">174</span>      this.deleteFamilyBloomFilterWriter 
= BloomFilterFactory<a name="line.174"></a>
-<span class="sourceLineNo">175</span>          .createDeleteBloomAtWrite(conf, 
cacheConf,<a name="line.175"></a>
-<span class="sourceLineNo">176</span>              (int) Math.min(maxKeys, 
Integer.MAX_VALUE), writer);<a name="line.176"></a>
-<span class="sourceLineNo">177</span>      deleteFamilyBloomContext = new 
RowBloomContext(deleteFamilyBloomFilterWriter, comparator);<a 
name="line.177"></a>
-<span class="sourceLineNo">178</span>    } else {<a name="line.178"></a>
-<span class="sourceLineNo">179</span>      deleteFamilyBloomFilterWriter = 
null;<a name="line.179"></a>
-<span class="sourceLineNo">180</span>    }<a name="line.180"></a>
-<span class="sourceLineNo">181</span>    if (deleteFamilyBloomFilterWriter != 
null &amp;&amp; LOG.isTraceEnabled()) {<a name="line.181"></a>
-<span class="sourceLineNo">182</span>      LOG.trace("Delete Family Bloom 
filter type for " + path + ": " +<a name="line.182"></a>
-<span class="sourceLineNo">183</span>          
deleteFamilyBloomFilterWriter.getClass().getSimpleName());<a 
name="line.183"></a>
-<span class="sourceLineNo">184</span>    }<a name="line.184"></a>
-<span class="sourceLineNo">185</span>  }<a name="line.185"></a>
-<span class="sourceLineNo">186</span><a name="line.186"></a>
-<span class="sourceLineNo">187</span>  /**<a name="line.187"></a>
-<span class="sourceLineNo">188</span>   * Writes meta data.<a 
name="line.188"></a>
-<span class="sourceLineNo">189</span>   * Call before {@link #close()} since 
its written as meta data to this file.<a name="line.189"></a>
-<span class="sourceLineNo">190</span>   * @param maxSequenceId Maximum 
sequence id.<a name="line.190"></a>
-<span class="sourceLineNo">191</span>   * @param majorCompaction True if this 
file is product of a major compaction<a name="line.191"></a>
-<span class="sourceLineNo">192</span>   * @throws IOException problem writing 
to FS<a name="line.192"></a>
-<span class="sourceLineNo">193</span>   */<a name="line.193"></a>
-<span class="sourceLineNo">194</span>  public void appendMetadata(final long 
maxSequenceId, final boolean majorCompaction)<a name="line.194"></a>
-<span class="sourceLineNo">195</span>      throws IOException {<a 
name="line.195"></a>
-<span class="sourceLineNo">196</span>    writer.appendFileInfo(MAX_SEQ_ID_KEY, 
Bytes.toBytes(maxSequenceId));<a name="line.196"></a>
-<span class="sourceLineNo">197</span>    
writer.appendFileInfo(MAJOR_COMPACTION_KEY, Bytes.toBytes(majorCompaction));<a 
name="line.197"></a>
-<span class="sourceLineNo">198</span>    
appendTrackedTimestampsToMetadata();<a name="line.198"></a>
-<span class="sourceLineNo">199</span>  }<a name="line.199"></a>
-<span class="sourceLineNo">200</span><a name="line.200"></a>
-<span class="sourceLineNo">201</span>  /**<a name="line.201"></a>
-<span class="sourceLineNo">202</span>   * Writes meta data.<a 
name="line.202"></a>
-<span class="sourceLineNo">203</span>   * Call before {@link #close()} since 
its written as meta data to this file.<a name="line.203"></a>
-<span class="sourceLineNo">204</span>   * @param maxSequenceId Maximum 
sequence id.<a name="line.204"></a>
-<span class="sourceLineNo">205</span>   * @param majorCompaction True if this 
file is product of a major compaction<a name="line.205"></a>
-<span class="sourceLineNo">206</span>   * @param mobCellsCount The number of 
mob cells.<a name="line.206"></a>
-<span class="sourceLineNo">207</span>   * @throws IOException problem writing 
to FS<a name="line.207"></a>
-<span class="sourceLineNo">208</span>   */<a name="line.208"></a>
-<span class="sourceLineNo">209</span>  public void appendMetadata(final long 
maxSequenceId, final boolean majorCompaction,<a name="line.209"></a>
-<span class="sourceLineNo">210</span>      final long mobCellsCount) throws 
IOException {<a name="line.210"></a>
-<span class="sourceLineNo">211</span>    writer.appendFileInfo(MAX_SEQ_ID_KEY, 
Bytes.toBytes(maxSequenceId));<a name="line.211"></a>
-<span class="sourceLineNo">212</span>    
writer.appendFileInfo(MAJOR_COMPACTION_KEY, Bytes.toBytes(majorCompaction));<a 
name="line.212"></a>
-<span class="sourceLineNo">213</span>    
writer.appendFileInfo(MOB_CELLS_COUNT, Bytes.toBytes(mobCellsCount));<a 
name="line.213"></a>
-<span class="sourceLineNo">214</span>    
appendTrackedTimestampsToMetadata();<a name="line.214"></a>
+<span class="sourceLineNo">074</span>  private final TimeRangeTracker 
timeRangeTracker;<a name="line.74"></a>
+<span class="sourceLineNo">075</span><a name="line.75"></a>
+<span class="sourceLineNo">076</span>  protected HFile.Writer writer;<a 
name="line.76"></a>
+<span class="sourceLineNo">077</span><a name="line.77"></a>
+<span class="sourceLineNo">078</span>    /**<a name="line.78"></a>
+<span class="sourceLineNo">079</span>     * Creates an HFile.Writer that also 
write helpful meta data.<a name="line.79"></a>
+<span class="sourceLineNo">080</span>     * @param fs file system to write 
to<a name="line.80"></a>
+<span class="sourceLineNo">081</span>     * @param path file name to create<a 
name="line.81"></a>
+<span class="sourceLineNo">082</span>     * @param conf user configuration<a 
name="line.82"></a>
+<span class="sourceLineNo">083</span>     * @param comparator key comparator<a 
name="line.83"></a>
+<span class="sourceLineNo">084</span>     * @param bloomType bloom filter 
setting<a name="line.84"></a>
+<span class="sourceLineNo">085</span>     * @param maxKeys the expected 
maximum number of keys to be added. Was used<a name="line.85"></a>
+<span class="sourceLineNo">086</span>     *        for Bloom filter size in 
{@link HFile} format version 1.<a name="line.86"></a>
+<span class="sourceLineNo">087</span>     * @param favoredNodes<a 
name="line.87"></a>
+<span class="sourceLineNo">088</span>     * @param fileContext - The HFile 
context<a name="line.88"></a>
+<span class="sourceLineNo">089</span>     * @param shouldDropCacheBehind Drop 
pages written to page cache after writing the store file.<a name="line.89"></a>
+<span class="sourceLineNo">090</span>     * @throws IOException problem 
writing to FS<a name="line.90"></a>
+<span class="sourceLineNo">091</span>     */<a name="line.91"></a>
+<span class="sourceLineNo">092</span>    private StoreFileWriter(FileSystem 
fs, Path path,<a name="line.92"></a>
+<span class="sourceLineNo">093</span>        final Configuration conf,<a 
name="line.93"></a>
+<span class="sourceLineNo">094</span>        CacheConfig cacheConf,<a 
name="line.94"></a>
+<span class="sourceLineNo">095</span>        final CellComparator comparator, 
BloomType bloomType, long maxKeys,<a name="line.95"></a>
+<span class="sourceLineNo">096</span>        InetSocketAddress[] favoredNodes, 
HFileContext fileContext,<a name="line.96"></a>
+<span class="sourceLineNo">097</span>        boolean shouldDropCacheBehind)<a 
name="line.97"></a>
+<span class="sourceLineNo">098</span>            throws IOException {<a 
name="line.98"></a>
+<span class="sourceLineNo">099</span>    this.timeRangeTracker = 
TimeRangeTracker.create(TimeRangeTracker.Type.NON_SYNC);<a name="line.99"></a>
+<span class="sourceLineNo">100</span>    // TODO : Change all writers to be 
specifically created for compaction context<a name="line.100"></a>
+<span class="sourceLineNo">101</span>    writer = HFile.getWriterFactory(conf, 
cacheConf)<a name="line.101"></a>
+<span class="sourceLineNo">102</span>        .withPath(fs, path)<a 
name="line.102"></a>
+<span class="sourceLineNo">103</span>        .withComparator(comparator)<a 
name="line.103"></a>
+<span class="sourceLineNo">104</span>        .withFavoredNodes(favoredNodes)<a 
name="line.104"></a>
+<span class="sourceLineNo">105</span>        .withFileContext(fileContext)<a 
name="line.105"></a>
+<span class="sourceLineNo">106</span>        
.withShouldDropCacheBehind(shouldDropCacheBehind)<a name="line.106"></a>
+<span class="sourceLineNo">107</span>        .create();<a name="line.107"></a>
+<span class="sourceLineNo">108</span><a name="line.108"></a>
+<span class="sourceLineNo">109</span>    generalBloomFilterWriter = 
BloomFilterFactory.createGeneralBloomAtWrite(<a name="line.109"></a>
+<span class="sourceLineNo">110</span>        conf, cacheConf, bloomType,<a 
name="line.110"></a>
+<span class="sourceLineNo">111</span>        (int) Math.min(maxKeys, 
Integer.MAX_VALUE), writer);<a name="line.111"></a>
+<span class="sourceLineNo">112</span><a name="line.112"></a>
+<span class="sourceLineNo">113</span>    if (generalBloomFilterWriter != null) 
{<a name="line.113"></a>
+<span class="sourceLineNo">114</span>      this.bloomType = bloomType;<a 
name="line.114"></a>
+<span class="sourceLineNo">115</span>      if (LOG.isTraceEnabled()) {<a 
name="line.115"></a>
+<span class="sourceLineNo">116</span>        LOG.trace("Bloom filter type for 
" + path + ": " + this.bloomType + ", " +<a name="line.116"></a>
+<span class="sourceLineNo">117</span>            
generalBloomFilterWriter.getClass().getSimpleName());<a name="line.117"></a>
+<span class="sourceLineNo">118</span>      }<a name="line.118"></a>
+<span class="sourceLineNo">119</span>      // init bloom context<a 
name="line.119"></a>
+<span class="sourceLineNo">120</span>      switch (bloomType) {<a 
name="line.120"></a>
+<span class="sourceLineNo">121</span>      case ROW:<a name="line.121"></a>
+<span class="sourceLineNo">122</span>        bloomContext = new 
RowBloomContext(generalBloomFilterWriter, comparator);<a name="line.122"></a>
+<span class="sourceLineNo">123</span>        break;<a name="line.123"></a>
+<span class="sourceLineNo">124</span>      case ROWCOL:<a name="line.124"></a>
+<span class="sourceLineNo">125</span>        bloomContext = new 
RowColBloomContext(generalBloomFilterWriter, comparator);<a name="line.125"></a>
+<span class="sourceLineNo">126</span>        break;<a name="line.126"></a>
+<span class="sourceLineNo">127</span>      default:<a name="line.127"></a>
+<span class="sourceLineNo">128</span>        throw new IOException(<a 
name="line.128"></a>
+<span class="sourceLineNo">129</span>            "Invalid Bloom filter type: " 
+ bloomType + " (ROW or ROWCOL expected)");<a name="line.129"></a>
+<span class="sourceLineNo">130</span>      }<a name="line.130"></a>
+<span class="sourceLineNo">131</span>    } else {<a name="line.131"></a>
+<span class="sourceLineNo">132</span>      // Not using Bloom filters.<a 
name="line.132"></a>
+<span class="sourceLineNo">133</span>      this.bloomType = BloomType.NONE;<a 
name="line.133"></a>
+<span class="sourceLineNo">134</span>    }<a name="line.134"></a>
+<span class="sourceLineNo">135</span><a name="line.135"></a>
+<span class="sourceLineNo">136</span>    // initialize delete family Bloom 
filter when there is NO RowCol Bloom<a name="line.136"></a>
+<span class="sourceLineNo">137</span>    // filter<a name="line.137"></a>
+<span class="sourceLineNo">138</span>    if (this.bloomType != 
BloomType.ROWCOL) {<a name="line.138"></a>
+<span class="sourceLineNo">139</span>      this.deleteFamilyBloomFilterWriter 
= BloomFilterFactory<a name="line.139"></a>
+<span class="sourceLineNo">140</span>          .createDeleteBloomAtWrite(conf, 
cacheConf,<a name="line.140"></a>
+<span class="sourceLineNo">141</span>              (int) Math.min(maxKeys, 
Integer.MAX_VALUE), writer);<a name="line.141"></a>
+<span class="sourceLineNo">142</span>      deleteFamilyBloomContext = new 
RowBloomContext(deleteFamilyBloomFilterWriter, comparator);<a 
name="line.142"></a>
+<span class="sourceLineNo">143</span>    } else {<a name="line.143"></a>
+<span class="sourceLineNo">144</span>      deleteFamilyBloomFilterWriter = 
null;<a name="line.144"></a>
+<span class="sourceLineNo">145</span>    }<a name="line.145"></a>
+<span class="sourceLineNo">146</span>    if (deleteFamilyBloomFilterWriter != 
null &amp;&amp; LOG.isTraceEnabled()) {<a name="line.146"></a>
+<span class="sourceLineNo">147</span>      LOG.trace("Delete Family Bloom 
filter type for " + path + ": " +<a name="line.147"></a>
+<span class="sourceLineNo">148</span>          
deleteFamilyBloomFilterWriter.getClass().getSimpleName());<a 
name="line.148"></a>
+<span class="sourceLineNo">149</span>    }<a name="line.149"></a>
+<span class="sourceLineNo">150</span>  }<a name="line.150"></a>
+<span class="sourceLineNo">151</span><a name="line.151"></a>
+<span class="sourceLineNo">152</span>  /**<a name="line.152"></a>
+<span class="sourceLineNo">153</span>   * Writes meta data.<a 
name="line.153"></a>
+<span class="sourceLineNo">154</span>   * Call before {@link #close()} since 
its written as meta data to this file.<a name="line.154"></a>
+<span class="sourceLineNo">155</span>   * @param maxSequenceId Maximum 
sequence id.<a name="line.155"></a>
+<span class="sourceLineNo">156</span>   * @param majorCompaction True if this 
file is product of a major compaction<a name="line.156"></a>
+<span class="sourceLineNo">157</span>   * @throws IOException problem writing 
to FS<a name="line.157"></a>
+<span class="sourceLineNo">158</span>   */<a name="line.158"></a>
+<span class="sourceLineNo">159</span>  public void appendMetadata(final long 
maxSequenceId, final boolean majorCompaction)<a name="line.159"></a>
+<span class="sourceLineNo">160</span>      throws IOException {<a 
name="line.160"></a>
+<span class="sourceLineNo">161</span>    writer.appendFileInfo(MAX_SEQ_ID_KEY, 
Bytes.toBytes(maxSequenceId));<a name="line.161"></a>
+<span class="sourceLineNo">162</span>    
writer.appendFileInfo(MAJOR_COMPACTION_KEY, Bytes.toBytes(majorCompaction));<a 
name="line.162"></a>
+<span class="sourceLineNo">163</span>    
appendTrackedTimestampsToMetadata();<a name="line.163"></a>
+<span class="sourceLineNo">164</span>  }<a name="line.164"></a>
+<span class="sourceLineNo">165</span><a name="line.165"></a>
+<span class="sourceLineNo">166</span>  /**<a name="line.166"></a>
+<span class="sourceLineNo">167</span>   * Writes meta data.<a 
name="line.167"></a>
+<span class="sourceLineNo">168</span>   * Call before {@link #close()} since 
its written as meta data to this file.<a name="line.168"></a>
+<span class="sourceLineNo">169</span>   * @param maxSequenceId Maximum 
sequence id.<a name="line.169"></a>
+<span class="sourceLineNo">170</span>   * @param majorCompaction True if this 
file is product of a major compaction<a name="line.170"></a>
+<span class="sourceLineNo">171</span>   * @param mobCellsCount The number of 
mob cells.<a name="line.171"></a>
+<span class="sourceLineNo">172</span>   * @throws IOException problem writing 
to FS<a name="line.172"></a>
+<span class="sourceLineNo">173</span>   */<a name="line.173"></a>
+<span class="sourceLineNo">174</span>  public void appendMetadata(final long 
maxSequenceId, final boolean majorCompaction,<a name="line.174"></a>
+<span class="sourceLineNo">175</span>      final long mobCellsCount) throws 
IOException {<a name="line.175"></a>
+<span class="sourceLineNo">176</span>    writer.appendFileInfo(MAX_SEQ_ID_KEY, 
Bytes.toBytes(maxSequenceId));<a name="line.176"></a>
+<span class="sourceLineNo">177</span>    
writer.appendFileInfo(MAJOR_COMPACTION_KEY, Bytes.toBytes(majorCompaction));<a 
name="line.177"></a>
+<span class="sourceLineNo">178</span>    
writer.appendFileInfo(MOB_CELLS_COUNT, Bytes.toBytes(mobCellsCount));<a 
name="line.178"></a>
+<span class="sourceLineNo">179</span>    
appendTrackedTimestampsToMetadata();<a name="line.179"></a>
+<span class="sourceLineNo">180</span>  }<a name="line.180"></a>
+<span class="sourceLineNo">181</span><a name="line.181"></a>
+<span class="sourceLineNo">182</span>  /**<a name="line.182"></a>
+<span class="sourceLineNo">183</span>   * Add TimestampRange and earliest put 
timestamp to Metadata<a name="line.183"></a>
+<span class="sourceLineNo">184</span>   */<a name="line.184"></a>
+<span class="sourceLineNo">185</span>  public void 
appendTrackedTimestampsToMetadata() throws IOException {<a name="line.185"></a>
+<span class="sourceLineNo">186</span>    appendFileInfo(TIMERANGE_KEY, 
WritableUtils.toByteArray(timeRangeTracker));<a name="line.186"></a>
+<span class="sourceLineNo">187</span>    appendFileInfo(EARLIEST_PUT_TS, 
Bytes.toBytes(earliestPutTs));<a name="line.187"></a>
+<span class="sourceLineNo">188</span>  }<a name="line.188"></a>
+<span class="sourceLineNo">189</span><a name="line.189"></a>
+<span class="sourceLineNo">190</span>  /**<a name="line.190"></a>
+<span class="sourceLineNo">191</span>   * Record the earlest Put timestamp.<a 
name="line.191"></a>
+<span class="sourceLineNo">192</span>   *<a name="line.192"></a>
+<span class="sourceLineNo">193</span>   * If the timeRangeTracker is not 
set,<a name="line.193"></a>
+<span class="sourceLineNo">194</span>   * update TimeRangeTracker to include 
the timestamp of this key<a name="line.194"></a>
+<span class="sourceLineNo">195</span>   */<a name="line.195"></a>
+<span class="sourceLineNo">196</span>  public void trackTimestamps(final Cell 
cell) {<a name="line.196"></a>
+<span class="sourceLineNo">197</span>    if (KeyValue.Type.Put.getCode() == 
cell.getTypeByte()) {<a name="line.197"></a>
+<span class="sourceLineNo">198</span>      earliestPutTs = 
Math.min(earliestPutTs, cell.getTimestamp());<a name="line.198"></a>
+<span class="sourceLineNo">199</span>    }<a name="line.199"></a>
+<span class="sourceLineNo">200</span>    
timeRangeTracker.includeTimestamp(cell);<a name="line.200"></a>
+<span class="sourceLineNo">201</span>  }<a name="line.201"></a>
+<span class="sourceLineNo">202</span><a name="line.202"></a>
+<span class="sourceLineNo">203</span>  private void 
appendGeneralBloomfilter(final Cell cell) throws IOException {<a 
name="line.203"></a>
+<span class="sourceLineNo">204</span>    if (this.generalBloomFilterWriter != 
null) {<a name="line.204"></a>
+<span class="sourceLineNo">205</span>      /*<a name="line.205"></a>
+<span class="sourceLineNo">206</span>       * 
http://2.bp.blogspot.com/_Cib_A77V54U/StZMrzaKufI/AAAAAAAAADo/ZhK7bGoJdMQ/s400/KeyValue.png<a
 name="line.206"></a>
+<span class="sourceLineNo">207</span>       * Key = RowLen + Row + FamilyLen + 
Column [Family + Qualifier] + TimeStamp<a name="line.207"></a>
+<span class="sourceLineNo">208</span>       *<a name="line.208"></a>
+<span class="sourceLineNo">209</span>       * 2 Types of Filtering:<a 
name="line.209"></a>
+<span class="sourceLineNo">210</span>       *  1. Row = Row<a 
name="line.210"></a>
+<span class="sourceLineNo">211</span>       *  2. RowCol = Row + Qualifier<a 
name="line.211"></a>
+<span class="sourceLineNo">212</span>       */<a name="line.212"></a>
+<span class="sourceLineNo">213</span>      bloomContext.writeBloom(cell);<a 
name="line.213"></a>
+<span class="sourceLineNo">214</span>    }<a name="line.214"></a>
 <span class="sourceLineNo">215</span>  }<a name="line.215"></a>
 <span class="sourceLineNo">216</span><a name="line.216"></a>
-<span class="sourceLineNo">217</span>  /**<a name="line.217"></a>
-<span class="sourceLineNo">218</span>   * Add TimestampRange and earliest put 
timestamp to Metadata<a name="line.218"></a>
-<span class="sourceLineNo">219</span>   */<a name="line.219"></a>
-<span class="sourceLineNo">220</span>  public void 
appendTrackedTimestampsToMetadata() throws IOException {<a name="line.220"></a>
-<span class="sourceLineNo">221</span>    appendFileInfo(TIMERANGE_KEY, 
WritableUtils.toByteArray(timeRangeTracker));<a name="line.221"></a>
-<span class="sourceLineNo">222</span>    appendFileInfo(EARLIEST_PUT_TS, 
Bytes.toBytes(earliestPutTs));<a name="line.222"></a>
-<span class="sourceLineNo">223</span>  }<a name="line.223"></a>
-<span class="sourceLineNo">224</span><a name="line.224"></a>
-<span class="sourceLineNo">225</span>  /**<a name="line.225"></a>
-<span class="sourceLineNo">226</span>   * Record the earlest Put timestamp.<a 
name="line.226"></a>
-<span class="sourceLineNo">227</span>   *<a name="line.227"></a>
-<span class="sourceLineNo">228</span>   * If the timeRangeTracker is not 
set,<a name="line.228"></a>
-<span class="sourceLineNo">229</span>   * update TimeRangeTracker to include 
the timestamp of this key<a name="line.229"></a>
-<span class="sourceLineNo">230</span>   */<a name="line.230"></a>
-<span class="sourceLineNo">231</span>  public void trackTimestamps(final Cell 
cell) {<a name="line.231"></a>
-<span class="sourceLineNo">232</span>    if (KeyValue.Type.Put.getCode() == 
cell.getTypeByte()) {<a name="line.232"></a>
-<span class="sourceLineNo">233</span>      earliestPutTs = 
Math.min(earliestPutTs, cell.getTimestamp());<a name="line.233"></a>
-<span class="sourceLineNo">234</span>    }<a name="line.234"></a>
-<span class="sourceLineNo">235</span>    if (!timeRangeTrackerSet) {<a 
name="line.235"></a>
-<span class="sourceLineNo">236</span>      
timeRangeTracker.includeTimestamp(cell);<a name="line.236"></a>
-<span class="sourceLineNo">237</span>    }<a name="line.237"></a>
-<span class="sourceLineNo">238</span>  }<a name="line.238"></a>
-<span class="sourceLineNo">239</span><a name="line.239"></a>
-<span class="sourceLineNo">240</span>  private void 
appendGeneralBloomfilter(final Cell cell) throws IOException {<a 
name="line.240"></a>
-<span class="sourceLineNo">241</span>    if (this.generalBloomFilterWriter != 
null) {<a name="line.241"></a>
-<span class="sourceLineNo">242</span>      /*<a name="line.242"></a>
-<span class="sourceLineNo">243</span>       * 
http://2.bp.blogspot.com/_Cib_A77V54U/StZMrzaKufI/AAAAAAAAADo/ZhK7bGoJdMQ/s400/KeyValue.png<a
 name="line.243"></a>
-<span class="sourceLineNo">244</span>       * Key = RowLen + Row + FamilyLen + 
Column [Family + Qualifier] + TimeStamp<a name="line.244"></a>
-<span class="sourceLineNo">245</span>       *<a name="line.245"></a>
-<span class="sourceLineNo">246</span>       * 2 Types of Filtering:<a 
name="line.246"></a>
-<span class="sourceLineNo">247</span>       *  1. Row = Row<a 
name="line.247"></a>
-<span class="sourceLineNo">248</span>       *  2. RowCol = Row + Qualifier<a 
name="line.248"></a>
-<span class="sourceLineNo">249</span>       */<a name="line.249"></a>
-<span class="sourceLineNo">250</span>      bloomContext.writeBloom(cell);<a 
name="line.250"></a>
-<span class="sourceLineNo">251</span>    }<a name="line.251"></a>
-<span class="sourceLineNo">252</span>  }<a name="line.252"></a>
-<span class="sourceLineNo">253</span><a name="line.253"></a>
-<span class="sourceLineNo">254</span>  private void 
appendDeleteFamilyBloomFilter(final Cell cell)<a name="line.254"></a>
-<span class="sourceLineNo">255</span>      throws IOException {<a 
name="line.255"></a>
-<span class="sourceLineNo">256</span>    if (!CellUtil.isDeleteFamily(cell) 
&amp;&amp; !CellUtil.isDeleteFamilyVersion(cell)) {<a name="line.256"></a>
-<span class="sourceLineNo">257</span>      return;<a name="line.257"></a>
-<span class="sourceLineNo">258</span>    }<a name="line.258"></a>
-<span class="sourceLineNo">259</span><a name="line.259"></a>
-<span class="sourceLineNo">260</span>    // increase the number of delete 
family in the store file<a name="line.260"></a>
-<span class="sourceLineNo">261</span>    deleteFamilyCnt++;<a 
name="line.261"></a>
-<span class="sourceLineNo">262</span>    if 
(this.deleteFamilyBloomFilterWriter != null) {<a name="line.262"></a>
-<span class="sourceLineNo">263</span>      
deleteFamilyBloomContext.writeBloom(cell);<a name="line.263"></a>
-<span class="sourceLineNo">264</span>    }<a name="line.264"></a>
-<span class="sourceLineNo">265</span>  }<a name="line.265"></a>
-<span class="sourceLineNo">266</span><a name="line.266"></a>
-<span class="sourceLineNo">267</span>  @Override<a name="line.267"></a>
-<span class="sourceLineNo">268</span>  public void append(final Cell cell) 
throws IOException {<a name="line.268"></a>
-<span class="sourceLineNo">269</span>    appendGeneralBloomfilter(cell);<a 
name="line.269"></a>
-<span class="sourceLineNo">270</span>    
appendDeleteFamilyBloomFilter(cell);<a name="line.270"></a>
-<span class="sourceLineNo">271</span>    writer.append(cell);<a 
name="line.271"></a>
-<span class="sourceLineNo">272</span>    trackTimestamps(cell);<a 
name="line.272"></a>
-<span class="sourceLineNo">273</span>  }<a name="line.273"></a>
-<span class="sourceLineNo">274</span><a name="line.274"></a>
-<span class="sourceLineNo">275</span>  @Override<a name="line.275"></a>
-<span class="sourceLineNo">276</span>  public void beforeShipped() throws 
IOException {<a name="line.276"></a>
-<span class="sourceLineNo">277</span>    // For now these writer will always 
be of type ShipperListener true.<a name="line.277"></a>
-<span class="sourceLineNo">278</span>    // TODO : Change all writers to be 
specifically created for compaction context<a name="line.278"></a>
-<span class="sourceLineNo">279</span>    writer.beforeShipped();<a 
name="line.279"></a>
-<span class="sourceLineNo">280</span>    if (generalBloomFilterWriter != null) 
{<a name="line.280"></a>
-<span class="sourceLineNo">281</span>      
generalBloomFilterWriter.beforeShipped();<a name="line.281"></a>
-<span class="sourceLineNo">282</span>    }<a name="line.282"></a>
-<span class="sourceLineNo">283</span>    if (deleteFamilyBloomFilterWriter != 
null) {<a name="line.283"></a>
-<span class="sourceLineNo">284</span>      
deleteFamilyBloomFilterWriter.beforeShipped();<a name="line.284"></a>
-<span class="sourceLineNo">285</span>    }<a name="line.285"></a>
+<span class="sourceLineNo">217</span>  private void 
appendDeleteFamilyBloomFilter(final Cell cell)<a name="line.217"></a>
+<span class="sourceLineNo">218</span>      throws IOException {<a 
name="line.218"></a>
+<span class="sourceLineNo">219</span>    if (!CellUtil.isDeleteFamily(cell) 
&amp;&amp; !CellUtil.isDeleteFamilyVersion(cell)) {<a name="line.219"></a>
+<span class="sourceLineNo">220</span>      return;<a name="line.220"></a>
+<span class="sourceLineNo">221</span>    }<a name="line.221"></a>
+<span class="sourceLineNo">222</span><a name="line.222"></a>
+<span class="sourceLineNo">223</span>    // increase the number of delete 
family in the store file<a name="line.223"></a>
+<span class="sourceLineNo">224</span>    deleteFamilyCnt++;<a 
name="line.224"></a>
+<span class="sourceLineNo">225</span>    if 
(this.deleteFamilyBloomFilterWriter != null) {<a name="line.225"></a>
+<span class="sourceLineNo">226</span>      
deleteFamilyBloomContext.writeBloom(cell);<a name="line.226"></a>
+<span class="sourceLineNo">227</span>    }<a name="line.227"></a>
+<span class="sourceLineNo">228</span>  }<a name="line.228"></a>
+<span class="sourceLineNo">229</span><a name="line.229"></a>
+<span class="sourceLineNo">230</span>  @Override<a name="line.230"></a>
+<span class="sourceLineNo">231</span>  public void append(final Cell cell) 
throws IOException {<a name="line.231"></a>
+<span class="sourceLineNo">232</span>    appendGeneralBloomfilter(cell);<a 
name="line.232"></a>
+<span class="sourceLineNo">233</span>    
appendDeleteFamilyBloomFilter(cell);<a name="line.233"></a>
+<span class="sourceLineNo">234</span>    writer.append(cell);<a 
name="line.234"></a>
+<span class="sourceLineNo">235</span>    trackTimestamps(cell);<a 
name="line.235"></a>
+<span class="sourceLineNo">236</span>  }<a name="line.236"></a>
+<span class="sourceLineNo">237</span><a name="line.237"></a>
+<span class="sourceLineNo">238</span>  @Override<a name="line.238"></a>
+<span class="sourceLineNo">239</span>  public void beforeShipped() throws 
IOException {<a name="line.239"></a>
+<span class="sourceLineNo">240</span>    // For now these writer will always 
be of type ShipperListener true.<a name="line.240"></a>
+<span class="sourceLineNo">241</span>    // TODO : Change all writers to be 
specifically created for compaction context<a name="line.241"></a>
+<span class="sourceLineNo">242</span>    writer.beforeShipped();<a 
name="line.242"></a>
+<span class="sourceLineNo">243</span>    if (generalBloomFilterWriter != null) 
{<a name="line.243"></a>
+<span class="sourceLineNo">244</span>      
generalBloomFilterWriter.beforeShipped();<a name="line.244"></a>
+<span class="sourceLineNo">245</span>    }<a name="line.245"></a>
+<span class="sourceLineNo">246</span>    if (deleteFamilyBloomFilterWriter != 
null) {<a name="line.246"></a>
+<span class="sourceLineNo">247</span>      
deleteFamilyBloomFilterWriter.beforeShipped();<a name="line.247"></a>
+<span class="sourceLineNo">248</span>    }<a name="line.248"></a>
+<span class="sourceLineNo">249</span>  }<a name="line.249"></a>
+<span class="sourceLineNo">250</span><a name="line.250"></a>
+<span class="sourceLineNo">251</span>  public Path getPath() {<a 
name="line.251"></a>
+<span class="sourceLineNo">252</span>    return this.writer.getPath();<a 
name="line.252"></a>
+<span class="sourceLineNo">253</span>  }<a name="line.253"></a>
+<span class="sourceLineNo">254</span><a name="line.254"></a>
+<span class="sourceLineNo">255</span>  public boolean hasGeneralBloom() {<a 
name="line.255"></a>
+<span class="sourceLineNo">256</span>    return this.generalBloomFilterWriter 
!= null;<a name="line.256"></a>
+<span class="sourceLineNo">257</span>  }<a name="line.257"></a>
+<span class="sourceLineNo">258</span><a name="line.258"></a>
+<span class="sourceLineNo">259</span>  /**<a name="line.259"></a>
+<span class="sourceLineNo">260</span>   * For unit testing only.<a 
name="line.260"></a>
+<span class="sourceLineNo">261</span>   *<a name="line.261"></a>
+<span class="sourceLineNo">262</span>   * @return the Bloom filter used by 
this writer.<a name="line.262"></a>
+<span class="sourceLineNo">263</span>   */<a name="line.263"></a>
+<span class="sourceLineNo">264</span>  BloomFilterWriter 
getGeneralBloomWriter() {<a name="line.264"></a>
+<span class="sourceLineNo">265</span>    return generalBloomFilterWriter;<a 
name="line.265"></a>
+<span class="sourceLineNo">266</span>  }<a name="line.266"></a>
+<span class="sourceLineNo">267</span><a name="line.267"></a>
+<span class="sourceLineNo">268</span>  private boolean 
closeBloomFilter(BloomFilterWriter bfw) throws IOException {<a 
name="line.268"></a>
+<span class="sourceLineNo">269</span>    boolean haveBloom = (bfw != null 
&amp;&amp; bfw.getKeyCount() &gt; 0);<a name="line.269"></a>
+<span class="sourceLineNo">270</span>    if (haveBloom) {<a 
name="line.270"></a>
+<span class="sourceLineNo">271</span>      bfw.compactBloom();<a 
name="line.271"></a>
+<span class="sourceLineNo">272</span>    }<a name="line.272"></a>
+<span class="sourceLineNo">273</span>    return haveBloom;<a 
name="line.273"></a>
+<span class="sourceLineNo">274</span>  }<a name="line.274"></a>
+<span class="sourceLineNo">275</span><a name="line.275"></a>
+<span class="sourceLineNo">276</span>  private boolean 
closeGeneralBloomFilter() throws IOException {<a name="line.276"></a>
+<span class="sourceLineNo">277</span>    boolean hasGeneralBloom = 
closeBloomFilter(generalBloomFilterWriter);<a name="line.277"></a>
+<span class="sourceLineNo">278</span><a name="line.278"></a>
+<span class="sourceLineNo">279</span>    // add the general Bloom filter 
writer and append file info<a name="line.279"></a>
+<span class="sourceLineNo">280</span>    if (hasGeneralBloom) {<a 
name="line.280"></a>
+<span class="sourceLineNo">281</span>      
writer.addGeneralBloomFilter(generalBloomFilterWriter);<a name="line.281"></a>
+<span class="sourceLineNo">282</span>      
writer.appendFileInfo(BLOOM_FILTER_TYPE_KEY, 
Bytes.toBytes(bloomType.toString()));<a name="line.282"></a>
+<span class="sourceLineNo">283</span>      
bloomContext.addLastBloomKey(writer);<a name="line.283"></a>
+<span class="sourceLineNo">284</span>    }<a name="line.284"></a>
+<span class="sourceLineNo">285</span>    return hasGeneralBloom;<a 
name="line.285"></a>
 <span class="sourceLineNo">286</span>  }<a name="line.286"></a>
 <span class="sourceLineNo">287</span><a name="line.287"></a>
-<span class="sourceLineNo">288</span>  public Path getPath() {<a 
name="line.288"></a>
-<span class="sourceLineNo">289</span>    return this.writer.getPath();<a 
name="line.289"></a>
-<span class="sourceLineNo">290</span>  }<a name="line.290"></a>
-<span class="sourceLineNo">291</span><a name="line.291"></a>
-<span class="sourceLineNo">292</span>  public boolean hasGeneralBloom() {<a 
name="line.292"></a>
-<span class="sourceLineNo">293</span>    return this.generalBloomFilterWriter 
!= null;<a name="line.293"></a>
-<span class="sourceLineNo">294</span>  }<a name="line.294"></a>
+<span class="sourceLineNo">288</span>  private boolean 
closeDeleteFamilyBloomFilter() throws IOException {<a name="line.288"></a>
+<span class="sourceLineNo">289</span>    boolean hasDeleteFamilyBloom = 
closeBloomFilter(deleteFamilyBloomFilterWriter);<a name="line.289"></a>
+<span class="sourceLineNo">290</span><a name="line.290"></a>
+<span class="sourceLineNo">291</span>    // add the delete family Bloom filter 
writer<a name="line.291"></a>
+<span class="sourceLineNo">292</span>    if (hasDeleteFamilyBloom) {<a 
name="line.292"></a>
+<span class="sourceLineNo">293</span>      
writer.addDeleteFamilyBloomFilter(deleteFamilyBloomFilterWriter);<a 
name="line.293"></a>
+<span class="sourceLineNo">294</span>    }<a name="line.294"></a>
 <span class="sourceLineNo">295</span><a name="line.295"></a>
-<span class="sourceLineNo">296</span>  /**<a name="line.296"></a>
-<span class="sourceLineNo">297</span>   * For unit testing only.<a 
name="line.297"></a>
-<span class="sourceLineNo">298</span>   *<a name="line.298"></a>
-<span class="sourceLineNo">299</span>   * @return the Bloom filter used by 
this writer.<a name="line.299"></a>
-<span class="sourceLineNo">300</span>   */<a name="line.300"></a>
-<span class="sourceLineNo">301</span>  BloomFilterWriter 
getGeneralBloomWriter() {<a name="line.301"></a>
-<span class="sourceLineNo">302</span>    return generalBloomFilterWriter;<a 
name="line.302"></a>
-<span class="sourceLineNo">303</span>  }<a name="line.303"></a>
-<span class="sourceLineNo">304</span><a name="line.304"></a>
-<span class="sourceLineNo">305</span>  private boolean 
closeBloomFilter(BloomFilterWriter bfw) throws IOException {<a 
name="line.305"></a>
-<span class="sourceLineNo">306</span>    boolean haveBloom = (bfw != null 
&amp;&amp; bfw.getKeyCount() &gt; 0);<a name="line.306"></a>
-<span class="sourceLineNo">307</span>    if (haveBloom) {<a 
name="line.307"></a>
-<span class="sourceLineNo">308</span>      bfw.compactBloom();<a 
name="line.308"></a>
-<span class="sourceLineNo">309</span>    }<a name="line.309"></a>
-<span class="sourceLineNo">310</span>    return haveBloom;<a 
name="line.310"></a>
-<span class="sourceLineNo">311</span>  }<a name="line.311"></a>
-<span class="sourceLineNo">312</span><a name="line.312"></a>
-<span class="sourceLineNo">313</span>  private boolean 
closeGeneralBloomFilter() throws IOException {<a name="line.313"></a>
-<span class="sourceLineNo">314</span>    boolean hasGeneralBloom = 
closeBloomFilter(generalBloomFilterWriter);<a name="line.314"></a>
-<span class="sourceLineNo">315</span><a name="line.315"></a>
-<span class="sourceLineNo">316</span>    // add the general Bloom filter 
writer and append file info<a name="line.316"></a>
-<span class="sourceLineNo">317</span>    if (hasGeneralBloom) {<a 
name="line.317"></a>
-<span class="sourceLineNo">318</span>      
writer.addGeneralBloomFilter(generalBloomFilterWriter);<a name="line.318"></a>
-<span class="sourceLineNo">319</span>      
writer.appendFileInfo(BLOOM_FILTER_TYPE_KEY, 
Bytes.toBytes(bloomType.toString()));<a name="line.319"></a>
-<span class="sourceLineNo">320</span>      
bloomContext.addLastBloomKey(writer);<a name="line.320"></a>
-<span class="sourceLineNo">321</span>    }<a name="line.321"></a>
-<span class="sourceLineNo">322</span>    return hasGeneralBloom;<a 
name="line.322"></a>
-<span class="sourceLineNo">323</span>  }<a name="line.323"></a>
-<span class="sourceLineNo">324</span><a name="line.324"></a>
-<span class="sourceLineNo">325</span>  private boolean 
closeDeleteFamilyBloomFilter() throws IOException {<a name="line.325"></a>
-<span class="sourceLineNo">326</span>    boolean hasDeleteFamilyBloom = 
closeBloomFilter(deleteFamilyBloomFilterWriter);<a name="line.326"></a>
-<span class="sourceLineNo">327</span><a name="line.327"></a>
-<span class="sourceLineNo">328</span>    // add the delete family Bloom filter 
writer<a name="line.328"></a>
-<span class="sourceLineNo">329</span>    if (hasDeleteFamilyBloom) {<a 
name="line.329"></a>
-<span class="sourceLineNo">330</span>      
writer.addDeleteFamilyBloomFilter(deleteFamilyBloomFilterWriter);<a 
name="line.330"></a>
-<span class="sourceLineNo">331</span>    }<a name="line.331"></a>
-<span class="sourceLineNo">332</span><a name="line.332"></a>
-<span class="sourceLineNo">333</span>    // append file info about the number 
of delete family kvs<a name="line.333"></a>
-<span class="sourceLineNo">334</span>    // even if there is no delete family 
Bloom.<a name="line.334"></a>
-<span class="sourceLineNo">335</span>    
writer.appendFileInfo(DELETE_FAMILY_COUNT, 
Bytes.toBytes(this.deleteFamilyCnt));<a name="line.335"></a>
-<span class="sourceLineNo">336</span><a name="line.336"></a>
-<span class="sourceLineNo">337</span>    return hasDeleteFamilyBloom;<a 
name="line.337"></a>
-<span class="sourceLineNo">338</span>  }<a name="line.338"></a>
-<span class="sourceLineNo">339</span><a name="line.339"></a>
-<span class="sourceLineNo">340</span>  public void close() throws IOException 
{<a name="line.340"></a>
-<span class="sourceLineNo">341</span>    boolean hasGeneralBloom = 
this.closeGeneralBloomFilter();<a name="line.341"></a>
-<span class="sourceLineNo">342</span>    boolean hasDeleteFamilyBloom = 
this.closeDeleteFamilyBloomFilter();<a name="line.342"></a>
-<span class="sourceLineNo">343</span><a name="line.343"></a>
-<span class="sourceLineNo">344</span>    writer.close();<a name="line.344"></a>
-<span class="sourceLineNo">345</span><a name="line.345"></a>
-<span class="sourceLineNo">346</span>    // Log final Bloom filter statistics. 
This needs to be done after close()<a name="line.346"></a>
-<span class="sourceLineNo">347</span>    // because compound Bloom filters 
might be finalized as part of closing.<a name="line.347"></a>
-<span class="sourceLineNo">348</span>    if (LOG.isTraceEnabled()) {<a 
name="line.348"></a>
-<span class="sourceLineNo">349</span>      LOG.trace((hasGeneralBloom ? "" : 
"NO ") + "General Bloom and " +<a name="line.349"></a>
-<span class="sourceLineNo">350</span>        (hasDeleteFamilyBloom ? "" : "NO 
") + "DeleteFamily" + " was added to HFile " +<a name="line.350"></a>
-<span class="sourceLineNo">351</span>        getPath());<a name="line.351"></a>
-<span class="sourceLineNo">352</span>    }<a name="line.352"></a>
-<span class="sourceLineNo">353</span><a name="line.353"></a>
-<span class="sourceLineNo">354</span>  }<a name="line.354"></a>
-<span class="sourceLineNo">355</span><a name="line.355"></a>
-<span class="sourceLineNo">356</span>  public void appendFileInfo(byte[] key, 
byte[] value) throws IOException {<a name="line.356"></a>
-<span class="sourceLineNo">357</span>    writer.appendFileInfo(key, value);<a 
name="line.357"></a>
-<span class="sourceLineNo">358</span>  }<a name="line.358"></a>
-<span class="sourceLineNo">359</span><a name="line.359"></a>
-<span class="sourceLineNo">360</span>  /** For use in testing.<a 
name="line.360"></a>
-<span class="sourceLineNo">361</span>   */<a name="line.361"></a>
-<span class="sourceLineNo">362</span>  HFile.Writer getHFileWriter() {<a 
name="line.362"></a>
-<span class="sourceLineNo">363</span>    return writer;<a name="line.363"></a>
-<span class="sourceLineNo">364</span>  }<a name="line.364"></a>
-<span class="sourceLineNo">365</span><a name="line.365"></a>
-<span class="sourceLineNo">366</span>  /**<a name="line.366"></a>
-<span class="sourceLineNo">367</span>   * @param fs<a name="line.367"></a>
-<span class="sourceLineNo">368</span>   * @param dir Directory to create file 
in.<a name="line.368"></a>
-<span class="sourceLineNo">369</span>   * @return random filename inside 
passed &lt;code&gt;dir&lt;/code&gt;<a name="line.369"></a>
-<span class="sourceLineNo">370</span>   */<a name="line.370"></a>
-<span class="sourceLineNo">371</span>  static Path getUniqueFile(final 
FileSystem fs, final Path dir) throws IOException {<a name="line.371"></a>
-<span class="sourceLineNo">372</span>    if 
(!fs.getFileStatus(dir).isDirectory()) {<a name="line.372"></a>
-<span class="sourceLineNo">373</span>      throw new IOException("Expecting " 
+ dir.toString() + " to be a directory");<a name="line.373"></a>
-<span class="sourceLineNo">374</span>    }<a name="line.374"></a>
-<span class="sourceLineNo">375</span>    return new Path(dir, 
dash.matcher(UUID.randomUUID().toString()).replaceAll(""));<a 
name="line.375"></a>
-<span class="sourceLineNo">376</span>  }<a name="line.376"></a>
-<span class="sourceLineNo">377</span><a name="line.377"></a>
-<span class="sourceLineNo">378</span>  
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="ICAST_INTEGER_MULTIPLY_CAST_TO_LONG",<a
 name="line.378"></a>
-<span class="sourceLineNo">379</span>      justification="Will not 
overflow")<a name="line.379"></a>
-<span class="sourceLineNo">380</span>  public static class Builder {<a 
name="line.380"></a>
-<span class="sourceLineNo">381</span>    private final Configuration conf;<a 
name="line.381"></a>
-<span class="sourceLineNo">382</span>    private final CacheConfig 
cacheConf;<a name="line.382"></a>
-<span class="sourceLineNo">383</span>    private final FileSystem fs;<a 
name="line.383"></a>
-<span class="sourceLineNo">384</span><a name="line.384"></a>
-<span class="sourceLineNo">385</span>    private CellComparator comparator = 
CellComparator.COMPARATOR;<a name="line.385"></a>
-<span class="sourceLineNo">386</span>    private BloomType bloomType = 
BloomType.NONE;<a name="line.386"></a>
-<span class="sourceLineNo">387</span>    private long maxKeyCount = 0;<a 
name="line.387"></a>
-<span class="sourceLineNo">388</span>    private Path dir;<a 
name="line.388"></a>
-<span class="sourceLineNo">389</span>    private Path filePath;<a 
name="line.389"></a>
-<span class="sourceLineNo">390</span>    private InetSocketAddress[] 
favoredNodes;<a name="line.390"></a>
-<span class="sourceLineNo">391</span>    private HFileContext fileContext;<a 
name="line.391"></a>
-<span class="sourceLineNo">392</span>    private TimeRangeTracker trt;<a 
name="line.392"></a>
-<span class="sourceLineNo">393</span>    private boolean 
shouldDropCacheBehind;<a name="line.393"></a>
-<span class="sourceLineNo">394</span><a name="line.394"></a>
-<span class="sourceLineNo">395</span>    public Builder(Configuration conf, 
CacheConfig cacheConf,<a name="line.395"></a>
-<span class="sourceLineNo">396</span>        FileSystem fs) {<a 
name="line.396"></a>
-<span class="sourceLineNo">397</span>      this.conf = conf;<a 
name="line.397"></a>
-<span class="sourceLineNo">398</span>      this.cacheConf = cacheConf;<a 
name="line.398"></a>
-<span class="sourceLineNo">399</span>      this.fs = fs;<a name="line.399"></a>
-<span class="sourceLineNo">400</span>    }<a name="line.400"></a>
-<span class="sourceLineNo">401</span><a name="line.401"></a>
-<span class="sourceLineNo">402</span>    /**<a name="line.402"></a>
-<span class="sourceLineNo">403</span>     * Creates Builder with cache 
configuration disabled<a name="line.403"></a>
-<span class="sourceLineNo">404</span>     */<a name="line.404"></a>
-<span class="sourceLineNo">405</span>    public Builder(Configuration conf, 
FileSystem fs) {<a name="line.405"></a>
-<span class="sourceLineNo">406</span>      this.conf = conf;<a 
name="line.406"></a>
-<span class="sourceLineNo">407</span>      this.cacheConf = 
CacheConfig.DISABLED;<a name="line.407"></a>
-<span class="sourceLineNo">408</span>      this.fs = fs;<a name="line.408"></a>
-<span class="sourceLineNo">409</span>    }<a name="line.409"></a>
-<span class="sourceLineNo">410</span><a name="line.410"></a>
-<span class="sourceLineNo">411</span>    /**<a name="line.411"></a>
-<span class="sourceLineNo">412</span>     * @param trt A premade 
TimeRangeTracker to use rather than build one per append (building one<a 
name="line.412"></a>
-<span class="sourceLineNo">413</span>     * of these is expensive so good to 
pass one in if you have one).<a name="line.413"></a>
-<span class="sourceLineNo">414</span>     * @return this (for chained 
invocation)<a name="line.414"></a>
-<span class="sourceLineNo">415</span>     */<a name="line.415"></a>
-<span class="sourceLineNo">416</span>    public Builder 
withTimeRangeTracker(final TimeRangeTracker trt) {<a name="line.416"></a>
-<span class="sourceLineNo">417</span>      Preconditions.checkNotNull(trt);<a 
name="line.417"></a>
-<span class="sourceLineNo">418</span>      this.trt = trt;<a 
name="line.418"></a>
-<span class="sourceLineNo">419</span>      return this;<a name="line.419"></a>
-<span class="sourceLineNo">420</span>    }<a name="line.420"></a>
-<span class="sourceLineNo">421</span><a name="line.421"></a>
-<span class="sourceLineNo">422</span>    /**<a name="line.422"></a>
-<span class="sourceLineNo">423</span>     * Use either this method or {@link 
#withFilePath}, but not both.<a name="line.423"></a>
-<span class="sourceLineNo">424</span>     * @param dir Path to column family 
directory. The directory is created if<a name="line.424"></a>
-<span class="sourceLineNo">425</span>     *          does not exist. The file 
is given a unique name within this<a name="line.425"></a>
-<span class="sourceLineNo">426</span>     *          directory.<a 
name="line.426"></a>
-<span class="sourceLineNo">427</span>     * @return this (for chained 
invocation)<a name="line.427"></a>
-<span class="sourceLineNo">428</span>     */<a name="line.428"></a>
-<span class="sourceLineNo">429</span>    public Builder withOutputDir(Path 
dir) {<a name="line.429"></a>
-<span class="sourceLineNo">430</span>      Preconditions.checkNotNull(dir);<a 
name="line.430"></a>
-<span class="sourceLineNo">431</span>      this.dir = dir;<a 
name="line.431"></a>
-<span class="sourceLineNo">432</span>      return this;<a name="line.432"></a>
-<span class="sourceLineNo">433</span>    }<a name="line.433"></a>
-<span class="sourceLineNo">434</span><a name="line.434"></a>
-<span class="sourceLineNo">435</span>    /**<a name="line.435"></a>
-<span class="sourceLineNo">436</span>     * Use either this method or {@link 
#withOutputDir}, but not both.<a name="line.436"></a>
-<span class="sourceLineNo">437</span>     * @param filePath the StoreFile path 
to write<a name="line.437"></a>
-<span class="sourceLineNo">438</span>     * @return this (for chained 
invocation)<a name="line.438"></a>
-<span class="sourceLineNo">439</span>     */<a name="line.439"></a>
-<span class="sourceLineNo">440</span>    public Builder withFilePath(Path 
filePath) {<a name="line.440"></a>
-<span class="sourceLineNo">441</span>      
Preconditions.checkNotNull(filePath);<a name="line.441"></a>
-<span class="sourceLineNo">442</span>      this.filePath = filePath;<a 
name="line.442"></a>
-<span class="sourceLineNo">443</span>      return this;<a name="line.443"></a>
-<span class="sourceLineNo">444</span>    }<a name="line.444"></a>
-<span class="sourceLineNo">445</span><a name="line.445"></a>
-<span class="sourceLineNo">446</span>    /**<a name="line.446"></a>
-<span class="sourceLineNo">447</span>     * @param favoredNodes an array of 
favored nodes or possibly null<a name="line.447"></a>
-<span class="sourceLineNo">448</span>     * @return this (for chained 
invocation)<a name="line.448"></a>
-<span class="sourceLineNo">449</span>     */<a name="line.449"></a>
-<span class="sourceLineNo">450</span>    public Builder 
withFavoredNodes(InetSocketAddress[] favoredNodes) {<a name="line.450"></a>
-<span class="sourceLineNo">451</span>      this.favoredNodes = favoredNodes;<a 
name="line.451"></a>
-<span class="sourceLineNo">452</span>      return this;<a name="line.452"></a>
-<span class="sourceLineNo">453</span>    }<a name="line.453"></a>
-<span class="sourceLineNo">454</span><a name="line.454"></a>
-<span class="sourceLineNo">455</span>    public Builder 
withComparator(CellComparator comparator) {<a name="line.455"></a>
-<span class="sourceLineNo">456</span>      
Preconditions.checkNotNull(comparator);<a name="line.456"></a>
-<span class="sourceLineNo">457</span>      this.comparator = comparator;<a 
name="line.457"></a>
-<span class="sourceLineNo">458</span>      return this;<a name="line.458"></a>
-<span class="sourceLineNo">459</span>    }<a name="line.459"></a>
-<span class="sourceLineNo">460</span><a name="line.460"></a>
-<span class="sourceLineNo">461</span>    public Builder 
withBloomType(BloomType bloomType) {<a name="line.461"></a>
-<span class="sourceLineNo">462</span>      
Preconditions.checkNotNull(bloomType);<a name="line.462"></a>
-<span class="sourceLineNo">463</span>      this.bloomType = bloomType;<a 
name="line.463"></a>
-<span class="sourceLineNo">464</span>      return this;<a name="line.464"></a>
-<span class="sourceLineNo">465</span>    }<a name="line.465"></a>
-<span class="sourceLineNo">466</span><a name="line.466"></a>
-<span class="sourceLineNo">467</span>    /**<a name="line.467"></a>
-<span class="sourceLineNo">468</span>     * @param maxKeyCount estimated 
maximum number of keys we expect to add<a name="line.468"></a>
-<span class="sourceLineNo">469</span>     * @return this (for chained 
invocation)<a name="line.469"></a>
-<span class="sourceLineNo">470</span>     */<a name="line.470"></a>
-<span class="sourceLineNo">471</span>    public Builder withMaxKeyCount(long 
maxKeyCount) {<a name="line.471"></a>
-<span class="sourceLineNo">472</span>      this.maxKeyCount = maxKeyCount;<a 
name="line.472"></a>
-<span class="sourceLineNo">473</span>      return this;<a name="line.473"></a>
-<span class="sourceLineNo">474</span>    }<a name="line.474"></a>
-<span class="sourceLineNo">475</span><a name="line.475"></a>
-<span class="sourceLineNo">476</span>    public Builder 
withFileContext(HFileContext fileContext) {<a name="line.476"></a>
-<span class="sourceLineNo">477</span>      this.fileContext = fileContext;<a 
name="line.477"></a>
-<span class="sourceLineNo">478</span>      return this;<a name="line.478"></a>
-<span class="sourceLineNo">479</span>    }<a name="line.479"></a>
-<span class="sourceLineNo">480</span><a name="line.480"></a>
-<span class="sourceLineNo">481</span>    public Builder 
withShouldDropCacheBehind(boolean shouldDropCacheBehind) {<a 
name="line.481"></a>
-<span class="sourceLineNo">482</span>      this.shouldDropCacheBehind = 
shouldDropCacheBehind;<a name="line.482"></a>
-<span class="sourceLineNo">483</span>      return this;<a name="line.483"></a>
-<span class="sourceLineNo">484</span>    }<a name="line.484"></a>
-<span class="sourceLineNo">485</span><a name="line.485"></a>
-<span class="sourceLineNo">486</span>    /**<a name="line.486"></a>
-<span class="sourceLineNo">487</span>     * Create a store file writer. Client 
is responsible for closing file when<a name="line.487"></a>
-<span class="sourceLineNo">488</span>     * done. If metadata, add BEFORE 
closing using<a name="line.488"></a>
-<span class="sourceLineNo">489</span>     * {@link 
StoreFileWriter#appendMetadata}.<a name="line.489"></a>
-<span class="sourceLineNo">490</span>     */<a name="line.490"></a>
-<span class="sourceLineNo">491</span>    public StoreFileWriter build() throws 
IOException {<a name="line.491"></a>
-<span class="sourceLineNo">492</span>      if ((dir == null ? 0 : 1) + 
(filePath == null ? 0 : 1) != 1) {<a name="line.492"></a>
-<span class="sourceLineNo">493</span>        throw new 
IllegalArgumentException("Either specify parent directory " +<a 
name="line.493"></a>
-<span class="sourceLineNo">494</span>            "or file path");<a 
name="line.494"></a>
-<span class="sourceLineNo">495</span>      }<a name="line.495"></a>
-<span class="sourceLineNo">496</span><a name="line.496"></a>
-<span class="sourceLineNo">497</span>      if (dir == null) {<a 
name="line.497"></a>
-<span class="sourceLineNo">498</span>        dir = filePath.getParent();<a 
name="line.498"></a>
-<span class="sourceLineNo">499</span>      }<a name="line.499"></a>
-<span class="sourceLineNo">500</span><a name="line.500"></a>
-<span class="sourceLineNo">501</span>      if (!fs.exists(dir)) {<a 
name="line.501"></a>
-<span class="sourceLineNo">502</span>        // Handle permission for non-HDFS 
filesystem properly<a name="line.502"></a>
-<span class="sourceLineNo">503</span>        // See HBASE-17710<a 
name="line.503"></a>
-<span class="sourceLineNo">504</span>        HRegionFileSystem.mkdirs(fs, 
conf, dir);<a name="line.504"></a>
-<span class="sourceLineNo">505</span>      }<a name="line.505"></a>
-<span class="sourceLineNo">506</span><a name="line.506"></a>
-<span class="sourceLineNo">507</span>      // set block storage policy for 
temp path<a name="line.507"></a>
-<span class="sourceLineNo">508</span>      String policyName = 
this.conf.get(ColumnFamilyDescriptorBuilder.STORAGE_POLICY);<a 
name="line.508"></a>
-<span class="sourceLineNo">509</span>      if (null == policyName) {<a 
name="line.509"></a>
-<span class="sourceLineNo">510</span>        policyName = 
this.conf.get(HStore.BLOCK_STORAGE_POLICY_KEY);<a name="line.510"></a>
-<span class="sourceLineNo">511</span>      }<a name="line.511"></a>
-<span class="sourceLineNo">512</span>      FSUtils.setStoragePolicy(this.fs, 
dir, policyName);<a name="line.512"></a>
-<span class="sourceLineNo">513</span><a name="line.513"></a>
-<span class="sourceLineNo">514</span>      if (filePath == null) {<a 
name="line.514"></a>
-<span class="sourceLineNo">515</span>        filePath = getUniqueFile(fs, 
dir);<a name="line.515"></a>
-<span class="sourceLineNo">516</span>        if 
(!BloomFilterFactory.isGeneralBloomEnabled(conf)) {<a name="line.516"></a>
-<span class="sourceLineNo">517</span>          bloomType = BloomType.NONE;<a 
name="line.517"></a>
-<span class="sourceLineNo">518</span>        }<a name="line.518"></a>
-<span class="sourceLineNo">519</span>      }<a name="line.519"></a>
-<span class="sourceLineNo">520</span><a name="line.520"></a>
-<span class="sourceLineNo">521</span>      if (comparator == null) {<a 
name="line.521"></a>
-<span class="sourceLineNo">522</span>        comparator = 
CellComparator.COMPARATOR;<a name="line.522"></a>
-<span class="sourceLineNo">523</span>      }<a name="line.523"></a>
-<span class="sourceLineNo">524</span>      return new StoreFileWriter(fs, 
filePath,<a name="line.524"></a>
-<span class="sourceLineNo">525</span>          conf, cacheConf, comparator, 
bloomType, maxKeyCount, favoredNodes, fileContext,<a name="line.525"></a>
-<span class="sourceLineNo">526</span>          shouldDropCacheBehind, trt);<a 
name="line.526"></a>
-<span class="sourceLineNo">527</span>    }<a name="line.527"></a>
-<span class="sourceLineNo">528</span>  }<a name="line.528"></a>
-<span class="sourceLineNo">529</span>}<a name="line.529"></a>
+<span class="sourceLineNo">296</span>    // append file info about the number 
of delete family kvs<a name="line.296"></a>
+<span class="sourceLineNo">297</span>    // even if there is no delete family 
Bloom.<a name="line.297"></a>
+<span class="sourceLineNo">298</span>    
writer.appendFileInfo(DELETE_FAMILY_COUNT, 
Bytes.toBytes(this.deleteFamilyCnt));<a name="line.298"></a>
+<span class="sourceLineNo">299</span><a name="line.299"></a>
+<span class="sourceLineNo">300</span>    return hasDeleteFamilyBloom;<a 
name="line.300"></a>
+<span class="sourceLineNo">301</span>  }<a name="line.301"></a>
+<span class="sourceLineNo">302</span><a name="line.302"></a>
+<span class="sourceLineNo">303</span>  public void close() throws IOException 
{<a name="line.303"></a>
+<span class="sourceLineNo">304</span>    boolean hasGeneralBloom = 
this.closeGeneralBloomFilter();<a name="line.304"></a>
+<span class="sourceLineNo">305</span>    boolean hasDeleteFamilyBloom = 
this.closeDeleteFamilyBloomFilter();<a name="line.305"></a>
+<span class="sourceLineNo">306</span><a name="line.306"></a>
+<span class="sourceLineNo">307</span>    writer.close();<a name="line.307"></a>
+<span class="sourceLineNo">308</span><a name="line.308"></a>
+<span class="sourceLineNo">309</span>    // Log final Bloom filter statistics. 
This needs to be done after close()<a name="line.309"></a>
+<span class="sourceLineNo">310</span>    // because compound Bloom filters 
might be finalized as part of closing.<a name="line.310"></a>
+<span class="sourceLineNo">311</span>    if (LOG.isTraceEnabled()) {<a 
name="line.311"></a>
+<span class="sourceLineNo">312</span>      LOG.trace((hasGeneralBloom ? "" : 
"NO ") + "General Bloom and " +<a name="line.312"></a>
+<span class="sourceLineNo">313</span>        (hasDeleteFamilyBloom ? "" : "NO 
") + "DeleteFamily" + " was added to HFile " +<a name="line.313"></a>
+<span class="sourceLineNo">314</span>        getPath());<a name="line.314"></a>
+<span class="sourceLineNo">315</span>    }<a name="line.315"></a>
+<span class="sourceLineNo">316</span><a name="line.316"></a>
+<span class="sourceLineNo">317</span>  }<a name="line.317"></a>
+<span class="sourceLineNo">318</span><a name="line.318"></a>
+<span class="sourceLineNo">319</span>  public void appendFileInfo(byte[] key, 
byte[] value) throws IOException {<a name="line.319"></a>
+<span class="sourceLineNo">320</span>    writer.appendFileInfo(key, value);<a 
name="line.320"></a>
+<span class="sourceLineNo">321</span>  }<a name="line.321"></a>
+<span class="sourceLineNo">322</span><a name="line.322"></a>
+<span class="sourceLineNo">323</span>  /** For use in testing.<a 
name="line.323"></a>
+<span class="sourceLineNo">324</span>   */<a name="line.324"></a>
+<span class="sourceLineNo">325</span>  HFile.Writer getHFileWriter() {<a 
name="line.325"></a>
+<span class="sourceLineNo">326</span>    return writer;<a name="line.326"></a>
+<span class="sourceLineNo">327</span>  }<a name="line.327"></a>
+<span class="sourceLineNo">328</span><a name="line.328"></a>
+<span class="sourceLineNo">329</span>  /**<a name="line.329"></a>
+<span class="sourceLineNo">330</span>   * @param fs<a name="line.330"></a>
+<span class="sourceLineNo">331</span>   * @param dir Directory to create file 
in.<a name="line.331"></a>
+<span class="sourceLineNo">332</span>   * @return random filename inside 
passed &lt;code&gt;dir&lt;/code&gt;<a name="line.332"></a>
+<span class="sourceLineNo">333</span>   */<a name="line.333"></a>
+<span class="sourceLineNo">334</span>  static Path getUniqueFile(final 
FileSystem fs, final Path dir) throws IOException {<a name="line.334"></a>
+<span class="sourceLineNo">335</span>    if 
(!fs.getFileStatus(dir).isDirectory()) {<a name="line.335"></a>
+<span class="sourceLineNo">336</span>      throw new IOException("Expecting " 
+ dir.toString() + " to be a directory");<a name="line.336"></a>
+<span class="sourceLineNo">337</span>    }<a name="line.337"></a>
+<span class="sourceLineNo">338</span>    return new Path(dir, 
dash.matcher(UUID.randomUUID().toString()).replaceAll(""));<a 
name="line.338"></a>
+<span class="sourceLineNo">339</span>  }<a name="line.339"></a>
+<span class="sourceLineNo">340</span><a name="line.340"></a>
+<span class="sourceLineNo">341</span>  
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="ICAST_INTEGER_MULTIPLY_CAST_TO_LONG",<a
 name="line.341"></a>
+<span class="sourceLineNo">342</span>      justification="Will not 
overflow")<a name="line.342"></a>
+<span class="sourceLineNo">343</span>  public static class Builder {<a 
name="line.343"></a>
+<span class="sourceLineNo">344</span>    private final Configuration conf;<a 
name="line.344"></a>
+<span class="sourceLineNo">345</span>    private final CacheConfig 
cacheConf;<a name="line.345"></a>
+<span class="sourceLineNo">346</span>    private final FileSystem fs;<a 
name="line.346"></a>
+<span class="sourceLineNo">347</span><a name="line.347"></a>
+<span class="sourceLineNo">348</span>    private CellComparator comparator = 
CellComparator.COMPARATOR;<a name="line.348"></a>
+<span class="sourceLineNo">349</span>    private BloomType bloomType = 
BloomType.NONE;<a name="line.349"></a>
+<span class="sourceLineNo">350</span>    private long maxKeyCount = 0;<a 
name="line.350"></a>
+<span class="sourceLineNo">351</span>    private Path dir;<a 
name="line.351"></a>
+<span class="sourceLineNo">352</span>    private Path filePath;<a 
name="line.352"></a>
+<span class="sourceLineNo">353</span>    private InetSocketAddress[] 
favoredNodes;<a name="line.353"></a>
+<span class="sourceLineNo">354</span>    private HFileContext fileContext;<a 
name="line.354"></a>
+<span class="sourceLineNo">355</span>    private boolean 
shouldDropCacheBehind;<a name="line.355"></a>
+<span class="sourceLineNo">356</span><a name="line.356"></a>
+<span class="sourceLineNo">357</span>    public Builder(Configuration conf, 
CacheConfig cacheConf,<a name="line.357"></a>
+<span class="sourceLineNo">358</span>        FileSystem fs) {<a 
name="line.358"></a>
+<span class="sourceLineNo">359</span>      this.conf = conf;<a 
name="line.359"></a>
+<span class="sourceLineNo">360</span>      this.cacheConf = cacheConf;<a 
name="line.360"></a>
+<span class="sourceLineNo">361</span>      this.fs = fs;<a name="line.361"></a>
+<span class="sourceLineNo">362</span>    }<a name="line.362"></a>
+<span class="sourceLineNo">363</span><a name="line.363"></a>
+<span class="sourceLineNo">364</span>    /**<a name="line.364"></a>
+<span class="sourceLineNo">365</span>     * Creates Builder with cache 
configuration disabled<a name="line.365"></a>
+<span class="sourceLineNo">366</span>     */<a name="line.366"></a>
+<span class="sourceLineNo">367</span>    public Builder(Configuration conf, 
FileSystem fs) {<a name="line.367"></a>
+<span class="sourceLineNo">368</span>      this.conf = conf;<a 
name="line.368"></a>
+<span class="sourceLineNo">369</span>      this.cacheConf = 
CacheConfig.DISABLED;<a name="line.369"></a>
+<span class="sourceLineNo">370</span>      this.fs = fs;<a name="line.370"></a>
+<span class="sourceLineNo">371</span>    }<a name="line.371"></a>
+<span class="sourceLineNo">372</span><a name="line.372"></a>
+<span class="sourceLineNo">373</span>    /**<a name="line.373"></a>
+<span class="sourceLineNo">374</span>     * Use either this method or {@link 
#withFilePath}, but not both.<a name="line.374"></a>
+<span class="sourceLineNo">375</span>     * @param dir Path to column family 
directory. The directory is created if<a name="line.375"></a>
+<span class="sourceLineNo">376</span>     *          does not exist. The file 
is given a unique name within this<a name="line.376"></a>
+<span class="sourceLineNo">377</span>     *          directory.<a 
name="line.377"></a>
+<span class="sourceLineNo">378</span>     * @return this (for chained 
invocation)<a name="line.378"></a>
+<span class="sourceLineNo">379</span>     */<a name="line.379"></a>
+<span class="sourceLineNo">380</span>    public Builder withOutputDir(Path 
dir) {<a name="line.380"></a>
+<span class="sourceLineNo">381</span>      Preconditions.checkNotNull(dir);<a 
name="line.381"></a>
+<span class="sourceLineNo">382</span>      this.dir = dir;<a 
name="line.382"></a>
+<span class="sourceLineNo">383</span>      return this;<a name="line.383"></a>
+<span class="sourceLineNo">384</span>    }<a name="line.384"></a>
+<span class="sourceLineNo">385</span><a name="line.385"></a>
+<span class="sourceLineNo">386</span>    /**<a name="line.386"></a>
+<span class="sourceLineNo">387</span>     * Use either this method or {@link 
#withOutputDir}, but not both.<a name="line.387"></a>
+<span class="sourceLineNo">388</span>     * @param filePath the StoreFile path 
to write<a name="line.388"></a>
+<span class="sourceLineNo">389</span>     * @return this (for chained 
invocation)<a name="line.389"></a>
+<span class="sourceLineNo">390</span>     */<a name="line.390"></a>
+<span class="sourceLineNo">391</span>    public Builder withFilePath(Path 
filePath) {<a name="line.391"></a>
+<span class="sourceLineNo">392</span>      
Preconditions.checkNotNull(filePath);<a name="line.392"></a>
+<span class="sourceLineNo">393</span>      this.filePath = filePath;<a 
name="line.393"></a>
+<span class="sourceLineNo">394</span>      return this;<a name="line.394"></a>
+<span class="sourceLineNo">395</span>    }<a name="line.395"></a>
+<span class="sourceLineNo">396</span><a name="line.396"></a>
+<span class="sourceLineNo">397</span>    /**<a name="line.397"></a>
+<span class="sourceLineNo">398</span>     * @param favoredNodes an array of 
favored nodes or possibly null<a name="line.398"></a>
+<span class="sourceLineNo">399</span>     * @return this (for chained 
invocation)<a name="line.399"></a>
+<span class="sourceLineNo">400</span>     */<a name="line.400"></a>
+<span class="sourceLineNo">401</span>    public Builder 
withFavoredNodes(InetSocketAddress[] favoredNodes) {<a name="line.401"></a>
+<span class="sourceLineNo">402</span>      this.favoredNodes = favoredNodes;<a 
name="line.402"></a>
+<span class="sourceLineNo">403</span>      return this;<a name="line.403"></a>
+<span class="sourceLineNo">404</span>    }<a name="line.404"></a>
+<span class="sourceLineNo">405</span><a name="line.405"></a>
+<span class="sourceLineNo">406</span>    public Builder 
withComparator(CellComparator comparator) {<a name="line.406"></a>
+<span class="sourceLineNo">407</span>      
Preconditions.checkNotNull(comparator);<a name="line.407"></a>
+<span class="sourceLineNo">408</span>      this.comparator = comparator;<a 
name="line.408"></a>
+<span class="sourceLineNo">409</span>      return this;<a name="line.409"></a>
+<span class="sourceLineNo">410</span>    }<a name="line.410"></a>
+<span class="sourceLineNo">411</span><a name="line.411"></a>
+<span class="sourceLineNo">412</span>    public Builder 
withBloomType(BloomType bloomType) {<a name="line.412"></a>
+<span class="sourceLineNo">413</span>      
Preconditions.checkNotNull(bloomType);<a name="line.413"></a>
+<span class="sourceLineNo">414</span>      this.bloomType = bloomType;<a 
name="line.414"></a>
+<span class="sourceLineNo">415</span>      return this;<a name="line.415"></a>
+<span class="sourceLineNo">416</span>    }<a name="line.416"></a>
+<span class="sourceLineNo">417</span><a name="line.417"></a>
+<span class="sourceLineNo">418</span>    /**<a name="line.418"></a>
+<span class="sourceLineNo">419</span>     * @param maxKeyCount estimated 
maximum number of keys we expect to add<a name="line.419"></a>
+<span class="sourceLineNo">420</span>     * @return this (for chained 
invocation)<a name="line.420"></a>
+<span class="sourceLineNo">421</span>     */<a name="line.421"></a>
+<span class="sourceLineNo">422</span>    public Builder withMaxKeyCount(long 
maxKeyCount) {<a name="line.422"></a>
+<span class="sourceLineNo">423</span>      this.maxKeyCount = maxKeyCount;<a 
name="line.423"></a>
+<span class="sourceLineNo">424</span>      return this;<a name="line.424"></a>
+<span class="sourceLineNo">425</span>    }<a name="line.425"></a>
+<span class="sourceLineNo">426</span><a name="line.426"></a>
+<span class="sourceLineNo">427</span>    public Builder 
withFileContext(HFileContext fileContext) {<a name="line.427"></a>
+<span class="sourceLineNo">428</span>      this.fileContext = fileContext;<a 
name="line.428"></a>
+<span class="sourceLineNo">429</span>      return this;<a name="line.429"></a>
+<span class="sourceLineNo">430</span>    }<a name="line.430"></a>
+<span class="sourceLineNo">431</span><a name="line.431"></a>
+<span class="sourceLineNo">432</span>    public Builder 
withShouldDropCacheBehind(boolean shouldDropCacheBehind) {<a 
name="line.432"></a>
+<span class="sourceLineNo">433</span>      this.shouldDropCacheBehind = 
shouldDropCacheBehind;<a name="line.433"></a>
+<span class="sourceLineNo">434</span>      return this;<a name="line.434"></a>
+<span class="sourceLineNo">435</span>    }<a name="line.435"></a>
+<span class="sourceLineNo">436</span><a name="line.436"></a>
+<span class="sourceLineNo">437</span>    /**<a name="line.437"></a>
+<span class="sourceLineNo">438</span>     * Create a store file writer. Client 
is responsible for closing file when<a name="line.438"></a>
+<span class="sourceLineNo">439</span>     * done. If metadata, add BEFORE 
closing using<a name="line.439"></a>
+<span class="sourceLineNo">440</span>     * {@link 
StoreFileWriter#appendMetadata}.<a name="line.440"></a>
+<span class="sourceLineNo">441</span>     */<a name="line.441"></a>
+<span class="sourceLineNo">442</span>    public StoreFileWriter build() throws 
IOException {<a name="line.442"></a>
+<span class="sourceLineNo">443</span>      if ((dir == null ? 0 : 1) + 
(filePath == null ? 0 : 1) != 1) {<a name="line.443"></a>
+<span class="sourceLineNo">444</span>        throw new 
IllegalArgumentException("Either specify parent directory " +<a 
name="line.444"></a>
+<span class="sourceLineNo">445</span>            "or file path");<a 
name="line.445"></a>
+<span class="sourceLineNo">446</span>      }<a name="line.446"></a>
+<span class="sourceLineNo">447</span><a name="line.447"></a>
+<span class="sourceLineNo">448</span>      if (dir == null) {<a 
name="line.448"></a>
+<span class="sourceLineNo">449</span>        dir = filePath.getParent();<a 
name="line.449"></a>
+<span class="sourceLineNo">450</span>      }<a name="line.450"></a>
+<span class="sourceLineNo">451</span><a name="line.451"></a>
+<span class="sourceLineNo">452</span>      if (!fs.exists(dir)) {<a 
name="line.452"></a>
+<span class="sourceLineNo">453</span>        // Handle permission for non-HDFS 
filesystem properly<a name="line.453"></a>
+<span class="sourceLineNo">454</span>        // See HBASE-17710<a 
name="line.454"></a>
+<span class="sourceLineNo">455</span>        HRegionFileSystem.mkdirs(fs, 
conf, dir);<a name="line.455"></a>
+<span class="sourceLineNo">456</span>      }<a name="line.456"></a>
+<span class="sourceLineNo">457</span><a name="line.457"></a>
+<span class="sourceLineNo">458</span>      // set block storage policy for 
temp path<a name="line.458"></a>
+<span class="sourceLineNo">459</span>      String policyName = 
this.conf.get(ColumnFamilyDescriptorBuilder.STORAGE_POLICY);<a 
name="line.459"></a>
+<span class="sourceLineNo">460</span>      if (null == policyName) {<a 
name="line.460"></a>
+<span class="sourceLineNo">461</span>        policyName = 
this.conf.get(HStore.BLOCK_STORAGE_POLICY_KEY);<a name="line.461"></a>
+<span class="sourceLineNo">462</span>      }<a name="line.462"></a>
+<span class="sourceLineNo">463</span>      FSUtils.setStoragePolicy(this.fs, 
dir, policyName);<a name="line.463"></a>
+<span class="sourceLineNo">464</span><a name="line.464"></a>
+<span class="sourceLineNo">465</span>      if (filePath == null) {<a 
name="line.465"></a>
+<span class="sourceLineNo">466</span>        filePath = getUniqueFile(fs, 
dir);<a name="line.466"></a>
+<span class="sourceLineNo">467</span>        if 
(!BloomFilterFactory.isGeneralBloomEnabled(conf)) {<a name="line.467"></a>
+<span class="sourceLineNo">468</span>          bloomType = BloomType.NONE;<a 
name="line.468"></a>
+<span class="sourceLineNo">469</span>        }<a name="line.469"></a>
+<span class="sourceLineNo">470</span>      }<a name="line.470"></a>
+<span class="sourceLineNo">471</span><a name="line.471"></a>
+<span class="sourceLineNo">472</span>      if (comparator == null) {<a 
name="line.472"></a>
+<span class="sourceLineNo">473</span>        comparator = 
CellComparator.COMPARATOR;<a name="line.473"></a>
+<span class="sourceLineNo">474</span>      }<a name="line.474"></a>
+<span class="sourceLineNo">475</span>      return new StoreFileWriter(fs, 
filePath,<a name="line.475"></a>
+<span class="sourceLineNo">476</span>          conf, cacheConf, comparator, 
bloomType, maxKeyCount, favoredNodes, fileContext,<a name="line.476"></a>
+<span class="sourceLineNo">477</span>          shouldDropCacheBehind);<a 
name="line.477"></a>
+<span class="sourceLineNo">478</span>    }<a name="line.478"></a>
+<span class="sourceLineNo">479</span>  }<a name="line.479"></a>
+<span class="sourceLineNo">480</span>}<a name="line.480"></a>
[20/29] hbase-site git commit: Published site at .

Reply via email to
