HBASE-19039 refactor shadedjars test to only run on java changes. Signed-off-by: Mike Drob <md...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b10ad9e9 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b10ad9e9 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b10ad9e9 Branch: refs/heads/HBASE-18410 Commit: b10ad9e97f67b462a4ab58ee1d449c9c319c4176 Parents: dd4dbae Author: Sean Busbey <bus...@apache.org> Authored: Fri Oct 20 14:39:03 2017 -0500 Committer: Sean Busbey <bus...@apache.org> Committed: Fri Oct 20 19:35:20 2017 -0500 ---------------------------------------------------------------------- dev-support/hbase-personality.sh | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/b10ad9e9/dev-support/hbase-personality.sh ---------------------------------------------------------------------- diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh index 88e773e..dcf4f7a 100755 --- a/dev-support/hbase-personality.sh +++ b/dev-support/hbase-personality.sh @@ -171,12 +171,19 @@ function shadedjars_initialize { yetus_debug "initializing shaded client checks." maven_add_install shadedjars - add_test shadedjars } -function shadedjars_clean +## @description only run the test if java changes. +## @audience private +## @stability evolving +## @param filename +function shadedjars_filefilter { - "${MAVEN}" "${MAVEN_ARGS[@]}" clean -fae -pl hbase_shaded/hbase-shaded-check-invariants -am -Prelease + local filename=$1 + + if [[ ${filename} =~ \.java$ ]] || [[ ${filename} =~ pom.xml$ ]]; then + add_test shadedjars + fi } ## @description test the shaded client artifacts @@ -188,6 +195,10 @@ function shadedjars_rebuild local repostatus=$1 local logfile="${PATCH_DIR}/${repostatus}-shadedjars.txt" + if ! verify_needed_test shadedjars; then + return 0 + fi + big_console_header "Checking shaded client builds on ${repostatus}" echo_and_redirect "${logfile}" \