Repository: hbase Updated Branches: refs/heads/master 9ed6cf5cb -> 7406c83ef
HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of Signed-off-by: Apekshit Sharma <a...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/7406c83e Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/7406c83e Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/7406c83e Branch: refs/heads/master Commit: 7406c83ef6f5c2f4620e8cbb48630d983c8ad57e Parents: 9ed6cf5 Author: Sean Busbey <bus...@apache.org> Authored: Mon Nov 13 16:12:32 2017 -0600 Committer: Sean Busbey <bus...@apache.org> Committed: Mon Nov 13 22:35:10 2017 -0600 ---------------------------------------------------------------------- dev-support/hbase-personality.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/7406c83e/dev-support/hbase-personality.sh ---------------------------------------------------------------------- diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh index d0d81c6..11f8731 100755 --- a/dev-support/hbase-personality.sh +++ b/dev-support/hbase-personality.sh @@ -431,21 +431,21 @@ function hbaseanti_patchfile start_clock - warnings=$(${GREP} 'new TreeMap<byte.*()' "${patchfile}") + warnings=$(${GREP} -c 'new TreeMap<byte.*()' "${patchfile}") if [[ ${warnings} -gt 0 ]]; then - add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted: ${warnings}." + add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted." ((result=result+1)) fi - warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}") + warnings=$(${GREP} -c 'import org.apache.hadoop.classification' "${patchfile}") if [[ ${warnings} -gt 0 ]]; then - add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}." + add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase." ((result=result+1)) fi - warnings=$(${GREP} 'import org.codehaus.jackson' "${patchfile}") + warnings=$(${GREP} -c 'import org.codehaus.jackson' "${patchfile}") if [[ ${warnings} -gt 0 ]]; then - add_vote_table -1 hbaseanti "" "The patch appears use Jackson 1 classes/annotations: ${warnings}." + add_vote_table -1 hbaseanti "" "The patch appears use Jackson 1 classes/annotations." ((result=result+1)) fi
