Repository: hbase Updated Branches: refs/heads/branch-1.4 9a075fe73 -> 2200397fc
HBASE-19262 Revisit checkstyle rules Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/2200397f Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/2200397f Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/2200397f Branch: refs/heads/branch-1.4 Commit: 2200397fc3f9ff5da04c97269bec5b548d3485a6 Parents: 9a075fe Author: zhangduo <zhang...@apache.org> Authored: Wed Nov 15 15:38:02 2017 +0800 Committer: zhangduo <zhang...@apache.org> Committed: Thu Nov 16 09:43:25 2017 +0800 ---------------------------------------------------------------------- .../src/main/resources/hbase/checkstyle-suppressions.xml | 3 ++- hbase-checkstyle/src/main/resources/hbase/checkstyle.xml | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/2200397f/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml ---------------------------------------------------------------------- diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml index 46009e9..1ecae86 100644 --- a/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml +++ b/hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml @@ -33,5 +33,6 @@ <suppressions> <suppress checks="." files=".*/generated/.*\.java"/> <suppress checks="." files=".*/generated-jamon/.*\.java"/> - <suppress checks="MagicNumberCheck" files=".*Test\.java"/> + <suppress checks="MagicNumberCheck" files=".*/src/test/.*\.java"/> + <suppress checks="VisibilityModifier" files=".*/src/test/.*\.java"/> </suppressions> http://git-wip-us.apache.org/repos/asf/hbase/blob/2200397f/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml ---------------------------------------------------------------------- diff --git a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml index b423095..2240096 100644 --- a/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml +++ b/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml @@ -67,6 +67,7 @@ http://checkstyle.sourceforge.net/config_imports.html --> <module name="AvoidStarImport"/> <module name="ImportOrder"> + <property name="groups" value="*,org.apache.hadoop.hbase.shaded"/> <property name="option" value="top" /> <property name="ordered" value="true"/> <property name="sortStaticImportsAlphabetically" value="true"/>
