Repository: hbase-site Updated Branches: refs/heads/asf-site f2c790b70 -> 1473a64a7
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/1473a64a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.PutThread.html ---------------------------------------------------------------------- diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.PutThread.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.PutThread.html index 06992c4..f5e1b5f 100644 --- a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.PutThread.html +++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.PutThread.html @@ -26,199 +26,226 @@ <span class="sourceLineNo">018</span> */<a name="line.18"></a> <span class="sourceLineNo">019</span>package org.apache.hadoop.hbase.regionserver;<a name="line.19"></a> <span class="sourceLineNo">020</span><a name="line.20"></a> -<span class="sourceLineNo">021</span>import org.apache.commons.logging.Log;<a name="line.21"></a> -<span class="sourceLineNo">022</span>import org.apache.commons.logging.LogFactory;<a name="line.22"></a> -<span class="sourceLineNo">023</span>import org.apache.hadoop.conf.Configuration;<a name="line.23"></a> -<span class="sourceLineNo">024</span>import org.apache.hadoop.fs.FileSystem;<a name="line.24"></a> -<span class="sourceLineNo">025</span>import org.apache.hadoop.fs.Path;<a name="line.25"></a> -<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.*;<a name="line.26"></a> -<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.client.*;<a name="line.27"></a> -<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.regionserver.wal.FSHLog;<a name="line.28"></a> -<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.wal.WALEdit;<a name="line.29"></a> -<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.30"></a> -<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.31"></a> -<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.32"></a> -<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.33"></a> -<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.wal.WAL;<a name="line.34"></a> -<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.wal.WALFactory;<a name="line.35"></a> -<span class="sourceLineNo">036</span>import org.junit.Assert;<a name="line.36"></a> -<span class="sourceLineNo">037</span>import org.junit.Rule;<a name="line.37"></a> -<span class="sourceLineNo">038</span>import org.junit.Test;<a name="line.38"></a> -<span class="sourceLineNo">039</span>import org.junit.experimental.categories.Category;<a name="line.39"></a> -<span class="sourceLineNo">040</span>import org.junit.rules.TestName;<a name="line.40"></a> -<span class="sourceLineNo">041</span><a name="line.41"></a> -<span class="sourceLineNo">042</span>import java.io.IOException;<a name="line.42"></a> -<span class="sourceLineNo">043</span>import java.util.ArrayList;<a name="line.43"></a> -<span class="sourceLineNo">044</span>import java.util.List;<a name="line.44"></a> -<span class="sourceLineNo">045</span>import java.util.concurrent.CountDownLatch;<a name="line.45"></a> -<span class="sourceLineNo">046</span><a name="line.46"></a> -<span class="sourceLineNo">047</span>/**<a name="line.47"></a> -<span class="sourceLineNo">048</span> * Test for HBASE-17471<a name="line.48"></a> -<span class="sourceLineNo">049</span> * MVCCPreAssign is added by HBASE-16698, but pre-assign mvcc is only used in put/delete<a name="line.49"></a> -<span class="sourceLineNo">050</span> * path. Other write paths like increment/append still assign mvcc in ringbuffer's consumer<a name="line.50"></a> -<span class="sourceLineNo">051</span> * thread. If put and increment are used parallel. Then seqid in WAL may not increase monotonically<a name="line.51"></a> -<span class="sourceLineNo">052</span> * Disorder in wals will lead to data loss.<a name="line.52"></a> -<span class="sourceLineNo">053</span> * This case use two thread to put and increment at the same time in a single region.<a name="line.53"></a> -<span class="sourceLineNo">054</span> * Then check the seqid in WAL. If seqid is wal is not monotonically increasing, this case will fail<a name="line.54"></a> -<span class="sourceLineNo">055</span> *<a name="line.55"></a> -<span class="sourceLineNo">056</span> */<a name="line.56"></a> -<span class="sourceLineNo">057</span>@Category({RegionServerTests.class, SmallTests.class})<a name="line.57"></a> -<span class="sourceLineNo">058</span>public class TestWALMonotonicallyIncreasingSeqId {<a name="line.58"></a> -<span class="sourceLineNo">059</span> final Log LOG = LogFactory.getLog(getClass());<a name="line.59"></a> -<span class="sourceLineNo">060</span> private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.60"></a> -<span class="sourceLineNo">061</span> private static Path testDir = TEST_UTIL.getDataTestDir("TestWALMonotonicallyIncreasingSeqId");<a name="line.61"></a> -<span class="sourceLineNo">062</span> private WALFactory wals;<a name="line.62"></a> -<span class="sourceLineNo">063</span> private FileSystem fileSystem;<a name="line.63"></a> -<span class="sourceLineNo">064</span> private Configuration walConf;<a name="line.64"></a> -<span class="sourceLineNo">065</span><a name="line.65"></a> -<span class="sourceLineNo">066</span> public static final String KEY_SEED = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";<a name="line.66"></a> -<span class="sourceLineNo">067</span><a name="line.67"></a> -<span class="sourceLineNo">068</span> private static final int KEY_SEED_LEN = KEY_SEED.length();<a name="line.68"></a> -<span class="sourceLineNo">069</span><a name="line.69"></a> -<span class="sourceLineNo">070</span> private static final char[] KEY_SEED_CHARS = KEY_SEED.toCharArray();<a name="line.70"></a> -<span class="sourceLineNo">071</span><a name="line.71"></a> -<span class="sourceLineNo">072</span> @Rule<a name="line.72"></a> -<span class="sourceLineNo">073</span> public TestName name = new TestName();<a name="line.73"></a> -<span class="sourceLineNo">074</span><a name="line.74"></a> -<span class="sourceLineNo">075</span> private HTableDescriptor getTableDesc(TableName tableName, byte[]... families) {<a name="line.75"></a> -<span class="sourceLineNo">076</span> HTableDescriptor htd = new HTableDescriptor(tableName);<a name="line.76"></a> -<span class="sourceLineNo">077</span> for (byte[] family : families) {<a name="line.77"></a> -<span class="sourceLineNo">078</span> HColumnDescriptor hcd = new HColumnDescriptor(family);<a name="line.78"></a> -<span class="sourceLineNo">079</span> // Set default to be three versions.<a name="line.79"></a> -<span class="sourceLineNo">080</span> hcd.setMaxVersions(Integer.MAX_VALUE);<a name="line.80"></a> -<span class="sourceLineNo">081</span> htd.addFamily(hcd);<a name="line.81"></a> -<span class="sourceLineNo">082</span> }<a name="line.82"></a> -<span class="sourceLineNo">083</span> return htd;<a name="line.83"></a> -<span class="sourceLineNo">084</span> }<a name="line.84"></a> -<span class="sourceLineNo">085</span><a name="line.85"></a> -<span class="sourceLineNo">086</span> private Region initHRegion(HTableDescriptor htd, byte[] startKey, byte[] stopKey, int replicaId)<a name="line.86"></a> -<span class="sourceLineNo">087</span> throws IOException {<a name="line.87"></a> -<span class="sourceLineNo">088</span> Configuration conf = TEST_UTIL.getConfiguration();<a name="line.88"></a> -<span class="sourceLineNo">089</span> conf.setBoolean("hbase.hregion.mvcc.preassign", false);<a name="line.89"></a> -<span class="sourceLineNo">090</span> Path tableDir = FSUtils.getTableDir(testDir, htd.getTableName());<a name="line.90"></a> -<span class="sourceLineNo">091</span><a name="line.91"></a> -<span class="sourceLineNo">092</span> HRegionInfo info = new HRegionInfo(htd.getTableName(), startKey, stopKey, false, 0, replicaId);<a name="line.92"></a> -<span class="sourceLineNo">093</span> fileSystem = tableDir.getFileSystem(conf);<a name="line.93"></a> -<span class="sourceLineNo">094</span> HRegionFileSystem fs = new HRegionFileSystem(conf, fileSystem, tableDir, info);<a name="line.94"></a> -<span class="sourceLineNo">095</span> final Configuration walConf = new Configuration(conf);<a name="line.95"></a> -<span class="sourceLineNo">096</span> FSUtils.setRootDir(walConf, tableDir);<a name="line.96"></a> -<span class="sourceLineNo">097</span> this.walConf = walConf;<a name="line.97"></a> -<span class="sourceLineNo">098</span> wals = new WALFactory(walConf, null, "log_" + replicaId);<a name="line.98"></a> -<span class="sourceLineNo">099</span> ChunkCreator.initialize(MemStoreLABImpl.CHUNK_SIZE_DEFAULT, false, 0, 0, 0, null);<a name="line.99"></a> -<span class="sourceLineNo">100</span> HRegion region = HRegion.createHRegion(info, TEST_UTIL.getDefaultRootDirPath(), conf, htd,<a name="line.100"></a> -<span class="sourceLineNo">101</span> wals.getWAL(info.getEncodedNameAsBytes(), info.getTable().getNamespace()));<a name="line.101"></a> -<span class="sourceLineNo">102</span> return region;<a name="line.102"></a> -<span class="sourceLineNo">103</span> }<a name="line.103"></a> -<span class="sourceLineNo">104</span><a name="line.104"></a> -<span class="sourceLineNo">105</span> CountDownLatch latch = new CountDownLatch(1);<a name="line.105"></a> -<span class="sourceLineNo">106</span> public class PutThread extends Thread {<a name="line.106"></a> -<span class="sourceLineNo">107</span> HRegion region;<a name="line.107"></a> -<span class="sourceLineNo">108</span> public PutThread(HRegion region) {<a name="line.108"></a> -<span class="sourceLineNo">109</span> this.region = region;<a name="line.109"></a> -<span class="sourceLineNo">110</span> }<a name="line.110"></a> -<span class="sourceLineNo">111</span><a name="line.111"></a> -<span class="sourceLineNo">112</span> @Override<a name="line.112"></a> -<span class="sourceLineNo">113</span> public void run() {<a name="line.113"></a> -<span class="sourceLineNo">114</span> try {<a name="line.114"></a> -<span class="sourceLineNo">115</span> for(int i = 0; i < 100; i++) {<a name="line.115"></a> -<span class="sourceLineNo">116</span> byte[] row = Bytes.toBytes("putRow" + i);<a name="line.116"></a> -<span class="sourceLineNo">117</span> Put put = new Put(row);<a name="line.117"></a> -<span class="sourceLineNo">118</span> put.addColumn("cf".getBytes(), Bytes.toBytes(0), Bytes.toBytes(""));<a name="line.118"></a> -<span class="sourceLineNo">119</span> //put.setDurability(Durability.ASYNC_WAL);<a name="line.119"></a> -<span class="sourceLineNo">120</span> latch.await();<a name="line.120"></a> -<span class="sourceLineNo">121</span> region.batchMutate(new Mutation[]{put});<a name="line.121"></a> -<span class="sourceLineNo">122</span> Thread.sleep(10);<a name="line.122"></a> -<span class="sourceLineNo">123</span> }<a name="line.123"></a> -<span class="sourceLineNo">124</span><a name="line.124"></a> +<span class="sourceLineNo">021</span>import static org.junit.Assert.fail;<a name="line.21"></a> +<span class="sourceLineNo">022</span><a name="line.22"></a> +<span class="sourceLineNo">023</span>import java.io.IOException;<a name="line.23"></a> +<span class="sourceLineNo">024</span>import java.util.ArrayList;<a name="line.24"></a> +<span class="sourceLineNo">025</span>import java.util.Arrays;<a name="line.25"></a> +<span class="sourceLineNo">026</span>import java.util.List;<a name="line.26"></a> +<span class="sourceLineNo">027</span>import java.util.concurrent.CountDownLatch;<a name="line.27"></a> +<span class="sourceLineNo">028</span><a name="line.28"></a> +<span class="sourceLineNo">029</span>import org.apache.commons.logging.Log;<a name="line.29"></a> +<span class="sourceLineNo">030</span>import org.apache.commons.logging.LogFactory;<a name="line.30"></a> +<span class="sourceLineNo">031</span>import org.apache.hadoop.conf.Configuration;<a name="line.31"></a> +<span class="sourceLineNo">032</span>import org.apache.hadoop.fs.FileSystem;<a name="line.32"></a> +<span class="sourceLineNo">033</span>import org.apache.hadoop.fs.Path;<a name="line.33"></a> +<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.34"></a> +<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.HConstants;<a name="line.35"></a> +<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.TableName;<a name="line.36"></a> +<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;<a name="line.37"></a> +<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.client.Increment;<a name="line.38"></a> +<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.client.Mutation;<a name="line.39"></a> +<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.client.Put;<a name="line.40"></a> +<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.41"></a> +<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.client.RegionInfoBuilder;<a name="line.42"></a> +<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.client.TableDescriptor;<a name="line.43"></a> +<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.client.TableDescriptorBuilder;<a name="line.44"></a> +<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL;<a name="line.45"></a> +<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.46"></a> +<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.47"></a> +<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.48"></a> +<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.49"></a> +<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.wal.WAL;<a name="line.50"></a> +<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.wal.WALEdit;<a name="line.51"></a> +<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.wal.WALFactory;<a name="line.52"></a> +<span class="sourceLineNo">053</span>import org.junit.After;<a name="line.53"></a> +<span class="sourceLineNo">054</span>import org.junit.AfterClass;<a name="line.54"></a> +<span class="sourceLineNo">055</span>import org.junit.Before;<a name="line.55"></a> +<span class="sourceLineNo">056</span>import org.junit.Rule;<a name="line.56"></a> +<span class="sourceLineNo">057</span>import org.junit.Test;<a name="line.57"></a> +<span class="sourceLineNo">058</span>import org.junit.experimental.categories.Category;<a name="line.58"></a> +<span class="sourceLineNo">059</span>import org.junit.rules.TestName;<a name="line.59"></a> +<span class="sourceLineNo">060</span>import org.junit.runner.RunWith;<a name="line.60"></a> +<span class="sourceLineNo">061</span>import org.junit.runners.Parameterized;<a name="line.61"></a> +<span class="sourceLineNo">062</span>import org.junit.runners.Parameterized.Parameter;<a name="line.62"></a> +<span class="sourceLineNo">063</span>import org.junit.runners.Parameterized.Parameters;<a name="line.63"></a> +<span class="sourceLineNo">064</span><a name="line.64"></a> +<span class="sourceLineNo">065</span>/**<a name="line.65"></a> +<span class="sourceLineNo">066</span> * Test for HBASE-17471.<a name="line.66"></a> +<span class="sourceLineNo">067</span> * <p><a name="line.67"></a> +<span class="sourceLineNo">068</span> * MVCCPreAssign is added by HBASE-16698, but pre-assign mvcc is only used in put/delete path. Other<a name="line.68"></a> +<span class="sourceLineNo">069</span> * write paths like increment/append still assign mvcc in ringbuffer's consumer thread. If put and<a name="line.69"></a> +<span class="sourceLineNo">070</span> * increment are used parallel. Then seqid in WAL may not increase monotonically Disorder in wals<a name="line.70"></a> +<span class="sourceLineNo">071</span> * will lead to data loss.<a name="line.71"></a> +<span class="sourceLineNo">072</span> * <p><a name="line.72"></a> +<span class="sourceLineNo">073</span> * This case use two thread to put and increment at the same time in a single region. Then check the<a name="line.73"></a> +<span class="sourceLineNo">074</span> * seqid in WAL. If seqid is wal is not monotonically increasing, this case will fail<a name="line.74"></a> +<span class="sourceLineNo">075</span> */<a name="line.75"></a> +<span class="sourceLineNo">076</span>@RunWith(Parameterized.class)<a name="line.76"></a> +<span class="sourceLineNo">077</span>@Category({ RegionServerTests.class, SmallTests.class })<a name="line.77"></a> +<span class="sourceLineNo">078</span>public class TestWALMonotonicallyIncreasingSeqId {<a name="line.78"></a> +<span class="sourceLineNo">079</span> private final Log LOG = LogFactory.getLog(getClass());<a name="line.79"></a> +<span class="sourceLineNo">080</span> private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.80"></a> +<span class="sourceLineNo">081</span> private static Path testDir = TEST_UTIL.getDataTestDir("TestWALMonotonicallyIncreasingSeqId");<a name="line.81"></a> +<span class="sourceLineNo">082</span> private WALFactory wals;<a name="line.82"></a> +<span class="sourceLineNo">083</span> private FileSystem fileSystem;<a name="line.83"></a> +<span class="sourceLineNo">084</span> private Configuration walConf;<a name="line.84"></a> +<span class="sourceLineNo">085</span> private HRegion region;<a name="line.85"></a> +<span class="sourceLineNo">086</span><a name="line.86"></a> +<span class="sourceLineNo">087</span> @Parameter<a name="line.87"></a> +<span class="sourceLineNo">088</span> public String walProvider;<a name="line.88"></a> +<span class="sourceLineNo">089</span><a name="line.89"></a> +<span class="sourceLineNo">090</span> @Rule<a name="line.90"></a> +<span class="sourceLineNo">091</span> public TestName name = new TestName();<a name="line.91"></a> +<span class="sourceLineNo">092</span><a name="line.92"></a> +<span class="sourceLineNo">093</span> @Parameters(name = "{index}: wal={0}")<a name="line.93"></a> +<span class="sourceLineNo">094</span> public static List<Object[]> data() {<a name="line.94"></a> +<span class="sourceLineNo">095</span> return Arrays.asList(new Object[] { "asyncfs" }, new Object[] { "filesystem" });<a name="line.95"></a> +<span class="sourceLineNo">096</span> }<a name="line.96"></a> +<span class="sourceLineNo">097</span><a name="line.97"></a> +<span class="sourceLineNo">098</span> private TableDescriptor getTableDesc(TableName tableName, byte[]... families) {<a name="line.98"></a> +<span class="sourceLineNo">099</span> TableDescriptorBuilder builder = TableDescriptorBuilder.newBuilder(tableName);<a name="line.99"></a> +<span class="sourceLineNo">100</span> Arrays.stream(families).map(<a name="line.100"></a> +<span class="sourceLineNo">101</span> f -> ColumnFamilyDescriptorBuilder.newBuilder(f).setMaxVersions(Integer.MAX_VALUE).build())<a name="line.101"></a> +<span class="sourceLineNo">102</span> .forEachOrdered(builder::addColumnFamily);<a name="line.102"></a> +<span class="sourceLineNo">103</span> return builder.build();<a name="line.103"></a> +<span class="sourceLineNo">104</span> }<a name="line.104"></a> +<span class="sourceLineNo">105</span><a name="line.105"></a> +<span class="sourceLineNo">106</span> private HRegion initHRegion(TableDescriptor htd, byte[] startKey, byte[] stopKey, int replicaId)<a name="line.106"></a> +<span class="sourceLineNo">107</span> throws IOException {<a name="line.107"></a> +<span class="sourceLineNo">108</span> Configuration conf = TEST_UTIL.getConfiguration();<a name="line.108"></a> +<span class="sourceLineNo">109</span> conf.set("hbase.wal.provider", walProvider);<a name="line.109"></a> +<span class="sourceLineNo">110</span> conf.setBoolean("hbase.hregion.mvcc.preassign", false);<a name="line.110"></a> +<span class="sourceLineNo">111</span> Path tableDir = FSUtils.getTableDir(testDir, htd.getTableName());<a name="line.111"></a> +<span class="sourceLineNo">112</span><a name="line.112"></a> +<span class="sourceLineNo">113</span> RegionInfo info = RegionInfoBuilder.newBuilder(htd.getTableName()).setStartKey(startKey)<a name="line.113"></a> +<span class="sourceLineNo">114</span> .setEndKey(stopKey).setReplicaId(replicaId).setRegionId(0).build();<a name="line.114"></a> +<span class="sourceLineNo">115</span> fileSystem = tableDir.getFileSystem(conf);<a name="line.115"></a> +<span class="sourceLineNo">116</span> final Configuration walConf = new Configuration(conf);<a name="line.116"></a> +<span class="sourceLineNo">117</span> FSUtils.setRootDir(walConf, tableDir);<a name="line.117"></a> +<span class="sourceLineNo">118</span> this.walConf = walConf;<a name="line.118"></a> +<span class="sourceLineNo">119</span> wals = new WALFactory(walConf, null, "log_" + replicaId);<a name="line.119"></a> +<span class="sourceLineNo">120</span> ChunkCreator.initialize(MemStoreLABImpl.CHUNK_SIZE_DEFAULT, false, 0, 0, 0, null);<a name="line.120"></a> +<span class="sourceLineNo">121</span> HRegion region = HRegion.createHRegion(info, TEST_UTIL.getDefaultRootDirPath(), conf, htd,<a name="line.121"></a> +<span class="sourceLineNo">122</span> wals.getWAL(info.getEncodedNameAsBytes(), info.getTable().getNamespace()));<a name="line.122"></a> +<span class="sourceLineNo">123</span> return region;<a name="line.123"></a> +<span class="sourceLineNo">124</span> }<a name="line.124"></a> <span class="sourceLineNo">125</span><a name="line.125"></a> -<span class="sourceLineNo">126</span> } catch (Throwable t) {<a name="line.126"></a> -<span class="sourceLineNo">127</span> LOG.warn("Error happend when Increment: ", t);<a name="line.127"></a> -<span class="sourceLineNo">128</span> }<a name="line.128"></a> -<span class="sourceLineNo">129</span><a name="line.129"></a> -<span class="sourceLineNo">130</span> }<a name="line.130"></a> -<span class="sourceLineNo">131</span> }<a name="line.131"></a> -<span class="sourceLineNo">132</span><a name="line.132"></a> -<span class="sourceLineNo">133</span> public class IncThread extends Thread {<a name="line.133"></a> -<span class="sourceLineNo">134</span> HRegion region;<a name="line.134"></a> -<span class="sourceLineNo">135</span> public IncThread(HRegion region) {<a name="line.135"></a> -<span class="sourceLineNo">136</span> this.region = region;<a name="line.136"></a> -<span class="sourceLineNo">137</span> }<a name="line.137"></a> -<span class="sourceLineNo">138</span> @Override<a name="line.138"></a> -<span class="sourceLineNo">139</span> public void run() {<a name="line.139"></a> -<span class="sourceLineNo">140</span> try {<a name="line.140"></a> -<span class="sourceLineNo">141</span> for(int i = 0; i < 100; i++) {<a name="line.141"></a> -<span class="sourceLineNo">142</span> byte[] row = Bytes.toBytes("incrementRow" + i);<a name="line.142"></a> -<span class="sourceLineNo">143</span> Increment inc = new Increment(row);<a name="line.143"></a> -<span class="sourceLineNo">144</span> inc.addColumn("cf".getBytes(), Bytes.toBytes(0), 1);<a name="line.144"></a> -<span class="sourceLineNo">145</span> //inc.setDurability(Durability.ASYNC_WAL);<a name="line.145"></a> -<span class="sourceLineNo">146</span> region.increment(inc);<a name="line.146"></a> -<span class="sourceLineNo">147</span> latch.countDown();<a name="line.147"></a> -<span class="sourceLineNo">148</span> Thread.sleep(10);<a name="line.148"></a> -<span class="sourceLineNo">149</span> }<a name="line.149"></a> -<span class="sourceLineNo">150</span><a name="line.150"></a> -<span class="sourceLineNo">151</span><a name="line.151"></a> -<span class="sourceLineNo">152</span> } catch (Throwable t) {<a name="line.152"></a> -<span class="sourceLineNo">153</span> LOG.warn("Error happend when Put: ", t);<a name="line.153"></a> -<span class="sourceLineNo">154</span> }<a name="line.154"></a> +<span class="sourceLineNo">126</span> CountDownLatch latch = new CountDownLatch(1);<a name="line.126"></a> +<span class="sourceLineNo">127</span><a name="line.127"></a> +<span class="sourceLineNo">128</span> public class PutThread extends Thread {<a name="line.128"></a> +<span class="sourceLineNo">129</span> HRegion region;<a name="line.129"></a> +<span class="sourceLineNo">130</span><a name="line.130"></a> +<span class="sourceLineNo">131</span> public PutThread(HRegion region) {<a name="line.131"></a> +<span class="sourceLineNo">132</span> this.region = region;<a name="line.132"></a> +<span class="sourceLineNo">133</span> }<a name="line.133"></a> +<span class="sourceLineNo">134</span><a name="line.134"></a> +<span class="sourceLineNo">135</span> @Override<a name="line.135"></a> +<span class="sourceLineNo">136</span> public void run() {<a name="line.136"></a> +<span class="sourceLineNo">137</span> try {<a name="line.137"></a> +<span class="sourceLineNo">138</span> for (int i = 0; i < 100; i++) {<a name="line.138"></a> +<span class="sourceLineNo">139</span> byte[] row = Bytes.toBytes("putRow" + i);<a name="line.139"></a> +<span class="sourceLineNo">140</span> Put put = new Put(row);<a name="line.140"></a> +<span class="sourceLineNo">141</span> put.addColumn("cf".getBytes(), Bytes.toBytes(0), Bytes.toBytes(""));<a name="line.141"></a> +<span class="sourceLineNo">142</span> latch.await();<a name="line.142"></a> +<span class="sourceLineNo">143</span> region.batchMutate(new Mutation[] { put });<a name="line.143"></a> +<span class="sourceLineNo">144</span> Thread.sleep(10);<a name="line.144"></a> +<span class="sourceLineNo">145</span> }<a name="line.145"></a> +<span class="sourceLineNo">146</span><a name="line.146"></a> +<span class="sourceLineNo">147</span> } catch (Throwable t) {<a name="line.147"></a> +<span class="sourceLineNo">148</span> LOG.warn("Error happend when Increment: ", t);<a name="line.148"></a> +<span class="sourceLineNo">149</span> }<a name="line.149"></a> +<span class="sourceLineNo">150</span> }<a name="line.150"></a> +<span class="sourceLineNo">151</span> }<a name="line.151"></a> +<span class="sourceLineNo">152</span><a name="line.152"></a> +<span class="sourceLineNo">153</span> public class IncThread extends Thread {<a name="line.153"></a> +<span class="sourceLineNo">154</span> HRegion region;<a name="line.154"></a> <span class="sourceLineNo">155</span><a name="line.155"></a> -<span class="sourceLineNo">156</span> }<a name="line.156"></a> -<span class="sourceLineNo">157</span> }<a name="line.157"></a> -<span class="sourceLineNo">158</span><a name="line.158"></a> -<span class="sourceLineNo">159</span> @Test<a name="line.159"></a> -<span class="sourceLineNo">160</span> public void TestWALMonotonicallyIncreasingSeqId() throws Exception {<a name="line.160"></a> -<span class="sourceLineNo">161</span> byte[][] families = new byte[][] {Bytes.toBytes("cf")};<a name="line.161"></a> -<span class="sourceLineNo">162</span> byte[] qf = Bytes.toBytes("cq");<a name="line.162"></a> -<span class="sourceLineNo">163</span> HTableDescriptor htd = getTableDesc(TableName.valueOf(name.getMethodName()), families);<a name="line.163"></a> -<span class="sourceLineNo">164</span> HRegion region = (HRegion)initHRegion(htd, HConstants.EMPTY_START_ROW, HConstants.EMPTY_END_ROW, 0);<a name="line.164"></a> -<span class="sourceLineNo">165</span> List<Thread> putThreads = new ArrayList<>();<a name="line.165"></a> -<span class="sourceLineNo">166</span> for(int i = 0; i < 1; i++) {<a name="line.166"></a> -<span class="sourceLineNo">167</span> putThreads.add(new PutThread(region));<a name="line.167"></a> -<span class="sourceLineNo">168</span> }<a name="line.168"></a> -<span class="sourceLineNo">169</span> IncThread incThread = new IncThread(region);<a name="line.169"></a> -<span class="sourceLineNo">170</span> for(int i = 0; i < 1; i++) {<a name="line.170"></a> -<span class="sourceLineNo">171</span> putThreads.get(i).start();<a name="line.171"></a> -<span class="sourceLineNo">172</span> }<a name="line.172"></a> -<span class="sourceLineNo">173</span> incThread.start();<a name="line.173"></a> -<span class="sourceLineNo">174</span> incThread.join();<a name="line.174"></a> -<span class="sourceLineNo">175</span><a name="line.175"></a> -<span class="sourceLineNo">176</span> Path logPath = ((FSHLog) region.getWAL()).getCurrentFileName();<a name="line.176"></a> -<span class="sourceLineNo">177</span> region.getWAL().rollWriter();<a name="line.177"></a> -<span class="sourceLineNo">178</span> Thread.sleep(10);<a name="line.178"></a> -<span class="sourceLineNo">179</span> Path hbaseDir = new Path(walConf.get(HConstants.HBASE_DIR));<a name="line.179"></a> -<span class="sourceLineNo">180</span> Path oldWalsDir = new Path(hbaseDir, HConstants.HREGION_OLDLOGDIR_NAME);<a name="line.180"></a> -<span class="sourceLineNo">181</span> WAL.Reader reader = null;<a name="line.181"></a> -<span class="sourceLineNo">182</span> try {<a name="line.182"></a> -<span class="sourceLineNo">183</span> reader = wals.createReader(fileSystem, logPath);<a name="line.183"></a> -<span class="sourceLineNo">184</span> } catch (Throwable t) {<a name="line.184"></a> -<span class="sourceLineNo">185</span> reader = wals.createReader(fileSystem, new Path(oldWalsDir, logPath.getName()));<a name="line.185"></a> +<span class="sourceLineNo">156</span> public IncThread(HRegion region) {<a name="line.156"></a> +<span class="sourceLineNo">157</span> this.region = region;<a name="line.157"></a> +<span class="sourceLineNo">158</span> }<a name="line.158"></a> +<span class="sourceLineNo">159</span><a name="line.159"></a> +<span class="sourceLineNo">160</span> @Override<a name="line.160"></a> +<span class="sourceLineNo">161</span> public void run() {<a name="line.161"></a> +<span class="sourceLineNo">162</span> try {<a name="line.162"></a> +<span class="sourceLineNo">163</span> for (int i = 0; i < 100; i++) {<a name="line.163"></a> +<span class="sourceLineNo">164</span> byte[] row = Bytes.toBytes("incrementRow" + i);<a name="line.164"></a> +<span class="sourceLineNo">165</span> Increment inc = new Increment(row);<a name="line.165"></a> +<span class="sourceLineNo">166</span> inc.addColumn("cf".getBytes(), Bytes.toBytes(0), 1);<a name="line.166"></a> +<span class="sourceLineNo">167</span> // inc.setDurability(Durability.ASYNC_WAL);<a name="line.167"></a> +<span class="sourceLineNo">168</span> region.increment(inc);<a name="line.168"></a> +<span class="sourceLineNo">169</span> latch.countDown();<a name="line.169"></a> +<span class="sourceLineNo">170</span> Thread.sleep(10);<a name="line.170"></a> +<span class="sourceLineNo">171</span> }<a name="line.171"></a> +<span class="sourceLineNo">172</span><a name="line.172"></a> +<span class="sourceLineNo">173</span> } catch (Throwable t) {<a name="line.173"></a> +<span class="sourceLineNo">174</span> LOG.warn("Error happend when Put: ", t);<a name="line.174"></a> +<span class="sourceLineNo">175</span> }<a name="line.175"></a> +<span class="sourceLineNo">176</span> }<a name="line.176"></a> +<span class="sourceLineNo">177</span> }<a name="line.177"></a> +<span class="sourceLineNo">178</span><a name="line.178"></a> +<span class="sourceLineNo">179</span> @Before<a name="line.179"></a> +<span class="sourceLineNo">180</span> public void setUp() throws IOException {<a name="line.180"></a> +<span class="sourceLineNo">181</span> byte[][] families = new byte[][] { Bytes.toBytes("cf") };<a name="line.181"></a> +<span class="sourceLineNo">182</span> TableDescriptor htd = getTableDesc(<a name="line.182"></a> +<span class="sourceLineNo">183</span> TableName.valueOf(name.getMethodName().replaceAll("[^0-9A-Za-z_]", "_")), families);<a name="line.183"></a> +<span class="sourceLineNo">184</span> region = initHRegion(htd, HConstants.EMPTY_START_ROW, HConstants.EMPTY_END_ROW, 0);<a name="line.184"></a> +<span class="sourceLineNo">185</span> }<a name="line.185"></a> <span class="sourceLineNo">186</span><a name="line.186"></a> -<span class="sourceLineNo">187</span> }<a name="line.187"></a> -<span class="sourceLineNo">188</span> WAL.Entry e;<a name="line.188"></a> -<span class="sourceLineNo">189</span> try {<a name="line.189"></a> -<span class="sourceLineNo">190</span> long currentMaxSeqid = 0;<a name="line.190"></a> -<span class="sourceLineNo">191</span> while ((e = reader.next()) != null) {<a name="line.191"></a> -<span class="sourceLineNo">192</span> if (!WALEdit.isMetaEditFamily(e.getEdit().getCells().get(0))) {<a name="line.192"></a> -<span class="sourceLineNo">193</span> long currentSeqid = e.getKey().getSequenceId();<a name="line.193"></a> -<span class="sourceLineNo">194</span> if(currentSeqid > currentMaxSeqid) {<a name="line.194"></a> -<span class="sourceLineNo">195</span> currentMaxSeqid = currentSeqid;<a name="line.195"></a> -<span class="sourceLineNo">196</span> } else {<a name="line.196"></a> -<span class="sourceLineNo">197</span> Assert.fail("Current max Seqid is " + currentMaxSeqid<a name="line.197"></a> -<span class="sourceLineNo">198</span> + ", but the next seqid in wal is smaller:" + currentSeqid);<a name="line.198"></a> -<span class="sourceLineNo">199</span> }<a name="line.199"></a> -<span class="sourceLineNo">200</span> }<a name="line.200"></a> -<span class="sourceLineNo">201</span> }<a name="line.201"></a> -<span class="sourceLineNo">202</span> } finally {<a name="line.202"></a> -<span class="sourceLineNo">203</span> if(reader != null) {<a name="line.203"></a> -<span class="sourceLineNo">204</span> reader.close();<a name="line.204"></a> -<span class="sourceLineNo">205</span> }<a name="line.205"></a> -<span class="sourceLineNo">206</span> if(region != null) {<a name="line.206"></a> -<span class="sourceLineNo">207</span> region.close();<a name="line.207"></a> -<span class="sourceLineNo">208</span> }<a name="line.208"></a> -<span class="sourceLineNo">209</span> }<a name="line.209"></a> -<span class="sourceLineNo">210</span> }<a name="line.210"></a> -<span class="sourceLineNo">211</span><a name="line.211"></a> -<span class="sourceLineNo">212</span><a name="line.212"></a> -<span class="sourceLineNo">213</span>}<a name="line.213"></a> +<span class="sourceLineNo">187</span> @After<a name="line.187"></a> +<span class="sourceLineNo">188</span> public void tearDown() throws IOException {<a name="line.188"></a> +<span class="sourceLineNo">189</span> if (region != null) {<a name="line.189"></a> +<span class="sourceLineNo">190</span> region.close();<a name="line.190"></a> +<span class="sourceLineNo">191</span> }<a name="line.191"></a> +<span class="sourceLineNo">192</span> }<a name="line.192"></a> +<span class="sourceLineNo">193</span><a name="line.193"></a> +<span class="sourceLineNo">194</span> @AfterClass<a name="line.194"></a> +<span class="sourceLineNo">195</span> public static void tearDownAfterClass() throws IOException {<a name="line.195"></a> +<span class="sourceLineNo">196</span> TEST_UTIL.cleanupTestDir();<a name="line.196"></a> +<span class="sourceLineNo">197</span> }<a name="line.197"></a> +<span class="sourceLineNo">198</span><a name="line.198"></a> +<span class="sourceLineNo">199</span> private WAL.Reader createReader(Path logPath, Path oldWalsDir) throws IOException {<a name="line.199"></a> +<span class="sourceLineNo">200</span> try {<a name="line.200"></a> +<span class="sourceLineNo">201</span> return wals.createReader(fileSystem, logPath);<a name="line.201"></a> +<span class="sourceLineNo">202</span> } catch (IOException e) {<a name="line.202"></a> +<span class="sourceLineNo">203</span> return wals.createReader(fileSystem, new Path(oldWalsDir, logPath.getName()));<a name="line.203"></a> +<span class="sourceLineNo">204</span> }<a name="line.204"></a> +<span class="sourceLineNo">205</span> }<a name="line.205"></a> +<span class="sourceLineNo">206</span><a name="line.206"></a> +<span class="sourceLineNo">207</span> @Test<a name="line.207"></a> +<span class="sourceLineNo">208</span> public void testWALMonotonicallyIncreasingSeqId() throws Exception {<a name="line.208"></a> +<span class="sourceLineNo">209</span> List<Thread> putThreads = new ArrayList<>();<a name="line.209"></a> +<span class="sourceLineNo">210</span> for (int i = 0; i < 1; i++) {<a name="line.210"></a> +<span class="sourceLineNo">211</span> putThreads.add(new PutThread(region));<a name="line.211"></a> +<span class="sourceLineNo">212</span> }<a name="line.212"></a> +<span class="sourceLineNo">213</span> IncThread incThread = new IncThread(region);<a name="line.213"></a> +<span class="sourceLineNo">214</span> for (int i = 0; i < 1; i++) {<a name="line.214"></a> +<span class="sourceLineNo">215</span> putThreads.get(i).start();<a name="line.215"></a> +<span class="sourceLineNo">216</span> }<a name="line.216"></a> +<span class="sourceLineNo">217</span> incThread.start();<a name="line.217"></a> +<span class="sourceLineNo">218</span> incThread.join();<a name="line.218"></a> +<span class="sourceLineNo">219</span><a name="line.219"></a> +<span class="sourceLineNo">220</span> Path logPath = ((AbstractFSWAL<?>) region.getWAL()).getCurrentFileName();<a name="line.220"></a> +<span class="sourceLineNo">221</span> region.getWAL().rollWriter();<a name="line.221"></a> +<span class="sourceLineNo">222</span> Thread.sleep(10);<a name="line.222"></a> +<span class="sourceLineNo">223</span> Path hbaseDir = new Path(walConf.get(HConstants.HBASE_DIR));<a name="line.223"></a> +<span class="sourceLineNo">224</span> Path oldWalsDir = new Path(hbaseDir, HConstants.HREGION_OLDLOGDIR_NAME);<a name="line.224"></a> +<span class="sourceLineNo">225</span> try (WAL.Reader reader = createReader(logPath, oldWalsDir)) {<a name="line.225"></a> +<span class="sourceLineNo">226</span> long currentMaxSeqid = 0;<a name="line.226"></a> +<span class="sourceLineNo">227</span> for (WAL.Entry e; (e = reader.next()) != null;) {<a name="line.227"></a> +<span class="sourceLineNo">228</span> if (!WALEdit.isMetaEditFamily(e.getEdit().getCells().get(0))) {<a name="line.228"></a> +<span class="sourceLineNo">229</span> long currentSeqid = e.getKey().getSequenceId();<a name="line.229"></a> +<span class="sourceLineNo">230</span> if (currentSeqid > currentMaxSeqid) {<a name="line.230"></a> +<span class="sourceLineNo">231</span> currentMaxSeqid = currentSeqid;<a name="line.231"></a> +<span class="sourceLineNo">232</span> } else {<a name="line.232"></a> +<span class="sourceLineNo">233</span> fail("Current max Seqid is " + currentMaxSeqid +<a name="line.233"></a> +<span class="sourceLineNo">234</span> ", but the next seqid in wal is smaller:" + currentSeqid);<a name="line.234"></a> +<span class="sourceLineNo">235</span> }<a name="line.235"></a> +<span class="sourceLineNo">236</span> }<a name="line.236"></a> +<span class="sourceLineNo">237</span> }<a name="line.237"></a> +<span class="sourceLineNo">238</span> }<a name="line.238"></a> +<span class="sourceLineNo">239</span> }<a name="line.239"></a> +<span class="sourceLineNo">240</span>}<a name="line.240"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/1473a64a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html ---------------------------------------------------------------------- diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html index 06992c4..f5e1b5f 100644 --- a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html +++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALMonotonicallyIncreasingSeqId.html @@ -26,199 +26,226 @@ <span class="sourceLineNo">018</span> */<a name="line.18"></a> <span class="sourceLineNo">019</span>package org.apache.hadoop.hbase.regionserver;<a name="line.19"></a> <span class="sourceLineNo">020</span><a name="line.20"></a> -<span class="sourceLineNo">021</span>import org.apache.commons.logging.Log;<a name="line.21"></a> -<span class="sourceLineNo">022</span>import org.apache.commons.logging.LogFactory;<a name="line.22"></a> -<span class="sourceLineNo">023</span>import org.apache.hadoop.conf.Configuration;<a name="line.23"></a> -<span class="sourceLineNo">024</span>import org.apache.hadoop.fs.FileSystem;<a name="line.24"></a> -<span class="sourceLineNo">025</span>import org.apache.hadoop.fs.Path;<a name="line.25"></a> -<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.*;<a name="line.26"></a> -<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.client.*;<a name="line.27"></a> -<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.regionserver.wal.FSHLog;<a name="line.28"></a> -<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.wal.WALEdit;<a name="line.29"></a> -<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.30"></a> -<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.31"></a> -<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.32"></a> -<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.33"></a> -<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.wal.WAL;<a name="line.34"></a> -<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.wal.WALFactory;<a name="line.35"></a> -<span class="sourceLineNo">036</span>import org.junit.Assert;<a name="line.36"></a> -<span class="sourceLineNo">037</span>import org.junit.Rule;<a name="line.37"></a> -<span class="sourceLineNo">038</span>import org.junit.Test;<a name="line.38"></a> -<span class="sourceLineNo">039</span>import org.junit.experimental.categories.Category;<a name="line.39"></a> -<span class="sourceLineNo">040</span>import org.junit.rules.TestName;<a name="line.40"></a> -<span class="sourceLineNo">041</span><a name="line.41"></a> -<span class="sourceLineNo">042</span>import java.io.IOException;<a name="line.42"></a> -<span class="sourceLineNo">043</span>import java.util.ArrayList;<a name="line.43"></a> -<span class="sourceLineNo">044</span>import java.util.List;<a name="line.44"></a> -<span class="sourceLineNo">045</span>import java.util.concurrent.CountDownLatch;<a name="line.45"></a> -<span class="sourceLineNo">046</span><a name="line.46"></a> -<span class="sourceLineNo">047</span>/**<a name="line.47"></a> -<span class="sourceLineNo">048</span> * Test for HBASE-17471<a name="line.48"></a> -<span class="sourceLineNo">049</span> * MVCCPreAssign is added by HBASE-16698, but pre-assign mvcc is only used in put/delete<a name="line.49"></a> -<span class="sourceLineNo">050</span> * path. Other write paths like increment/append still assign mvcc in ringbuffer's consumer<a name="line.50"></a> -<span class="sourceLineNo">051</span> * thread. If put and increment are used parallel. Then seqid in WAL may not increase monotonically<a name="line.51"></a> -<span class="sourceLineNo">052</span> * Disorder in wals will lead to data loss.<a name="line.52"></a> -<span class="sourceLineNo">053</span> * This case use two thread to put and increment at the same time in a single region.<a name="line.53"></a> -<span class="sourceLineNo">054</span> * Then check the seqid in WAL. If seqid is wal is not monotonically increasing, this case will fail<a name="line.54"></a> -<span class="sourceLineNo">055</span> *<a name="line.55"></a> -<span class="sourceLineNo">056</span> */<a name="line.56"></a> -<span class="sourceLineNo">057</span>@Category({RegionServerTests.class, SmallTests.class})<a name="line.57"></a> -<span class="sourceLineNo">058</span>public class TestWALMonotonicallyIncreasingSeqId {<a name="line.58"></a> -<span class="sourceLineNo">059</span> final Log LOG = LogFactory.getLog(getClass());<a name="line.59"></a> -<span class="sourceLineNo">060</span> private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.60"></a> -<span class="sourceLineNo">061</span> private static Path testDir = TEST_UTIL.getDataTestDir("TestWALMonotonicallyIncreasingSeqId");<a name="line.61"></a> -<span class="sourceLineNo">062</span> private WALFactory wals;<a name="line.62"></a> -<span class="sourceLineNo">063</span> private FileSystem fileSystem;<a name="line.63"></a> -<span class="sourceLineNo">064</span> private Configuration walConf;<a name="line.64"></a> -<span class="sourceLineNo">065</span><a name="line.65"></a> -<span class="sourceLineNo">066</span> public static final String KEY_SEED = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";<a name="line.66"></a> -<span class="sourceLineNo">067</span><a name="line.67"></a> -<span class="sourceLineNo">068</span> private static final int KEY_SEED_LEN = KEY_SEED.length();<a name="line.68"></a> -<span class="sourceLineNo">069</span><a name="line.69"></a> -<span class="sourceLineNo">070</span> private static final char[] KEY_SEED_CHARS = KEY_SEED.toCharArray();<a name="line.70"></a> -<span class="sourceLineNo">071</span><a name="line.71"></a> -<span class="sourceLineNo">072</span> @Rule<a name="line.72"></a> -<span class="sourceLineNo">073</span> public TestName name = new TestName();<a name="line.73"></a> -<span class="sourceLineNo">074</span><a name="line.74"></a> -<span class="sourceLineNo">075</span> private HTableDescriptor getTableDesc(TableName tableName, byte[]... families) {<a name="line.75"></a> -<span class="sourceLineNo">076</span> HTableDescriptor htd = new HTableDescriptor(tableName);<a name="line.76"></a> -<span class="sourceLineNo">077</span> for (byte[] family : families) {<a name="line.77"></a> -<span class="sourceLineNo">078</span> HColumnDescriptor hcd = new HColumnDescriptor(family);<a name="line.78"></a> -<span class="sourceLineNo">079</span> // Set default to be three versions.<a name="line.79"></a> -<span class="sourceLineNo">080</span> hcd.setMaxVersions(Integer.MAX_VALUE);<a name="line.80"></a> -<span class="sourceLineNo">081</span> htd.addFamily(hcd);<a name="line.81"></a> -<span class="sourceLineNo">082</span> }<a name="line.82"></a> -<span class="sourceLineNo">083</span> return htd;<a name="line.83"></a> -<span class="sourceLineNo">084</span> }<a name="line.84"></a> -<span class="sourceLineNo">085</span><a name="line.85"></a> -<span class="sourceLineNo">086</span> private Region initHRegion(HTableDescriptor htd, byte[] startKey, byte[] stopKey, int replicaId)<a name="line.86"></a> -<span class="sourceLineNo">087</span> throws IOException {<a name="line.87"></a> -<span class="sourceLineNo">088</span> Configuration conf = TEST_UTIL.getConfiguration();<a name="line.88"></a> -<span class="sourceLineNo">089</span> conf.setBoolean("hbase.hregion.mvcc.preassign", false);<a name="line.89"></a> -<span class="sourceLineNo">090</span> Path tableDir = FSUtils.getTableDir(testDir, htd.getTableName());<a name="line.90"></a> -<span class="sourceLineNo">091</span><a name="line.91"></a> -<span class="sourceLineNo">092</span> HRegionInfo info = new HRegionInfo(htd.getTableName(), startKey, stopKey, false, 0, replicaId);<a name="line.92"></a> -<span class="sourceLineNo">093</span> fileSystem = tableDir.getFileSystem(conf);<a name="line.93"></a> -<span class="sourceLineNo">094</span> HRegionFileSystem fs = new HRegionFileSystem(conf, fileSystem, tableDir, info);<a name="line.94"></a> -<span class="sourceLineNo">095</span> final Configuration walConf = new Configuration(conf);<a name="line.95"></a> -<span class="sourceLineNo">096</span> FSUtils.setRootDir(walConf, tableDir);<a name="line.96"></a> -<span class="sourceLineNo">097</span> this.walConf = walConf;<a name="line.97"></a> -<span class="sourceLineNo">098</span> wals = new WALFactory(walConf, null, "log_" + replicaId);<a name="line.98"></a> -<span class="sourceLineNo">099</span> ChunkCreator.initialize(MemStoreLABImpl.CHUNK_SIZE_DEFAULT, false, 0, 0, 0, null);<a name="line.99"></a> -<span class="sourceLineNo">100</span> HRegion region = HRegion.createHRegion(info, TEST_UTIL.getDefaultRootDirPath(), conf, htd,<a name="line.100"></a> -<span class="sourceLineNo">101</span> wals.getWAL(info.getEncodedNameAsBytes(), info.getTable().getNamespace()));<a name="line.101"></a> -<span class="sourceLineNo">102</span> return region;<a name="line.102"></a> -<span class="sourceLineNo">103</span> }<a name="line.103"></a> -<span class="sourceLineNo">104</span><a name="line.104"></a> -<span class="sourceLineNo">105</span> CountDownLatch latch = new CountDownLatch(1);<a name="line.105"></a> -<span class="sourceLineNo">106</span> public class PutThread extends Thread {<a name="line.106"></a> -<span class="sourceLineNo">107</span> HRegion region;<a name="line.107"></a> -<span class="sourceLineNo">108</span> public PutThread(HRegion region) {<a name="line.108"></a> -<span class="sourceLineNo">109</span> this.region = region;<a name="line.109"></a> -<span class="sourceLineNo">110</span> }<a name="line.110"></a> -<span class="sourceLineNo">111</span><a name="line.111"></a> -<span class="sourceLineNo">112</span> @Override<a name="line.112"></a> -<span class="sourceLineNo">113</span> public void run() {<a name="line.113"></a> -<span class="sourceLineNo">114</span> try {<a name="line.114"></a> -<span class="sourceLineNo">115</span> for(int i = 0; i < 100; i++) {<a name="line.115"></a> -<span class="sourceLineNo">116</span> byte[] row = Bytes.toBytes("putRow" + i);<a name="line.116"></a> -<span class="sourceLineNo">117</span> Put put = new Put(row);<a name="line.117"></a> -<span class="sourceLineNo">118</span> put.addColumn("cf".getBytes(), Bytes.toBytes(0), Bytes.toBytes(""));<a name="line.118"></a> -<span class="sourceLineNo">119</span> //put.setDurability(Durability.ASYNC_WAL);<a name="line.119"></a> -<span class="sourceLineNo">120</span> latch.await();<a name="line.120"></a> -<span class="sourceLineNo">121</span> region.batchMutate(new Mutation[]{put});<a name="line.121"></a> -<span class="sourceLineNo">122</span> Thread.sleep(10);<a name="line.122"></a> -<span class="sourceLineNo">123</span> }<a name="line.123"></a> -<span class="sourceLineNo">124</span><a name="line.124"></a> +<span class="sourceLineNo">021</span>import static org.junit.Assert.fail;<a name="line.21"></a> +<span class="sourceLineNo">022</span><a name="line.22"></a> +<span class="sourceLineNo">023</span>import java.io.IOException;<a name="line.23"></a> +<span class="sourceLineNo">024</span>import java.util.ArrayList;<a name="line.24"></a> +<span class="sourceLineNo">025</span>import java.util.Arrays;<a name="line.25"></a> +<span class="sourceLineNo">026</span>import java.util.List;<a name="line.26"></a> +<span class="sourceLineNo">027</span>import java.util.concurrent.CountDownLatch;<a name="line.27"></a> +<span class="sourceLineNo">028</span><a name="line.28"></a> +<span class="sourceLineNo">029</span>import org.apache.commons.logging.Log;<a name="line.29"></a> +<span class="sourceLineNo">030</span>import org.apache.commons.logging.LogFactory;<a name="line.30"></a> +<span class="sourceLineNo">031</span>import org.apache.hadoop.conf.Configuration;<a name="line.31"></a> +<span class="sourceLineNo">032</span>import org.apache.hadoop.fs.FileSystem;<a name="line.32"></a> +<span class="sourceLineNo">033</span>import org.apache.hadoop.fs.Path;<a name="line.33"></a> +<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.34"></a> +<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.HConstants;<a name="line.35"></a> +<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.TableName;<a name="line.36"></a> +<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;<a name="line.37"></a> +<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.client.Increment;<a name="line.38"></a> +<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.client.Mutation;<a name="line.39"></a> +<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.client.Put;<a name="line.40"></a> +<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.41"></a> +<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.client.RegionInfoBuilder;<a name="line.42"></a> +<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.client.TableDescriptor;<a name="line.43"></a> +<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.client.TableDescriptorBuilder;<a name="line.44"></a> +<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL;<a name="line.45"></a> +<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.46"></a> +<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.47"></a> +<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.48"></a> +<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.49"></a> +<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.wal.WAL;<a name="line.50"></a> +<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.wal.WALEdit;<a name="line.51"></a> +<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.wal.WALFactory;<a name="line.52"></a> +<span class="sourceLineNo">053</span>import org.junit.After;<a name="line.53"></a> +<span class="sourceLineNo">054</span>import org.junit.AfterClass;<a name="line.54"></a> +<span class="sourceLineNo">055</span>import org.junit.Before;<a name="line.55"></a> +<span class="sourceLineNo">056</span>import org.junit.Rule;<a name="line.56"></a> +<span class="sourceLineNo">057</span>import org.junit.Test;<a name="line.57"></a> +<span class="sourceLineNo">058</span>import org.junit.experimental.categories.Category;<a name="line.58"></a> +<span class="sourceLineNo">059</span>import org.junit.rules.TestName;<a name="line.59"></a> +<span class="sourceLineNo">060</span>import org.junit.runner.RunWith;<a name="line.60"></a> +<span class="sourceLineNo">061</span>import org.junit.runners.Parameterized;<a name="line.61"></a> +<span class="sourceLineNo">062</span>import org.junit.runners.Parameterized.Parameter;<a name="line.62"></a> +<span class="sourceLineNo">063</span>import org.junit.runners.Parameterized.Parameters;<a name="line.63"></a> +<span class="sourceLineNo">064</span><a name="line.64"></a> +<span class="sourceLineNo">065</span>/**<a name="line.65"></a> +<span class="sourceLineNo">066</span> * Test for HBASE-17471.<a name="line.66"></a> +<span class="sourceLineNo">067</span> * <p><a name="line.67"></a> +<span class="sourceLineNo">068</span> * MVCCPreAssign is added by HBASE-16698, but pre-assign mvcc is only used in put/delete path. Other<a name="line.68"></a> +<span class="sourceLineNo">069</span> * write paths like increment/append still assign mvcc in ringbuffer's consumer thread. If put and<a name="line.69"></a> +<span class="sourceLineNo">070</span> * increment are used parallel. Then seqid in WAL may not increase monotonically Disorder in wals<a name="line.70"></a> +<span class="sourceLineNo">071</span> * will lead to data loss.<a name="line.71"></a> +<span class="sourceLineNo">072</span> * <p><a name="line.72"></a> +<span class="sourceLineNo">073</span> * This case use two thread to put and increment at the same time in a single region. Then check the<a name="line.73"></a> +<span class="sourceLineNo">074</span> * seqid in WAL. If seqid is wal is not monotonically increasing, this case will fail<a name="line.74"></a> +<span class="sourceLineNo">075</span> */<a name="line.75"></a> +<span class="sourceLineNo">076</span>@RunWith(Parameterized.class)<a name="line.76"></a> +<span class="sourceLineNo">077</span>@Category({ RegionServerTests.class, SmallTests.class })<a name="line.77"></a> +<span class="sourceLineNo">078</span>public class TestWALMonotonicallyIncreasingSeqId {<a name="line.78"></a> +<span class="sourceLineNo">079</span> private final Log LOG = LogFactory.getLog(getClass());<a name="line.79"></a> +<span class="sourceLineNo">080</span> private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.80"></a> +<span class="sourceLineNo">081</span> private static Path testDir = TEST_UTIL.getDataTestDir("TestWALMonotonicallyIncreasingSeqId");<a name="line.81"></a> +<span class="sourceLineNo">082</span> private WALFactory wals;<a name="line.82"></a> +<span class="sourceLineNo">083</span> private FileSystem fileSystem;<a name="line.83"></a> +<span class="sourceLineNo">084</span> private Configuration walConf;<a name="line.84"></a> +<span class="sourceLineNo">085</span> private HRegion region;<a name="line.85"></a> +<span class="sourceLineNo">086</span><a name="line.86"></a> +<span class="sourceLineNo">087</span> @Parameter<a name="line.87"></a> +<span class="sourceLineNo">088</span> public String walProvider;<a name="line.88"></a> +<span class="sourceLineNo">089</span><a name="line.89"></a> +<span class="sourceLineNo">090</span> @Rule<a name="line.90"></a> +<span class="sourceLineNo">091</span> public TestName name = new TestName();<a name="line.91"></a> +<span class="sourceLineNo">092</span><a name="line.92"></a> +<span class="sourceLineNo">093</span> @Parameters(name = "{index}: wal={0}")<a name="line.93"></a> +<span class="sourceLineNo">094</span> public static List<Object[]> data() {<a name="line.94"></a> +<span class="sourceLineNo">095</span> return Arrays.asList(new Object[] { "asyncfs" }, new Object[] { "filesystem" });<a name="line.95"></a> +<span class="sourceLineNo">096</span> }<a name="line.96"></a> +<span class="sourceLineNo">097</span><a name="line.97"></a> +<span class="sourceLineNo">098</span> private TableDescriptor getTableDesc(TableName tableName, byte[]... families) {<a name="line.98"></a> +<span class="sourceLineNo">099</span> TableDescriptorBuilder builder = TableDescriptorBuilder.newBuilder(tableName);<a name="line.99"></a> +<span class="sourceLineNo">100</span> Arrays.stream(families).map(<a name="line.100"></a> +<span class="sourceLineNo">101</span> f -> ColumnFamilyDescriptorBuilder.newBuilder(f).setMaxVersions(Integer.MAX_VALUE).build())<a name="line.101"></a> +<span class="sourceLineNo">102</span> .forEachOrdered(builder::addColumnFamily);<a name="line.102"></a> +<span class="sourceLineNo">103</span> return builder.build();<a name="line.103"></a> +<span class="sourceLineNo">104</span> }<a name="line.104"></a> +<span class="sourceLineNo">105</span><a name="line.105"></a> +<span class="sourceLineNo">106</span> private HRegion initHRegion(TableDescriptor htd, byte[] startKey, byte[] stopKey, int replicaId)<a name="line.106"></a> +<span class="sourceLineNo">107</span> throws IOException {<a name="line.107"></a> +<span class="sourceLineNo">108</span> Configuration conf = TEST_UTIL.getConfiguration();<a name="line.108"></a> +<span class="sourceLineNo">109</span> conf.set("hbase.wal.provider", walProvider);<a name="line.109"></a> +<span class="sourceLineNo">110</span> conf.setBoolean("hbase.hregion.mvcc.preassign", false);<a name="line.110"></a> +<span class="sourceLineNo">111</span> Path tableDir = FSUtils.getTableDir(testDir, htd.getTableName());<a name="line.111"></a> +<span class="sourceLineNo">112</span><a name="line.112"></a> +<span class="sourceLineNo">113</span> RegionInfo info = RegionInfoBuilder.newBuilder(htd.getTableName()).setStartKey(startKey)<a name="line.113"></a> +<span class="sourceLineNo">114</span> .setEndKey(stopKey).setReplicaId(replicaId).setRegionId(0).build();<a name="line.114"></a> +<span class="sourceLineNo">115</span> fileSystem = tableDir.getFileSystem(conf);<a name="line.115"></a> +<span class="sourceLineNo">116</span> final Configuration walConf = new Configuration(conf);<a name="line.116"></a> +<span class="sourceLineNo">117</span> FSUtils.setRootDir(walConf, tableDir);<a name="line.117"></a> +<span class="sourceLineNo">118</span> this.walConf = walConf;<a name="line.118"></a> +<span class="sourceLineNo">119</span> wals = new WALFactory(walConf, null, "log_" + replicaId);<a name="line.119"></a> +<span class="sourceLineNo">120</span> ChunkCreator.initialize(MemStoreLABImpl.CHUNK_SIZE_DEFAULT, false, 0, 0, 0, null);<a name="line.120"></a> +<span class="sourceLineNo">121</span> HRegion region = HRegion.createHRegion(info, TEST_UTIL.getDefaultRootDirPath(), conf, htd,<a name="line.121"></a> +<span class="sourceLineNo">122</span> wals.getWAL(info.getEncodedNameAsBytes(), info.getTable().getNamespace()));<a name="line.122"></a> +<span class="sourceLineNo">123</span> return region;<a name="line.123"></a> +<span class="sourceLineNo">124</span> }<a name="line.124"></a> <span class="sourceLineNo">125</span><a name="line.125"></a> -<span class="sourceLineNo">126</span> } catch (Throwable t) {<a name="line.126"></a> -<span class="sourceLineNo">127</span> LOG.warn("Error happend when Increment: ", t);<a name="line.127"></a> -<span class="sourceLineNo">128</span> }<a name="line.128"></a> -<span class="sourceLineNo">129</span><a name="line.129"></a> -<span class="sourceLineNo">130</span> }<a name="line.130"></a> -<span class="sourceLineNo">131</span> }<a name="line.131"></a> -<span class="sourceLineNo">132</span><a name="line.132"></a> -<span class="sourceLineNo">133</span> public class IncThread extends Thread {<a name="line.133"></a> -<span class="sourceLineNo">134</span> HRegion region;<a name="line.134"></a> -<span class="sourceLineNo">135</span> public IncThread(HRegion region) {<a name="line.135"></a> -<span class="sourceLineNo">136</span> this.region = region;<a name="line.136"></a> -<span class="sourceLineNo">137</span> }<a name="line.137"></a> -<span class="sourceLineNo">138</span> @Override<a name="line.138"></a> -<span class="sourceLineNo">139</span> public void run() {<a name="line.139"></a> -<span class="sourceLineNo">140</span> try {<a name="line.140"></a> -<span class="sourceLineNo">141</span> for(int i = 0; i < 100; i++) {<a name="line.141"></a> -<span class="sourceLineNo">142</span> byte[] row = Bytes.toBytes("incrementRow" + i);<a name="line.142"></a> -<span class="sourceLineNo">143</span> Increment inc = new Increment(row);<a name="line.143"></a> -<span class="sourceLineNo">144</span> inc.addColumn("cf".getBytes(), Bytes.toBytes(0), 1);<a name="line.144"></a> -<span class="sourceLineNo">145</span> //inc.setDurability(Durability.ASYNC_WAL);<a name="line.145"></a> -<span class="sourceLineNo">146</span> region.increment(inc);<a name="line.146"></a> -<span class="sourceLineNo">147</span> latch.countDown();<a name="line.147"></a> -<span class="sourceLineNo">148</span> Thread.sleep(10);<a name="line.148"></a> -<span class="sourceLineNo">149</span> }<a name="line.149"></a> -<span class="sourceLineNo">150</span><a name="line.150"></a> -<span class="sourceLineNo">151</span><a name="line.151"></a> -<span class="sourceLineNo">152</span> } catch (Throwable t) {<a name="line.152"></a> -<span class="sourceLineNo">153</span> LOG.warn("Error happend when Put: ", t);<a name="line.153"></a> -<span class="sourceLineNo">154</span> }<a name="line.154"></a> +<span class="sourceLineNo">126</span> CountDownLatch latch = new CountDownLatch(1);<a name="line.126"></a> +<span class="sourceLineNo">127</span><a name="line.127"></a> +<span class="sourceLineNo">128</span> public class PutThread extends Thread {<a name="line.128"></a> +<span class="sourceLineNo">129</span> HRegion region;<a name="line.129"></a> +<span class="sourceLineNo">130</span><a name="line.130"></a> +<span class="sourceLineNo">131</span> public PutThread(HRegion region) {<a name="line.131"></a> +<span class="sourceLineNo">132</span> this.region = region;<a name="line.132"></a> +<span class="sourceLineNo">133</span> }<a name="line.133"></a> +<span class="sourceLineNo">134</span><a name="line.134"></a> +<span class="sourceLineNo">135</span> @Override<a name="line.135"></a> +<span class="sourceLineNo">136</span> public void run() {<a name="line.136"></a> +<span class="sourceLineNo">137</span> try {<a name="line.137"></a> +<span class="sourceLineNo">138</span> for (int i = 0; i < 100; i++) {<a name="line.138"></a> +<span class="sourceLineNo">139</span> byte[] row = Bytes.toBytes("putRow" + i);<a name="line.139"></a> +<span class="sourceLineNo">140</span> Put put = new Put(row);<a name="line.140"></a> +<span class="sourceLineNo">141</span> put.addColumn("cf".getBytes(), Bytes.toBytes(0), Bytes.toBytes(""));<a name="line.141"></a> +<span class="sourceLineNo">142</span> latch.await();<a name="line.142"></a> +<span class="sourceLineNo">143</span> region.batchMutate(new Mutation[] { put });<a name="line.143"></a> +<span class="sourceLineNo">144</span> Thread.sleep(10);<a name="line.144"></a> +<span class="sourceLineNo">145</span> }<a name="line.145"></a> +<span class="sourceLineNo">146</span><a name="line.146"></a> +<span class="sourceLineNo">147</span> } catch (Throwable t) {<a name="line.147"></a> +<span class="sourceLineNo">148</span> LOG.warn("Error happend when Increment: ", t);<a name="line.148"></a> +<span class="sourceLineNo">149</span> }<a name="line.149"></a> +<span class="sourceLineNo">150</span> }<a name="line.150"></a> +<span class="sourceLineNo">151</span> }<a name="line.151"></a> +<span class="sourceLineNo">152</span><a name="line.152"></a> +<span class="sourceLineNo">153</span> public class IncThread extends Thread {<a name="line.153"></a> +<span class="sourceLineNo">154</span> HRegion region;<a name="line.154"></a> <span class="sourceLineNo">155</span><a name="line.155"></a> -<span class="sourceLineNo">156</span> }<a name="line.156"></a> -<span class="sourceLineNo">157</span> }<a name="line.157"></a> -<span class="sourceLineNo">158</span><a name="line.158"></a> -<span class="sourceLineNo">159</span> @Test<a name="line.159"></a> -<span class="sourceLineNo">160</span> public void TestWALMonotonicallyIncreasingSeqId() throws Exception {<a name="line.160"></a> -<span class="sourceLineNo">161</span> byte[][] families = new byte[][] {Bytes.toBytes("cf")};<a name="line.161"></a> -<span class="sourceLineNo">162</span> byte[] qf = Bytes.toBytes("cq");<a name="line.162"></a> -<span class="sourceLineNo">163</span> HTableDescriptor htd = getTableDesc(TableName.valueOf(name.getMethodName()), families);<a name="line.163"></a> -<span class="sourceLineNo">164</span> HRegion region = (HRegion)initHRegion(htd, HConstants.EMPTY_START_ROW, HConstants.EMPTY_END_ROW, 0);<a name="line.164"></a> -<span class="sourceLineNo">165</span> List<Thread> putThreads = new ArrayList<>();<a name="line.165"></a> -<span class="sourceLineNo">166</span> for(int i = 0; i < 1; i++) {<a name="line.166"></a> -<span class="sourceLineNo">167</span> putThreads.add(new PutThread(region));<a name="line.167"></a> -<span class="sourceLineNo">168</span> }<a name="line.168"></a> -<span class="sourceLineNo">169</span> IncThread incThread = new IncThread(region);<a name="line.169"></a> -<span class="sourceLineNo">170</span> for(int i = 0; i < 1; i++) {<a name="line.170"></a> -<span class="sourceLineNo">171</span> putThreads.get(i).start();<a name="line.171"></a> -<span class="sourceLineNo">172</span> }<a name="line.172"></a> -<span class="sourceLineNo">173</span> incThread.start();<a name="line.173"></a> -<span class="sourceLineNo">174</span> incThread.join();<a name="line.174"></a> -<span class="sourceLineNo">175</span><a name="line.175"></a> -<span class="sourceLineNo">176</span> Path logPath = ((FSHLog) region.getWAL()).getCurrentFileName();<a name="line.176"></a> -<span class="sourceLineNo">177</span> region.getWAL().rollWriter();<a name="line.177"></a> -<span class="sourceLineNo">178</span> Thread.sleep(10);<a name="line.178"></a> -<span class="sourceLineNo">179</span> Path hbaseDir = new Path(walConf.get(HConstants.HBASE_DIR));<a name="line.179"></a> -<span class="sourceLineNo">180</span> Path oldWalsDir = new Path(hbaseDir, HConstants.HREGION_OLDLOGDIR_NAME);<a name="line.180"></a> -<span class="sourceLineNo">181</span> WAL.Reader reader = null;<a name="line.181"></a> -<span class="sourceLineNo">182</span> try {<a name="line.182"></a> -<span class="sourceLineNo">183</span> reader = wals.createReader(fileSystem, logPath);<a name="line.183"></a> -<span class="sourceLineNo">184</span> } catch (Throwable t) {<a name="line.184"></a> -<span class="sourceLineNo">185</span> reader = wals.createReader(fileSystem, new Path(oldWalsDir, logPath.getName()));<a name="line.185"></a> +<span class="sourceLineNo">156</span> public IncThread(HRegion region) {<a name="line.156"></a> +<span class="sourceLineNo">157</span> this.region = region;<a name="line.157"></a> +<span class="sourceLineNo">158</span> }<a name="line.158"></a> +<span class="sourceLineNo">159</span><a name="line.159"></a> +<span class="sourceLineNo">160</span> @Override<a name="line.160"></a> +<span class="sourceLineNo">161</span> public void run() {<a name="line.161"></a> +<span class="sourceLineNo">162</span> try {<a name="line.162"></a> +<span class="sourceLineNo">163</span> for (int i = 0; i < 100; i++) {<a name="line.163"></a> +<span class="sourceLineNo">164</span> byte[] row = Bytes.toBytes("incrementRow" + i);<a name="line.164"></a> +<span class="sourceLineNo">165</span> Increment inc = new Increment(row);<a name="line.165"></a> +<span class="sourceLineNo">166</span> inc.addColumn("cf".getBytes(), Bytes.toBytes(0), 1);<a name="line.166"></a> +<span class="sourceLineNo">167</span> // inc.setDurability(Durability.ASYNC_WAL);<a name="line.167"></a> +<span class="sourceLineNo">168</span> region.increment(inc);<a name="line.168"></a> +<span class="sourceLineNo">169</span> latch.countDown();<a name="line.169"></a> +<span class="sourceLineNo">170</span> Thread.sleep(10);<a name="line.170"></a> +<span class="sourceLineNo">171</span> }<a name="line.171"></a> +<span class="sourceLineNo">172</span><a name="line.172"></a> +<span class="sourceLineNo">173</span> } catch (Throwable t) {<a name="line.173"></a> +<span class="sourceLineNo">174</span> LOG.warn("Error happend when Put: ", t);<a name="line.174"></a> +<span class="sourceLineNo">175</span> }<a name="line.175"></a> +<span class="sourceLineNo">176</span> }<a name="line.176"></a> +<span class="sourceLineNo">177</span> }<a name="line.177"></a> +<span class="sourceLineNo">178</span><a name="line.178"></a> +<span class="sourceLineNo">179</span> @Before<a name="line.179"></a> +<span class="sourceLineNo">180</span> public void setUp() throws IOException {<a name="line.180"></a> +<span class="sourceLineNo">181</span> byte[][] families = new byte[][] { Bytes.toBytes("cf") };<a name="line.181"></a> +<span class="sourceLineNo">182</span> TableDescriptor htd = getTableDesc(<a name="line.182"></a> +<span class="sourceLineNo">183</span> TableName.valueOf(name.getMethodName().replaceAll("[^0-9A-Za-z_]", "_")), families);<a name="line.183"></a> +<span class="sourceLineNo">184</span> region = initHRegion(htd, HConstants.EMPTY_START_ROW, HConstants.EMPTY_END_ROW, 0);<a name="line.184"></a> +<span class="sourceLineNo">185</span> }<a name="line.185"></a> <span class="sourceLineNo">186</span><a name="line.186"></a> -<span class="sourceLineNo">187</span> }<a name="line.187"></a> -<span class="sourceLineNo">188</span> WAL.Entry e;<a name="line.188"></a> -<span class="sourceLineNo">189</span> try {<a name="line.189"></a> -<span class="sourceLineNo">190</span> long currentMaxSeqid = 0;<a name="line.190"></a> -<span class="sourceLineNo">191</span> while ((e = reader.next()) != null) {<a name="line.191"></a> -<span class="sourceLineNo">192</span> if (!WALEdit.isMetaEditFamily(e.getEdit().getCells().get(0))) {<a name="line.192"></a> -<span class="sourceLineNo">193</span> long currentSeqid = e.getKey().getSequenceId();<a name="line.193"></a> -<span class="sourceLineNo">194</span> if(currentSeqid > currentMaxSeqid) {<a name="line.194"></a> -<span class="sourceLineNo">195</span> currentMaxSeqid = currentSeqid;<a name="line.195"></a> -<span class="sourceLineNo">196</span> } else {<a name="line.196"></a> -<span class="sourceLineNo">197</span> Assert.fail("Current max Seqid is " + currentMaxSeqid<a name="line.197"></a> -<span class="sourceLineNo">198</span> + ", but the next seqid in wal is smaller:" + currentSeqid);<a name="line.198"></a> -<span class="sourceLineNo">199</span> }<a name="line.199"></a> -<span class="sourceLineNo">200</span> }<a name="line.200"></a> -<span class="sourceLineNo">201</span> }<a name="line.201"></a> -<span class="sourceLineNo">202</span> } finally {<a name="line.202"></a> -<span class="sourceLineNo">203</span> if(reader != null) {<a name="line.203"></a> -<span class="sourceLineNo">204</span> reader.close();<a name="line.204"></a> -<span class="sourceLineNo">205</span> }<a name="line.205"></a> -<span class="sourceLineNo">206</span> if(region != null) {<a name="line.206"></a> -<span class="sourceLineNo">207</span> region.close();<a name="line.207"></a> -<span class="sourceLineNo">208</span> }<a name="line.208"></a> -<span class="sourceLineNo">209</span> }<a name="line.209"></a> -<span class="sourceLineNo">210</span> }<a name="line.210"></a> -<span class="sourceLineNo">211</span><a name="line.211"></a> -<span class="sourceLineNo">212</span><a name="line.212"></a> -<span class="sourceLineNo">213</span>}<a name="line.213"></a> +<span class="sourceLineNo">187</span> @After<a name="line.187"></a> +<span class="sourceLineNo">188</span> public void tearDown() throws IOException {<a name="line.188"></a> +<span class="sourceLineNo">189</span> if (region != null) {<a name="line.189"></a> +<span class="sourceLineNo">190</span> region.close();<a name="line.190"></a> +<span class="sourceLineNo">191</span> }<a name="line.191"></a> +<span class="sourceLineNo">192</span> }<a name="line.192"></a> +<span class="sourceLineNo">193</span><a name="line.193"></a> +<span class="sourceLineNo">194</span> @AfterClass<a name="line.194"></a> +<span class="sourceLineNo">195</span> public static void tearDownAfterClass() throws IOException {<a name="line.195"></a> +<span class="sourceLineNo">196</span> TEST_UTIL.cleanupTestDir();<a name="line.196"></a> +<span class="sourceLineNo">197</span> }<a name="line.197"></a> +<span class="sourceLineNo">198</span><a name="line.198"></a> +<span class="sourceLineNo">199</span> private WAL.Reader createReader(Path logPath, Path oldWalsDir) throws IOException {<a name="line.199"></a> +<span class="sourceLineNo">200</span> try {<a name="line.200"></a> +<span class="sourceLineNo">201</span> return wals.createReader(fileSystem, logPath);<a name="line.201"></a> +<span class="sourceLineNo">202</span> } catch (IOException e) {<a name="line.202"></a> +<span class="sourceLineNo">203</span> return wals.createReader(fileSystem, new Path(oldWalsDir, logPath.getName()));<a name="line.203"></a> +<span class="sourceLineNo">204</span> }<a name="line.204"></a> +<span class="sourceLineNo">205</span> }<a name="line.205"></a> +<span class="sourceLineNo">206</span><a name="line.206"></a> +<span class="sourceLineNo">207</span> @Test<a name="line.207"></a> +<span class="sourceLineNo">208</span> public void testWALMonotonicallyIncreasingSeqId() throws Exception {<a name="line.208"></a> +<span class="sourceLineNo">209</span> List<Thread> putThreads = new ArrayList<>();<a name="line.209"></a> +<span class="sourceLineNo">210</span> for (int i = 0; i < 1; i++) {<a name="line.210"></a> +<span class="sourceLineNo">211</span> putThreads.add(new PutThread(region));<a name="line.211"></a> +<span class="sourceLineNo">212</span> }<a name="line.212"></a> +<span class="sourceLineNo">213</span> IncThread incThread = new IncThread(region);<a name="line.213"></a> +<span class="sourceLineNo">214</span> for (int i = 0; i < 1; i++) {<a name="line.214"></a> +<span class="sourceLineNo">215</span> putThreads.get(i).start();<a name="line.215"></a> +<span class="sourceLineNo">216</span> }<a name="line.216"></a> +<span class="sourceLineNo">217</span> incThread.start();<a name="line.217"></a> +<span class="sourceLineNo">218</span> incThread.join();<a name="line.218"></a> +<span class="sourceLineNo">219</span><a name="line.219"></a> +<span class="sourceLineNo">220</span> Path logPath = ((AbstractFSWAL<?>) region.getWAL()).getCurrentFileName();<a name="line.220"></a> +<span class="sourceLineNo">221</span> region.getWAL().rollWriter();<a name="line.221"></a> +<span class="sourceLineNo">222</span> Thread.sleep(10);<a name="line.222"></a> +<span class="sourceLineNo">223</span> Path hbaseDir = new Path(walConf.get(HConstants.HBASE_DIR));<a name="line.223"></a> +<span class="sourceLineNo">224</span> Path oldWalsDir = new Path(hbaseDir, HConstants.HREGION_OLDLOGDIR_NAME);<a name="line.224"></a> +<span class="sourceLineNo">225</span> try (WAL.Reader reader = createReader(logPath, oldWalsDir)) {<a name="line.225"></a> +<span class="sourceLineNo">226</span> long currentMaxSeqid = 0;<a name="line.226"></a> +<span class="sourceLineNo">227</span> for (WAL.Entry e; (e = reader.next()) != null;) {<a name="line.227"></a> +<span class="sourceLineNo">228</span> if (!WALEdit.isMetaEditFamily(e.getEdit().getCells().get(0))) {<a name="line.228"></a> +<span class="sourceLineNo">229</span> long currentSeqid = e.getKey().getSequenceId();<a name="line.229"></a> +<span class="sourceLineNo">230</span> if (currentSeqid > currentMaxSeqid) {<a name="line.230"></a> +<span class="sourceLineNo">231</span> currentMaxSeqid = currentSeqid;<a name="line.231"></a> +<span class="sourceLineNo">232</span> } else {<a name="line.232"></a> +<span class="sourceLineNo">233</span> fail("Current max Seqid is " + currentMaxSeqid +<a name="line.233"></a> +<span class="sourceLineNo">234</span> ", but the next seqid in wal is smaller:" + currentSeqid);<a name="line.234"></a> +<span class="sourceLineNo">235</span> }<a name="line.235"></a> +<span class="sourceLineNo">236</span> }<a name="line.236"></a> +<span class="sourceLineNo">237</span> }<a name="line.237"></a> +<span class="sourceLineNo">238</span> }<a name="line.238"></a> +<span class="sourceLineNo">239</span> }<a name="line.239"></a> +<span class="sourceLineNo">240</span>}<a name="line.240"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/1473a64a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/compactions/TestCompactedHFilesDischarger.ScanThread.html ---------------------------------------------------------------------- diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/compactions/TestCompactedHFilesDischarger.ScanThread.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/compactions/TestCompactedHFilesDischarger.ScanThread.html index 51d8a6a..fc531fc 100644 --- a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/compactions/TestCompactedHFilesDischarger.ScanThread.html +++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/compactions/TestCompactedHFilesDischarger.ScanThread.html @@ -391,8 +391,8 @@ <span class="sourceLineNo">383</span> latch.await();<a name="line.383"></a> <span class="sourceLineNo">384</span> } catch (InterruptedException e) {<a name="line.384"></a> <span class="sourceLineNo">385</span> }<a name="line.385"></a> -<span class="sourceLineNo">386</span> while (!next) {<a name="line.386"></a> -<span class="sourceLineNo">387</span> resScanner.next(results);<a name="line.387"></a> +<span class="sourceLineNo">386</span> while (next) {<a name="line.386"></a> +<span class="sourceLineNo">387</span> next = resScanner.next(results);<a name="line.387"></a> <span class="sourceLineNo">388</span> }<a name="line.388"></a> <span class="sourceLineNo">389</span> } finally {<a name="line.389"></a> <span class="sourceLineNo">390</span> scanCompletedCounter.incrementAndGet();<a name="line.390"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/1473a64a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/compactions/TestCompactedHFilesDischarger.html ---------------------------------------------------------------------- diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/compactions/TestCompactedHFilesDischarger.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/compactions/TestCompactedHFilesDischarger.html index 51d8a6a..fc531fc 100644 --- a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/compactions/TestCompactedHFilesDischarger.html +++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/compactions/TestCompactedHFilesDischarger.html @@ -391,8 +391,8 @@ <span class="sourceLineNo">383</span> latch.await();<a name="line.383"></a> <span class="sourceLineNo">384</span> } catch (InterruptedException e) {<a name="line.384"></a> <span class="sourceLineNo">385</span> }<a name="line.385"></a> -<span class="sourceLineNo">386</span> while (!next) {<a name="line.386"></a> -<span class="sourceLineNo">387</span> resScanner.next(results);<a name="line.387"></a> +<span class="sourceLineNo">386</span> while (next) {<a name="line.386"></a> +<span class="sourceLineNo">387</span> next = resScanner.next(results);<a name="line.387"></a> <span class="sourceLineNo">388</span> }<a name="line.388"></a> <span class="sourceLineNo">389</span> } finally {<a name="line.389"></a> <span class="sourceLineNo">390</span> scanCompletedCounter.incrementAndGet();<a name="line.390"></a>
