Repository: hbase Updated Branches: refs/heads/master c269e63a0 -> c1a8dc09d
HBASE-19810 Fix findbugs and error-prone warnings in hbase-metrics (branch-2) Signed-off-by: Michael Stack <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/c1a8dc09 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/c1a8dc09 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/c1a8dc09 Branch: refs/heads/master Commit: c1a8dc09d64ef3f6062aced595c3bb918724025d Parents: c269e63 Author: Peter Somogyi <[email protected]> Authored: Wed Jan 17 10:05:03 2018 +0100 Committer: Michael Stack <[email protected]> Committed: Wed Jan 17 11:25:48 2018 -0800 ---------------------------------------------------------------------- .../org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java | 2 ++ .../apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java | 5 +++++ 2 files changed, 7 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/c1a8dc09/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java ---------------------------------------------------------------------- diff --git a/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java b/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java index 6871f7e..7b79fba 100644 --- a/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java +++ b/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java @@ -65,6 +65,7 @@ public class HistogramImpl implements Histogram { histogram.add(value, 1); } + @Override public long getCount() { return counter.getCount(); } @@ -73,6 +74,7 @@ public class HistogramImpl implements Histogram { return this.histogram.getMax(); } + @Override public Snapshot snapshot() { return histogram.snapshotAndReset(); } http://git-wip-us.apache.org/repos/asf/hbase/blob/c1a8dc09/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java ---------------------------------------------------------------------- diff --git a/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java b/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java index d72c68f..3826e66 100644 --- a/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java +++ b/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java @@ -51,22 +51,27 @@ public class MetricRegistriesImpl extends MetricRegistries { return registries.put(info, () -> factory.create(info)); } + @Override public boolean remove(MetricRegistryInfo key) { return registries.remove(key) == null; } + @Override public Optional<MetricRegistry> get(MetricRegistryInfo info) { return Optional.ofNullable(registries.get(info)); } + @Override public Collection<MetricRegistry> getMetricRegistries() { return Collections.unmodifiableCollection(registries.values()); } + @Override public void clear() { registries.clear(); } + @Override public Set<MetricRegistryInfo> getMetricRegistryInfos() { return Collections.unmodifiableSet(registries.keySet()); }
