http://git-wip-us.apache.org/repos/asf/hbase-site/blob/b248f175/devapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/LogCleaner.CleanerContext.html
----------------------------------------------------------------------
diff --git 
a/devapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/LogCleaner.CleanerContext.html
 
b/devapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/LogCleaner.CleanerContext.html
index 541533a..a23f742 100644
--- 
a/devapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/LogCleaner.CleanerContext.html
+++ 
b/devapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/LogCleaner.CleanerContext.html
@@ -32,213 +32,248 @@
 <span class="sourceLineNo">024</span>import java.util.LinkedList;<a 
name="line.24"></a>
 <span class="sourceLineNo">025</span>import java.util.List;<a 
name="line.25"></a>
 <span class="sourceLineNo">026</span>import 
java.util.concurrent.LinkedBlockingQueue;<a name="line.26"></a>
-<span class="sourceLineNo">027</span><a name="line.27"></a>
-<span class="sourceLineNo">028</span>import 
org.apache.hadoop.conf.Configuration;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import org.apache.hadoop.fs.FileStatus;<a 
name="line.29"></a>
-<span class="sourceLineNo">030</span>import org.apache.hadoop.fs.FileSystem;<a 
name="line.30"></a>
-<span class="sourceLineNo">031</span>import org.apache.hadoop.fs.Path;<a 
name="line.31"></a>
-<span class="sourceLineNo">032</span>import 
org.apache.hadoop.hbase.Stoppable;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import 
org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil;<a 
name="line.33"></a>
-<span class="sourceLineNo">034</span>import 
org.apache.hadoop.hbase.wal.AbstractFSWALProvider;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import 
org.apache.yetus.audience.InterfaceAudience;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.slf4j.Logger;<a 
name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.slf4j.LoggerFactory;<a 
name="line.37"></a>
-<span class="sourceLineNo">038</span>import 
org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;<a 
name="line.38"></a>
-<span class="sourceLineNo">039</span><a name="line.39"></a>
-<span class="sourceLineNo">040</span>/**<a name="line.40"></a>
-<span class="sourceLineNo">041</span> * This Chore, every time it runs, will 
attempt to delete the WALs and Procedure WALs in the old<a name="line.41"></a>
-<span class="sourceLineNo">042</span> * logs folder. The WAL is only deleted 
if none of the cleaner delegates says otherwise.<a name="line.42"></a>
-<span class="sourceLineNo">043</span> * @see BaseLogCleanerDelegate<a 
name="line.43"></a>
-<span class="sourceLineNo">044</span> */<a name="line.44"></a>
-<span class="sourceLineNo">045</span>@InterfaceAudience.Private<a 
name="line.45"></a>
-<span class="sourceLineNo">046</span>public class LogCleaner extends 
CleanerChore&lt;BaseLogCleanerDelegate&gt; {<a name="line.46"></a>
-<span class="sourceLineNo">047</span>  private static final Logger LOG = 
LoggerFactory.getLogger(LogCleaner.class.getName());<a name="line.47"></a>
-<span class="sourceLineNo">048</span><a name="line.48"></a>
-<span class="sourceLineNo">049</span>  public static final String 
OLD_WALS_CLEANER_SIZE = "hbase.oldwals.cleaner.thread.size";<a 
name="line.49"></a>
-<span class="sourceLineNo">050</span>  public static final int 
OLD_WALS_CLEANER_DEFAULT_SIZE = 2;<a name="line.50"></a>
-<span class="sourceLineNo">051</span><a name="line.51"></a>
-<span class="sourceLineNo">052</span>  private final 
LinkedBlockingQueue&lt;CleanerContext&gt; pendingDelete;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>  private List&lt;Thread&gt; 
oldWALsCleaner;<a name="line.53"></a>
-<span class="sourceLineNo">054</span><a name="line.54"></a>
-<span class="sourceLineNo">055</span>  /**<a name="line.55"></a>
-<span class="sourceLineNo">056</span>   * @param period the period of time to 
sleep between each run<a name="line.56"></a>
-<span class="sourceLineNo">057</span>   * @param stopper the stopper<a 
name="line.57"></a>
-<span class="sourceLineNo">058</span>   * @param conf configuration to use<a 
name="line.58"></a>
-<span class="sourceLineNo">059</span>   * @param fs handle to the FS<a 
name="line.59"></a>
-<span class="sourceLineNo">060</span>   * @param oldLogDir the path to the 
archived logs<a name="line.60"></a>
-<span class="sourceLineNo">061</span>   */<a name="line.61"></a>
-<span class="sourceLineNo">062</span>  public LogCleaner(final int period, 
final Stoppable stopper, Configuration conf, FileSystem fs,<a 
name="line.62"></a>
-<span class="sourceLineNo">063</span>      Path oldLogDir) {<a 
name="line.63"></a>
-<span class="sourceLineNo">064</span>    super("LogsCleaner", period, stopper, 
conf, fs, oldLogDir, HBASE_MASTER_LOGCLEANER_PLUGINS);<a name="line.64"></a>
-<span class="sourceLineNo">065</span>    this.pendingDelete = new 
LinkedBlockingQueue&lt;&gt;();<a name="line.65"></a>
-<span class="sourceLineNo">066</span>    int size = 
conf.getInt(OLD_WALS_CLEANER_SIZE, OLD_WALS_CLEANER_DEFAULT_SIZE);<a 
name="line.66"></a>
-<span class="sourceLineNo">067</span>    this.oldWALsCleaner = 
createOldWalsCleaner(size);<a name="line.67"></a>
-<span class="sourceLineNo">068</span>  }<a name="line.68"></a>
-<span class="sourceLineNo">069</span><a name="line.69"></a>
-<span class="sourceLineNo">070</span>  @Override<a name="line.70"></a>
-<span class="sourceLineNo">071</span>  protected boolean validate(Path file) 
{<a name="line.71"></a>
-<span class="sourceLineNo">072</span>    return 
AbstractFSWALProvider.validateWALFilename(file.getName())<a name="line.72"></a>
-<span class="sourceLineNo">073</span>        || 
MasterProcedureUtil.validateProcedureWALFilename(file.getName());<a 
name="line.73"></a>
-<span class="sourceLineNo">074</span>  }<a name="line.74"></a>
-<span class="sourceLineNo">075</span><a name="line.75"></a>
-<span class="sourceLineNo">076</span>  @Override<a name="line.76"></a>
-<span class="sourceLineNo">077</span>  public void 
onConfigurationChange(Configuration conf) {<a name="line.77"></a>
-<span class="sourceLineNo">078</span>    super.onConfigurationChange(conf);<a 
name="line.78"></a>
-<span class="sourceLineNo">079</span><a name="line.79"></a>
-<span class="sourceLineNo">080</span>    int newSize = 
conf.getInt(OLD_WALS_CLEANER_SIZE, OLD_WALS_CLEANER_DEFAULT_SIZE);<a 
name="line.80"></a>
-<span class="sourceLineNo">081</span>    if (newSize == oldWALsCleaner.size()) 
{<a name="line.81"></a>
-<span class="sourceLineNo">082</span>      if (LOG.isDebugEnabled()) {<a 
name="line.82"></a>
-<span class="sourceLineNo">083</span>        LOG.debug("Size from 
configuration is the same as previous which is " +<a name="line.83"></a>
-<span class="sourceLineNo">084</span>          newSize + ", no need to 
update.");<a name="line.84"></a>
-<span class="sourceLineNo">085</span>      }<a name="line.85"></a>
-<span class="sourceLineNo">086</span>      return;<a name="line.86"></a>
-<span class="sourceLineNo">087</span>    }<a name="line.87"></a>
-<span class="sourceLineNo">088</span>    interruptOldWALsCleaner();<a 
name="line.88"></a>
-<span class="sourceLineNo">089</span>    oldWALsCleaner = 
createOldWalsCleaner(newSize);<a name="line.89"></a>
-<span class="sourceLineNo">090</span>  }<a name="line.90"></a>
-<span class="sourceLineNo">091</span><a name="line.91"></a>
-<span class="sourceLineNo">092</span>  @Override<a name="line.92"></a>
-<span class="sourceLineNo">093</span>  protected int 
deleteFiles(Iterable&lt;FileStatus&gt; filesToDelete) {<a name="line.93"></a>
-<span class="sourceLineNo">094</span>    List&lt;CleanerContext&gt; results = 
new LinkedList&lt;&gt;();<a name="line.94"></a>
-<span class="sourceLineNo">095</span>    for (FileStatus toDelete : 
filesToDelete) {<a name="line.95"></a>
-<span class="sourceLineNo">096</span>      CleanerContext context = 
CleanerContext.createCleanerContext(toDelete);<a name="line.96"></a>
-<span class="sourceLineNo">097</span>      if (context != null) {<a 
name="line.97"></a>
-<span class="sourceLineNo">098</span>        pendingDelete.add(context);<a 
name="line.98"></a>
-<span class="sourceLineNo">099</span>        results.add(context);<a 
name="line.99"></a>
-<span class="sourceLineNo">100</span>      }<a name="line.100"></a>
-<span class="sourceLineNo">101</span>    }<a name="line.101"></a>
-<span class="sourceLineNo">102</span><a name="line.102"></a>
-<span class="sourceLineNo">103</span>    int deletedFiles = 0;<a 
name="line.103"></a>
-<span class="sourceLineNo">104</span>    for (CleanerContext res : results) 
{<a name="line.104"></a>
-<span class="sourceLineNo">105</span>      deletedFiles += res.getResult(500) 
? 1 : 0;<a name="line.105"></a>
-<span class="sourceLineNo">106</span>    }<a name="line.106"></a>
-<span class="sourceLineNo">107</span>    return deletedFiles;<a 
name="line.107"></a>
-<span class="sourceLineNo">108</span>  }<a name="line.108"></a>
-<span class="sourceLineNo">109</span><a name="line.109"></a>
-<span class="sourceLineNo">110</span>  @Override<a name="line.110"></a>
-<span class="sourceLineNo">111</span>  public synchronized void cleanup() {<a 
name="line.111"></a>
-<span class="sourceLineNo">112</span>    super.cleanup();<a 
name="line.112"></a>
-<span class="sourceLineNo">113</span>    interruptOldWALsCleaner();<a 
name="line.113"></a>
-<span class="sourceLineNo">114</span>  }<a name="line.114"></a>
-<span class="sourceLineNo">115</span><a name="line.115"></a>
-<span class="sourceLineNo">116</span>  @VisibleForTesting<a 
name="line.116"></a>
-<span class="sourceLineNo">117</span>  int getSizeOfCleaners() {<a 
name="line.117"></a>
-<span class="sourceLineNo">118</span>    return oldWALsCleaner.size();<a 
name="line.118"></a>
-<span class="sourceLineNo">119</span>  }<a name="line.119"></a>
-<span class="sourceLineNo">120</span><a name="line.120"></a>
-<span class="sourceLineNo">121</span>  private List&lt;Thread&gt; 
createOldWalsCleaner(int size) {<a name="line.121"></a>
-<span class="sourceLineNo">122</span>    LOG.info("Creating OldWALs cleaners 
with size=" + size);<a name="line.122"></a>
-<span class="sourceLineNo">123</span><a name="line.123"></a>
-<span class="sourceLineNo">124</span>    List&lt;Thread&gt; oldWALsCleaner = 
new ArrayList&lt;&gt;(size);<a name="line.124"></a>
-<span class="sourceLineNo">125</span>    for (int i = 0; i &lt; size; i++) {<a 
name="line.125"></a>
-<span class="sourceLineNo">126</span>      Thread cleaner = new Thread(() 
-&gt; deleteFile());<a name="line.126"></a>
-<span class="sourceLineNo">127</span>      cleaner.setName("OldWALsCleaner-" + 
i);<a name="line.127"></a>
-<span class="sourceLineNo">128</span>      cleaner.setDaemon(true);<a 
name="line.128"></a>
-<span class="sourceLineNo">129</span>      cleaner.start();<a 
name="line.129"></a>
-<span class="sourceLineNo">130</span>      oldWALsCleaner.add(cleaner);<a 
name="line.130"></a>
-<span class="sourceLineNo">131</span>    }<a name="line.131"></a>
-<span class="sourceLineNo">132</span>    return oldWALsCleaner;<a 
name="line.132"></a>
-<span class="sourceLineNo">133</span>  }<a name="line.133"></a>
-<span class="sourceLineNo">134</span><a name="line.134"></a>
-<span class="sourceLineNo">135</span>  private void interruptOldWALsCleaner() 
{<a name="line.135"></a>
-<span class="sourceLineNo">136</span>    for (Thread cleaner : oldWALsCleaner) 
{<a name="line.136"></a>
-<span class="sourceLineNo">137</span>      cleaner.interrupt();<a 
name="line.137"></a>
-<span class="sourceLineNo">138</span>    }<a name="line.138"></a>
-<span class="sourceLineNo">139</span>    oldWALsCleaner.clear();<a 
name="line.139"></a>
-<span class="sourceLineNo">140</span>  }<a name="line.140"></a>
-<span class="sourceLineNo">141</span><a name="line.141"></a>
-<span class="sourceLineNo">142</span>  private void deleteFile() {<a 
name="line.142"></a>
-<span class="sourceLineNo">143</span>    while (true) {<a name="line.143"></a>
-<span class="sourceLineNo">144</span>      CleanerContext context = null;<a 
name="line.144"></a>
-<span class="sourceLineNo">145</span>      boolean succeed = false;<a 
name="line.145"></a>
-<span class="sourceLineNo">146</span>      boolean interrupted = false;<a 
name="line.146"></a>
-<span class="sourceLineNo">147</span>      try {<a name="line.147"></a>
-<span class="sourceLineNo">148</span>        context = pendingDelete.take();<a 
name="line.148"></a>
-<span class="sourceLineNo">149</span>        if (context != null) {<a 
name="line.149"></a>
-<span class="sourceLineNo">150</span>          FileStatus toClean = 
context.getTargetToClean();<a name="line.150"></a>
-<span class="sourceLineNo">151</span>          succeed = 
this.fs.delete(toClean.getPath(), false);<a name="line.151"></a>
-<span class="sourceLineNo">152</span>        }<a name="line.152"></a>
-<span class="sourceLineNo">153</span>      } catch (InterruptedException ite) 
{<a name="line.153"></a>
-<span class="sourceLineNo">154</span>        // It's most likely from 
configuration changing request<a name="line.154"></a>
-<span class="sourceLineNo">155</span>        if (context != null) {<a 
name="line.155"></a>
-<span class="sourceLineNo">156</span>          LOG.warn("Interrupted while 
cleaning oldWALs " +<a name="line.156"></a>
-<span class="sourceLineNo">157</span>              context.getTargetToClean() 
+ ", try to clean it next round.");<a name="line.157"></a>
-<span class="sourceLineNo">158</span>        }<a name="line.158"></a>
-<span class="sourceLineNo">159</span>        interrupted = true;<a 
name="line.159"></a>
-<span class="sourceLineNo">160</span>      } catch (IOException e) {<a 
name="line.160"></a>
-<span class="sourceLineNo">161</span>        // fs.delete() fails.<a 
name="line.161"></a>
-<span class="sourceLineNo">162</span>        LOG.warn("Failed to clean oldwals 
with exception: " + e);<a name="line.162"></a>
-<span class="sourceLineNo">163</span>        succeed = false;<a 
name="line.163"></a>
-<span class="sourceLineNo">164</span>      } finally {<a name="line.164"></a>
-<span class="sourceLineNo">165</span>        if (context != null) {<a 
name="line.165"></a>
-<span class="sourceLineNo">166</span>          context.setResult(succeed);<a 
name="line.166"></a>
-<span class="sourceLineNo">167</span>        }<a name="line.167"></a>
-<span class="sourceLineNo">168</span>        if (interrupted) {<a 
name="line.168"></a>
-<span class="sourceLineNo">169</span>          // Restore interrupt status<a 
name="line.169"></a>
-<span class="sourceLineNo">170</span>          
Thread.currentThread().interrupt();<a name="line.170"></a>
-<span class="sourceLineNo">171</span>          break;<a name="line.171"></a>
-<span class="sourceLineNo">172</span>        }<a name="line.172"></a>
-<span class="sourceLineNo">173</span>      }<a name="line.173"></a>
-<span class="sourceLineNo">174</span>    }<a name="line.174"></a>
-<span class="sourceLineNo">175</span>    if (LOG.isDebugEnabled()) {<a 
name="line.175"></a>
-<span class="sourceLineNo">176</span>      LOG.debug("Exiting cleaner.");<a 
name="line.176"></a>
-<span class="sourceLineNo">177</span>    }<a name="line.177"></a>
-<span class="sourceLineNo">178</span>  }<a name="line.178"></a>
-<span class="sourceLineNo">179</span><a name="line.179"></a>
-<span class="sourceLineNo">180</span>  @Override<a name="line.180"></a>
-<span class="sourceLineNo">181</span>  public synchronized void cancel(boolean 
mayInterruptIfRunning) {<a name="line.181"></a>
-<span class="sourceLineNo">182</span>    
super.cancel(mayInterruptIfRunning);<a name="line.182"></a>
-<span class="sourceLineNo">183</span>    for (Thread t : oldWALsCleaner) {<a 
name="line.183"></a>
-<span class="sourceLineNo">184</span>      t.interrupt();<a 
name="line.184"></a>
-<span class="sourceLineNo">185</span>    }<a name="line.185"></a>
-<span class="sourceLineNo">186</span>  }<a name="line.186"></a>
-<span class="sourceLineNo">187</span><a name="line.187"></a>
-<span class="sourceLineNo">188</span>  private static final class 
CleanerContext {<a name="line.188"></a>
-<span class="sourceLineNo">189</span>    // At most waits 60 seconds<a 
name="line.189"></a>
-<span class="sourceLineNo">190</span>    static final long MAX_WAIT = 60 * 
1000;<a name="line.190"></a>
-<span class="sourceLineNo">191</span><a name="line.191"></a>
-<span class="sourceLineNo">192</span>    final FileStatus target;<a 
name="line.192"></a>
-<span class="sourceLineNo">193</span>    volatile boolean result;<a 
name="line.193"></a>
-<span class="sourceLineNo">194</span>    volatile boolean setFromCleaner = 
false;<a name="line.194"></a>
-<span class="sourceLineNo">195</span><a name="line.195"></a>
-<span class="sourceLineNo">196</span>    static CleanerContext 
createCleanerContext(FileStatus status) {<a name="line.196"></a>
-<span class="sourceLineNo">197</span>      return status != null ? new 
CleanerContext(status) : null;<a name="line.197"></a>
-<span class="sourceLineNo">198</span>    }<a name="line.198"></a>
-<span class="sourceLineNo">199</span><a name="line.199"></a>
-<span class="sourceLineNo">200</span>    private CleanerContext(FileStatus 
status) {<a name="line.200"></a>
-<span class="sourceLineNo">201</span>      this.target = status;<a 
name="line.201"></a>
-<span class="sourceLineNo">202</span>      this.result = false;<a 
name="line.202"></a>
-<span class="sourceLineNo">203</span>    }<a name="line.203"></a>
-<span class="sourceLineNo">204</span><a name="line.204"></a>
-<span class="sourceLineNo">205</span>    synchronized void setResult(boolean 
res) {<a name="line.205"></a>
-<span class="sourceLineNo">206</span>      this.result = res;<a 
name="line.206"></a>
-<span class="sourceLineNo">207</span>      this.setFromCleaner = true;<a 
name="line.207"></a>
-<span class="sourceLineNo">208</span>      notify();<a name="line.208"></a>
-<span class="sourceLineNo">209</span>    }<a name="line.209"></a>
-<span class="sourceLineNo">210</span><a name="line.210"></a>
-<span class="sourceLineNo">211</span>    synchronized boolean getResult(long 
waitIfNotFinished) {<a name="line.211"></a>
-<span class="sourceLineNo">212</span>      long totalTime = 0;<a 
name="line.212"></a>
-<span class="sourceLineNo">213</span>      try {<a name="line.213"></a>
-<span class="sourceLineNo">214</span>        while (!setFromCleaner) {<a 
name="line.214"></a>
-<span class="sourceLineNo">215</span>          wait(waitIfNotFinished);<a 
name="line.215"></a>
-<span class="sourceLineNo">216</span>          totalTime += 
waitIfNotFinished;<a name="line.216"></a>
-<span class="sourceLineNo">217</span>          if (totalTime &gt;= MAX_WAIT) 
{<a name="line.217"></a>
-<span class="sourceLineNo">218</span>            LOG.warn("Spend too much time 
to delete oldwals " + target);<a name="line.218"></a>
-<span class="sourceLineNo">219</span>            return result;<a 
name="line.219"></a>
-<span class="sourceLineNo">220</span>          }<a name="line.220"></a>
-<span class="sourceLineNo">221</span>        }<a name="line.221"></a>
-<span class="sourceLineNo">222</span>      } catch (InterruptedException e) 
{<a name="line.222"></a>
-<span class="sourceLineNo">223</span>        LOG.warn("Interrupted while 
waiting deletion of " + target);<a name="line.223"></a>
-<span class="sourceLineNo">224</span>        return result;<a 
name="line.224"></a>
-<span class="sourceLineNo">225</span>      }<a name="line.225"></a>
-<span class="sourceLineNo">226</span>      return result;<a 
name="line.226"></a>
-<span class="sourceLineNo">227</span>    }<a name="line.227"></a>
-<span class="sourceLineNo">228</span><a name="line.228"></a>
-<span class="sourceLineNo">229</span>    FileStatus getTargetToClean() {<a 
name="line.229"></a>
-<span class="sourceLineNo">230</span>      return target;<a 
name="line.230"></a>
-<span class="sourceLineNo">231</span>    }<a name="line.231"></a>
-<span class="sourceLineNo">232</span>  }<a name="line.232"></a>
-<span class="sourceLineNo">233</span>}<a name="line.233"></a>
+<span class="sourceLineNo">027</span>import java.util.concurrent.TimeUnit;<a 
name="line.27"></a>
+<span class="sourceLineNo">028</span><a name="line.28"></a>
+<span class="sourceLineNo">029</span>import 
org.apache.hadoop.conf.Configuration;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.fs.FileStatus;<a 
name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.fs.FileSystem;<a 
name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.fs.Path;<a 
name="line.32"></a>
+<span class="sourceLineNo">033</span>import 
org.apache.hadoop.hbase.Stoppable;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import 
org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil;<a 
name="line.34"></a>
+<span class="sourceLineNo">035</span>import 
org.apache.hadoop.hbase.wal.AbstractFSWALProvider;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import 
org.apache.yetus.audience.InterfaceAudience;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.slf4j.Logger;<a 
name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.slf4j.LoggerFactory;<a 
name="line.38"></a>
+<span class="sourceLineNo">039</span>import 
org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;<a 
name="line.39"></a>
+<span class="sourceLineNo">040</span><a name="line.40"></a>
+<span class="sourceLineNo">041</span>/**<a name="line.41"></a>
+<span class="sourceLineNo">042</span> * This Chore, every time it runs, will 
attempt to delete the WALs and Procedure WALs in the old<a name="line.42"></a>
+<span class="sourceLineNo">043</span> * logs folder. The WAL is only deleted 
if none of the cleaner delegates says otherwise.<a name="line.43"></a>
+<span class="sourceLineNo">044</span> * @see BaseLogCleanerDelegate<a 
name="line.44"></a>
+<span class="sourceLineNo">045</span> */<a name="line.45"></a>
+<span class="sourceLineNo">046</span>@InterfaceAudience.Private<a 
name="line.46"></a>
+<span class="sourceLineNo">047</span>public class LogCleaner extends 
CleanerChore&lt;BaseLogCleanerDelegate&gt; {<a name="line.47"></a>
+<span class="sourceLineNo">048</span>  private static final Logger LOG = 
LoggerFactory.getLogger(LogCleaner.class.getName());<a name="line.48"></a>
+<span class="sourceLineNo">049</span><a name="line.49"></a>
+<span class="sourceLineNo">050</span>  public static final String 
OLD_WALS_CLEANER_THREAD_SIZE = "hbase.oldwals.cleaner.thread.size";<a 
name="line.50"></a>
+<span class="sourceLineNo">051</span>  public static final int 
DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE = 2;<a name="line.51"></a>
+<span class="sourceLineNo">052</span><a name="line.52"></a>
+<span class="sourceLineNo">053</span>  public static final String 
OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC =<a name="line.53"></a>
+<span class="sourceLineNo">054</span>      
"hbase.oldwals.cleaner.thread.timeout.msec";<a name="line.54"></a>
+<span class="sourceLineNo">055</span>  @VisibleForTesting<a name="line.55"></a>
+<span class="sourceLineNo">056</span>  static final long 
DEFAULT_OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC = 60 * 1000L;<a name="line.56"></a>
+<span class="sourceLineNo">057</span><a name="line.57"></a>
+<span class="sourceLineNo">058</span>  public static final String 
OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC =<a name="line.58"></a>
+<span class="sourceLineNo">059</span>      
"hbase.oldwals.cleaner.thread.check.interval.msec";<a name="line.59"></a>
+<span class="sourceLineNo">060</span>  @VisibleForTesting<a name="line.60"></a>
+<span class="sourceLineNo">061</span>  static final long 
DEFAULT_OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC = 500L;<a 
name="line.61"></a>
+<span class="sourceLineNo">062</span><a name="line.62"></a>
+<span class="sourceLineNo">063</span><a name="line.63"></a>
+<span class="sourceLineNo">064</span>  private final 
LinkedBlockingQueue&lt;CleanerContext&gt; pendingDelete;<a name="line.64"></a>
+<span class="sourceLineNo">065</span>  private List&lt;Thread&gt; 
oldWALsCleaner;<a name="line.65"></a>
+<span class="sourceLineNo">066</span>  private long 
cleanerThreadTimeoutMsec;<a name="line.66"></a>
+<span class="sourceLineNo">067</span>  private long 
cleanerThreadCheckIntervalMsec;<a name="line.67"></a>
+<span class="sourceLineNo">068</span><a name="line.68"></a>
+<span class="sourceLineNo">069</span>  /**<a name="line.69"></a>
+<span class="sourceLineNo">070</span>   * @param period the period of time to 
sleep between each run<a name="line.70"></a>
+<span class="sourceLineNo">071</span>   * @param stopper the stopper<a 
name="line.71"></a>
+<span class="sourceLineNo">072</span>   * @param conf configuration to use<a 
name="line.72"></a>
+<span class="sourceLineNo">073</span>   * @param fs handle to the FS<a 
name="line.73"></a>
+<span class="sourceLineNo">074</span>   * @param oldLogDir the path to the 
archived logs<a name="line.74"></a>
+<span class="sourceLineNo">075</span>   */<a name="line.75"></a>
+<span class="sourceLineNo">076</span>  public LogCleaner(final int period, 
final Stoppable stopper, Configuration conf, FileSystem fs,<a 
name="line.76"></a>
+<span class="sourceLineNo">077</span>      Path oldLogDir) {<a 
name="line.77"></a>
+<span class="sourceLineNo">078</span>    super("LogsCleaner", period, stopper, 
conf, fs, oldLogDir, HBASE_MASTER_LOGCLEANER_PLUGINS);<a name="line.78"></a>
+<span class="sourceLineNo">079</span>    this.pendingDelete = new 
LinkedBlockingQueue&lt;&gt;();<a name="line.79"></a>
+<span class="sourceLineNo">080</span>    int size = 
conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE, 
DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);<a name="line.80"></a>
+<span class="sourceLineNo">081</span>    this.oldWALsCleaner = 
createOldWalsCleaner(size);<a name="line.81"></a>
+<span class="sourceLineNo">082</span>    this.cleanerThreadTimeoutMsec = 
conf.getLong(OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC,<a name="line.82"></a>
+<span class="sourceLineNo">083</span>        
DEFAULT_OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC);<a name="line.83"></a>
+<span class="sourceLineNo">084</span>    this.cleanerThreadCheckIntervalMsec = 
conf.getLong(OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC,<a name="line.84"></a>
+<span class="sourceLineNo">085</span>        
DEFAULT_OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC);<a name="line.85"></a>
+<span class="sourceLineNo">086</span>  }<a name="line.86"></a>
+<span class="sourceLineNo">087</span><a name="line.87"></a>
+<span class="sourceLineNo">088</span>  @Override<a name="line.88"></a>
+<span class="sourceLineNo">089</span>  protected boolean validate(Path file) 
{<a name="line.89"></a>
+<span class="sourceLineNo">090</span>    return 
AbstractFSWALProvider.validateWALFilename(file.getName())<a name="line.90"></a>
+<span class="sourceLineNo">091</span>        || 
MasterProcedureUtil.validateProcedureWALFilename(file.getName());<a 
name="line.91"></a>
+<span class="sourceLineNo">092</span>  }<a name="line.92"></a>
+<span class="sourceLineNo">093</span><a name="line.93"></a>
+<span class="sourceLineNo">094</span>  @Override<a name="line.94"></a>
+<span class="sourceLineNo">095</span>  public void 
onConfigurationChange(Configuration conf) {<a name="line.95"></a>
+<span class="sourceLineNo">096</span>    super.onConfigurationChange(conf);<a 
name="line.96"></a>
+<span class="sourceLineNo">097</span><a name="line.97"></a>
+<span class="sourceLineNo">098</span>    int newSize = 
conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE, 
DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);<a name="line.98"></a>
+<span class="sourceLineNo">099</span>    if (newSize == oldWALsCleaner.size()) 
{<a name="line.99"></a>
+<span class="sourceLineNo">100</span>      if (LOG.isDebugEnabled()) {<a 
name="line.100"></a>
+<span class="sourceLineNo">101</span>        LOG.debug("Size from 
configuration is the same as previous which is " +<a name="line.101"></a>
+<span class="sourceLineNo">102</span>          newSize + ", no need to 
update.");<a name="line.102"></a>
+<span class="sourceLineNo">103</span>      }<a name="line.103"></a>
+<span class="sourceLineNo">104</span>      return;<a name="line.104"></a>
+<span class="sourceLineNo">105</span>    }<a name="line.105"></a>
+<span class="sourceLineNo">106</span>    interruptOldWALsCleaner();<a 
name="line.106"></a>
+<span class="sourceLineNo">107</span>    oldWALsCleaner = 
createOldWalsCleaner(newSize);<a name="line.107"></a>
+<span class="sourceLineNo">108</span>    cleanerThreadTimeoutMsec = 
conf.getLong(OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC,<a name="line.108"></a>
+<span class="sourceLineNo">109</span>        
DEFAULT_OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC);<a name="line.109"></a>
+<span class="sourceLineNo">110</span>    cleanerThreadCheckIntervalMsec = 
conf.getLong(OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC,<a name="line.110"></a>
+<span class="sourceLineNo">111</span>        
DEFAULT_OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC);<a name="line.111"></a>
+<span class="sourceLineNo">112</span>  }<a name="line.112"></a>
+<span class="sourceLineNo">113</span><a name="line.113"></a>
+<span class="sourceLineNo">114</span>  @Override<a name="line.114"></a>
+<span class="sourceLineNo">115</span>  protected int 
deleteFiles(Iterable&lt;FileStatus&gt; filesToDelete) {<a name="line.115"></a>
+<span class="sourceLineNo">116</span>    List&lt;CleanerContext&gt; results = 
new LinkedList&lt;&gt;();<a name="line.116"></a>
+<span class="sourceLineNo">117</span>    for (FileStatus toDelete : 
filesToDelete) {<a name="line.117"></a>
+<span class="sourceLineNo">118</span>      CleanerContext context = 
CleanerContext.createCleanerContext(toDelete,<a name="line.118"></a>
+<span class="sourceLineNo">119</span>          cleanerThreadTimeoutMsec);<a 
name="line.119"></a>
+<span class="sourceLineNo">120</span>      if (context != null) {<a 
name="line.120"></a>
+<span class="sourceLineNo">121</span>        pendingDelete.add(context);<a 
name="line.121"></a>
+<span class="sourceLineNo">122</span>        results.add(context);<a 
name="line.122"></a>
+<span class="sourceLineNo">123</span>      }<a name="line.123"></a>
+<span class="sourceLineNo">124</span>    }<a name="line.124"></a>
+<span class="sourceLineNo">125</span><a name="line.125"></a>
+<span class="sourceLineNo">126</span>    int deletedFiles = 0;<a 
name="line.126"></a>
+<span class="sourceLineNo">127</span>    for (CleanerContext res : results) 
{<a name="line.127"></a>
+<span class="sourceLineNo">128</span>      deletedFiles += 
res.getResult(cleanerThreadCheckIntervalMsec) ? 1 : 0;<a name="line.128"></a>
+<span class="sourceLineNo">129</span>    }<a name="line.129"></a>
+<span class="sourceLineNo">130</span>    return deletedFiles;<a 
name="line.130"></a>
+<span class="sourceLineNo">131</span>  }<a name="line.131"></a>
+<span class="sourceLineNo">132</span><a name="line.132"></a>
+<span class="sourceLineNo">133</span>  @Override<a name="line.133"></a>
+<span class="sourceLineNo">134</span>  public synchronized void cleanup() {<a 
name="line.134"></a>
+<span class="sourceLineNo">135</span>    super.cleanup();<a 
name="line.135"></a>
+<span class="sourceLineNo">136</span>    interruptOldWALsCleaner();<a 
name="line.136"></a>
+<span class="sourceLineNo">137</span>  }<a name="line.137"></a>
+<span class="sourceLineNo">138</span><a name="line.138"></a>
+<span class="sourceLineNo">139</span>  @VisibleForTesting<a 
name="line.139"></a>
+<span class="sourceLineNo">140</span>  int getSizeOfCleaners() {<a 
name="line.140"></a>
+<span class="sourceLineNo">141</span>    return oldWALsCleaner.size();<a 
name="line.141"></a>
+<span class="sourceLineNo">142</span>  }<a name="line.142"></a>
+<span class="sourceLineNo">143</span><a name="line.143"></a>
+<span class="sourceLineNo">144</span>  @VisibleForTesting<a 
name="line.144"></a>
+<span class="sourceLineNo">145</span>  long getCleanerThreadTimeoutMsec() {<a 
name="line.145"></a>
+<span class="sourceLineNo">146</span>    return cleanerThreadTimeoutMsec;<a 
name="line.146"></a>
+<span class="sourceLineNo">147</span>  }<a name="line.147"></a>
+<span class="sourceLineNo">148</span><a name="line.148"></a>
+<span class="sourceLineNo">149</span>  @VisibleForTesting<a 
name="line.149"></a>
+<span class="sourceLineNo">150</span>  long 
getCleanerThreadCheckIntervalMsec() {<a name="line.150"></a>
+<span class="sourceLineNo">151</span>    return 
cleanerThreadCheckIntervalMsec;<a name="line.151"></a>
+<span class="sourceLineNo">152</span>  }<a name="line.152"></a>
+<span class="sourceLineNo">153</span><a name="line.153"></a>
+<span class="sourceLineNo">154</span>  private List&lt;Thread&gt; 
createOldWalsCleaner(int size) {<a name="line.154"></a>
+<span class="sourceLineNo">155</span>    LOG.info("Creating OldWALs cleaners 
with size=" + size);<a name="line.155"></a>
+<span class="sourceLineNo">156</span><a name="line.156"></a>
+<span class="sourceLineNo">157</span>    List&lt;Thread&gt; oldWALsCleaner = 
new ArrayList&lt;&gt;(size);<a name="line.157"></a>
+<span class="sourceLineNo">158</span>    for (int i = 0; i &lt; size; i++) {<a 
name="line.158"></a>
+<span class="sourceLineNo">159</span>      Thread cleaner = new Thread(() 
-&gt; deleteFile());<a name="line.159"></a>
+<span class="sourceLineNo">160</span>      cleaner.setName("OldWALsCleaner-" + 
i);<a name="line.160"></a>
+<span class="sourceLineNo">161</span>      cleaner.setDaemon(true);<a 
name="line.161"></a>
+<span class="sourceLineNo">162</span>      cleaner.start();<a 
name="line.162"></a>
+<span class="sourceLineNo">163</span>      oldWALsCleaner.add(cleaner);<a 
name="line.163"></a>
+<span class="sourceLineNo">164</span>    }<a name="line.164"></a>
+<span class="sourceLineNo">165</span>    return oldWALsCleaner;<a 
name="line.165"></a>
+<span class="sourceLineNo">166</span>  }<a name="line.166"></a>
+<span class="sourceLineNo">167</span><a name="line.167"></a>
+<span class="sourceLineNo">168</span>  private void interruptOldWALsCleaner() 
{<a name="line.168"></a>
+<span class="sourceLineNo">169</span>    for (Thread cleaner : oldWALsCleaner) 
{<a name="line.169"></a>
+<span class="sourceLineNo">170</span>      cleaner.interrupt();<a 
name="line.170"></a>
+<span class="sourceLineNo">171</span>    }<a name="line.171"></a>
+<span class="sourceLineNo">172</span>    oldWALsCleaner.clear();<a 
name="line.172"></a>
+<span class="sourceLineNo">173</span>  }<a name="line.173"></a>
+<span class="sourceLineNo">174</span><a name="line.174"></a>
+<span class="sourceLineNo">175</span>  private void deleteFile() {<a 
name="line.175"></a>
+<span class="sourceLineNo">176</span>    while (true) {<a name="line.176"></a>
+<span class="sourceLineNo">177</span>      CleanerContext context = null;<a 
name="line.177"></a>
+<span class="sourceLineNo">178</span>      boolean succeed = false;<a 
name="line.178"></a>
+<span class="sourceLineNo">179</span>      boolean interrupted = false;<a 
name="line.179"></a>
+<span class="sourceLineNo">180</span>      try {<a name="line.180"></a>
+<span class="sourceLineNo">181</span>        context = pendingDelete.take();<a 
name="line.181"></a>
+<span class="sourceLineNo">182</span>        if (context != null) {<a 
name="line.182"></a>
+<span class="sourceLineNo">183</span>          FileStatus toClean = 
context.getTargetToClean();<a name="line.183"></a>
+<span class="sourceLineNo">184</span>          succeed = 
this.fs.delete(toClean.getPath(), false);<a name="line.184"></a>
+<span class="sourceLineNo">185</span>        }<a name="line.185"></a>
+<span class="sourceLineNo">186</span>      } catch (InterruptedException ite) 
{<a name="line.186"></a>
+<span class="sourceLineNo">187</span>        // It's most likely from 
configuration changing request<a name="line.187"></a>
+<span class="sourceLineNo">188</span>        if (context != null) {<a 
name="line.188"></a>
+<span class="sourceLineNo">189</span>          LOG.warn("Interrupted while 
cleaning oldWALs " +<a name="line.189"></a>
+<span class="sourceLineNo">190</span>              context.getTargetToClean() 
+ ", try to clean it next round.");<a name="line.190"></a>
+<span class="sourceLineNo">191</span>        }<a name="line.191"></a>
+<span class="sourceLineNo">192</span>        interrupted = true;<a 
name="line.192"></a>
+<span class="sourceLineNo">193</span>      } catch (IOException e) {<a 
name="line.193"></a>
+<span class="sourceLineNo">194</span>        // fs.delete() fails.<a 
name="line.194"></a>
+<span class="sourceLineNo">195</span>        LOG.warn("Failed to clean oldwals 
with exception: " + e);<a name="line.195"></a>
+<span class="sourceLineNo">196</span>        succeed = false;<a 
name="line.196"></a>
+<span class="sourceLineNo">197</span>      } finally {<a name="line.197"></a>
+<span class="sourceLineNo">198</span>        if (context != null) {<a 
name="line.198"></a>
+<span class="sourceLineNo">199</span>          context.setResult(succeed);<a 
name="line.199"></a>
+<span class="sourceLineNo">200</span>        }<a name="line.200"></a>
+<span class="sourceLineNo">201</span>        if (interrupted) {<a 
name="line.201"></a>
+<span class="sourceLineNo">202</span>          // Restore interrupt status<a 
name="line.202"></a>
+<span class="sourceLineNo">203</span>          
Thread.currentThread().interrupt();<a name="line.203"></a>
+<span class="sourceLineNo">204</span>          break;<a name="line.204"></a>
+<span class="sourceLineNo">205</span>        }<a name="line.205"></a>
+<span class="sourceLineNo">206</span>      }<a name="line.206"></a>
+<span class="sourceLineNo">207</span>    }<a name="line.207"></a>
+<span class="sourceLineNo">208</span>    if (LOG.isDebugEnabled()) {<a 
name="line.208"></a>
+<span class="sourceLineNo">209</span>      LOG.debug("Exiting cleaner.");<a 
name="line.209"></a>
+<span class="sourceLineNo">210</span>    }<a name="line.210"></a>
+<span class="sourceLineNo">211</span>  }<a name="line.211"></a>
+<span class="sourceLineNo">212</span><a name="line.212"></a>
+<span class="sourceLineNo">213</span>  @Override<a name="line.213"></a>
+<span class="sourceLineNo">214</span>  public synchronized void cancel(boolean 
mayInterruptIfRunning) {<a name="line.214"></a>
+<span class="sourceLineNo">215</span>    
super.cancel(mayInterruptIfRunning);<a name="line.215"></a>
+<span class="sourceLineNo">216</span>    for (Thread t : oldWALsCleaner) {<a 
name="line.216"></a>
+<span class="sourceLineNo">217</span>      t.interrupt();<a 
name="line.217"></a>
+<span class="sourceLineNo">218</span>    }<a name="line.218"></a>
+<span class="sourceLineNo">219</span>  }<a name="line.219"></a>
+<span class="sourceLineNo">220</span><a name="line.220"></a>
+<span class="sourceLineNo">221</span>  private static final class 
CleanerContext {<a name="line.221"></a>
+<span class="sourceLineNo">222</span><a name="line.222"></a>
+<span class="sourceLineNo">223</span>    final FileStatus target;<a 
name="line.223"></a>
+<span class="sourceLineNo">224</span>    volatile boolean result;<a 
name="line.224"></a>
+<span class="sourceLineNo">225</span>    volatile boolean setFromCleaner = 
false;<a name="line.225"></a>
+<span class="sourceLineNo">226</span>    long timeoutMsec;<a 
name="line.226"></a>
+<span class="sourceLineNo">227</span><a name="line.227"></a>
+<span class="sourceLineNo">228</span>    static CleanerContext 
createCleanerContext(FileStatus status, long timeoutMsec) {<a 
name="line.228"></a>
+<span class="sourceLineNo">229</span>      return status != null ? new 
CleanerContext(status, timeoutMsec) : null;<a name="line.229"></a>
+<span class="sourceLineNo">230</span>    }<a name="line.230"></a>
+<span class="sourceLineNo">231</span><a name="line.231"></a>
+<span class="sourceLineNo">232</span>    private CleanerContext(FileStatus 
status, long timeoutMsec) {<a name="line.232"></a>
+<span class="sourceLineNo">233</span>      this.target = status;<a 
name="line.233"></a>
+<span class="sourceLineNo">234</span>      this.result = false;<a 
name="line.234"></a>
+<span class="sourceLineNo">235</span>      this.timeoutMsec = timeoutMsec;<a 
name="line.235"></a>
+<span class="sourceLineNo">236</span>    }<a name="line.236"></a>
+<span class="sourceLineNo">237</span><a name="line.237"></a>
+<span class="sourceLineNo">238</span>    synchronized void setResult(boolean 
res) {<a name="line.238"></a>
+<span class="sourceLineNo">239</span>      this.result = res;<a 
name="line.239"></a>
+<span class="sourceLineNo">240</span>      this.setFromCleaner = true;<a 
name="line.240"></a>
+<span class="sourceLineNo">241</span>      notify();<a name="line.241"></a>
+<span class="sourceLineNo">242</span>    }<a name="line.242"></a>
+<span class="sourceLineNo">243</span><a name="line.243"></a>
+<span class="sourceLineNo">244</span>    synchronized boolean getResult(long 
waitIfNotFinished) {<a name="line.244"></a>
+<span class="sourceLineNo">245</span>      long totalTimeMsec = 0;<a 
name="line.245"></a>
+<span class="sourceLineNo">246</span>      try {<a name="line.246"></a>
+<span class="sourceLineNo">247</span>        while (!setFromCleaner) {<a 
name="line.247"></a>
+<span class="sourceLineNo">248</span>          long startTimeNanos = 
System.nanoTime();<a name="line.248"></a>
+<span class="sourceLineNo">249</span>          wait(waitIfNotFinished);<a 
name="line.249"></a>
+<span class="sourceLineNo">250</span>          totalTimeMsec += 
TimeUnit.MILLISECONDS.convert(System.nanoTime() - startTimeNanos,<a 
name="line.250"></a>
+<span class="sourceLineNo">251</span>              TimeUnit.NANOSECONDS);<a 
name="line.251"></a>
+<span class="sourceLineNo">252</span>          if (totalTimeMsec &gt;= 
timeoutMsec) {<a name="line.252"></a>
+<span class="sourceLineNo">253</span>            LOG.warn("Spend too much time 
" + totalTimeMsec + " ms to delete oldwals " + target);<a name="line.253"></a>
+<span class="sourceLineNo">254</span>            return result;<a 
name="line.254"></a>
+<span class="sourceLineNo">255</span>          }<a name="line.255"></a>
+<span class="sourceLineNo">256</span>        }<a name="line.256"></a>
+<span class="sourceLineNo">257</span>      } catch (InterruptedException e) 
{<a name="line.257"></a>
+<span class="sourceLineNo">258</span>        LOG.warn("Interrupted while 
waiting deletion of " + target);<a name="line.258"></a>
+<span class="sourceLineNo">259</span>        return result;<a 
name="line.259"></a>
+<span class="sourceLineNo">260</span>      }<a name="line.260"></a>
+<span class="sourceLineNo">261</span>      return result;<a 
name="line.261"></a>
+<span class="sourceLineNo">262</span>    }<a name="line.262"></a>
+<span class="sourceLineNo">263</span><a name="line.263"></a>
+<span class="sourceLineNo">264</span>    FileStatus getTargetToClean() {<a 
name="line.264"></a>
+<span class="sourceLineNo">265</span>      return target;<a 
name="line.265"></a>
+<span class="sourceLineNo">266</span>    }<a name="line.266"></a>
+<span class="sourceLineNo">267</span>  }<a name="line.267"></a>
+<span class="sourceLineNo">268</span>}<a name="line.268"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/b248f175/devapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/LogCleaner.html
----------------------------------------------------------------------
diff --git 
a/devapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/LogCleaner.html 
b/devapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/LogCleaner.html
index 541533a..a23f742 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/LogCleaner.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/LogCleaner.html
@@ -32,213 +32,248 @@
 <span class="sourceLineNo">024</span>import java.util.LinkedList;<a 
name="line.24"></a>
 <span class="sourceLineNo">025</span>import java.util.List;<a 
name="line.25"></a>
 <span class="sourceLineNo">026</span>import 
java.util.concurrent.LinkedBlockingQueue;<a name="line.26"></a>
-<span class="sourceLineNo">027</span><a name="line.27"></a>
-<span class="sourceLineNo">028</span>import 
org.apache.hadoop.conf.Configuration;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import org.apache.hadoop.fs.FileStatus;<a 
name="line.29"></a>
-<span class="sourceLineNo">030</span>import org.apache.hadoop.fs.FileSystem;<a 
name="line.30"></a>
-<span class="sourceLineNo">031</span>import org.apache.hadoop.fs.Path;<a 
name="line.31"></a>
-<span class="sourceLineNo">032</span>import 
org.apache.hadoop.hbase.Stoppable;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import 
org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil;<a 
name="line.33"></a>
-<span class="sourceLineNo">034</span>import 
org.apache.hadoop.hbase.wal.AbstractFSWALProvider;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import 
org.apache.yetus.audience.InterfaceAudience;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.slf4j.Logger;<a 
name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.slf4j.LoggerFactory;<a 
name="line.37"></a>
-<span class="sourceLineNo">038</span>import 
org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;<a 
name="line.38"></a>
-<span class="sourceLineNo">039</span><a name="line.39"></a>
-<span class="sourceLineNo">040</span>/**<a name="line.40"></a>
-<span class="sourceLineNo">041</span> * This Chore, every time it runs, will 
attempt to delete the WALs and Procedure WALs in the old<a name="line.41"></a>
-<span class="sourceLineNo">042</span> * logs folder. The WAL is only deleted 
if none of the cleaner delegates says otherwise.<a name="line.42"></a>
-<span class="sourceLineNo">043</span> * @see BaseLogCleanerDelegate<a 
name="line.43"></a>
-<span class="sourceLineNo">044</span> */<a name="line.44"></a>
-<span class="sourceLineNo">045</span>@InterfaceAudience.Private<a 
name="line.45"></a>
-<span class="sourceLineNo">046</span>public class LogCleaner extends 
CleanerChore&lt;BaseLogCleanerDelegate&gt; {<a name="line.46"></a>
-<span class="sourceLineNo">047</span>  private static final Logger LOG = 
LoggerFactory.getLogger(LogCleaner.class.getName());<a name="line.47"></a>
-<span class="sourceLineNo">048</span><a name="line.48"></a>
-<span class="sourceLineNo">049</span>  public static final String 
OLD_WALS_CLEANER_SIZE = "hbase.oldwals.cleaner.thread.size";<a 
name="line.49"></a>
-<span class="sourceLineNo">050</span>  public static final int 
OLD_WALS_CLEANER_DEFAULT_SIZE = 2;<a name="line.50"></a>
-<span class="sourceLineNo">051</span><a name="line.51"></a>
-<span class="sourceLineNo">052</span>  private final 
LinkedBlockingQueue&lt;CleanerContext&gt; pendingDelete;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>  private List&lt;Thread&gt; 
oldWALsCleaner;<a name="line.53"></a>
-<span class="sourceLineNo">054</span><a name="line.54"></a>
-<span class="sourceLineNo">055</span>  /**<a name="line.55"></a>
-<span class="sourceLineNo">056</span>   * @param period the period of time to 
sleep between each run<a name="line.56"></a>
-<span class="sourceLineNo">057</span>   * @param stopper the stopper<a 
name="line.57"></a>
-<span class="sourceLineNo">058</span>   * @param conf configuration to use<a 
name="line.58"></a>
-<span class="sourceLineNo">059</span>   * @param fs handle to the FS<a 
name="line.59"></a>
-<span class="sourceLineNo">060</span>   * @param oldLogDir the path to the 
archived logs<a name="line.60"></a>
-<span class="sourceLineNo">061</span>   */<a name="line.61"></a>
-<span class="sourceLineNo">062</span>  public LogCleaner(final int period, 
final Stoppable stopper, Configuration conf, FileSystem fs,<a 
name="line.62"></a>
-<span class="sourceLineNo">063</span>      Path oldLogDir) {<a 
name="line.63"></a>
-<span class="sourceLineNo">064</span>    super("LogsCleaner", period, stopper, 
conf, fs, oldLogDir, HBASE_MASTER_LOGCLEANER_PLUGINS);<a name="line.64"></a>
-<span class="sourceLineNo">065</span>    this.pendingDelete = new 
LinkedBlockingQueue&lt;&gt;();<a name="line.65"></a>
-<span class="sourceLineNo">066</span>    int size = 
conf.getInt(OLD_WALS_CLEANER_SIZE, OLD_WALS_CLEANER_DEFAULT_SIZE);<a 
name="line.66"></a>
-<span class="sourceLineNo">067</span>    this.oldWALsCleaner = 
createOldWalsCleaner(size);<a name="line.67"></a>
-<span class="sourceLineNo">068</span>  }<a name="line.68"></a>
-<span class="sourceLineNo">069</span><a name="line.69"></a>
-<span class="sourceLineNo">070</span>  @Override<a name="line.70"></a>
-<span class="sourceLineNo">071</span>  protected boolean validate(Path file) 
{<a name="line.71"></a>
-<span class="sourceLineNo">072</span>    return 
AbstractFSWALProvider.validateWALFilename(file.getName())<a name="line.72"></a>
-<span class="sourceLineNo">073</span>        || 
MasterProcedureUtil.validateProcedureWALFilename(file.getName());<a 
name="line.73"></a>
-<span class="sourceLineNo">074</span>  }<a name="line.74"></a>
-<span class="sourceLineNo">075</span><a name="line.75"></a>
-<span class="sourceLineNo">076</span>  @Override<a name="line.76"></a>
-<span class="sourceLineNo">077</span>  public void 
onConfigurationChange(Configuration conf) {<a name="line.77"></a>
-<span class="sourceLineNo">078</span>    super.onConfigurationChange(conf);<a 
name="line.78"></a>
-<span class="sourceLineNo">079</span><a name="line.79"></a>
-<span class="sourceLineNo">080</span>    int newSize = 
conf.getInt(OLD_WALS_CLEANER_SIZE, OLD_WALS_CLEANER_DEFAULT_SIZE);<a 
name="line.80"></a>
-<span class="sourceLineNo">081</span>    if (newSize == oldWALsCleaner.size()) 
{<a name="line.81"></a>
-<span class="sourceLineNo">082</span>      if (LOG.isDebugEnabled()) {<a 
name="line.82"></a>
-<span class="sourceLineNo">083</span>        LOG.debug("Size from 
configuration is the same as previous which is " +<a name="line.83"></a>
-<span class="sourceLineNo">084</span>          newSize + ", no need to 
update.");<a name="line.84"></a>
-<span class="sourceLineNo">085</span>      }<a name="line.85"></a>
-<span class="sourceLineNo">086</span>      return;<a name="line.86"></a>
-<span class="sourceLineNo">087</span>    }<a name="line.87"></a>
-<span class="sourceLineNo">088</span>    interruptOldWALsCleaner();<a 
name="line.88"></a>
-<span class="sourceLineNo">089</span>    oldWALsCleaner = 
createOldWalsCleaner(newSize);<a name="line.89"></a>
-<span class="sourceLineNo">090</span>  }<a name="line.90"></a>
-<span class="sourceLineNo">091</span><a name="line.91"></a>
-<span class="sourceLineNo">092</span>  @Override<a name="line.92"></a>
-<span class="sourceLineNo">093</span>  protected int 
deleteFiles(Iterable&lt;FileStatus&gt; filesToDelete) {<a name="line.93"></a>
-<span class="sourceLineNo">094</span>    List&lt;CleanerContext&gt; results = 
new LinkedList&lt;&gt;();<a name="line.94"></a>
-<span class="sourceLineNo">095</span>    for (FileStatus toDelete : 
filesToDelete) {<a name="line.95"></a>
-<span class="sourceLineNo">096</span>      CleanerContext context = 
CleanerContext.createCleanerContext(toDelete);<a name="line.96"></a>
-<span class="sourceLineNo">097</span>      if (context != null) {<a 
name="line.97"></a>
-<span class="sourceLineNo">098</span>        pendingDelete.add(context);<a 
name="line.98"></a>
-<span class="sourceLineNo">099</span>        results.add(context);<a 
name="line.99"></a>
-<span class="sourceLineNo">100</span>      }<a name="line.100"></a>
-<span class="sourceLineNo">101</span>    }<a name="line.101"></a>
-<span class="sourceLineNo">102</span><a name="line.102"></a>
-<span class="sourceLineNo">103</span>    int deletedFiles = 0;<a 
name="line.103"></a>
-<span class="sourceLineNo">104</span>    for (CleanerContext res : results) 
{<a name="line.104"></a>
-<span class="sourceLineNo">105</span>      deletedFiles += res.getResult(500) 
? 1 : 0;<a name="line.105"></a>
-<span class="sourceLineNo">106</span>    }<a name="line.106"></a>
-<span class="sourceLineNo">107</span>    return deletedFiles;<a 
name="line.107"></a>
-<span class="sourceLineNo">108</span>  }<a name="line.108"></a>
-<span class="sourceLineNo">109</span><a name="line.109"></a>
-<span class="sourceLineNo">110</span>  @Override<a name="line.110"></a>
-<span class="sourceLineNo">111</span>  public synchronized void cleanup() {<a 
name="line.111"></a>
-<span class="sourceLineNo">112</span>    super.cleanup();<a 
name="line.112"></a>
-<span class="sourceLineNo">113</span>    interruptOldWALsCleaner();<a 
name="line.113"></a>
-<span class="sourceLineNo">114</span>  }<a name="line.114"></a>
-<span class="sourceLineNo">115</span><a name="line.115"></a>
-<span class="sourceLineNo">116</span>  @VisibleForTesting<a 
name="line.116"></a>
-<span class="sourceLineNo">117</span>  int getSizeOfCleaners() {<a 
name="line.117"></a>
-<span class="sourceLineNo">118</span>    return oldWALsCleaner.size();<a 
name="line.118"></a>
-<span class="sourceLineNo">119</span>  }<a name="line.119"></a>
-<span class="sourceLineNo">120</span><a name="line.120"></a>
-<span class="sourceLineNo">121</span>  private List&lt;Thread&gt; 
createOldWalsCleaner(int size) {<a name="line.121"></a>
-<span class="sourceLineNo">122</span>    LOG.info("Creating OldWALs cleaners 
with size=" + size);<a name="line.122"></a>
-<span class="sourceLineNo">123</span><a name="line.123"></a>
-<span class="sourceLineNo">124</span>    List&lt;Thread&gt; oldWALsCleaner = 
new ArrayList&lt;&gt;(size);<a name="line.124"></a>
-<span class="sourceLineNo">125</span>    for (int i = 0; i &lt; size; i++) {<a 
name="line.125"></a>
-<span class="sourceLineNo">126</span>      Thread cleaner = new Thread(() 
-&gt; deleteFile());<a name="line.126"></a>
-<span class="sourceLineNo">127</span>      cleaner.setName("OldWALsCleaner-" + 
i);<a name="line.127"></a>
-<span class="sourceLineNo">128</span>      cleaner.setDaemon(true);<a 
name="line.128"></a>
-<span class="sourceLineNo">129</span>      cleaner.start();<a 
name="line.129"></a>
-<span class="sourceLineNo">130</span>      oldWALsCleaner.add(cleaner);<a 
name="line.130"></a>
-<span class="sourceLineNo">131</span>    }<a name="line.131"></a>
-<span class="sourceLineNo">132</span>    return oldWALsCleaner;<a 
name="line.132"></a>
-<span class="sourceLineNo">133</span>  }<a name="line.133"></a>
-<span class="sourceLineNo">134</span><a name="line.134"></a>
-<span class="sourceLineNo">135</span>  private void interruptOldWALsCleaner() 
{<a name="line.135"></a>
-<span class="sourceLineNo">136</span>    for (Thread cleaner : oldWALsCleaner) 
{<a name="line.136"></a>
-<span class="sourceLineNo">137</span>      cleaner.interrupt();<a 
name="line.137"></a>
-<span class="sourceLineNo">138</span>    }<a name="line.138"></a>
-<span class="sourceLineNo">139</span>    oldWALsCleaner.clear();<a 
name="line.139"></a>
-<span class="sourceLineNo">140</span>  }<a name="line.140"></a>
-<span class="sourceLineNo">141</span><a name="line.141"></a>
-<span class="sourceLineNo">142</span>  private void deleteFile() {<a 
name="line.142"></a>
-<span class="sourceLineNo">143</span>    while (true) {<a name="line.143"></a>
-<span class="sourceLineNo">144</span>      CleanerContext context = null;<a 
name="line.144"></a>
-<span class="sourceLineNo">145</span>      boolean succeed = false;<a 
name="line.145"></a>
-<span class="sourceLineNo">146</span>      boolean interrupted = false;<a 
name="line.146"></a>
-<span class="sourceLineNo">147</span>      try {<a name="line.147"></a>
-<span class="sourceLineNo">148</span>        context = pendingDelete.take();<a 
name="line.148"></a>
-<span class="sourceLineNo">149</span>        if (context != null) {<a 
name="line.149"></a>
-<span class="sourceLineNo">150</span>          FileStatus toClean = 
context.getTargetToClean();<a name="line.150"></a>
-<span class="sourceLineNo">151</span>          succeed = 
this.fs.delete(toClean.getPath(), false);<a name="line.151"></a>
-<span class="sourceLineNo">152</span>        }<a name="line.152"></a>
-<span class="sourceLineNo">153</span>      } catch (InterruptedException ite) 
{<a name="line.153"></a>
-<span class="sourceLineNo">154</span>        // It's most likely from 
configuration changing request<a name="line.154"></a>
-<span class="sourceLineNo">155</span>        if (context != null) {<a 
name="line.155"></a>
-<span class="sourceLineNo">156</span>          LOG.warn("Interrupted while 
cleaning oldWALs " +<a name="line.156"></a>
-<span class="sourceLineNo">157</span>              context.getTargetToClean() 
+ ", try to clean it next round.");<a name="line.157"></a>
-<span class="sourceLineNo">158</span>        }<a name="line.158"></a>
-<span class="sourceLineNo">159</span>        interrupted = true;<a 
name="line.159"></a>
-<span class="sourceLineNo">160</span>      } catch (IOException e) {<a 
name="line.160"></a>
-<span class="sourceLineNo">161</span>        // fs.delete() fails.<a 
name="line.161"></a>
-<span class="sourceLineNo">162</span>        LOG.warn("Failed to clean oldwals 
with exception: " + e);<a name="line.162"></a>
-<span class="sourceLineNo">163</span>        succeed = false;<a 
name="line.163"></a>
-<span class="sourceLineNo">164</span>      } finally {<a name="line.164"></a>
-<span class="sourceLineNo">165</span>        if (context != null) {<a 
name="line.165"></a>
-<span class="sourceLineNo">166</span>          context.setResult(succeed);<a 
name="line.166"></a>
-<span class="sourceLineNo">167</span>        }<a name="line.167"></a>
-<span class="sourceLineNo">168</span>        if (interrupted) {<a 
name="line.168"></a>
-<span class="sourceLineNo">169</span>          // Restore interrupt status<a 
name="line.169"></a>
-<span class="sourceLineNo">170</span>          
Thread.currentThread().interrupt();<a name="line.170"></a>
-<span class="sourceLineNo">171</span>          break;<a name="line.171"></a>
-<span class="sourceLineNo">172</span>        }<a name="line.172"></a>
-<span class="sourceLineNo">173</span>      }<a name="line.173"></a>
-<span class="sourceLineNo">174</span>    }<a name="line.174"></a>
-<span class="sourceLineNo">175</span>    if (LOG.isDebugEnabled()) {<a 
name="line.175"></a>
-<span class="sourceLineNo">176</span>      LOG.debug("Exiting cleaner.");<a 
name="line.176"></a>
-<span class="sourceLineNo">177</span>    }<a name="line.177"></a>
-<span class="sourceLineNo">178</span>  }<a name="line.178"></a>
-<span class="sourceLineNo">179</span><a name="line.179"></a>
-<span class="sourceLineNo">180</span>  @Override<a name="line.180"></a>
-<span class="sourceLineNo">181</span>  public synchronized void cancel(boolean 
mayInterruptIfRunning) {<a name="line.181"></a>
-<span class="sourceLineNo">182</span>    
super.cancel(mayInterruptIfRunning);<a name="line.182"></a>
-<span class="sourceLineNo">183</span>    for (Thread t : oldWALsCleaner) {<a 
name="line.183"></a>
-<span class="sourceLineNo">184</span>      t.interrupt();<a 
name="line.184"></a>
-<span class="sourceLineNo">185</span>    }<a name="line.185"></a>
-<span class="sourceLineNo">186</span>  }<a name="line.186"></a>
-<span class="sourceLineNo">187</span><a name="line.187"></a>
-<span class="sourceLineNo">188</span>  private static final class 
CleanerContext {<a name="line.188"></a>
-<span class="sourceLineNo">189</span>    // At most waits 60 seconds<a 
name="line.189"></a>
-<span class="sourceLineNo">190</span>    static final long MAX_WAIT = 60 * 
1000;<a name="line.190"></a>
-<span class="sourceLineNo">191</span><a name="line.191"></a>
-<span class="sourceLineNo">192</span>    final FileStatus target;<a 
name="line.192"></a>
-<span class="sourceLineNo">193</span>    volatile boolean result;<a 
name="line.193"></a>
-<span class="sourceLineNo">194</span>    volatile boolean setFromCleaner = 
false;<a name="line.194"></a>
-<span class="sourceLineNo">195</span><a name="line.195"></a>
-<span class="sourceLineNo">196</span>    static CleanerContext 
createCleanerContext(FileStatus status) {<a name="line.196"></a>
-<span class="sourceLineNo">197</span>      return status != null ? new 
CleanerContext(status) : null;<a name="line.197"></a>
-<span class="sourceLineNo">198</span>    }<a name="line.198"></a>
-<span class="sourceLineNo">199</span><a name="line.199"></a>
-<span class="sourceLineNo">200</span>    private CleanerContext(FileStatus 
status) {<a name="line.200"></a>
-<span class="sourceLineNo">201</span>      this.target = status;<a 
name="line.201"></a>
-<span class="sourceLineNo">202</span>      this.result = false;<a 
name="line.202"></a>
-<span class="sourceLineNo">203</span>    }<a name="line.203"></a>
-<span class="sourceLineNo">204</span><a name="line.204"></a>
-<span class="sourceLineNo">205</span>    synchronized void setResult(boolean 
res) {<a name="line.205"></a>
-<span class="sourceLineNo">206</span>      this.result = res;<a 
name="line.206"></a>
-<span class="sourceLineNo">207</span>      this.setFromCleaner = true;<a 
name="line.207"></a>
-<span class="sourceLineNo">208</span>      notify();<a name="line.208"></a>
-<span class="sourceLineNo">209</span>    }<a name="line.209"></a>
-<span class="sourceLineNo">210</span><a name="line.210"></a>
-<span class="sourceLineNo">211</span>    synchronized boolean getResult(long 
waitIfNotFinished) {<a name="line.211"></a>
-<span class="sourceLineNo">212</span>      long totalTime = 0;<a 
name="line.212"></a>
-<span class="sourceLineNo">213</span>      try {<a name="line.213"></a>
-<span class="sourceLineNo">214</span>        while (!setFromCleaner) {<a 
name="line.214"></a>
-<span class="sourceLineNo">215</span>          wait(waitIfNotFinished);<a 
name="line.215"></a>
-<span class="sourceLineNo">216</span>          totalTime += 
waitIfNotFinished;<a name="line.216"></a>
-<span class="sourceLineNo">217</span>          if (totalTime &gt;= MAX_WAIT) 
{<a name="line.217"></a>
-<span class="sourceLineNo">218</span>            LOG.warn("Spend too much time 
to delete oldwals " + target);<a name="line.218"></a>
-<span class="sourceLineNo">219</span>            return result;<a 
name="line.219"></a>
-<span class="sourceLineNo">220</span>          }<a name="line.220"></a>
-<span class="sourceLineNo">221</span>        }<a name="line.221"></a>
-<span class="sourceLineNo">222</span>      } catch (InterruptedException e) 
{<a name="line.222"></a>
-<span class="sourceLineNo">223</span>        LOG.warn("Interrupted while 
waiting deletion of " + target);<a name="line.223"></a>
-<span class="sourceLineNo">224</span>        return result;<a 
name="line.224"></a>
-<span class="sourceLineNo">225</span>      }<a name="line.225"></a>
-<span class="sourceLineNo">226</span>      return result;<a 
name="line.226"></a>
-<span class="sourceLineNo">227</span>    }<a name="line.227"></a>
-<span class="sourceLineNo">228</span><a name="line.228"></a>
-<span class="sourceLineNo">229</span>    FileStatus getTargetToClean() {<a 
name="line.229"></a>
-<span class="sourceLineNo">230</span>      return target;<a 
name="line.230"></a>
-<span class="sourceLineNo">231</span>    }<a name="line.231"></a>
-<span class="sourceLineNo">232</span>  }<a name="line.232"></a>
-<span class="sourceLineNo">233</span>}<a name="line.233"></a>
+<span class="sourceLineNo">027</span>import java.util.concurrent.TimeUnit;<a 
name="line.27"></a>
+<span class="sourceLineNo">028</span><a name="line.28"></a>
+<span class="sourceLineNo">029</span>import 
org.apache.hadoop.conf.Configuration;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.fs.FileStatus;<a 
name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.fs.FileSystem;<a 
name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.fs.Path;<a 
name="line.32"></a>
+<span class="sourceLineNo">033</span>import 
org.apache.hadoop.hbase.Stoppable;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import 
org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil;<a 
name="line.34"></a>
+<span class="sourceLineNo">035</span>import 
org.apache.hadoop.hbase.wal.AbstractFSWALProvider;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import 
org.apache.yetus.audience.InterfaceAudience;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.slf4j.Logger;<a 
name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.slf4j.LoggerFactory;<a 
name="line.38"></a>
+<span class="sourceLineNo">039</span>import 
org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;<a 
name="line.39"></a>
+<span class="sourceLineNo">040</span><a name="line.40"></a>
+<span class="sourceLineNo">041</span>/**<a name="line.41"></a>
+<span class="sourceLineNo">042</span> * This Chore, every time it runs, will 
attempt to delete the WALs and Procedure WALs in the old<a name="line.42"></a>
+<span class="sourceLineNo">043</span> * logs folder. The WAL is only deleted 
if none of the cleaner delegates says otherwise.<a name="line.43"></a>
+<span class="sourceLineNo">044</span> * @see BaseLogCleanerDelegate<a 
name="line.44"></a>
+<span class="sourceLineNo">045</span> */<a name="line.45"></a>
+<span class="sourceLineNo">046</span>@InterfaceAudience.Private<a 
name="line.46"></a>
+<span class="sourceLineNo">047</span>public class LogCleaner extends 
CleanerChore&lt;BaseLogCleanerDelegate&gt; {<a name="line.47"></a>
+<span class="sourceLineNo">048</span>  private static final Logger LOG = 
LoggerFactory.getLogger(LogCleaner.class.getName());<a name="line.48"></a>
+<span class="sourceLineNo">049</span><a name="line.49"></a>
+<span class="sourceLineNo">050</span>  public static final String 
OLD_WALS_CLEANER_THREAD_SIZE = "hbase.oldwals.cleaner.thread.size";<a 
name="line.50"></a>
+<span class="sourceLineNo">051</span>  public static final int 
DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE = 2;<a name="line.51"></a>
+<span class="sourceLineNo">052</span><a name="line.52"></a>
+<span class="sourceLineNo">053</span>  public static final String 
OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC =<a name="line.53"></a>
+<span class="sourceLineNo">054</span>      
"hbase.oldwals.cleaner.thread.timeout.msec";<a name="line.54"></a>
+<span class="sourceLineNo">055</span>  @VisibleForTesting<a name="line.55"></a>
+<span class="sourceLineNo">056</span>  static final long 
DEFAULT_OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC = 60 * 1000L;<a name="line.56"></a>
+<span class="sourceLineNo">057</span><a name="line.57"></a>
+<span class="sourceLineNo">058</span>  public static final String 
OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC =<a name="line.58"></a>
+<span class="sourceLineNo">059</span>      
"hbase.oldwals.cleaner.thread.check.interval.msec";<a name="line.59"></a>
+<span class="sourceLineNo">060</span>  @VisibleForTesting<a name="line.60"></a>
+<span class="sourceLineNo">061</span>  static final long 
DEFAULT_OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC = 500L;<a 
name="line.61"></a>
+<span class="sourceLineNo">062</span><a name="line.62"></a>
+<span class="sourceLineNo">063</span><a name="line.63"></a>
+<span class="sourceLineNo">064</span>  private final 
LinkedBlockingQueue&lt;CleanerContext&gt; pendingDelete;<a name="line.64"></a>
+<span class="sourceLineNo">065</span>  private List&lt;Thread&gt; 
oldWALsCleaner;<a name="line.65"></a>
+<span class="sourceLineNo">066</span>  private long 
cleanerThreadTimeoutMsec;<a name="line.66"></a>
+<span class="sourceLineNo">067</span>  private long 
cleanerThreadCheckIntervalMsec;<a name="line.67"></a>
+<span class="sourceLineNo">068</span><a name="line.68"></a>
+<span class="sourceLineNo">069</span>  /**<a name="line.69"></a>
+<span class="sourceLineNo">070</span>   * @param period the period of time to 
sleep between each run<a name="line.70"></a>
+<span class="sourceLineNo">071</span>   * @param stopper the stopper<a 
name="line.71"></a>
+<span class="sourceLineNo">072</span>   * @param conf configuration to use<a 
name="line.72"></a>
+<span class="sourceLineNo">073</span>   * @param fs handle to the FS<a 
name="line.73"></a>
+<span class="sourceLineNo">074</span>   * @param oldLogDir the path to the 
archived logs<a name="line.74"></a>
+<span class="sourceLineNo">075</span>   */<a name="line.75"></a>
+<span class="sourceLineNo">076</span>  public LogCleaner(final int period, 
final Stoppable stopper, Configuration conf, FileSystem fs,<a 
name="line.76"></a>
+<span class="sourceLineNo">077</span>      Path oldLogDir) {<a 
name="line.77"></a>
+<span class="sourceLineNo">078</span>    super("LogsCleaner", period, stopper, 
conf, fs, oldLogDir, HBASE_MASTER_LOGCLEANER_PLUGINS);<a name="line.78"></a>
+<span class="sourceLineNo">079</span>    this.pendingDelete = new 
LinkedBlockingQueue&lt;&gt;();<a name="line.79"></a>
+<span class="sourceLineNo">080</span>    int size = 
conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE, 
DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);<a name="line.80"></a>
+<span class="sourceLineNo">081</span>    this.oldWALsCleaner = 
createOldWalsCleaner(size);<a name="line.81"></a>
+<span class="sourceLineNo">082</span>    this.cleanerThreadTimeoutMsec = 
conf.getLong(OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC,<a name="line.82"></a>
+<span class="sourceLineNo">083</span>        
DEFAULT_OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC);<a name="line.83"></a>
+<span class="sourceLineNo">084</span>    this.cleanerThreadCheckIntervalMsec = 
conf.getLong(OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC,<a name="line.84"></a>
+<span class="sourceLineNo">085</span>        
DEFAULT_OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC);<a name="line.85"></a>
+<span class="sourceLineNo">086</span>  }<a name="line.86"></a>
+<span class="sourceLineNo">087</span><a name="line.87"></a>
+<span class="sourceLineNo">088</span>  @Override<a name="line.88"></a>
+<span class="sourceLineNo">089</span>  protected boolean validate(Path file) 
{<a name="line.89"></a>
+<span class="sourceLineNo">090</span>    return 
AbstractFSWALProvider.validateWALFilename(file.getName())<a name="line.90"></a>
+<span class="sourceLineNo">091</span>        || 
MasterProcedureUtil.validateProcedureWALFilename(file.getName());<a 
name="line.91"></a>
+<span class="sourceLineNo">092</span>  }<a name="line.92"></a>
+<span class="sourceLineNo">093</span><a name="line.93"></a>
+<span class="sourceLineNo">094</span>  @Override<a name="line.94"></a>
+<span class="sourceLineNo">095</span>  public void 
onConfigurationChange(Configuration conf) {<a name="line.95"></a>
+<span class="sourceLineNo">096</span>    super.onConfigurationChange(conf);<a 
name="line.96"></a>
+<span class="sourceLineNo">097</span><a name="line.97"></a>
+<span class="sourceLineNo">098</span>    int newSize = 
conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE, 
DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);<a name="line.98"></a>
+<span class="sourceLineNo">099</span>    if (newSize == oldWALsCleaner.size()) 
{<a name="line.99"></a>
+<span class="sourceLineNo">100</span>      if (LOG.isDebugEnabled()) {<a 
name="line.100"></a>
+<span class="sourceLineNo">101</span>        LOG.debug("Size from 
configuration is the same as previous which is " +<a name="line.101"></a>
+<span class="sourceLineNo">102</span>          newSize + ", no need to 
update.");<a name="line.102"></a>
+<span class="sourceLineNo">103</span>      }<a name="line.103"></a>
+<span class="sourceLineNo">104</span>      return;<a name="line.104"></a>
+<span class="sourceLineNo">105</span>    }<a name="line.105"></a>
+<span class="sourceLineNo">106</span>    interruptOldWALsCleaner();<a 
name="line.106"></a>
+<span class="sourceLineNo">107</span>    oldWALsCleaner = 
createOldWalsCleaner(newSize);<a name="line.107"></a>
+<span class="sourceLineNo">108</span>    cleanerThreadTimeoutMsec = 
conf.getLong(OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC,<a name="line.108"></a>
+<span class="sourceLineNo">109</span>        
DEFAULT_OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC);<a name="line.109"></a>
+<span class="sourceLineNo">110</span>    cleanerThreadCheckIntervalMsec = 
conf.getLong(OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC,<a name="line.110"></a>
+<span class="sourceLineNo">111</span>        
DEFAULT_OLD_WALS_CLEANER_THREAD_CHECK_INTERVAL_MSEC);<a name="line.111"></a>
+<span class="sourceLineNo">112</span>  }<a name="line.112"></a>
+<span class="sourceLineNo">113</span><a name="line.113"></a>
+<span class="sourceLineNo">114</span>  @Override<a name="line.114"></a>
+<span class="sourceLineNo">115</span>  protected int 
deleteFiles(Iterable&lt;FileStatus&gt; filesToDelete) {<a name="line.115"></a>
+<span class="sourceLineNo">116</span>    List&lt;CleanerContext&gt; results = 
new LinkedList&lt;&gt;();<a name="line.116"></a>
+<span class="sourceLineNo">117</span>    for (FileStatus toDelete : 
filesToDelete) {<a name="line.117"></a>
+<span class="sourceLineNo">118</span>      CleanerContext context = 
CleanerContext.createCleanerContext(toDelete,<a name="line.118"></a>
+<span class="sourceLineNo">119</span>          cleanerThreadTimeoutMsec);<a 
name="line.119"></a>
+<span class="sourceLineNo">120</span>      if (context != null) {<a 
name="line.120"></a>
+<span class="sourceLineNo">121</span>        pendingDelete.add(context);<a 
name="line.121"></a>
+<span class="sourceLineNo">122</span>        results.add(context);<a 
name="line.122"></a>
+<span class="sourceLineNo">123</span>      }<a name="line.123"></a>
+<span class="sourceLineNo">124</span>    }<a name="line.124"></a>
+<span class="sourceLineNo">125</span><a name="line.125"></a>
+<span class="sourceLineNo">126</span>    int deletedFiles = 0;<a 
name="line.126"></a>
+<span class="sourceLineNo">127</span>    for (CleanerContext res : results) 
{<a name="line.127"></a>
+<span class="sourceLineNo">128</span>      deletedFiles += 
res.getResult(cleanerThreadCheckIntervalMsec) ? 1 : 0;<a name="line.128"></a>
+<span class="sourceLineNo">129</span>    }<a name="line.129"></a>
+<span class="sourceLineNo">130</span>    return deletedFiles;<a 
name="line.130"></a>
+<span class="sourceLineNo">131</span>  }<a name="line.131"></a>
+<span class="sourceLineNo">132</span><a name="line.132"></a>
+<span class="sourceLineNo">133</span>  @Override<a name="line.133"></a>
+<span class="sourceLineNo">134</span>  public synchronized void cleanup() {<a 
name="line.134"></a>
+<span class="sourceLineNo">135</span>    super.cleanup();<a 
name="line.135"></a>
+<span class="sourceLineNo">136</span>    interruptOldWALsCleaner();<a 
name="line.136"></a>
+<span class="sourceLineNo">137</span>  }<a name="line.137"></a>
+<span class="sourceLineNo">138</span><a name="line.138"></a>
+<span class="sourceLineNo">139</span>  @VisibleForTesting<a 
name="line.139"></a>
+<span class="sourceLineNo">140</span>  int getSizeOfCleaners() {<a 
name="line.140"></a>
+<span class="sourceLineNo">141</span>    return oldWALsCleaner.size();<a 
name="line.141"></a>
+<span class="sourceLineNo">142</span>  }<a name="line.142"></a>
+<span class="sourceLineNo">143</span><a name="line.143"></a>
+<span class="sourceLineNo">144</span>  @VisibleForTesting<a 
name="line.144"></a>
+<span class="sourceLineNo">145</span>  long getCleanerThreadTimeoutMsec() {<a 
name="line.145"></a>
+<span class="sourceLineNo">146</span>    return cleanerThreadTimeoutMsec;<a 
name="line.146"></a>
+<span class="sourceLineNo">147</span>  }<a name="line.147"></a>
+<span class="sourceLineNo">148</span><a name="line.148"></a>
+<span class="sourceLineNo">149</span>  @VisibleForTesting<a 
name="line.149"></a>
+<span class="sourceLineNo">150</span>  long 
getCleanerThreadCheckIntervalMsec() {<a name="line.150"></a>
+<span class="sourceLineNo">151</span>    return 
cleanerThreadCheckIntervalMsec;<a name="line.151"></a>
+<span class="sourceLineNo">152</span>  }<a name="line.152"></a>
+<span class="sourceLineNo">153</span><a name="line.153"></a>
+<span class="sourceLineNo">154</span>  private List&lt;Thread&gt; 
createOldWalsCleaner(int size) {<a name="line.154"></a>
+<span class="sourceLineNo">155</span>    LOG.info("Creating OldWALs cleaners 
with size=" + size);<a name="line.155"></a>
+<span class="sourceLineNo">156</span><a name="line.156"></a>
+<span class="sourceLineNo">157</span>    List&lt;Thread&gt; oldWALsCleaner = 
new ArrayList&lt;&gt;(size);<a name="line.157"></a>
+<span class="sourceLineNo">158</span>    for (int i = 0; i &lt; size; i++) {<a 
name="line.158"></a>
+<span class="sourceLineNo">159</span>      Thread cleaner = new Thread(() 
-&gt; deleteFile());<a name="line.159"></a>
+<span class="sourceLineNo">160</span>      cleaner.setName("OldWALsCleaner-" + 
i);<a name="line.160"></a>
+<span class="sourceLineNo">161</span>      cleaner.setDaemon(true);<a 
name="line.161"></a>
+<span class="sourceLineNo">162</span>      cleaner.start();<a 
name="line.162"></a>
+<span class="sourceLineNo">163</span>      oldWALsCleaner.add(cleaner);<a 
name="line.163"></a>
+<span class="sourceLineNo">164</span>    }<a name="line.164"></a>
+<span class="sourceLineNo">165</span>    return oldWALsCleaner;<a 
name="line.165"></a>
+<span class="sourceLineNo">166</span>  }<a name="line.166"></a>
+<span class="sourceLineNo">167</span><a name="line.167"></a>
+<span class="sourceLineNo">168</span>  private void interruptOldWALsCleaner() 
{<a name="line.168"></a>
+<span class="sourceLineNo">169</span>    for (Thread cleaner : oldWALsCleaner) 
{<a name="line.169"></a>
+<span class="sourceLineNo">170</span>      cleaner.interrupt();<a 
name="line.170"></a>
+<span class="sourceLineNo">171</span>    }<a name="line.171"></a>
+<span class="sourceLineNo">172</span>    oldWALsCleaner.clear();<a 
name="line.172"></a>
+<span class="sourceLineNo">173</span>  }<a name="line.173"></a>
+<span class="sourceLineNo">174</span><a name="line.174"></a>
+<span class="sourceLineNo">175</span>  private void deleteFile() {<a 
name="line.175"></a>
+<span class="sourceLineNo">176</span>    while (true) {<a name="line.176"></a>
+<span class="sourceLineNo">177</span>      CleanerContext context = null;<a 
name="line.177"></a>
+<span class="sourceLineNo">178</span>      boolean succeed = false;<a 
name="line.178"></a>
+<span class="sourceLineNo">179</span>      boolean interrupted = false;<a 
name="line.179"></a>
+<span class="sourceLineNo">180</span>      try {<a name="line.180"></a>
+<span class="sourceLineNo">181</span>        context = pendingDelete.take();<a 
name="line.181"></a>
+<span class="sourceLineNo">182</span>        if (context != null) {<a 
name="line.182"></a>
+<span class="sourceLineNo">183</span>          FileStatus toClean = 
context.getTargetToClean();<a name="line.183"></a>
+<span class="sourceLineNo">184</span>          succeed = 
this.fs.delete(toClean.getPath(), false);<a name="line.184"></a>
+<span class="sourceLineNo">185</span>        }<a name="line.185"></a>
+<span class="sourceLineNo">186</span>      } catch (InterruptedException ite) 
{<a name="line.186"></a>
+<span class="sourceLineNo">187</span>        // It's most likely from 
configuration changing request<a name="line.187"></a>
+<span class="sourceLineNo">188</span>        if (context != null) {<a 
name="line.188"></a>
+<span class="sourceLineNo">189</span>          LOG.warn("Interrupted while 
cleaning oldWALs " +<a name="line.189"></a>
+<span class="sourceLineNo">190</span>              context.getTargetToClean() 
+ ", try to clean it next round.");<a name="line.190"></a>
+<span class="sourceLineNo">191</span>        }<a name="line.191"></a>
+<span class="sourceLineNo">192</span>        interrupted = true;<a 
name="line.192"></a>
+<span class="sourceLineNo">193</span>      } catch (IOException e) {<a 
name="line.193"></a>
+<span class="sourceLineNo">194</span>        // fs.delete() fails.<a 
name="line.194"></a>
+<span class="sourceLineNo">195</span>        LOG.warn("Failed to clean oldwals 
with exception: " + e);<a name="line.195"></a>
+<span class="sourceLineNo">196</span>        succeed = false;<a 
name="line.196"></a>
+<span class="sourceLineNo">197</span>      } finally {<a name="line.197"></a>
+<span class="sourceLineNo">198</span>        if (context != null) {<a 
name="line.198"></a>
+<span class="sourceLineNo">199</span>          context.setResult(succeed);<a 
name="line.199"></a>
+<span class="sourceLineNo">200</span>        }<a name="line.200"></a>
+<span class="sourceLineNo">201</span>        if (interrupted) {<a 
name="line.201"></a>
+<span class="sourceLineNo">202</span>          // Restore interrupt status<a 
name="line.202"></a>
+<span class="sourceLineNo">203</span>          
Thread.currentThread().interrupt();<a name="line.203"></a>
+<span class="sourceLineNo">204</span>          break;<a name="line.204"></a>
+<span class="sourceLineNo">205</span>        }<a name="line.205"></a>
+<span class="sourceLineNo">206</span>      }<a name="line.206"></a>
+<span class="sourceLineNo">207</span>    }<a name="line.207"></a>
+<span class="sourceLineNo">208</span>    if (LOG.isDebugEnabled()) {<a 
name="line.208"></a>
+<span class="sourceLineNo">209</span>      LOG.debug("Exiting cleaner.");<a 
name="line.209"></a>
+<span class="sourceLineNo">210</span>    }<a name="line.210"></a>
+<span class="sourceLineNo">211</span>  }<a name="line.211"></a>
+<span class="sourceLineNo">212</span><a name="line.212"></a>
+<span class="sourceLineNo">213</span>  @Override<a name="line.213"></a>
+<span class="sourceLineNo">214</span>  public synchronized void cancel(boolean 
mayInterruptIfRunning) {<a name="line.214"></a>
+<span class="sourceLineNo">215</span>    
super.cancel(mayInterruptIfRunning);<a name="line.215"></a>
+<span class="sourceLineNo">216</span>    for (Thread t : oldWALsCleaner) {<a 
name="line.216"></a>
+<span class="sourceLineNo">217</span>      t.interrupt();<a 
name="line.217"></a>
+<span class="sourceLineNo">218</span>    }<a name="line.218"></a>
+<span class="sourceLineNo">219</span>  }<a name="line.219"></a>
+<span class="sourceLineNo">220</span><a name="line.220"></a>
+<span class="sourceLineNo">221</span>  private static final class 
CleanerContext {<a name="line.221"></a>
+<span class="sourceLineNo">222</span><a name="line.222"></a>
+<span class="sourceLineNo">223</span>    final FileStatus target;<a 
name="line.223"></a>
+<span class="sourceLineNo">224</span>    volatile boolean result;<a 
name="line.224"></a>
+<span class="sourceLineNo">225</span>    volatile boolean setFromCleaner = 
false;<a name="line.225"></a>
+<span class="sourceLineNo">226</span>    long timeoutMsec;<a 
name="line.226"></a>
+<span class="sourceLineNo">227</span><a name="line.227"></a>
+<span class="sourceLineNo">228</span>    static CleanerContext 
createCleanerContext(FileStatus status, long timeoutMsec) {<a 
name="line.228"></a>
+<span class="sourceLineNo">229</span>      return status != null ? new 
CleanerContext(status, timeoutMsec) : null;<a name="line.229"></a>
+<span class="sourceLineNo">230</span>    }<a name="line.230"></a>
+<span class="sourceLineNo">231</span><a name="line.231"></a>
+<span class="sourceLineNo">232</span>    private CleanerContext(FileStatus 
status, long timeoutMsec) {<a name="line.232"></a>
+<span class="sourceLineNo">233</span>      this.target = status;<a 
name="line.233"></a>
+<span class="sourceLineNo">234</span>      this.result = false;<a 
name="line.234"></a>
+<span class="sourceLineNo">235</span>      this.timeoutMsec = timeoutMsec;<a 
name="line.235"></a>
+<span class="sourceLineNo">236</span>    }<a name="line.236"></a>
+<span class="sourceLineNo">237</span><a name="line.237"></a>
+<span class="sourceLineNo">238</span>    synchronized void setResult(boolean 
res) {<a name="line.238"></a>
+<span class="sourceLineNo">239</span>      this.result = res;<a 
name="line.239"></a>
+<span class="sourceLineNo">240</span>      this.setFromCleaner = true;<a 
name="line.240"></a>
+<span class="sourceLineNo">241</span>      notify();<a name="line.241"></a>
+<span class="sourceLineNo">242</span>    }<a name="line.242"></a>
+<span class="sourceLineNo">243</span><a name="line.243"></a>
+<span class="sourceLineNo">244</span>    synchronized boolean getResult(long 
waitIfNotFinished) {<a name="line.244"></a>
+<span class="sourceLineNo">245</span>      long totalTimeMsec = 0;<a 
name="line.245"></a>
+<span class="sourceLineNo">246</span>      try {<a name="line.246"></a>
+<span class="sourceLineNo">247</span>        while (!setFromCleaner) {<a 
name="line.247"></a>
+<span class="sourceLineNo">248</span>          long startTimeNanos = 
System.nanoTime();<a name="line.248"></a>
+<span class="sourceLineNo">249</span>          wait(waitIfNotFinished);<a 
name="line.249"></a>
+<span class="sourceLineNo">250</span>          totalTimeMsec += 
TimeUnit.MILLISECONDS.convert(System.nanoTime() - startTimeNanos,<a 
name="line.250"></a>
+<span class="sourceLineNo">251</span>              TimeUnit.NANOSECONDS);<a 
name="line.251"></a>
+<span class="sourceLineNo">252</span>          if (totalTimeMsec &gt;= 
timeoutMsec) {<a name="line.252"></a>
+<span class="sourceLineNo">253</span>            LOG.warn("Spend too much time 
" + totalTimeMsec + " ms to delete oldwals " + target);<a name="line.253"></a>
+<span class="sourceLineNo">254</span>            return result;<a 
name="line.254"></a>
+<span class="sourceLineNo">255</span>          }<a name="line.255"></a>
+<span class="sourceLineNo">256</span>        }<a name="line.256"></a>
+<span class="sourceLineNo">257</span>      } catch (InterruptedException e) 
{<a name="line.257"></a>
+<span class="sourceLineNo">258</span>        LOG.warn("Interrupted while 
waiting deletion of " + target);<a name="line.258"></a>
+<span class="sourceLineNo">259</span>        return result;<a 
name="line.259"></a>
+<span class="sourceLineNo">260</span>      }<a name="line.260"></a>
+<span class="sourceLineNo">261</span>      return result;<a 
name="line.261"></a>
+<span class="sourceLineNo">262</span>    }<a name="line.262"></a>
+<span class="sourceLineNo">263</span><a name="line.263"></a>
+<span class="sourceLineNo">264</span>    FileStatus getTargetToClean() {<a 
name="line.264"></a>
+<span class="sourceLineNo">265</span>      return target;<a 
name="line.265"></a>
+<span class="sourceLineNo">266</span>    }<a name="line.266"></a>
+<span class="sourceLineNo">267</span>  }<a name="line.267"></a>
+<span class="sourceLineNo">268</span>}<a name="line.268"></a>
 
 
 

Reply via email to