Repository: hbase Updated Branches: refs/heads/master e8eb36651 -> d159b1f8b
HBASE-21056 Findbugs false positive: BucketCache.persistToFile may fail to clean up java.io.OutputStream Signed-off-by: Andrew Purtell <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/d159b1f8 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/d159b1f8 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/d159b1f8 Branch: refs/heads/master Commit: d159b1f8bb9a29f7786a96c910157e12583768a2 Parents: e8eb366 Author: Sean Busbey <[email protected]> Authored: Wed Aug 15 09:24:55 2018 -0500 Committer: Sean Busbey <[email protected]> Committed: Fri Aug 17 21:29:32 2018 -0500 ---------------------------------------------------------------------- .../java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java | 2 ++ 1 file changed, 2 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/d159b1f8/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java index a862912..66ee0e4 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java @@ -1081,6 +1081,8 @@ public class BucketCache implements BlockCache, HeapSize { /** * @see #retrieveFromFile(int[]) */ + @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="OBL_UNSATISFIED_OBLIGATION", + justification = "false positive, try-with-resources ensures close is called.") private void persistToFile() throws IOException { assert !cacheEnabled; if (!ioEngine.isPersistent()) {
