Repository: hbase Updated Branches: refs/heads/master b9bb14e0f -> 4508f670b
HBASE-21185 - WALPrettyPrinter: Additional useful info to be printed by wal printer tool, for debugability purposes Signed-off-by: Allan Yang <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/4508f670 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/4508f670 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/4508f670 Branch: refs/heads/master Commit: 4508f670b136ae36325016e8d51b784ab0ec490b Parents: b9bb14e Author: Wellington Chevreuil <[email protected]> Authored: Tue Oct 2 15:55:52 2018 +0100 Committer: Michael Stack <[email protected]> Committed: Thu Oct 4 03:32:18 2018 -0700 ---------------------------------------------------------------------- .../hadoop/hbase/wal/WALPrettyPrinter.java | 23 ++++++++++++++++++++ 1 file changed, 23 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/4508f670/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java index 3fa496f..281f3c9 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java @@ -84,6 +84,8 @@ public class WALPrettyPrinter { private PrintStream out; // for JSON encoding private static final ObjectMapper MAPPER = new ObjectMapper(); + //allows for jumping straight to a given portion of the file + private long position; /** * Basic constructor that simply initializes values to reasonable defaults. @@ -202,6 +204,15 @@ public class WALPrettyPrinter { } /** + * sets the position to start seeking the WAL file + * @param position + * initial position to start seeking the given WAL file + */ + public void setPosition(long position) { + this.position = position; + } + + /** * enables output as a single, persistent list. at present, only relevant in * the case of JSON output. */ @@ -274,6 +285,10 @@ public class WALPrettyPrinter { firstTxn = true; } + if (position > 0) { + log.seek(position); + } + try { WAL.Entry entry; while ((entry = log.next()) != null) { @@ -297,6 +312,7 @@ public class WALPrettyPrinter { if (row == null || ((String) op.get("row")).equals(row)) { actions.add(op); } + op.put("total_size_sum", PrivateCellUtil.estimatedSizeOfCell(cell)); } if (actions.isEmpty()) continue; @@ -321,8 +337,11 @@ public class WALPrettyPrinter { out.println(" tag: " + op.get("tag")); } if (outputValues) out.println(" value: " + op.get("value")); + out.println("cell total size sum: " + op.get("total_size_sum")); } } + out.println("edit heap size: " + entry.getEdit().heapSize()); + out.println("position: " + log.getPosition()); } } finally { log.close(); @@ -380,6 +399,7 @@ public class WALPrettyPrinter { options.addOption("s", "sequence", true, "Sequence to filter by. Pass sequence number."); options.addOption("w", "row", true, "Row to filter by. Pass row name."); + options.addOption("g", "goto", true, "Position to seek to in the file"); WALPrettyPrinter printer = new WALPrettyPrinter(); CommandLineParser parser = new PosixParser(); @@ -403,6 +423,9 @@ public class WALPrettyPrinter { printer.setSequenceFilter(Long.parseLong(cmd.getOptionValue("s"))); if (cmd.hasOption("w")) printer.setRowFilter(cmd.getOptionValue("w")); + if (cmd.hasOption("g")) { + printer.setPosition(Long.parseLong(cmd.getOptionValue("g"))); + } } catch (ParseException e) { LOG.error("Failed to parse commandLine arguments", e); HelpFormatter formatter = new HelpFormatter();
