This is an automated email from the ASF dual-hosted git repository.
apurtell pushed a commit to branch branch-1.3
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-1.3 by this push:
new 07658ff HBASE-17170 HBase is also retrying DoNotRetryIOException
because of class loader differences (Ankit Singhal)
07658ff is described below
commit 07658ffcc1426356b7ca42188c8230bbf4e842a9
Author: tedyu <[email protected]>
AuthorDate: Mon Dec 5 10:16:01 2016 -0800
HBASE-17170 HBase is also retrying DoNotRetryIOException because of class
loader differences (Ankit Singhal)
---
.../hbase/ipc/RemoteWithExtrasException.java | 50 ++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git
a/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RemoteWithExtrasException.java
b/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RemoteWithExtrasException.java
index 46356f8..0e50943 100644
---
a/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RemoteWithExtrasException.java
+++
b/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RemoteWithExtrasException.java
@@ -17,8 +17,16 @@
*/
package org.apache.hadoop.hbase.ipc;
+import java.io.IOException;
+import java.lang.reflect.Constructor;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.DoNotRetryIOException;
+import org.apache.hadoop.hbase.HBaseConfiguration;
import org.apache.hadoop.hbase.classification.InterfaceAudience;
import org.apache.hadoop.hbase.classification.InterfaceStability;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.util.DynamicClassLoader;
import org.apache.hadoop.ipc.RemoteException;
/**
@@ -30,11 +38,21 @@ import org.apache.hadoop.ipc.RemoteException;
@SuppressWarnings("serial")
@InterfaceAudience.Public
@InterfaceStability.Evolving
[email protected](
+ value = "DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED", justification =
"None. Address sometime.")
public class RemoteWithExtrasException extends RemoteException {
private final String hostname;
private final int port;
private final boolean doNotRetry;
+ private final static ClassLoader CLASS_LOADER;
+
+ static {
+ ClassLoader parent = RemoteWithExtrasException.class.getClassLoader();
+ Configuration conf = HBaseConfiguration.create();
+ CLASS_LOADER = new DynamicClassLoader(conf, parent);
+ }
+
public RemoteWithExtrasException(String className, String msg, final boolean
doNotRetry) {
this(className, msg, null, -1, doNotRetry);
}
@@ -47,6 +65,38 @@ public class RemoteWithExtrasException extends
RemoteException {
this.doNotRetry = doNotRetry;
}
+ @Override
+ public IOException unwrapRemoteException() {
+ Class<?> realClass;
+ try {
+ // try to load a exception class from where the HBase classes are loaded
or from Dynamic
+ // classloader.
+ realClass = Class.forName(getClassName(), false, CLASS_LOADER);
+ } catch (ClassNotFoundException cnfe) {
+ try {
+ // cause could be a hadoop exception, try to load from hadoop classpath
+ realClass = Class.forName(getClassName(), false,
super.getClass().getClassLoader());
+ } catch (ClassNotFoundException e) {
+ return new DoNotRetryIOException(
+ "Unable to load exception received from server:" + e.getMessage(),
this);
+ }
+ }
+ try {
+ return instantiateException(realClass.asSubclass(IOException.class));
+ } catch (Exception e) {
+ return new DoNotRetryIOException(
+ "Unable to instantiate exception received from server:" +
e.getMessage(), this);
+ }
+ }
+
+ private IOException instantiateException(Class<? extends IOException> cls)
throws Exception {
+ Constructor<? extends IOException> cn = cls.getConstructor(String.class);
+ cn.setAccessible(true);
+ IOException ex = cn.newInstance(this.getMessage());
+ ex.initCause(this);
+ return ex;
+ }
+
/**
* @return null if not set
*/
