[hbase] branch branch-2 updated: HBASE-23582 Unbalanced braces in string representation of table descriptor

[janh]

This is an automated email from the ASF dual-hosted git repository.

janh pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2 by this push:
     new dcd02d1  HBASE-23582 Unbalanced braces in string representation of 
table descriptor
dcd02d1 is described below

commit dcd02d1236ea936b5078768495a89f0fbd543253
Author: Junegunn Choi <junegun...@gmail.com>
AuthorDate: Mon Dec 16 18:35:15 2019 +0900

    HBASE-23582 Unbalanced braces in string representation of table descriptor
    
    Signed-off-by: Lijin Bin <binli...@apache.org>
    Signed-off-by: Jan Hentschel <j...@apache.org>
---
 .../hadoop/hbase/client/TableDescriptorBuilder.java     |  2 ++
 .../hadoop/hbase/client/TestTableDescriptorBuilder.java | 17 +++++++++++++++++
 2 files changed, 19 insertions(+)

diff --git 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java
 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java
index 4ab04cd6..4beb6e9 100644
--- 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java
+++ 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java
@@ -1214,6 +1214,8 @@ public class TableDescriptorBuilder {
           }
           s.append("}");
         }
+
+        s.append("}");
       }
 
       s.append("}"); // end METHOD
diff --git 
a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java
 
b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java
index ef64fc7..19f8721 100644
--- 
a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java
+++ 
b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java
@@ -310,4 +310,21 @@ public class TestTableDescriptorBuilder {
             .build();
     assertEquals(42, htd.getPriority());
   }
+
+  @Test
+  public void testStringCustomizedValues() {
+    byte[] familyName = Bytes.toBytes("cf");
+    ColumnFamilyDescriptor hcd = 
ColumnFamilyDescriptorBuilder.newBuilder(familyName)
+            .setBlocksize(1000)
+            .build();
+    TableDescriptor htd = 
TableDescriptorBuilder.newBuilder(TableName.valueOf(name.getMethodName()))
+            .setColumnFamily(hcd)
+            .setDurability(Durability.ASYNC_WAL)
+            .build();
+
+    assertEquals(
+      "'testStringCustomizedValues', " +
+        "{TABLE_ATTRIBUTES => {DURABILITY => 'ASYNC_WAL'}}, {NAME => 'cf', 
BLOCKSIZE => '1000'}",
+      htd.toStringCustomizedValues());
+  }
 }