This is an automated email from the ASF dual-hosted git repository.
apurtell pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new fd3e283 HBASE-25836 RegionStates#getAssignmentsForBalancer should
only care about OPEN or OPENING regions (#3219)
fd3e283 is described below
commit fd3e28364c86b37b5df307f979e2f1918c38ae94
Author: Andrew Purtell <[email protected]>
AuthorDate: Mon May 3 18:23:07 2021 -0700
HBASE-25836 RegionStates#getAssignmentsForBalancer should only care about
OPEN or OPENING regions (#3219)
RegionStates#getAssignmentsForBalancer is used by the HMaster to
collect all regions of interest to the balancer for the next chore
iteration. We check if a table is in disabled state to exclude
regions that will not be of interest (because disabled regions are
or will be offline) or are in a state where they shouldn't be
mutated (like SPLITTING). The current checks are not actually
comprehensive.
Filter out regions not in OPEN or OPENING state when building the
set of interesting regions for the balancer to consider. Only
regions open (or opening) on the cluster are of interest to
balancing calculations for the current iteration. Regions in all
other states can be expected to not be of interest – either offline
(OFFLINE, or FAILED_*), not subject to balancer decisions now
(SPLITTING, SPLITTING_NEW, MERGING, MERGING_NEW), or will be
offline shortly (CLOSING) – until at least the next chore
iteration.
Add TRACE level logging.
Signed-off-by: Bharath Vissapragada <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Viraj Jasani <[email protected]>
---
.../hadoop/hbase/master/assignment/RegionStates.java | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java
index d3553f1..579e13a 100644
---
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java
+++
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java
@@ -553,23 +553,37 @@ public class RegionStates {
* wants to iterate this exported list. We need to synchronize on regions
* since all access to this.servers is under a lock on this.regions.
*
- * @return A clone of current assignments.
+ * @return A clone of current open or opening assignments.
*/
public Map<TableName, Map<ServerName, List<RegionInfo>>>
getAssignmentsForBalancer(
TableStateManager tableStateManager, List<ServerName> onlineServers) {
final Map<TableName, Map<ServerName, List<RegionInfo>>> result = new
HashMap<>();
for (RegionStateNode node : regionsMap.values()) {
+ // DisableTableProcedure first sets the table state to DISABLED and then
force unassigns
+ // the regions in a loop. The balancer should ignore all regions for
tables in DISABLED
+ // state because even if still currently open we expect them to be
offlined very soon.
if (isTableDisabled(tableStateManager, node.getTable())) {
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("Ignoring {} because table is disabled", node);
+ }
continue;
}
- if (node.getRegionInfo().isSplitParent()) {
+ // When balancing, we are only interested in OPEN or OPENING regions.
These can be
+ // expected to remain online until the next balancer iteration or unless
the balancer
+ // decides to move it. Regions in other states are not eligible for
balancing, because
+ // they are closing, splitting, merging, or otherwise already in
transition.
+ if (!node.isInState(State.OPEN, State.OPENING)) {
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("Ignoring {} because region is not OPEN or OPENING", node);
+ }
continue;
}
Map<ServerName, List<RegionInfo>> tableResult =
result.computeIfAbsent(node.getTable(), t -> new HashMap<>());
final ServerName serverName = node.getRegionLocation();
+ // A region in ONLINE or OPENING state should have a location.
if (serverName == null) {
- LOG.info("Skipping, no server for " + node);
+ LOG.warn("Skipping, no server for {}", node);
continue;
}
List<RegionInfo> serverResult =
