Repository: helix
Updated Branches:
  refs/heads/helix-0.6.x 0979dd168 -> 83ca30468


Fix TestClusterVerifier

Full-Auto verifier requires BestPossibleState to be persisted but this
change hasn’t been synced into the code base from LinkedIn Helix yet.
Patch an ad-hoc fix for TestClusterVerifier, in order to publish new
release quickly. This verifier will be synced with LinkedIn Helix later.


Project: http://git-wip-us.apache.org/repos/asf/helix/repo
Commit: http://git-wip-us.apache.org/repos/asf/helix/commit/83ca3046
Tree: http://git-wip-us.apache.org/repos/asf/helix/tree/83ca3046
Diff: http://git-wip-us.apache.org/repos/asf/helix/diff/83ca3046

Branch: refs/heads/helix-0.6.x
Commit: 83ca304686411ca4252d08d0684d4e06931fd544
Parents: 0979dd1
Author: Weihan Kong <[email protected]>
Authored: Mon May 22 15:30:15 2017 -0700
Committer: Weihan Kong <[email protected]>
Committed: Mon May 22 17:17:08 2017 -0700

----------------------------------------------------------------------
 .../tools/ClusterVerifiers/StrictMatchExternalViewVerifier.java    | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/helix/blob/83ca3046/helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/StrictMatchExternalViewVerifier.java
----------------------------------------------------------------------
diff --git 
a/helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/StrictMatchExternalViewVerifier.java
 
b/helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/StrictMatchExternalViewVerifier.java
index 447c5ed..be79444 100644
--- 
a/helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/StrictMatchExternalViewVerifier.java
+++ 
b/helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/StrictMatchExternalViewVerifier.java
@@ -236,6 +236,8 @@ public class StrictMatchExternalViewVerifier extends 
ZkHelixClusterVerifier {
 
     switch (idealState.getRebalanceMode()) {
     case FULL_AUTO:
+      // TODO: need to compute actual IdealState and compare
+      return true;
     case SEMI_AUTO:
     case USER_DEFINED:
       idealPartitionState = computeIdealPartitionState(dataCache, idealState);

Reply via email to