ASF GitHub Bot commented on HELIX-692:

GitHub user zhan849 opened a pull request:


    [HELIX-692] use map instead of list to avoid deleting redundant message 
during cleanup

    Currently in MessageGenerationPhase, we are using list to store messages to 
GC. However, pending message is stored per resource/partition/instance, and 
under batch message mode, same message is stored once for each partition in the 
batch, which lead to the fact that we are cleaning up same message a lot of 
    This RB changes list to map to avoid redundant cleanup

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhan849/helix harry/HELIX-692

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #175
commit ce7d2e9d275e1403375edd94d63afa94ea1a2234
Author: Harry Zhang <zhan849@...>
Date:   2018-04-06T23:27:02Z

    [HELIX-692] use map instead of list to avoid deleting redundant message 
during cleanup


> Use map instead of set in controller's message cleanup logic
> ------------------------------------------------------------
>                 Key: HELIX-692
>                 URL: https://issues.apache.org/jira/browse/HELIX-692
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: Hao Zhang
>            Priority: Major
> This is to avoid duplicated cleans of same message, as under batch message 
> mode, we are storing same message under all resources and therefore causing 
> extra deletion api calls for same message.

This message was sent by Atlassian JIRA

Reply via email to