Repository: helix Updated Branches: refs/heads/master 3ec93129e -> bd171f26d
[HELIX-733] Fix TestAssignableInstanceManagerControllerSwitch This test uses RoutingTableProvider. It was not being shut down, causing an ExecutorService thread to continue executing periodic updates. This RB makes it so that it is shut down at the end of the test. Changelist: 1. Add shutdown() on RoutingTableProvider at the end of the test Project: http://git-wip-us.apache.org/repos/asf/helix/repo Commit: http://git-wip-us.apache.org/repos/asf/helix/commit/bd171f26 Tree: http://git-wip-us.apache.org/repos/asf/helix/tree/bd171f26 Diff: http://git-wip-us.apache.org/repos/asf/helix/diff/bd171f26 Branch: refs/heads/master Commit: bd171f26d164dc33ac91fc393d11de269c2665b0 Parents: 3ec9312 Author: Hunter Lee <[email protected]> Authored: Mon Jul 16 15:02:47 2018 -0700 Committer: Hunter Lee <[email protected]> Committed: Mon Jul 16 15:02:47 2018 -0700 ---------------------------------------------------------------------- .../helix/task/TestAssignableInstanceManagerControllerSwitch.java | 3 +++ 1 file changed, 3 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/helix/blob/bd171f26/helix-core/src/test/java/org/apache/helix/task/TestAssignableInstanceManagerControllerSwitch.java ---------------------------------------------------------------------- diff --git a/helix-core/src/test/java/org/apache/helix/task/TestAssignableInstanceManagerControllerSwitch.java b/helix-core/src/test/java/org/apache/helix/task/TestAssignableInstanceManagerControllerSwitch.java index 21278f2..ca6085e 100644 --- a/helix-core/src/test/java/org/apache/helix/task/TestAssignableInstanceManagerControllerSwitch.java +++ b/helix-core/src/test/java/org/apache/helix/task/TestAssignableInstanceManagerControllerSwitch.java @@ -119,6 +119,9 @@ public class TestAssignableInstanceManagerControllerSwitch extends TaskTestBase Assert.assertEquals(prevTaskAssignResultMap.get(taskID).toString(), taskAssignResultEntry.getValue().toString()); } + + // Shut down RoutingTableProvider so periodic update gets shut down + routingTableProvider.shutdown(); } private void setupAndRunJobs() {
