This is an automated email from the ASF dual-hosted git repository. jxue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/helix.git
commit 7daecd030ca6555f4a7db645761122142c9188d1 Author: narendly <[email protected]> AuthorDate: Tue Feb 26 17:29:40 2019 -0800 [HELIX-811] HELIX: Only log relayMsg if it doesn't exist This log was flooding our log files. We need to change it so that relay messages only get logged once. --- .../org/apache/helix/common/caches/InstanceMessagesCache.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/helix-core/src/main/java/org/apache/helix/common/caches/InstanceMessagesCache.java b/helix-core/src/main/java/org/apache/helix/common/caches/InstanceMessagesCache.java index 21c35af..d936467 100644 --- a/helix-core/src/main/java/org/apache/helix/common/caches/InstanceMessagesCache.java +++ b/helix-core/src/main/java/org/apache/helix/common/caches/InstanceMessagesCache.java @@ -457,13 +457,15 @@ public class InstanceMessagesCache { private void cacheRelayMessage(Message relayMessage, Message hostMessage) { String instanceName = relayMessage.getTgtName(); if (!_relayMessageCache.containsKey(instanceName)) { - _relayMessageCache.put(instanceName, Maps.<String, Message>newHashMap()); + _relayMessageCache.put(instanceName, Maps.<String, Message> newHashMap()); + } + if (!_relayMessageCache.get(instanceName).containsKey(relayMessage.getId())) { + // Only log if the message doesn't already exist in the cache + LOG.info("Add relay message to relay cache " + relayMessage.getMsgId() + ", hosted message " + + hostMessage.getMsgId()); } _relayMessageCache.get(instanceName).put(relayMessage.getId(), relayMessage); _relayHostMessageCache.put(relayMessage.getMsgId(), hostMessage); - - LOG.info("Add relay message to relay cache " + relayMessage.getMsgId() + ", hosted message " - + hostMessage.getMsgId()); } @Override public String toString() {
