This is an automated email from the ASF dual-hosted git repository. hulee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/helix.git
commit 0854c8fba9581b40e341d421969b05e79b29fda4 Author: Jiajun Wang <[email protected]> AuthorDate: Tue Apr 30 15:18:21 2019 -0700 Avoid lock the cache object when require a FullRefresh. The old synchronize control logic will prevent requiring full refresh if a refresh is in progress. This may lead to a slow callback handling.In this change, we remove the original synchronize control. The current cache update logic will be able to handle gradually refreshed data. There is no need to lock the full refresh request. RB=1652941 BUG=HELIX-1851,gcn-29329 G=helix-reviewers A=jxue Signed-off-by: Hunter Lee <[email protected]> --- .../helix/controller/dataproviders/BaseControllerDataProvider.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java b/helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java index da91f97..9402029 100644 --- a/helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java +++ b/helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java @@ -666,7 +666,7 @@ public class BaseControllerDataProvider implements ControlContextProvider { /** * Indicate that a full read should be done on the next refresh */ - public synchronized void requireFullRefresh() { + public void requireFullRefresh() { for (HelixConstants.ChangeType type : HelixConstants.ChangeType.values()) { if (!_noFullRefreshProperty.contains(type)) { _propertyDataChangedMap.put(type, true);
