This is an automated email from the ASF dual-hosted git repository.
hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.wiki.git
The following commit(s) were added to refs/heads/master by this push:
new da53abd Updated Pull Request Checkin Steps (markdown)
da53abd is described below
commit da53abd58e23e9ade198840be0180551481552ef
Author: Hunter Lee <[email protected]>
AuthorDate: Mon Jul 29 10:05:29 2019 -0700
Updated Pull Request Checkin Steps (markdown)
---
Pull-Request-Check-In-Steps.md | 9 +++++++++
Pull-Request-Checkin-Steps.md | 9 ---------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/Pull-Request-Check-In-Steps.md b/Pull-Request-Check-In-Steps.md
new file mode 100644
index 0000000..985e7e8
--- /dev/null
+++ b/Pull-Request-Check-In-Steps.md
@@ -0,0 +1,9 @@
+# Pull Request Check-in Steps
+
+1. Create a PR for review.
+
+2. Address all comments and feedback. You will need at least one approval from
Helix contributors.
+
+3. The author should confirm whether the code is ready to be checked in (for
example, no merge conflicts). Once ready, please leave a comment on the PR
stating "The PR is ready to be merged, xxx approved the PR".
+
+4. Helix PMC/Committers will only merge the **approved** PRs with confirmed
comments and without **any pending comments**.
\ No newline at end of file
diff --git a/Pull-Request-Checkin-Steps.md b/Pull-Request-Checkin-Steps.md
deleted file mode 100644
index 265db74..0000000
--- a/Pull-Request-Checkin-Steps.md
+++ /dev/null
@@ -1,9 +0,0 @@
-# Pull Request Checkin Steps
-
-1. Send PR to github for reviewing.
-
-2. After addressing concerns and comments, you need at least one approval from
Helix contributors.
-
-3. Author should confirm whether the code is ready for checkin. If it is
ready, please leave a comment on the PR stating "The PR is ready to merge, xxx
approved the PR"
-
-4. Helix PMCs/Commiters will merge the **approved** PRs with confirmed
comments and without **any pending comments**.
\ No newline at end of file
