This is an automated email from the ASF dual-hosted git repository.
hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.wiki.git
The following commit(s) were added to refs/heads/master by this push:
new 990ddc3 Updated Pull Request Check In Steps (markdown)
990ddc3 is described below
commit 990ddc33db59475417c2a6f2e58e96b3f49e0408
Author: Hunter Lee <[email protected]>
AuthorDate: Mon Jul 29 11:06:04 2019 -0700
Updated Pull Request Check In Steps (markdown)
---
Pull-Request-Check-In-Steps.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Pull-Request-Check-In-Steps.md b/Pull-Request-Check-In-Steps.md
index e6788c0..d187f38 100644
--- a/Pull-Request-Check-In-Steps.md
+++ b/Pull-Request-Check-In-Steps.md
@@ -2,8 +2,8 @@
1. Create a PR for review.
-2. Address all comments and feedback. You will need at least one approval from
Helix contributors.
+2. Address all comments and feedback. You will need at least one approval from
Helix contributors. In order to become a Helix contributor, one must have made
at least 5 commits to Helix.
-3. The author should confirm whether the code is ready to be checked in (for
example, no merge conflicts). Once ready, please leave a comment on the PR
stating "The PR is ready to be merged, [person who gave an approval, **tag
their GitHub handle using @**] approved the PR".
+3. Leave a final comment on the PR stating "This PR is ready to be merged,
approved by [person who gave an approval, **tag their GitHub handle using @**]".
-4. Helix PMC/Committers will only merge the PRs **no pending comments and an
approval message**.
\ No newline at end of file
+4. Helix PMC/Committers will only merge the PRs with **no pending comments and
with the final approval message**.
\ No newline at end of file
