This is an automated email from the ASF dual-hosted git repository.
jiajunwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git
The following commit(s) were added to refs/heads/master by this push:
new b5cc49e Update pull_request_template.md
b5cc49e is described below
commit b5cc49e86a26fad0d466949b50df7c4ca2311eba
Author: Jiajun Wang <[email protected]>
AuthorDate: Fri Jan 8 23:24:48 2021 -0800
Update pull_request_template.md
As discussed, we are now relying on the Github CI test. So the local mvn
test is no longer a requirement.
I didn't remove the section since it is possible that the CI test may not
run due to some unexpected reasons. In such a case, the guideline is to specify
the known issue and keep running the test locally.
---
.github/pull_request_template.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 4e7cfe2..f2c3025 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -17,9 +17,9 @@ Any of the following keywords can be used: close, closes,
closed, fix, fixes, fi
(List the names of added unit/integration tests)
-- [ ] The following is the result of the "mvn test" command on the appropriate
module:
+- The following is the result of the "mvn test" command on the appropriate
module:
-(Before CI test pass, please copy & paste the result of "mvn test")
+(If CI test fails due to known issue, please specify the issue and test PR
locally. Then copy & paste the result of "mvn test" to here.)
### Documentation (Optional)
