[helix] branch master updated: Fix flaky TestAssignableInstanceManager (#1708)

[jiajunwang]

This is an automated email from the ASF dual-hosted git repository.

jiajunwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new 5c9aa78  Fix flaky TestAssignableInstanceManager (#1708)
5c9aa78 is described below

commit 5c9aa788e2c814d940bf9f8ab56219595c63864e
Author: Neal Sun <nealsun.0...@gmail.com>
AuthorDate: Thu Apr 22 18:19:33 2021 -0700

    Fix flaky TestAssignableInstanceManager (#1708)
    
    This PR enforces ordering of TestAssignableInstanceManager to fix flakiness.
    
    Co-authored-by: Neal Sun <ne...@nesun-mn1.linkedin.biz>
---
 .../java/org/apache/helix/task/TestAssignableInstanceManager.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/helix-core/src/test/java/org/apache/helix/task/TestAssignableInstanceManager.java
 
b/helix-core/src/test/java/org/apache/helix/task/TestAssignableInstanceManager.java
index 8598160..3669ae7 100644
--- 
a/helix-core/src/test/java/org/apache/helix/task/TestAssignableInstanceManager.java
+++ 
b/helix-core/src/test/java/org/apache/helix/task/TestAssignableInstanceManager.java
@@ -116,7 +116,7 @@ public class TestAssignableInstanceManager {
     }
   }
 
-  @Test
+  @Test(dependsOnMethods = "testGetAssignableInstanceMap")
   public void testGetTaskAssignResultMap() {
     Map<String, TaskAssignResult> taskAssignResultMap =
         _assignableInstanceManager.getTaskAssignResultMap();
@@ -125,7 +125,7 @@ public class TestAssignableInstanceManager {
     }
   }
 
-  @Test
+  @Test(dependsOnMethods = "testGetTaskAssignResultMap")
   public void testUpdateAssignableInstances() {
     Map<String, LiveInstance> newLiveInstances = new HashMap<>();
     Map<String, InstanceConfig> newInstanceConfigs = new HashMap<>();