This is an automated email from the ASF dual-hosted git repository.

xyuanlu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new 2eef3f6c3 Fix Metaclient testDataCacheUpdate Flaky Testl (#2705)
2eef3f6c3 is described below

commit 2eef3f6c3d1c186b835aeb1d0cd86b55a13d3bf4
Author: Grant Paláu Spencer <[email protected]>
AuthorDate: Mon Nov 27 09:27:31 2023 -0800

    Fix Metaclient testDataCacheUpdate Flaky Testl (#2705)
---
 .../org/apache/helix/metaclient/impl/zk/TestZkMetaClientCache.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestZkMetaClientCache.java
 
b/meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestZkMetaClientCache.java
index 2950a652e..119af8961 100644
--- 
a/meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestZkMetaClientCache.java
+++ 
b/meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestZkMetaClientCache.java
@@ -49,10 +49,10 @@ public class TestZkMetaClientCache extends 
ZkMetaClientTestBase {
             zkMetaClientCache.create(key, "test");
             zkMetaClientCache.create(key + DATA_PATH, DATA_VALUE);
             // Get data for DATA_PATH and cache it
-            String data = zkMetaClientCache.get(key + DATA_PATH);
-            Assert.assertEquals(data, 
zkMetaClientCache.getDataCacheMap().get(key + DATA_PATH));
             Assert.assertTrue(MetaClientTestUtil.verify(() ->
-                    
(Objects.equals(zkMetaClientCache.getDataCacheMap().get(key + DATA_PATH), 
data)), MetaClientTestUtil.WAIT_DURATION));
+                (Objects.equals(zkMetaClientCache.get(key+DATA_PATH), 
DATA_VALUE)), MetaClientTestUtil.WAIT_DURATION));
+            Assert.assertTrue(MetaClientTestUtil.verify(() ->
+                (Objects.equals(zkMetaClientCache.getDataCacheMap().get(key + 
DATA_PATH), DATA_VALUE)), MetaClientTestUtil.WAIT_DURATION));
 
             // Update data for DATA_PATH
             String newData = zkMetaClientCache.update(key + DATA_PATH, 
currentData -> currentData + "1");

Reply via email to