This is an automated email from the ASF dual-hosted git repository.

jxue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new 04a2400ee increase test assertion timeout (#2926)
04a2400ee is described below

commit 04a2400eef4b32945c2f40ff947b3b29719d4658
Author: Grant Paláu Spencer <gspen...@linkedin.com>
AuthorDate: Wed Sep 25 14:28:09 2024 -0700

    increase test assertion timeout (#2926)
    
    Fix flaky test - testMultipleWrites
---
 .../java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git 
a/helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java
 
b/helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java
index 7e495e922..5dda56c6d 100644
--- 
a/helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java
+++ 
b/helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBucketDataAccessor.java
@@ -142,13 +142,8 @@ public class TestZkBucketDataAccessor extends ZkTestBase {
           List<String> children = _zkBaseDataAccessor.getChildNames(path, 
AccessOption.PERSISTENT);
           return children.size() == 3 && children.containsAll(ImmutableList
               .of(LAST_SUCCESSFUL_WRITE_KEY, LAST_WRITE_KEY, new 
Long(lastSuccessfulWriteVer).toString()));
-        }, VERSION_TTL_MS * 2));
+        }, TestHelper.WAIT_DURATION));
 
-        // Wait one more TTL to ensure that the GC has been done.
-        Thread.sleep(VERSION_TTL_MS);
-        List<String> children = _zkBaseDataAccessor.getChildNames(path, 
AccessOption.PERSISTENT);
-        Assert.assertTrue(children.size() == 3 && 
children.containsAll(ImmutableList
-            .of(LAST_SUCCESSFUL_WRITE_KEY, LAST_WRITE_KEY, new 
Long(lastSuccessfulWriteVer).toString())));
       }
     } finally {
       for (int j = 0; j < pathCount; j++) {

Reply via email to