Code0x58 commented on a change in pull request #3601:
URL: https://github.com/apache/incubator-heron/pull/3601#discussion_r466768647



##########
File path: docker/compile/Dockerfile.ubuntu20.04
##########
@@ -31,12 +31,13 @@ RUN apt-get update && apt-get -y install \
       libunwind8 \
       libcppunit-dev \
       patch \
+      python3 \

Review comment:
       trivia: this is implicit from `python3-dev` 
[[dependencies](https://packages.ubuntu.com/focal/python3-dev)] and 
`python-is-python3`

##########
File path: docker/compile/Dockerfile.ubuntu20.04
##########
@@ -31,12 +31,13 @@ RUN apt-get update && apt-get -y install \
       libunwind8 \
       libcppunit-dev \
       patch \
+      python3 \
       python3-dev \
-      python \
+      python3-pip \

Review comment:
       is this needed for something? pip2/pip3 wasn't included before




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to