joshfischer1108 commented on a change in pull request #3593: URL: https://github.com/apache/incubator-heron/pull/3593#discussion_r471170359
########## File path: release/maven/heron-with-kryo.template.pom ########## @@ -36,7 +36,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/ma <dependency> <groupId>com.esotericsoftware</groupId> <artifactId>kryo</artifactId> - <version>3.0.3</version> + <version>5.0.0-RC9</version> Review comment: It's awesome you worked with them to get this release candidate out for us. 💯 ########## File path: examples/src/java/org/apache/heron/examples/api/AckingTopology.java ########## @@ -60,6 +60,8 @@ public static void main(String[] args) throws Exception { Config conf = new Config(); conf.setDebug(true); + conf.setSerializationClassName(Config.HERON_KRYO_SERIALIZER_CLASS_NAME); + Review comment: It would be good to create an issue for us to try and explain in more detail how Kryo fits into and works with the Heron system. I think it's a bit of a black box at the moment. Doesn't need to be done with this PR. ########## File path: maven_install.json ########## @@ -1,6 +1,6 @@ { "dependency_tree": { - "__AUTOGENERATED_FILE_DO_NOT_MODIFY_THIS_FILE_MANUALLY": -1332813254, + "__AUTOGENERATED_FILE_DO_NOT_MODIFY_THIS_FILE_MANUALLY": -790274667, Review comment: Do we have anything in the documentation that shows how to regenerate this `maven_install` file? Again, doesn't need to be done in this PR. But would be helpful to know more about it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
