nicknezis commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-heron/pull/3669#discussion_r563331830
##########
File path: docker/dist/Dockerfile.dist.centos7
##########
@@ -34,14 +34,15 @@ RUN yum -y install epel-release \
ENV JAVA_HOME /usr/
-ADD artifacts /heron
+# run Heron installer
+RUN --mount=type=bind,source=artifacts,target=/tmp/heron
/tmp/heron/heron-install.sh && \
+ rm /usr/local/heron/dist/heron-core.tar.gz && \
+ rm -rf /opt/heron/heron-core/lib/scheduler/heron-local-scheduler.jar && \
+ rm -rf /opt/heron/heron-core/lib/scheduler/heron-mesos-scheduler.jar && \
+ rm -rf /opt/heron/heron-core/lib/scheduler/heron-slurm-scheduler.jar
Review comment:
Yes I agree. I saw the lines in one of the Dockerfiles and made them
consistent. But I don't know if I like this. It assumes the container if only
used for Kubernetes. I'm not sure if that will always be the case. I can remove
these `rm` statements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
