surahman commented on a change in pull request #3725:
URL: https://github.com/apache/incubator-heron/pull/3725#discussion_r743817138
##########
File path:
heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/V1Controller.java
##########
@@ -130,6 +137,18 @@ boolean submit(PackingPlan packingPlan) {
throw new TopologySubmissionException(e.getMessage());
}
+ // Get and then create Persistent Volume Claims from the CLI.
+ persistentVolumeClaimConfigs =
KubernetesContext.getPersistentVolumeClaims(getConfiguration());
+ if (KubernetesContext.getPersistentVolumeClaimDisabled(getConfiguration())
+ && !persistentVolumeClaimConfigs.isEmpty()) {
+ final String message =
+ String.format("Loading Persistent Volume Claim from CLI is disabled:
'%s'", topologyName);
Review comment:
Your confusion with the `getPersistentVolumeClaims` is case and point
for why Javadoc comments are essential. I have been lazy because the file does
not have any of them. I shall add them to the routines I have created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
