nicknezis commented on pull request #3721: URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-962248948
@windhamwong I made the branch off of `master` branch. I also realized that `helm` was stripping away the comments in the generated `values.yml` file. This issue was documented [here](https://github.com/helm/helm/issues/6951). It's fixed in Helm 3.1.0, so I updated the version of Helm that we are using. I also did some minor refactoring of the values to start aggregating `apiserver`, `tracker` and `ui` sets of properties. I also moved the `apiserver` Service up in `tools.yml` to group it with the other two `Service` definitions. I also mirrored your logic to add `NodePort` support to the other two services. I chose to keep the default behavior with k8s auto picking the NodePort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
