nicknezis commented on pull request #3753:
URL: https://github.com/apache/incubator-heron/pull/3753#issuecomment-1004955471


   > Did you mean to delete the `maven_install.json`? We don't have how this 
plugin works for Heron documented anywhere. Could you add something quick to 
the instructions on compiling Heron in the website so we don't lose track of 
this process/tool?
   
   I didn't delete it. Only refreshed it with the newer version of the 
`rules_jvm_external` build tool. I think the logic for how dependencies are 
ordered changed, so that caused lots of changes in the json file. But that 
should be a one time change due to the newer build tool. 
   
   General information about the pinning is here: 
https://github.com/bazelbuild/rules_jvm_external#pinning-artifacts-and-integration-with-bazels-downloader
   
   With this updated version, if anyone ever updates the dependency list and 
doesn't repin, it will actually fail to compile and give the documentation in 
the console output for how to refresh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to