surahman edited a comment on pull request #3751: URL: https://github.com/apache/incubator-heron/pull/3751#issuecomment-1022547789
There is no `zip_safe` and `resources` in `py_binary`. I have opted to disable `zip_safe` and placed the change in its own commit so it can be dropped if needed. `resources` in [bazel_pex_rules](https://github.com/benley/bazel_rules_pex#pex_binary.data) appears to have switched to calling this `data`: > `List of labels; Optional; Default is []` > > Files to include as resources in the final pex binary. > > Putting other rules here will cause the outputs of those rules to be embedded in this one. Files will be included as-is. Paths in the archive will be relative to the workspace root. I think this may align with [Bazel's](https://docs.bazel.build/versions/main/be/common-definitions.html#typical.data) definition of `data`, but it uses those files at rule runtime: > `List of labels; optional` > > Files needed by this rule at runtime. May list file or rule targets. Generally allows any target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
