surahman commented on pull request #3768: URL: https://github.com/apache/incubator-heron/pull/3768#issuecomment-1037680370
> I think this is still in draft and the checklist not complete, so not sure if this is approvable yet. Just wanted to make sure it wasn't merged in by accident. But I guess the Draft status should help with that. Yes, this is still a WiP. There is a long way to go to completion and the protobuf is currently blocking progress. > I'd like to better understand the refactoring of the protobuf files to this location: https://github.com/surahman/Heron-Protobuf > > @surahman Will this remove the need for the protobuf files to live in this repo? Or was this just a temporary home to figure out the build tooling? It is to isolate development of the protobuf build script and directory structures. It has speed up and greatly declutter the protobuf build script development. The directory structures and build scripts would need to be transplanted into the current Heron build scripts. The issues to consider are whether the import/includes and directory structure within the protobuf libraries these scripts assemble will match what Heron requires. This could become very complicated if it does not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
