nicknezis commented on pull request #3778: URL: https://github.com/apache/incubator-heron/pull/3778#issuecomment-1052563279
Also, this insistence on random "copy" `genrule`s is driving me crazy. Why are they there? It seemed 6 years ago it used to be a `jar_jar` shading process, but that was removed. But instead of removing the target, they changed it to a copy which renames the `unshaded` to `shaded`. Just found this old PR using Git Blame. Happy to finally shed some light on this. But feels like we can clean this up. Doesn't have to be in this PR, but in a futture PR we should remove these random copies. https://github.com/apache/incubator-heron/blob/ebd7ceaeb7cb4aeddf21e8a51a233d53e2afca0d/examples/src/java/BUILD#L17-L22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
