nicknezis commented on a change in pull request #3798:
URL: https://github.com/apache/incubator-heron/pull/3798#discussion_r834929012
##########
File path: deploy/kubernetes/helm/values.yaml.template
##########
@@ -33,6 +33,15 @@ image: apache/heron:VERSION
# Heron image pull policy
imagePullPolicy: IfNotPresent
+# Optional Variables
Review comment:
Let's move these under the `bookkeeper` section (@ line 109). Maybe
insert at the end of that section (@ line 116). You will also need to update
the property names in the yaml to reference `.Values.bookkeeper.*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
