This is an automated email from the ASF dual-hosted git repository. nicknezis pushed a commit to branch nicknezis/cppcheck-update in repository https://gitbox.apache.org/repos/asf/incubator-heron.git
commit 7808e83a5899c89ccfe48e66b51653db8671fbc1 Author: Nicholas Nezis <[email protected]> AuthorDate: Sat Mar 26 00:55:03 2022 -0400 Update to cppcheck 2.7 --- WORKSPACE | 8 +++----- third_party/cppcheck/cppcheck-readdir-fix.patch | 12 ------------ 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 19ec505..5e09596 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -390,11 +390,9 @@ http_archive( http_archive( name = "com_github_danmar_cppcheck", build_file = "@//:third_party/cppcheck/cppcheck.BUILD", - patch_args = ["-p2"], - patches = ["//third_party/cppcheck:cppcheck-readdir-fix.patch"], - sha256 = "cb0e66cbe2d6b655fce430cfaaa74b83ad11c91f221e3926f1ca3211bb7c906b", - strip_prefix = "cppcheck-1.90", - urls = ["https://github.com/danmar/cppcheck/archive/1.90.zip";], + sha256 = "9285bf64af22a07fb24a7431510cc34fba118cf6950190abc2a08c9f7a7084c8", + strip_prefix = "cppcheck-2.7", + urls = ["https://github.com/danmar/cppcheck/archive/refs/tags/2.7.zip";], ) http_archive( diff --git a/third_party/cppcheck/cppcheck-readdir-fix.patch b/third_party/cppcheck/cppcheck-readdir-fix.patch deleted file mode 100644 index bde961a..0000000 --- a/third_party/cppcheck/cppcheck-readdir-fix.patch +++ /dev/null @@ -1,12 +0,0 @@ -diff -Naur cppcheck/cppcheck-1.90/cli/filelister.cpp cppcheck-fixed/cppcheck-1.90/cli/filelister.cpp ---- cppcheck/cppcheck-1.90/cli/filelister.cpp 2020-02-20 22:42:28.000000000 -0500 -+++ cppcheck-fixed/cppcheck-1.90/cli/filelister.cpp 2020-02-20 22:44:48.000000000 -0500 -@@ -194,7 +194,7 @@ - std::string new_path; - new_path.reserve(path.length() + 100);// prealloc some memory to avoid constant new/deletes in loop - -- while ((readdir_r(dir, &entry, &dir_result) == 0) && (dir_result != nullptr)) { -+ while ((dir_result = readdir(dir)) != NULL) { - - if ((std::strcmp(dir_result->d_name, ".") == 0) || - (std::strcmp(dir_result->d_name, "..") == 0))
