surahman commented on code in PR #3786:
URL: https://github.com/apache/incubator-heron/pull/3786#discussion_r845645169
##########
heron/statemgrs/src/python/statemanager.py:
##########
@@ -92,8 +92,8 @@ def is_host_port_reachable(self):
socket.create_connection(hostport, StateManager.TIMEOUT_SECONDS)
return True
except:
- LOG.info("StateManager %s Unable to connect to host: %s port %i"
- % (self.name, hostport[0], hostport[1]))
+ LOG.info("StateManager %s Unable to connect to host: %s port %i",
+ self.name, hostport[0], hostport[1])
Review Comment:
I am not sure but I think the `%i`
[specifier](https://peps.python.org/pep-3101/) might have been deprecated in
Python3. I am not sure if `hostportlist` is a list of integers or strings but
perhaps consider this if they are:
```suggestion
LOG.info("StateManager %s Unable to connect to host: %d port %d",
self.name, hostport[0], hostport[1])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
