surahman commented on PR #3768: URL: https://github.com/apache/incubator-heron/pull/3768#issuecomment-1126989152
I have verified that the generated C++, Java, and Python source files match the expected extensions. **_C++:_** https://github.com/apache/incubator-heron/blob/8d38e0e501f2862a673cf1aa2b4da6e7c8d58787/tools/rules/genproto.bzl#L123-L124 https://github.com/surahman/Heron-Protobuf/blob/23a47cfab36cbed6fe1ca93ba0a1e5b09420409d/proto/api/BUILD.bazel#L24-L25 **_Java:_** https://github.com/apache/incubator-heron/blob/8d38e0e501f2862a673cf1aa2b4da6e7c8d58787/tools/rules/genproto.bzl#L44-L45 https://github.com/surahman/Heron-Protobuf/blob/23a47cfab36cbed6fe1ca93ba0a1e5b09420409d/proto/api/BUILD.bazel#L41 **_Python:_** https://github.com/apache/incubator-heron/blob/8d38e0e501f2862a673cf1aa2b4da6e7c8d58787/tools/rules/genproto.bzl#L160-L161 https://github.com/surahman/Heron-Protobuf/blob/23a47cfab36cbed6fe1ca93ba0a1e5b09420409d/proto/api/BUILD.bazel#L49 The next step is to generate the protocol buffer C++, Java, and Python files from the latest Heron build and the IDL on my repo. There needs to be verification that the file names and directory structure match the expected. Subsequently, the new IDL and build scripts can be transplanted into this branch. There will need to be some build script configurations to kick off the builds for the C++, Java, and Python IDL source files. There might also be a potentially rejigging of the file structure required to match that which is expected by Heron. Is there anyone proficient with Bazel who can assist in getting this PR across the finish line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
