nicknezis commented on PR #3838: URL: https://github.com/apache/incubator-heron/pull/3838#issuecomment-1141305876
> Based on the unit test: `testGenerateFilename`, it seems like the file name is expected to be unique. Interesting, the test still passes. I'll have to dig into it further. But looking in each Uploader, they seem to have logic for uploading a package with the same name. But this logic would never be needed if the intention was to always generate a unique filename. I really think this is a relic from the old Twitter code base. It doesn't seem to provide any value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
