thinker0 commented on code in PR #3830:
URL: https://github.com/apache/incubator-heron/pull/3830#discussion_r887840888


##########
heron/tools/tracker/src/python/topology.py:
##########
@@ -589,30 +601,31 @@ def _update(
       scheduler_location=...,
     ) -> None:
     """Atomically update this instance to avoid inconsistent reads/writes from 
other threads."""

Review Comment:
   ```
   heron update lad/www/beta heron-system-access-prometheus 
--component-parallelism parser:1
   heron update lad/www/beta heron-system-access-prometheus 
--component-parallelism parser:2
   ```
   Lock is required because the above ```_update``` is executed at the same 
time when instance update occurs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to